blacklight-spotlight 0.4.1 → 0.5.0

data/spec/models/spotlight/contact_email_spec.rb

@@ -1,47 +1,51 @@
 require 'spec_helper'
 
-describe Spotlight::ContactEmail, :type => :model do
+describe Spotlight::ContactEmail, type: :model do
   let(:exhibit) { FactoryGirl.create(:exhibit) }
-  subject { Spotlight::ContactEmail.new(exhibit: exhibit) }
+  subject { described_class.new(exhibit: exhibit) }
 
   it { is_expected.not_to be_valid }
 
-  describe "with an invalid email set" do
+  describe 'with an invalid email set' do
     before { subject.email = '@-foo' }
-    it "should not be valid" do
-      expect(subject).to_not be_valid 
+    it 'does not be valid' do
+      expect(subject).to_not be_valid
       expect(subject.errors[:email]).to eq ['is not valid']
     end
   end
 
-  describe "with a valid email set" do
+  describe 'with a valid email set' do
     before { subject.email = 'foo@example.com' }
     it { is_expected.to be_valid }
 
-    describe "when saved" do
-      it "should send a confirmation" do
+    describe 'when saved' do
+      it 'sends a confirmation' do
         expect(subject).to receive(:send_devise_notification)
-        subject.save 
+        subject.save
       end
     end
-    describe "#send_devise_notification" do
-      it "should send stuff" do
-        expect {
-          subject.send(:send_devise_notification, :confirmation_instructions, "Q7PEPdLVxymsQL2_s_Rg", {})
-        }.to change { ActionMailer::Base.deliveries.count }.by(1)
+    describe '#send_devise_notification' do
+      it 'sends stuff' do
+        expect do
+          subject.send(:send_devise_notification, :confirmation_instructions, 'Q7PEPdLVxymsQL2_s_Rg', {})
+        end.to change { ActionMailer::Base.deliveries.count }.by(1)
       end
     end
   end
-  
-  describe ".confirmed" do
-    it "should scope contacts to only confirmed contacts" do
-      a = exhibit.contact_emails.create(:email => 'a@example.com')
-      a.confirm!
-      b = exhibit.contact_emails.create(:email => 'b@example.com')
-      
-      expect(Spotlight::ContactEmail.confirmed.to_a).to include a
-      expect(Spotlight::ContactEmail.confirmed.to_a).to_not include b
+
+  describe '.confirmed' do
+    it 'scopes contacts to only confirmed contacts' do
+      a = exhibit.contact_emails.create(email: 'a@example.com')
+      if a.respond_to? :confirm
+        a.confirm
+      else
+        a.confirm!
+      end
+
+      b = exhibit.contact_emails.create(email: 'b@example.com')
+
+      expect(described_class.confirmed.to_a).to include a
+      expect(described_class.confirmed.to_a).to_not include b
     end
   end
-
 end

data/spec/models/spotlight/contact_spec.rb

@@ -1,22 +1,21 @@
 require 'spec_helper'
 
-describe Spotlight::Contact, :type => :model do
-  
-  context "#show_in_sidebar" do
-    it "should be an attribute" do
+describe Spotlight::Contact, type: :model do
+  context '#show_in_sidebar' do
+    it 'is an attribute' do
       subject.show_in_sidebar = false
       subject.save
       expect(subject.show_in_sidebar).to be_falsey
     end
-    it "should be published by default" do
+    it 'is published by default' do
       subject.save
       expect(subject.show_in_sidebar).to be_truthy
     end
   end
-  context "#fields" do
+  context '#fields' do
     it 'show allow new fields to be configured' do
       expect(subject.class.fields).to_not have_key(:new_field)
-      Spotlight::Contact.fields[:new_field] = {}
+      described_class.fields[:new_field] = {}
       expect(subject.class.fields).to have_key(:new_field)
     end
   end

data/spec/models/spotlight/custom_field_spec.rb

@@ -1,62 +1,62 @@
 require 'spec_helper'
 
-describe Spotlight::CustomField, :type => :model do
-  describe "#label" do
-    subject { Spotlight::CustomField.new configuration: { "label" => "the configured label"}, field: 'foo_tesim' }
+describe Spotlight::CustomField, type: :model do
+  describe '#label' do
+    subject { described_class.new configuration: { 'label' => 'the configured label' }, field: 'foo_tesim' }
     describe "when the exhibit doesn't have a config" do
-      its(:label) { should eq "the configured label"}
+      its(:label) { should eq 'the configured label' }
     end
 
-    describe "when the exhibit has a config" do
+    describe 'when the exhibit has a config' do
       let(:exhibit) { FactoryGirl.create(:exhibit) }
       before { subject.exhibit = exhibit }
-      describe "that overrides the label" do
+      describe 'that overrides the label' do
         before do
-          exhibit.blacklight_configuration.index_fields['foo_tesim'] = { 'label' => "overridden" }
+          exhibit.blacklight_configuration.index_fields['foo_tesim'] = { 'label' => 'overridden' }
         end
-        its(:label) { should eq "overridden"}
+        its(:label) { should eq 'overridden' }
       end
       describe "that doesn't override the label" do
-        its(:label) { should eq "the configured label"}
+        its(:label) { should eq 'the configured label' }
       end
     end
   end
 
-  describe "#label=" do
-    subject { Spotlight::CustomField.new  field: 'foo_tesim' }
+  describe '#label=' do
+    subject { described_class.new field: 'foo_tesim' }
     describe "when the exhibit doesn't have a config" do
       before { subject.label = 'the configured label' }
-      its(:configuration) { should eq({ 'label' => "the configured label" }) }
+      its(:configuration) { should eq('label' => 'the configured label') }
     end
 
-    describe "when the exhibit has a config" do
+    describe 'when the exhibit has a config' do
       let(:exhibit) { FactoryGirl.create(:exhibit) }
       before { subject.exhibit = exhibit }
-      describe "that overrides the label" do
+      describe 'that overrides the label' do
         before do
-          exhibit.blacklight_configuration.index_fields['foo_tesim'] = { 'label' => "overridden" }
+          exhibit.blacklight_configuration.index_fields['foo_tesim'] = { 'label' => 'overridden' }
           subject.label = 'edited'
         end
-        it "should have updated the exhibit" do
+        it 'has updated the exhibit' do
           expect(subject.exhibit.blacklight_configuration.index_fields['foo_tesim']['label']).to eq 'edited'
         end
       end
     end
   end
 
-  describe "#field" do
+  describe '#field' do
     let(:exhibit) { FactoryGirl.create(:exhibit) }
-    it "should be auto-generated from the field label" do
-      subject.configuration["label"] = "xyz"
+    it 'is auto-generated from the field label' do
+      subject.configuration['label'] = 'xyz'
       subject.exhibit = exhibit
       subject.save
 
       expect(subject.field).to eq "exhibit_#{exhibit.to_param}_xyz_tesim"
     end
 
-    it "should use the solr field prefix" do
-      allow(Spotlight::Engine.config.solr_fields).to receive(:prefix).and_return "prefix_"
-      subject.configuration["label"] = "xyz"
+    it 'uses the solr field prefix' do
+      allow(Spotlight::Engine.config.solr_fields).to receive(:prefix).and_return 'prefix_'
+      subject.configuration['label'] = 'xyz'
       subject.exhibit = exhibit
       subject.save
 
@@ -67,90 +67,89 @@ describe Spotlight::CustomField, :type => :model do
   describe '#configured_to_display?' do
     let(:exhibit) { FactoryGirl.create(:exhibit) }
     before do
-      exhibit.blacklight_configuration.blacklight_config.view = {view_name: {}}
+      exhibit.blacklight_configuration.blacklight_config.view = { view_name: {} }
       subject.exhibit = exhibit
-      subject.label = "Label"
+      subject.label = 'Label'
       subject.field = 'foo_tesim'
     end
-    it 'should be truthy when a view has been configured true' do
+    it 'is truthy when a view has been configured true' do
       exhibit.blacklight_configuration.blacklight_config.index_fields['foo_tesim'] =
-        Blacklight::Configuration::IndexField.new(label: "Label", enabled: true, view_name: true)
+        Blacklight::Configuration::IndexField.new(label: 'Label', enabled: true, view_name: true)
       subject.save
 
       expect(subject).to be_configured_to_display
     end
-    it 'should be truthey for show views when enabled' do
+    it 'is truthey for show views when enabled' do
       exhibit.blacklight_configuration.blacklight_config.index_fields['foo_tesim'] =
-        Blacklight::Configuration::IndexField.new(label: "Label", enabled: true, show: true)
+        Blacklight::Configuration::IndexField.new(label: 'Label', enabled: true, show: true)
       subject.save
 
       expect(subject).to be_configured_to_display
     end
-    it 'should be falsey when a few has not been configured true' do
+    it 'is falsey when a few has not been configured true' do
       exhibit.blacklight_configuration.blacklight_config.index_fields['foo_tesim'] =
-        Blacklight::Configuration::IndexField.new(label: "Label", enabled: true, view_name: false)
+        Blacklight::Configuration::IndexField.new(label: 'Label', enabled: true, view_name: false)
       subject.save
 
       expect(subject).to_not be_configured_to_display
     end
-    it 'should be falsey when the field is not enabled' do
-      exhibit.blacklight_configuration.index_fields['foo_tesim'] = { 'label' => "overridden", enabled: false, view_name: false } 
+    it 'is falsey when the field is not enabled' do
+      exhibit.blacklight_configuration.index_fields['foo_tesim'] = { 'label' => 'overridden', enabled: false, view_name: false }
       subject.save
 
       expect(subject).to_not be_configured_to_display
     end
   end
 
-  describe "#field_name" do
-    let(:exhibit) { double(to_param: "a") }
+  describe '#field_name' do
+    let(:exhibit) { double(to_param: 'a') }
 
     before do
-      subject.label = "xyz"
+      subject.label = 'xyz'
     end
 
-    it "should end in the text suffix if it is a text field" do
-      subject.field_type = "text"
+    it 'ends in the text suffix if it is a text field' do
+      subject.field_type = 'text'
       expect(subject.send(:field_name)).to end_with Spotlight::Engine.config.solr_fields.text_suffix
     end
 
-    it "should end in a string suffix if it is a vocab field" do
-      subject.field_type = "vocab"
+    it 'ends in a string suffix if it is a vocab field' do
+      subject.field_type = 'vocab'
       expect(subject.send(:field_name)).to end_with Spotlight::Engine.config.solr_fields.string_suffix
     end
   end
 
-  describe "changing the field type" do
+  describe 'changing the field type' do
     let(:exhibit) { FactoryGirl.create(:exhibit) }
     before do
-      subject.label = "xyz"
+      subject.label = 'xyz'
       subject.exhibit = exhibit
       subject.save!
     end
 
-    it "should change the field name for the field" do
-      expect(subject.field).to end_with "tesim"
-      subject.field_type = "vocab"
+    it 'changes the field name for the field' do
+      expect(subject.field).to end_with 'tesim'
+      subject.field_type = 'vocab'
       subject.save
-      expect(subject.field).to end_with "ssim"
+      expect(subject.field).to end_with 'ssim'
     end
 
-    it "should copy index field configuration to the new field name" do
+    it 'copies index field configuration to the new field name' do
       subject.exhibit.blacklight_configuration.index_fields_will_change!
       subject.exhibit.blacklight_configuration.index_fields[subject.field] = { value: true }
       subject.exhibit.blacklight_configuration.save
       expect(subject.exhibit.blacklight_configuration.index_fields).to have_key subject.field
 
-      subject.field_type = "vocab"
+      subject.field_type = 'vocab'
       subject.save
       expect(subject.exhibit.blacklight_configuration.index_fields).to have_key subject.field
       expect(subject.exhibit.blacklight_configuration.index_fields[subject.field]).to include value: true
     end
-    
-    it "should queue a job to reindex any documents with data in the old field" do
-      expect(Spotlight::RenameSidecarFieldJob).to receive(:perform_later).with(exhibit, subject.field, subject.field.sub("tesim", "ssim"))
-      subject.field_type = "vocab"
+
+    it 'queues a job to reindex any documents with data in the old field' do
+      expect(Spotlight::RenameSidecarFieldJob).to receive(:perform_later).with(exhibit, subject.field, subject.field.sub('tesim', 'ssim'))
+      subject.field_type = 'vocab'
       subject.save
     end
   end
-
 end

data/spec/models/spotlight/exhibit_spec.rb

@@ -1,170 +1,212 @@
 require 'spec_helper'
 
-describe Spotlight::Exhibit, :type => :model do
-  subject { Spotlight::Exhibit.new(title: "Sample") }
+describe Spotlight::Exhibit, type: :model do
+  subject { FactoryGirl.build(:exhibit, title: 'Sample') }
 
-  it "should have a title" do
-    subject.title = "Test title"
-    expect(subject.title).to eq "Test title"
+  it 'has a title' do
+    subject.title = 'Test title'
+    expect(subject.title).to eq 'Test title'
   end
 
-  it "should have a subtitle" do
-    subject.subtitle = "Test subtitle"
-    expect(subject.subtitle).to eq "Test subtitle"
+  it 'has a subtitle' do
+    subject.subtitle = 'Test subtitle'
+    expect(subject.subtitle).to eq 'Test subtitle'
   end
 
-  it "should have a description that strips html tags" do
-    subject.description = "Test <b>description</b>"
+  it 'has a description that strips html tags' do
+    subject.description = 'Test <b>description</b>'
     subject.save!
-    expect(subject.description).to eq "Test description"
+    expect(subject.description).to eq 'Test description'
   end
-  describe "contact_emails" do
+  describe 'contact_emails' do
     before do
-      subject.contact_emails_attributes= [ { "email"=>"chris@example.com"}, {"email"=>"jesse@stanford.edu"}]
+      subject.contact_emails_attributes = [{ 'email' => 'chris@example.com' }, { 'email' => 'jesse@stanford.edu' }]
     end
-    it "should accept nested contact_emails" do
+    it 'accepts nested contact_emails' do
       expect(subject.contact_emails.size).to eq 2
     end
   end
 
-  it "should have a #to_s" do
-    expect(subject.to_s).to eq "Sample"
-    subject.title = "New Title"
-    expect(subject.to_s).to eq "New Title"
+  it 'has a #to_s' do
+    expect(subject.to_s).to eq 'Sample'
+    subject.title = 'New Title'
+    expect(subject.to_s).to eq 'New Title'
   end
 
-  describe "that is saved" do
-    before { subject.save!  }
+  describe 'that is saved' do
+    before { subject.save! }
 
-    it "should have a configuration" do
+    it 'has a configuration' do
       expect(subject.blacklight_configuration).to be_kind_of Spotlight::BlacklightConfiguration
     end
 
-    it "should have an unpublished search" do
+    it 'has an unpublished search' do
       expect(subject.searches).to have(1).search
       expect(subject.searches.published).to be_empty
       expect(subject.searches.first.query_params).to be_empty
     end
-
   end
 
-  describe "#main_navigations" do
-    subject { Spotlight::Exhibit.new(title: "Sample").tap(&:save!)  }
-    it "should have main navigations" do
+  describe '#main_navigations' do
+    subject { FactoryGirl.create(:exhibit, title: 'Sample') }
+    it 'has main navigations' do
       expect(subject.main_navigations).to have(3).main_navigations
       expect(subject.main_navigations.map(&:label).compact).to be_blank
       expect(subject.main_navigations.map(&:weight)).to eq [0, 1, 2]
     end
-    it "should use the engine's configuration for default navigations" do
-      expect(Spotlight::Engine.config).to receive(:exhibit_main_navigation).and_return([:a,:b])
+    it "uses the engine's configuration for default navigations" do
+      expect(Spotlight::Engine.config).to receive(:exhibit_main_navigation).and_return([:a, :b])
       expect(subject.main_navigations).to have(2).main_navigations
-      expect(subject.main_navigations.map(&:nav_type).compact).to match_array ["a", "b"]
+      expect(subject.main_navigations.map(&:nav_type).compact).to match_array %w(a b)
     end
   end
 
-  describe "contacts" do
+  describe 'contacts' do
     before do
-      subject.contacts_attributes= [
-        {"show_in_sidebar"=>"0", "name"=>"Justin Coyne", "contact_info" => {"email"=>"jcoyne@justincoyne.com", "title"=>"", "location"=>"US"}},
-        {"show_in_sidebar"=>"0", "name"=>"", "contact_info" => {"email"=>"", "title"=>"Librarian", "location"=>""}}]
+      subject.contacts_attributes = [
+        { 'show_in_sidebar' => '0', 'name' => 'Justin Coyne', 'contact_info' => { 'email' => 'jcoyne@justincoyne.com', 'title' => '', 'location' => 'US' } },
+        { 'show_in_sidebar' => '0', 'name' => '', 'contact_info' => { 'email' => '', 'title' => 'Librarian', 'location' => '' } }]
     end
-    it "should accept nested contacts" do
+    it 'accepts nested contacts' do
       expect(subject.contacts.size).to eq 2
     end
   end
 
-  describe "import" do
-    it "should remove the default browse category" do
+  describe 'import' do
+    it 'removes the default browse category' do
       subject.save
-      expect { subject.import({}) }.to change {subject.searches.count}.by(0)
-      expect { subject.import({"searches" => [{"title" => "All Exhibit Items","slug" => "all-exhibit-items"}]}) }.to change {subject.searches.count}.by(0)
+      expect { subject.import({}) }.to change { subject.searches.count }.by(0)
+      expect { subject.import('searches' => [{ 'title' => 'All Exhibit Items', 'slug' => 'all-exhibit-items' }]) }.to change { subject.searches.count }.by(0)
     end
 
-    it "should import nested attributes from the hash" do
+    it 'imports nested attributes from the hash' do
       subject.save
       subject.import 'title' => 'xyz'
       expect(subject.title).to eq 'xyz'
     end
 
-    it "should munge taggings so they can be imported easily" do
+    it 'munges taggings so they can be imported easily' do
       expect do
-        subject.import("owned_taggings"=>[{"taggable_id"=>"1", "taggable_type"=>"SolrDocument", "context"=>"tags", "tag"=>"xyz"}])
+        subject.import('owned_taggings' => [{ 'taggable_id' => '1', 'taggable_type' => 'SolrDocument', 'context' => 'tags', 'tag' => 'xyz' }])
         subject.save
       end.to change { subject.owned_taggings.count }.by(1)
       tag = subject.owned_taggings.last
-      expect(tag.taggable_id).to eq "1"
-      expect(tag.tag.name).to eq "xyz"
+      expect(tag.taggable_id).to eq '1'
+      expect(tag.tag.name).to eq 'xyz'
+    end
+
+    describe 'importing with the default attribute' do
+      before do
+        described_class.where(default: true).delete_all
+      end
+
+      it 'imports and sets the exhibit as the default exhibit' do
+        subject.import 'default' => true
+        subject.save
+
+        expect(described_class.default).to eq subject
+      end
+
+      it 'ignores the default flag if a default exhibit exists' do
+        FactoryGirl.create(:exhibit, default: true)
+        expect(described_class.default).to be_persisted
+
+        subject.import 'default' => true
+        subject.save
+
+        expect(described_class.default).not_to eq subject
+      end
     end
   end
 
-  describe "#blacklight_config" do
+  describe '#blacklight_config' do
     subject { FactoryGirl.create(:exhibit) }
     before do
-      subject.blacklight_configuration.index = { timestamp_field:  "timestamp_field" }
+      subject.blacklight_configuration.index = { timestamp_field: 'timestamp_field' }
       subject.save!
       subject.reload
     end
 
-    it "should create a blacklight_configuration from the database" do
+    it 'creates a blacklight_configuration from the database' do
       expect(subject.blacklight_config.index.timestamp_field).to eq 'timestamp_field'
     end
   end
 
-  describe "#destroy" do
+  describe '#destroy' do
     subject { FactoryGirl.create(:exhibit) }
     let(:default_exhibit) { double }
-    it "should touch the default exhibit when it is destroyed" do
-      allow(Spotlight::Exhibit).to receive_messages(default: default_exhibit)
+    it 'touches the default exhibit when it is destroyed' do
+      allow(described_class).to receive_messages(default: default_exhibit)
       expect(default_exhibit).to receive(:touch)
       subject.destroy
     end
   end
 
-  describe "#solr_data" do
+  describe '#solr_data' do
     subject { FactoryGirl.create(:exhibit) }
 
-    it "should provide a solr field with the exhibit slug" do
+    it 'provides a solr field with the exhibit slug' do
       expect(subject.solr_data).to include(:"spotlight_exhibit_slug_#{subject.slug}_bsi" => true)
     end
   end
 
-  describe "#analytics" do
+  describe '#analytics' do
     subject { FactoryGirl.create(:exhibit) }
-    let(:ga_data) { OpenStruct.new(pageviews: 123)}
+    let(:ga_data) { OpenStruct.new(pageviews: 123) }
 
     before do
       allow(Spotlight::Analytics::Ga).to receive(:enabled?).and_return(true)
       allow(Spotlight::Analytics::Ga).to receive(:exhibit_data).with(subject, hash_including(:start_date)).and_return(ga_data)
     end
 
-    it "should request analytics data" do
+    it 'requests analytics data' do
       expect(subject.analytics.pageviews).to eq 123
     end
   end
 
-  describe "#page_analytics" do
+  describe '#page_analytics' do
     subject { FactoryGirl.create(:exhibit) }
-    let(:ga_data) { [OpenStruct.new(pageviews: 123)]}
+    let(:ga_data) { [OpenStruct.new(pageviews: 123)] }
 
     before do
       allow(Spotlight::Analytics::Ga).to receive(:enabled?).and_return(true)
       allow(Spotlight::Analytics::Ga).to receive(:page_data).with(subject, hash_including(:start_date)).and_return(ga_data)
     end
 
-    it "should request analytics data" do
+    it 'requests analytics data' do
       expect(subject.page_analytics.length).to eq 1
       expect(subject.page_analytics.first.pageviews).to eq 123
     end
   end
 
-  describe "#reindex_later" do
+  describe '#reindex_later' do
     subject { FactoryGirl.create(:exhibit) }
 
-    it "should queue a reindex job for the exhibit" do
+    it 'queues a reindex job for the exhibit' do
       expect(Spotlight::ReindexJob).to receive(:perform_later).with(subject)
       subject.reindex_later
     end
-
   end
 
+  describe '.default?' do
+    context 'without a default exhibit' do
+      before do
+        described_class.where(default: true).delete_all
+      end
+
+      it 'is false' do
+        expect(described_class.default?).to eq false
+      end
+    end
+
+    context 'with a default exhibit' do
+      before do
+        described_class.default
+      end
+
+      it 'is true' do
+        expect(described_class.default?).to eq true
+      end
+    end
+  end
 end