blacklight-spotlight 0.4.1 → 0.5.0

data/spec/features/javascript/about_page_admin_spec.rb

@@ -1,11 +1,11 @@
-require "spec_helper"
+require 'spec_helper'
 
-feature "About Pages Adminstration", js: true do
-  let(:exhibit) { FactoryGirl.create(:exhibit) }
+feature 'About Pages Adminstration', js: true do
+  let(:exhibit) { FactoryGirl.create(:default_exhibit) }
   let(:exhibit_curator) { FactoryGirl.create(:exhibit_curator, exhibit: exhibit) }
   before { login_as exhibit_curator }
 
-  it "should be able to create new pages" do
+  it 'is able to create new pages' do
     login_as exhibit_curator
 
     visit spotlight.exhibit_home_page_path(exhibit, exhibit.home_page)
@@ -15,12 +15,12 @@ feature "About Pages Adminstration", js: true do
       click_link 'Dashboard'
     end
 
-    click_link "About pages"
+    click_link 'About pages'
 
-    add_new_page_via_button("My New Page")
+    add_new_page_via_button('My New Page')
 
-    expect(page).to have_content "The about page was created."
-    expect(page).to have_css("li.dd-item")
-    expect(page).to have_css("h3", text: "My New Page")
+    expect(page).to have_content 'The about page was created.'
+    expect(page).to have_css('li.dd-item')
+    expect(page).to have_css('h3', text: 'My New Page')
   end
 end

data/spec/features/javascript/block_controls_spec.rb

@@ -1,44 +1,42 @@
-require "spec_helper"
+require 'spec_helper'
 
-feature "Block controls" do
-  let(:exhibit) { FactoryGirl.create(:exhibit) }
+feature 'Block controls' do
+  let(:exhibit) { FactoryGirl.create(:default_exhibit) }
   let(:exhibit_curator) { FactoryGirl.create(:exhibit_curator, exhibit: exhibit) }
   before { login_as exhibit_curator }
 
-  scenario "should be split into separate sections", js: true do
+  scenario 'should be split into separate sections', js: true do
     # create page
     visit spotlight.exhibit_home_page_path(exhibit, exhibit.home_page)
     click_link exhibit_curator.email
     within '#user-util-collapse .dropdown' do
       click_link 'Dashboard'
     end
-    click_link "Feature pages"
+    click_link 'Feature pages'
 
-    add_new_page_via_button("My New Feature Page")
+    add_new_page_via_button('My New Feature Page')
 
-    expect(page).to have_css("h3", text: "My New Feature Page")
+    expect(page).to have_css('h3', text: 'My New Feature Page')
 
-    expect(page).to have_content("The feature page was created.")
-    within("li.dd-item") do
-      click_link "Edit"
+    expect(page).to have_content('The feature page was created.')
+    within('li.dd-item') do
+      click_link 'Edit'
     end
     # fill in title
-    fill_in "feature_page_title", :with => "Exhibit Title"
+    fill_in 'feature_page_title', with: 'Exhibit Title'
     # click to add widget
-    add_widget
+    click_add_widget
 
     within('.st-block-controls') do
-      expect(page).to have_css(".st-controls-group", count: 2)
+      expect(page).to have_css('.st-controls-group', count: 2)
       within(first('.st-controls-group')) do
-        expect(page).to have_content "Standard widgets"
+        expect(page).to have_content 'Standard widgets'
         expect(page).to have_css('a.st-block-control')
       end
       within(all('.st-controls-group').last) do
-        expect(page).to have_content "Exhibit item widgets"
+        expect(page).to have_content 'Exhibit item widgets'
         expect(page).to have_css('a.st-block-control')
       end
     end
-
-
   end
-end
+end

data/spec/features/javascript/blocks/featured_browse_categories_block_spec.rb

@@ -1,12 +1,12 @@
-require "spec_helper"
+require 'spec_helper'
 
-describe "Featured Browse Category Block", type: :feature, js: true do
-  let(:exhibit) { FactoryGirl.create(:exhibit) }
+describe 'Featured Browse Category Block', type: :feature, js: true do
+  let(:exhibit) { FactoryGirl.create(:default_exhibit) }
   let(:exhibit_curator) { FactoryGirl.create(:exhibit_curator, exhibit: exhibit) }
 
   let!(:feature_page) { FactoryGirl.create(:feature_page, exhibit: exhibit) }
-  let!(:search1) { FactoryGirl.create(:published_search, exhibit: exhibit, title: "Title1", on_landing_page: true) }
-  let!(:search2) { FactoryGirl.create(:published_search, exhibit: exhibit, title: "Title2", on_landing_page: true) }
+  let!(:search1) { FactoryGirl.create(:published_search, exhibit: exhibit, title: 'Title1', published: true) }
+  let!(:search2) { FactoryGirl.create(:published_search, exhibit: exhibit, title: 'Title2', published: true) }
 
   before do
     login_as exhibit_curator
@@ -15,16 +15,16 @@ describe "Featured Browse Category Block", type: :feature, js: true do
     add_widget 'browse'
   end
 
-  it "should allow a curator to select from existing browse categories" do
-    check "Include item counts?"
+  it 'allows a curator to select from existing browse categories' do
+    check 'Include item counts?'
+
+    fill_in_typeahead_field with: 'Title1'
 
-    fill_in_typeahead_field with: "Title1"
-    
     within(:css, '.panel') do
-      uncheck "Display?"
+      uncheck 'Display?'
     end
 
-    fill_in_typeahead_field with: "Title2"
+    fill_in_typeahead_field with: 'Title2'
 
     save_page
 
@@ -32,6 +32,5 @@ describe "Featured Browse Category Block", type: :feature, js: true do
     expect(page).not_to have_css('.category-title', text: search1.title)
     expect(page).to have_css('.category-title', text: search2.title)
     expect(page).to have_css('.item-count', text: /\d+ items/i)
-
   end
 end

data/spec/features/javascript/blocks/featured_pages_block_spec.rb

@@ -1,14 +1,14 @@
-require "spec_helper"
+require 'spec_helper'
 
-describe "Featured Pages Blocks", type: :feature do
-  let(:exhibit) { FactoryGirl.create(:exhibit) }
-  let!(:feature_page) {
+describe 'Featured Pages Blocks', type: :feature do
+  let(:exhibit) { FactoryGirl.create(:default_exhibit) }
+  let!(:feature_page) do
     FactoryGirl.create(
       :feature_page,
-      title: "xyz",
+      title: 'xyz',
       exhibit: exhibit
     )
-  }
+  end
 
   let(:exhibit_curator) { FactoryGirl.create(:exhibit_curator, exhibit: exhibit) }
 
@@ -16,18 +16,17 @@ describe "Featured Pages Blocks", type: :feature do
     login_as exhibit_curator
   end
 
-  it 'should save the selected exhibits', js: true do
+  it 'saves the selected exhibits', js: true do
     visit spotlight.exhibit_home_page_path(exhibit, exhibit.home_page)
 
-    click_link("Edit")
+    click_link('Edit')
 
     add_widget 'featured_pages'
-    
-    fill_in_typeahead_field with: "xyz"
-    
+
+    fill_in_typeahead_field with: 'xyz'
+
     save_page
 
-    expect(page).to have_content "xyz"
+    expect(page).to have_content 'xyz'
   end
-
 end

data/spec/features/javascript/blocks/search_result_block_spec.rb

@@ -1,41 +1,41 @@
-require "spec_helper"
+require 'spec_helper'
 
-describe "Search Result Block", type: :feature, js: true do
-  let(:exhibit) { FactoryGirl.create(:exhibit) }
+describe 'Search Result Block', type: :feature, js: true do
+  let(:exhibit) { FactoryGirl.create(:default_exhibit) }
   let(:exhibit_curator) { FactoryGirl.create(:exhibit_curator, exhibit: exhibit) }
 
   let!(:feature_page) { FactoryGirl.create(:feature_page, exhibit: exhibit) }
-  let!(:alt_search) { FactoryGirl.create(:search, title: "Alt. Search", exhibit: exhibit) }
+  let!(:alt_search) { FactoryGirl.create(:search, title: 'Alt. Search', exhibit: exhibit) }
 
   before do
     login_as exhibit_curator
 
-    exhibit.searches.each { |x| x.on_landing_page = true; x.save }
+    exhibit.searches.each { |x| x.update published: true }
 
     visit spotlight.edit_exhibit_feature_page_path(exhibit, feature_page)
     add_widget 'search_results'
   end
 
-  it "should allow a curator to select from existing browse categories" do
-    fill_in_typeahead_field with: "All Exhibit Items"
+  it 'allows a curator to select from existing browse categories' do
+    fill_in_typeahead_field with: 'All Exhibit Items'
 
-    check "Gallery"
-    check "Slideshow"
+    check 'Gallery'
+    check 'Slideshow'
 
     save_page
 
-    expect(page).not_to have_content "per page"
-    expect(page).not_to have_content "Sort by"
-    
+    expect(page).not_to have_content 'per page'
+    expect(page).not_to have_content 'Sort by'
+
     # The two configured view types should be
     # present and the one not selected should not be
-    within(".view-type-group") do
-      expect(page).not_to have_css(".view-type-list")
-      expect(page).to     have_css(".view-type-gallery")
-      expect(page).to     have_css(".view-type-slideshow")
+    within('.view-type-group') do
+      expect(page).not_to have_css('.view-type-list')
+      expect(page).to have_css('.view-type-gallery')
+      expect(page).to have_css('.view-type-slideshow')
     end
 
     # Documents should exist
-    expect(page).to have_css(".documents .document")
+    expect(page).to have_css('.documents .document')
   end
 end

data/spec/features/javascript/blocks/solr_documents_block_spec.rb

@@ -1,12 +1,12 @@
-require "spec_helper"
+require 'spec_helper'
 
-feature "Solr Document Block", feature: true do
-  let(:exhibit) { FactoryGirl.create(:exhibit) }
+feature 'Solr Document Block', feature: true do
+  let(:exhibit) { FactoryGirl.create(:default_exhibit) }
   let(:exhibit_curator) { FactoryGirl.create(:exhibit_curator, exhibit: exhibit) }
   let(:feature_page) do
     FactoryGirl.create(
       :feature_page,
-      title: "FeaturePage1",
+      title: 'FeaturePage1',
       exhibit: exhibit
     )
   end
@@ -17,17 +17,18 @@ feature "Solr Document Block", feature: true do
     add_widget 'solr_documents'
   end
 
-  scenario "it should allow you to add the solr document block widget", js: true do
-    expect(page).to have_content "This widget displays exhibit items in a horizontal row. Optionally, you can add a heading and/or text to be displayed adjacent to the items."
-    expect(page).to have_content "Primary caption"
-    expect(page).to have_content "Secondary caption"
-    expect(page).to have_content "Display text on"
-    expect(page).to have_content "Heading"
-    expect(page).to have_content "Text"
+  scenario 'it should allow you to add the solr document block widget', js: true do
+    expect(page).to have_content 'This widget displays exhibit items in a horizontal row.'
+    expect(page).to have_content 'Optionally, you can add a heading and/or text to be displayed adjacent to the items.'
+    expect(page).to have_content 'Primary caption'
+    expect(page).to have_content 'Secondary caption'
+    expect(page).to have_content 'Display text on'
+    expect(page).to have_content 'Heading'
+    expect(page).to have_content 'Text'
   end
 
-  scenario "it should allow you to add a solr document to the widget", js: true do
-    fill_in_typeahead_field with: "dq287tq6352"
+  scenario 'it should allow you to add a solr document to the widget', js: true do
+    fill_in_typeahead_field with: 'dq287tq6352'
     within(:css, '.panel') do
       expect(page).to have_content "L'AMERIQUE"
     end
@@ -35,130 +36,131 @@ feature "Solr Document Block", feature: true do
     save_page
 
     # verify that the item + image widget is displaying an image from the document.
-    within(:css, ".items-block") do
-      expect(page).to have_css(".thumbnail")
-      expect(page).to have_css(".thumbnail a img")
-      expect(page).not_to have_css(".title")
+    within(:css, '.items-block') do
+      expect(page).to have_css('.thumbnail')
+      expect(page).to have_css('.thumbnail a img')
+      expect(page).not_to have_css('.title')
     end
   end
 
-  scenario "it should allow you to add multiple solr documents to the widget", js: true do
-    fill_in_typeahead_field with: "dq287tq6352"
-    fill_in_typeahead_field with: "gk446cj2442"
+  scenario 'it should allow you to add multiple solr documents to the widget', js: true do
+    fill_in_typeahead_field with: 'dq287tq6352'
+    fill_in_typeahead_field with: 'gk446cj2442'
 
     save_page
 
-    expect(page).to have_selector ".items-block .box", count: 2
+    expect(page).to have_selector '.items-block .box', count: 2
   end
 
-  scenario "it should allow you toggle visibility of solr documents", js: true do
-    fill_in_typeahead_field with: "dq287tq6352"
+  scenario 'it should allow you toggle visibility of solr documents', js: true do
+    fill_in_typeahead_field with: 'dq287tq6352'
 
     within(:css, '.panel') do
-      uncheck "Display?"
+      uncheck 'Display?'
     end
 
-    fill_in_typeahead_field with: "gk446cj2442"
+    fill_in_typeahead_field with: 'gk446cj2442'
 
     # display the title as the primary caption
     within('.primary-caption') do
-      check("Primary caption")
-      select("Title", from: 'primary-caption-field')
+      check('Primary caption')
+      select('Title', from: 'primary-caption-field')
     end
 
     save_page
 
-    expect(page).to have_selector ".items-block .box", count: 1
-    expect(page).to have_content "[World map]"
+    expect(page).to have_selector '.items-block .box', count: 1
+    expect(page).to have_content '[World map]'
     expect(page).not_to have_content "L'AMERIQUE"
   end
 
-  scenario "should allow you to optionally display captions with the image", js: true do
-    fill_in_typeahead_field with: "gk446cj2442"
+  scenario 'should allow you to optionally display captions with the image', js: true do
+    fill_in_typeahead_field with: 'gk446cj2442'
 
     # display the title as the primary caption
     within('.primary-caption') do
-      check("Primary caption")
-      select("Title", from: 'primary-caption-field')
+      check('Primary caption')
+      select('Title', from: 'primary-caption-field')
     end
     # display the language as the secondary caption
     within('.secondary-caption') do
-      check("Secondary caption")
-      select("Language", from: 'secondary-caption-field')
+      check('Secondary caption')
+      select('Language', from: 'secondary-caption-field')
     end
     # create the page
     save_page
 
     # verify that the item + image widget is displaying image and title from the requested document.
-    within(:css, ".items-block") do
-      expect(page).to have_css(".thumbnail")
-      expect(page).to have_css(".thumbnail a img")
-      expect(page).to have_css(".primary-caption", text: "[World map]")
-      expect(page).to have_css(".secondary-caption", text: "Latin")
+    within(:css, '.items-block') do
+      expect(page).to have_css('.thumbnail')
+      expect(page).to have_css('.thumbnail a img')
+      expect(page).to have_css('.primary-caption', text: '[World map]')
+      expect(page).to have_css('.secondary-caption', text: 'Latin')
     end
   end
 
-  scenario "should allow you to add text to the image", js: true do
-
+  scenario 'should allow you to add text to the image', js: true do
     # fill in the content-editable div
-    content_editable = find(".st-text-block")
-    content_editable.set("zzz")
+    content_editable = find('.st-text-block')
+    content_editable.set('zzz')
     # create the page
     save_page
 
     # visit the show page for the document we just saved
     # verify that the item + image widget is displaying image and title from the requested document.
-    within(:css, ".items-block") do
-      expect(page).to have_content "zzz"
+    within(:css, '.items-block') do
+      expect(page).to have_content 'zzz'
     end
   end
 
-  scenario "should allow you to choose which side the text will be on", js: true do
+  scenario 'should allow you to choose which side the text will be on', js: true do
+    fill_in_typeahead_field with: 'dq287tq6352'
 
     # fill in the content editable div
-    content_editable = find(".st-text-block")
-    content_editable.set("zzz")
+    content_editable = find('.st-text-block')
+    content_editable.set('zzz')
     # Select to align the text right
-    choose "Right"
+    choose 'Right'
     # create the page
     save_page
 
     # verify that the item + image widget is displaying image and title from the requested document.
-    within(:css, ".items-block") do
-      expect(page).to have_content "zzz"
-      expect(page).to have_css(".text-col.pull-right")
+    within(:css, '.items-block') do
+      expect(page).to have_content 'zzz'
+      expect(page).to have_css('.items-col.pull-left')
+      expect(page).to have_css('.text-col')
     end
   end
 
-  scenario "round-trip data", js: true do
-    fill_in_typeahead_field with: "dq287tq6352"
+  scenario 'round-trip data', js: true do
+    fill_in_typeahead_field with: 'dq287tq6352'
 
     within(:css, '.panel') do
-      uncheck "Display?"
+      uncheck 'Display?'
     end
 
-    fill_in_typeahead_field with: "gk446cj2442"
+    fill_in_typeahead_field with: 'gk446cj2442'
 
     # display the title as the primary caption
     within('.primary-caption') do
-      check("Primary caption")
-      select("Title", from: 'primary-caption-field')
+      check('Primary caption')
+      select('Title', from: 'primary-caption-field')
     end
 
     # fill in the content editable div
-    content_editable = find(".st-text-block")
-    content_editable.set("zzz")
+    content_editable = find('.st-text-block')
+    content_editable.set('zzz')
     # Select to align the text right
-    choose "Right"
+    choose 'Right'
 
     save_page
 
-    click_on "Edit"
+    click_on 'Edit'
 
-    expect(page).to have_selector ".panel", count: 2
+    expect(page).to have_selector '.panel', count: 2
 
     # for some reason, the text area above isn't getting filled in
     # expect(page).to have_selector ".st-text-block", text: "zzz"
-    expect(find_field("primary-caption-field").value).to eq "full_title_tesim"
+    expect(find_field('primary-caption-field').value).to eq 'full_title_tesim'
   end
 end