blacklight-spotlight 0.4.1 → 0.5.0

data/spec/features/multiple_exhibits_spec.rb

@@ -1,29 +1,27 @@
-require "spec_helper"
-describe "Home page", :type => :feature do
+require 'spec_helper'
+describe 'Home page', type: :feature do
   let(:exhibit_visitor) { FactoryGirl.create(:exhibit_visitor) }
-  let!(:default_exhibit) { Spotlight::Exhibit.default }
-  let!(:second_exhibit) { FactoryGirl.create(:exhibit, title: "Second exhibit") }
+  let!(:default_exhibit) { FactoryGirl.create(:default_exhibit, title: 'Default exhibit') }
+  let!(:second_exhibit) { FactoryGirl.create(:exhibit, title: 'Second exhibit') }
 
-  before {login_as exhibit_visitor}
+  before { login_as exhibit_visitor }
 
-  it "should exist by default on exhibits" do
+  it 'exists by default on exhibits' do
     visit '/'
 
-    expect(page).to have_selector ".site-title", text: "Default exhibit"
-    expect(page).to have_link "More Exhibits"
+    expect(page).to have_selector '.site-title', text: 'Default exhibit'
+    expect(page).to have_link 'More Exhibits'
     within '#exhibit-masthead .dropdown-menu' do
-      expect(page).to have_no_link "Default exhibit"
-      click_link "Second exhibit"
+      expect(page).to have_no_link 'Default exhibit'
+      click_link 'Second exhibit'
     end
 
-    expect(page).to have_selector ".site-title", text: "Second exhibit"
-    expect(page).to have_link "More Exhibits"
+    expect(page).to have_selector '.site-title', text: 'Second exhibit'
+    expect(page).to have_link 'More Exhibits'
     within '#exhibit-masthead .dropdown-menu' do
-      expect(page).to have_no_link "Second exhibit"
-      click_link "Default exhibit"
+      expect(page).to have_no_link 'Second exhibit'
+      click_link 'Default exhibit'
     end
-    expect(page).to have_selector ".site-title", text: "Default exhibit"
-
+    expect(page).to have_selector '.site-title', text: 'Default exhibit'
   end
 end
-

data/spec/features/report_a_problem_spec.rb

@@ -1,30 +1,36 @@
-require "spec_helper"
+require 'spec_helper'
 
-describe "Report a Problem", :type => :feature do
-  let!(:exhibit) { FactoryGirl.create(:exhibit) }
-  it "should not have a header link" do
+describe 'Report a Problem', type: :feature do
+  let!(:exhibit) { FactoryGirl.create(:default_exhibit) }
+  it 'does not have a header link' do
     visit root_path
-    expect(page).to_not have_content "Feedback"
+    expect(page).to_not have_content 'Feedback'
   end
 
-  describe "when emails are setup" do
+  describe 'when emails are setup' do
     before do
-      exhibit.contact_emails_attributes= [ { "email"=>"test@example.com"}, {"email"=>"test2@example.com"}]
+      exhibit.contact_emails_attributes = [{ 'email' => 'test@example.com' }, { 'email' => 'test2@example.com' }]
       exhibit.save!
-      exhibit.contact_emails.first.confirm!
+      exhibit.contact_emails.first.tap do |e|
+        if e.respond_to? :confirm
+          e.confirm
+        else
+          e.confirm!
+        end
+      end
     end
 
-    it "should accept a problem report", js: true do
+    it 'accepts a problem report', js: true do
       visit spotlight.exhibit_catalog_path(exhibit, id: 'dq287tq6352')
-      click_on "Feedback"
-      expect(find("#contact_form_current_url", visible: false).value).to end_with spotlight.exhibit_catalog_path(exhibit, id: 'dq287tq6352') 
-      fill_in "Name", with: "Some Body"
-      fill_in "Email", with: "test@example.com"
-      fill_in "Message", with: "This is my problem report"
+      click_on 'Feedback'
+      expect(find('#contact_form_current_url', visible: false).value).to end_with spotlight.exhibit_catalog_path(exhibit, id: 'dq287tq6352')
+      fill_in 'Name', with: 'Some Body'
+      fill_in 'Email', with: 'test@example.com'
+      fill_in 'Message', with: 'This is my problem report'
 
-      expect {
-        click_on "Send"
-      }.to change {ActionMailer::Base.deliveries.count}.by(1)
+      expect do
+        click_on 'Send'
+      end.to change { ActionMailer::Base.deliveries.count }.by(1)
     end
   end
 end

data/spec/features/site_masthead_spec.rb

@@ -1,99 +1,99 @@
 require 'spec_helper'
 
-describe "Add and update the site masthead", :type => :feature do
-  let(:exhibit) { FactoryGirl.create(:exhibit) }
+describe 'Add and update the site masthead', type: :feature do
+  let(:exhibit) { FactoryGirl.create(:default_exhibit) }
   let(:user) { FactoryGirl.create(:exhibit_admin, exhibit: exhibit) }
 
   before { login_as user }
-  it 'should update site masthead options' do
+  it 'updates site masthead options' do
     visit spotlight.exhibit_dashboard_path(exhibit)
 
-    within "#sidebar" do
-      click_link "Appearance"
+    within '#sidebar' do
+      click_link 'Appearance'
     end
 
-    click_link "Site masthead"
+    click_link 'Site masthead'
 
-    within "#site-masthead" do
-      check "Show background image in masthead"
-      choose "Upload an image"
-      attach_file('appearance_masthead_image', File.absolute_path(File.join(FIXTURES_PATH, 'avatar.png')));
+    within '#site-masthead' do
+      check 'Show background image in masthead'
+      choose 'Upload an image'
+      attach_file('exhibit_masthead_attributes_image', File.absolute_path(File.join(FIXTURES_PATH, 'avatar.png')))
     end
 
-    click_button "Save changes"
+    click_button 'Save changes'
 
-    expect(page).to have_content("The appearance was successfully updated.")
+    expect(page).to have_content('The exhibit was successfully updated.')
 
-    within "#sidebar" do
-      click_link "Appearance"
+    within '#sidebar' do
+      click_link 'Appearance'
     end
 
-    click_link "Site masthead"
-    
-    within "#site-masthead" do
+    click_link 'Site masthead'
+
+    within '#site-masthead' do
       expect(field_labeled('Show background image in masthead')).to be_checked
       expect(field_labeled('Upload an image')).to be_checked
     end
   end
-  it 'should display a masthead image when one is uploaded and configured' do
+  it 'displays a masthead image when one is uploaded and configured' do
     visit spotlight.exhibit_dashboard_path(exhibit)
     expect(page).to_not have_css('#exhibit-masthead.with-image')
-    within "#sidebar" do
-      click_link "Appearance"
+    within '#sidebar' do
+      click_link 'Appearance'
     end
 
-    click_link "Site masthead"
-    
-    within "#site-masthead" do
-      check "Show background image in masthead"
+    click_link 'Site masthead'
+
+    within '#site-masthead' do
+      check 'Show background image in masthead'
 
-      attach_file('appearance_masthead_image', File.absolute_path(File.join(FIXTURES_PATH, 'avatar.png')));
+      attach_file('exhibit_masthead_attributes_image', File.absolute_path(File.join(FIXTURES_PATH, 'avatar.png')))
     end
 
-    click_button "Save changes"
+    click_button 'Save changes'
 
-    expect(page).to have_content("The appearance was successfully updated.")
+    expect(page).to have_content('The exhibit was successfully updated.')
 
     expect(page).to have_css('#exhibit-masthead.with-image .background-container')
   end
-  it 'should not display an uploaded masthead if configured to not display' do
+  it 'does not display an uploaded masthead if configured to not display' do
     visit spotlight.exhibit_dashboard_path(exhibit)
     expect(page).to_not have_css('#exhibit-masthead.with-image')
-    within "#sidebar" do
-      click_link "Appearance"
+    within '#sidebar' do
+      click_link 'Appearance'
     end
 
-    click_link "Site masthead"
-    
-    within "#site-masthead" do
-      attach_file('appearance_masthead_image', File.absolute_path(File.join(FIXTURES_PATH, 'avatar.png')));
+    click_link 'Site masthead'
+
+    within '#site-masthead' do
+      attach_file('exhibit_masthead_attributes_image', File.absolute_path(File.join(FIXTURES_PATH, 'avatar.png')))
     end
 
-    click_button "Save changes"
+    click_button 'Save changes'
 
-    expect(page).to have_content("The appearance was successfully updated.")
+    expect(page).to have_content('The exhibit was successfully updated.')
 
     expect(page).to_not have_css('#exhibit-masthead.with-image .background-container')
   end
-  it 'should display a masthead image when one is uploaded from an exhibit item', js: true do
+  it 'displays a masthead image when one is uploaded from an exhibit item', js: true do
     skip "Capyabara and jcrop don't play well together.."
     visit spotlight.exhibit_dashboard_path(exhibit)
     expect(page).to_not have_css('#exhibit-masthead.with-image')
-    within "#sidebar" do
-      click_link "Appearance"
+    within '#sidebar' do
+      click_link 'Appearance'
     end
 
-    click_link "Site masthead"
-    
-    within "#site-masthead" do
-      check "Show background image in masthead"
+    click_link 'Site masthead'
+
+    within '#site-masthead' do
+      check 'Show background image in masthead'
 
-      fill_in_typeahead_field 'document_title', with: "Armenia"
+      fill_in_typeahead_field 'document_title', with: 'Armenia'
     end
 
-    click_button "Save changes"
+    click_button 'Save changes'
 
-    expect(page).to have_content("The appearance was successfully updated.")
+    expect(page).to have_content('The appearance was successfully updated.')
 
     expect(page).to have_css('#exhibit-masthead.with-image .background-container')
   end

data/spec/features/slideshow_spec.rb

@@ -1,21 +1,20 @@
 require 'spec_helper'
 
-describe "Slideshow", type: :feature, js: true do
-  let(:exhibit) { FactoryGirl.create(:exhibit) }
+describe 'Slideshow', type: :feature, js: true do
+  let(:exhibit) { FactoryGirl.create(:default_exhibit) }
   let(:user) { FactoryGirl.create(:exhibit_admin, exhibit: exhibit) }
 
   before do
     login_as user
-    exhibit.blacklight_configuration.update(document_index_view_types: ['list', 'gallery', 'slideshow'])
+    exhibit.blacklight_configuration.update(document_index_view_types: %w(list gallery slideshow))
   end
-  it "should have slideshow" do
-    visit spotlight.exhibit_catalog_index_path(exhibit, f: {genre_ssim: ['map']})
-    expect(page).to have_content "You searched for:"
-    within ".view-type" do
-      click_link "Slideshow"
+  it 'has slideshow' do
+    visit spotlight.exhibit_catalog_index_path(exhibit, f: { genre_ssim: ['map'] })
+    expect(page).to have_content 'You searched for:'
+    within '.view-type' do
+      click_link 'Slideshow'
     end
     find('.grid [data-slide-to="1"]').trigger('click')
     expect(page).to have_selector '#slideshow', visible: true
   end
-  
 end

data/spec/features/tags_admin_spec.rb

@@ -1,29 +1,29 @@
-require "spec_helper"
+require 'spec_helper'
 
-describe "Tags Administration", :type => :feature do
-  let(:exhibit) { FactoryGirl.create(:exhibit) }
+describe 'Tags Administration', type: :feature do
+  let(:exhibit) { FactoryGirl.create(:default_exhibit) }
   let!(:tagging) { FactoryGirl.create(:tagging, tagger: exhibit) }
   let(:exhibit_curator) { FactoryGirl.create(:exhibit_curator, exhibit: exhibit) }
   before { login_as exhibit_curator }
 
-  describe "index" do
-    it "should have tags" do
+  describe 'index' do
+    it 'has tags' do
       visit spotlight.exhibit_tags_path(exhibit)
-      expect(page).to have_css("td", text: tagging.tag.name)
+      expect(page).to have_css('td', text: tagging.tag.name)
     end
 
-    it "should link tags to a search" do
+    it 'links tags to a search' do
       visit spotlight.exhibit_tags_path(exhibit)
       click_on tagging.tag.name
       expect(page).to have_content "Remove constraint Exhibit Tags: #{tagging.tag.name}"
     end
   end
 
-  describe "destroy" do
-    it "should destroy a tag" do
+  describe 'destroy' do
+    it 'destroys a tag' do
       visit spotlight.exhibit_tags_path(exhibit)
-      click_link "Delete"
-      expect(page).not_to have_css("td", text: tagging.tag.name)
+      click_link 'Delete'
+      expect(page).not_to have_css('td', text: tagging.tag.name)
     end
   end
 end

data/spec/features/upload_non_repository_item_spec.rb

@@ -1,18 +1,18 @@
-require "spec_helper"
+require 'spec_helper'
 
-describe "Uploading a non-repository item", :type => :feature do
-  let!(:exhibit) { FactoryGirl.create(:exhibit) }
+describe 'Uploading a non-repository item', type: :feature do
+  let!(:exhibit) { FactoryGirl.create(:default_exhibit) }
   let!(:custom_field) { FactoryGirl.create(:custom_field, exhibit: exhibit) }
   let!(:exhibit_curator) { FactoryGirl.create(:exhibit_curator, exhibit: exhibit) }
   before { login_as exhibit_curator }
 
-  describe "forms" do
-    it "should display the single item upload form" do
+  describe 'forms' do
+    it 'displays the single item upload form' do
       visit spotlight.new_exhibit_resources_upload_path(exhibit)
-      expect(page).to have_css("h1", text: /Curation/)
-      expect(page).to have_css "h1 small", text: "Add non-repository items"
+      expect(page).to have_css('h1', text: /Curation/)
+      expect(page).to have_css 'h1 small', text: 'Add non-repository items'
 
-      within("form#new_resources_upload") do
+      within('form#new_resources_upload') do
         expect(page).to have_css('#resources_upload_url[type="file"]')
         expect(page).to have_css('.help-block', text: 'Valid file types: jpg jpeg png')
         expect(page).to have_css('#resources_upload_data_full_title_tesim[type="text"]')
@@ -22,52 +22,52 @@ describe "Uploading a non-repository item", :type => :feature do
         expect(page).to have_css("#resources_upload_data_#{custom_field.field}[type='text']")
       end
     end
-    it "should display the multi-item CSV upload form" do
+    it 'displays the multi-item CSV upload form' do
       visit spotlight.new_exhibit_resources_upload_path(exhibit)
-      expect(page).to have_css("h1", text: /Curation/)
-      expect(page).to have_css "h1 small", text: "Add non-repository items"
-      within("form#new_resources_csv_upload") do
+      expect(page).to have_css('h1', text: /Curation/)
+      expect(page).to have_css 'h1 small', text: 'Add non-repository items'
+      within('form#new_resources_csv_upload') do
         expect(page).to have_css('#resources_csv_upload_url[type="file"]')
         expect(page).to have_css('.help-block a', text: 'Download template')
       end
     end
   end
 
-  describe "upload" do
-    it "should create a new non-repository item" do
+  describe 'upload' do
+    it 'creates a new non-repository item' do
       visit spotlight.new_exhibit_resources_upload_path(exhibit)
-      attach_file("resources_upload_url", File.join(FIXTURES_PATH, "800x600.png"))
-      fill_in "Title", with: "800x600"
+      attach_file('resources_upload_url', File.join(FIXTURES_PATH, '800x600.png'))
+      fill_in 'Title', with: '800x600'
 
-      within "#new_resources_upload" do
-        click_button "Add item"
+      within '#new_resources_upload' do
+        click_button 'Add item'
       end
-      expect(page).to have_content "Object uploaded successfully."
+      expect(page).to have_content 'Object uploaded successfully.'
 
-      expect(Spotlight::Resource.last.url.file.path).to end_with "800x600.png"
+      expect(Spotlight::Resource.last.url.file.path).to end_with '800x600.png'
       Blacklight.default_index.connection.delete_by_id Spotlight::Resource.last.send(:compound_id)
       Blacklight.default_index.connection.commit
     end
 
-    it "should be editable" do
+    it 'is editable' do
       visit spotlight.new_exhibit_resources_upload_path(exhibit)
-      attach_file("resources_upload_url", File.join(FIXTURES_PATH, "800x600.png"))
-      fill_in "Title", with: "800x600"
+      attach_file('resources_upload_url', File.join(FIXTURES_PATH, '800x600.png'))
+      fill_in 'Title', with: '800x600'
 
-      within "#new_resources_upload" do
-        click_button "Add item"
+      within '#new_resources_upload' do
+        click_button 'Add item'
       end
 
-      click_link "800x600"
-      click_link "Edit"
-      fill_in "Title", with: "This is a now an avatar"
+      click_link '800x600'
+      click_link 'Edit'
+      fill_in 'Title', with: 'This is a now an avatar'
 
-      attach_file("File", File.join(FIXTURES_PATH, "avatar.png"))
+      attach_file('File', File.join(FIXTURES_PATH, 'avatar.png'))
 
-      click_button "Save"
+      click_button 'Save'
 
-      expect(page).to have_content "This is a now an avatar"
-      expect(Spotlight::Resource.last.url.file.path).to end_with "avatar.png"
+      expect(page).to have_content 'This is a now an avatar'
+      expect(Spotlight::Resource.last.url.file.path).to end_with 'avatar.png'
       Blacklight.default_index.connection.delete_by_id Spotlight::Resource.last.send(:compound_id)
       Blacklight.default_index.connection.commit
     end

data/spec/features/user_admin_spec.rb

@@ -1,15 +1,15 @@
-require "spec_helper"
+require 'spec_helper'
 
-describe "User Administration", :type => :feature do
-  let!(:exhibit) { FactoryGirl.create(:exhibit) }
+describe 'User Administration', type: :feature do
+  let!(:exhibit) { FactoryGirl.create(:default_exhibit) }
   let!(:user) { FactoryGirl.create(:exhibit_admin, exhibit: exhibit) }
   before { login_as user }
-  describe "index" do
-    it "should show the users for the exhibit" do
+  describe 'index' do
+    it 'shows the users for the exhibit' do
       visit spotlight.exhibit_roles_path(exhibit)
       exhibit.roles.each do |role|
-        expect(page).to have_css("td", text: role.user.email)
-        expect(page).to have_css("td", text: role.role.humanize)
+        expect(page).to have_css('td', text: role.user.email)
+        expect(page).to have_css('td', text: role.role.humanize)
       end
     end
   end

data/spec/helpers/spotlight/application_helper_spec.rb

@@ -1,19 +1,19 @@
 require 'spec_helper'
 
-describe Spotlight::ApplicationHelper, :type => :helper do
-  describe "#application_name" do
-    it "should include the exhibit" do
-      allow(helper).to receive_messages(current_exhibit: double(title: "My Exhibit"))
-      expect(helper.application_name).to eq "My Exhibit - Blacklight"  
+describe Spotlight::ApplicationHelper, type: :helper do
+  describe '#application_name' do
+    it 'includes the exhibit' do
+      allow(helper).to receive_messages(current_exhibit: double(title: 'My Exhibit'))
+      expect(helper.application_name).to eq 'My Exhibit - Blacklight'
     end
 
-    it "should be just the application name if there isn't an exhibit" do
+    it "is just the application name if there isn't an exhibit" do
       allow(helper).to receive_messages(current_exhibit: nil)
-      expect(helper.application_name).to eq "Blacklight"  
+      expect(helper.application_name).to eq 'Blacklight'
     end
   end
 
-  describe "#url_to_tag_facet" do
+  describe '#url_to_tag_facet' do
     before do
       allow(helper).to receive_messages(current_exhibit: FactoryGirl.create(:exhibit))
       allow(helper).to receive_messages(blacklight_config: Blacklight::Configuration.new)
@@ -24,32 +24,39 @@ describe Spotlight::ApplicationHelper, :type => :helper do
       end
     end
 
-    it "should be a url for a search with the given tag facet" do
+    it 'is a url for a search with the given tag facet' do
       allow(Spotlight::SolrDocument).to receive_messages(solr_field_for_tagger: :exhibit_tags)
-      expect(helper.url_to_tag_facet "tag_value").to eq spotlight.exhibit_catalog_index_path(exhibit_id: helper.current_exhibit, f: { exhibit_tags: ['tag_value']})
+      expected = spotlight.exhibit_catalog_index_path(exhibit_id: helper.current_exhibit, f: { exhibit_tags: ['tag_value'] })
+      expect(helper.url_to_tag_facet 'tag_value').to eq expected
     end
   end
-  describe "search block helpers" do
-    describe "selected_search_block_views" do
-      it "should return keys with a value of 'on'" do
-        expect(helper.selected_search_block_views(SirTrevorRails::Block.new({type: 'xyz', data: {a: "on", b: "off", c: false, d: "on"}}, 'parent'))).to eq ["a", "d"]
+
+  describe 'search block helpers' do
+    describe 'selected_search_block_views' do
+      let(:block) do
+        SirTrevorRails::Block.new({ type: 'xyz', data: { a: 'on', b: 'off', c: false, d: 'on' } }, 'parent')
+      end
+
+      it "returns keys with a value of 'on'" do
+        expect(helper.selected_search_block_views(block)).to eq %w(a d)
       end
     end
-    describe "blacklight_view_config_for_search_block" do
-      let(:sir_trevor_block) { 
-        SirTrevorRails::Block.new({type: 'xyz', data: {view: ["list", "gallery"]}}, 'parent')
-      }
+    describe 'blacklight_view_config_for_search_block' do
+      let(:sir_trevor_block) do
+        SirTrevorRails::Block.new({ type: 'xyz', data: { view: %w(list gallery) } }, 'parent')
+      end
 
-      let(:config) { Blacklight::Configuration.new do |config|
-        config.view.list = {}
-        config.view.gallery = {}
-        config.view.slideshow = {}
+      let(:config) do
+        Blacklight::Configuration.new do |config|
+          config.view.list = {}
+          config.view.gallery = {}
+          config.view.slideshow = {}
+        end
       end
-      }
       before do
         allow(helper).to receive_messages(blacklight_config: config)
       end
-      it "should return a blacklight configuration object that has reduced the views to those that are configured in the block" do
+      it 'returns a blacklight configuration object that has reduced the views to those that are configured in the block' do
         new_config = helper.blacklight_view_config_for_search_block(sir_trevor_block)
         expect(new_config.keys).to eq [:list, :gallery]
       end
@@ -57,35 +64,35 @@ describe Spotlight::ApplicationHelper, :type => :helper do
   end
   describe 'render_document_class' do
     let(:current_exhibit) { FactoryGirl.create(:exhibit) }
-    let(:document) { SolrDocument.new(some_field: "Some data") }
+    let(:document) { SolrDocument.new(some_field: 'Some data') }
     before do
       allow(helper).to receive_messages(current_exhibit: current_exhibit)
       allow(helper).to receive_messages(blacklight_config: Blacklight::Configuration.new do |config|
         config.index.display_type_field = :some_field
       end)
     end
-    it 'should return blacklight-private when the document is private' do
+    it 'returns blacklight-private when the document is private' do
       allow(document).to receive(:private?).with(current_exhibit).and_return(true)
-      expect(helper.render_document_class(document)).to match /blacklight-private/
+      expect(helper.render_document_class(document)).to include 'blacklight-private'
     end
-    it 'should prefix "blacklight-" to the configured type' do
-      expect(helper.render_document_class(document)).to match /blacklight-some-data/
+    it 'prefixs "blacklight-" to the configured type' do
+      expect(helper.render_document_class(document)).to include 'blacklight-some-data'
     end
   end
 
-  describe "#add_exhibit_twitter_card_content" do
+  describe '#add_exhibit_twitter_card_content' do
     let(:current_exhibit) { FactoryGirl.create(:exhibit) }
     before do
       allow(helper).to receive_messages(current_exhibit: current_exhibit)
-      current_exhibit.subtitle = "xyz"
-      current_exhibit.description = "abc"
+      current_exhibit.subtitle = 'xyz'
+      current_exhibit.description = 'abc'
       TopHat.current['twitter_card'] = nil
     end
 
-    it "should generate a twitter card for the exhibit" do
-      allow(helper).to receive(:exhibit_root_url).and_return("some/url")
+    it 'generates a twitter card for the exhibit' do
+      allow(helper).to receive(:exhibit_root_url).and_return('some/url')
       allow(current_exhibit).to receive(:thumbnail).and_return(double)
-      allow(current_exhibit).to receive_message_chain(:thumbnail, :image, :thumb, url: "/image")
+      allow(current_exhibit).to receive_message_chain(:thumbnail, :image, :thumb, url: '/image')
 
       helper.add_exhibit_twitter_card_content
 
@@ -97,41 +104,41 @@ describe Spotlight::ApplicationHelper, :type => :helper do
       expect(card).to have_css "meta[name='twitter:image'][value='http://test.host/image']", visible: false
     end
   end
-  
-  describe "#carrierwave_url" do
-    it "should turn a application-relative URI into a path" do
-      upload = double(url: "/x/y/z")
-      expect(helper.carrierwave_url(upload)).to eq "http://test.host/x/y/z"
+
+  describe '#carrierwave_url' do
+    it 'turns a application-relative URI into a path' do
+      upload = double(url: '/x/y/z')
+      expect(helper.carrierwave_url(upload)).to eq 'http://test.host/x/y/z'
     end
 
-    it "should pass a full URI through" do
-      upload = double(url: "http://some.host/x/y/z")
-      expect(helper.carrierwave_url(upload)).to eq "http://some.host/x/y/z"
+    it 'passes a full URI through' do
+      upload = double(url: 'http://some.host/x/y/z')
+      expect(helper.carrierwave_url(upload)).to eq 'http://some.host/x/y/z'
     end
   end
-  
-  describe "save_search rendering" do
+
+  describe 'save_search rendering' do
     let(:current_exhibit) { FactoryGirl.create(:exhibit) }
     before { allow(helper).to receive_messages(current_exhibit: current_exhibit) }
-    describe "render_save_this_search?" do
-      it "should return false if we are on the items admin screen" do
+    describe 'render_save_this_search?' do
+      it 'returns false if we are on the items admin screen' do
         allow(helper).to receive(:"can?").with(:curate, current_exhibit).and_return(true)
-        allow(helper).to receive(:params).and_return({controller: "spotlight/catalog", action: "admin"})
+        allow(helper).to receive(:params).and_return(controller: 'spotlight/catalog', action: 'admin')
         expect(helper.render_save_this_search?).to be_falsey
       end
-      it "should return true if we are not on the items admin screen" do
+      it 'returns true if we are not on the items admin screen' do
         allow(helper).to receive(:"can?").with(:curate, current_exhibit).and_return(true)
-        allow(helper).to receive(:params).and_return({controller: "spotlight/catalog", action: "index"})
+        allow(helper).to receive(:params).and_return(controller: 'spotlight/catalog', action: 'index')
         expect(helper.render_save_this_search?).to be_truthy
       end
-      it "should return false if a user cannot curate the object" do
+      it 'returns false if a user cannot curate the object' do
         allow(helper).to receive(:"can?").with(:curate, current_exhibit).and_return(false)
         expect(helper.render_save_this_search?).to be_falsey
       end
     end
   end
 
-  describe "#uploaded_field_label" do
+  describe '#uploaded_field_label' do
     let :field do
       OpenStruct.new field_name: 'x'
     end
@@ -144,18 +151,18 @@ describe Spotlight::ApplicationHelper, :type => :helper do
       allow(helper).to receive_messages(blacklight_config: blacklight_config)
     end
 
-    it "should use the configuration-provided label" do
+    it 'uses the configuration-provided label' do
       field.label = 'label x'
       expect(helper.uploaded_field_label(field)).to eq 'label x'
     end
 
-    it "should pull the label from the solr field" do
+    it 'pulls the label from the solr field' do
       blacklight_config.add_index_field 'x', label: 'solr x'
       expect(helper.uploaded_field_label(field)).to eq 'solr x'
     end
   end
 
-  describe "#available_view_fields" do    
+  describe '#available_view_fields' do
     let :blacklight_config do
       Blacklight::Configuration.new
     end
@@ -164,7 +171,7 @@ describe Spotlight::ApplicationHelper, :type => :helper do
       allow(helper).to receive_message_chain(:current_exhibit, :blacklight_configuration, default_blacklight_config: blacklight_config)
     end
 
-    it "should exclude view fields that are never visible (e.g. atom, rss)" do
+    it 'excludes view fields that are never visible (e.g. atom, rss)' do
       blacklight_config.view.a.if = true
       blacklight_config.view.b.if = false