blacklight-spotlight 0.4.1 → 0.5.0

data/spec/features/create_page_spec.rb

@@ -1,23 +1,23 @@
-require "spec_helper"
+require 'spec_helper'
 
-describe "Creating a page", :type => :feature do
-  let(:exhibit) { FactoryGirl.create(:exhibit) }
+describe 'Creating a page', type: :feature do
+  let(:exhibit) { FactoryGirl.create(:default_exhibit) }
   let(:exhibit_curator) { FactoryGirl.create(:exhibit_curator, exhibit: exhibit) }
 
-  describe "when a bunch of about pages exist" do
+  describe 'when a bunch of about pages exist' do
     let!(:page1) { FactoryGirl.create(:about_page, exhibit: exhibit) }
     let!(:page2) { FactoryGirl.create(:about_page, exhibit: exhibit) }
-    let!(:page3) { FactoryGirl.create(:about_page, exhibit: exhibit, title: "A new one") }
-    it "should be able to show a list of About pages to be curated" do
+    let!(:page3) { FactoryGirl.create(:about_page, exhibit: exhibit, title: 'A new one') }
+    it 'is able to show a list of About pages to be curated' do
       login_as exhibit_curator
       visit spotlight.exhibit_home_page_path(exhibit, exhibit.home_page)
       within '#user-util-collapse .dropdown' do
         click_link 'Dashboard'
       end
       within '#sidebar' do
-        click_link "About pages"
+        click_link 'About pages'
       end
-      expect(page).to have_content "A new one"
+      expect(page).to have_content 'A new one'
     end
   end
 end

data/spec/features/curator_items.rb

@@ -1,15 +1,15 @@
 require 'spec_helper'
 
-describe "A curator can see the items page", :type => :feature do
+describe 'A curator can see the items page', type: :feature do
   let(:exhibit_curator) { FactoryGirl.create(:exhibit_curator) }
 
-  it "should work" do
+  it 'works' do
     login_as exhibit_curator
 
     visit '/'
     within '.dropdown-menu' do
       click_link 'Dashboard'
     end
-    expect(page).to have_content "Items"
+    expect(page).to have_content 'Items'
   end
 end

data/spec/features/dashboard_spec.rb

@@ -1,35 +1,34 @@
 require 'spec_helper'
 
-describe "Dashboard", :type => :feature do
-  let(:exhibit) { FactoryGirl.create(:exhibit) }
+describe 'Dashboard', type: :feature do
+  let(:exhibit) { FactoryGirl.create(:default_exhibit) }
   let(:admin) { FactoryGirl.create(:exhibit_admin, exhibit: exhibit) }
   before do
     login_as(admin)
   end
 
-  let!(:parent_feature_page) { 
-    FactoryGirl.create(:feature_page, title: "Parent Page", exhibit: exhibit)
-  }
-  let!(:child_feature_page) {
+  let!(:parent_feature_page) do
+    FactoryGirl.create(:feature_page, title: 'Parent Page', exhibit: exhibit)
+  end
+  let!(:child_feature_page) do
     FactoryGirl.create(
       :feature_page,
-      title: "Child Page",
+      title: 'Child Page',
       parent_page: parent_feature_page,
       exhibit: exhibit
     )
-  }
+  end
 
-  it "should include a list of recently edited feature pages" do
+  it 'includes a list of recently edited feature pages' do
     visit spotlight.exhibit_dashboard_path(exhibit)
-    expect(page).to have_content "Recent Site Building Activity"
-    expect(page).to have_content "Parent Page"
-    expect(page).to have_content "Child Page"
+    expect(page).to have_content 'Recent Site Building Activity'
+    expect(page).to have_content 'Parent Page'
+    expect(page).to have_content 'Child Page'
   end
 
-  it "should include a list of recently indexed items" do
+  it 'includes a list of recently indexed items' do
     visit spotlight.exhibit_dashboard_path(exhibit)
-    expect(page).to have_content "Recently Updated Items"
-    expect(page).to have_selector("#documents")
+    expect(page).to have_content 'Recently Updated Items'
+    expect(page).to have_selector('#documents')
   end
-
 end

data/spec/features/edit_contact_spec.rb

@@ -1,22 +1,20 @@
 require 'spec_helper'
 
-describe "Add a contact to an exhibit", :type => :feature do
+describe 'Add a contact to an exhibit', type: :feature do
   let(:curator) { FactoryGirl.create(:exhibit_curator) }
   let(:exhibit) { curator.roles.first.exhibit }
   let!(:about_page) { FactoryGirl.create(:about_page, exhibit: exhibit) }
-  let!(:contact) { FactoryGirl.create(:contact, name: 'Marcus Aurelius', exhibit: exhibit)}
+  let!(:contact) { FactoryGirl.create(:contact, name: 'Marcus Aurelius', exhibit: exhibit) }
   before { login_as curator }
-  it "should display a newly added contact in the sidebar" do
+  it 'displays a newly added contact in the sidebar' do
     visit spotlight.exhibit_about_pages_path(exhibit)
-    
-    within ".contacts_admin" do
-      click_link "Edit"
-    end
 
-    click_button "Save"
+    within '.contacts_admin' do
+      click_link 'Edit'
+    end
 
-    expect(page).to have_content "The contact was successfully updated."
+    click_button 'Save'
 
+    expect(page).to have_content 'The contact was successfully updated.'
   end
-  
 end

data/spec/features/edit_search_fields_spec.rb

@@ -0,0 +1,79 @@
+require 'spec_helper'
+
+describe 'Search Administration', type: :feature do
+  let(:exhibit) { FactoryGirl.create(:default_exhibit) }
+  let(:exhibit_curator) { FactoryGirl.create(:exhibit_curator, exhibit: exhibit) }
+  before { login_as exhibit_curator }
+
+  describe 'edit' do
+    it 'displays the search configuration edit screen' do
+      visit spotlight.edit_exhibit_search_configuration_path(exhibit)
+      expect(page).to have_css('h1 small', text: 'Search')
+    end
+
+    it 'has breadcrumbs' do
+      visit spotlight.edit_exhibit_search_configuration_path exhibit
+      expect(page).to have_breadcrumbs 'Home', 'Curation', 'Search'
+    end
+
+    describe 'facets' do
+      it 'displays information about the facets' do
+        visit spotlight.edit_exhibit_search_configuration_path(exhibit)
+        within("[data-id='genre_ssim']") do
+          expect(page).to have_content('Genre')
+          expect(page).to have_content(/\d+ items/)
+          expect(page).to have_content(/(\d+) unique values/)
+        end
+      end
+
+      it 'allows curators to select and unselect facets for display' do
+        visit spotlight.edit_exhibit_search_configuration_path exhibit
+
+        expect(page).to have_content 'Curation Search Options Facets'
+        expect(page).to have_button 'Save'
+
+        uncheck 'blacklight_configuration_facet_fields_language_ssim_show' # Language
+        uncheck 'blacklight_configuration_facet_fields_genre_ssim_show' # Genre
+        check 'blacklight_configuration_facet_fields_subject_temporal_ssim_show' # Era
+
+        click_on 'Save changes'
+
+        expect(exhibit.reload.blacklight_config.facet_fields.select { |_k, v| v.show }.keys).to include('subject_temporal_ssim')
+        expect(exhibit.blacklight_config.facet_fields.select { |_k, v| v.show }.keys).to_not include('language_ssim', 'genre_ssim')
+      end
+    end
+
+    describe 'sort' do
+      it 'displays the sort fields edit area' do
+        visit spotlight.edit_exhibit_search_configuration_path(exhibit)
+        expect(page).to have_content('Sort fields')
+      end
+
+      it 'updates sort options' do
+        visit spotlight.edit_exhibit_search_configuration_path(exhibit)
+
+        # #field_labeled doesn't appear to work for disabled inputs
+        expect(page).to have_css("input[name='blacklight_configuration[sort_fields][relevance][enable]'][disabled='disabled']")
+        expect(page).to have_css('#nested-sort-fields .dd-item:nth-child(5) h3', text: 'Identifier')
+
+        uncheck 'blacklight_configuration_sort_fields_title_enabled'
+        uncheck 'blacklight_configuration_sort_fields_identifier_enabled'
+
+        find('#blacklight_configuration_sort_fields_type_weight').set('100')
+
+        click_button 'Save changes'
+
+        click_link 'Results'
+
+        expect(page).to have_css("input[name='blacklight_configuration[sort_fields][relevance][enable]'][disabled='disabled']")
+        expect(find('#blacklight_configuration_sort_fields_type_enabled')).to be_checked
+        expect(find('#blacklight_configuration_sort_fields_date_enabled')).to be_checked
+        expect(find('#blacklight_configuration_sort_fields_title_enabled')).to_not be_checked
+        expect(find('#blacklight_configuration_sort_fields_identifier_enabled')).to_not be_checked
+
+        # Type is now sorted last
+        expect(page).to have_css('#nested-sort-fields .dd-item:nth-child(5) h3', text: 'Type')
+      end
+    end
+  end
+end

data/spec/features/exhibits/add_tags_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
-describe "Add tags to an item in an exhibit", :type => :feature do
-  let(:exhibit) { FactoryGirl.create(:exhibit) }
+describe 'Add tags to an item in an exhibit', type: :feature do
+  let(:exhibit) { FactoryGirl.create(:default_exhibit) }
   let(:curator) { FactoryGirl.create(:exhibit_curator, exhibit: exhibit) }
   let(:custom_field) { FactoryGirl.create(:custom_field, exhibit: exhibit) }
 
@@ -9,28 +9,27 @@ describe "Add tags to an item in an exhibit", :type => :feature do
     login_as(curator)
   end
 
-  it "should change and display the of tags" do
-    visit spotlight.exhibit_catalog_path(exhibit, "dq287tq6352")
+  it 'changes and display the of tags' do
+    visit spotlight.exhibit_catalog_path(exhibit, 'dq287tq6352')
 
-    expect(page).to have_link "Edit"
+    expect(page).to have_link 'Edit'
 
-    click_on "Edit"
+    click_on 'Edit'
 
-    fill_in "Tags", with: "One, Two and a half, Three"
+    fill_in 'Tags', with: 'One, Two and a half, Three'
 
-    click_on "Save changes"
+    click_on 'Save changes'
 
-    visit spotlight.exhibit_catalog_path(exhibit, "dq287tq6352")
+    visit spotlight.exhibit_catalog_path(exhibit, 'dq287tq6352')
 
-    within("dd.blacklight-exhibit_tags") do
-      expect(page).to have_selector  "a", text: "One"
-      expect(page).to have_selector  "a", text: "Two and a half"
-      expect(page).to have_selector  "a", text: "Three"
+    within('dd.blacklight-exhibit_tags') do
+      expect(page).to have_selector 'a', text: 'One'
+      expect(page).to have_selector 'a', text: 'Two and a half'
+      expect(page).to have_selector 'a', text: 'Three'
     end
 
-    click_on "Two and a half"
+    click_on 'Two and a half'
 
-    expect(page).to have_content "Remove constraint Exhibit Tags: Two and a half"
+    expect(page).to have_content 'Remove constraint Exhibit Tags: Two and a half'
   end
 end
-

data/spec/features/exhibits/administration_spec.rb

@@ -1,36 +1,36 @@
-require "spec_helper"
+require 'spec_helper'
 
-describe "Exhibit Administration", :type => :feature do
-  let(:exhibit) { FactoryGirl.create(:exhibit) }
+describe 'Exhibit Administration', type: :feature do
+  let(:exhibit) { FactoryGirl.create(:default_exhibit) }
   let(:admin) { FactoryGirl.create(:exhibit_admin, exhibit: exhibit) }
-  let(:email_id_0) { "exhibit_contact_emails_attributes_0_email" }
-  let(:email_address_0) { "admin@example.com" }
-  let(:email_id_1) { "exhibit_contact_emails_attributes_1_email" }
-  let(:email_address_1) { "admin2@example.com" }
+  let(:email_id_0) { 'exhibit_contact_emails_attributes_0_email' }
+  let(:email_address_0) { 'admin@example.com' }
+  let(:email_id_1) { 'exhibit_contact_emails_attributes_1_email' }
+  let(:email_address_1) { 'admin2@example.com' }
   before { login_as admin }
 
-  describe "Contact Emails" do
-    it "should have breadcrumbs" do
-      visit spotlight.edit_exhibit_path( exhibit )
-      expect(page).to have_breadcrumbs "Home", "Administration", "Settings"
+  describe 'Contact Emails' do
+    it 'has breadcrumbs' do
+      visit spotlight.edit_exhibit_path(exhibit)
+      expect(page).to have_breadcrumbs 'Home', 'Administration', 'Settings'
     end
 
-    it "should have a blank input field when there are no contacts yet" do
-      visit spotlight.edit_exhibit_path( exhibit )
-      expect(page).to have_css("input.exhibit-contact")
+    it 'has a blank input field when there are no contacts yet' do
+      visit spotlight.edit_exhibit_path(exhibit)
+      expect(page).to have_css('input.exhibit-contact')
       expect(find_field(email_id_0).value).to be_blank
     end
-    it "should store and retreive a contact email address" do
-      visit spotlight.edit_exhibit_path( exhibit )
+    it 'stores and retreive a contact email address' do
+      visit spotlight.edit_exhibit_path(exhibit)
       fill_in email_id_0, with: email_address_0
-      click_button "Save changes"
-      expect(page).to have_content("The exhibit was successfully updated.")
-      visit spotlight.edit_exhibit_path( exhibit )
+      click_button 'Save changes'
+      expect(page).to have_content('The exhibit was successfully updated.')
+      visit spotlight.edit_exhibit_path(exhibit)
       expect(find_field(email_id_0).value).to eq email_address_0
     end
-    it "should have new inputs added when clicking on the 'add contact' button", js: true do
+    it "has new inputs added when clicking on the 'add contact' button", js: true do
       # Exhibit administration edit
-      visit spotlight.edit_exhibit_path( exhibit )
+      visit spotlight.edit_exhibit_path(exhibit)
 
       # fill in first email field
       fill_in email_id_0, with: email_address_0
@@ -38,17 +38,17 @@ describe "Exhibit Administration", :type => :feature do
       # Additonal blank fields should not exist
       expect(page).not_to have_css("input##{email_id_1}")
       # click the + (add contact) button
-      find("#another-email").click
+      find('#another-email').click
       # An additional blank field should exist now
       expect(page).to have_css("input##{email_id_1}")
       expect(find_field(email_id_1).value).to be_blank
 
       # fill in the second email field
       fill_in email_id_1, with: email_address_1
-      click_button "Save changes"
+      click_button 'Save changes'
 
-      expect(page).to have_content("The exhibit was successfully updated.")
-      visit spotlight.edit_exhibit_path( exhibit )
+      expect(page).to have_content('The exhibit was successfully updated.')
+      visit spotlight.edit_exhibit_path(exhibit)
 
       expect(find_field(email_id_0).value).to eq email_address_0
       expect(find_field(email_id_1).value).to eq email_address_1

data/spec/features/exhibits/custom_metadata_fields_spec.rb

@@ -1,30 +1,29 @@
 require 'spec_helper'
 
-describe "Adding custom metadata fields", type: :feature do
-
-  let(:exhibit) { FactoryGirl.create(:exhibit) }
+describe 'Adding custom metadata fields', type: :feature do
+  let(:exhibit) { FactoryGirl.create(:default_exhibit) }
   let(:admin) { FactoryGirl.create(:exhibit_admin, exhibit: exhibit) }
 
   before do
     login_as(admin)
   end
 
-  it "should work" do
-    # Add 
-    
-    visit spotlight.exhibit_edit_metadata_path exhibit
-    click_on "Add new field"
-    fill_in "Label", with: "My new custom field"
-    fill_in "Short description", with: "Helps to remind me what this field is for"
+  it 'works' do
+    # Add
+
+    visit spotlight.edit_exhibit_metadata_configuration_path exhibit
+    click_on 'Add new field'
+    fill_in 'Label', with: 'My new custom field'
+    fill_in 'Short description', with: 'Helps to remind me what this field is for'
 
-    click_on "Save"
+    click_on 'Save'
 
-    expect(page).to have_content "The custom field was created."
-    within "#exhibit-specific-fields" do
-      expect(page).to have_selector ".field-label", text: "My new custom field"
-      expect(page).to have_selector ".field-description", text: "Helps to remind me what this field is for"
+    expect(page).to have_content 'The custom field was created.'
+    within '#exhibit-specific-fields' do
+      expect(page).to have_selector '.field-label', text: 'My new custom field'
+      expect(page).to have_selector '.field-description', text: 'Helps to remind me what this field is for'
       # Edit
-      click_link "Edit"
+      click_link 'Edit'
     end
 
     # on the edit form
@@ -32,45 +31,44 @@ describe "Adding custom metadata fields", type: :feature do
     expect(find_field('Short description').value).to eq 'Helps to remind me what this field is for'
     fill_in 'Short description', with: 'A much better description'
 
-    click_button "Save changes"
+    click_button 'Save changes'
 
-    expect(page).to have_content "The custom field was successfully updated."
+    expect(page).to have_content 'The custom field was successfully updated.'
 
-    within "#exhibit-specific-fields" do
-      expect(page).to have_selector ".field-label", text: "My new custom field"
-      expect(page).to have_selector ".field-description", text: "A much better description"
-      # Destroy 
-      click_link "Delete"
+    within '#exhibit-specific-fields' do
+      expect(page).to have_selector '.field-label', text: 'My new custom field'
+      expect(page).to have_selector '.field-description', text: 'A much better description'
+      # Destroy
+      click_link 'Delete'
     end
 
-    expect(page).to have_content "The custom field was deleted."
-    
+    expect(page).to have_content 'The custom field was deleted.'
   end
 
-  it "should have breadcrumbs" do
-    visit spotlight.exhibit_edit_metadata_path exhibit
-    click_on "Add new field"
-    expect(page).to have_breadcrumbs "Home", "Curation", "Metadata", "Add new field"
+  it 'has breadcrumbs' do
+    visit spotlight.edit_exhibit_metadata_configuration_path exhibit
+    click_on 'Add new field'
+    expect(page).to have_breadcrumbs 'Home', 'Curation', 'Metadata', 'Add new field'
   end
 
-  it "should let the curator choose the type of field on create" do
-    visit spotlight.exhibit_edit_metadata_path exhibit
-    click_on "Add new field"
-    fill_in "Label", with: "My new custom field"
+  it 'lets the curator choose the type of field on create' do
+    visit spotlight.edit_exhibit_metadata_configuration_path exhibit
+    click_on 'Add new field'
+    fill_in 'Label', with: 'My new custom field'
 
-    choose "Controlled vocabulary"
-    click_on "Save"
+    choose 'Controlled vocabulary'
+    click_on 'Save'
 
-    expect(page).to have_content "The custom field was created."
-    within "#exhibit-specific-fields" do
+    expect(page).to have_content 'The custom field was created.'
+    within '#exhibit-specific-fields' do
       # Edit
-      click_link "Edit"
+      click_link 'Edit'
     end
-    
-    expect(page).to have_checked_field "Controlled vocabulary"
-    expect(page).to have_unchecked_field "Free text"
 
-    visit spotlight.exhibit_edit_facets_path exhibit
-    expect(page).to have_content "My new custom field"
+    expect(page).to have_checked_field 'Controlled vocabulary'
+    expect(page).to have_unchecked_field 'Free text'
+
+    visit spotlight.edit_exhibit_search_configuration_path exhibit
+    expect(page).to have_content 'My new custom field'
   end
 end