blacklight-spotlight 0.4.1 → 0.5.0

data/spec/features/add_contacts_spec.rb

@@ -1,61 +1,61 @@
 require 'spec_helper'
 
-describe "Add a contact to an exhibit", :type => :feature do
+describe 'Add a contact to an exhibit', type: :feature do
   let(:curator) { FactoryGirl.create(:exhibit_curator) }
   let(:exhibit) { curator.roles.first.exhibit }
   let!(:about_page) { FactoryGirl.create(:about_page, exhibit: exhibit) }
   before { login_as curator }
-  it "should display a newly added contact in the sidebar" do
+  it 'displays a newly added contact in the sidebar' do
     visit spotlight.exhibit_about_pages_path(exhibit)
-    click_link "Add contact"
-    within "#new_contact" do
-      fill_in "Name", with: "Marcus Aurelius"
-      fill_in "Email", with: "marcus@rome.gov"
-      fill_in "Title", with: "Emperor"
-      fill_in "Location", with: "Rome"
-      fill_in "Telephone", with: "(555) 555-5555 ext. 12345 (mobile)"
-
-      click_button "Save"
+    click_link 'Add contact'
+    within '#new_contact' do
+      fill_in 'Name', with: 'Marcus Aurelius'
+      fill_in 'Email', with: 'marcus@rome.gov'
+      fill_in 'Title', with: 'Emperor'
+      fill_in 'Location', with: 'Rome'
+      fill_in 'Telephone', with: '(555) 555-5555 ext. 12345 (mobile)'
+
+      click_button 'Save'
     end
-    expect(page).to have_content "The contact was created."
+    expect(page).to have_content 'The contact was created.'
 
-    within ".contacts_admin" do
-      check "exhibit_contacts_attributes_0_show_in_sidebar"
+    within '.contacts_admin' do
+      check 'exhibit_contacts_attributes_0_show_in_sidebar'
     end
-    within ".exhibit-contacts" do
-      click_button "Save changes"
+    within '.exhibit-contacts' do
+      click_button 'Save changes'
     end
 
-    expect(page).to have_content "Contacts were successfully updated."
+    expect(page).to have_content 'Contacts were successfully updated.'
 
-    within "#nested-pages" do
-      click_link "View"
+    within '#nested-pages' do
+      click_link 'View'
     end
 
-    within "#sidebar .contacts" do
-      expect(page).to have_selector ".name", text: "Marcus Aurelius"
-      expect(page).to have_selector "div", text: "marcus@rome.gov"
-      expect(page).to have_selector "div", text: "Emperor"
-      expect(page).to have_selector "div", text: "Rome"
-      expect(page).to have_selector "div", text: "(555) 555-5555 ext. 12345 (mobile)"
-      expect(page).to_not have_selector "img.contact-photo"
+    within '#sidebar .contacts' do
+      expect(page).to have_selector '.name', text: 'Marcus Aurelius'
+      expect(page).to have_selector 'div', text: 'marcus@rome.gov'
+      expect(page).to have_selector 'div', text: 'Emperor'
+      expect(page).to have_selector 'div', text: 'Rome'
+      expect(page).to have_selector 'div', text: '(555) 555-5555 ext. 12345 (mobile)'
+      expect(page).to_not have_selector 'img.contact-photo'
     end
   end
 
-  it "should allow the curator to crop the contact's avatar", js: true do
+  it "allows the curator to crop the contact's avatar", js: true do
     skip "Capyabara and jcrop don't play well together.."
 
     visit spotlight.exhibit_about_pages_path(exhibit)
-    click_link "Add contact"
+    click_link 'Add contact'
     page.document.synchronize do
-      find(".jcrop-holder");
+      find('.jcrop-holder')
     end
-    within "#new_contact" do
-      fill_in "Name", with: "Pictured User"
-      fill_in "Email", with: "marcus@rome.gov"
-      attach_file('contact_avatar', File.absolute_path(File.join(FIXTURES_PATH, 'avatar.png')));
+    within '#new_contact' do
+      fill_in 'Name', with: 'Pictured User'
+      fill_in 'Email', with: 'marcus@rome.gov'
+      attach_file('contact_avatar', File.absolute_path(File.join(FIXTURES_PATH, 'avatar.png')))
     end
-    expect(page).to have_content "The contact was created."
+    expect(page).to have_content 'The contact was created.'
     expect(page).to have_selector 'img.contact-photo'
   end
 end

data/spec/features/add_custom_field_metadata_spec.rb

@@ -1,56 +1,54 @@
 require 'spec_helper'
 
-describe "Adding custom metadata field data", :type => :feature do
-  let(:exhibit) { FactoryGirl.create(:exhibit) }
+describe 'Adding custom metadata field data', type: :feature do
+  let(:exhibit) { FactoryGirl.create(:default_exhibit) }
   let(:admin) { FactoryGirl.create(:exhibit_admin, exhibit: exhibit) }
   let(:custom_field) { FactoryGirl.create(:custom_field, exhibit: exhibit) }
   let(:config) { exhibit.blacklight_configuration }
   before do
     login_as(admin)
-    config.index_fields[custom_field.field] = { enabled: true, show: true, 'label' => "Some Field" }
+    config.index_fields[custom_field.field] = { enabled: true, show: true, 'label' => 'Some Field' }
     config.save!
   end
 
-  it "should work" do
-    visit spotlight.exhibit_catalog_path(exhibit, "dq287tq6352")
+  it 'works' do
+    visit spotlight.exhibit_catalog_path(exhibit, 'dq287tq6352')
 
-    expect(page).to have_link "Edit"
+    expect(page).to have_link 'Edit'
 
-    click_on "Edit"
+    click_on 'Edit'
 
-    fill_in "Some Field", with: "My new custom field value"
+    fill_in 'Some Field', with: 'My new custom field value'
 
-    click_on "Save changes"
+    click_on 'Save changes'
 
-    expect(::SolrDocument.find("dq287tq6352").sidecar(exhibit).data).to include "field_name_tesim" => "My new custom field value"
+    expect(::SolrDocument.find('dq287tq6352').sidecar(exhibit).data).to include 'field_name_tesim' => 'My new custom field value'
     sleep(1) # The data isn't commited to solr immediately.
 
-    visit spotlight.exhibit_catalog_path(exhibit, "dq287tq6352")
-    expect(page).to have_content "Some Field"
-    expect(page).to have_content "My new custom field value"
-
+    visit spotlight.exhibit_catalog_path(exhibit, 'dq287tq6352')
+    expect(page).to have_content 'Some Field'
+    expect(page).to have_content 'My new custom field value'
   end
 
-  it "should have a public toggle" do
-    visit spotlight.exhibit_catalog_path(exhibit, "dq287tq6352")
-
-    expect(page).not_to have_selector ".blacklight-private"
+  it 'has a public toggle' do
+    visit spotlight.exhibit_catalog_path(exhibit, 'dq287tq6352')
 
-    click_on "Edit"
+    expect(page).not_to have_selector '.blacklight-private'
 
-    uncheck "Public"
+    click_on 'Edit'
 
-    click_on "Save changes"
+    uncheck 'Public'
 
-    expect(page).to have_selector ".blacklight-private"
+    click_on 'Save changes'
 
-    click_on "Edit"
+    expect(page).to have_selector '.blacklight-private'
 
-    check "Public"
+    click_on 'Edit'
 
-    click_on "Save changes"
+    check 'Public'
 
-    expect(page).not_to have_selector ".blacklight-private"
+    click_on 'Save changes'
 
+    expect(page).not_to have_selector '.blacklight-private'
   end
 end

data/spec/features/add_item_bookmarklet_spec.rb

@@ -1,33 +1,33 @@
 require 'spec_helper'
 
-describe "adding an item using the provided bookmarklet", :type => :feature do
-  let(:exhibit) { FactoryGirl.create(:exhibit) }
+describe 'adding an item using the provided bookmarklet', type: :feature do
+  let(:exhibit) { FactoryGirl.create(:default_exhibit) }
   let(:curator) { FactoryGirl.create(:exhibit_curator, exhibit: exhibit) }
   let(:search) { exhibit.searches.first }
   before { login_as curator }
 
   before do
-    Spotlight::Engine.config.new_resource_partials += ["spotlight/resources/bookmarklet"]
+    Spotlight::Engine.config.new_resource_partials += ['spotlight/resources/bookmarklet']
   end
 
-  it "should have an exhibit-specific bookmarklet" do
+  it 'has an exhibit-specific bookmarklet' do
     visit spotlight.admin_exhibit_catalog_index_path(exhibit)
-    click_link "Add repository item"
+    click_link 'Add repository item'
 
-    expect(page).to have_content "Drag this button to the bookmarks toolbar in your web browser"
+    expect(page).to have_content 'Drag this button to the bookmarks toolbar in your web browser'
     expect(page).to have_link "#{exhibit.title} - Blacklight widget"
   end
 
-  it "should trigger the bookmarklet" do
+  it 'triggers the bookmarklet' do
     # magic.
   end
 
-  it "should submit the form to create a new item" do
+  it 'submits the form to create a new item' do
     allow_any_instance_of(Spotlight::Resource).to receive(:reindex)
-    visit spotlight.new_exhibit_resource_path(exhibit, popup: true, resource: { url: "info:url" })
-    expect(page).to have_content "Add Resource"
+    visit spotlight.new_exhibit_resource_path(exhibit, popup: true, resource: { url: 'info:url' })
+    expect(page).to have_content 'Add Resource'
     expect(first('#resource_url', visible: false).value).to eq 'info:url'
-    click_button "Create Resource"
-    expect(Spotlight::Resource.last.url).to eq "info:url"
+    click_button 'Create Resource'
+    expect(Spotlight::Resource.last.url).to eq 'info:url'
   end
 end

data/spec/features/browse_category_admin_spec.rb

@@ -1,77 +1,77 @@
-require "spec_helper"
+require 'spec_helper'
 
-describe "Browse Category Administration", :type => :feature do
-  let(:exhibit) { FactoryGirl.create(:exhibit) }
+describe 'Browse Category Administration', type: :feature do
+  let(:exhibit) { FactoryGirl.create(:default_exhibit) }
   let(:curator) { FactoryGirl.create(:exhibit_curator, exhibit: exhibit) }
-  let!(:search) { FactoryGirl.create(:search, exhibit: exhibit, query_params: { f: { "genre_ssim" => ["Value"]}}) }
+  let!(:search) { FactoryGirl.create(:search, exhibit: exhibit, query_params: { f: { 'genre_ssim' => ['Value'] } }) }
   before { login_as curator }
-  describe "index" do
-    it "should have searches" do
+  describe 'index' do
+    it 'has searches' do
       visit spotlight.exhibit_searches_path(exhibit)
-      expect(page).to have_css(".panel .search .title", text: search.title)
+      expect(page).to have_css('.panel .search .title', text: search.title)
     end
   end
-  describe "edit" do
-    it "should display an edit form" do
+  describe 'edit' do
+    it 'displays an edit form' do
       visit spotlight.edit_exhibit_search_path(exhibit, search)
-      expect(page).to have_css("h1 small", text: "Edit Browse Category")
-      expect(find_field("search_title").value).to eq search.title
-      within ".appliedFilter" do
-        expect(page).to have_content "Genre"
-        expect(page).to have_content "Value"
+      expect(page).to have_css('h1 small', text: 'Edit Browse Category')
+      expect(find_field('search_title').value).to eq search.title
+      within '.appliedFilter' do
+        expect(page).to have_content 'Genre'
+        expect(page).to have_content 'Value'
       end
     end
-    
-    it 'should attach a masthead image' do
+
+    it 'attaches a masthead image' do
       visit spotlight.edit_exhibit_search_path exhibit, search
 
-      click_link "Masthead"
-      
-      within "#search-masthead" do
-        choose "Upload an image"
-        attach_file('search_masthead_attributes_image', File.absolute_path(File.join(FIXTURES_PATH, 'avatar.png')));
+      click_link 'Masthead'
+
+      within '#search-masthead' do
+        choose 'Upload an image'
+        attach_file('search_masthead_attributes_image', File.absolute_path(File.join(FIXTURES_PATH, 'avatar.png')))
       end
 
-      click_button "Save changes"
+      click_button 'Save changes'
 
-      expect(page).to have_content("The search was successfully updated.")
+      expect(page).to have_content('The search was successfully updated.')
 
       search.reload
 
       expect(search.masthead).not_to be nil
       expect(search.masthead.image.cropped).not_to be_nil
-      expect(search.masthead.image.path).to end_with "avatar.png"
+      expect(search.masthead.image.path).to end_with 'avatar.png'
     end
 
-    it 'should attach a thumbnail image' do
+    it 'attaches a thumbnail image' do
       visit spotlight.edit_exhibit_search_path exhibit, search
 
-      click_link "Thumbnail"
-      
-      within "#search-thumbnail" do
-        choose "Upload an image"
-        attach_file('search_thumbnail_attributes_image', File.absolute_path(File.join(FIXTURES_PATH, 'avatar.png')));
+      click_link 'Thumbnail'
+
+      within '#search-thumbnail' do
+        choose 'Upload an image'
+        attach_file('search_thumbnail_attributes_image', File.absolute_path(File.join(FIXTURES_PATH, 'avatar.png')))
       end
 
-      click_button "Save changes"
+      click_button 'Save changes'
 
-      expect(page).to have_content("The search was successfully updated.")
+      expect(page).to have_content('The search was successfully updated.')
 
       search.reload
 
       expect(search.thumbnail).not_to be nil
       expect(search.thumbnail.image.thumb).not_to be_nil
-      expect(search.thumbnail.image.path).to end_with "avatar.png"
+      expect(search.thumbnail.image.path).to end_with 'avatar.png'
     end
   end
-  describe "destroy" do
-    it "should destroy a tag" do
-      skip("TODO: Allow searches to be destroyed without javascript")
+  describe 'destroy' do
+    it 'destroys a tag' do
+      skip('TODO: Allow searches to be destroyed without javascript')
       visit spotlight.exhibit_searches_path(exhibit)
-      within(".panel .search") do
-        click_link("Delete")
+      within('.panel .search') do
+        click_link('Delete')
       end
-      expect(page).to have_content("Search was deleted")
+      expect(page).to have_content('Search was deleted')
       expect(page).not_to have_content(search.title)
     end
   end

data/spec/features/catalog_spec.rb

@@ -1,9 +1,8 @@
-require "spec_helper"
+require 'spec_helper'
 
-describe "Catalog", :type => :feature do
-
-  describe "admin" do
-    let(:exhibit) { FactoryGirl.create(:exhibit) }
+describe 'Catalog', type: :feature do
+  describe 'admin' do
+    let(:exhibit) { FactoryGirl.create(:default_exhibit) }
     let(:curator) { FactoryGirl.create(:exhibit_curator, exhibit: exhibit) }
 
     before do
@@ -13,7 +12,7 @@ describe "Catalog", :type => :feature do
       d.reindex
       Blacklight.default_index.connection.commit
     end
-    
+
     after do
       d = SolrDocument.new(id: 'dq287tq6352')
       d.make_public! exhibit
@@ -21,15 +20,15 @@ describe "Catalog", :type => :feature do
       Blacklight.default_index.connection.commit
     end
 
-    it "should have a 'Item Visiblity' facet" do
+    it "has a 'Item Visiblity' facet" do
       visit spotlight.exhibit_catalog_index_path(exhibit)
-      expect(page).to have_selector '.panel-title', text: "Item Visibility"
+      expect(page).to have_selector '.panel-title', text: 'Item Visibility'
     end
   end
   describe 'Non-spotlight #show' do
-    it 'should be able to render without exhibit context' do
+    it 'is able to render without exhibit context' do
       visit catalog_path('dq287tq6352')
-      expect(page).to have_css "h1", text: "L'AMERIQUE"
+      expect(page).to have_css 'h1', text: "L'AMERIQUE"
     end
   end
 end

data/spec/features/confirm_email_spec.rb

@@ -1,21 +1,21 @@
 require 'spec_helper'
 
-describe "Confirming an email", :type => :feature do
-  let(:exhibit) { FactoryGirl.create(:exhibit) }
-  let(:contact_email) { Spotlight::ContactEmail.create!(:email=> 'justin@example.com', exhibit: exhibit ) }
+describe 'Confirming an email', type: :feature do
+  let(:exhibit) { FactoryGirl.create(:default_exhibit) }
+  let(:contact_email) { Spotlight::ContactEmail.create!(email: 'justin@example.com', exhibit: exhibit) }
   let(:raw_token) { contact_email.instance_variable_get(:@raw_confirmation_token) }
 
-  it "should resend confirmation instructions" do
-    visit spotlight.new_contact_email_confirmation_url(:confirmation_token => contact_email.confirmation_token)
-    expect(page).to have_content("Resend confirmation instructions")
+  it 'resends confirmation instructions' do
+    visit spotlight.new_contact_email_confirmation_url(confirmation_token: contact_email.confirmation_token)
+    expect(page).to have_content('Resend confirmation instructions')
     within '#new_contact_email' do
       fill_in 'Email', with: contact_email.email
-      click_button "Resend confirmation instructions"
+      click_button 'Resend confirmation instructions'
     end
   end
 
-  it "should confirm email" do
-    visit spotlight.contact_email_confirmation_url(:confirmation_token => raw_token)
-    expect(page).to have_content("successfully confirmed")
+  it 'confirms email' do
+    visit spotlight.contact_email_confirmation_url(confirmation_token: raw_token)
+    expect(page).to have_content('successfully confirmed')
   end
 end

data/spec/features/create_exhibit_spec.rb

@@ -1,38 +1,41 @@
 require 'spec_helper'
 
-describe "Create a new exhibit", :type => :feature do
+describe 'Create a new exhibit', type: :feature do
   let(:user) { FactoryGirl.create(:site_admin) }
-  before {login_as user}
+  before do
+    allow_any_instance_of(Spotlight::Search).to receive(:set_default_featured_image)
+    login_as user
+  end
 
-  it "should have a link in the user dropdown" do
+  it 'has a link in the user dropdown' do
     visit '/'
     within '.dropdown-menu' do
-      click_link "Create Exhibit"
+      click_link 'Create Exhibit'
     end
-    expect(page).to have_selector "h1", text: "Administration"
-    expect(page).to have_selector "h1 small", text: "Create a new exhibit"
+    expect(page).to have_selector 'h1', text: 'Administration'
+    expect(page).to have_selector 'h1 small', text: 'Create a new exhibit'
   end
 
-  it 'should have a contact emails field' do
+  it 'has a contact emails field' do
     visit '/'
     within '.dropdown-menu' do
-      click_link "Create Exhibit"
+      click_link 'Create Exhibit'
     end
     expect(page).to have_css('#exhibit_contact_emails_attributes_0_email')
   end
 
-  it "should allow admins to create a new exhibit" do
+  it 'allows admins to create a new exhibit' do
     visit '/'
     within '.dropdown-menu' do
-      click_link "Create Exhibit"
+      click_link 'Create Exhibit'
     end
 
-    fill_in "Title", with: "My exhibit title"
-    fill_in "Subtitle", with: "Some subtitle"
-    fill_in "Description", with: "A short description of the exhibit"
+    fill_in 'Title', with: 'My exhibit title'
+    fill_in 'Subtitle', with: 'Some subtitle'
+    fill_in 'Description', with: 'A short description of the exhibit'
 
-    click_button "Save"
+    click_button 'Save'
 
-    expect(page).to have_content "The exhibit was created."
+    expect(page).to have_content 'The exhibit was created.'
   end
 end