blacklight-spotlight 0.4.1 → 0.5.0

data/spec/views/_user_util_links.html.erb_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 module Spotlight
-  describe "_user_util_links", :type => :view do
+  describe '_user_util_links', type: :view do
     let(:current_exhibit) { FactoryGirl.create(:exhibit) }
     before do
       allow(view).to receive(:blacklight_config).and_return(Blacklight::Configuration.new)
@@ -10,30 +10,30 @@ module Spotlight
       allow(view).to receive_messages(show_contact_form?: true)
     end
 
-    describe "when user is not logged in" do
+    describe 'when user is not logged in' do
       let(:current_user) { nil }
-      it "renders the links" do
+      it 'renders the links' do
         render
         expect(rendered).to have_link 'Sign in'
         expect(rendered).to have_link 'Feedback'
       end
     end
 
-    describe "when show_contact_form is false" do
+    describe 'when show_contact_form is false' do
       let(:current_user) { nil }
       before do
         allow(view).to receive_messages(show_contact_form?: false)
       end
-  
-      it "should not render the feedback link" do
+
+      it 'does not render the feedback link' do
         render
         expect(rendered).to_not have_link 'Feedback'
       end
     end
 
-    describe "when user is logged in" do
+    describe 'when user is logged in' do
       let(:current_user) { ::User.new }
-      it "renders the links" do
+      it 'renders the links' do
         render
         expect(rendered).to have_link 'Feedback'
         expect(rendered).to_not have_link 'Dashboard'
@@ -41,28 +41,28 @@ module Spotlight
       end
     end
 
-    describe "when user is a curator" do
+    describe 'when user is a curator' do
       let(:current_user) { ::User.new }
       before do
         allow(view).to receive(:can?).with(:update, current_exhibit).and_return(false)
         allow(view).to receive(:can?).with(:create, Spotlight::Exhibit).and_return(false)
         allow(view).to receive(:can?).with(:curate, current_exhibit).and_return(true)
       end
-      it "renders the links" do
+      it 'renders the links' do
         render
         expect(rendered).to have_link 'Feedback'
         expect(rendered).to have_link 'Dashboard'
         expect(rendered).to have_link 'Sign out'
       end
     end
-    describe "when user is an admin" do
+    describe 'when user is an admin' do
       let(:current_user) { ::User.new }
       before do
         allow(view).to receive(:can?).with(:update, current_exhibit).and_return(true)
         allow(view).to receive(:can?).with(:create, Spotlight::Exhibit).and_return(false)
         allow(view).to receive(:can?).with(:curate, current_exhibit).and_return(true)
       end
-      it "renders the links" do
+      it 'renders the links' do
         render
         expect(rendered).to have_link 'Feedback'
         expect(rendered).to have_link 'Dashboard'
@@ -70,14 +70,14 @@ module Spotlight
       end
     end
 
-    describe "when user is a site-wide admin" do
+    describe 'when user is a site-wide admin' do
       let(:current_user) { ::User.new }
       before do
         allow(view).to receive(:can?).with(:update, current_exhibit).and_return(true)
         allow(view).to receive(:can?).with(:create, Spotlight::Exhibit).and_return(true)
         allow(view).to receive(:can?).with(:curate, current_exhibit).and_return(true)
       end
-      it "renders the links" do
+      it 'renders the links' do
         render
         expect(rendered).to have_link 'Feedback'
         expect(rendered).to have_link 'Dashboard'

data/spec/views/shared/_analytics.html.erb_spec.rb

@@ -1,19 +1,17 @@
 require 'spec_helper'
 
 module Spotlight
-  describe "shared/_analytics", :type => :view do
-  
-    it "should be empty without Google Analytics configured" do
+  describe 'shared/_analytics', type: :view do
+    it 'is empty without Google Analytics configured' do
       render
       expect(rendered).to be_empty
     end
 
-    it "should render the GA script tag if the web property id is configured" do
-      allow(Spotlight::Engine.config).to receive(:ga_web_property_id).and_return("XYZ-234")
+    it 'renders the GA script tag if the web property id is configured' do
+      allow(Spotlight::Engine.config).to receive(:ga_web_property_id).and_return('XYZ-234')
       render
       expect(rendered).to have_selector 'script', visible: false
       expect(rendered).to have_content 'XYZ-234'
     end
   end
 end
-

data/spec/views/shared/_exhibit_masthead.html.erb_spec.rb

@@ -1,12 +1,12 @@
 require 'spec_helper'
 
 module Spotlight
-  describe "shared/_exhibit_masthead", :type => :view do
+  describe 'shared/_exhibit_masthead', type: :view do
     let(:masthead) { Spotlight::Masthead.new }
-    let(:search) { double(title: "Search Title", count: '12') }
-    let(:current_exhibit) { double(title: "Some title", subtitle: "Subtitle", masthead: masthead) }
-    let(:current_masthead) { double() }
-    let(:current_exhibit_without_subtitle) { double(title: "Some title", subtitle: nil, masthead: masthead) }
+    let(:search) { double(title: 'Search Title', count: '12') }
+    let(:current_exhibit) { double(title: 'Some title', subtitle: 'Subtitle', masthead: masthead) }
+    let(:current_masthead) { double }
+    let(:current_exhibit_without_subtitle) { double(title: 'Some title', subtitle: nil, masthead: masthead) }
     before do
       allow(view).to receive_messages(exhibit_masthead?: true)
       allow(view).to receive_messages(current_masthead: nil)
@@ -14,29 +14,29 @@ module Spotlight
     end
 
     describe 'title' do
-      it "should display the title and subtitle" do
+      it 'displays the title and subtitle' do
         allow(view).to receive_messages(current_exhibit: current_exhibit)
         render
-        expect(rendered).to have_selector('.site-title', text: "Some title")
-        expect(rendered).to have_selector('.site-title small', text: "Subtitle")
+        expect(rendered).to have_selector('.site-title', text: 'Some title')
+        expect(rendered).to have_selector('.site-title small', text: 'Subtitle')
       end
 
-      it "should display just the title" do
+      it 'displays just the title' do
         allow(view).to receive_messages(current_exhibit: current_exhibit_without_subtitle)
         render
-        expect(rendered).to have_selector('.site-title', text: "Some title")
+        expect(rendered).to have_selector('.site-title', text: 'Some title')
         expect(rendered).to_not have_selector('.site-title small')
       end
     end
 
     describe 'masthead from exhibit' do
       before { allow(view).to receive_messages(current_exhibit: current_exhibit) }
-      it 'should not include the background element when there is no masthead' do
+      it 'does not include the background element when there is no masthead' do
         render
         expect(rendered).to_not have_selector('.background-container')
         expect(rendered).to_not have_selector('.background-container-gradient')
       end
-      it 'should include the background image from the current exhibit' do
+      it 'includes the background image from the current exhibit' do
         allow(view).to receive_messages(current_masthead: current_masthead)
         render
         expect(rendered).to have_selector('.background-container[style="background-image: url(\'/uploads/image.jpg\')"]')
@@ -45,7 +45,7 @@ module Spotlight
     end
 
     describe 'masthead from search' do
-      let(:search_masthead) { "CUSTOM MASTHEAD" }
+      let(:search_masthead) { 'CUSTOM MASTHEAD' }
       before do
         allow(view).to receive_messages(current_exhibit: current_exhibit)
         allow(view).to receive_messages(current_masthead: current_masthead)
@@ -54,18 +54,17 @@ module Spotlight
         allow(view).to receive(:content_for).with(:masthead).and_return(search_masthead)
         render
       end
-      it 'should include the background image from the current search' do
+      it 'includes the background image from the current search' do
         expect(rendered).to have_selector('.background-container[style="background-image: url(\'/uploads/image.jpg\')"]')
         expect(rendered).to have_selector('.background-container-gradient')
       end
-      it 'should not include the exhibit title when there is a current search masthead' do
-        expect(rendered).to_not have_selector('.site-title', text: "Some title")
-        expect(rendered).to_not have_selector('.site-title small', text: "Subtitle")
+      it 'does not include the exhibit title when there is a current search masthead' do
+        expect(rendered).to_not have_selector('.site-title', text: 'Some title')
+        expect(rendered).to_not have_selector('.site-title small', text: 'Subtitle')
       end
-      it 'should include the search title and count when there is a current search masthead' do
+      it 'includes the search title and count when there is a current search masthead' do
         expect(rendered).to have_content search_masthead
       end
     end
-
   end
-end
+end

data/spec/views/shared/_exhibit_navbar.html.erb_spec.rb

@@ -1,135 +1,133 @@
 require 'spec_helper'
 
-module Spotlight
-  describe "shared/_exhibit_navbar", :type => :view do
-    let(:current_exhibit) { FactoryGirl.create(:exhibit) }
-    let(:feature_page) { FactoryGirl.create(:feature_page, exhibit: current_exhibit) }
-    let(:unpublished_feature_page) { FactoryGirl.create(:feature_page, published: false, exhibit: current_exhibit) }
-    let(:about_page) { FactoryGirl.create(:about_page, exhibit: current_exhibit) }
-    let(:unpublished_about_page) { FactoryGirl.create(:about_page, published: false, exhibit: current_exhibit) }
-
-    before :each do
-      allow(view).to receive_messages(exhibit_masthead?: true)
-      allow(view).to receive_messages(current_exhibit: current_exhibit)
-      allow(view).to receive_messages(on_browse_page?: false, on_about_page?: false)
-      allow(view).to receive_messages(render_search_bar: "Search Bar")
-      allow(view).to receive_messages(exhibit_path: spotlight.exhibit_path(current_exhibit))
-    end
-
-    it 'should link to the exhibit home page (as branding) when there is a current search masthead' do
-      allow(view).to receive_messages(exhibit_masthead?: false)
-      render
-      expect(response).to have_selector("a.navbar-brand", text: current_exhibit.title)
-    end
-
-    it "should link to the search page if no home page is defined" do
-      render
-      expect(response).to have_link "Home", href: spotlight.exhibit_path(current_exhibit)
-    end
-
-    it "should link to the home page" do
-      allow(current_exhibit).to receive_messages home_page: feature_page
-      render
-      expect(response).to have_link "Home", href: spotlight.exhibit_path(current_exhibit)
-    end
-
-    it "should link directly to a single feature page" do
-      feature_page
-      render
-      expect(response).to have_link feature_page.title, href: spotlight.exhibit_feature_page_path(current_exhibit, feature_page)
-    end
-
-    it "should provide a dropdown of multiple feature pages" do
-      feature_page
-      another_page = FactoryGirl.create(:feature_page, exhibit: current_exhibit)
-      render
-      expect(response).to have_selector ".dropdown .dropdown-toggle", text: "Curated Features"
-      expect(response).to have_link feature_page.title, visible: false, href: spotlight.exhibit_feature_page_path(current_exhibit, feature_page)
-      expect(response).to have_link another_page.title, visible: false,  href: spotlight.exhibit_feature_page_path(current_exhibit, another_page)
-    end
-
-    it "should not display links to feature pages if none are defined" do
-      render
-      expect(response).to_not have_link "Curated Features"
-    end
-
-    it "should not display links to feature pages that are not published" do
-      unpublished_feature_page
-      render
-      expect(response).to_not have_link "Curated Features"
-    end
-
-    it "should link to the browse index if there's a published search" do
-      FactoryGirl.create :published_search, exhibit: current_exhibit
-      render
-      expect(response).to have_link "Browse", href: spotlight.exhibit_browse_index_path(current_exhibit)
-    end
-
-    it "should mark the browse button as active if we're on a browse page" do
-      FactoryGirl.create :published_search, exhibit: current_exhibit
-      allow(view).to receive_messages(on_browse_page?: true)
-      render
-      expect(response).to have_selector "li.active", text: "Browse"
-    end
-
-    it "should not link to the browse index if no categories are defined" do
-      render
-      expect(response).not_to have_link "Browse"
-    end
-
-    it "should not link to the browse index if only private categories are defined" do
-      FactoryGirl.create :search, exhibit: current_exhibit
-      render
-      expect(response).not_to have_link "Browse"
-    end
-
-    it "should link to the about page" do
-      allow(current_exhibit).to receive_messages main_about_page: about_page
-      render
-      expect(response).to have_link "About", href: spotlight.exhibit_about_page_path(current_exhibit, about_page)
-    end
-
-    it "should not link to the about page if no about page exists" do
-      render
-      expect(response).to_not have_link "About"
-    end
-
-    it "should not to the about page if none are published" do
-      unpublished_about_page
-      render
-      expect(response).to_not have_link "About"
-    end
-
-    it "should  mark the about button as active if we're on an about page" do
-      allow(current_exhibit).to receive_messages main_about_page: about_page
-      allow(view).to receive_messages(on_about_page?: true)
-      render
-      expect(response).to have_selector "li.active", text: "About"
-    end
-
-    it 'should include the search bar when the exhibit is searchable' do
-      expect(current_exhibit).to receive(:searchable?).and_return(true)
-      render
-      expect(response).to have_content "Search Bar"
-    end
-
-    it 'should not include the search bar when the exhibit is searchable' do
-      expect(current_exhibit).to receive(:searchable?).and_return(false)
-      render
-      expect(response).to_not have_content "Search Bar"
-    end
-
-    it 'should not include the search bar when there is a current search masthead' do
-      allow(view).to receive_messages(exhibit_masthead?: false)
-      render
-      expect(response).to_not have_content "Search Bar"
-    end
-
-    it 'should not include any navigation menu items that are not configured' do
-      expect(current_exhibit.main_navigations).to receive_messages(displayable: [])
-      render
-      expect(response).to have_css('.navbar-nav li', count: 1)
-      expect(response).to have_css('.navbar-nav li', text: "Home")
-    end
+describe 'shared/_exhibit_navbar', type: :view do
+  let(:current_exhibit) { FactoryGirl.create(:exhibit) }
+  let(:feature_page) { FactoryGirl.create(:feature_page, exhibit: current_exhibit) }
+  let(:unpublished_feature_page) { FactoryGirl.create(:feature_page, published: false, exhibit: current_exhibit) }
+  let(:about_page) { FactoryGirl.create(:about_page, exhibit: current_exhibit) }
+  let(:unpublished_about_page) { FactoryGirl.create(:about_page, published: false, exhibit: current_exhibit) }
+
+  before :each do
+    allow(view).to receive_messages(exhibit_masthead?: true)
+    allow(view).to receive_messages(current_exhibit: current_exhibit)
+    allow(view).to receive_messages(on_browse_page?: false, on_about_page?: false)
+    allow(view).to receive_messages(render_search_bar: 'Search Bar')
+    allow(view).to receive_messages(exhibit_path: spotlight.exhibit_path(current_exhibit))
+  end
+
+  it 'links to the exhibit home page (as branding) when there is a current search masthead' do
+    allow(view).to receive_messages(exhibit_masthead?: false)
+    render
+    expect(response).to have_selector('a.navbar-brand', text: current_exhibit.title)
+  end
+
+  it 'links to the search page if no home page is defined' do
+    render
+    expect(response).to have_link 'Home', href: spotlight.exhibit_path(current_exhibit)
+  end
+
+  it 'links to the home page' do
+    allow(current_exhibit).to receive_messages home_page: feature_page
+    render
+    expect(response).to have_link 'Home', href: spotlight.exhibit_path(current_exhibit)
+  end
+
+  it 'links directly to a single feature page' do
+    feature_page
+    render
+    expect(response).to have_link feature_page.title, href: spotlight.exhibit_feature_page_path(current_exhibit, feature_page)
+  end
+
+  it 'provides a dropdown of multiple feature pages' do
+    feature_page
+    another_page = FactoryGirl.create(:feature_page, exhibit: current_exhibit)
+    render
+    expect(response).to have_selector '.dropdown .dropdown-toggle', text: 'Curated Features'
+    expect(response).to have_link feature_page.title, visible: false, href: spotlight.exhibit_feature_page_path(current_exhibit, feature_page)
+    expect(response).to have_link another_page.title, visible: false, href: spotlight.exhibit_feature_page_path(current_exhibit, another_page)
+  end
+
+  it 'does not display links to feature pages if none are defined' do
+    render
+    expect(response).to_not have_link 'Curated Features'
+  end
+
+  it 'does not display links to feature pages that are not published' do
+    unpublished_feature_page
+    render
+    expect(response).to_not have_link 'Curated Features'
+  end
+
+  it "links to the browse index if there's a published search" do
+    FactoryGirl.create :published_search, exhibit: current_exhibit
+    render
+    expect(response).to have_link 'Browse', href: spotlight.exhibit_browse_index_path(current_exhibit)
+  end
+
+  it "marks the browse button as active if we're on a browse page" do
+    FactoryGirl.create :published_search, exhibit: current_exhibit
+    allow(view).to receive_messages(on_browse_page?: true)
+    render
+    expect(response).to have_selector 'li.active', text: 'Browse'
+  end
+
+  it 'does not link to the browse index if no categories are defined' do
+    render
+    expect(response).not_to have_link 'Browse'
+  end
+
+  it 'does not link to the browse index if only private categories are defined' do
+    FactoryGirl.create :search, exhibit: current_exhibit
+    render
+    expect(response).not_to have_link 'Browse'
+  end
+
+  it 'links to the about page' do
+    allow(current_exhibit).to receive_messages main_about_page: about_page
+    render
+    expect(response).to have_link 'About', href: spotlight.exhibit_about_page_path(current_exhibit, about_page)
+  end
+
+  it 'does not link to the about page if no about page exists' do
+    render
+    expect(response).to_not have_link 'About'
+  end
+
+  it 'does not to the about page if none are published' do
+    unpublished_about_page
+    render
+    expect(response).to_not have_link 'About'
+  end
+
+  it "marks the about button as active if we're on an about page" do
+    allow(current_exhibit).to receive_messages main_about_page: about_page
+    allow(view).to receive_messages(on_about_page?: true)
+    render
+    expect(response).to have_selector 'li.active', text: 'About'
+  end
+
+  it 'includes the search bar when the exhibit is searchable' do
+    expect(current_exhibit).to receive(:searchable?).and_return(true)
+    render
+    expect(response).to have_content 'Search Bar'
+  end
+
+  it 'does not include the search bar when the exhibit is searchable' do
+    expect(current_exhibit).to receive(:searchable?).and_return(false)
+    render
+    expect(response).to_not have_content 'Search Bar'
+  end
+
+  it 'does not include the search bar when there is a current search masthead' do
+    allow(view).to receive_messages(exhibit_masthead?: false)
+    render
+    expect(response).to_not have_content 'Search Bar'
+  end
+
+  it 'does not include any navigation menu items that are not configured' do
+    expect(current_exhibit.main_navigations).to receive_messages(displayable: [])
+    render
+    expect(response).to have_css('.navbar-nav li', count: 1)
+    expect(response).to have_css('.navbar-nav li', text: 'Home')
   end
 end