blacklight-spotlight 0.4.1 → 0.5.0

data/spec/controllers/spotlight/solr_controller_spec.rb

@@ -2,17 +2,17 @@ require 'spec_helper'
 
 describe Spotlight::SolrController, type: :controller do
   routes { Spotlight::Engine.routes }
-  let(:exhibit) {FactoryGirl.create(:exhibit) }
+  let(:exhibit) { FactoryGirl.create(:exhibit) }
 
-  describe "when user does not have access" do
+  describe 'when user does not have access' do
     before { sign_in FactoryGirl.create(:exhibit_visitor) }
-    it "should not allow update" do
+    it 'does not allow update' do
       post :update, exhibit_id: exhibit
       expect(response).to redirect_to main_app.root_path
     end
   end
-  
-  describe "when user is an admin" do
+
+  describe 'when user is an admin' do
     let(:admin) { FactoryGirl.create(:site_admin) }
     let(:role) { admin.roles.first }
     let(:solr) { double }
@@ -21,31 +21,31 @@ describe Spotlight::SolrController, type: :controller do
       expect(controller).to receive(:blacklight_solr).and_return(solr)
     end
 
-    it "should pass through the request data" do
+    it 'passes through the request data' do
       doc = {}
       expect(solr).to receive(:update) do |arr|
         doc = arr.first
       end
 
-      post :update, {a: 1}.to_json, content_type: :json, exhibit_id: exhibit
+      post :update, { a: 1 }.to_json, content_type: :json, exhibit_id: exhibit
 
       expect(response).to be_successful
-      expect(doc).to include "a" => 1
+      expect(doc).to include 'a' => 1
     end
 
-    it "should enrich the request with exhibit solr data" do
+    it 'enriches the request with exhibit solr data' do
       doc = {}
       expect(solr).to receive(:update) do |arr|
         doc = arr.first
       end
 
-      post :update, {a: 1}.to_json, content_type: :json, exhibit_id: exhibit
+      post :update, { a: 1 }.to_json, content_type: :json, exhibit_id: exhibit
 
       expect(response).to be_successful
       expect(doc).to include exhibit.solr_data
     end
 
-    it "should enrich the request with sidecar data" do
+    it 'enriches the request with sidecar data' do
       doc = {}
       expect(solr).to receive(:update) do |arr|
         doc = arr.first
@@ -53,11 +53,10 @@ describe Spotlight::SolrController, type: :controller do
 
       allow_any_instance_of(SolrDocument).to receive(:to_solr).and_return(b: 1)
 
-      post :update, {a: 1}.to_json, content_type: :json, exhibit_id: exhibit
+      post :update, { a: 1 }.to_json, content_type: :json, exhibit_id: exhibit
 
       expect(response).to be_successful
       expect(doc).to include b: 1
     end
   end
-
-end
+end

data/spec/controllers/spotlight/tags_controller_spec.rb

@@ -1,42 +1,42 @@
 require 'spec_helper'
 
-describe Spotlight::TagsController, :type => :controller do
+describe Spotlight::TagsController, type: :controller do
   routes { Spotlight::Engine.routes }
   let(:exhibit) { FactoryGirl.create(:exhibit) }
 
-  describe "when not signed in" do
-    describe "GET index" do
-      it "should redirect to sign inl" do
+  describe 'when not signed in' do
+    describe 'GET index' do
+      it 'redirects to sign inl' do
         get :index, exhibit_id: exhibit
         expect(response).to redirect_to main_app.new_user_session_path
       end
     end
   end
-  describe "when signed in as a curator" do
-    before {sign_in FactoryGirl.create(:exhibit_curator, exhibit: exhibit)} 
-    describe "GET index" do
-      it "should be successful" do
-        expect(controller).to receive(:add_breadcrumb).with("Home", exhibit)
-        expect(controller).to receive(:add_breadcrumb).with("Curation", exhibit_dashboard_path(exhibit))
-        expect(controller).to receive(:add_breadcrumb).with("Tags", exhibit_tags_path(exhibit))
+  describe 'when signed in as a curator' do
+    before { sign_in FactoryGirl.create(:exhibit_curator, exhibit: exhibit) }
+    describe 'GET index' do
+      it 'is successful' do
+        expect(controller).to receive(:add_breadcrumb).with('Home', exhibit)
+        expect(controller).to receive(:add_breadcrumb).with('Curation', exhibit_dashboard_path(exhibit))
+        expect(controller).to receive(:add_breadcrumb).with('Tags', exhibit_tags_path(exhibit))
         get :index, exhibit_id: exhibit
         expect(response).to be_successful
         expect(assigns[:tags]).to eq []
         expect(assigns[:exhibit]).to eq exhibit
       end
 
-      it "should have a json serialization" do
+      it 'has a json serialization' do
         get :index, exhibit_id: exhibit, format: 'json'
         expect(response).to be_successful
       end
     end
 
-    describe "DELETE destroy" do
+    describe 'DELETE destroy' do
       let!(:tagging) { FactoryGirl.create(:tagging, tagger: exhibit) }
-      it "should be successful" do
-        expect {
+      it 'is successful' do
+        expect do
           delete :destroy, exhibit_id: exhibit, id: tagging.tag
-        }.to change { ActsAsTaggableOn::Tagging.count }.by(-1)
+        end.to change { ActsAsTaggableOn::Tagging.count }.by(-1)
         expect(response).to redirect_to exhibit_tags_path(exhibit)
       end
     end

data/spec/controllers/spotlight/versions_controller_spec.rb

@@ -1,20 +1,18 @@
 require 'spec_helper'
 
 describe Spotlight::VersionsController, type: :controller do
- 
-  routes { Spotlight::Engine.routes } 
+  routes { Spotlight::Engine.routes }
 
-  describe "when not logged in" do
-    describe "POST revert" do
-      it "should not be allowed" do
+  describe 'when not logged in' do
+    describe 'POST revert' do
+      it 'does not be allowed' do
         post :revert, id: 1
         expect(response).to redirect_to main_app.new_user_session_path
       end
     end
   end
-  
-  describe "when not authorized for the exhibit resource" do
-    
+
+  describe 'when not authorized for the exhibit resource' do
     let(:exhibit) { FactoryGirl.create(:exhibit) }
     let(:user) { FactoryGirl.create(:exhibit_visitor) }
     let!(:page) { FactoryGirl.create(:feature_page, exhibit: exhibit) }
@@ -22,8 +20,8 @@ describe Spotlight::VersionsController, type: :controller do
       sign_in user
     end
 
-    describe "POST revert" do
-      it "should not be allowed" do
+    describe 'POST revert' do
+      it 'does not be allowed' do
         post :revert, id: page.versions.last
         expect(response).to redirect_to main_app.root_path
         expect(flash[:alert]).to be_present
@@ -31,8 +29,7 @@ describe Spotlight::VersionsController, type: :controller do
     end
   end
 
-  describe "when logged in as a curator" do
-    
+  describe 'when logged in as a curator' do
     let(:exhibit) { FactoryGirl.create(:exhibit) }
     let(:user) { FactoryGirl.create(:exhibit_curator) }
     let!(:page) { FactoryGirl.create(:feature_page, exhibit: exhibit) }
@@ -41,18 +38,18 @@ describe Spotlight::VersionsController, type: :controller do
       sign_in user
     end
 
-    describe "POST revert" do
-      it "should revert the change" do
-        page.title = "xyz"
+    describe 'POST revert' do
+      it 'reverts the change' do
+        page.title = 'xyz'
         page.save!
 
         post :revert, id: page.versions.last
         page.reload
-        expect(page.title).not_to eq "xyz"
+        expect(page.title).not_to eq 'xyz'
         expect(response).to redirect_to [exhibit, page]
         expect(flash[:notice]).to be_present
-        expect(flash[:notice]).to match /Redo changes/
+        expect(flash[:notice]).to match(/Redo changes/)
       end
     end
   end
-end
+end

data/spec/controllers/spotlight/view_configurations_controller_spec.rb

@@ -0,0 +1,31 @@
+require 'spec_helper'
+describe Spotlight::ViewConfigurationsController, type: :controller do
+  routes { Spotlight::Engine.routes }
+  let(:exhibit) { FactoryGirl.create(:exhibit) }
+
+  describe 'when the user is not authorized' do
+    before do
+      sign_in FactoryGirl.create(:exhibit_visitor)
+    end
+
+    it 'denies access' do
+      get :show, exhibit_id: exhibit
+      expect(response).to redirect_to main_app.root_path
+      expect(flash[:alert]).to be_present
+    end
+  end
+
+  describe 'when signed in' do
+    let(:user) { FactoryGirl.create(:exhibit_admin, exhibit: exhibit) }
+    before { sign_in user }
+
+    describe '#show' do
+      it 'is successful' do
+        get :show, exhibit_id: exhibit, format: 'json'
+        expect(response).to be_successful
+        available = JSON.parse(response.body)
+        expect(available).to match_array %w(list gallery slideshow)
+      end
+    end
+  end
+end

data/spec/factories/contacts.rb

@@ -1,8 +1,6 @@
 FactoryGirl.define do
   factory :contact, class: Spotlight::Contact do
     exhibit
-    avatar { Rack::Test::UploadedFile.new(File.join(FIXTURES_PATH, "avatar.png")) }
+    avatar { Rack::Test::UploadedFile.new(File.join(FIXTURES_PATH, 'avatar.png')) }
   end
 end
-  
-

data/spec/factories/custom_fields.rb

@@ -1,9 +1,7 @@
 FactoryGirl.define do
   factory :custom_field, class: Spotlight::CustomField do
     exhibit
-    field "field_name_tesim"
-    configuration({ "label" => "Some Field" })
+    field 'field_name_tesim'
+    configuration('label' => 'Some Field')
   end
 end
-  
-

data/spec/factories/exhibits.rb

@@ -3,6 +3,8 @@ FactoryGirl.define do
     sequence(:title) { |n| "Exhibit Title #{n}" }
     after(:build) { |exhibit| exhibit.searches << FactoryGirl.build(:default_search) }
   end
-end
-  
 
+  factory :default_exhibit, parent: :exhibit do
+    default true
+  end
+end

data/spec/factories/pages.rb

@@ -1,29 +1,26 @@
 FactoryGirl.define do
   factory :feature_page, class: Spotlight::FeaturePage do
     exhibit
-    title "Page1"
-    published  true
-    content "[]"
+    title 'Page1'
+    published true
+    content '[]'
   end
   factory :feature_subpage, parent: :feature_page do
     transient do
       exhibit
     end
-    title "SubPage1"
-    content "[]"
+    title 'SubPage1'
+    content '[]'
     after(:build) { |subpage, evaluator| subpage.parent_page = FactoryGirl.create(:feature_page, exhibit: evaluator.exhibit) }
   end
   factory :about_page, class: Spotlight::AboutPage do
     exhibit
-    title "Page1"
-    content "[]"
-    published  true
+    title 'Page1'
+    content '[]'
+    published true
   end
 
   factory :home_page, class: Spotlight::HomePage do
     exhibit
-    title "Page1"
   end
 end
-  
-

data/spec/factories/resources.rb

@@ -1,11 +1,11 @@
 FactoryGirl.define do
   factory :resource, class: Spotlight::Resource do
     exhibit
-    type "Spotlight::Resource"
-    url "some url"
+    type 'Spotlight::Resource'
+    url 'some url'
   end
   factory :uploaded_resource, class: Spotlight::Resources::Upload, parent: :resource do
-    type "Spotlight::Resources::Upload"
-    url { Rack::Test::UploadedFile.new(File.join(FIXTURES_PATH, "avatar.png")) }
+    type 'Spotlight::Resources::Upload'
+    url { Rack::Test::UploadedFile.new(File.join(FIXTURES_PATH, 'avatar.png')) }
   end
 end

data/spec/factories/searches.rb

@@ -1,26 +1,23 @@
 FactoryGirl.define do
   factory :search, class: Spotlight::Search do
     exhibit
-    title "Search1"
+    title 'Search1'
+
+    after(:build) { |search| search.thumbnail = FactoryGirl.create(:featured_image) }
   end
 
-  factory :published_search, class: Spotlight::Search do
-    exhibit
-    title "Search1"
-    on_landing_page true
+  factory :published_search, parent: :search do
+    published true
   end
 
   factory :default_search, class: Spotlight::Search do
-    title "All Exhibit Items"
-    long_description "All items in this exhibit."
-    
-    after(:build) { |search| search.thumbnail = FactoryGirl.create(:featured_image)}
+    title 'All Exhibit Items'
+    long_description 'All items in this exhibit.'
+
+    after(:build) { |search| search.thumbnail = FactoryGirl.create(:featured_image) }
   end
 
   factory :featured_image, class: Spotlight::FeaturedImage do
-    image { File.open(File.join(FIXTURES_PATH, "avatar.png")) }
+    image { File.open(File.join(FIXTURES_PATH, 'avatar.png')) }
   end
 end
-  
-
-

data/spec/factories/tags.rb

@@ -9,6 +9,3 @@ FactoryGirl.define do
     context :tags
   end
 end
-  
-
-

data/spec/factories/users.rb

@@ -4,10 +4,10 @@ FactoryGirl.define do
       exhibit { FactoryGirl.create(:exhibit) }
     end
     sequence(:email) { |n| "user#{n}@example.com" }
-    password "insecure"
+    password 'insecure'
 
     factory :site_admin do
-      after(:create) do |user, evaluator|
+      after(:create) do |user, _evaluator|
         create_list(:role, 1, user: user, exhibit_id: nil, role: 'admin')
       end
     end
@@ -24,8 +24,6 @@ FactoryGirl.define do
     end
 
     factory :exhibit_visitor do
-      
     end
   end
 end
-  

data/spec/features/about_page_spec.rb

@@ -1,42 +1,42 @@
-require "spec_helper"
+require 'spec_helper'
 
-describe "About page", :type => :feature do
-  let(:exhibit) { FactoryGirl.create(:exhibit) }
+describe 'About page', type: :feature do
+  let(:exhibit) { FactoryGirl.create(:default_exhibit) }
   let(:exhibit_curator) { FactoryGirl.create(:exhibit_curator, exhibit: exhibit) }
-  let!(:about_page1) { FactoryGirl.create(:about_page, title: "First Page", exhibit: exhibit) }
-  let!(:about_page2) { FactoryGirl.create(:about_page, title: "Second Page", exhibit: exhibit) }
-  let(:unpublished_page) { FactoryGirl.create(:about_page, title: "Unpublished Page", published: false, exhibit: exhibit) }
-  describe "sidebar" do
-    it "should display" do
+  let!(:about_page1) { FactoryGirl.create(:about_page, title: 'First Page', exhibit: exhibit) }
+  let!(:about_page2) { FactoryGirl.create(:about_page, title: 'Second Page', exhibit: exhibit) }
+  let(:unpublished_page) { FactoryGirl.create(:about_page, title: 'Unpublished Page', published: false, exhibit: exhibit) }
+  describe 'sidebar' do
+    it 'displays' do
       visit spotlight.exhibit_about_page_path(about_page1.exhibit, about_page1)
       # the sidebar should display
-      within("#sidebar") do
+      within('#sidebar') do
         # within the sidebar navigation
-        within("ul.sidenav") do
+        within('ul.sidenav') do
           # the current page should be active
-          expect(page).to have_css("li.active", text: about_page1.title)
+          expect(page).to have_css('li.active', text: about_page1.title)
           # the other page should be linked
-          expect(page).to have_css("li a", text: about_page2.title)
+          expect(page).to have_css('li a', text: about_page2.title)
         end
       end
     end
   end
-  describe "page options" do
+  describe 'page options' do
     before { login_as exhibit_curator }
-    describe "publish" do
-      it "should be updatable from the edit page" do
+    describe 'publish' do
+      it 'is updatable from the edit page' do
         expect(unpublished_page).not_to be_published
 
         visit spotlight.edit_exhibit_about_page_path(unpublished_page.exhibit, unpublished_page)
-        expect(find("#about_page_published")).not_to be_checked
+        expect(find('#about_page_published')).not_to be_checked
 
-        check "Publish"
-        click_button "Save changes"
+        check 'Publish'
+        click_button 'Save changes'
 
         expect(unpublished_page.reload).to be_published
 
         visit spotlight.edit_exhibit_about_page_path(unpublished_page.exhibit, unpublished_page)
-        expect(find("#about_page_published")).to be_checked
+        expect(find('#about_page_published')).to be_checked
       end
     end
   end