blacklight-spotlight 0.4.1 → 0.5.0

data/spec/views/shared/_footer.html.erb_spec.rb

@@ -1,20 +1,20 @@
 require 'spec_helper'
 
 module Spotlight
-  describe "shared/_footer", :type => :view do
-    let(:current_exhibit) { double(title: "Some title", subtitle: "Subtitle") }
+  describe 'shared/_footer', type: :view do
+    let(:current_exhibit) { double(title: 'Some title', subtitle: 'Subtitle') }
 
     before do
       allow(view).to receive_messages(current_exhibit: current_exhibit)
     end
 
-    it "should include analytics reporting" do
-      stub_template "shared/_analytics.html.erb" => "analytics"
+    it 'includes analytics reporting' do
+      stub_template 'shared/_analytics.html.erb' => 'analytics'
       render
-      expect(rendered).to have_content "analytics"
+      expect(rendered).to have_content 'analytics'
     end
 
-    it "should display social media links" do
+    it 'displays social media links' do
       render
       expect(rendered).to have_selector('footer .social-share-button a.social-share-button-twitter[title="Twitter"]')
       expect(rendered).to have_selector('footer .social-share-button a.social-share-button-facebook[title="Facebook"]')
@@ -22,4 +22,3 @@ module Spotlight
     end
   end
 end
-

data/spec/views/shared/_header_navbar.html.erb_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 module Spotlight
-  describe "shared/_header_navbar", :type => :view do
+  describe 'shared/_header_navbar', type: :view do
     let(:current_exhibit) { FactoryGirl.create(:exhibit) }
     let(:masthead) { 'exhibit-masthead' }
     let(:navbar) { 'exhibit-navbar' }
@@ -14,20 +14,20 @@ module Spotlight
       allow(view).to receive_messages(exhibit_masthead?: true)
       allow(view).to receive_messages(current_exhibit: current_exhibit)
     end
-    it 'should render the masthead above the navbar' do
+    it 'renders the masthead above the navbar' do
       render
       expect(rendered.index(masthead)).to be < rendered.index(navbar)
     end
-    it 'should render the navbar above the search masthead' do
+    it 'renders the navbar above the search masthead' do
       allow(view).to receive_messages(exhibit_masthead?: false)
       render
       expect(rendered.index(navbar)).to be < rendered.index(masthead)
     end
-    it 'should render the breadcrumbs' do
+    it 'renders the breadcrumbs' do
       render
       expect(rendered).to have_content(breadcrumbs)
     end
-    it 'should not render breadcrumbs when there is a search masthead' do
+    it 'does not render breadcrumbs when there is a search masthead' do
       allow(view).to receive_messages(exhibit_masthead?: false)
       render
       expect(rendered).to_not have_content(breadcrumbs)

data/spec/views/spotlight/about_pages/_empty.html.erb_spec.rb

@@ -1,22 +1,22 @@
 require 'spec_helper'
 
-describe "spotlight/about_pages/_empty.html.erb", :type => :view do
+describe 'spotlight/about_pages/_empty.html.erb', type: :view do
   let(:can?) { false }
   before do
     allow(view).to receive_messages(can?: can?)
     render
   end
   describe 'when a user cannot edit' do
-    it 'should not render an ordered list of steps' do
+    it 'does not render an ordered list of steps' do
       expect(rendered).to_not have_css('ol')
     end
   end
   describe 'when a user can edit' do
     let(:can?) { true }
-    it 'should render a heading' do
+    it 'renders a heading' do
       expect(rendered).to have_css('h2', text: 'Building this about page')
     end
-    it 'should render an ordered list of steps' do
+    it 'renders an ordered list of steps' do
       expect(rendered).to have_css('ol li', count: 6)
     end
   end

data/spec/views/spotlight/about_pages/_sidebar.html.erb_spec.rb

@@ -1,23 +1,21 @@
 require 'spec_helper'
 
-describe "spotlight/about_pages/_sidebar.html.erb", :type => :view do
+describe 'spotlight/about_pages/_sidebar.html.erb', type: :view do
   let(:exhibit) { FactoryGirl.create(:exhibit) }
-  let!(:page1) { FactoryGirl.create(:about_page, title: "One", weight: 4, exhibit: exhibit) }
-  let!(:page2) { FactoryGirl.create(:about_page, exhibit: exhibit, title: "Two", published: false) }
-  let!(:page3) { FactoryGirl.create(:about_page, exhibit: exhibit, title: "Three", weight: 3) }
-  
+  let!(:page1) { FactoryGirl.create(:about_page, title: 'One', weight: 4, exhibit: exhibit) }
+  let!(:page2) { FactoryGirl.create(:about_page, exhibit: exhibit, title: 'Two', published: false) }
+  let!(:page3) { FactoryGirl.create(:about_page, exhibit: exhibit, title: 'Three', weight: 3) }
+
   before do
     allow(view).to receive_messages(current_exhibit: exhibit)
     allow(view).to receive_messages(exhibit_about_page_path: '/about/9')
   end
 
-  it "renders a list of pages" do
+  it 'renders a list of pages' do
     render
     # Checking that they are sorted accoding to weight
-    expect(rendered).to have_selector "#sidebar ul.sidenav li:nth-child(1) a", text: "Three"
-    expect(rendered).to have_selector "#sidebar ul.sidenav li:nth-child(2) a", text: "One"
-    expect(rendered).not_to have_link "Two"
+    expect(rendered).to have_selector '#sidebar ul.sidenav li:nth-child(1) a', text: 'Three'
+    expect(rendered).to have_selector '#sidebar ul.sidenav li:nth-child(2) a', text: 'One'
+    expect(rendered).not_to have_link 'Two'
   end
 end
-
-

data/spec/views/spotlight/about_pages/index.html.erb_spec.rb

@@ -1,34 +1,38 @@
 require 'spec_helper'
 
-describe "spotlight/about_pages/index.html.erb", :type => :view do
-  let(:pages) {[
+describe 'spotlight/about_pages/index.html.erb', type: :view do
+  let(:pages) do
+    [
       stub_model(Spotlight::AboutPage,
-        title: "Title1",
-        content: "[]",
-        exhibit: exhibit
-      ),
+                 title: 'Title1',
+                 content: '[]',
+                 exhibit: exhibit
+                ),
       stub_model(Spotlight::AboutPage,
-        title: "Title2",
-        content: "[]",
-        exhibit: exhibit
-      )
-    ]}
-  let(:contacts) {[
+                 title: 'Title2',
+                 content: '[]',
+                 exhibit: exhibit
+                )
+    ]
+  end
+  let(:contacts) do
+    [
       stub_model(Spotlight::Contact,
-        exhibit: exhibit
-      ),
+                 exhibit: exhibit
+                ),
       stub_model(Spotlight::Contact,
-        exhibit: exhibit
-      )
-    ]}
+                 exhibit: exhibit
+                )
+    ]
+  end
   let(:exhibit) { stub_model(Spotlight::Exhibit) }
   before do
     allow(view).to receive(:disable_save_pages_button?).and_return(false)
     allow(view).to receive(:page_collection_name).and_return(:about_pages)
-    allow(view).to receive(:update_all_exhibit_about_pages_path).and_return("/exhibit/about/update_all")
-    allow(view).to receive(:exhibit_contacts_path).and_return("/exhibit/1/contacts")
+    allow(view).to receive(:update_all_exhibit_about_pages_path).and_return('/exhibit/about/update_all')
+    allow(view).to receive(:exhibit_contacts_path).and_return('/exhibit/1/contacts')
     allow(view).to receive(:nestable_data_attributes).and_return('data-behavior="nestable"')
-    allow(exhibit).to receive_messages(:contacts => contacts)
+    allow(exhibit).to receive_messages(contacts: contacts)
     assign(:page, Spotlight::AboutPage.new)
     assign(:exhibit, exhibit)
     allow(view).to receive(:current_exhibit).and_return(exhibit)
@@ -36,7 +40,7 @@ describe "spotlight/about_pages/index.html.erb", :type => :view do
     allow(view).to receive(:can?).and_return(true)
   end
 
-  it "renders a list of pages and contacts" do
+  it 'renders a list of pages and contacts' do
     assign(:pages, pages)
     allow(exhibit).to receive(:about_pages).and_return pages
     render
@@ -49,20 +53,19 @@ describe "spotlight/about_pages/index.html.erb", :type => :view do
     expect(rendered).to have_selector '.contacts_admin ol.dd-list li input#exhibit_contacts_attributes_1_id'
   end
 
-  describe "Save button" do
-    it "should be disabled the when the pages are blank" do
+  describe 'Save button' do
+    it 'is disabled the when the pages are blank' do
       allow(view).to receive(:disable_save_pages_button?).and_return(true)
       assign(:pages, [])
       render
-      expect(rendered).to have_selector 'button[disabled]', text: "Save changes"
+      expect(rendered).to have_selector 'button[disabled]', text: 'Save changes'
     end
-    it "should not be disabled the when there are pages" do
+    it 'does not be disabled the when there are pages' do
       allow(view).to receive(:disable_save_pages_button?).and_return(false)
       assign(:pages, [{}])
       render
-      expect(rendered).not_to have_selector 'button[disabled]', text: "Save changes"
-      expect(rendered).to     have_selector 'button',           text: "Save changes"
+      expect(rendered).not_to have_selector 'button[disabled]', text: 'Save changes'
+      expect(rendered).to have_selector 'button', text: 'Save changes'
     end
   end
-
 end

data/spec/views/spotlight/browse/_search.html.erb_spec.rb

@@ -1,29 +1,29 @@
 require 'spec_helper'
 
-describe 'spotlight/browse/search', :type => :view do
+describe 'spotlight/browse/search', type: :view do
   let(:search) { FactoryGirl.create(:search) }
   let(:exhibit) { FactoryGirl.create(:exhibit) }
   before :each do
     allow(search).to receive_messages(count: 15)
-    allow(search).to receive_message_chain(:thumbnail, :image, thumb: "/some/image")
+    allow(search).to receive_message_chain(:thumbnail, :image, thumb: '/some/image')
   end
 
   before :each do
     assign :exhibit, exhibit
   end
 
-  it "should display the image" do
+  it 'displays the image' do
     render partial: 'spotlight/browse/search', locals: { search: search }
     expect(response).to have_selector 'a img'
   end
 
-  it "should have a heading" do
+  it 'has a heading' do
     render partial: 'spotlight/browse/search', locals: { search: search }
     expect(response).to have_link search.title, href: spotlight.exhibit_browse_path(exhibit, search)
   end
 
-  it "should display the item count" do
+  it 'displays the item count' do
     render partial: 'spotlight/browse/search', locals: { search: search }
-    expect(response).to have_selector "small", text: /#{search.count} items/i
+    expect(response).to have_selector 'small', text: /#{search.count} items/i
   end
 end

data/spec/views/spotlight/browse/_sort_and_per_page.html.erb_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
-describe "spotlight/browse/_sort_and_per_page", :type => :view do
-
+describe 'spotlight/browse/_sort_and_per_page', type: :view do
   let :blacklight_config do
     Blacklight::Configuration.new
   end
@@ -10,16 +9,15 @@ describe "spotlight/browse/_sort_and_per_page", :type => :view do
     allow(view).to receive_messages(blacklight_config: blacklight_config)
   end
 
-  it "should render the pagination, sort, per page and view type controls" do
-    stub_template "_paginate_compact.html.erb" => "paginate_compact\n"
-    stub_template "_sort_widget.html.erb" => "sort_widget\n"
-    stub_template "_per_page_widget.html.erb" => "per_page_widget\n"
-    stub_template "_view_type_group.html.erb" => "view_type_group\n"
+  it 'renders the pagination, sort, per page and view type controls' do
+    stub_template '_paginate_compact.html.erb' => "paginate_compact\n"
+    stub_template '_sort_widget.html.erb' => "sort_widget\n"
+    stub_template '_per_page_widget.html.erb' => "per_page_widget\n"
+    stub_template '_view_type_group.html.erb' => "view_type_group\n"
     render
-    expect(rendered).to_not have_content "paginate_compact"
-    expect(rendered).to have_content "sort_widget"
-    expect(rendered).to have_content "per_page_widget"
-    expect(rendered).to have_content "view_type_group"
+    expect(rendered).to_not have_content 'paginate_compact'
+    expect(rendered).to have_content 'sort_widget'
+    expect(rendered).to have_content 'per_page_widget'
+    expect(rendered).to have_content 'view_type_group'
   end
-
 end

data/spec/views/spotlight/browse/index.html.erb_spec.rb

@@ -1,18 +1,18 @@
 require 'spec_helper'
 
-describe "spotlight/browse/index", :type => :view do
+describe 'spotlight/browse/index', type: :view do
   let(:search) { FactoryGirl.create(:search) }
   let(:another_search) { FactoryGirl.create(:search) }
 
-  it "should have a title" do
+  it 'has a title' do
     render
-    expect(response).to have_selector 'h1', text: "Browse Exhibit"
+    expect(response).to have_selector 'h1', text: 'Browse Exhibit'
   end
 
-  it "should render the collection of searches" do
+  it 'renders the collection of searches' do
     assign :searches, [search, another_search]
-    stub_template "spotlight/browse/_search.html.erb" => "<%= search.id %> <br/>"
+    stub_template 'spotlight/browse/_search.html.erb' => '<%= search.id %> <br/>'
     render
     expect(response).to have_content "#{search.id} #{another_search.id}"
   end
-end
+end

data/spec/views/spotlight/browse/show.html.erb_spec.rb

@@ -1,17 +1,17 @@
 require 'spec_helper'
 
-describe 'spotlight/browse/show', :type => :view do
+describe 'spotlight/browse/show', type: :view do
   let(:search) { FactoryGirl.create(:published_search) }
   let(:exhibit) { FactoryGirl.create(:exhibit) }
 
   before :each do
     allow(view).to receive_messages(exhibit_masthead?: true)
-    allow(view).to receive_messages(blacklight_config: Blacklight::Configuration.new )
+    allow(view).to receive_messages(blacklight_config: Blacklight::Configuration.new)
     view.blacklight_config.view.gallery = true
     allow(search).to receive_messages(count: 15)
-    allow(view).to receive_messages(render_document_index_with_view: "")
-    stub_template("_results_pagination.html.erb" => "")
-    stub_template("_sort_and_per_page.html.erb" => "Sort and Per Page actions")
+    allow(view).to receive_messages(render_document_index_with_view: '')
+    stub_template('_results_pagination.html.erb' => '')
+    stub_template('_sort_and_per_page.html.erb' => 'Sort and Per Page actions')
   end
 
   before :each do
@@ -20,40 +20,39 @@ describe 'spotlight/browse/show', :type => :view do
     assign :document_list, []
   end
 
-  it "should have a heading and item count when there is no current search masthead" do
+  it 'has a heading and item count when there is no current search masthead' do
     render
     expect(response).to have_selector 'h1', text: search.title
-    expect(response).to have_selector ".item-count", text: "#{search.count} items"
+    expect(response).to have_selector '.item-count', text: "#{search.count} items"
   end
 
-  it 'should not have the heading and item count when there is a current search masthead' do
+  it 'does not have the heading and item count when there is a current search masthead' do
     allow(view).to receive_messages(exhibit_masthead?: false)
     render
     expect(response).to_not have_selector 'h1', text: search.title
-    expect(response).to_not have_selector ".item-count", text: "#{search.count} items"
+    expect(response).to_not have_selector '.item-count', text: "#{search.count} items"
   end
 
-  it "should have an edit button" do
+  it 'has an edit button' do
     allow(view).to receive_messages(can?: true)
     render
     expect(response).to have_selector '.btn', text: 'Edit'
   end
 
-  it "should display the long description" do
-    allow(search).to receive_messages(long_description: "Long description")
+  it 'displays the long description' do
+    allow(search).to receive_messages(long_description: 'Long description')
     render
-    expect(response).to have_selector "p", text: search.long_description
+    expect(response).to have_selector 'p', text: search.long_description
   end
-  
-  it "should display search results actions" do
+
+  it 'displays search results actions' do
     render
-    expect(response).to have_content "Sort and Per Page actions"
-    
+    expect(response).to have_content 'Sort and Per Page actions'
   end
 
-  it "should display the search results" do
-    expect(view).to receive(:render_document_index_with_view).with(:gallery, anything, anything).and_return "Gallery View"
+  it 'displays the search results' do
+    expect(view).to receive(:render_document_index_with_view).with(:gallery, anything, anything).and_return 'Gallery View'
     render
-    expect(response).to match /Gallery View/
+    expect(response).to include 'Gallery View'
   end
 end

data/spec/views/spotlight/catalog/_edit_default.html.erb_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe "spotlight/catalog/_edit_default.html.erb", :type => :view do
+describe 'spotlight/catalog/_edit_default.html.erb', type: :view do
   let(:blacklight_config) do
     Blacklight::Configuration.new do |config|
       config.index.title_field = :title_field
@@ -17,31 +17,31 @@ describe "spotlight/catalog/_edit_default.html.erb", :type => :view do
     allow(view).to receive(:uploaded_field_label) do |config|
       "#{config.field_name} label"
     end
-    allow(view).to receive_messages(exhibit_tags_path: "autocomplete-path.json")
+    allow(view).to receive_messages(exhibit_tags_path: 'autocomplete-path.json')
     allow(view).to receive_messages(blacklight_config: blacklight_config)
     allow(view).to receive_messages(current_exhibit: exhibit)
     allow(view).to receive_messages(document: document)
     allow(view).to receive(:can?).and_return(true)
   end
 
-  it "should have a edit tag form" do
+  it 'has a edit tag form' do
     render
     expect(rendered).to have_field 'solr_document_exhibit_tag_list'
     expect(rendered).to have_selector '#solr_document_exhibit_tag_list[@data-autocomplete_url="autocomplete-path.json"]'
   end
-  it 'should not have special metadata editing fields for non-uploaded resources' do
+  it 'does not have special metadata editing fields for non-uploaded resources' do
     render
     expect(rendered).to_not have_field 'title_field label'
     expect(rendered).to_not have_field 'spotlight_upload_description_tesim label'
     expect(rendered).to_not have_field 'spotlight_upload_attribution_tesim label'
     expect(rendered).to_not have_field 'spotlight_upload_date_tesim label'
   end
-  it 'should have special metadata fields for an uploaded resource' do
-    allow(document).to receive_messages(:uploaded_resource? => true)
+  it 'has special metadata fields for an uploaded resource' do
+    allow(document).to receive_messages(uploaded_resource?: true)
     render
     expect(rendered).to have_field 'title_field label'
     expect(rendered).to have_field 'spotlight_upload_description_tesim label'
     expect(rendered).to have_field 'spotlight_upload_attribution_tesim label'
     expect(rendered).to have_field 'spotlight_upload_date_tesim label'
   end
-end
+end

data/spec/views/spotlight/catalog/admin.html.erb_spec.rb

@@ -1,8 +1,8 @@
 require 'spec_helper'
 
 module Spotlight
-  describe "spotlight/catalog/admin.html.erb", :type => :view do
-    let(:exhibit) { stub_model(Spotlight::Exhibit)}
+  describe 'spotlight/catalog/admin.html.erb', type: :view do
+    let(:exhibit) { stub_model(Spotlight::Exhibit) }
     before do
       allow(view).to receive(:blacklight_config).and_return(CatalogController.blacklight_config)
       allow(view).to receive(:spotlight_page_path_for).and_return(nil)
@@ -17,21 +17,21 @@ module Spotlight
       stub_template '_results_pagination.html.erb' => '0'
       allow(view).to receive(:can?).and_return(true)
     end
-    it "should render the sidebar" do
+    it 'renders the sidebar' do
       render
       expect(rendered).to have_link 'Browse'
     end
 
-    it "should not render the 'add repository item' link if no repository sources are configured" do
+    it "does not render the 'add repository item' link if no repository sources are configured" do
       allow(Spotlight::Engine.config).to receive(:new_resource_partials).and_return([])
       render
-      expect(rendered).to_not have_link "Add repository item"
+      expect(rendered).to_not have_link 'Add repository item'
     end
 
-    it "should not render the 'add repository item' link if no repository sources are configured" do
+    it "does not render the 'add repository item' link if no repository sources are configured" do
       allow(Spotlight::Engine.config).to receive(:new_resource_partials).and_return(['a'])
       render
-      expect(rendered).to have_link "Add repository item"
+      expect(rendered).to have_link 'Add repository item'
     end
   end
 end