blacklight-spotlight 0.4.1 → 0.5.0

data/spec/features/exhibits/edit_metadata_fields_spec.rb

@@ -1,14 +1,14 @@
 require 'spec_helper'
 
-describe "Editing metadata fields", type: :feature do
-  let(:exhibit) { FactoryGirl.create(:exhibit) }
+describe 'Editing metadata fields', type: :feature do
+  let(:exhibit) { FactoryGirl.create(:default_exhibit) }
   let(:admin) { FactoryGirl.create(:exhibit_admin, exhibit: exhibit) }
   before { login_as(admin) }
 
-  it "should work" do
-    visit spotlight.exhibit_edit_metadata_path exhibit
+  it 'works' do
+    visit spotlight.edit_exhibit_metadata_configuration_path exhibit
 
-    expect(page).to have_content "Display and Order Metadata Fields"
+    expect(page).to have_content 'Display and Order Metadata Fields'
 
     check :blacklight_configuration_index_fields_language_ssm_show
     check :blacklight_configuration_index_fields_abstract_tesim_show
@@ -18,31 +18,31 @@ describe "Editing metadata fields", type: :feature do
     check :blacklight_configuration_index_fields_language_ssm_list
     check :blacklight_configuration_index_fields_note_mapuse_tesim_list
 
-    click_on "Save changes"
+    click_on 'Save changes'
 
-    expect(exhibit.reload.blacklight_config.index_fields.select { |k, x| x.list }).to include 'language_ssm', 'note_mapuse_tesim'
-    expect(exhibit.blacklight_config.index_fields.select { |k, x| x.list }).to_not include 'abstract_tesim'
-    expect(exhibit.blacklight_config.show_fields.select { |k, x| x.show }).to include "language_ssm", "abstract_tesim"
-    expect(exhibit.blacklight_config.show_fields.select { |k, x| x.show }).to_not include "note_mapuse_tesim"
+    expect(exhibit.reload.blacklight_config.index_fields.select { |_k, x| x.list }).to include 'language_ssm', 'note_mapuse_tesim'
+    expect(exhibit.blacklight_config.index_fields.select { |_k, x| x.list }).to_not include 'abstract_tesim'
+    expect(exhibit.blacklight_config.show_fields.select { |_k, x| x.show }).to include 'language_ssm', 'abstract_tesim'
+    expect(exhibit.blacklight_config.show_fields.select { |_k, x| x.show }).to_not include 'note_mapuse_tesim'
   end
 
-  it "should have in-place editing of labels", js: true do
-    visit spotlight.exhibit_edit_metadata_path exhibit
+  it 'has in-place editing of labels', js: true do
+    visit spotlight.edit_exhibit_metadata_configuration_path exhibit
     check :blacklight_configuration_index_fields_language_ssm_show
     check :blacklight_configuration_index_fields_language_ssm_list
 
-    click_on "Language"
+    click_on 'Language'
 
     expect(page).to have_field :blacklight_configuration_index_fields_language_ssm_label, visible: true
-    fill_in :blacklight_configuration_index_fields_language_ssm_label, with: "Language of Origin"
+    fill_in :blacklight_configuration_index_fields_language_ssm_label, with: 'Language of Origin'
 
-    click_on "Save changes"
-    expect(exhibit.reload.blacklight_config.index_fields['language_ssm'].label).to eq "Language of Origin"
+    click_on 'Save changes'
+    expect(exhibit.reload.blacklight_config.index_fields['language_ssm'].label).to eq 'Language of Origin'
   end
 
-  it "should have breadcrumbs" do
-    visit spotlight.exhibit_edit_metadata_path exhibit
+  it 'has breadcrumbs' do
+    visit spotlight.edit_exhibit_metadata_configuration_path exhibit
 
-    expect(page).to have_breadcrumbs "Home", "Curation", "Metadata"
+    expect(page).to have_breadcrumbs 'Home', 'Curation', 'Metadata'
   end
 end

data/spec/features/feature_page_spec.rb

@@ -1,100 +1,101 @@
-require "spec_helper"
+require 'spec_helper'
 
-describe "Feature page", :type => :feature do
-  let(:exhibit) { FactoryGirl.create(:exhibit) }
+describe 'Feature page', type: :feature do
+  let(:exhibit) { FactoryGirl.create(:default_exhibit) }
   let(:exhibit_curator) { FactoryGirl.create(:exhibit_curator, exhibit: exhibit) }
-  describe "sidebar" do
-    let!(:parent_feature_page) { 
-      FactoryGirl.create(:feature_page, title: "Parent Page", exhibit: exhibit)
-    }
-    let!(:child_feature_page) {
+  describe 'sidebar' do
+    let!(:parent_feature_page) do
+      FactoryGirl.create(:feature_page, title: 'Parent Page', exhibit: exhibit)
+    end
+    let!(:child_feature_page) do
       FactoryGirl.create(
         :feature_page,
-        title: "Child Page",
+        title: 'Child Page',
         parent_page: parent_feature_page, exhibit: exhibit
       )
-    }
-    describe "when configured to display" do
-      before { parent_feature_page.display_sidebar = true;  parent_feature_page.save }
-      after  { parent_feature_page.display_sidebar = false; parent_feature_page.save }
-      it "should be present" do
+    end
+    describe 'when configured to display' do
+      before { parent_feature_page.update display_sidebar: true }
+      after { parent_feature_page.update display_sidebar: false }
+
+      it 'is present' do
         visit spotlight.exhibit_feature_page_path(parent_feature_page.exhibit, parent_feature_page)
         # the sidebar should display
-        within("#sidebar") do
+        within('#sidebar') do
           # the current page should be the sidebar header
-          expect(page).to have_css("h4", text: parent_feature_page.title)
+          expect(page).to have_css('h4', text: parent_feature_page.title)
           # within the sidebar navigation
-          within("ol.sidenav") do
+          within('ol.sidenav') do
             # there should be a link to the child page
-            expect(page).to have_css("li a", text: child_feature_page.title)
+            expect(page).to have_css('li a', text: child_feature_page.title)
           end
         end
       end
     end
-    describe "when configured to not display" do
-      before { parent_feature_page.display_sidebar = false;  parent_feature_page.save }
-      context "with a child page" do
-        it "should be present anyway" do
+    describe 'when configured to not display' do
+      before { parent_feature_page.update display_sidebar: false }
+      context 'with a child page' do
+        it 'is present anyway' do
           visit spotlight.exhibit_feature_page_path(parent_feature_page.exhibit, parent_feature_page)
-          expect(page).to have_css("#sidebar")
+          expect(page).to have_css('#sidebar')
           expect(page).to have_content(child_feature_page.title)
         end
       end
-      
-      context "with an unpublished child page" do
-        before { child_feature_page.published = false; child_feature_page.save }
-        it "should not be present" do
+
+      context 'with an unpublished child page' do
+        before { child_feature_page.update published: false }
+        it 'does not be present' do
           visit spotlight.exhibit_feature_page_path(parent_feature_page.exhibit, parent_feature_page)
-          expect(page).not_to have_css("#sidebar")
+          expect(page).not_to have_css('#sidebar')
           expect(page).not_to have_content(child_feature_page.title)
         end
       end
     end
   end
-  describe "page options" do
+  describe 'page options' do
     before { login_as exhibit_curator }
-    describe "publish" do
+    describe 'publish' do
       let!(:unpublished_page) { FactoryGirl.create(:feature_page, published: false, exhibit: exhibit) }
-      it "should be updatable from the edit page" do
+      it 'is updatable from the edit page' do
         expect(unpublished_page).not_to be_published
 
         visit spotlight.edit_exhibit_feature_page_path(unpublished_page.exhibit, unpublished_page)
-        expect(find("#feature_page_published")).not_to be_checked
+        expect(find('#feature_page_published')).not_to be_checked
 
-        check "Publish"
-        click_button "Save changes"
+        check 'Publish'
+        click_button 'Save changes'
 
         expect(unpublished_page.reload).to be_published
 
         visit spotlight.edit_exhibit_feature_page_path(unpublished_page.exhibit, unpublished_page)
-        expect(find("#feature_page_published")).to be_checked
+        expect(find('#feature_page_published')).to be_checked
       end
     end
-    describe "display_sidebar" do
+    describe 'display_sidebar' do
       let!(:feature_page) { FactoryGirl.create(:feature_page, display_sidebar: false, exhibit: exhibit) }
-      before { feature_page.display_sidebar = false; feature_page.save }
-      it "should be updatable from the edit page" do
+      before { feature_page.update display_sidebar: false }
+      it 'is updatable from the edit page' do
         expect(feature_page.display_sidebar?).to be_falsey
 
         visit spotlight.edit_exhibit_feature_page_path(feature_page.exhibit, feature_page)
-        expect(find("#feature_page_display_sidebar")).not_to be_checked
+        expect(find('#feature_page_display_sidebar')).not_to be_checked
 
-        check "Show sidebar"
-        click_button "Save changes"
+        check 'Show sidebar'
+        click_button 'Save changes'
 
         expect(feature_page.reload.display_sidebar?).to be_truthy
 
         visit spotlight.edit_exhibit_feature_page_path(feature_page.exhibit, feature_page)
-        expect(find("#feature_page_display_sidebar")).to be_checked
+        expect(find('#feature_page_display_sidebar')).to be_checked
       end
     end
   end
 
-  describe "page locking" do
+  describe 'page locking' do
     before { login_as exhibit_curator }
     let!(:feature_page) { FactoryGirl.create(:feature_page, display_sidebar: false, exhibit: exhibit) }
 
-    it "should show a lock message if someone is currently editing the page" do
+    it 'shows a lock message if someone is currently editing the page' do
       # open the edit page
       visit spotlight.edit_exhibit_feature_page_path(feature_page.exhibit, feature_page)
 
@@ -102,16 +103,16 @@ describe "Feature page", :type => :feature do
       visit spotlight.edit_exhibit_feature_page_path(feature_page.exhibit, feature_page)
 
       expect(page).to have_css '.alert'
-      within ".alert" do
-        expect(page).to have_content "This page is currently being edited by " + exhibit_curator.to_s
+      within '.alert' do
+        expect(page).to have_content 'This page is currently being edited by ' + exhibit_curator.to_s
       end
     end
 
-    it "should release the lock when the lock holder cancels edits", js: true do
+    it 'releases the lock when the lock holder cancels edits', js: true do
       # open the edit page
       visit spotlight.edit_exhibit_feature_page_path(feature_page.exhibit, feature_page)
 
-      click_on "Cancel"
+      click_on 'Cancel'
       sleep 2
 
       # and then open the edit page again

data/spec/features/home_page_spec.rb

@@ -1,57 +1,57 @@
-require "spec_helper"
-describe "Home page", :type => :feature do
-  let(:exhibit) { FactoryGirl.create(:exhibit) }
+require 'spec_helper'
+describe 'Home page', type: :feature do
+  let(:exhibit) { FactoryGirl.create(:default_exhibit) }
   let(:exhibit_curator) { FactoryGirl.create(:exhibit_curator, exhibit: exhibit) }
-  before {login_as exhibit_curator}
-  it "should exist by default on exhibits" do
+  before { login_as exhibit_curator }
+  it 'exists by default on exhibits' do
     visit spotlight.exhibit_home_page_path(exhibit, exhibit.home_page)
     within '#user-util-collapse .dropdown-menu' do
       click_link 'Dashboard'
     end
-    click_link "Feature pages"
-    expect(page).to have_selector "h3", text: "Homepage"
-    expect(page).to have_selector "h3.panel-title", text: "Exhibit Home"
+    click_link 'Feature pages'
+    expect(page).to have_selector 'h3', text: 'Homepage'
+    expect(page).to have_selector 'h3.panel-title', text: 'Exhibit Home'
   end
 
-  it "should allow users to edit the home page title" do
+  it 'allows users to edit the home page title' do
     visit spotlight.exhibit_home_page_path(exhibit, exhibit.home_page)
     within '#user-util-collapse .dropdown-menu' do
       click_link 'Dashboard'
     end
-    click_link "Feature pages"
-    within(".home_page") do
-      click_link "Edit"
+    click_link 'Feature pages'
+    within('.home_page') do
+      click_link 'Edit'
     end
-    fill_in "home_page_title", with: "New Home Page Title"
-    click_button "Save changes"
-    expect(page).to have_content("The home page was successfully updated.")
+    fill_in 'home_page_title', with: 'New Home Page Title'
+    click_button 'Save changes'
+    expect(page).to have_content('The home page was successfully updated.')
 
     within '.dropdown-menu' do
       click_link 'Dashboard'
     end
-    click_link "Feature pages"
-    expect(page).to have_content "New Home Page Title"
-    expect(page).to have_selector ".panel-title a", text: "New Home Page Title"
+    click_link 'Feature pages'
+    expect(page).to have_content 'New Home Page Title'
+    expect(page).to have_selector '.panel-title a', text: 'New Home Page Title'
   end
 
-  it "should have working facet links" do
+  it 'has working facet links' do
     visit spotlight.exhibit_home_page_path(exhibit.home_page)
-    click_link "Genre"
-    click_link "map"
+    click_link 'Genre'
+    click_link 'map'
     expect(page).to have_content exhibit.title
-    expect(page).to have_content "You searched for: Genre map"
+    expect(page).to have_content 'You searched for: Genre map'
   end
 
-  it "should have a search box" do
+  it 'has a search box' do
     visit spotlight.exhibit_home_page_path(exhibit.home_page)
-    fill_in "q", with: "query"
-    click_button "Search"
+    fill_in 'q', with: 'query'
+    click_button 'Search'
 
     expect(page).to have_content exhibit.title
-    expect(page).to have_content "You searched for: query"
+    expect(page).to have_content 'You searched for: query'
   end
 
-  it "should have <meta> tags" do
+  it 'has <meta> tags' do
     TopHat.current['twitter_card'] = nil
     visit spotlight.exhibit_home_page_path(exhibit.home_page)
 
@@ -59,32 +59,32 @@ describe "Home page", :type => :feature do
     expect(page).to have_css "meta[name='twitter:url'][value='#{spotlight.exhibit_root_url(exhibit)}']", visible: false
   end
 
-  describe "page options on edit form" do
-    describe "show title" do
+  describe 'page options on edit form' do
+    describe 'show title' do
       let(:home_page) { FactoryGirl.create(:home_page, display_title: false, exhibit: exhibit) }
-      it "should be updatable from the edit page" do
+      it 'is updatable from the edit page' do
         expect(home_page.display_title).to be_falsey
 
         visit spotlight.edit_exhibit_home_page_path(home_page.exhibit, home_page)
-        expect(find("#home_page_display_title")).not_to be_checked
+        expect(find('#home_page_display_title')).not_to be_checked
 
-        check "Show title"
-        click_button "Save changes"
+        check 'Show title'
+        click_button 'Save changes'
 
         visit spotlight.edit_exhibit_home_page_path(home_page.exhibit, home_page)
-        expect(find("#home_page_display_title")).to be_checked
+        expect(find('#home_page_display_title')).to be_checked
       end
     end
   end
 
-  describe "when configured to not display sidebar" do
+  describe 'when configured to not display sidebar' do
     before do
-      exhibit.home_page.display_sidebar =false
+      exhibit.home_page.display_sidebar = false
       exhibit.home_page.save
     end
-    it "should not display the facet sidebar" do
+    it 'does not display the facet sidebar' do
       visit spotlight.exhibit_home_page_path(exhibit.home_page)
-      expect(page).not_to have_css("#sidebar")
+      expect(page).not_to have_css('#sidebar')
     end
   end
 end

data/spec/features/import_exhibit_spec.rb

@@ -1,13 +1,15 @@
 require 'spec_helper'
 require 'tempfile'
 
-describe "Allow exhibit admins to import and export content from an exhibit", type: :feature, js: true do
-  let(:exhibit) { FactoryGirl.create(:exhibit) }
+describe 'Allow exhibit admins to import and export content from an exhibit', type: :feature, js: true do
+  let(:exhibit) { FactoryGirl.create(:default_exhibit) }
   let(:user) { FactoryGirl.create(:exhibit_admin, exhibit: exhibit) }
   before { login_as user }
 
-  pending "should allow admins to export content from an exhibit" do
-    pending("There's not really any good way to test the contents of a downloaded file with Poltergeist (which is now necessary since we've moved the export option behind a bootstrap tab)")
+  pending 'should allow admins to export content from an exhibit' do
+    pending(%(There's not really any good way to test the contents of a
+downloaded file with Poltergeist (which is now necessary since we've moved
+the export option behind a bootstrap tab)))
     visit spotlight.exhibit_home_page_path(exhibit, exhibit.home_page)
 
     click_link user.email
@@ -15,20 +17,21 @@ describe "Allow exhibit admins to import and export content from an exhibit", ty
       click_link 'Dashboard'
     end
 
-    click_link "Settings"
-    within(".nav-tabs") do
-      click_link "Export data"
+    click_link 'Settings'
+    within('.nav-tabs') do
+      click_link 'Export data'
     end
-    within("#export") do
-      click_link "Export data"
+    within('#export') do
+      click_link 'Export data'
     end
 
     data = JSON.parse(page.body)
 
-    expect(data).to include "title", "searches", "home_page"
+    expect(data).to include 'title', 'searches', 'home_page'
   end
 
-  it "should allow admins to import content into an exhibit" do
+  it 'allows admins to import content into an exhibit' do
+    pending 'PhantomJS 2.0.0 is unable to upload files; see https://github.com/ariya/phantomjs/issues/12506'
     visit spotlight.exhibit_home_page_path(exhibit, exhibit.home_page)
 
     click_link user.email
@@ -36,25 +39,25 @@ describe "Allow exhibit admins to import and export content from an exhibit", ty
       click_link 'Dashboard'
     end
 
-    click_link "Settings"
+    click_link 'Settings'
 
-    within(".nav-tabs") do
-      click_link "Import data"
+    within('.nav-tabs') do
+      click_link 'Import data'
     end
 
     file = Tempfile.new('foo')
-    file.write({"title" => "A better title"}.to_json)
+    file.write({ 'title' => 'A better title' }.to_json)
     file.rewind
     begin
-      attach_file("file", File.expand_path(file.path))
-      within("#import") do
-        click_button "Import data"
+      attach_file('file', File.expand_path(file.path))
+      within('#import') do
+        click_button 'Import data'
       end
     ensure
       file.close
       file.unlink
     end
-    expect(page).to have_content "The exhibit was successfully updated."
-    expect(page).to have_content "A better title"
+    expect(page).to have_content 'The exhibit was successfully updated.'
+    expect(page).to have_content 'A better title'
   end
 end

data/spec/features/item_admin_spec.rb

@@ -1,7 +1,7 @@
-require "spec_helper"
+require 'spec_helper'
 
-describe "Item Administration", :type => :feature do
-  let(:exhibit) { FactoryGirl.create(:exhibit) }
+describe 'Item Administration', type: :feature do
+  let(:exhibit) { FactoryGirl.create(:default_exhibit) }
   let(:curator) { FactoryGirl.create(:exhibit_curator, exhibit: exhibit) }
   before { login_as curator }
 
@@ -9,50 +9,49 @@ describe "Item Administration", :type => :feature do
     allow_any_instance_of(::SolrDocument).to receive_messages(reindex: true)
   end
 
-  describe "admin" do
-    it "should not have a 'Save this search' button" do
+  describe 'admin' do
+    it "does not have a 'Save this search' button" do
       visit spotlight.admin_exhibit_catalog_index_path(exhibit)
-      expect(page).not_to have_css("button", text: "Save this search")
+      expect(page).not_to have_css('button', text: 'Save this search')
     end
-    it "should have catalog items" do
+    it 'has catalog items' do
       visit spotlight.admin_exhibit_catalog_index_path(exhibit)
-      expect(page).to have_css("h1 small", text: "Items")
-      expect(page).to have_css("table#documents")
-      expect(page).to have_css(".pagination")
-      
-      item = first("tr[itemscope]")
-      expect(item).to have_link "View"
-      expect(item).to have_link "Edit"
+      expect(page).to have_css('h1 small', text: 'Items')
+      expect(page).to have_css('table#documents')
+      expect(page).to have_css('.pagination')
+
+      item = first('tr[itemscope]')
+      expect(item).to have_link 'View'
+      expect(item).to have_link 'Edit'
     end
 
-    it "should have a public/private toggle" do
+    it 'has a public/private toggle' do
       visit spotlight.admin_exhibit_catalog_index_path(exhibit)
-      item = first("tr[itemscope]")
-      expect(item).to have_button "Make Private"
-      item.click_button "Make Private"
+      item = first('tr[itemscope]')
+      expect(item).to have_button 'Make Private'
+      item.click_button 'Make Private'
 
-      item = first("tr[itemscope]")
-      expect(item).to have_button "Make Public"
-      item.click_button "Make Public"
+      item = first('tr[itemscope]')
+      expect(item).to have_button 'Make Public'
+      item.click_button 'Make Public'
     end
 
-    it "should toggle the 'blacklight-private' label", js: true do
+    it "toggles the 'blacklight-private' label", js: true do
       visit spotlight.admin_exhibit_catalog_index_path(exhibit)
       # The label should be toggled when the checkbox is clicked
-      expect(page).to_not have_css("tr.blacklight-private")
-      within "tr[itemscope]:first-child" do
+      expect(page).to_not have_css('tr.blacklight-private')
+      within 'tr[itemscope]:first-child' do
         find("input.toggle_visibility[type='checkbox']").click
       end
-      expect(page).to have_css("tr.blacklight-private")
-
+      expect(page).to have_css('tr.blacklight-private')
 
       # The label should show up on page load
-      expect(page).to have_css("tr.blacklight-private")
+      expect(page).to have_css('tr.blacklight-private')
       visit spotlight.admin_exhibit_catalog_index_path(exhibit)
-      within "tr[itemscope]:first-child" do
+      within 'tr[itemscope]:first-child' do
         find("input.toggle_visibility[type='checkbox']").click
       end
-      expect(page).to_not have_css("tr.blacklight-private")
+      expect(page).to_not have_css('tr.blacklight-private')
     end
   end
 end