@woosh/meep-engine 3.39.0 → 3.41.0

package/src/engine/graphics3/WaterSystem.js

@@ -1,423 +1,230 @@
 import { assert } from "../../core/assert.js";
 import Water from "../graphics/ecs/water/Water.js";
 import WaterWaves from "../graphics/ecs/water/WaterWaves.js";
-import { WATER_SIZE } from "../graphics/ecs/water/WATER_SIZE.js";
-import { obtainTerrain } from "../ecs/terrain/util/obtainTerrain.js";
 import { System } from "../ecs/System.js";
+import { EventType } from "../ecs/EventType.js";
+import { Transform64 } from "../ecs/transform/Transform64.js";
+import { TransformAttachment } from "../ecs/transform-attachment/TransformAttachment.js";
+import { TRANSFORM64_EVENT_CHANGE } from "../ecs/transform/TRANSFORM64_EVENT_CHANGE.js";
+import { TRANSFORM_ATTACHMENT_EVENT_CHANGE } from "../ecs/transform-attachment/TRANSFORM_ATTACHMENT_EVENT_CHANGE.js";
+import { MeshletGeometry } from "../../shade/renderer/geometry/MeshletGeometry.js";
 import { ResourceAccessKind } from "../../core/model/ResourceAccessKind.js";
 import { ResourceAccessSpecification } from "../../core/model/ResourceAccessSpecification.js";
 import { GPUWaterRenderer } from "../../shade/renderer/water/GPUWaterRenderer.js";
 import { GPUWaterBodies } from "../../shade/renderer/water/medium/GPUWaterBodies.js";
 import { GPUWaterWaveSimulation } from "../../shade/renderer/water/surface/GPUWaterWaveSimulation.js";
-import { WATER_WAVE_IMPULSE_LIMIT } from "../../shade/renderer/water/surface/WATER_WAVE_PARAMETERS_STRUCT.js";
-import { water_height_texture_from_sampler } from "../../shade/renderer/water/water_height_texture_from_sampler.js";
 import { FramePhase } from "../../shade/renderer/extension/FramePhase.js";
 import { RenderExtension } from "../../shade/renderer/extension/RenderExtension.js";
 import { SceneColor } from "../../shade/renderer/extension/SceneColor.js";
+import { m4_invert } from "../../core/geom/3d/mat4/m4_invert.js";
+import { generate_record_writer } from "../../shade/renderer/buffer/table/serde/generate_record_writer.js";
+import { WATER_WAVE_IMPULSE_LIMIT, WATER_WAVE_RECORD_STRUCT } from "../../shade/renderer/water/surface/WATER_WAVE_RECORD_STRUCT.js";
+
+const WIND_WRITER = generate_record_writer(WATER_WAVE_RECORD_STRUCT, ['forcing', 'unresolved_variance']);
+const IMPULSE_WRITER = generate_record_writer(WATER_WAVE_RECORD_STRUCT, ['impulses', 'impulse_count']);
 
 /**
- * Draws the level's water under Shade.
- *
- * Water is a shared AVBOIT side channel. The extension is debug presentation only; normal frames
- * composite water exactly once alongside particles, meshlets and trails in AVBOIT's resolve.
- *
- * Registration does not wait for a device. `GraphicsEngine` holds extensions and applies them
- * to the renderer when one exists and again after a restart (E9, §4.8).
+ * Registers [Water, MeshletGeometry, Transform64] in the scene's existing GPU database. Authored
+ * edits queue writes; idle frames never walk bodies. Transform rows follow the same change events
+ * and GPU hierarchy as shaded geometry. Water does not enter the opaque mesh table or its TLAS.
  */
 export class WaterSystem extends System {
-    dependencies = [Water];
-
-    components_used = [
-        // optional: drives the surface producer when present, calm water when not
-        ResourceAccessSpecification.from(WaterWaves, ResourceAccessKind.Read),
-    ];
-
-    /**
-     * @type {GraphicsEngine}
-     */
+    dependencies = [Water, MeshletGeometry, Transform64];
+    components_used = [ResourceAccessSpecification.from(WaterWaves, ResourceAccessKind.Read)];
     #graphics;
-
-    /**
-     * @type {GPUWaterRenderer}
-     */
+    #scene;
+    #context = null;
     #renderer = new GPUWaterRenderer();
-
-    /**
-     * The surface producer: the primitive wave simulation, behind the surface interface the water
-     * draws read (WATER_OPTICS_PLAN_2026_10_02.md §7.2).
-     *
-     * @type {GPUWaterWaveSimulation}
-     */
     #waves = new GPUWaterWaveSimulation();
-
-    /**
-     * The frame's water bodies on the GPU: each one's medium and surface optics, read by every pass
-     * that lights water.
-     *
-     * @type {GPUWaterBodies}
-     */
     #bodies = new GPUWaterBodies();
-
-    /**
-     * What the pass draws, in link order.
-     *
-     * @type {WaterSurface[]}
-     */
-    #surfaces = [];
-
-    /**
-     * @type {Map<number, WaterSurface>}
-     */
     #entries = new Map();
-
-    /**
-     * @type {RenderExtension|null}
-     */
-    #extension = null;
-
-    /**
-     * Records the surface producer at the head of each frame.
-     *
-     * @type {RenderExtension|null}
-     */
-    #surface_extension = null;
-
+    #dirty = new Set();
+    #impulses = new Set();
+    #extensions = [];
+    #time = 0;
     get settings() { return this.#renderer.settings; }
-
-    /** The surface producer, for settings such as its grid resolution. */
     get waves() { return this.#waves; }
-
-    /** The registered channel, for diagnostics such as testing registration order. */
     get transparency_channel() { return this.#renderer; }
-
+    get scene() { return this.#scene; }
     request_probe(uv) { return this.#renderer.request_probe(uv); }
-
     get time() { return this.#time; }
     set time(seconds) {
         assert.ok(Number.isFinite(seconds) && seconds >= 0, 'water time must be finite and non-negative');
         this.#time = seconds;
-        this.update(0);
     }
 
-    /**
-     * Seconds since startup. Waves are a function of it and nothing else advances it.
-     *
-     * @type {number}
-     */
-    #time = 0;
-
-    /**
-     * What the pass draws. Read-only — the surfaces follow the entities, and a harness that wants
-     * one gone takes its component off.
-     *
-     * @returns {WaterSurface[]}
-     */
-    get surfaces() {
-        return this.#surfaces;
-    }
-
-    /**
-     * @param {GraphicsEngine} graphics
-     */
-    constructor(graphics) {
-        super();
-
-        assert.defined(graphics, 'graphics');
-
-        this.#graphics = graphics;
+    constructor(graphics, scene) {
+        super(); assert.defined(graphics, 'graphics'); assert.defined(scene, 'scene');
+        this.#graphics = graphics; this.#scene = scene;
+        this.#renderer.scene = scene;
+        this.#waves.onInputsConsumed.add(context => {
+            if (context !== this.#context) { return; }
+            for (const entry of this.#impulses) {
+                entry.staged.length = 0;
+                if (entry.impulses.length !== 0) { this.#dirty.add(entry); }
+                else { this.#impulses.delete(entry); }
+            }
+        });
+        this.#renderer.bodies = this.#bodies;
+        this.#renderer.waves = this.#waves;
     }
 
     async startup(entityManager) {
         this.entityManager = entityManager;
-
-        this.#renderer.surfaces = this.#surfaces;
-        this.#renderer.bodies = this.#bodies;
+        assert.ok(this.#scene.dataset == null || this.#scene.dataset === entityManager.dataset, 'scene belongs to another dataset');
+        this.#scene.dataset = entityManager.dataset;
         this.#graphics.add_transparency_channel(this.#renderer);
-        this.#extension = this.#graphics.add_extension(new WaterExtension(this));
-        this.#surface_extension = this.#graphics.add_extension(new WaterSurfaceExtension(this));
+        this.#extensions = [this.#graphics.add_extension(new WaterExtension(this)),
+            this.#graphics.add_extension(new WaterSurfaceExtension(this))];
     }
 
-    async shutdown(entityManager) {
+    async shutdown() {
+        for (const entry of Array.from(this.#entries.values())) { this.unlink(entry.water, entry.geometry, entry.transform, entry.entity); }
         this.#graphics.remove_transparency_channel(this.#renderer);
-        this.#renderer.dispose();
-        if (this.#extension !== null) {
-            this.#graphics.remove_extension(this.#extension);
-
-            this.#extension = null;
-        }
-        if (this.#surface_extension !== null) {
-            this.#graphics.remove_extension(this.#surface_extension);
-
-            this.#surface_extension = null;
-        }
-        this.#waves.dispose();
-        this.#bodies.dispose();
-
-        this.#surfaces.length = 0;
-        this.#entries.clear();
-    }
-
-    /**
-     * @param {FrameContext} frame
-     */
-    record(frame) {
-        const inspection = this.#renderer.inspect(frame.graph, frame.view, frame.resolution);
-        if (inspection !== undefined) { frame.get(SceneColor).color = inspection; }
-    }
-
-    /**
-     * Record the surface producer: this frame's wave steps and the surface interface every water
-     * pass reads. At the head of the frame, so everything that reads it is recorded after.
-     *
-     * @param {FrameContext} frame
-     */
-    record_surface(frame) {
-        const renderer = this.#graphics.renderer;
-
-        if (renderer === null || renderer === undefined) {
-            return;
-        }
-
-        const device = renderer.graphics.device;
-
-        this.#waves.record({ graph: frame.graph, device, surfaces: this.#surfaces });
-        this.#bodies.record({ graph: frame.graph, device, surfaces: this.#surfaces });
-    }
-
-    /**
-     * Kick the surface of an entity's water, as a boat or a splash would: a vertical velocity
-     * `strength` m/s at `position`, falling off over `radius` m. Applied on the next frame that
-     * steps; at most {@link WATER_WAVE_IMPULSE_LIMIT} a frame per body, the rest wait for the
-     * following frames.
-     *
-     * @param {number} entity the entity carrying the {@link Water}
-     * @param {number[]} position world x, y, z; y is ignored
-     * @param {number} radius m
-     * @param {number} strength m/s, positive upwards
-     */
-    splash(entity, position, radius, strength) {
-        assert.isNonNegativeInteger(entity, 'entity');
-        assert.isArrayLike(position, 'position');
-        assert.isFinite(position[0], 'position[0]');
-        assert.isFinite(position[2], 'position[2]');
-        assert.isFinite(radius, 'radius');
-        assert.greaterThan(radius, 0, 'radius');
-        assert.isFinite(strength, 'strength');
-
-        const surface = this.#entries.get(entity);
-
-        assert.defined(surface, 'surface');
-
-        surface.impulses.push([position[0], position[2], radius, strength]);
-    }
-
-    /**
-     * @param {Water} water
-     * @param {number} entity
-     */
-    link(water, entity) {
-        const surface = {
-            entity,
-            visible: true,
-            level: water.level.getValue(),
-            ior: 1,
-            roughness: 0,
-            medium: water.medium,
-            body_index: 0,
-            time: this.#time,
-            extent: new Float32Array(4),
-            height_uv: new Float32Array([0, 0, 1, 1]),
-            height_texture: null,
-            height_data: null,
-            height_version: -1,
-            wind_speed: 0,
-            wind_direction: 0,
-            impulses: [],
-            gpu_surface: undefined,
-            component: water
+        for (const extension of this.#extensions) { this.#graphics.remove_extension(extension); }
+        this.#extensions.length = 0;
+        this.#renderer.dispose(); this.#waves.dispose(); this.#context = null;
+    }
+
+    link(water, geometry, transform, entity) {
+        const entry = { water, geometry, transform, entity, context: null, row: -1, wave: -1, waves: null,
+            impulses: [], staged: [], wave_record: null };
+        const dataset = this.entityManager.dataset;
+        entry.changed = () => this.#dirty.add(entry);
+        entry.world = () => entry.context?.rows.mark_world(entity);
+        entry.local = () => entry.context?.rows.mark_local(entity);
+        entry.components = ({ klass }) => {
+            if (klass === WaterWaves) { this.#watch_waves(entry); entry.changed(); }
+            if (klass === TransformAttachment) { entry.local(); }
         };
-
-        this.#entries.set(entity, surface);
-
-        this.#refresh(surface, water);
-
-        if (surface.height_texture !== null) {
-            this.#surfaces.push(surface);
+        water.onChanged.add(entry.changed);
+        dataset.addEntityEventListener(entity, TRANSFORM64_EVENT_CHANGE, entry.world);
+        dataset.addEntityEventListener(entity, TRANSFORM_ATTACHMENT_EVENT_CHANGE, entry.local);
+        dataset.addEntityEventListener(entity, EventType.ComponentAdded, entry.components);
+        dataset.addEntityEventListener(entity, EventType.ComponentRemoved, entry.components);
+        this.#entries.set(entity, entry);
+        this.#watch_waves(entry);
+        this.#dirty.add(entry);
+        this.#renderer.body_count++;
+    }
+
+    #watch_waves(entry) {
+        entry.waves?.windSpeed.onChanged.remove(entry.changed);
+        entry.waves?.windDirection.onChanged.remove(entry.changed);
+        entry.waves = this.entityManager.dataset.getComponent(entry.entity, WaterWaves);
+        entry.waves?.windSpeed.onChanged.add(entry.changed);
+        entry.waves?.windDirection.onChanged.add(entry.changed);
+    }
+
+    unlink(water, geometry, transform, entity) {
+        const entry = this.#entries.get(entity);
+        if (entry === undefined) { return; }
+        const dataset = this.entityManager.dataset;
+        water.onChanged.remove(entry.changed);
+        entry.waves?.windSpeed.onChanged.remove(entry.changed);
+        entry.waves?.windDirection.onChanged.remove(entry.changed);
+        dataset.removeEntityEventListener(entity, TRANSFORM64_EVENT_CHANGE, entry.world);
+        dataset.removeEntityEventListener(entity, TRANSFORM_ATTACHMENT_EVENT_CHANGE, entry.local);
+        dataset.removeEntityEventListener(entity, EventType.ComponentAdded, entry.components);
+        dataset.removeEntityEventListener(entity, EventType.ComponentRemoved, entry.components);
+        if (entry.context !== null && entry.context === this.#graphics.scene_context(this.#scene)) {
+            entry.context.scene_database.get('water_bodies').remove(entry.row);
+            entry.context.rows.release(entity);
         }
-    }
-
-    /**
-     * @param {Water} water
-     * @param {number} entity
-     */
-    unlink(water, entity) {
-        const surface = this.#entries.get(entity);
-
-        if (surface === undefined) {
-            return;
+        this.#entries.delete(entity); this.#dirty.delete(entry); this.#impulses.delete(entry);
+        this.#renderer.body_count--;
+        if (entry.context !== null) { this.#renderer.meshlet_capacity -= entry.geometry.meshlets.count; }
+    }
+
+    update(dt) {
+        this.#time += dt; this.#renderer.time = this.#time; this.#waves.advance(dt);
+        const context = this.#graphics.scene_context(this.#scene);
+        if (context === null) { return; }
+        if (context !== this.#context) {
+            this.#context = context;
+            // Device replacement is the only whole-scene rebuild; ordinary frames drain edits.
+            for (const entry of this.#entries.values()) {
+                entry.context = null; entry.row = -1; entry.wave = -1; entry.wave_record = null;
+                entry.impulses.unshift(...entry.staged); entry.staged.length = 0;
+                this.#dirty.add(entry);
+            }
+            this.#renderer.meshlet_capacity = 0;
         }
-
-        const index = this.#surfaces.indexOf(surface);
-
-        if (index !== -1) {
-            this.#surfaces.splice(index, 1);
+        for (const entry of this.#dirty) { this.#write(entry, context); }
+        this.#dirty.clear();
+    }
+
+    #write(entry, context) {
+        const bodies = context.scene_database.get('water_bodies');
+        const waves = context.scene_database.get('water_waves');
+        if (entry.context === null) {
+            context.rows.acquire(entry.entity);
+            context.geometries.add(entry.geometry);
+            entry.context = context;
+            this.#renderer.meshlet_capacity += entry.geometry.meshlets.count;
         }
-
-        this.#entries.delete(entity);
-    }
-
-    update(timeDelta) {
-        this.#time += timeDelta;
-        this.#waves.advance(timeDelta);
-
-        for (const surface of this.#entries.values()) {
-            surface.time = this.#time;
-
-            this.#refresh(surface, surface.component);
-
-            if (surface.height_texture !== null && this.#surfaces.indexOf(surface) === -1) {
-                // the terrain arrived after the water did, which is ordinary at level-load rates
-                this.#surfaces.push(surface);
-            } else if (surface.height_texture === null) {
-                const index = this.#surfaces.indexOf(surface);
-                if (index !== -1) { this.#surfaces.splice(index, 1); }
+        if (entry.wave !== -1 || entry.waves != null || entry.impulses.length !== 0) {
+            const bounds = entry.geometry.bounding_box;
+            if (entry.wave === -1) {
+                entry.wave_record = { extent: [bounds[0], bounds[2], bounds[3], bounds[5]],
+                    forcing: [1, 0, 0, 0], impulses: Array.from({ length: WATER_WAVE_IMPULSE_LIMIT }, () => [0, 0, 0, 0]),
+                    node: entry.entity + 1, geometry: context.geometries.getAddress(entry.geometry),
+                    unresolved_variance: 0, impulse_count: 0, first_write: 1, displacement_bounds: [0, 0] };
+                entry.wave = waves.add(entry.wave_record);
+            }
+            const wind = Math.max(0, entry.waves?.windSpeed.getValue() ?? 0);
+            const direction = entry.waves?.windDirection.getValue() ?? 0;
+            // Patch only authored fields: a full write would restore GPU-consumed impulses/reset flags.
+            waves.set_fields(entry.wave, { forcing: [Math.cos(direction), Math.sin(direction), 0.02 * wind * wind, 0.5 * wind],
+                unresolved_variance: wind > 0 ? 0.003 + 0.00512 * wind : 0 }, WIND_WRITER);
+            if (entry.impulses.length !== 0) {
+                entry.staged.push(...entry.impulses.splice(0, WATER_WAVE_IMPULSE_LIMIT - entry.staged.length));
+                const impulses = entry.staged.slice();
+                const count = impulses.length;
+                while (impulses.length < WATER_WAVE_IMPULSE_LIMIT) { impulses.push([0, 0, 0, 0]); }
+                waves.set_fields(entry.wave, { impulses, impulse_count: count }, IMPULSE_WRITER);
             }
         }
+        const water = entry.water;
+        const record = { geometry: context.geometries.getAddress(entry.geometry), node: entry.entity + 1,
+            dirty: 1,
+            wave: entry.wave === -1 ? 0xffffffff : entry.wave, ior: Math.max(1, water.ior.getValue()),
+            roughness: Math.min(1, Math.max(0, water.roughness.getValue())), medium: water.medium.to_gpu_record(),
+            backscattering: [0, 0, 0, 0], extinction: [0, 0, 0, 0], diffuse_transmittance: 0 };
+        if (entry.row === -1) { entry.row = bodies.add(record); } else { bodies.set(entry.row, record); }
     }
 
-    /**
-     * Copy the component's authored values across, and work out where the surface sits over the
-     * terrain it is flooding.
-     *
-     * @param {WaterSurface} surface
-     * @param {Water} water
-     */
-    #refresh(surface, water) {
-        surface.level = water.level.getValue();
-        surface.ior = Math.max(1, water.ior.getValue());
-        surface.roughness = Math.min(1, Math.max(0, water.roughness.getValue()));
-        surface.medium = water.medium;
-
-        const waves = this.entityManager.dataset.getComponent(surface.entity, WaterWaves);
-
-        surface.wind_speed = waves === undefined ? 0 : Math.max(0, waves.windSpeed.getValue());
-        surface.wind_direction = waves === undefined ? 0 : waves.windDirection.getValue();
-
-        const terrain = obtainTerrain(this.entityManager.dataset);
-
-        if (terrain === null || terrain === undefined) {
-            // no terrain to flood; the shore line has nothing to read and the surface stays out of
-            // the pass until one exists
-            surface.height_texture = null;
-            surface.height_data = null;
-            surface.height_version = -1;
-            return;
-        }
-
-        const width = terrain.size.x * terrain.gridScale;
-        const height = terrain.size.y * terrain.gridScale;
-        if (!(width > 0 && height > 0)) {
-            surface.height_texture = null; surface.height_data = null; surface.height_version = -1;
-            return;
-        }
-
-        /*
-         The legacy placement, read off it rather than derived: an 800-unit plane centred at
-         `WATER_SIZE / 4` on both axes, so it spans [-200, 600] regardless of how big the terrain is.
-         The map is an island in an ocean, not a lake fitted to the map, and where the surface hangs
-         past the terrain the height map clamps — which is what lets the shore line continue instead
-         of stopping at the boundary.
-
-         The three path stated the same thing as a UV transform,
-         `(uv - 0.25) * (WATER_SIZE / terrain_size)`, and the two agree by construction: world
-         position is `(u - 0.25) * WATER_SIZE`, and terrain uv is that over the terrain's own size.
-        */
-        const x0 = -WATER_SIZE * 0.25;
-        const z0 = -WATER_SIZE * 0.25;
-
-        surface.extent[0] = x0;
-        surface.extent[1] = z0;
-        surface.extent[2] = x0 + WATER_SIZE;
-        surface.extent[3] = z0 + WATER_SIZE;
-
-        surface.height_uv[0] = x0 / width;
-        surface.height_uv[1] = z0 / height;
-        surface.height_uv[2] = WATER_SIZE / width;
-        surface.height_uv[3] = WATER_SIZE / height;
-
-        const height_field = terrain.samplerHeight;
-
-        /*
-         The height field a water surface links against is not the one it will read. A `Terrain`
-         carries a 512² placeholder from the moment its entity exists, and the level's own field
-         arrives later — while Shade uploads a texture once and has no notion of one changing. So a
-         surface linked at load time would read a flat sea floor for the rest of the session.
-
-         Watched on the data array rather than on the sampler: `Sampler2D.fromJSON` replaces `data`
-         and leaves `version` alone, so deserialization is invisible to the counter. The version is
-         watched too, for the edits that do bump it and keep the array.
-        */
-        if (surface.height_data !== height_field.data || surface.height_version !== height_field.version) {
-            surface.height_texture = water_height_texture_from_sampler(height_field);
-            surface.height_data = height_field.data;
-            surface.height_version = height_field.version;
-        }
+    /** World-space radius and velocity kick; position is interpreted in the CPU-owned pose. */
+    splash(entity, position, radius, strength) {
+        const entry = this.#entries.get(entity); assert.defined(entry, 'water entity');
+        assert.greaterThan(radius, 0, 'radius'); assert.isFinite(radius, 'radius'); assert.isFinite(strength, 'strength');
+        for (let i = 0; i < 3; i++) { assert.isFinite(position[i], `position[${i}]`); }
+        const inverse = new Float64Array(16);
+        assert.ok(m4_invert(inverse, entry.transform), 'water transform is singular');
+        const x = inverse[0] * position[0] + inverse[4] * position[1] + inverse[8] * position[2] + inverse[12];
+        const z = inverse[2] * position[0] + inverse[6] * position[1] + inverse[10] * position[2] + inverse[14];
+        entry.impulses.push([x, z, radius, strength]); this.#impulses.add(entry); this.#dirty.add(entry);
     }
-}
-
-/**
- * Opt-in water inspection after temporal processing. Kept under the exported name
- * for compatibility; this never records a water color overlay in normal rendering.
- */
-export class WaterExtension extends RenderExtension {
-    name = "water";
 
-    // Diagnostics must show this frame's measurements, not temporally accumulated colors.
-    phase = FramePhase.BeforePresent;
-
-    /**
-     * @type {WaterSystem}
-     */
-    #system;
-
-    /**
-     * @param {WaterSystem} system
-     */
-    constructor(system) {
-        super();
-
-        this.#system = system;
+    record_surface(frame) {
+        const scene = frame.view.scene;
+        if (scene.scene !== this.#scene) { return; }
+        this.#waves.record({ graph: frame.graph, device: this.#graphics.renderer.graphics.device, scene });
+        this.#bodies.record({ graph: frame.graph, scene });
     }
-
     record(frame) {
-        this.#system.record(frame);
+        const inspection = this.#renderer.inspect(frame.graph, frame.view, frame.resolution);
+        if (inspection !== undefined) { frame.get(SceneColor).color = inspection; }
     }
 }
 
-/**
- * Records the water surface producer at {@link FramePhase.FrameStart}, so the surface exists before
- * anything in the frame reads it.
- */
+export class WaterExtension extends RenderExtension {
+    name = 'water'; phase = FramePhase.BeforePresent;
+    constructor(system) { super(); this.system = system; }
+    record(frame) { this.system.record(frame); }
+}
 export class WaterSurfaceExtension extends RenderExtension {
-    name = "water surface";
-
-    phase = FramePhase.FrameStart;
-
-    /**
-     * @type {WaterSystem}
-     */
-    #system;
-
-    /**
-     * @param {WaterSystem} system
-     */
-    constructor(system) {
-        super();
-
-        this.#system = system;
-    }
-
-    record(frame) {
-        this.#system.record_surface(frame);
-    }
+    name = 'water surface'; phase = FramePhase.FrameStart;
+    constructor(system) { super(); this.system = system; }
+    record(frame) { this.system.record_surface(frame); }
 }