@openui5/sap.ui.rta 1.136.1 → 1.138.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (177) hide show
  1. package/REUSE.toml +0 -28
  2. package/THIRDPARTY.txt +1 -25
  3. package/package.json +6 -6
  4. package/src/sap/ui/rta/.library +1 -1
  5. package/src/sap/ui/rta/Client.js +1 -1
  6. package/src/sap/ui/rta/RuntimeAuthoring.js +33 -22
  7. package/src/sap/ui/rta/Utils.js +1 -1
  8. package/src/sap/ui/rta/appVariant/AppVariantManager.js +1 -1
  9. package/src/sap/ui/rta/command/AddIFrame.js +1 -1
  10. package/src/sap/ui/rta/command/AddProperty.js +1 -1
  11. package/src/sap/ui/rta/command/AddXML.js +1 -1
  12. package/src/sap/ui/rta/command/AddXMLAtExtensionPoint.js +1 -1
  13. package/src/sap/ui/rta/command/AnnotationCommand.js +1 -1
  14. package/src/sap/ui/rta/command/BaseCommand.js +1 -1
  15. package/src/sap/ui/rta/command/BindProperty.js +1 -1
  16. package/src/sap/ui/rta/command/Combine.js +1 -1
  17. package/src/sap/ui/rta/command/CommandFactory.js +1 -1
  18. package/src/sap/ui/rta/command/CompositeCommand.js +1 -1
  19. package/src/sap/ui/rta/command/ControlVariantConfigure.js +1 -1
  20. package/src/sap/ui/rta/command/ControlVariantSave.js +1 -1
  21. package/src/sap/ui/rta/command/ControlVariantSaveAs.js +1 -1
  22. package/src/sap/ui/rta/command/ControlVariantSetTitle.js +1 -1
  23. package/src/sap/ui/rta/command/ControlVariantSwitch.js +1 -1
  24. package/src/sap/ui/rta/command/CreateContainer.js +1 -1
  25. package/src/sap/ui/rta/command/CustomAdd.js +1 -1
  26. package/src/sap/ui/rta/command/ExtendControllerCommand.js +1 -1
  27. package/src/sap/ui/rta/command/FlexCommand.js +2 -3
  28. package/src/sap/ui/rta/command/LREPSerializer.js +2 -85
  29. package/src/sap/ui/rta/command/LocalReset.js +1 -1
  30. package/src/sap/ui/rta/command/ManifestCommand.js +1 -1
  31. package/src/sap/ui/rta/command/Move.js +1 -1
  32. package/src/sap/ui/rta/command/Property.js +1 -1
  33. package/src/sap/ui/rta/command/Remove.js +1 -1
  34. package/src/sap/ui/rta/command/Rename.js +1 -1
  35. package/src/sap/ui/rta/command/Resize.js +1 -1
  36. package/src/sap/ui/rta/command/Reveal.js +1 -1
  37. package/src/sap/ui/rta/command/Settings.js +1 -1
  38. package/src/sap/ui/rta/command/Split.js +1 -1
  39. package/src/sap/ui/rta/command/Stack.js +115 -87
  40. package/src/sap/ui/rta/command/compVariant/CompVariantContent.js +1 -1
  41. package/src/sap/ui/rta/command/compVariant/CompVariantSaveAs.js +1 -1
  42. package/src/sap/ui/rta/command/compVariant/CompVariantSwitch.js +1 -1
  43. package/src/sap/ui/rta/command/compVariant/CompVariantUpdate.js +1 -1
  44. package/src/sap/ui/rta/command/manifest/AddLibrary.js +1 -1
  45. package/src/sap/ui/rta/enablement/elementActionTest.js +1 -1
  46. package/src/sap/ui/rta/library.js +2 -2
  47. package/src/sap/ui/rta/messagebundle.properties +12 -60
  48. package/src/sap/ui/rta/messagebundle_ar.properties +17 -41
  49. package/src/sap/ui/rta/messagebundle_bg.properties +17 -41
  50. package/src/sap/ui/rta/messagebundle_ca.properties +17 -41
  51. package/src/sap/ui/rta/messagebundle_cnr.properties +17 -41
  52. package/src/sap/ui/rta/messagebundle_cs.properties +16 -40
  53. package/src/sap/ui/rta/messagebundle_cy.properties +17 -41
  54. package/src/sap/ui/rta/messagebundle_da.properties +17 -41
  55. package/src/sap/ui/rta/messagebundle_de.properties +15 -39
  56. package/src/sap/ui/rta/messagebundle_el.properties +17 -41
  57. package/src/sap/ui/rta/messagebundle_en.properties +18 -42
  58. package/src/sap/ui/rta/messagebundle_en_GB.properties +18 -42
  59. package/src/sap/ui/rta/messagebundle_en_US_saprigi.properties +102 -35
  60. package/src/sap/ui/rta/messagebundle_es.properties +43 -67
  61. package/src/sap/ui/rta/messagebundle_es_MX.properties +17 -41
  62. package/src/sap/ui/rta/messagebundle_et.properties +18 -42
  63. package/src/sap/ui/rta/messagebundle_fi.properties +17 -41
  64. package/src/sap/ui/rta/messagebundle_fr.properties +18 -42
  65. package/src/sap/ui/rta/messagebundle_fr_CA.properties +18 -42
  66. package/src/sap/ui/rta/messagebundle_hi.properties +17 -41
  67. package/src/sap/ui/rta/messagebundle_hr.properties +18 -42
  68. package/src/sap/ui/rta/messagebundle_hu.properties +17 -41
  69. package/src/sap/ui/rta/messagebundle_id.properties +22 -46
  70. package/src/sap/ui/rta/messagebundle_it.properties +17 -41
  71. package/src/sap/ui/rta/messagebundle_iw.properties +18 -42
  72. package/src/sap/ui/rta/messagebundle_ja.properties +20 -44
  73. package/src/sap/ui/rta/messagebundle_kk.properties +23 -47
  74. package/src/sap/ui/rta/messagebundle_ko.properties +18 -42
  75. package/src/sap/ui/rta/messagebundle_lt.properties +17 -41
  76. package/src/sap/ui/rta/messagebundle_lv.properties +17 -41
  77. package/src/sap/ui/rta/messagebundle_mk.properties +19 -43
  78. package/src/sap/ui/rta/messagebundle_ms.properties +17 -41
  79. package/src/sap/ui/rta/messagebundle_nl.properties +16 -40
  80. package/src/sap/ui/rta/messagebundle_no.properties +17 -41
  81. package/src/sap/ui/rta/messagebundle_pl.properties +20 -44
  82. package/src/sap/ui/rta/messagebundle_pt.properties +17 -41
  83. package/src/sap/ui/rta/messagebundle_pt_PT.properties +18 -42
  84. package/src/sap/ui/rta/messagebundle_ro.properties +17 -41
  85. package/src/sap/ui/rta/messagebundle_ru.properties +17 -41
  86. package/src/sap/ui/rta/messagebundle_sh.properties +17 -41
  87. package/src/sap/ui/rta/messagebundle_sk.properties +13 -37
  88. package/src/sap/ui/rta/messagebundle_sl.properties +38 -62
  89. package/src/sap/ui/rta/messagebundle_sr.properties +17 -41
  90. package/src/sap/ui/rta/messagebundle_sv.properties +18 -42
  91. package/src/sap/ui/rta/messagebundle_th.properties +18 -42
  92. package/src/sap/ui/rta/messagebundle_tr.properties +17 -41
  93. package/src/sap/ui/rta/messagebundle_uk.properties +18 -42
  94. package/src/sap/ui/rta/messagebundle_vi.properties +19 -43
  95. package/src/sap/ui/rta/messagebundle_zh_CN.properties +18 -42
  96. package/src/sap/ui/rta/messagebundle_zh_TW.properties +18 -42
  97. package/src/sap/ui/rta/plugin/AddXMLAtExtensionPoint.js +1 -1
  98. package/src/sap/ui/rta/plugin/AddXMLPlugin.js +1 -1
  99. package/src/sap/ui/rta/plugin/BaseCreate.js +1 -1
  100. package/src/sap/ui/rta/plugin/Combine.js +1 -1
  101. package/src/sap/ui/rta/plugin/ControlVariant.js +1 -1
  102. package/src/sap/ui/rta/plugin/CreateContainer.js +1 -1
  103. package/src/sap/ui/rta/plugin/CutPaste.js +1 -1
  104. package/src/sap/ui/rta/plugin/DragDrop.js +1 -1
  105. package/src/sap/ui/rta/plugin/ExtendControllerPlugin.js +1 -1
  106. package/src/sap/ui/rta/plugin/LocalReset.js +1 -1
  107. package/src/sap/ui/rta/plugin/Plugin.js +1 -1
  108. package/src/sap/ui/rta/plugin/RTAElementMover.js +1 -1
  109. package/src/sap/ui/rta/plugin/Remove.js +1 -1
  110. package/src/sap/ui/rta/plugin/Resize.js +1 -1
  111. package/src/sap/ui/rta/plugin/Selection.js +14 -7
  112. package/src/sap/ui/rta/plugin/Settings.js +1 -1
  113. package/src/sap/ui/rta/plugin/Split.js +1 -1
  114. package/src/sap/ui/rta/plugin/Stretch.js +1 -1
  115. package/src/sap/ui/rta/plugin/additionalElements/ActionExtractor.js +11 -1
  116. package/src/sap/ui/rta/plugin/additionalElements/AddElementsDialog.js +1 -1
  117. package/src/sap/ui/rta/plugin/additionalElements/AdditionalElementsPlugin.js +1 -1
  118. package/src/sap/ui/rta/plugin/additionalElements/AdditionalElementsUtils.js +1 -1
  119. package/src/sap/ui/rta/plugin/additionalElements/CommandBuilder.js +1 -1
  120. package/src/sap/ui/rta/plugin/annotations/AnnotationChangeDialog.fragment.xml +16 -3
  121. package/src/sap/ui/rta/plugin/annotations/AnnotationChangeDialog.js +1 -1
  122. package/src/sap/ui/rta/plugin/annotations/AnnotationChangeDialogController.js +1 -1
  123. package/src/sap/ui/rta/plugin/annotations/AnnotationPlugin.js +3 -3
  124. package/src/sap/ui/rta/plugin/iframe/AddIFrame.js +1 -1
  125. package/src/sap/ui/rta/plugin/iframe/AddIFrameDialog.fragment.xml +2 -2
  126. package/src/sap/ui/rta/plugin/iframe/AddIFrameDialog.js +1 -1
  127. package/src/sap/ui/rta/plugin/iframe/AddIFrameDialogController.js +23 -6
  128. package/src/sap/ui/rta/plugin/rename/Rename.js +1 -1
  129. package/src/sap/ui/rta/plugin/rename/RenameDialog.js +1 -1
  130. package/src/sap/ui/rta/service/Action.js +1 -1
  131. package/src/sap/ui/rta/service/ControllerExtension.js +1 -1
  132. package/src/sap/ui/rta/service/Outline.js +1 -1
  133. package/src/sap/ui/rta/service/Property.js +1 -1
  134. package/src/sap/ui/rta/service/Selection.js +1 -1
  135. package/src/sap/ui/rta/service/SupportTools.js +1 -1
  136. package/src/sap/ui/rta/toolbar/ActionsMenu.fragment.xml +4 -4
  137. package/src/sap/ui/rta/toolbar/Adaptation.js +15 -3
  138. package/src/sap/ui/rta/toolbar/Base.js +1 -1
  139. package/src/sap/ui/rta/toolbar/Fiori.js +1 -1
  140. package/src/sap/ui/rta/toolbar/FioriLike.js +1 -1
  141. package/src/sap/ui/rta/toolbar/OverflowToolbarButton.js +1 -1
  142. package/src/sap/ui/rta/toolbar/Standalone.js +1 -1
  143. package/src/sap/ui/rta/toolbar/contextBased/SaveAsAdaptation.js +1 -1
  144. package/src/sap/ui/rta/toolbar/translation/Translation.js +1 -1
  145. package/src/sap/ui/rta/toolbar/versioning/Versioning.js +1 -1
  146. package/src/sap/ui/rta/util/Animation.js +4 -6
  147. package/src/sap/ui/rta/util/BindingsExtractor.js +44 -53
  148. package/src/sap/ui/rta/util/PluginManager.js +6 -6
  149. package/src/sap/ui/rta/util/PopupManager.js +90 -109
  150. package/src/sap/ui/rta/util/ReloadManager.js +53 -98
  151. package/src/sap/ui/rta/util/ServiceEventBus.js +3 -4
  152. package/src/sap/ui/rta/util/ServiceManager.js +1 -1
  153. package/src/sap/ui/rta/util/adaptationStarter.js +59 -80
  154. package/src/sap/ui/rta/util/changeVisualization/ChangeCategories.js +3 -3
  155. package/src/sap/ui/rta/util/changeVisualization/ChangeIndicator.js +1 -1
  156. package/src/sap/ui/rta/util/changeVisualization/ChangeIndicatorRegistry.js +1 -1
  157. package/src/sap/ui/rta/util/changeVisualization/ChangeStates.js +2 -4
  158. package/src/sap/ui/rta/util/changeVisualization/ChangeVisualization.js +1 -1
  159. package/src/sap/ui/rta/util/changeVisualization/ChangeVisualizationUtils.js +5 -7
  160. package/src/sap/ui/rta/util/changeVisualization/commands/CombineVisualization.js +9 -9
  161. package/src/sap/ui/rta/util/changeVisualization/commands/CreateContainerVisualization.js +5 -5
  162. package/src/sap/ui/rta/util/changeVisualization/commands/MoveVisualization.js +8 -8
  163. package/src/sap/ui/rta/util/changeVisualization/commands/RenameVisualization.js +5 -5
  164. package/src/sap/ui/rta/util/changeVisualization/commands/SplitVisualization.js +5 -5
  165. package/src/sap/ui/rta/util/changeVisualization/commands/getCommandVisualization.js +2 -2
  166. package/src/sap/ui/rta/util/guidedTour/GuidedTour.js +1 -1
  167. package/src/sap/ui/rta/util/guidedTour/content/GeneralTour.js +1 -1
  168. package/src/sap/ui/rta/util/hasStableId.js +11 -19
  169. package/src/sap/ui/rta/util/showMessageBox.js +15 -15
  170. package/src/sap/ui/rta/util/validateFlexEnabled.js +35 -34
  171. package/src/sap/ui/rta/util/validateStableIds.js +22 -31
  172. package/src/sap/ui/rta/util/validateText.js +7 -7
  173. package/src/sap/ui/rta/util/whatsNew/WhatsNew.js +33 -7
  174. package/src/sap/ui/rta/util/whatsNew/WhatsNewOverview.js +2 -6
  175. package/src/sap/ui/rta/util/whatsNew/WhatsNewOverviewDialog.fragment.xml +1 -0
  176. package/src/sap/ui/rta/util/whatsNew/WhatsNewUtils.js +4 -4
  177. package/src/sap/ui/rta/util/whatsNew/whatsNewContent/WhatsNewFeatures.js +8 -22
@@ -31,7 +31,7 @@ sap.ui.define([
31
31
  * @class The Selection plugin allows you to select or focus overlays with mouse or keyboard and navigate to others.
32
32
  * @extends sap.ui.rta.plugin.Plugin
33
33
  * @author SAP SE
34
- * @version 1.136.1
34
+ * @version 1.138.0
35
35
  * @constructor
36
36
  * @private
37
37
  * @since 1.34
@@ -270,7 +270,7 @@ sap.ui.define([
270
270
  };
271
271
 
272
272
  Selection.prototype._selectOverlay = function(oEvent) {
273
- var oOverlay = OverlayRegistry.getOverlay(oEvent.currentTarget.id);
273
+ const oOverlay = OverlayRegistry.getOverlay(oEvent.currentTarget.id);
274
274
  if (!this.getIsActive()) {
275
275
  // Propagation should be stopped at the root overlay to prevent the selection of the underlying elements
276
276
  if (oOverlay.isRoot()) {
@@ -278,19 +278,26 @@ sap.ui.define([
278
278
  }
279
279
  return;
280
280
  }
281
- var bMultiSelection = oEvent.metaKey || oEvent.ctrlKey || oEvent.shiftKey;
282
- var bContextMenu = oEvent.type === "contextmenu";
281
+ const oSelectionManager = this.getDesignTime().getSelectionManager();
282
+ const bMultipleOverlaysSelected = oSelectionManager.get().length > 1;
283
+ const bMultiSelection = oEvent.metaKey || oEvent.ctrlKey || oEvent.shiftKey;
284
+ const bContextMenu = oEvent.type === "contextmenu";
283
285
 
284
286
  if (oOverlay && oOverlay.getSelectable()) {
285
287
  if (oOverlay.isSelected()) {
286
288
  // don't deselect on right click!
287
289
  if (!bContextMenu) {
288
- this.getDesignTime().getSelectionManager().remove(oOverlay);
290
+ if (!bMultiSelection && bMultipleOverlaysSelected) {
291
+ // if the overlay is already selected and the user left clicks on it we deselect all other overlays
292
+ oSelectionManager.set([oOverlay]);
293
+ } else {
294
+ oSelectionManager.remove(oOverlay);
295
+ }
289
296
  }
290
297
  } else if (bMultiSelection) {
291
- this.getDesignTime().getSelectionManager().add(oOverlay);
298
+ oSelectionManager.add(oOverlay);
292
299
  } else {
293
- this.getDesignTime().getSelectionManager().set(oOverlay);
300
+ oSelectionManager.set(oOverlay);
294
301
  }
295
302
 
296
303
  preventEventDefaultAndPropagation(oEvent);
@@ -30,7 +30,7 @@ sap.ui.define([
30
30
  * @class The Settings allows trigger change of settings operations on the overlay
31
31
  * @extends sap.ui.rta.plugin.Plugin
32
32
  * @author SAP SE
33
- * @version 1.136.1
33
+ * @version 1.138.0
34
34
  * @constructor
35
35
  * @private
36
36
  * @since 1.44
@@ -23,7 +23,7 @@ sap.ui.define([
23
23
  * @class
24
24
  * @extends sap.ui.rta.plugin.Plugin
25
25
  * @author SAP SE
26
- * @version 1.136.1
26
+ * @version 1.138.0
27
27
  * @constructor
28
28
  * @private
29
29
  * @since 1.46
@@ -29,7 +29,7 @@ sap.ui.define([
29
29
  * @extends sap.ui.rta.plugin.Plugin
30
30
  *
31
31
  * @author SAP SE
32
- * @version 1.136.1
32
+ * @version 1.138.0
33
33
  *
34
34
  * @constructor
35
35
  * @private
@@ -32,7 +32,7 @@ sap.ui.define([
32
32
  * handled by the AdditionalElements Plugin (Reveal, Add Via Delegate, Add Custom)
33
33
  *
34
34
  * @author SAP SE
35
- * @version 1.136.1
35
+ * @version 1.138.0
36
36
  * @private
37
37
  * @since 1.94
38
38
  */
@@ -303,6 +303,16 @@ sap.ui.define([
303
303
  let mRevealCache = {};
304
304
  let bIsSyncRegistered = true;
305
305
 
306
+ /**
307
+ * Clears the cache of the Reveal actions data.
308
+ * It also registers a sync event to clear the cache after the DesignTime is synced.
309
+ * This should only be used in tests.
310
+ */
311
+ ActionExtractor.clearCache = function() {
312
+ mRevealCache = {};
313
+ bIsSyncRegistered = true;
314
+ };
315
+
306
316
  /**
307
317
  * Returns the Reveal actions data (parameters + elements) for an Overlay
308
318
  * @param {boolean} bSibling - If source element overlay should be sibling or parent to the newly added fields
@@ -32,7 +32,7 @@ sap.ui.define([
32
32
  * @class Context - Dialog for available Fields in Runtime Authoring
33
33
  * @extends sap.ui.base.ManagedObject
34
34
  * @author SAP SE
35
- * @version 1.136.1
35
+ * @version 1.138.0
36
36
  * @constructor
37
37
  * @private
38
38
  * @since 1.44
@@ -119,7 +119,7 @@ sap.ui.define([
119
119
  * @class The plugin allows to add additional elements that exist either hidden in the UI or in the OData service
120
120
  * @extends sap.ui.rta.plugin.Plugin
121
121
  * @author SAP SE
122
- * @version 1.136.1
122
+ * @version 1.138.0
123
123
  * @constructor
124
124
  * @private
125
125
  * @since 1.44
@@ -17,7 +17,7 @@ sap.ui.define([
17
17
  * Helper object containing methods for the AdditionalElements plugin
18
18
  *
19
19
  * @author SAP SE
20
- * @version 1.136.1
20
+ * @version 1.138.0
21
21
  * @private
22
22
  * @since 1.94
23
23
  */
@@ -25,7 +25,7 @@ sap.ui.define([
25
25
  * Helper object to build the RTA commands resulting from the AdditionalElements Plugin
26
26
  *
27
27
  * @author SAP SE
28
- * @version 1.136.1
28
+ * @version 1.138.0
29
29
  * @private
30
30
  * @since 1.94
31
31
  */
@@ -40,7 +40,8 @@
40
40
  id="sapUiRtaChangeAnnotationDialog_propertiesFilter"
41
41
  placeholder="{i18n>ANNOTATION_CHANGE_DIALOG_PROPERTY_SEARCH}"
42
42
  value="{/filterText}"
43
- liveChange="onFilterProperties">
43
+ liveChange="onFilterProperties"
44
+ enabled="{= ${/properties}.length > 0}">
44
45
  <layoutData>
45
46
  <FlexItemData growFactor="1" styleClass="sapUiSmallMarginEnd"/>
46
47
  </layoutData>
@@ -53,10 +54,14 @@
53
54
  state="{/showChangedPropertiesOnly}"
54
55
  change="switchDisplayMode"
55
56
  customTextOn=" "
56
- customTextOff=" "/>
57
+ customTextOff=" "
58
+ enabled="{= ${/properties}.length > 0}"/>
57
59
  </HBox>
58
60
  </HBox>
59
- <f:Form editable="true">
61
+ <f:Form
62
+ id="sapUiRtaChangeAnnotationDialog_propertyListForm"
63
+ editable="true"
64
+ visible="{= ${/properties}.length > 0}">
60
65
  <f:layout>
61
66
  <f:ResponsiveGridLayout
62
67
  labelSpanXL="4"
@@ -77,6 +82,13 @@
77
82
  id="sapUiRtaChangeAnnotationDialog_propertyList"
78
83
  formElements="{path: '/propertiesToDisplay', factory: '.editorFactory'}" />
79
84
  </f:Form>
85
+ <IllustratedMessage
86
+ illustrationType="sapIllus-NoData"
87
+ enableVerticalResponsiveness="true"
88
+ title="{i18n>ANNOTATION_CHANGE_DIALOG_NO_PROPERTIES_TITLE}"
89
+ description="{i18n>ANNOTATION_CHANGE_DIALOG_NO_PROPERTIES_DESCRIPTION}"
90
+ visible="{= ${/properties}.length === 0}">
91
+ </IllustratedMessage>
80
92
  </VBox>
81
93
  </content>
82
94
  <beginButton>
@@ -85,6 +97,7 @@
85
97
  type="Emphasized"
86
98
  text="{i18n>ANNOTATION_CHANGE_DIALOG_CONFIRM}"
87
99
  press="onSave"
100
+ visible="{= ${/properties}.length > 0}"
88
101
  />
89
102
  </beginButton>
90
103
  <endButton>
@@ -29,7 +29,7 @@ sap.ui.define([
29
29
  * @class Constructor for a new sap.ui.rta.plugin.annotations.AnnotationChangeDialog.
30
30
  * @extends sap.ui.base.ManagedObject
31
31
  * @author SAP SE
32
- * @version 1.136.1
32
+ * @version 1.138.0
33
33
  * @constructor
34
34
  * @since 1.132
35
35
  * @private
@@ -35,7 +35,7 @@ sap.ui.define([
35
35
  * @class Controller for the AnnotationChangeDialog.
36
36
  * @extends sap.ui.core.mvc.Controller
37
37
  * @author SAP SE
38
- * @version 1.136.1
38
+ * @version 1.138.0
39
39
  * @constructor
40
40
  * @since 1.132
41
41
  * @private
@@ -57,9 +57,9 @@ sap.ui.define([
57
57
  }
58
58
  }
59
59
 
60
- function getActionText(oElementOverlay, oAction, oPropagatingControl) {
60
+ function getActionText(oElementOverlay, oAction) {
61
61
  const vName = oAction.title;
62
- const oElement = oPropagatingControl || oElementOverlay.getElement();
62
+ const oElement = oElementOverlay.getElement();
63
63
  if (vName) {
64
64
  if (typeof vName === "function") {
65
65
  return vName(oElement);
@@ -105,7 +105,7 @@ sap.ui.define([
105
105
  * @class
106
106
  * @extends sap.ui.rta.plugin.Plugin
107
107
  * @author SAP SE
108
- * @version 1.136.1
108
+ * @version 1.138.0
109
109
  * @constructor
110
110
  * @private
111
111
  * @since 1.132
@@ -119,7 +119,7 @@ sap.ui.define([
119
119
  * @class The AddIFrame allows trigger AddIFrame operations on the overlay.
120
120
  * @extends sap.ui.rta.plugin.BaseCreate
121
121
  * @author SAP SE
122
- * @version 1.136.1
122
+ * @version 1.138.0
123
123
  * @constructor
124
124
  * @private
125
125
  * @since 1.75
@@ -17,7 +17,7 @@
17
17
  contentWidth="50rem"
18
18
  contentHeight="44rem"
19
19
  core:require="{ FloatType: 'sap/ui/model/type/Float' }"
20
- afterOpen="configureMultiInput"
20
+ beforeOpen="onBeforeOpen"
21
21
  >
22
22
  <content>
23
23
  <layout:VerticalLayout
@@ -420,7 +420,7 @@
420
420
  type="Emphasized"
421
421
  text="{dialogInfo>/text/saveText}"
422
422
  press="onSavePress"
423
- enabled="{=!!${dialogInfo>/frameUrl/value} &amp;&amp; !${dialogInfo>/frameUrlError/value} &amp;&amp; ${dialogInfo>/areAllFieldsValid}}"
423
+ enabled="{= !!${dialogInfo>/areAllFieldsValid}}"
424
424
  />
425
425
  </beginButton>
426
426
  <endButton>
@@ -159,7 +159,7 @@ sap.ui.define([
159
159
  * @class Context - Dialog for IFrame settings in Runtime Authoring
160
160
  * @extends sap.ui.base.ManagedObject
161
161
  * @author SAP SE
162
- * @version 1.136.1
162
+ * @version 1.138.0
163
163
  * @constructor
164
164
  * @private
165
165
  * @since 1.78
@@ -64,7 +64,15 @@ sap.ui.define([
64
64
  this._importSettings(mSettings);
65
65
  },
66
66
 
67
- configureMultiInput() {
67
+ onBeforeOpen() {
68
+ if (this._buildPreviewURL()) {
69
+ // If a URL is set initially (updateIframe), validate it
70
+ this.onValidateUrl();
71
+ } else {
72
+ // Disable the save button but don't show an error message
73
+ this._checkIfAllFieldsValid(false);
74
+ }
75
+ // Configure the MultiInput field
68
76
  // This syntax is the suggested way by the UI5 documentation to trigger a submit on the input field on focus loss
69
77
  const oMultiInput = Element.getElementById("sapUiRtaAddIFrameDialog_AddAdditionalParametersInput");
70
78
  oMultiInput.addValidator(multiInputValidator);
@@ -103,8 +111,7 @@ sap.ui.define([
103
111
  */
104
112
  onValidationSuccess(oEvent) {
105
113
  oEvent.getSource().setValueState(ValueState.None);
106
- this._oJSONModel.setProperty("/areAllFieldsValid",
107
- this._areAllTextFieldsValid() && this._areAllValueStateNones());
114
+ this._checkIfAllFieldsValid(true);
108
115
  },
109
116
 
110
117
  /**
@@ -113,7 +120,7 @@ sap.ui.define([
113
120
  */
114
121
  onValidationError(oEvent) {
115
122
  oEvent.getSource().setValueState(ValueState.Error);
116
- this._oJSONModel.setProperty("/areAllFieldsValid", false);
123
+ this._checkIfAllFieldsValid(false);
117
124
  this._setFocusOnInvalidInput();
118
125
  },
119
126
 
@@ -237,6 +244,16 @@ sap.ui.define([
237
244
  return urlCleaner(this._oJSONModel.getProperty("/frameUrl/value"));
238
245
  },
239
246
 
247
+ _checkIfAllFieldsValid(bExternalValidationSuccess) {
248
+ const bAllFieldsValid = (
249
+ bExternalValidationSuccess
250
+ && !this._oJSONModel.getProperty("/frameUrlError/value")
251
+ && this._areAllTextFieldsValid()
252
+ && this._areAllValueStateNones()
253
+ );
254
+ this._oJSONModel.setProperty("/areAllFieldsValid", bAllFieldsValid);
255
+ },
256
+
240
257
  onValidateUrl() {
241
258
  const sUrl = this._buildPreviewURL();
242
259
  const { result: bResult, error: sError } = isValidUrl(sUrl);
@@ -252,6 +269,7 @@ sap.ui.define([
252
269
  const sErrorText = _oTextResources.getText(sErrorKey);
253
270
  this._oJSONModel.setProperty("/frameUrlError/value", sErrorText);
254
271
  }
272
+ this._checkIfAllFieldsValid(bResult);
255
273
  },
256
274
 
257
275
  /**
@@ -281,8 +299,7 @@ sap.ui.define([
281
299
  bValidationError = true;
282
300
  }
283
301
 
284
- const bAllFieldsValid = this._areAllTextFieldsValid() && this._areAllValueStateNones() && !bValidationError;
285
- this._oJSONModel.setProperty("/areAllFieldsValid", bAllFieldsValid);
302
+ this._checkIfAllFieldsValid(!bValidationError);
286
303
  oInput.setValueState(sValueState);
287
304
  return bValidationError;
288
305
  },
@@ -28,7 +28,7 @@ sap.ui.define([
28
28
  * @extends sap.ui.rta.plugin.Plugin
29
29
  *
30
30
  * @author SAP SE
31
- * @version 1.136.1
31
+ * @version 1.138.0
32
32
  *
33
33
  * @constructor
34
34
  * @private
@@ -27,7 +27,7 @@ sap.ui.define([
27
27
  * @class Constructor for a new sap.ui.rta.plugin.rename.RenameDialog.
28
28
  * @extends sap.ui.base.ManagedObject
29
29
  * @author SAP SE
30
- * @version 1.136.1
30
+ * @version 1.138.0
31
31
  * @constructor
32
32
  * @since 1.136
33
33
  * @private
@@ -24,7 +24,7 @@ sap.ui.define([
24
24
  * @name sap.ui.rta.service.Action
25
25
  * @author SAP SE
26
26
  * @since 1.58
27
- * @version 1.136.1
27
+ * @version 1.138.0
28
28
  * @private
29
29
  * @ui5-restricted
30
30
  *
@@ -30,7 +30,7 @@ sap.ui.define([
30
30
  * @name sap.ui.rta.service.ControllerExtension
31
31
  * @author SAP SE
32
32
  * @since 1.58
33
- * @version 1.136.1
33
+ * @version 1.138.0
34
34
  * @private
35
35
  * @ui5-restricted
36
36
  */
@@ -43,7 +43,7 @@ sap.ui.define([
43
43
  * @name sap.ui.rta.service.Outline
44
44
  * @author SAP SE
45
45
  * @since 1.56
46
- * @version 1.136.1
46
+ * @version 1.138.0
47
47
  * @private
48
48
  * @ui5-restricted
49
49
  */
@@ -27,7 +27,7 @@ sap.ui.define([
27
27
  * @name sap.ui.rta.service.Property
28
28
  * @author SAP SE
29
29
  * @since 1.58
30
- * @version 1.136.1
30
+ * @version 1.138.0
31
31
  * @private
32
32
  * @ui5-restricted
33
33
  */
@@ -14,7 +14,7 @@ sap.ui.define(function() {
14
14
  * @name sap.ui.rta.service.Selection
15
15
  * @author SAP SE
16
16
  * @since 1.58
17
- * @version 1.136.1
17
+ * @version 1.138.0
18
18
  * @private
19
19
  * @ui5-restricted
20
20
  */
@@ -30,7 +30,7 @@ sap.ui.define([
30
30
  * @name sap.ui.rta.service.SupportTools
31
31
  * @author SAP SE
32
32
  * @since 1.106
33
- * @version 1.136.1
33
+ * @version 1.138.0
34
34
  * @private
35
35
  * @ui5-restricted
36
36
  */
@@ -28,7 +28,8 @@
28
28
  icon="sap-icon://BusinessSuiteInAppSymbols/icon-variant-configuration"
29
29
  enabled="{controls>/appVariantMenu/enabled}"
30
30
  visible="{= (${controls>/appVariantMenu/visible} &amp;&amp; ${controls>/modeSwitcher} === 'adaptation')}"
31
- text="{i18n>BTN_MANAGE_APPS_TXT}" >
31
+ text="{i18n>BTN_MANAGE_APPS_TXT}"
32
+ tooltip="{path: 'controls>/appVariantMenu/enabled', formatter: '.formatManageAppVariants'}" >
32
33
  <items>
33
34
  <MenuItem
34
35
  id="sapUiRta_appVariantOverview"
@@ -53,8 +54,8 @@
53
54
  id="sapUiRta_manageApps"
54
55
  icon="sap-icon://action-settings"
55
56
  press=".manageApps"
56
- enabled="{controls>/appVariantMenu/manageApps/enabled}"
57
57
  visible="{= (${controls>/appVariantMenu/manageApps/visible} &amp;&amp; ${controls>/modeSwitcher} === 'adaptation')}"
58
+ enabled="{controls>/appVariantMenu/manageApps/enabled}"
58
59
  text="{i18n>BTN_MANAGE_APPS_ITEM}" />
59
60
  <MenuItem
60
61
  id="sapUiRta_saveAs"
@@ -62,6 +63,7 @@
62
63
  enabled="{parts: ['controls>/appVariantMenu/saveAs/enabled', 'versions>/displayedVersion'], formatter: '.formatSaveAsEnabled'}"
63
64
  press=".saveAs"
64
65
  icon="sap-icon://copy"
66
+ tooltip="{path: 'controls>/appVariantMenu/saveAs/enabled', formatter: '.formatSaveAsAppVariants'}"
65
67
  text="{i18n>BTN_SAVE_AS}" />
66
68
  </items>
67
69
  </MenuItem>
@@ -75,8 +77,6 @@
75
77
  <MenuItem
76
78
  id="sapUiRta_newFeaturesOverview"
77
79
  icon="sap-icon://newspaper"
78
- enabled="{controls>/newFeaturesOverview/enabled}"
79
- visible="{controls>/newFeaturesOverview/visible}"
80
80
  text="{i18n>BTN_WHATS_NEW_DIALOG_OVERVIEW}"
81
81
  tooltip="{i18n>BTN_WHATS_NEW_DIALOG_OVERVIEW_TOOLTIP}"
82
82
  press=".openWhatsNewOverviewDialog"/>
@@ -67,7 +67,7 @@ sap.ui.define([
67
67
  * @extends sap.ui.rta.toolbar.Base
68
68
  *
69
69
  * @author SAP SE
70
- * @version 1.136.1
70
+ * @version 1.138.0
71
71
  *
72
72
  * @constructor
73
73
  * @private
@@ -127,8 +127,8 @@ sap.ui.define([
127
127
 
128
128
  Adaptation.prototype.exit = function(...aArgs) {
129
129
  window.removeEventListener("resize", this._onResize);
130
- this._aIntersectionObservers.forEach(function(oInstersectionObserver) {
131
- oInstersectionObserver.disconnect();
130
+ (this._aIntersectionObservers || []).forEach(function(oIntersectionObserver) {
131
+ oIntersectionObserver.disconnect();
132
132
  });
133
133
  Base.prototype.exit.apply(this, aArgs);
134
134
  };
@@ -284,6 +284,8 @@ sap.ui.define([
284
284
  overviewForDeveloper: onOverviewForDeveloperPressed.bind(this),
285
285
  restore: this.eventHandler.bind(this, "Restore"),
286
286
  formatSaveAsEnabled,
287
+ formatManageAppVariants: formatAppVariantsEnabled.bind(this),
288
+ formatSaveAsAppVariants: formatSaveAsAppVariantsEnabled.bind(this),
287
289
  saveAs: onSaveAsPressed.bind(this),
288
290
  openWhatsNewOverviewDialog,
289
291
  openGuidedTour
@@ -378,6 +380,14 @@ sap.ui.define([
378
380
  return bGeneralSaveAsEnabled && sDisplayedVersion !== Version.Number.Draft;
379
381
  }
380
382
 
383
+ function formatAppVariantsEnabled(bAppVariantsMenuEnabled) {
384
+ return bAppVariantsMenuEnabled ? null : this.getTextResources().getText("TOOLTIP_MANAGE_APPS_TXT_DISABLED");
385
+ }
386
+
387
+ function formatSaveAsAppVariantsEnabled(bAppVariantSaveAsEnabled) {
388
+ return bAppVariantSaveAsEnabled ? null : this.getTextResources().getText("TOOLTIP_SAVE_AS_APP_VARIANT_DISABLED");
389
+ }
390
+
381
391
  function onSaveAsPressed() {
382
392
  AppVariantFeature.onSaveAs(true, true, this.getRtaInformation().flexSettings.layer, null);
383
393
  }
@@ -547,6 +557,8 @@ sap.ui.define([
547
557
  oUrlParams.set("feature", (oFeedbackUrlParams.connector === "KeyUserConnector" ? "BTP" : "ABAP"));
548
558
  oUrlParams.set("appId", oFeedbackUrlParams.appId);
549
559
  oUrlParams.set("appVersion", oFeedbackUrlParams.appVersion);
560
+ // Add product filter for qualtrics colleagues
561
+ oUrlParams.set("product_filter", "Key%20User%20Adaptation");
550
562
 
551
563
  var oFeedbackDialogModel = new JSONModel({
552
564
  url: `${sURL}?${oUrlParams.toString()}`
@@ -33,7 +33,7 @@ sap.ui.define([
33
33
  * @extends sap.m.HBox
34
34
  *
35
35
  * @author SAP SE
36
- * @version 1.136.1
36
+ * @version 1.138.0
37
37
  *
38
38
  * @constructor
39
39
  * @private
@@ -34,7 +34,7 @@ function(
34
34
  * @extends sap.ui.rta.toolbar.Adaptation
35
35
  *
36
36
  * @author SAP SE
37
- * @version 1.136.1
37
+ * @version 1.138.0
38
38
  *
39
39
  * @constructor
40
40
  * @private
@@ -22,7 +22,7 @@ function(
22
22
  * @extends sap.ui.rta.toolbar.Adaptation
23
23
  *
24
24
  * @author SAP SE
25
- * @version 1.136.1
25
+ * @version 1.138.0
26
26
  *
27
27
  * @constructor
28
28
  * @private
@@ -23,7 +23,7 @@ sap.ui.define([
23
23
  * @extends sap.m.OverflowToolbarButton
24
24
  *
25
25
  * @author SAP SE
26
- * @version 1.136.1
26
+ * @version 1.138.0
27
27
  *
28
28
  * @constructor
29
29
  * @private
@@ -22,7 +22,7 @@ function(
22
22
  * @extends sap.ui.rta.toolbar.Adaptation
23
23
  *
24
24
  * @author SAP SE
25
- * @version 1.136.1
25
+ * @version 1.138.0
26
26
  *
27
27
  * @constructor
28
28
  * @private
@@ -45,7 +45,7 @@ sap.ui.define([
45
45
  * @class
46
46
  *
47
47
  * @author SAP SE
48
- * @version 1.136.1
48
+ * @version 1.138.0
49
49
  *
50
50
  * @constructor
51
51
  * @private
@@ -53,7 +53,7 @@ sap.ui.define([
53
53
  * @class
54
54
  *
55
55
  * @author SAP SE
56
- * @version 1.136.1
56
+ * @version 1.138.0
57
57
  *
58
58
  * @constructor
59
59
  * @private
@@ -38,7 +38,7 @@ sap.ui.define([
38
38
  * @class
39
39
  *
40
40
  * @author SAP SE
41
- * @version 1.136.1
41
+ * @version 1.138.0
42
42
  *
43
43
  * @constructor
44
44
  * @private
@@ -4,12 +4,10 @@
4
4
  * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
5
5
  */
6
6
 
7
- sap.ui.define([
8
- ],
9
- function() {
7
+ sap.ui.define([], function() {
10
8
  "use strict";
11
9
 
12
- var module = {};
10
+ const module = {};
13
11
 
14
12
  /**
15
13
  * CSS Transition helper
@@ -26,8 +24,8 @@ function() {
26
24
  oElement.addEventListener("transitionend", fnResolve, {once: true});
27
25
 
28
26
  // perform animation in the next animation frame, normally 16-17ms later.
29
- var iTimestampInitial;
30
- var fnAnimCallback = function(iTimestamp) {
27
+ let iTimestampInitial;
28
+ const fnAnimCallback = function(iTimestamp) {
31
29
  iTimestampInitial ||= iTimestamp;
32
30
  if (iTimestamp !== iTimestampInitial) {
33
31
  fnCallback();