openvox 7.37.1 → 8.19.0

data/lib/puppet/provider/package/sun.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Sun packaging.
 
 require_relative '../../../puppet/provider/package'
@@ -11,26 +13,26 @@ Puppet::Type.type(:package).provide :sun, :parent => Puppet::Provider::Package d
      or a hash."
 
   commands :pkginfo => "/usr/bin/pkginfo",
-    :pkgadd => "/usr/sbin/pkgadd",
-    :pkgrm => "/usr/sbin/pkgrm"
+           :pkgadd => "/usr/sbin/pkgadd",
+           :pkgrm => "/usr/sbin/pkgrm"
 
-  confine :osfamily => :solaris
-  defaultfor :osfamily => :solaris
+  confine 'os.family' => :solaris
+  defaultfor 'os.family' => :solaris
 
   has_feature :install_options
 
   self::Namemap = {
-    "PKGINST"  => :name,
+    "PKGINST" => :name,
     "CATEGORY" => :category,
-    "ARCH"     => :platform,
-    "VERSION"  => :ensure,
-    "BASEDIR"  => :root,
-    "VENDOR"   => :vendor,
-    "DESC"     => :description,
+    "ARCH" => :platform,
+    "VERSION" => :ensure,
+    "BASEDIR" => :root,
+    "VENDOR" => :vendor,
+    "DESC" => :description,
   }
 
   def self.namemap(hash)
-    self::Namemap.keys.inject({}) do |hsh,k|
+    self::Namemap.keys.inject({}) do |hsh, k|
       hsh.merge(self::Namemap[k] => hash[k])
     end
   end
@@ -45,7 +47,7 @@ Puppet::Type.type(:package).provide :sun, :parent => Puppet::Provider::Package d
         pkgs << pkg unless pkg.empty?
         pkg = {}
       when /^\s*([^:]+):\s+(.+)$/
-        pkg[$1] = $2
+        pkg[Regexp.last_match(1)] = Regexp.last_match(2)
       end
     end
     pkgs << pkg unless pkg.empty?
@@ -68,17 +70,18 @@ Puppet::Type.type(:package).provide :sun, :parent => Puppet::Provider::Package d
     begin
       pkgs = self.class.parse_pkginfo(pkginfo(*args))
       errmsg = case pkgs.size
-        when 0
-          'No message'
-        when 1
-           pkgs[0]['ERROR']
-      end
+               when 0
+                 'No message'
+               when 1
+                 pkgs[0]['ERROR']
+               end
       return self.class.namemap(pkgs[0]) if errmsg.nil?
+
       # according to commit 41356a7 some errors do not raise an exception
       # so even though pkginfo passed, we have to check the actual output
       raise Puppet::Error, _("Unable to get information about package %{name} because of: %{errmsg}") % { name: @resource[:name], errmsg: errmsg }
     rescue Puppet::ExecutionFailure
-      return {:ensure => :absent}
+      { :ensure => :absent }
     end
   end
 
@@ -93,13 +96,14 @@ Puppet::Type.type(:package).provide :sun, :parent => Puppet::Provider::Package d
 
   # only looking for -G now
   def install
-    #TRANSLATORS Sun refers to the company name, do not translate
+    # TRANSLATORS Sun refers to the company name, do not translate
     raise Puppet::Error, _("Sun packages must specify a package source") unless @resource[:source]
+
     options = {
-      :adminfile    => @resource[:adminfile],
+      :adminfile => @resource[:adminfile],
       :responsefile => @resource[:responsefile],
-      :source       => @resource[:source],
-      :cmd_options  => @resource[:install_options]
+      :source => @resource[:source],
+      :cmd_options => @resource[:install_options]
     }
     pkgadd prepare_cmd(options)
   end
@@ -111,8 +115,8 @@ Puppet::Type.type(:package).provide :sun, :parent => Puppet::Provider::Package d
   # Remove the old package, and install the new one.  This will probably
   # often fail.
   def update
-    self.uninstall if (@property_hash[:ensure] || info2hash[:ensure]) != :absent
-    self.install
+    uninstall if (@property_hash[:ensure] || info2hash[:ensure]) != :absent
+    install
   end
 
   def prepare_cmd(opt)

data/lib/puppet/provider/package/sunfreeware.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # At this point, it's an exact copy of the Blastwave stuff.
 Puppet::Type.type(:package).provide :sunfreeware, :parent => :blastwave, :source => :sun do
   desc "Package management using sunfreeware.com's `pkg-get` command on Solaris.
@@ -5,5 +7,5 @@ Puppet::Type.type(:package).provide :sunfreeware, :parent => :blastwave, :source
     has not actually been tested."
   commands :pkgget => "pkg-get"
 
-  confine :osfamily => :solaris
+  confine 'os.family' => :solaris
 end

data/lib/puppet/provider/package/tdnf.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 Puppet::Type.type(:package).provide :tdnf, :parent => :dnf do
   desc "Support via `tdnf`.
 
   This provider supports the `install_options` attribute, which allows command-line flags to be passed to tdnf.
-  These options should be spcified as a string (e.g. '--flag'), a hash (e.g. {'--flag' => 'value'}), or an
+  These options should be specified as a string (e.g. `'--flag'`), a hash (e.g. `{'--flag' => 'value'}`), or an
   array where each element is either a string or a hash."
 
   has_feature :install_options, :versionable, :virtual_packages
@@ -14,6 +16,10 @@ Puppet::Type.type(:package).provide :tdnf, :parent => :dnf do
   # never try to use RPM on a machine without it. We think this
   # has probably become obsolete with the way `commands` work, so
   # we should investigate removing it at some point.
+  #
+  # Mixing confine statements, control expressions, and exception handling
+  # confuses Rubocop's Layout cops, so we disable them entirely.
+  # rubocop:disable Layout
   if command('rpm')
     confine :true => begin
       rpm('--version')
@@ -23,6 +29,7 @@ Puppet::Type.type(:package).provide :tdnf, :parent => :dnf do
         true
       end
   end
+  # rubocop:enable Layout
 
-  defaultfor :operatingsystem => "PhotonOS" 
+  defaultfor 'os.name' => "PhotonOS"
 end

data/lib/puppet/provider/package/up2date.rb

@@ -1,40 +1,40 @@
+# frozen_string_literal: true
+
 Puppet::Type.type(:package).provide :up2date, :parent => :rpm, :source => :rpm do
   desc "Support for Red Hat's proprietary `up2date` package update
     mechanism."
 
   commands :up2date => "/usr/sbin/up2date-nox"
 
-  defaultfor :osfamily => :redhat, :lsbdistrelease => ["2.1", "3", "4"]
+  defaultfor 'os.family' => :redhat, 'os.distro.release.full' => ["2.1", "3", "4"]
 
-  confine    :osfamily => :redhat
+  confine    'os.family' => :redhat
 
   # Install a package using 'up2date'.
   def install
     up2date "-u", @resource[:name]
 
-    unless self.query
-      raise Puppet::ExecutionFailure.new(
-        _("Could not find package %{name}") % { name: self.name }
-      )
+    unless query
+      raise Puppet::ExecutionFailure, _("Could not find package %{name}") % { name: name }
     end
   end
 
   # What's the latest package version available?
   def latest
-    #up2date can only get a list of *all* available packages?
+    # up2date can only get a list of *all* available packages?
     output = up2date "--showall"
 
     if output =~ /^#{Regexp.escape @resource[:name]}-(\d+.*)\.\w+/
-      return $1
+      Regexp.last_match(1)
     else
       # up2date didn't find updates, pretend the current
       # version is the latest
-      return @property_hash[:ensure]
+      @property_hash[:ensure]
     end
   end
 
   def update
     # Install in up2date can be used for update, too
-    self.install
+    install
   end
 end

data/lib/puppet/provider/package/urpmi.rb

@@ -1,14 +1,16 @@
+# frozen_string_literal: true
+
 Puppet::Type.type(:package).provide :urpmi, :parent => :rpm, :source => :rpm do
   desc "Support via `urpmi`."
   commands :urpmi => "urpmi", :urpmq => "urpmq", :rpm => "rpm", :urpme => "urpme"
 
-  defaultfor :operatingsystem => [:mandriva, :mandrake]
+  defaultfor 'os.name' => [:mandriva, :mandrake]
 
   has_feature :versionable
 
   def install
     should = @resource.should(:ensure)
-    self.debug "Ensuring => #{should}"
+    debug "Ensuring => #{should}"
     wanted = @resource[:name]
 
     # XXX: We don't actually deal with epochs here.
@@ -22,8 +24,8 @@ Puppet::Type.type(:package).provide :urpmi, :parent => :rpm, :source => :rpm do
 
     urpmi "--auto", wanted
 
-    unless self.query
-      raise Puppet::Error, _("Package %{name} was not present after trying to install it") % { name: self.name }
+    unless query
+      raise Puppet::Error, _("Package %{name} was not present after trying to install it") % { name: name }
     end
   end
 
@@ -32,17 +34,17 @@ Puppet::Type.type(:package).provide :urpmi, :parent => :rpm, :source => :rpm do
     output = urpmq "-S", @resource[:name]
 
     if output =~ /^#{Regexp.escape @resource[:name]}\s+:\s+.*\(\s+(\S+)\s+\)/
-      return $1
+      Regexp.last_match(1)
     else
       # urpmi didn't find updates, pretend the current
       # version is the latest
-      return @resource[:ensure]
+      @resource[:ensure]
     end
   end
 
   def update
     # Install in urpmi can be used for update, too
-    self.install
+    install
   end
 
   # For normal package removal the urpmi provider will delegate to the RPM

data/lib/puppet/provider/package/windows/exe_package.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../../../puppet/provider/package/windows/package'
 
 class Puppet::Provider::Package::Windows
@@ -14,7 +16,7 @@ class Puppet::Provider::Package::Windows
       'Security Update',
       'Update Rollup',
       'Hotfix',
-      'WindowsInstaller',
+      'WindowsInstaller'
     ]
 
     def self.register(path)
@@ -42,10 +44,10 @@ class Puppet::Provider::Package::Windows
          values['UninstallString'].length > 0 &&
          values['WindowsInstaller'] != 1 && # DWORD
          name !~ /^KB[0-9]{6}/ &&
-         values['ParentKeyName'] == nil &&
-         values['Security Update'] == nil &&
-         values['Update Rollup'] == nil &&
-         values['Hotfix'] == nil)
+         values['ParentKeyName'].nil? &&
+         values['Security Update'].nil? &&
+         values['Update Rollup'].nil? &&
+         values['Hotfix'].nil?)
     end
 
     def initialize(name, version, uninstall_string)
@@ -62,12 +64,12 @@ class Puppet::Provider::Package::Windows
     def self.install_command(resource)
       file_location = resource[:source]
       if file_location.start_with?('http://', 'https://')
-        tempfile = Tempfile.new(['','.exe'])
+        tempfile = Tempfile.new(['', '.exe'])
         begin
           uri = URI(Puppet::Util.uri_encode(file_location))
           client = Puppet.runtime[:http]
           client.get(uri, options: { include_system_store: true }) do |response|
-            raise Puppet::HTTP::ResponseError.new(response) unless response.success?
+            raise Puppet::HTTP::ResponseError, response unless response.success?
 
             File.open(tempfile.path, 'wb') do |file|
               response.read_body do |data|
@@ -76,9 +78,9 @@ class Puppet::Provider::Package::Windows
             end
           end
         rescue => detail
-          raise Puppet::Error.new(_("Error when installing %{package}: %{detail}") % { package: resource[:name] ,detail: detail.message}, detail)
+          raise Puppet::Error.new(_("Error when installing %{package}: %{detail}") % { package: resource[:name], detail: detail.message }, detail)
         ensure
-          self.register(tempfile.path)
+          register(tempfile.path)
           tempfile.close()
           file_location = tempfile.path
         end

data/lib/puppet/provider/package/windows/msi_package.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../../../puppet/provider/package/windows/package'
 
 class Puppet::Provider::Package::Windows
@@ -11,9 +13,9 @@ class Puppet::Provider::Package::Windows
     # registry values to load under each product entry in
     # HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall
     # for this provider
-    REG_VALUE_NAMES = [
-      'DisplayVersion',
-      'WindowsInstaller'
+    REG_VALUE_NAMES = %w[
+      DisplayVersion
+      WindowsInstaller
     ]
 
     # Get the COM installer object, it's in a separate method for testing

data/lib/puppet/provider/package/windows/package.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../../../puppet/provider/package'
 require_relative '../../../../puppet/util/windows'
 
@@ -11,12 +13,12 @@ class Puppet::Provider::Package::Windows
 
     attr_reader :name, :version
 
-    REG_DISPLAY_VALUE_NAMES = [ 'DisplayName', 'QuietDisplayName' ]
+    REG_DISPLAY_VALUE_NAMES = %w[DisplayName QuietDisplayName]
 
     def self.reg_value_names_to_load
       REG_DISPLAY_VALUE_NAMES |
-      MsiPackage::REG_VALUE_NAMES |
-      ExePackage::REG_VALUE_NAMES
+        MsiPackage::REG_VALUE_NAMES |
+        ExePackage::REG_VALUE_NAMES
     end
 
     # Enumerate each package. The appropriate package subclass
@@ -44,7 +46,7 @@ class Puppet::Provider::Package::Windows
           mode |= KEY_READ
           begin
             self.open(hive, 'Software\Microsoft\Windows\CurrentVersion\Uninstall', mode) do |uninstall|
-              each_key(uninstall) do |name, wtime|
+              each_key(uninstall) do |name, _wtime|
                 self.open(hive, "#{uninstall.keyname}\\#{name}", mode) do |key|
                   yield key, values_by_name(key, reg_value_names_to_load)
                 end
@@ -69,6 +71,7 @@ class Puppet::Provider::Package::Windows
       when /\.exe"?\Z/i
         fail(_("The source does not exist: '%{source}'") % { source: resource[:source] }) unless
           Puppet::FileSystem.exist?(resource[:source]) || resource[:source].start_with?('http://', 'https://')
+
         ExePackage
       else
         fail(_("Don't know how to install '%{source}'") % { source: resource[:source] })
@@ -88,7 +91,7 @@ class Puppet::Provider::Package::Windows
     end
 
     def self.quote(value)
-      value.include?(' ') ? %Q["#{value.gsub(/"/, '\"')}"] : value
+      value.include?(' ') ? %Q("#{value.gsub(/"/, '\"')}") : value
     end
 
     def self.get_display_name(values)

data/lib/puppet/provider/package/windows.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../../puppet/provider/package'
 require_relative '../../../puppet/util/windows'
 require_relative 'windows/package'
@@ -20,8 +22,8 @@ Puppet::Type.type(:package).provide(:windows, :parent => Puppet::Provider::Packa
     `install_options` or `uninstall_options` attributes, respectively.  Puppet
     will automatically quote any option that contains spaces."
 
-  confine    :operatingsystem => :windows
-  defaultfor :operatingsystem => :windows
+  confine    'os.name' => :windows
+  defaultfor 'os.name' => :windows
 
   has_feature :installable
   has_feature :uninstallable
@@ -30,17 +32,16 @@ Puppet::Type.type(:package).provide(:windows, :parent => Puppet::Provider::Packa
   has_feature :versionable
 
   attr_accessor :package
+
   class << self
     attr_accessor :paths
   end
 
   def self.post_resource_eval
     @paths.each do |path|
-      begin
-        Puppet::FileSystem.unlink(path)
-      rescue => detail
-        raise Puppet::Error.new(_("Error when unlinking %{path}: %{detail}") % { path: path ,detail: detail.message}, detail)
-      end
+      Puppet::FileSystem.unlink(path)
+    rescue => detail
+      raise Puppet::Error.new(_("Error when unlinking %{path}: %{detail}") % { path: path, detail: detail.message }, detail)
     end if @paths
   end
 
@@ -55,8 +56,8 @@ Puppet::Type.type(:package).provide(:windows, :parent => Puppet::Provider::Packa
 
   def self.to_hash(pkg)
     {
-      :name     => pkg.name,
-      :ensure   => pkg.version || :installed,
+      :name => pkg.name,
+      :ensure => pkg.version || :installed,
       :provider => :windows
     }
   end

data/lib/puppet/provider/package/xbps.rb

@@ -0,0 +1,127 @@
+# frozen_string_literal: true
+
+require_relative "../../../puppet/provider/package"
+
+Puppet::Type.type(:package).provide :xbps, :parent => Puppet::Provider::Package do
+  desc "Support for the Package Manager Utility (xbps) used in VoidLinux.
+
+  This provider supports the `install_options` attribute, which allows command-line flags to be passed to xbps-install.
+  These options should be specified as an array where each element is either a string or a hash."
+
+  commands :xbps_install => "/usr/bin/xbps-install"
+  commands :xbps_remove => "/usr/bin/xbps-remove"
+  commands :xbps_query => "/usr/bin/xbps-query"
+  commands :xbps_pkgdb => "/usr/bin/xbps-pkgdb"
+
+  confine 'os.name' => :void
+  defaultfor 'os.name' => :void
+  has_feature :install_options, :uninstall_options, :upgradeable, :holdable, :virtual_packages
+
+  def self.defaultto_allow_virtual
+    false
+  end
+
+  # Fetch the list of packages that are currently installed on the system.
+  def self.instances
+    packages = []
+    execpipe([command(:xbps_query), "-l"]) do |pipe|
+      # xbps-query -l output is 'ii package-name-version     desc'
+      regex = /^\S+\s(\S+)-(\S+)\s+\S+/
+      pipe.each_line do |line|
+        match = regex.match(line.chomp)
+        if match
+          packages << new({ name: match.captures[0], ensure: match.captures[1], provider: name })
+        else
+          warning(_("Failed to match line '%{line}'") % { line: line })
+        end
+      end
+    end
+
+    packages
+  rescue Puppet::ExecutionFailure
+    fail(_("Error getting installed packages"))
+  end
+
+  # Install a package quietly (without confirmation or progress bar) using 'xbps-install'.
+  def install
+    resource_name = @resource[:name]
+    resource_source = @resource[:source]
+
+    cmd = %w[-S -y]
+    cmd += install_options if @resource[:install_options]
+    cmd << "--repository=#{resource_source}" if resource_source
+    cmd << resource_name
+
+    unhold if properties[:mark] == :hold
+    begin
+      xbps_install(*cmd)
+    ensure
+      hold if @resource[:mark] == :hold
+    end
+  end
+
+  # Because Voidlinux is a rolling release based distro, installing a package
+  # should always result in the newest release.
+  def update
+    install
+  end
+
+  # Removes a package from the system.
+  def uninstall
+    resource_name = @resource[:name]
+
+    cmd = %w[-R -y]
+    cmd += uninstall_options if @resource[:uninstall_options]
+    cmd << resource_name
+
+    xbps_remove(*cmd)
+  end
+
+  # The latest version of a given package
+  def latest
+    query&.[] :ensure
+  end
+
+  # Queries information for a package
+  def query
+    resource_name = @resource[:name]
+    installed_packages = self.class.instances
+
+    installed_packages.each do |pkg|
+      return pkg.properties if @resource[:name].casecmp(pkg.name).zero?
+    end
+
+    return nil unless @resource.allow_virtual?
+
+    # Search for virtual package
+    output = xbps_query("-Rs", resource_name).chomp
+
+    # xbps-query -Rs output is '[*] package-name-version     description'
+    regex = /^\[\*\]+\s(\S+)-(\S+)\s+\S+/
+    match = regex.match(output)
+
+    return nil unless match
+
+    { name: match.captures[0], ensure: match.captures[1], provider: self.class.name }
+  end
+
+  # Puts a package on hold, so it doesn't update by itself on system update
+  def hold
+    xbps_pkgdb("-m", "hold", @resource[:name])
+  end
+
+  # Puts a package out of hold
+  def unhold
+    xbps_pkgdb("-m", "unhold", @resource[:name])
+  end
+
+  private
+
+  def install_options
+    join_options(@resource[:install_options])
+  end
+
+  def uninstall_options
+    join_options(@resource[:uninstall_options])
+  end
+end