openvox 7.37.1 → 8.19.0

data/lib/puppet/face/parser.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 require_relative '../../puppet/face'
 require_relative '../../puppet/parser'
 
 Puppet::Face.define(:parser, '0.0.1') do
-  copyright "Puppet Inc.", 2014
+  copyright "Puppet Inc., Vox Pupuli", 2014
   license   _("Apache 2 license; see COPYING")
 
   summary _("Interact directly with the parser.")
@@ -32,7 +34,7 @@ Puppet::Face.define(:parser, '0.0.1') do
 
       Validate from STDIN:
 
-      $ cat init.pp | puppet parser validate
+      $ cat init.pp \| puppet parser validate
     EOT
     when_invoked do |*args|
       files = args.slice(0..-2)
@@ -40,7 +42,7 @@ Puppet::Face.define(:parser, '0.0.1') do
       parse_errors = {}
 
       if files.empty?
-        if not STDIN.tty?
+        if !STDIN.tty?
           Puppet[:code] = STDIN.read
           error = validate_manifest(nil)
           parse_errors['STDIN'] = error if error
@@ -63,7 +65,7 @@ Puppet::Face.define(:parser, '0.0.1') do
       end
 
       unless missing_files.empty?
-        raise Puppet::Error, _("One or more file(s) specified did not exist:\n%{files}") % { files: missing_files.collect {|f| " " * 3 + f + "\n"} }
+        raise Puppet::Error, _("One or more file(s) specified did not exist:\n%{files}") % { files: missing_files.collect { |f| " " * 3 + f + "\n" } }
       end
 
       parse_errors
@@ -82,12 +84,12 @@ Puppet::Face.define(:parser, '0.0.1') do
 
     when_rendering :json do |errors|
       unless errors.empty?
-        ignore_error_keys = [ :arguments, :environment, :node ]
+        ignore_error_keys = [:arguments, :environment, :node]
 
-        data = errors.map do |file, error|
+        data = errors.to_h do |file, error|
           file_errors = error.to_h.reject { |k, _| ignore_error_keys.include?(k) }
           [file, file_errors]
-        end.to_h
+        end
 
         puts Puppet::Util::Json.dump(Puppet::Pops::Serialization::ToDataConverter.convert(data, rich_data: false, symbol_as_string: true), :pretty => true)
 
@@ -99,8 +101,7 @@ Puppet::Face.define(:parser, '0.0.1') do
     end
   end
 
-
-  action (:dump) do
+  action(:dump) do
     summary _("Outputs a dump of the internal parse tree for debugging")
     arguments "[--format <old|pn|json>] [--pretty] { -e <source> | [<templates> ...] } "
     returns _("A dump of the resulting AST model unless there are syntax or validation errors.")
@@ -147,7 +148,7 @@ Puppet::Face.define(:parser, '0.0.1') do
       if options[:e]
         dump_parse(options[:e], 'command-line-string', options, false)
       elsif args.empty?
-        if ! STDIN.tty?
+        if !STDIN.tty?
           dump_parse(STDIN.read, 'stdin', options, false)
         else
           raise Puppet::Error, _("No input to parse given on command line or stdin")
@@ -173,7 +174,7 @@ Puppet::Face.define(:parser, '0.0.1') do
   end
 
   def dump_parse(source, filename, options, show_filename = true)
-    output = ""
+    output = ''.dup
     evaluating_parser = Puppet::Pops::Parser::EvaluatingParser.new
     begin
       if options[:validate]
@@ -212,14 +213,12 @@ Puppet::Face.define(:parser, '0.0.1') do
     env = Puppet.lookup(:current_environment)
     loaders = Puppet::Pops::Loaders.new(env)
 
-    Puppet.override( {:loaders => loaders } , _('For puppet parser validate')) do
-      begin
-        validation_environment = manifest ? env.override_with(:manifest => manifest) : env
-        validation_environment.check_for_reparse
-        validation_environment.known_resource_types.clear
-      rescue Puppet::ParseError => parse_error
-        return parse_error
-      end
+    Puppet.override({ :loaders => loaders }, _('For puppet parser validate')) do
+      validation_environment = manifest ? env.override_with(:manifest => manifest) : env
+      validation_environment.check_for_reparse
+      validation_environment.known_resource_types.clear
+    rescue Puppet::ParseError => parse_error
+      return parse_error
     end
 
     nil

data/lib/puppet/face/plugin.rb

@@ -1,26 +1,28 @@
+# frozen_string_literal: true
+
 require_relative '../../puppet/face'
 require_relative '../../puppet/configurer/plugin_handler'
 
 Puppet::Face.define(:plugin, '0.0.1') do
-  copyright "Puppet Inc.", 2011
+  copyright "Puppet Inc., Vox Pupuli", 2011
   license   _("Apache 2 license; see COPYING")
 
-  summary _("Interact with the Puppet plugin system.")
+  summary _("Interact with the OpenVox plugin system.")
   description <<-'EOT'
-    This subcommand provides network access to the puppet master's store of
+    This subcommand provides network access to the OpenVox server's store of
     plugins.
 
-    The puppet master serves Ruby code collected from the `lib` directories
+    The OpenVox server serves Ruby code collected from the `lib` directories
     of its modules. These plugins can be used on agent nodes to extend
     Facter and implement custom types and providers. Plugins are normally
-    downloaded by puppet agent during the course of a run.
+    downloaded by the OpenVox agent during the course of a run.
   EOT
 
   action :download do
     summary _("Download plugins from the puppet master.")
     description <<-'EOT'
-      Downloads plugins from the configured puppet master. Any plugins
-      downloaded in this way will be used in all subsequent Puppet activity.
+      Downloads plugins from the configured OpenVox server. Any plugins
+      downloaded in this way will be used in all subsequent OpenVox activity.
       This action modifies files on disk.
     EOT
     returns _(<<-'EOT')
@@ -38,7 +40,7 @@ Puppet::Face.define(:plugin, '0.0.1') do
       $ Puppet::Face[:plugin, '0.0.1'].download
     EOT
 
-    when_invoked do |options|
+    when_invoked do |_options|
       remote_environment_for_plugins = Puppet::Node::Environment.remote(Puppet[:environment])
 
       begin

data/lib/puppet/face/report.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 require_relative '../../puppet/indirector/face'
 
 Puppet::Indirector::Face.define(:report, '0.0.1') do
-  copyright "Puppet Inc.", 2011
+  copyright "Puppet Inc., Vox Pupuli", 2011
   license   _("Apache 2 license; see COPYING")
 
   summary _("Create, display, and submit reports.")
@@ -25,7 +27,7 @@ Puppet::Indirector::Face.define(:report, '0.0.1') do
   action(:submit) do
     summary _("API only: submit a report with error handling.")
     description <<-'EOT'
-      API only: Submits a report to the puppet master. This action is
+      API only: Submits a report to the OpenVox server. This action is
       essentially a shortcut and wrapper for the `save` action with the `rest`
       terminus, and provides additional details in the event of a failure.
     EOT
@@ -38,14 +40,12 @@ Puppet::Indirector::Face.define(:report, '0.0.1') do
           Puppet::Face[:report, '0.0.1'].submit(report)
           return report
     EOT
-    when_invoked do |report, options|
-      begin
-        Puppet::Transaction::Report.indirection.terminus_class = :rest
-        Puppet::Face[:report, "0.0.1"].save(report)
-        Puppet.notice _("Uploaded report for %{name}") % { name: report.name }
-      rescue => detail
-        Puppet.log_exception(detail, _("Could not send report: %{detail}") % { detail: detail })
-      end
+    when_invoked do |report, _options|
+      Puppet::Transaction::Report.indirection.terminus_class = :rest
+      Puppet::Face[:report, "0.0.1"].save(report)
+      Puppet.notice _("Uploaded report for %{name}") % { name: report.name }
+    rescue => detail
+      Puppet.log_exception(detail, _("Could not send report: %{detail}") % { detail: detail })
     end
   end
   deactivate_action(:find)

data/lib/puppet/face/resource.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../puppet/indirector/face'
 
 Puppet::Indirector::Face.define(:resource, '0.0.1') do

data/lib/puppet/face.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # The public name of this feature is 'face', but we have hidden all the
 # plumbing over in the 'interfaces' namespace to make clear the distinction
 # between the two.

data/lib/puppet/facter_impl.rb

@@ -58,7 +58,7 @@ module Puppet
     end
 
     def load_external(value)
-      ::Facter.load_external(value) if self.load_external?
+      ::Facter.load_external(value) if load_external?
     end
 
     private

data/lib/puppet/feature/base.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../puppet/util/feature'
 
 # Add the simple features, all in one file.
@@ -16,13 +18,13 @@ end
 # We can use Microsoft Windows functions
 Puppet.features.add(:microsoft_windows) { Puppet::Util::Platform.windows? }
 
-raise Puppet::Error,_("Cannot determine basic system flavour") unless Puppet.features.posix? or Puppet.features.microsoft_windows?
+raise Puppet::Error, _("Cannot determine basic system flavour") unless Puppet.features.posix? or Puppet.features.microsoft_windows?
 
 # We've got LDAP available.
 Puppet.features.add(:ldap, :libs => ["ldap"])
 
 # We have the Rdoc::Usage library.
-Puppet.features.add(:usage, :libs => %w{rdoc/ri/ri_paths rdoc/usage})
+Puppet.features.add(:usage, :libs => %w[rdoc/ri/ri_paths rdoc/usage])
 
 # We have libshadow, useful for managing passwords.
 Puppet.features.add(:libshadow, :libs => ["shadow"])
@@ -34,7 +36,7 @@ Puppet.features.add(:root) do
 end
 
 # We have lcs diff
-Puppet.features.add :diff, :libs => %w{diff/lcs diff/lcs/hunk}
+Puppet.features.add :diff, :libs => %w[diff/lcs diff/lcs/hunk]
 
 # We have OpenSSL
 Puppet.features.add(:openssl, :libs => ["openssl"])
@@ -49,23 +51,21 @@ Puppet.features.add(:minitar, :libs => ["archive/tar/minitar"])
 
 # We can manage symlinks
 Puppet.features.add(:manages_symlinks) do
-  if ! Puppet::Util::Platform.windows?
+  if !Puppet::Util::Platform.windows?
     true
   else
     module WindowsSymlink
       require 'ffi'
       extend FFI::Library
 
-      def self.is_implemented
-        begin
-          ffi_lib :kernel32
-          attach_function :CreateSymbolicLinkW, [:lpwstr, :lpwstr, :dword], :boolean
+      def self.is_implemented # rubocop:disable Naming/PredicateName
+        ffi_lib :kernel32
+        attach_function :CreateSymbolicLinkW, [:lpwstr, :lpwstr, :dword], :boolean
 
-          true
-        rescue LoadError
-          Puppet.debug { "CreateSymbolicLink is not available" }
-          false
-        end
+        true
+      rescue LoadError
+        Puppet.debug { "CreateSymbolicLink is not available" }
+        false
       end
     end
 

data/lib/puppet/feature/bolt.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../puppet/util/feature'
 
 Puppet.features.add(:bolt, :libs => ['bolt'])

data/lib/puppet/feature/cfpropertylist.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../puppet/util/feature'
 
 Puppet.features.add(:cfpropertylist, :libs => ['cfpropertylist'])

data/lib/puppet/feature/eventlog.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../puppet/util/feature'
 
 if Puppet::Util::Platform.windows?

data/lib/puppet/feature/hiera_eyaml.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../puppet/util/feature'
 
 Puppet.features.add(:hiera_eyaml, :libs => ['hiera/backend/eyaml/parser/parser'])

data/lib/puppet/feature/hocon.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../puppet/util/feature'
 
 Puppet.features.add(:hocon, :libs => ['hocon'])

data/lib/puppet/feature/libuser.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 require_relative '../../puppet/util/feature'
 require_relative '../../puppet/util/libuser'
 
 Puppet.features.add(:libuser) {
-   File.executable?("/usr/sbin/lgroupadd") and
-   File.executable?("/usr/sbin/luseradd")  and
-   Puppet::FileSystem.exist?(Puppet::Util::Libuser.getconf)
+  File.executable?("/usr/sbin/lgroupadd") and
+    File.executable?("/usr/sbin/luseradd") and
+    Puppet::FileSystem.exist?(Puppet::Util::Libuser.getconf)
 }

data/lib/puppet/feature/msgpack.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../puppet/util/feature'
 
 Puppet.features.add(:msgpack, :libs => ["msgpack"])

data/lib/puppet/feature/pe_license.rb

@@ -1,4 +1,6 @@
+# frozen_string_literal: true
+
 require_relative '../../puppet/util/feature'
 
-#Is the pe license library installed providing the ability to read licenses.
-Puppet.features.add(:pe_license, :libs => %{pe_license})
+# Is the pe license library installed providing the ability to read licenses.
+Puppet.features.add(:pe_license, :libs => %(pe_license))

data/lib/puppet/feature/pson.rb

@@ -0,0 +1,6 @@
+# frozen_string_literal: true
+
+require_relative '../../puppet/util/feature'
+
+# PSON is deprecated, use JSON instead
+Puppet.features.add(:pson, :libs => ['puppet/external/pson'])

data/lib/puppet/feature/selinux.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../puppet/util/feature'
 
 Puppet.features.add(:selinux, :libs => ["selinux"])

data/lib/puppet/feature/ssh.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../puppet/util/feature'
 
-Puppet.features.add(:ssh, :libs => %{net/ssh})
+Puppet.features.add(:ssh, :libs => %(net/ssh))

data/lib/puppet/feature/telnet.rb

@@ -1,9 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../puppet/util/feature'
 
-Puppet.features.add :telnet do
-  begin
-    require 'net/telnet'
-  rescue LoadError
-    false
-  end
-end
+Puppet.features.add(:telnet, :libs => %(net/telnet))

data/lib/puppet/feature/zlib.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 require_relative '../../puppet/util/feature'
 
 # We want this to load if possible, but it's not automatically
 # required.
-Puppet.features.add(:zlib, :libs => %{zlib})
+Puppet.features.add(:zlib, :libs => %(zlib))

data/lib/puppet/ffi/posix/constants.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 require_relative '../../../puppet/ffi/posix'
 
 module Puppet::FFI::POSIX
   module Constants
     extend FFI::Library
-  
+
     # Maximum number of supplementary groups (groups
     # that a user can be in plus its primary group)
     # (64 + 1 primary group)

data/lib/puppet/ffi/posix/functions.rb

@@ -1,8 +1,9 @@
+# frozen_string_literal: true
+
 require_relative '../../../puppet/ffi/posix'
 
 module Puppet::FFI::POSIX
   module Functions
-
     extend FFI::Library
 
     ffi_convention :stdcall

data/lib/puppet/ffi/posix.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'ffi'
 
 module Puppet

data/lib/puppet/ffi/windows/api_types.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../../puppet/ffi/windows'
 require_relative '../../../puppet/util/windows/string'
 
@@ -20,7 +22,7 @@ module Puppet::FFI::Windows
 
     class ::FFI::Pointer
       NULL_HANDLE = 0
-      WCHAR_NULL = "\0\0".force_encoding('UTF-16LE').freeze
+      WCHAR_NULL = String.new("\0\0").force_encoding('UTF-16LE').freeze
 
       def self.from_string_to_wide_string(str, &block)
         str = Puppet::Util::Windows::String.wide_string(str)

data/lib/puppet/ffi/windows/constants.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../../puppet/ffi/windows'
 
 module Puppet::FFI::Windows
@@ -46,31 +48,31 @@ module Puppet::FFI::Windows
     FILE_ALL_ACCESS = STANDARD_RIGHTS_REQUIRED | SYNCHRONIZE | 0x1FF
 
     FILE_GENERIC_READ =
-       STANDARD_RIGHTS_READ |
-       FILE_READ_DATA |
-       FILE_READ_ATTRIBUTES |
-       FILE_READ_EA |
-       SYNCHRONIZE
+      STANDARD_RIGHTS_READ |
+      FILE_READ_DATA |
+      FILE_READ_ATTRIBUTES |
+      FILE_READ_EA |
+      SYNCHRONIZE
 
     FILE_GENERIC_WRITE =
-       STANDARD_RIGHTS_WRITE |
-       FILE_WRITE_DATA |
-       FILE_WRITE_ATTRIBUTES |
-       FILE_WRITE_EA |
-       FILE_APPEND_DATA |
-       SYNCHRONIZE
+      STANDARD_RIGHTS_WRITE |
+      FILE_WRITE_DATA |
+      FILE_WRITE_ATTRIBUTES |
+      FILE_WRITE_EA |
+      FILE_APPEND_DATA |
+      SYNCHRONIZE
 
     FILE_GENERIC_EXECUTE =
-       STANDARD_RIGHTS_EXECUTE |
-       FILE_READ_ATTRIBUTES |
-       FILE_EXECUTE |
-       SYNCHRONIZE
+      STANDARD_RIGHTS_EXECUTE |
+      FILE_READ_ATTRIBUTES |
+      FILE_EXECUTE |
+      SYNCHRONIZE
 
     REPLACEFILE_WRITE_THROUGH         = 0x1
     REPLACEFILE_IGNORE_MERGE_ERRORS   = 0x2
     REPLACEFILE_IGNORE_ACL_ERRORS     = 0x3
 
-    INVALID_FILE_ATTRIBUTES = 0xFFFFFFFF #define INVALID_FILE_ATTRIBUTES (DWORD (-1))
+    INVALID_FILE_ATTRIBUTES = 0xFFFFFFFF # define INVALID_FILE_ATTRIBUTES (DWORD (-1))
 
     IO_REPARSE_TAG_MOUNT_POINT  = 0xA0000003
     IO_REPARSE_TAG_HSM          = 0xC0000004
@@ -107,7 +109,7 @@ module Puppet::FFI::Windows
     # https://msdn.microsoft.com/en-us/library/windows/desktop/aa364571(v=vs.85).aspx
     FSCTL_GET_REPARSE_POINT = 0x900a8
 
-    MAXIMUM_REPARSE_DATA_BUFFER_SIZE = 16384
+    MAXIMUM_REPARSE_DATA_BUFFER_SIZE = 16_384
 
     # Priority constants
     # https://docs.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-setpriorityclass
@@ -161,47 +163,47 @@ module Puppet::FFI::Windows
 
     # https://msdn.microsoft.com/en-us/library/windows/desktop/aa379626(v=vs.85).aspx
     TOKEN_INFORMATION_CLASS = enum(
-        :TokenUser, 1,
-        :TokenGroups,
-        :TokenPrivileges,
-        :TokenOwner,
-        :TokenPrimaryGroup,
-        :TokenDefaultDacl,
-        :TokenSource,
-        :TokenType,
-        :TokenImpersonationLevel,
-        :TokenStatistics,
-        :TokenRestrictedSids,
-        :TokenSessionId,
-        :TokenGroupsAndPrivileges,
-        :TokenSessionReference,
-        :TokenSandBoxInert,
-        :TokenAuditPolicy,
-        :TokenOrigin,
-        :TokenElevationType,
-        :TokenLinkedToken,
-        :TokenElevation,
-        :TokenHasRestrictions,
-        :TokenAccessInformation,
-        :TokenVirtualizationAllowed,
-        :TokenVirtualizationEnabled,
-        :TokenIntegrityLevel,
-        :TokenUIAccess,
-        :TokenMandatoryPolicy,
-        :TokenLogonSid,
-        :TokenIsAppContainer,
-        :TokenCapabilities,
-        :TokenAppContainerSid,
-        :TokenAppContainerNumber,
-        :TokenUserClaimAttributes,
-        :TokenDeviceClaimAttributes,
-        :TokenRestrictedUserClaimAttributes,
-        :TokenRestrictedDeviceClaimAttributes,
-        :TokenDeviceGroups,
-        :TokenRestrictedDeviceGroups,
-        :TokenSecurityAttributes,
-        :TokenIsRestricted,
-        :MaxTokenInfoClass
+      :TokenUser, 1,
+      :TokenGroups,
+      :TokenPrivileges,
+      :TokenOwner,
+      :TokenPrimaryGroup,
+      :TokenDefaultDacl,
+      :TokenSource,
+      :TokenType,
+      :TokenImpersonationLevel,
+      :TokenStatistics,
+      :TokenRestrictedSids,
+      :TokenSessionId,
+      :TokenGroupsAndPrivileges,
+      :TokenSessionReference,
+      :TokenSandBoxInert,
+      :TokenAuditPolicy,
+      :TokenOrigin,
+      :TokenElevationType,
+      :TokenLinkedToken,
+      :TokenElevation,
+      :TokenHasRestrictions,
+      :TokenAccessInformation,
+      :TokenVirtualizationAllowed,
+      :TokenVirtualizationEnabled,
+      :TokenIntegrityLevel,
+      :TokenUIAccess,
+      :TokenMandatoryPolicy,
+      :TokenLogonSid,
+      :TokenIsAppContainer,
+      :TokenCapabilities,
+      :TokenAppContainerSid,
+      :TokenAppContainerNumber,
+      :TokenUserClaimAttributes,
+      :TokenDeviceClaimAttributes,
+      :TokenRestrictedUserClaimAttributes,
+      :TokenRestrictedDeviceClaimAttributes,
+      :TokenDeviceGroups,
+      :TokenRestrictedDeviceGroups,
+      :TokenSecurityAttributes,
+      :TokenIsRestricted,
+      :MaxTokenInfoClass
     )
 
     # Service error codes
@@ -228,23 +230,23 @@ module Puppet::FFI::Windows
     SERVICE_CONTROL_TIMECHANGE            = 0x00000010
     SERVICE_CONTROL_TRIGGEREVENT          = 0x00000020
     SERVICE_CONTROL_SIGNALS               = {
-      SERVICE_CONTROL_STOP                  => :SERVICE_CONTROL_STOP,
-      SERVICE_CONTROL_PAUSE                 => :SERVICE_CONTROL_PAUSE,
-      SERVICE_CONTROL_CONTINUE              => :SERVICE_CONTROL_CONTINUE,
-      SERVICE_CONTROL_INTERROGATE           => :SERVICE_CONTROL_INTERROGATE,
-      SERVICE_CONTROL_SHUTDOWN              => :SERVICE_CONTROL_SHUTDOWN,
-      SERVICE_CONTROL_PARAMCHANGE           => :SERVICE_CONTROL_PARAMCHANGE,
-      SERVICE_CONTROL_NETBINDADD            => :SERVICE_CONTROL_NETBINDADD,
-      SERVICE_CONTROL_NETBINDREMOVE         => :SERVICE_CONTROL_NETBINDREMOVE,
-      SERVICE_CONTROL_NETBINDENABLE         => :SERVICE_CONTROL_NETBINDENABLE,
-      SERVICE_CONTROL_NETBINDDISABLE        => :SERVICE_CONTROL_NETBINDDISABLE,
-      SERVICE_CONTROL_DEVICEEVENT           => :SERVICE_CONTROL_DEVICEEVENT,
+      SERVICE_CONTROL_STOP => :SERVICE_CONTROL_STOP,
+      SERVICE_CONTROL_PAUSE => :SERVICE_CONTROL_PAUSE,
+      SERVICE_CONTROL_CONTINUE => :SERVICE_CONTROL_CONTINUE,
+      SERVICE_CONTROL_INTERROGATE => :SERVICE_CONTROL_INTERROGATE,
+      SERVICE_CONTROL_SHUTDOWN => :SERVICE_CONTROL_SHUTDOWN,
+      SERVICE_CONTROL_PARAMCHANGE => :SERVICE_CONTROL_PARAMCHANGE,
+      SERVICE_CONTROL_NETBINDADD => :SERVICE_CONTROL_NETBINDADD,
+      SERVICE_CONTROL_NETBINDREMOVE => :SERVICE_CONTROL_NETBINDREMOVE,
+      SERVICE_CONTROL_NETBINDENABLE => :SERVICE_CONTROL_NETBINDENABLE,
+      SERVICE_CONTROL_NETBINDDISABLE => :SERVICE_CONTROL_NETBINDDISABLE,
+      SERVICE_CONTROL_DEVICEEVENT => :SERVICE_CONTROL_DEVICEEVENT,
       SERVICE_CONTROL_HARDWAREPROFILECHANGE => :SERVICE_CONTROL_HARDWAREPROFILECHANGE,
-      SERVICE_CONTROL_POWEREVENT            => :SERVICE_CONTROL_POWEREVENT,
-      SERVICE_CONTROL_SESSIONCHANGE         => :SERVICE_CONTROL_SESSIONCHANGE,
-      SERVICE_CONTROL_PRESHUTDOWN           => :SERVICE_CONTROL_PRESHUTDOWN,
-      SERVICE_CONTROL_TIMECHANGE            => :SERVICE_CONTROL_TIMECHANGE,
-      SERVICE_CONTROL_TRIGGEREVENT          => :SERVICE_CONTROL_TRIGGEREVENT
+      SERVICE_CONTROL_POWEREVENT => :SERVICE_CONTROL_POWEREVENT,
+      SERVICE_CONTROL_SESSIONCHANGE => :SERVICE_CONTROL_SESSIONCHANGE,
+      SERVICE_CONTROL_PRESHUTDOWN => :SERVICE_CONTROL_PRESHUTDOWN,
+      SERVICE_CONTROL_TIMECHANGE => :SERVICE_CONTROL_TIMECHANGE,
+      SERVICE_CONTROL_TRIGGEREVENT => :SERVICE_CONTROL_TRIGGEREVENT
     }
 
     # Service start type codes
@@ -290,11 +292,11 @@ module Puppet::FFI::Windows
     UNSAFE_PENDING_STATES    = [SERVICE_START_PENDING, SERVICE_STOP_PENDING]
     FINAL_STATES             = {
       SERVICE_CONTINUE_PENDING => SERVICE_RUNNING,
-      SERVICE_PAUSE_PENDING    => SERVICE_PAUSED,
-      SERVICE_START_PENDING    => SERVICE_RUNNING,
-      SERVICE_STOP_PENDING     => SERVICE_STOPPED
+      SERVICE_PAUSE_PENDING => SERVICE_PAUSED,
+      SERVICE_START_PENDING => SERVICE_RUNNING,
+      SERVICE_STOP_PENDING => SERVICE_STOPPED
     }
-    SERVICE_STATES           = {
+    SERVICE_STATES = {
       SERVICE_CONTINUE_PENDING => :SERVICE_CONTINUE_PENDING,
       SERVICE_PAUSE_PENDING => :SERVICE_PAUSE_PENDING,
       SERVICE_PAUSED => :SERVICE_PAUSED,