openvox 7.37.1 → 8.19.0

data/lib/puppet/util/provider_features.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Provides feature definitions.
 require_relative '../../puppet/util/docs'
 require_relative '../../puppet/util'
@@ -20,13 +22,13 @@ module Puppet::Util::ProviderFeatures
     # @param obj [Object, Class] the object or class to check if requirements are met
     # @return [Boolean] whether all requirements for this feature are met or not.
     def available?(obj)
-      if self.methods
-        return !!methods_available?(obj)
+      if methods
+        !!methods_available?(obj)
       else
         # In this case, the provider has to declare support for this
         # feature, and that's been checked before we ever get to the
         # method checks.
-        return false
+        false
       end
     end
 
@@ -61,6 +63,7 @@ module Puppet::Util::ProviderFeatures
   def feature(name, docs, hash = {})
     @features ||= {}
     raise Puppet::DevError, _("Feature %{name} is already defined") % { name: name } if @features.include?(name)
+
     begin
       obj = ProviderFeature.new(name, docs, **hash)
       @features[obj.name] = obj
@@ -75,9 +78,10 @@ module Puppet::Util::ProviderFeatures
 
   # @return [String] Returns a string with documentation covering all features.
   def featuredocs
-    str = ""
+    str = ''.dup
     @features ||= {}
     return nil if @features.empty?
+
     names = @features.keys.sort_by(&:to_s)
     names.each do |name|
       doc = @features[name].docs.gsub(/\n\s+/, " ")
@@ -127,6 +131,7 @@ module Puppet::Util::ProviderFeatures
       # Create a method that will list all functional features.
       @feature_module.send(:define_method, :features) do
         return false unless defined?(features)
+
         features.keys.find_all { |n| feature?(n) }.sort_by(&:to_s)
       end
 
@@ -148,7 +153,7 @@ module Puppet::Util::ProviderFeatures
       @features.each do |name, feature|
         method = name.to_s + "?"
         @feature_module.send(:define_method, method) do
-          (is_a?(Class) ?  declared_feature?(name) : self.class.declared_feature?(name)) or feature.available?(self)
+          (is_a?(Class) ? declared_feature?(name) : self.class.declared_feature?(name)) or feature.available?(self)
         end
       end
 
@@ -176,4 +181,3 @@ module Puppet::Util::ProviderFeatures
     @features[name]
   end
 end
-

data/lib/puppet/util/psych_support.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # This module should be included when a class can be serialized to yaml and
 # needs to handle the deserialization from Psych with more control. Psych normally
 # pokes values directly into an instance using `instance_variable_set` which completely

data/lib/puppet/util/rdoc/code_objects.rb

@@ -1,7 +1,8 @@
+# frozen_string_literal: true
+
 require 'rdoc/code_objects'
 
 module RDoc
-
   # This modules contains various class that are used to hold information
   # about the various Puppet language structures we found while parsing.
   #
@@ -17,7 +18,7 @@ module RDoc
   # @api private
   module AddClassModuleComment
     def add_comment(comment, location = nil)
-        super
+      super
     end
   end
 
@@ -29,11 +30,11 @@ module RDoc
 
     attr_accessor :facts, :plugins
 
-    def initialize(name,superclass=nil)
+    def initialize(name, superclass = nil)
       @facts = []
       @plugins = []
       @nodes = {}
-      super(name,superclass)
+      super(name, superclass)
     end
 
     def add_plugin(plugin)
@@ -45,10 +46,11 @@ module RDoc
       meth.document_self = true
       meth.singleton = false
       meth.comment = plugin.comment
-      if type == 'function'
+      case type
+      when 'function'
         @function_container ||= add_module(NormalModule, "__functions__")
         @function_container.add_method(meth)
-      elsif type == 'type'
+      when 'type'
         @type_container ||= add_module(NormalModule, "__types__")
         @type_container.add_method(meth)
       end
@@ -63,27 +65,28 @@ module RDoc
 
     # Adds a module called __nodes__ and adds nodes to it as classes
     #
-    def add_node(name,superclass)
+    def add_node(name, superclass)
       cls = @nodes[name]
       if cls
         return cls
       end
+
       @node_container ||= add_module(NormalModule, "__nodes__")
       cls = @node_container.add_class(PuppetNode, name, superclass)
-      @nodes[name] = cls if !@done_documenting
+      @nodes[name] = cls unless @done_documenting
       cls
     end
 
     def each_fact
-      @facts.each {|c| yield c}
+      @facts.each { |c| yield c }
     end
 
     def each_plugin
-      @plugins.each {|c| yield c}
+      @plugins.each { |c| yield c }
     end
 
     def each_node
-      @nodes.each {|c| yield c}
+      @nodes.each { |c| yield c }
     end
 
     def nodes
@@ -100,7 +103,7 @@ module RDoc
     attr_accessor :resource_list, :requires, :childs, :realizes
 
     def initialize(name, superclass)
-      super(name,superclass)
+      super(name, superclass)
       @resource_list = []
       @requires = []
       @realizes = []
@@ -142,9 +145,9 @@ module RDoc
     # or class1::class2#method. Since our definitions are mapped to RDoc methods
     # but are written class1::class2::define we need to perform the lookup by
     # ourselves.
-    def find_symbol(symbol, method=nil)
+    def find_symbol(symbol, method = nil)
       result = super(symbol)
-      if not result and symbol =~ /::/
+      if !result and symbol =~ /::/
         modules = symbol.split(/::/)
         unless modules.empty?
           module_name = modules.shift
@@ -165,7 +168,7 @@ module RDoc
           end
         end
         if result && method
-          if !result.respond_to?(:find_local_symbol)
+          unless result.respond_to?(:find_local_symbol)
             p result.name
             p method
             fail
@@ -175,7 +178,6 @@ module RDoc
       end
       result
     end
-
   end
 
   # PuppetNode holds a puppet node
@@ -184,10 +186,6 @@ module RDoc
   class PuppetNode < PuppetClass
     include AddClassModuleComment
 
-    def initialize(name, superclass)
-      super(name,superclass)
-    end
-
     def is_module?
       false
     end