openvox 7.37.1 → 8.19.0

data/lib/puppet/pops/validation.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Puppet::Pops
 # A module with base functionality for validation of a model.
 #
@@ -8,7 +10,6 @@ module Puppet::Pops
 # * **DiagnosticFormatter** - produces human readable output for a Diagnostic
 #
 module Validation
-
   # This class is an abstract base implementation of a _model validation factory_ that creates a validator instance
   # and associates it with a fully configured DiagnosticProducer.
   #
@@ -25,7 +26,6 @@ module Validation
   # @api public
   #
   class Factory
-
     # Produces a validator with the given acceptor as the recipient of produced diagnostics.
     # The acceptor is where detected issues are received (and typically collected).
     #
@@ -126,14 +126,15 @@ module Validation
     #
     def []=(issue, level)
       unless issue.is_a? Issues::Issue
-        raise Puppet::DevError.new(_("Attempt to set validation severity for something that is not an Issue. (Got %{issue})") % { issue: issue.class })
+        raise Puppet::DevError, _("Attempt to set validation severity for something that is not an Issue. (Got %{issue})") % { issue: issue.class }
       end
       unless SEVERITIES[level]
-        raise Puppet::DevError.new(_("Illegal severity level: %{level} for '%{issue_code}'") % { issue_code: issue.issue_code, level: level })
+        raise Puppet::DevError, _("Illegal severity level: %{level} for '%{issue_code}'") % { issue_code: issue.issue_code, level: level }
       end
       unless issue.demotable? || level == :error
-        raise Puppet::DevError.new(_("Attempt to demote the hard issue '%{issue_code}' to %{level}") % { issue_code: issue.issue_code, level: level })
+        raise Puppet::DevError, _("Attempt to demote the hard issue '%{issue_code}' to %{level}") % { issue_code: issue.issue_code, level: level }
       end
+
       @severities[issue] = level
     end
 
@@ -152,7 +153,7 @@ module Validation
     #
     def assert_issue issue
       unless issue.is_a? Issues::Issue
-        raise Puppet::DevError.new(_("Attempt to get validation severity for something that is not an Issue. (Got %{issue})") % { issue: issue.class })
+        raise Puppet::DevError, _("Attempt to get validation severity for something that is not an Issue. (Got %{issue})") % { issue: issue.class }
       end
     end
   end
@@ -168,7 +169,6 @@ module Validation
   # sets keys in the given argument hash that may be used in the formatting of the issue message.
   #
   class DiagnosticProducer
-
     # A producer of severity for a given issue
     # @return [SeverityProducer]
     #
@@ -178,6 +178,7 @@ module Validation
     # @return [LabelProvider]
     #
     attr_reader :label_provider
+
     # Initializes this producer.
     #
     # @param acceptor [Acceptor] a sink/collector of diagnostic results
@@ -190,7 +191,7 @@ module Validation
       @label_provider     = label_provider
     end
 
-    def accept(issue, semantic, arguments={}, except=nil)
+    def accept(issue, semantic, arguments = {}, except = nil)
       return unless will_accept? issue
 
       # Set label provider unless caller provided a special label provider
@@ -205,7 +206,7 @@ module Validation
       if semantic.is_a?(StandardError)
         unless semantic.respond_to?(:file) && semantic.respond_to?(:line) && semantic.respond_to?(:pos)
           raise Puppet::DevError, _("Issue %{issue_code}: Cannot pass a %{class_name} as a semantic object when it does not support #pos(), #file() and #line()") %
-              { issue_code: issue.issue_code, class_name: semantic.class }
+                                  { issue_code: issue.issue_code, class_name: semantic.class }
         end
       end
 
@@ -228,7 +229,8 @@ module Validation
     attr_reader :exception
     attr_reader :file
     attr_reader :source_pos
-    def initialize severity, issue, file, source_pos, arguments={}, exception=nil
+
+    def initialize severity, issue, file, source_pos, arguments = {}, exception = nil
       @severity = severity
       @issue = issue
       @file = file
@@ -241,7 +243,7 @@ module Validation
 
     # Two diagnostics are considered equal if the have the same issue, location and severity
     # (arguments and exception are ignored)
-    #
+    # rubocop:disable Layout
     def ==(o)
       self.class            == o.class             &&
         same_position?(o)                          &&
@@ -250,16 +252,17 @@ module Validation
         severity            == o.severity
     end
     alias eql? ==
+    # rubocop:enable Layout
+
+    def hash
+      @hash ||= [file, source_pos.offset, issue.issue_code, severity].hash
+    end
 
     # Position is equal if the diagnostic is not located or if referring to the same offset
     def same_position?(o)
       source_pos.nil? && o.source_pos.nil? || source_pos.offset == o.source_pos.offset
     end
     private :same_position?
-
-    def hash
-      @hash ||= [file, source_pos.offset, issue.issue_code, severity].hash
-    end
   end
 
   # Formats a diagnostic for output.
@@ -352,7 +355,6 @@ module Validation
   # answer questions about what was diagnosed.
   #
   class Acceptor
-
     # All diagnostic in the order they were issued
     attr_reader :diagnostics
 
@@ -361,13 +363,14 @@ module Validation
 
     # The number of :error severity issues
     attr_reader :error_count
+
     # Initializes this diagnostics acceptor.
     # By default, the acceptor is configured with a default severity producer.
     # @param severity_producer [SeverityProducer] the severity producer to use to determine severity of an issue
     #
     # TODO add semantic_label_provider
     #
-    def initialize()
+    def initialize
       @diagnostics = []
       @error_count = 0
       @warning_count = 0
@@ -390,29 +393,29 @@ module Validation
 
     # Returns the diagnosed errors in the order they were reported.
     def errors
-      @diagnostics.select {|d| d.severity == :error }
+      @diagnostics.select { |d| d.severity == :error }
     end
 
     # Returns the diagnosed warnings in the order they were reported.
     # (This includes :warning and :deprecation severity)
     def warnings
-      @diagnostics.select {|d| d.severity == :warning || d.severity == :deprecation }
+      @diagnostics.select { |d| d.severity == :warning || d.severity == :deprecation }
     end
 
     def errors_and_warnings
-      @diagnostics.select {|d| d.severity != :ignore }
+      @diagnostics.select { |d| d.severity != :ignore }
     end
 
     # Returns the ignored diagnostics in the order they were reported (if reported at all)
     def ignored
-      @diagnostics.select {|d| d.severity == :ignore }
+      @diagnostics.select { |d| d.severity == :ignore }
     end
 
     # Add a diagnostic, or all diagnostics from another acceptor to the set of diagnostics
     # @param diagnostic [Diagnostic, Acceptor] diagnostic(s) that should be accepted
     def accept(diagnostic)
       if diagnostic.is_a?(Acceptor)
-        diagnostic.diagnostics.each {|d| _accept(d)}
+        diagnostic.diagnostics.each { |d| _accept(d) }
       else
         _accept(diagnostic)
       end
@@ -437,7 +440,7 @@ module Validation
           @error_count -= 1
         when :warning
           @warning_count -= 1
-        # there is not ignore_count
+          # there is not ignore_count
         end
       end
       removed.empty? ? nil : removed

data/lib/puppet/pops/visitable.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Visitable is a mix-in module that makes a class visitable by a Visitor
 module Puppet::Pops::Visitable
   def accept(visitor, *arguments)

data/lib/puppet/pops/visitor.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Puppet::Pops
 # A Visitor performs delegation to a given receiver based on the configuration of the Visitor.
 # A new visitor is created with a given receiver, a method prefix, min, and max argument counts.
@@ -12,9 +14,10 @@ module Puppet::Pops
 #
 class Visitor
   attr_reader :receiver, :message, :min_args, :max_args, :cache
-  def initialize(receiver, message, min_args=0, max_args=nil)
-    raise ArgumentError.new("min_args must be >= 0") if min_args < 0
-    raise ArgumentError.new("max_args must be >= min_args or nil") if max_args && max_args < min_args
+
+  def initialize(receiver, message, min_args = 0, max_args = nil)
+    raise ArgumentError, "min_args must be >= 0" if min_args < 0
+    raise ArgumentError, "max_args must be >= min_args or nil" if max_args && max_args < min_args
 
     @receiver = receiver
     @message = message
@@ -33,6 +36,7 @@ class Visitor
   # Visit an explicit receiver
   def visit_this(receiver, thing, args)
     raise "Visitor Error: Too few arguments passed. min = #{@min_args}" unless args.length >= @min_args
+
     if @max_args
       raise "Visitor Error: Too many arguments passed. max = #{@max_args}" unless args.length <= @max_args
     end
@@ -43,18 +47,22 @@ class Visitor
       thing.class.ancestors().each do |ancestor|
         name = ancestor.name
         next if name.nil?
+
         method_name = :"#{@message}_#{name.split(DOUBLE_COLON).last}"
         next unless receiver.respond_to?(method_name, true)
+
         @cache[thing.class] = method_name
         return receiver.send(method_name, thing, *args)
       end
     end
+
     raise "Visitor Error: the configured receiver (#{receiver.class}) can't handle instance of: #{thing.class}"
   end
 
   # Visit an explicit receiver
   def visit_this_class(receiver, clazz, args)
     raise "Visitor Error: Too few arguments passed. min = #{@min_args}" unless args.length >= @min_args
+
     if @max_args
       raise "Visitor Error: Too many arguments passed. max = #{@max_args}" unless args.length <= @max_args
     end
@@ -65,12 +73,15 @@ class Visitor
       clazz.ancestors().each do |ancestor|
         name = ancestor.name
         next if name.nil?
+
         method_name = :"#{@message}_#{name.split(DOUBLE_COLON).last}"
         next unless receiver.respond_to?(method_name, true)
+
         @cache[clazz] = method_name
         return receiver.send(method_name, clazz, *args)
       end
     end
+
     raise "Visitor Error: the configured receiver (#{receiver.class}) can't handle instance of: #{clazz}"
   end
 
@@ -82,6 +93,7 @@ class Visitor
     if method_name
       return receiver.send(method_name, thing)
     end
+
     visit_this(receiver, thing, NO_ARGS)
   end
 
@@ -93,6 +105,7 @@ class Visitor
     if method_name
       return receiver.send(method_name, thing, arg)
     end
+
     visit_this(receiver, thing, [arg])
   end
 
@@ -104,6 +117,7 @@ class Visitor
     if method_name
       return receiver.send(method_name, thing, arg1, arg2)
     end
+
     visit_this(receiver, thing, [arg1, arg2])
   end
 
@@ -115,8 +129,8 @@ class Visitor
     if method_name
       return receiver.send(method_name, thing, arg1, arg2, arg3)
     end
+
     visit_this(receiver, thing, [arg1, arg2, arg3])
   end
-
 end
 end

data/lib/puppet/pops.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Puppet
   # The Pops language system. This includes the parser, evaluator, AST model, and
   # Binder.
@@ -12,13 +14,13 @@ module Puppet
   module Pops
     EMPTY_HASH = {}.freeze
     EMPTY_ARRAY = [].freeze
-    EMPTY_STRING = ''.freeze
+    EMPTY_STRING = ''
 
     MAX_INTEGER =  0x7fffffffffffffff
     MIN_INTEGER = -0x8000000000000000
 
-    DOUBLE_COLON = '::'.freeze
-    USCORE = '_'.freeze
+    DOUBLE_COLON = '::'
+    USCORE = '_'
 
     require 'semantic_puppet'
 
@@ -60,6 +62,7 @@ module Puppet
     module Resource
       require_relative 'pops/resource/resource_type_impl'
     end
+
     module Evaluator
       require_relative 'pops/evaluator/literal_evaluator'
       require_relative 'pops/evaluator/callable_signature'

data/lib/puppet/property/boolean.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../puppet/coercion'
 
 class Puppet::Property::Boolean < Puppet::Property

data/lib/puppet/property/ensure.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../puppet/property'
 
 # This property is automatically added to any {Puppet::Type} that responds
@@ -38,7 +40,9 @@ class Puppet::Property::Ensure < Puppet::Property
     end
 
     # This doc will probably get overridden
+    # rubocop:disable Naming/MemoizedInstanceVariableName
     @doc ||= "The basic property that the resource should be in."
+    # rubocop:enable Naming/MemoizedInstanceVariableName
   end
 
   def self.inherited(sub)
@@ -48,19 +52,17 @@ class Puppet::Property::Ensure < Puppet::Property
   end
 
   def change_to_s(currentvalue, newvalue)
-    begin
-      if currentvalue == :absent || currentvalue.nil?
-        return _("created")
-      elsif newvalue == :absent
-        return _("removed")
-      else
-        return _('%{name} changed %{is} to %{should}') % { name: name, is: is_to_s(currentvalue), should: should_to_s(newvalue) }
-      end
-    rescue Puppet::Error
-      raise
-    rescue => detail
-      raise Puppet::DevError, _("Could not convert change %{name} to string: %{detail}") % { name: self.name, detail: detail }, detail.backtrace
+    if currentvalue == :absent || currentvalue.nil?
+      _("created")
+    elsif newvalue == :absent
+      _("removed")
+    else
+      _('%{name} changed %{is} to %{should}') % { name: name, is: is_to_s(currentvalue), should: should_to_s(newvalue) }
     end
+  rescue Puppet::Error
+    raise
+  rescue => detail
+    raise Puppet::DevError, _("Could not convert change %{name} to string: %{detail}") % { name: name, detail: detail }, detail.backtrace
   end
 
   # Retrieves the _is_ value for the ensure property.
@@ -86,15 +88,15 @@ class Puppet::Property::Ensure < Puppet::Property
       raise Puppet::DevError, _("No ability to determine if %{name} exists") % { name: @resource.class.name }
     end
     if result
-      return :present
+      :present
     else
-      return :absent
+      :absent
     end
   end
 
   # If they're talking about the thing at all, they generally want to
   # say it should exist.
-  #defaultto :present
+  # defaultto :present
   defaultto do
     if @resource.managed?
       :present
@@ -103,4 +105,3 @@ class Puppet::Property::Ensure < Puppet::Property
     end
   end
 end
-

data/lib/puppet/property/keyvalue.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../puppet/property'
 
 module Puppet
@@ -32,7 +34,7 @@ module Puppet
         hash_to_key_value_s(should_value)
       end
 
-      def is_to_s(current_value)
+      def is_to_s(current_value) # rubocop:disable Naming/PredicateName
         hash_to_key_value_s(current_value)
       end
 
@@ -49,22 +51,21 @@ module Puppet
         # passed in a hash for our property's should value, the should_value
         # parameter will be a single element array so we just extract our value
         # directly.
-        if ! @should.empty? && @should.first.is_a?(Hash)
+        if !@should.empty? && @should.first.is_a?(Hash)
           return @should.first
         end
 
         # Here, should is an array of key/value pairs.
-        @should.inject({}) do |hash, key_value|
+        @should.each_with_object({}) do |key_value, hash|
           tmp = key_value.split(separator)
           hash[tmp[0].strip.intern] = tmp[1]
-          hash
         end
       end
 
       def process_current_hash(current)
         return {} if current == :absent
 
-        #inclusive means we are managing everything so if it isn't in should, its gone
+        # inclusive means we are managing everything so if it isn't in should, its gone
         current.each_key { |key| current[key] = nil } if inclusive?
         current
       end
@@ -75,7 +76,7 @@ module Puppet
         members = hashify_should
         current = process_current_hash(retrieve)
 
-        #shared keys will get overwritten by members
+        # shared keys will get overwritten by members
         should_value = current.merge(members)
 
         # Figure out the keys that will actually change in our Puppet run.
@@ -86,7 +87,7 @@ module Puppet
         # changed_or_new_keys once (since this property will only be synced once).
         #
         @changed_or_new_keys ||= should_value.keys.select do |key|
-          ! current.key?(key) || current[key] != should_value[key]
+          !current.key?(key) || current[key] != should_value[key]
         end
 
         should_value
@@ -106,12 +107,12 @@ module Puppet
       # @return [Hash] the hash from the provider, or `:absent`
       #
       def retrieve
-        #ok, some 'convention' if the keyvalue property is named properties, provider should implement a properties method
+        # ok, some 'convention' if the keyvalue property is named properties, provider should implement a properties method
         key_hash = provider.send(name) if provider
         if key_hash && key_hash != :absent
-          return key_hash
+          key_hash
         else
-          return :absent
+          :absent
         end
       end
 
@@ -120,7 +121,7 @@ module Puppet
       def insync?(is)
         return true unless is
 
-        (is == self.should)
+        (is == should)
       end
 
       # We only accept an array of key/value pairs (strings), a single
@@ -134,8 +135,8 @@ module Puppet
 
         next if value.is_a?(Hash)
 
-        unless value.include?("#{separator}")
-          raise ArgumentError, _("Key/value pairs must be separated by '%{separator}'") % {separator: separator}
+        unless value.include?(separator.to_s)
+          raise ArgumentError, _("Key/value pairs must be separated by '%{separator}'") % { separator: separator }
         end
       end
 
@@ -151,7 +152,7 @@ module Puppet
           [hash_key.to_s.strip.to_sym, hash_value.to_s]
         end
 
-        Hash[munged_value]
+        munged_value.to_h
       end
     end
   end

data/lib/puppet/property/list.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../puppet/property'
 
 module Puppet
@@ -6,8 +8,7 @@ module Puppet
     # For an ordered list see {Puppet::Property::OrderedList}.
     #
     class List < Property
-
-      def is_to_s(currentvalue)
+      def is_to_s(currentvalue) # rubocop:disable Naming/PredicateName
         currentvalue == :absent ? super(currentvalue) : currentvalue.join(delimiter)
       end
 
@@ -24,7 +25,7 @@ module Puppet
         @resource[membership] == :inclusive
       end
 
-      #dearrayify was motivated because to simplify the implementation of the OrderedList property
+      # dearrayify was motivated because to simplify the implementation of the OrderedList property
       def dearrayify(array)
         array.sort.join(delimiter)
       end
@@ -33,8 +34,8 @@ module Puppet
         return nil unless @should
 
         members = @should
-        #inclusive means we are managing everything so if it isn't in should, its gone
-        members = add_should_with_current(members, retrieve) if ! inclusive?
+        # inclusive means we are managing everything so if it isn't in should, its gone
+        members = add_should_with_current(members, retrieve) unless inclusive?
 
         dearrayify(members)
       end
@@ -44,12 +45,12 @@ module Puppet
       end
 
       def retrieve
-        #ok, some 'convention' if the list property is named groups, provider should implement a groups method
+        # ok, some 'convention' if the list property is named groups, provider should implement a groups method
         tmp = provider.send(name) if provider
         if tmp && tmp != :absent
-          return tmp.instance_of?(Array) ? tmp : tmp.split(delimiter)
+          tmp.instance_of?(Array) ? tmp : tmp.split(delimiter)
         else
-          return :absent
+          :absent
         end
       end
 
@@ -63,7 +64,7 @@ module Puppet
       def insync?(is)
         return true unless is
 
-        (prepare_is_for_comparison(is) == self.should)
+        (prepare_is_for_comparison(is) == should)
       end
     end
   end

data/lib/puppet/property/ordered_list.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../puppet/property/list'
 
 module Puppet
@@ -10,13 +12,12 @@ module Puppet
     # For an unordered list see {Puppet::Property::List}.
     #
     class OrderedList < List
-
       def add_should_with_current(should, current)
         if current.is_a?(Array)
-          #tricky trick
-          #Preserve all the current items in the list
-          #but move them to the back of the line
-          should = should + (current - should)
+          # tricky trick
+          # Preserve all the current items in the list
+          # but move them to the back of the line
+          should += (current - should)
         end
         should
       end