openvox 7.37.1 → 8.19.0

data/lib/puppet/forge/repository.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../puppet/ssl/openssl_loader'
 require 'digest/sha1'
 require 'uri'
@@ -29,6 +31,7 @@ class Puppet::Forge
     # Return a Net::HTTPResponse read for this +path+.
     def make_http_request(path, io = nil)
       raise ArgumentError, "Path must start with forward slash" unless path.start_with?('/')
+
       begin
         str = @uri.to_s
         str.chomp!('/')
@@ -44,7 +47,7 @@ class Puppet::Forge
         end
 
         http = Puppet.runtime[:http]
-        response = http.get(uri, headers: headers, options: {ssl_context: @ssl_context})
+        response = http.get(uri, headers: headers, options: { ssl_context: @ssl_context })
         io.write(response.body) if io.respond_to?(:write)
         response
       rescue Puppet::SSL::CertVerifyError => e
@@ -66,7 +69,7 @@ class Puppet::Forge
     # repository at +release+ (e.g. "myuser-mymodule").
     def retrieve(release)
       path = @host.chomp('/') + release
-      return cache.retrieve(path)
+      cache.retrieve(path)
     end
 
     # Return the URI string for this repository.
@@ -77,7 +80,7 @@ class Puppet::Forge
     # Return the cache key for this repository, this a hashed string based on
     # the URI.
     def cache_key
-      return @cache_key ||= [
+      @cache_key ||= [
         @host.to_s.gsub(/[^[:alnum:]]+/, '_').sub(/_$/, ''),
         Digest::SHA1.hexdigest(@host.to_s)
       ].join('-').freeze

data/lib/puppet/forge.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../puppet/vendor'
 Puppet::Vendor.load_vendored
 
@@ -15,10 +17,10 @@ class Puppet::Forge < SemanticPuppet::Dependency::Source
 
   include Puppet::Forge::Errors
 
-  USER_AGENT = "PMT/1.1.1 (v3; Net::HTTP)".freeze
+  USER_AGENT = "PMT/1.1.1 (v3; Net::HTTP)"
 
   # From https://forgeapi.puppet.com/#!/release/getReleases
-  MODULE_RELEASE_EXCLUSIONS=%w[readme changelog license uri module tags supported file_size downloads created_at updated_at deleted_at].join(',').freeze
+  MODULE_RELEASE_EXCLUSIONS = %w[readme changelog license uri module tags supported file_size downloads created_at updated_at deleted_at].join(',').freeze
 
   attr_reader :host, :repository
 
@@ -112,7 +114,7 @@ class Puppet::Forge < SemanticPuppet::Dependency::Source
       uri = decode_uri(response['pagination']['next'])
     end
 
-    return releases
+    releases
   end
 
   def make_http_request(*args)
@@ -132,23 +134,21 @@ class Puppet::Forge < SemanticPuppet::Dependency::Source
 
       if meta['dependencies']
         dependencies = meta['dependencies'].collect do |dep|
-          begin
-            Puppet::ModuleTool::Metadata.new.add_dependency(dep['name'], dep['version_requirement'], dep['repository'])
-            Puppet::ModuleTool.parse_module_dependency(release, dep)[0..1]
-          rescue ArgumentError => e
-            raise ArgumentError, _("Malformed dependency: %{name}.") % { name: dep['name'] } +
-                ' ' + _("Exception was: %{detail}") % { detail: e }
-          end
+          Puppet::ModuleTool::Metadata.new.add_dependency(dep['name'], dep['version_requirement'], dep['repository'])
+          Puppet::ModuleTool.parse_module_dependency(release, dep)[0..1]
+        rescue ArgumentError => e
+          raise ArgumentError, _("Malformed dependency: %{name}.") % { name: dep['name'] } +
+                               ' ' + _("Exception was: %{detail}") % { detail: e }
         end
       else
         dependencies = []
       end
 
-      super(source, name, version, Hash[dependencies])
+      super(source, name, version, dependencies.to_h)
     end
 
     def install(dir)
-      staging_dir = self.prepare
+      staging_dir = prepare
 
       module_dir = dir + name[/-(.*)/, 1]
       module_dir.rmtree if module_dir.exist?
@@ -161,7 +161,7 @@ class Puppet::Forge < SemanticPuppet::Dependency::Source
 
       # Return the Pathname object representing the directory where the
       # module release archive was unpacked the to.
-      return module_dir
+      module_dir
     ensure
       staging_dir.rmtree if staging_dir.exist?
     end
@@ -194,15 +194,15 @@ class Puppet::Forge < SemanticPuppet::Dependency::Source
     # Obtain a suitable temporary path for unpacking tarballs
     #
     # @return [Pathname] path to temporary unpacking location
+    # rubocop:disable Naming/MemoizedInstanceVariableName
     def tmpdir
       @dir ||= Dir.mktmpdir(name, Puppet::Forge::Cache.base_path)
     end
 
     def tmpfile
-      @file ||= Tempfile.new(name, Puppet::Forge::Cache.base_path).tap do |f|
-        f.binmode
-      end
+      @file ||= Tempfile.new(name, Puppet::Forge::Cache.base_path).tap(&:binmode)
     end
+    # rubocop:enable Naming/MemoizedInstanceVariableName
 
     def download(uri, destination)
       response = @source.make_http_request(uri, destination)
@@ -223,15 +223,13 @@ class Puppet::Forge < SemanticPuppet::Dependency::Source
     end
 
     def unpack(file, destination)
-      begin
-        Puppet::ModuleTool::Applications::Unpacker.unpack(file.path, destination)
-      rescue Puppet::ExecutionFailure => e
-        raise RuntimeError, _("Could not extract contents of module archive: %{message}") % { message: e.message }
-      end
+      Puppet::ModuleTool::Applications::Unpacker.unpack(file.path, destination)
+    rescue Puppet::ExecutionFailure => e
+      raise RuntimeError, _("Could not extract contents of module archive: %{message}") % { message: e.message }
     end
 
     def deprecated?
-      @data['module'] && (@data['module']['deprecated_at'] != nil)
+      @data['module'] && !@data['module']['deprecated_at'].nil?
     end
   end
 

data/lib/puppet/functions/abs.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Returns the absolute value of a Numeric value, for example -34.56 becomes
 # 34.56. Takes a single `Integer` or `Float` value as an argument.
 #
@@ -18,7 +20,7 @@
 # ```puppet
 # abs(Numeric($str_val))
 # ```
-# 
+#
 # It is worth noting that `Numeric` can convert to absolute value
 # directly as in the following examples:
 #
@@ -45,14 +47,15 @@ Puppet::Functions.create_function(:abs) do
 
   def on_string(x)
     Puppet.warn_once('deprecations', 'abs_function_numeric_coerce_string',
-      _("The abs() function's auto conversion of String to Numeric is deprecated - change to convert input before calling"))
+                     _("The abs() function's auto conversion of String to Numeric is deprecated - change to convert input before calling"))
 
     # These patterns for conversion are backwards compatible with the stdlib
     # version of this function.
     #
-    if x =~ %r{^-?(?:\d+)(?:\.\d+){1}$}
+    case x
+    when /^-?(?:\d+)(?:\.\d+){1}$/
       x.to_f.abs
-    elsif x =~ %r{^-?\d+$}
+    when /^-?\d+$/
       x.to_i.abs
     else
       raise(ArgumentError, 'abs(): Requires float or integer to work with - was given non decimal string')

data/lib/puppet/functions/alert.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Logs a message on the server at level `alert`.
 Puppet::Functions.create_function(:alert, Puppet::Functions::InternalFunction) do
   # @param values The values to log.

data/lib/puppet/functions/all.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Runs a [lambda](https://puppet.com/docs/puppet/latest/lang_lambdas.html)
 # repeatedly using each value in a data structure until the lambda returns a non "truthy" value which
 # makes the function return `false`, or if the end of the iteration is reached, `true` is returned.
@@ -85,7 +87,7 @@ Puppet::Functions.create_function(:all) do
   end
 
   def all_Hash_2(hash)
-    hash.each_pair.all? { |x,y| yield(x,y) }
+    hash.each_pair.all? { |x, y| yield(x, y) }
   end
 
   def all_Enumerable_1(enumerable)

data/lib/puppet/functions/annotate.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Handles annotations on objects. The function can be used in four different ways.
 #
 # With two arguments, an `Annotation` type and an object, the function returns the annotation

data/lib/puppet/functions/any.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Runs a [lambda](https://puppet.com/docs/puppet/latest/lang_lambdas.html)
 # repeatedly using each value in a data structure until the lambda returns a "truthy" value which
 # makes the function return `true`, or if the end of the iteration is reached, false is returned.
@@ -90,7 +92,7 @@ Puppet::Functions.create_function(:any) do
   end
 
   def any_Hash_2(hash)
-    hash.each_pair.any? { |x,y| yield(x, y) }
+    hash.each_pair.any? { |x, y| yield(x, y) }
   end
 
   def any_Enumerable_1(enumerable)

data/lib/puppet/functions/assert_type.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Returns the given value if it is of the given
 # [data type](https://puppet.com/docs/puppet/latest/lang_data.html), or
 # otherwise either raises an error or executes an optional two-parameter
@@ -67,7 +69,7 @@ Puppet::Functions.create_function(:assert_type) do
   # @param value [Object] the value to assert
   #
   def assert_type(type, value)
-    unless Puppet::Pops::Types::TypeCalculator.instance?(type,value)
+    unless Puppet::Pops::Types::TypeCalculator.instance?(type, value)
       inferred_type = Puppet::Pops::Types::TypeCalculator.infer_set(value)
       if block_given?
         # Give the inferred type to allow richer comparison in the given block (if generalized
@@ -77,7 +79,8 @@ Puppet::Functions.create_function(:assert_type) do
       else
         raise Puppet::Pops::Types::TypeAssertionError.new(
           Puppet::Pops::Types::TypeMismatchDescriber.singleton.describe_mismatch('assert_type():', type, inferred_type),
-          type, inferred_type)
+          type, inferred_type
+        )
       end
     end
     value

data/lib/puppet/functions/binary_file.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Loads a binary file from a module or file system and returns its contents as a `Binary`.
 # The argument to this function should be a `<MODULE NAME>/<FILE>`
 # reference, which will load `<FILE>` from a module's `files`
@@ -24,9 +26,10 @@ Puppet::Functions.create_function(:binary_file, Puppet::Functions::InternalFunct
   def binary_file(scope, unresolved_path)
     path = Puppet::Parser::Files.find_file(unresolved_path, scope.compiler.environment)
     unless path && Puppet::FileSystem.exist?(path)
-      #TRANSLATORS the string "binary_file()" should not be translated
+      # TRANSLATORS the string "binary_file()" should not be translated
       raise Puppet::ParseError, _("binary_file(): The given file '%{unresolved_path}' does not exist") % { unresolved_path: unresolved_path }
     end
+
     Puppet::Pops::Types::PBinaryType::Binary.from_binary_string(Puppet::FileSystem.binread(path))
   end
 end

data/lib/puppet/functions/break.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Breaks an innermost iteration as if it encountered an end of input.
 # This function does not return to the caller.
 #
@@ -24,7 +26,7 @@
 # }
 # $data = [1,2,3]
 # notice $data.map |$x| { break_if_even($x); $x*10 }
-#```
+# ```
 # Would notice the value `[10]`
 #
 # * Also see functions `next` and `return`
@@ -35,7 +37,7 @@ Puppet::Functions.create_function(:break) do
   dispatch :break_impl do
   end
 
-  def break_impl()
+  def break_impl
     # get file, line if available, else they are set to nil
     file, line = Puppet::Pops::PuppetStack.top_of_stack
 

data/lib/puppet/functions/call.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Calls an arbitrary Puppet function by name.
 #
 # This function takes one mandatory argument and one or more optional arguments:
@@ -76,5 +78,4 @@ Puppet::Functions.create_function(:call, Puppet::Functions::InternalFunction) do
   def call_deferred(scope, deferred)
     Puppet::Pops::Evaluator::DeferredResolver.resolve(deferred, scope.compiler)
   end
-
 end

data/lib/puppet/functions/camelcase.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Creates a Camel Case version of a String
 #
 # This function is compatible with the stdlib function with the same name.
@@ -29,7 +31,6 @@
 # Would both result in `['AbcDef', 'BcdXyz']`
 #
 Puppet::Functions.create_function(:camelcase) do
-
   dispatch :on_numeric do
     param 'Numeric', :arg
   end
@@ -48,11 +49,11 @@ Puppet::Functions.create_function(:camelcase) do
   end
 
   def on_string(s)
-    s.split('_').map {|x| x.capitalize }.join('')
+    s.split('_').map(&:capitalize).join('')
   end
 
   def on_iterable(a)
-    a.map {|x| do_camelcase(x) }
+    a.map { |x| do_camelcase(x) }
   end
 
   def do_camelcase(x)

data/lib/puppet/functions/capitalize.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 # Capitalizes the first character of a String, or the first character of every String in an Iterable value (such as an Array).
 #
 # This function is compatible with the stdlib function with the same name.
 #
 # The function does the following:
-# * For a `String`, a string with its first character in upper case version is returned. 
+# * For a `String`, a string is returned in which the first character is uppercase.
 #   This is done using Ruby system locale which handles some, but not all
 #   special international up-casing rules (for example German double-s ß is capitalized to "Ss").
 # * For an `Iterable[Variant[String, Numeric]]` (for example an `Array`) each value is capitalized and the conversion is not recursive.
@@ -28,7 +30,6 @@
 # Would both result in `['Abc', 'Bcd']`
 #
 Puppet::Functions.create_function(:capitalize) do
-
   dispatch :on_numeric do
     param 'Numeric', :arg
   end
@@ -51,7 +52,7 @@ Puppet::Functions.create_function(:capitalize) do
   end
 
   def on_iterable(a)
-    a.map {|x| do_capitalize(x) }
+    a.map { |x| do_capitalize(x) }
   end
 
   def do_capitalize(x)

data/lib/puppet/functions/ceiling.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Returns the smallest `Integer` greater or equal to the argument.
 # Takes a single numeric value as an argument.
 #
@@ -24,7 +26,7 @@ Puppet::Functions.create_function(:ceiling) do
 
   def on_string(x)
     Puppet.warn_once('deprecations', 'ceiling_function_numeric_coerce_string',
-      _("The ceiling() function's auto conversion of String to Float is deprecated - change to convert input before calling"))
+                     _("The ceiling() function's auto conversion of String to Float is deprecated - change to convert input before calling"))
 
     begin
       Float(x).ceil
@@ -33,5 +35,4 @@ Puppet::Functions.create_function(:ceiling) do
       raise(ArgumentError, _('ceiling(): cannot convert given value to a floating point value.'))
     end
   end
-
 end

data/lib/puppet/functions/chomp.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Returns a new string with the record separator character(s) removed.
 # The record separator is the line ending characters `\r` and `\n`.
 #
@@ -24,7 +26,6 @@
 # Would both result in `['hello', 'hi']`
 #
 Puppet::Functions.create_function(:chomp) do
-
   dispatch :on_numeric do
     param 'Numeric', :arg
   end
@@ -47,7 +48,7 @@ Puppet::Functions.create_function(:chomp) do
   end
 
   def on_iterable(a)
-    a.map {|x| do_chomp(x) }
+    a.map { |x| do_chomp(x) }
   end
 
   def do_chomp(x)

data/lib/puppet/functions/chop.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Returns a new string with the last character removed.
 # If the string ends with `\r\n`, both characters are removed. Applying chop to an empty
 # string returns an empty string. If you wish to merely remove record
@@ -34,7 +36,6 @@
 # Would both result in `['hello', 'hi']`
 #
 Puppet::Functions.create_function(:chop) do
-
   dispatch :on_numeric do
     param 'Numeric', :arg
   end
@@ -57,7 +58,7 @@ Puppet::Functions.create_function(:chop) do
   end
 
   def on_iterable(a)
-    a.map {|x| do_chop(x) }
+    a.map { |x| do_chop(x) }
   end
 
   def do_chop(x)

data/lib/puppet/functions/compare.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Compares two values and returns -1, 0 or 1 if first value is smaller, equal or larger than the second value.
 # The compare function accepts arguments of the data types `String`, `Numeric`, `Timespan`, `Timestamp`, and `Semver`,
 # such that:
@@ -96,14 +98,14 @@ Puppet::Functions.create_function(:compare) do
   end
 
   def on_error(a, b, *ignore_case)
-    if !ignore_case.empty?
+    unless ignore_case.empty?
       unless a.is_a?(String) && b.is_a?(String)
         # TRANSLATORS 'compare' is a name
         return _("compare(): The third argument (ignore case) can only be used when comparing strings")
       end
       unless ignore_case.size == 1
         # TRANSLATORS 'compare' is a name
-        return _("compare(): Accepts at most 3 arguments, got %{actual_number}") % {actual_number: 2 + ignore_case.size}
+        return _("compare(): Accepts at most 3 arguments, got %{actual_number}") % { actual_number: 2 + ignore_case.size }
       end
       unless ignore_case[0].is_a?(Boolean)
         # TRANSLATORS 'compare' is a name
@@ -113,7 +115,7 @@ Puppet::Functions.create_function(:compare) do
 
     if a.class != b.class
       # TRANSLATORS 'compare' is a name
-      return _("compare(): Can only compare values of the same type (or for Timestamp/Timespan also against Numeric). Got %{type_a} and %{type_b}") % {
+      _("compare(): Can only compare values of the same type (or for Timestamp/Timespan also against Numeric). Got %{type_a} and %{type_b}") % {
         type_a: type_label(a), type_b: type_label(b)
       }
     end

data/lib/puppet/functions/contain.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Makes one or more classes be contained inside the current class.
 # If any of these classes are undeclared, they will be declared as if
 # there were declared with the `include` function.
@@ -32,24 +34,25 @@ Puppet::Functions.create_function(:contain, Puppet::Functions::InternalFunction)
     if Puppet[:tasks]
       raise Puppet::ParseErrorWithIssue.from_issue_and_stack(
         Puppet::Pops::Issues::CATALOG_OPERATION_NOT_SUPPORTED_WHEN_SCRIPTING,
-        {:operation => 'contain'})
+        { :operation => 'contain' }
+      )
     end
 
     # Make call patterns uniform and protected against nested arrays, also make
     # names absolute if so desired.
     classes = scope.transform_and_assert_classnames(classes.flatten)
 
-    result = classes.map {|name| Puppet::Pops::Types::TypeFactory.host_class(name) }
+    result = classes.map { |name| Puppet::Pops::Types::TypeFactory.host_class(name) }
     containing_resource = scope.resource
 
     # This is the same as calling the include function but faster and does not rely on the include
     # function.
     (scope.compiler.evaluate_classes(classes, scope, false) || []).each do |resource|
-      if ! scope.catalog.edge?(containing_resource, resource)
+      unless scope.catalog.edge?(containing_resource, resource)
         scope.catalog.add_edge(containing_resource, resource)
       end
     end
     # Result is an Array[Class, 1, n] which allows chaining other operations
     result
   end
-end
+end

data/lib/puppet/functions/convert_to.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # The `convert_to(value, type)` is a convenience function that does the same as `new(type, value)`.
 # The difference in the argument ordering allows it to be used in chained style for
 # improved readability "left to right".

data/lib/puppet/functions/crit.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Logs a message on the server at level `crit`.
 Puppet::Functions.create_function(:crit, Puppet::Functions::InternalFunction) do
   # @param values The values to log.

data/lib/puppet/functions/debug.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Logs a message on the server at level `debug`.
 Puppet::Functions.create_function(:debug, Puppet::Functions::InternalFunction) do
   # @param values The values to log.

data/lib/puppet/functions/defined.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Determines whether a given class or resource type is defined and returns a Boolean
 # value. You can also use `defined` to determine whether a specific resource is defined,
 # or whether a variable has a value (including `undef`, as opposed to the variable never
@@ -99,19 +101,18 @@
 # @since 3.8.1 type specific requests with future parser
 # @since 4.0.0
 #
-Puppet::Functions.create_function(:'defined', Puppet::Functions::InternalFunction) do
-
+Puppet::Functions.create_function(:defined, Puppet::Functions::InternalFunction) do
   dispatch :is_defined do
     scope_param
     required_repeated_param 'Variant[String, Type[CatalogEntry], Type[Type[CatalogEntry]]]', :vals
   end
 
-  def is_defined(scope, *vals)
+  def is_defined(scope, *vals) # rubocop:disable Naming/PredicateName
     vals.any? do |val|
       case val
       when String
         if val =~ /^\$(.+)$/
-          scope.exist?($1)
+          scope.exist?(Regexp.last_match(1))
         else
           case val
           when ''
@@ -130,11 +131,13 @@ Puppet::Functions.create_function(:'defined', Puppet::Functions::InternalFunctio
 
       when Puppet::Pops::Types::PResourceType
         raise ArgumentError, _('The given resource type is a reference to all kind of types') if val.type_name.nil?
+
         type = Puppet::Pops::Evaluator::Runtime3ResourceSupport.find_resource_type(scope, val.type_name)
         val.title.nil? ? type : scope.compiler.findresource(type, val.title)
 
       when Puppet::Pops::Types::PClassType
-        raise  ArgumentError, _('The given class type is a reference to all classes') if val.class_name.nil?
+        raise ArgumentError, _('The given class type is a reference to all classes') if val.class_name.nil?
+
         scope.compiler.findresource(:class, val.class_name)
 
       when Puppet::Pops::Types::PTypeType
@@ -148,7 +151,8 @@ Puppet::Functions.create_function(:'defined', Puppet::Functions::InternalFunctio
           # Interpreted as asking if a class (and nothing else) is defined without having to be included in the catalog
           # (this is the same as asking for just the class' name, but with the added certainty that it cannot be a defined type.
           #
-          raise  ArgumentError, _('The given class type is a reference to all classes') if val.type.class_name.nil?
+          raise ArgumentError, _('The given class type is a reference to all classes') if val.type.class_name.nil?
+
           Puppet::Pops::Evaluator::Runtime3ResourceSupport.find_hostclass(scope, val.type.class_name)
         end
       else

data/lib/puppet/functions/dig.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Returns a value for a sequence of given keys/indexes into a structure, such as
 # an array or hash.
 #
@@ -35,16 +37,17 @@ Puppet::Functions.create_function(:dig) do
 
   def dig(data, *args)
     walked_path = []
-    args.reduce(data) do | d, k |
+    args.reduce(data) do |d, k|
       return nil if d.nil? || k.nil?
-      if !(d.is_a?(Array) || d.is_a?(Hash))
+
+      unless d.is_a?(Array) || d.is_a?(Hash)
         t = Puppet::Pops::Types::TypeCalculator.infer(d)
         msg = _("The given data does not contain a Collection at %{walked_path}, got '%{type}'") % { walked_path: walked_path, type: t }
         error_data = Puppet::DataTypes::Error.new(
-            msg,
-            'SLICE_ERROR',
-            {'walked_path' => walked_path, 'value_type' => t},
-            'EXPECTED_COLLECTION'
+          msg,
+          'SLICE_ERROR',
+          { 'walked_path' => walked_path, 'value_type' => t },
+          'EXPECTED_COLLECTION'
         )
         raise Puppet::ErrorWithData.new(error_data, msg)
       end
@@ -54,10 +57,10 @@ Puppet::Functions.create_function(:dig) do
         t = Puppet::Pops::Types::TypeCalculator.infer(k)
         msg = _("The given data requires an Integer index at %{walked_path}, got '%{type}'") % { walked_path: walked_path, type: t }
         error_data = Puppet::DataTypes::Error.new(
-            msg,
-            'SLICE_ERROR',
-            {'walked_path' => walked_path, 'index_type' => t},
-            'EXPECTED_INTEGER_INDEX'
+          msg,
+          'SLICE_ERROR',
+          { 'walked_path' => walked_path, 'index_type' => t },
+          'EXPECTED_INTEGER_INDEX'
         )
         raise Puppet::ErrorWithData.new(error_data, msg)
       end

data/lib/puppet/functions/downcase.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Converts a String, Array or Hash (recursively) into lower case.
 #
 # This function is compatible with the stdlib function with the same name.
@@ -74,12 +76,12 @@ Puppet::Functions.create_function(:downcase) do
   end
 
   def on_array(a)
-    a.map {|x| do_downcase(x) }
+    a.map { |x| do_downcase(x) }
   end
 
   def on_hash(h)
     result = {}
-    h.each_pair {|k,v| result[do_downcase(k)] = do_downcase(v) }
+    h.each_pair { |k, v| result[do_downcase(k)] = do_downcase(v) }
     result
   end
 

data/lib/puppet/functions/each.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Runs a [lambda](https://puppet.com/docs/puppet/latest/lang_lambdas.html)
 # repeatedly using each value in a data structure, then returns the values unchanged.
 #

data/lib/puppet/functions/emerg.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Logs a message on the server at level `emerg`.
 Puppet::Functions.create_function(:emerg, Puppet::Functions::InternalFunction) do
   # @param values The values to log.

data/lib/puppet/functions/empty.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Returns `true` if the given argument is an empty collection of values.
 #
 # This function can answer if one of the following is empty: