openvox 7.37.1 → 8.19.0

data/lib/puppet/pops/resource/param.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # An implementation of the interface Puppet::Resource
 # that adapts the 3.x compiler and catalog expectations on
 # a resource instance. This instance is backed by a
@@ -19,18 +21,17 @@ class Param
   include Puppet::Pops::Types::PuppetObject
 
   def self.register_ptype(loader, ir)
-    @ptype = Pcore::create_object_type(loader, ir, self, 'Puppet::Resource::Param', nil,
-      {
-        Types::KEY_TYPE => Types::PTypeType::DEFAULT,
-        Types::KEY_NAME => Types::PStringType::NON_EMPTY,
-        'name_var' => {
-          Types::KEY_TYPE => Types::PBooleanType::DEFAULT,
-          Types::KEY_VALUE => false
-        }
-      },
-      EMPTY_HASH,
-      [Types::KEY_NAME]
-    )
+    @ptype = Pcore.create_object_type(loader, ir, self, 'Puppet::Resource::Param', nil,
+                                      {
+                                        Types::KEY_TYPE => Types::PTypeType::DEFAULT,
+                                        Types::KEY_NAME => Types::PStringType::NON_EMPTY,
+                                        'name_var' => {
+                                          Types::KEY_TYPE => Types::PBooleanType::DEFAULT,
+                                          Types::KEY_VALUE => false
+                                        }
+                                      },
+                                      EMPTY_HASH,
+                                      [Types::KEY_NAME])
   end
 
   attr_reader :name

data/lib/puppet/pops/resource/resource_type_impl.rb

@@ -1,13 +1,14 @@
+# frozen_string_literal: true
+
 require_relative 'param'
 
 module Puppet::Pops
 module Resource
-
 def self.register_ptypes(loader, ir)
   types = [Param, ResourceTypeImpl].map do |c|
     c.register_ptype(loader, ir)
   end
-  types.each {|t| t.resolve(loader) }
+  types.each { |t| t.resolve(loader) }
 end
 
 class ResourceTypeImpl
@@ -27,34 +28,34 @@ class ResourceTypeImpl
 
   def self.register_ptype(loader, ir)
     param_ref = Types::PTypeReferenceType.new('Puppet::Resource::Param')
-    @ptype = Pcore::create_object_type(loader, ir, self, 'Puppet::Resource::ResourceType3', nil,
-      {
-        Types::KEY_NAME => Types::PStringType::NON_EMPTY,
-        'properties' => {
-          Types::KEY_TYPE => Types::PArrayType.new(param_ref),
-          Types::KEY_VALUE => EMPTY_ARRAY
-        },
-        'parameters' => {
-          Types::KEY_TYPE => Types::PArrayType.new(param_ref),
-          Types::KEY_VALUE => EMPTY_ARRAY
-        },
-        'title_patterns_hash' => {
-          Types::KEY_TYPE => Types::POptionalType.new(
-            Types::PHashType.new(Types::PRegexpType::DEFAULT, Types::PArrayType.new(Types::PStringType::NON_EMPTY))),
-          Types::KEY_VALUE => nil
-        },
-        'isomorphic' => {
-          Types::KEY_TYPE => Types::PBooleanType::DEFAULT,
-          Types::KEY_VALUE => true
-        },
-        'capability' => {
-          Types::KEY_TYPE => Types::PBooleanType::DEFAULT,
-          Types::KEY_VALUE => false
-        },
-      },
-      EMPTY_HASH,
-      [Types::KEY_NAME]
-    )
+    @ptype = Pcore.create_object_type(loader, ir, self, 'Puppet::Resource::ResourceType3', nil,
+                                      {
+                                        Types::KEY_NAME => Types::PStringType::NON_EMPTY,
+                                        'properties' => {
+                                          Types::KEY_TYPE => Types::PArrayType.new(param_ref),
+                                          Types::KEY_VALUE => EMPTY_ARRAY
+                                        },
+                                        'parameters' => {
+                                          Types::KEY_TYPE => Types::PArrayType.new(param_ref),
+                                          Types::KEY_VALUE => EMPTY_ARRAY
+                                        },
+                                        'title_patterns_hash' => {
+                                          Types::KEY_TYPE => Types::POptionalType.new(
+                                            Types::PHashType.new(Types::PRegexpType::DEFAULT, Types::PArrayType.new(Types::PStringType::NON_EMPTY))
+                                          ),
+                                          Types::KEY_VALUE => nil
+                                        },
+                                        'isomorphic' => {
+                                          Types::KEY_TYPE => Types::PBooleanType::DEFAULT,
+                                          Types::KEY_VALUE => true
+                                        },
+                                        'capability' => {
+                                          Types::KEY_TYPE => Types::PBooleanType::DEFAULT,
+                                          Types::KEY_VALUE => false
+                                        },
+                                      },
+                                      EMPTY_HASH,
+                                      [Types::KEY_NAME])
   end
 
   def eql?(other)
@@ -72,8 +73,9 @@ class ResourceTypeImpl
     # Order is only maintained against other types, not arbitrary objects.
     # The natural order is based on the reference name used when comparing
     return nil unless other.is_a?(Puppet::CompilableResourceType)
+
     # against other type instances.
-    self.ref <=> other.ref
+    ref <=> other.ref
   end
 
   METAPARAMS = [
@@ -88,7 +90,7 @@ class ResourceTypeImpl
     :before,
     :notify,
     :stage
-    ].freeze
+  ].freeze
 
   # Speed up lookup
   METAPARAMSET = Set.new(METAPARAMS).freeze
@@ -116,7 +118,7 @@ class ResourceTypeImpl
     @attr_types = {}
 
     # Add all meta params
-    METAPARAMS.each {|p| @attr_types[p] = :meta }
+    METAPARAMS.each { |p| @attr_types[p] = :meta }
 
     @property_set = Set.new(properties.map do |p|
       symname = p.name.to_sym
@@ -148,12 +150,12 @@ class ResourceTypeImpl
         nil
       when 1
         if @title_patterns_hash.nil?
-          [ [ /(.*)/m, [ [@key_attributes.first] ] ] ]
+          [[/(.*)/m, [[@key_attributes.first]]]]
         else
           # TechDebt: The case of having one namevar and an empty title patterns is unspecified behavior in puppet.
           # Here, it may lead to an empty map which may or may not trigger the wanted/expected behavior.
           #
-          @title_patterns_hash.map { |k,v| [ k, v.map { |n| [ n.to_sym ] } ] }
+          @title_patterns_hash.map { |k, v| [k, v.map { |n| [n.to_sym] }] }
         end
       else
         if @title_patterns_hash.nil? || @title_patterns_hash.empty?
@@ -164,7 +166,8 @@ class ResourceTypeImpl
           #
           raise Puppet::DevError, _("you must specify title patterns when there are two or more key attributes")
         end
-        @title_patterns_hash.nil? ? [] : @title_patterns_hash.map { |k,v| [ k, v.map { |n| [ n.to_sym] } ] }
+
+        @title_patterns_hash.nil? ? [] : @title_patterns_hash.map { |k, v| [k, v.map { |n| [n.to_sym] }] }
       end
   end
 
@@ -187,7 +190,7 @@ class ResourceTypeImpl
   #
   # This implementation does nothing - it is assumed that the catalog is already validated
   # via the relationship validator (done late in the game).
-  def finish()
+  def finish
     # Do nothing.
   end
 
@@ -201,16 +204,16 @@ class ResourceTypeImpl
     # This is what the Puppet::Type implementation does
     # None of this should be needed
 
-      #    # Make sure our parent class has been evaluated, if we have one.
-      #    if parent && !scope.catalog.resource(resource.type, parent)
-      #      parent_type(scope).ensure_in_catalog(scope)
-      #    end
+    #    # Make sure our parent class has been evaluated, if we have one.
+    #    if parent && !scope.catalog.resource(resource.type, parent)
+    #      parent_type(scope).ensure_in_catalog(scope)
+    #    end
 
     # This will never happen
 
-      #    if ['Class', 'Node'].include? resource.type
-      #      scope.catalog.tag(*resource.tags)
-      #    end
+    #    if ['Class', 'Node'].include? resource.type
+    #      scope.catalog.tag(*resource.tags)
+    #    end
   end
 
   # Being isomorphic in puppet means that the resource is managing a state
@@ -288,7 +291,6 @@ class ResourceTypeImpl
   def can_apply_to_target(target)
     raise NotImplementedError, "can_apply_to_target() - probably used when selecting a provider (device/host support)"
   end
-
 end
 end
 end

data/lib/puppet/pops/semantic_error.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Error that is used to raise an Issue. See {Puppet::Pops::Issues}.
 #
 class Puppet::Pops::SemanticError < RuntimeError
@@ -9,7 +11,7 @@ class Puppet::Pops::SemanticError < RuntimeError
   # @param semantic [Puppet::Pops::Model::Locatable, nil] the expression causing the failure, or nil if unknown
   # @param options [Hash] an options hash with Symbol to value mapping - these are the arguments to the issue
   #
-  def initialize(issue, semantic=nil, options = {})
+  def initialize(issue, semantic = nil, options = {})
     @issue = issue
     @semantic = semantic
     @options = options

data/lib/puppet/pops/serialization/abstract_reader.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'extension'
 require_relative 'time_factory'
 
@@ -114,7 +116,7 @@ class AbstractReader
     end
 
     register_type(Extension::DEFAULT) do |data|
-      read_payload(data) { |ep| Extension::Default::INSTANCE }
+      read_payload(data) { |_ep| Extension::Default::INSTANCE }
     end
 
     register_type(Extension::COMMENT) do |data|
@@ -122,7 +124,7 @@ class AbstractReader
     end
 
     register_type(Extension::SENSITIVE_START) do |data|
-      read_payload(data) { |ep| Extension::SensitiveStart::INSTANCE }
+      read_payload(data) { |_ep| Extension::SensitiveStart::INSTANCE }
     end
 
     register_type(Extension::REGEXP) do |data|
@@ -141,7 +143,7 @@ class AbstractReader
       read_payload(data) do |ep|
         sec = ep.read
         nsec = ep.read
-        Time::Timestamp.new(sec * 1000000000 + nsec)
+        Time::Timestamp.new(sec * 1_000_000_000 + nsec)
       end
     end
 
@@ -149,7 +151,7 @@ class AbstractReader
       read_payload(data) do |ep|
         sec = ep.read
         nsec = ep.read
-        Time::Timespan.new(sec * 1000000000 + nsec)
+        Time::Timespan.new(sec * 1_000_000_000 + nsec)
       end
     end
 

data/lib/puppet/pops/serialization/abstract_writer.rb

@@ -1,9 +1,10 @@
+# frozen_string_literal: true
+
 require_relative 'extension'
 
 module Puppet::Pops
 module Serialization
-
-MAX_INTEGER =  0x7fffffffffffffff
+MAX_INTEGER = 0x7fffffffffffffff
 MIN_INTEGER = -0x8000000000000000
 
 # Abstract class for protocol specific writers such as MsgPack or JSON
@@ -92,15 +93,16 @@ class AbstractWriter
   def write_tpl_qname(ep, qname)
     names = qname.split('::')
     ep.write(names.size)
-    names.each {|n| write_tpl(ep, n)}
+    names.each { |n| write_tpl(ep, n) }
   end
 
   # Called from extension callbacks only
   #
   # @api private
   def write_tpl(ep, value)
-    #TRANSLATORS 'Integers' is a Ruby class for numbers and should not be translated
+    # TRANSLATORS 'Integers' is a Ruby class for numbers and should not be translated
     raise ArgumentError, _('Internal error. Integers cannot be tabulated in extension payload') if value.is_a?(Integer)
+
     if @tabulate
       index = @written[value]
       if index.nil?
@@ -149,7 +151,7 @@ class AbstractWriter
 
     # 0x20 - 0x2f reserved for special extension objects
 
-    register_type(Extension::DEFAULT, Extension::Default) do |o|
+    register_type(Extension::DEFAULT, Extension::Default) do |_o|
       build_payload { |ep| }
     end
 
@@ -157,7 +159,7 @@ class AbstractWriter
       build_payload { |ep| ep.write(o.comment) }
     end
 
-    register_type(Extension::SENSITIVE_START, Extension::SensitiveStart) do |o|
+    register_type(Extension::SENSITIVE_START, Extension::SensitiveStart) do |_o|
       build_payload { |ep| }
     end
 
@@ -176,11 +178,11 @@ class AbstractWriter
     end
 
     register_type(Extension::TIME, Time::Timestamp) do |o|
-      build_payload { |ep| nsecs = o.nsecs; ep.write(nsecs / 1000000000); ep.write(nsecs % 1000000000) }
+      build_payload { |ep| nsecs = o.nsecs; ep.write(nsecs / 1_000_000_000); ep.write(nsecs % 1_000_000_000) }
     end
 
     register_type(Extension::TIMESPAN, Time::Timespan) do |o|
-      build_payload { |ep| nsecs = o.nsecs; ep.write(nsecs / 1000000000); ep.write(nsecs % 1000000000) }
+      build_payload { |ep| nsecs = o.nsecs; ep.write(nsecs / 1_000_000_000); ep.write(nsecs % 1_000_000_000) }
     end
 
     register_type(Extension::VERSION, SemanticPuppet::Version) do |o|
@@ -211,7 +213,7 @@ class AbstractWriter
   end
 
   def to_s
-    "#{self.class.name}"
+    self.class.name.to_s
   end
 
   def inspect

data/lib/puppet/pops/serialization/deserializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'extension'
 
 module Puppet::Pops
@@ -44,6 +46,7 @@ module Serialization
         type_name = val.type_name
         type = Types::TypeParser.singleton.parse(type_name, @loader)
         raise SerializationError, _("No implementation mapping found for Puppet Type %{type_name}") % { type_name: type_name } if type.is_a?(Types::PTypeReferenceType)
+
         result = type.read(val.attribute_count, self)
         if result.is_a?(Types::PObjectType)
           existing_type = loader.load(:type, result.name)

data/lib/puppet/pops/serialization/extension.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Puppet::Pops
 module Serialization
 module Extension
@@ -48,6 +50,7 @@ module Extension
   class Tabulation
     include NotTabulated
     attr_reader :index
+
     def initialize(index)
       @index = index
     end
@@ -62,6 +65,7 @@ module Extension
     include NotTabulated
     include SequenceStart
     attr_reader :size
+
     def initialize(size)
       @size = size
     end
@@ -77,6 +81,7 @@ module Extension
     include NotTabulated
     include SequenceStart
     attr_reader :size
+
     def initialize(size)
       @size = size
     end
@@ -97,6 +102,7 @@ module Extension
   class PcoreObjectStart
     include SequenceStart
     attr_reader :type_name, :attribute_count
+
     def initialize(type_name, attribute_count)
       @type_name = type_name
       @attribute_count = attribute_count
@@ -119,6 +125,7 @@ module Extension
   class ObjectStart
     include SequenceStart
     attr_reader :attribute_count
+
     def initialize(attribute_count)
       @attribute_count = attribute_count
     end
@@ -140,6 +147,7 @@ module Extension
   # The class that triggers the use of the COMMENT extension. The payload is comment text
   class Comment
     attr_reader :comment
+
     def initialize(comment)
       @comment = comment
     end

data/lib/puppet/pops/serialization/from_data_converter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Puppet::Pops
 module Serialization
   class Builder
@@ -18,9 +20,10 @@ module Serialization
     def resolve
       unless @resolved
         @resolved = true
-        if @values.is_a?(Array)
+        case @values
+        when Array
           @values.each_with_index { |v, idx| @values[idx] = v.resolve if v.is_a?(Builder) }
-        elsif @values.is_a?(Hash)
+        when Hash
           @values.each_pair { |k, v| @values[k] = v.resolve if v.is_a?(Builder) }
         end
       end
@@ -123,6 +126,7 @@ module Serialization
           type = without_value { convert(type_value) }
           if type.is_a?(Hash)
             raise SerializationError, _('Unable to deserialize type from %{type}') % { type: type } unless @allow_unresolved
+
             hash
           else
             pcore_type_hash_to_value(type, value)
@@ -133,6 +137,7 @@ module Serialization
             unless @allow_unresolved
               raise SerializationError, _('No implementation mapping found for Puppet Type %{type_name}') % { type_name: type_value }
             end
+
             hash
           else
             # not a string
@@ -149,15 +154,16 @@ module Serialization
     #
     # @api public
     def convert(value)
-      if value.is_a?(Hash)
+      case value
+      when Hash
         pcore_type = value[PCORE_TYPE_KEY]
         if pcore_type && (pcore_type.is_a?(String) || pcore_type.is_a?(Hash))
           @pcore_type_procs[pcore_type].call(value, pcore_type)
         else
-          build({}) { value.each_pair { |key, elem| with(key) { convert(elem) }}}
+          build({}) { value.each_pair { |key, elem| with(key) { convert(elem) } } }
         end
-      elsif value.is_a?(Array)
-        build([]) { value.each_with_index { |elem, idx| with(idx) { convert(elem)}}}
+      when Array
+        build([]) { value.each_with_index { |elem, idx| with(idx) { convert(elem) } } }
       else
         build(value)
       end
@@ -203,7 +209,8 @@ module Serialization
     end
 
     def pcore_type_hash_to_value(pcore_type, value)
-      if value.is_a?(Hash)
+      case value
+      when Hash
         # Complex object
         if value.empty?
           build(pcore_type.create)
@@ -212,11 +219,11 @@ module Serialization
         else
           build_object(ObjectArrayBuilder.new(pcore_type.allocate)) { value.each_pair { |key, elem| with(key) { convert(elem) } } }
         end
-      elsif value.is_a?(String)
+      when String
         build(pcore_type.create(value))
       else
         raise SerializationError, _('Cannot create a %{type_name} from a %{arg_class}') %
-            { :type_name => pcore_type.name, :arg_class => value.class.name }
+                                  { :type_name => pcore_type.name, :arg_class => value.class.name }
       end
     end
   end

data/lib/puppet/pops/serialization/instance_reader.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Puppet::Pops
 module Serialization
   # An InstanceReader is responsible for reading an instance of a complex object using a deserializer. The read involves creating the

data/lib/puppet/pops/serialization/instance_writer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Puppet::Pops
 module Serialization
   # An instance writer is responsible for writing complex objects using a {Serializer}

data/lib/puppet/pops/serialization/json.rb

@@ -1,8 +1,9 @@
+# frozen_string_literal: true
+
 require_relative '../../../puppet/util/json'
 
 module Puppet::Pops
 module Serialization
-
 require_relative 'time_factory'
 require_relative 'abstract_reader'
 require_relative 'abstract_writer'
@@ -109,7 +110,7 @@ module JSON
         obj.each { |x| write(x) }
       when Hash
         write_map_header(obj.size)
-        obj.each_pair {|k, v| write(k); write(v) }
+        obj.each_pair { |k, v| write(k); write(v) }
       when nil
         write_nil
       else
@@ -123,7 +124,7 @@ module JSON
         @io << '[]'
       else
         @io << '['
-        @nested <<  [false, n]
+        @nested << [false, n]
       end
     end
 
@@ -132,7 +133,7 @@ module JSON
         @io << '{}'
       else
         @io << '{'
-        @nested <<  [true, n * 2]
+        @nested << [true, n * 2]
       end
     end
 
@@ -181,7 +182,7 @@ module JSON
         @nested.pop
         write_delim
       when Integer
-        if (cnt % 2) == 0 || !nesting[0]
+        if cnt.even? || !nesting[0]
           @io << ','
         else
           @io << ':'
@@ -249,6 +250,7 @@ module JSON
     def re_initialize(io)
       parsed = parse_io(io)
       raise SerializationError, _("JSON stream is not an array. It is a %{klass}") % { klass: io.class.name } unless parsed.is_a?(Array)
+
       @etor_stack = [parsed.each]
     end
 
@@ -256,6 +258,7 @@ module JSON
       obj = nil
       loop do
         raise SerializationError, _('Unexpected end of input') if @etor_stack.empty?
+
         etor = @etor_stack.last
         begin
           obj = etor.next
@@ -270,6 +273,7 @@ module JSON
         ext_no = ext_etor.next
         ext_block = @type_registry[ext_no]
         raise SerializationError, _("Invalid input. %{ext_no} is not a valid extension number") % { ext_no: ext_no } if ext_block.nil?
+
         obj = ext_block.call(nil)
       end
       obj

data/lib/puppet/pops/serialization/json_path.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../../puppet/concurrent/thread_local_singleton'
 
 module Puppet::Pops
@@ -10,7 +12,7 @@ module JsonPath
   #
   # @api private
   def self.to_json_path(path)
-    p = '$'
+    p = '$'.dup
     path.each do |seg|
       if seg.nil?
         p << '[null]'

data/lib/puppet/pops/serialization/object.rb

@@ -1,9 +1,10 @@
+# frozen_string_literal: true
+
 require_relative 'instance_reader'
 require_relative 'instance_writer'
 
 module Puppet::Pops
 module Serialization
-
 # Instance reader for objects that implement {Types::PuppetObject}
 # @api private
 class ObjectReader
@@ -15,6 +16,7 @@ class ObjectReader
     unless value_count >= required_count && value_count <= max
       raise Serialization::SerializationError, _("Feature count mismatch for %{value0}. Expected %{required_count} - %{max}, actual %{value_count}") % { value0: impl_class.name, required_count: required_count, max: max, value_count: value_count }
     end
+
     # Deserializer must know about this instance before we read its attributes
     val = deserializer.remember(impl_class.allocate)
     args = Array.new(value_count) { deserializer.read }
@@ -25,6 +27,7 @@ class ObjectReader
       else
         attr = type[names[index]]
         raise Serialization::SerializationError, _("Missing default value for %{type_name}[%{name}]") % { type_name: type.name, name: names[index] } unless attr && attr.value?
+
         args << attr.value
       end
     end
@@ -47,7 +50,8 @@ class ObjectWriter
 
     # Pop optional arguments that are default
     while args.size > required_count
-      break unless type[names[args.size-1]].default_value?(args.last)
+      break unless type[names[args.size - 1]].default_value?(args.last)
+
       args.pop
     end
 
@@ -67,4 +71,3 @@ class ObjectWriter
 end
 end
 end
-