openvox 7.37.1 → 8.19.0

data/lib/puppet/type/file/group.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../../puppet/util/posix'
 
 module Puppet
@@ -37,7 +39,7 @@ module Puppet
     end
 
     # We want to print names, not numbers
-    def is_to_s(currentvalue)
+    def is_to_s(currentvalue) # rubocop:disable Naming/PredicateName
       super(provider.gid2name(currentvalue) || currentvalue)
     end
 

data/lib/puppet/type/file/mode.rb

@@ -1,8 +1,9 @@
+# frozen_string_literal: true
+
 # Manage file modes.  This state should support different formats
 # for specification (e.g., u+rwx, or -0011), but for now only supports
 # specifying the full mode.
 
-
 module Puppet
   Puppet::Type.type(:file).newproperty(:mode) do
     require_relative '../../../puppet/util/symbolic_file_mode'
@@ -75,7 +76,7 @@ module Puppet
     EOT
 
     validate do |value|
-      if !value.is_a?(String)
+      unless value.is_a?(String)
         raise Puppet::Error, "The file mode specification must be a string, not '#{value.class.name}'"
       end
       unless value.nil? or valid_symbolic_mode?(value)
@@ -110,9 +111,9 @@ module Puppet
     def dirmask(value)
       if FileTest.directory?(resource[:path]) and value =~ /^\d+$/ then
         value = value.to_i(8)
-        value |= 0100 if value & 0400 != 0
-        value |= 010 if value & 040 != 0
-        value |= 01 if value & 04 != 0
+        value |= 0o100 if value & 0o400 != 0
+        value |= 0o10 if value & 0o40 != 0
+        value |= 0o1 if value & 0o4 != 0
         value = value.to_s(8)
       end
 
@@ -125,19 +126,21 @@ module Puppet
       if provider.respond_to?(:munge_windows_system_group)
         munged_mode = provider.munge_windows_system_group(currentvalue, @should)
         return false if munged_mode.nil?
+
         currentvalue = munged_mode
       end
       stat = @resource.stat
       if stat && stat.ftype == "link" && @resource[:links] != :follow
-        self.debug _("Not managing symlink mode")
-        return true
+        debug _("Not managing symlink mode")
+        true
       else
-        return super(currentvalue)
+        super(currentvalue)
       end
     end
 
     def property_matches?(current, desired)
       return false unless current
+
       current_bits = normalize_symbolic_mode(current)
       desired_bits = desired_mode_from_current(desired, current).to_s(8)
       current_bits == desired_bits
@@ -150,7 +153,7 @@ module Puppet
     # been synced.
     def retrieve
       if @resource.stat
-        @should &&= @should.collect { |s| self.dirmask(s) }
+        @should &&= @should.collect { |s| dirmask(s) }
       end
 
       super
@@ -160,7 +163,7 @@ module Puppet
     # don't have access to the calculated "desired" value here, or the
     # "current" value, only the "should" value we need to retrieve again.
     def sync
-      current = @resource.stat ? @resource.stat.mode : 0644
+      current = @resource.stat ? @resource.stat.mode : 0o644
       set(desired_mode_from_current(@should[0], current).to_s(8))
     end
 
@@ -176,7 +179,7 @@ module Puppet
       "'#{should_value.rjust(4, '0')}'"
     end
 
-    def is_to_s(currentvalue)
+    def is_to_s(currentvalue) # rubocop:disable Naming/PredicateName
       if currentvalue == :absent
         # This can occur during audits---if a file is transitioning from
         # present to absent the mode will have a value of `:absent`.

data/lib/puppet/type/file/mtime.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 module Puppet
   Puppet::Type.type(:file).newproperty(:mtime) do
-    desc %q{A read-only state to check the file mtime. On \*nix-like systems, this
-      is the time of the most recent change to the content of the file.}
+    desc "A read-only state to check the file mtime. On \*nix-like systems, this
+      is the time of the most recent change to the content of the file."
 
     def retrieve
       current_value = :absent
@@ -12,7 +14,7 @@ module Puppet
       current_value.to_s
     end
 
-    validate do |val|
+    validate do |_val|
       fail "mtime is read-only"
     end
   end

data/lib/puppet/type/file/owner.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Puppet
   Puppet::Type.type(:file).newproperty(:owner) do
     include Puppet::Util::Warnings
@@ -39,7 +41,7 @@ module Puppet
     end
 
     # We want to print names, not numbers
-    def is_to_s(currentvalue)
+    def is_to_s(currentvalue) # rubocop:disable Naming/PredicateName
       super(provider.uid2name(currentvalue) || currentvalue)
     end
 
@@ -48,4 +50,3 @@ module Puppet
     end
   end
 end
-

data/lib/puppet/type/file/selcontext.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Manage SELinux context of files.
 #
 # This code actually manages three pieces of data in the context.
@@ -19,7 +21,6 @@
 #
 # See https://www.nsa.gov/selinux/ for complete docs on SELinux.
 
-
 module Puppet
   require_relative '../../../puppet/util/selinux'
 
@@ -28,35 +29,37 @@ module Puppet
 
     def retrieve
       return :absent unless @resource.stat
-      context = self.get_selinux_current_context(@resource[:path])
+
+      context = get_selinux_current_context(@resource[:path])
       is = parse_selinux_context(name, context)
       if name == :selrange and selinux_support?
-        self.selinux_category_to_label(is)
+        selinux_category_to_label(is)
       else
         is
       end
     end
 
     def retrieve_default_context(property)
+      return nil if Puppet::Util::Platform.windows?
       if @resource[:selinux_ignore_defaults] == :true
         return nil
       end
 
-      context = self.get_selinux_default_context(@resource[:path], @resource[:ensure])
+      context = get_selinux_default_context_with_handle(@resource[:path], provider.class.selinux_handle, @resource[:ensure])
       unless context
         return nil
       end
 
-      property_default = self.parse_selinux_context(property, context)
-      self.debug "Found #{property} default '#{property_default}' for #{@resource[:path]}" if not property_default.nil?
+      property_default = parse_selinux_context(property, context)
+      debug "Found #{property} default '#{property_default}' for #{@resource[:path]}" unless property_default.nil?
       property_default
     end
 
     def insync?(value)
-      if not selinux_support?
+      if !selinux_support?
         debug("SELinux bindings not found. Ignoring parameter.")
         true
-      elsif not selinux_label_support?(@resource[:path])
+      elsif !selinux_label_support?(@resource[:path])
         debug("SELinux not available for this filesystem. Ignoring parameter.")
         true
       else
@@ -65,25 +68,25 @@ module Puppet
     end
 
     def unsafe_munge(should)
-      if not selinux_support?
+      unless selinux_support?
         return should
       end
 
       if name == :selrange
-        self.selinux_category_to_label(should)
+        selinux_category_to_label(should)
       else
         should
       end
     end
 
     def sync
-      self.set_selinux_context(@resource[:path], @should, name)
+      set_selinux_context(@resource[:path], @should, name)
       :file_changed
     end
   end
 
   Puppet::Type.type(:file).newparam(:selinux_ignore_defaults) do
-    desc "If this is set then Puppet will not ask SELinux (via matchpathcon) to
+    desc "If this is set, Puppet will not call the SELinux function selabel_lookup to
       supply defaults for the SELinux attributes (seluser, selrole,
       seltype, and selrange). In general, you should leave this set at its
       default and only set it to true when you need Puppet to not try to fix
@@ -96,47 +99,45 @@ module Puppet
   Puppet::Type.type(:file).newproperty(:seluser, :parent => Puppet::SELFileContext) do
     desc "What the SELinux user component of the context of the file should be.
       Any valid SELinux user component is accepted.  For example `user_u`.
-      If not specified it defaults to the value returned by matchpathcon for
+      If not specified, it defaults to the value returned by selabel_lookup for
       the file, if any exists.  Only valid on systems with SELinux support
       enabled."
 
     @event = :file_changed
-    defaultto { self.retrieve_default_context(:seluser) }
+    defaultto { retrieve_default_context(:seluser) }
   end
 
   Puppet::Type.type(:file).newproperty(:selrole, :parent => Puppet::SELFileContext) do
     desc "What the SELinux role component of the context of the file should be.
       Any valid SELinux role component is accepted.  For example `role_r`.
-      If not specified it defaults to the value returned by matchpathcon for
+      If not specified, it defaults to the value returned by selabel_lookup for
       the file, if any exists.  Only valid on systems with SELinux support
       enabled."
 
     @event = :file_changed
-    defaultto { self.retrieve_default_context(:selrole) }
+    defaultto { retrieve_default_context(:selrole) }
   end
 
   Puppet::Type.type(:file).newproperty(:seltype, :parent => Puppet::SELFileContext) do
     desc "What the SELinux type component of the context of the file should be.
       Any valid SELinux type component is accepted.  For example `tmp_t`.
-      If not specified it defaults to the value returned by matchpathcon for
+      If not specified, it defaults to the value returned by selabel_lookup for
       the file, if any exists.  Only valid on systems with SELinux support
       enabled."
 
     @event = :file_changed
-    defaultto { self.retrieve_default_context(:seltype) }
+    defaultto { retrieve_default_context(:seltype) }
   end
 
   Puppet::Type.type(:file).newproperty(:selrange, :parent => Puppet::SELFileContext) do
     desc "What the SELinux range component of the context of the file should be.
       Any valid SELinux range component is accepted.  For example `s0` or
-      `SystemHigh`.  If not specified it defaults to the value returned by
-      matchpathcon for the file, if any exists.  Only valid on systems with
+      `SystemHigh`.  If not specified, it defaults to the value returned by
+      selabel_lookup for the file, if any exists.  Only valid on systems with
       SELinux support enabled and that have support for MCS (Multi-Category
       Security)."
 
     @event = :file_changed
-    defaultto { self.retrieve_default_context(:selrange) }
+    defaultto { retrieve_default_context(:selrange) }
   end
-
 end
-

data/lib/puppet/type/file/source.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../../puppet/file_serving/content'
 require_relative '../../../puppet/file_serving/metadata'
 require_relative '../../../puppet/file_serving/terminus_helper'
@@ -11,8 +13,8 @@ module Puppet
   # this state, during retrieval, modifies the appropriate other states
   # so that things get taken care of appropriately.
   Puppet::Type.type(:file).newparam(:source) do
-
     attr_accessor :source, :local
+
     desc <<-'EOT'
       A source file, which will be copied into place on the local system. This
       attribute is mutually exclusive with `content` and `target`. Allowed
@@ -72,7 +74,7 @@ module Puppet
           file { '/etc/nfs.conf':
             source => [
               "puppet:///modules/nfs/conf.${host}",
-              "puppet:///modules/nfs/conf.${operatingsystem}",
+              "puppet:///modules/nfs/conf.${os['name']}",
               'puppet:///modules/nfs/conf'
             ]
           }
@@ -94,7 +96,7 @@ module Puppet
 
         self.fail "Cannot use relative URLs '#{source}'" unless uri.absolute?
         self.fail "Cannot use opaque URLs '#{source}'" unless uri.hierarchical?
-        unless %w{file puppet http https}.include?(uri.scheme)
+        unless %w[file puppet http https].include?(uri.scheme)
           self.fail "Cannot use URLs of type '#{uri.scheme}' as source for fileserving"
         end
       end
@@ -128,9 +130,9 @@ module Puppet
     def change_to_s(currentvalue, newvalue)
       # newvalue = "{md5}#{@metadata.checksum}"
       if resource.property(:ensure).retrieve == :absent
-        return "creating from source #{metadata.source} with contents #{metadata.checksum}"
+        "creating from source #{metadata.source} with contents #{metadata.checksum}"
       else
-        return "replacing from source #{metadata.source} with contents #{metadata.checksum}"
+        "replacing from source #{metadata.source} with contents #{metadata.checksum}"
       end
     end
 
@@ -185,26 +187,25 @@ module Puppet
       return @metadata if @metadata
 
       return nil unless value
+
       value.each do |source|
-        begin
-          options = {
-            :environment          => resource.catalog.environment_instance,
-            :links                => resource[:links],
-            :checksum_type        => resource[:checksum],
-            :source_permissions   => resource[:source_permissions]
-          }
+        options = {
+          :environment => resource.catalog.environment_instance,
+          :links => resource[:links],
+          :checksum_type => resource[:checksum],
+          :source_permissions => resource[:source_permissions]
+        }
 
-          data = Puppet::FileServing::Metadata.indirection.find(source, options)
-          if data
-            @metadata = data
-            @metadata.source = source
-            break
-          end
-        rescue => detail
-          self.fail Puppet::Error, "Could not retrieve file metadata for #{source}: #{detail}", detail
+        data = Puppet::FileServing::Metadata.indirection.find(source, options)
+        if data
+          @metadata = data
+          @metadata.source = source
+          break
         end
+      rescue => detail
+        self.fail Puppet::Error, "Could not retrieve file metadata for #{source}: #{detail}", detail
       end
-      self.fail "Could not retrieve information from environment #{resource.catalog.environment} source(s) #{value.join(", ")}" unless @metadata
+      self.fail "Could not retrieve information from environment #{resource.catalog.environment} source(s) #{value.join(', ')}" unless @metadata
       @metadata
     end
 
@@ -217,7 +218,7 @@ module Puppet
     end
 
     def server?
-       uri && uri.host && !uri.host.empty?
+      uri && uri.host && !uri.host.empty?
     end
 
     def server
@@ -248,7 +249,7 @@ module Puppet
     end
 
     def found?
-      ! (metadata.nil? or metadata.ftype.nil?)
+      !(metadata.nil? or metadata.ftype.nil?)
     end
 
     def copy_source_value(metadata_method)
@@ -263,7 +264,7 @@ module Puppet
         value = value.to_s(8) if param_name == :mode && value.is_a?(Numeric)
         resource[param_name] = value
 
-        if (metadata_method == :checksum)
+        if metadata_method == :checksum
           # If copying checksum, also copy checksum_type
           resource[:checksum] = metadata.checksum_type
         end
@@ -282,7 +283,7 @@ module Puppet
 
     def chunk_file_from_disk(local_path)
       File.open(local_path, "rb") do |src|
-        while chunk = src.read(8192) #rubocop:disable Lint/AssignmentInCondition
+        while chunk = src.read(8192) # rubocop:disable Lint/AssignmentInCondition
           yield chunk
         end
       end
@@ -313,8 +314,8 @@ module Puppet
 
     def get_from_http_source(url, &block)
       client = Puppet.runtime[:http]
-      client.get(url, options: {include_system_store: true}) do |response|
-        raise Puppet::HTTP::ResponseError.new(response) unless response.success?
+      client.get(url, options: { include_system_store: true }) do |response|
+        raise Puppet::HTTP::ResponseError, response unless response.success?
 
         response.read_body(&block)
       end
@@ -366,14 +367,14 @@ module Puppet
 
     defaultto :ignore
     newvalues(:use, :use_when_creating, :ignore)
-     munge do |value|
+    munge do |value|
       value = value ? value.to_sym : :ignore
       if @resource.file && @resource.line && value != :ignore
-        #TRANSLATORS "source_permissions" is a parameter name and should not be translated
+        # TRANSLATORS "source_permissions" is a parameter name and should not be translated
         Puppet.puppet_deprecation_warning(_("The `source_permissions` parameter is deprecated. Explicitly set `owner`, `group`, and `mode`."), file: @resource.file, line: @resource.line)
       end
 
       value
-     end
+    end
   end
 end

data/lib/puppet/type/file/target.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Puppet
   Puppet::Type.type(:file).newproperty(:target) do
     desc "The target for creating a link.  Currently, symlinks are the
@@ -23,18 +25,18 @@ module Puppet
 
     # Anything else, basically
     newvalue(/./) do
-      @resource[:ensure] = :link if ! @resource.should(:ensure)
+      @resource[:ensure] = :link unless @resource.should(:ensure)
 
       # Only call mklink if ensure didn't call us in the first place.
-      currentensure  = @resource.property(:ensure).retrieve
+      currentensure = @resource.property(:ensure).retrieve
       mklink if @resource.property(:ensure).safe_insync?(currentensure)
     end
 
     # Create our link.
     def mklink
-      raise Puppet::Error, "Cannot symlink on this platform version" if !provider.feature?(:manages_symlinks)
+      raise Puppet::Error, "Cannot symlink on this platform version" unless provider.feature?(:manages_symlinks)
 
-      target = self.should
+      target = should
 
       # Clean up any existing objects.  The argument is just for logging,
       # it doesn't determine what's removed.
@@ -42,47 +44,43 @@ module Puppet
 
       raise Puppet::Error, "Could not remove existing file" if Puppet::FileSystem.exist?(@resource[:path])
 
-      Dir.chdir(File.dirname(@resource[:path])) do
-        Puppet::Util::SUIDManager.asuser(@resource.asuser) do
-          mode = @resource.should(:mode)
-          if mode
-            Puppet::Util.withumask(000) do
-              Puppet::FileSystem.symlink(target, @resource[:path])
-            end
-          else
+      Puppet::Util::SUIDManager.asuser(@resource.asuser) do
+        mode = @resource.should(:mode)
+        if mode
+          Puppet::Util.withumask(0o00) do
             Puppet::FileSystem.symlink(target, @resource[:path])
           end
+        else
+          Puppet::FileSystem.symlink(target, @resource[:path])
         end
+      end
 
-        @resource.send(:property_fix)
+      @resource.send(:property_fix)
 
-        :link_created
-      end
+      :link_created
     end
 
     def insync?(currentvalue)
-      if [:nochange, :notlink].include?(self.should) or @resource.recurse?
-        return true
-      elsif ! @resource.replace? and Puppet::FileSystem.exist?(@resource[:path])
-        return true
+      if [:nochange, :notlink].include?(should) or @resource.recurse?
+        true
+      elsif !@resource.replace? and Puppet::FileSystem.exist?(@resource[:path])
+        true
       else
-        return super(currentvalue)
+        super(currentvalue)
       end
     end
 
-
     def retrieve
       stat = @resource.stat
       if stat
         if stat.ftype == "link"
-          return Puppet::FileSystem.readlink(@resource[:path])
+          Puppet::FileSystem.readlink(@resource[:path])
         else
-          return :notlink
+          :notlink
         end
       else
-        return :absent
+        :absent
       end
     end
   end
 end
-

data/lib/puppet/type/file/type.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Puppet
   Puppet::Type.type(:file).newproperty(:type) do
     require 'etc'
@@ -12,9 +14,8 @@ module Puppet
       current_value
     end
 
-    validate do |val|
+    validate do |_val|
       fail "type is read-only"
     end
   end
 end
-