openvox 7.37.1 → 8.19.0

data/lib/puppet/pops/parser/locator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Puppet::Pops
 module Parser
 # Helper class that keeps track of where line breaks are located and can answer questions about positions.
@@ -57,6 +59,7 @@ class Locator
     last = first + ast.length
     ast._pcore_all_contents([]) do |m|
       next unless m.is_a?(Model::Positioned)
+
       m_offset = m.offset
       m_last = m_offset + m.length
       first = m_offset if m_offset < first
@@ -68,7 +71,7 @@ class Locator
   # Returns the line index - an array of line offsets for the start position of each line, starting at 0 for
   # the first line.
   #
-  def line_index()
+  def line_index
   end
 
   # Common byte based impl that works for all rubies (stringscanner is byte based
@@ -111,7 +114,7 @@ class Locator
 
     # Returns the position on line (first position on a line is 1)
     def pos_on_line(offset)
-      offset_on_line(offset) +1
+      offset_on_line(offset) + 1
     end
 
     def to_location_hash(reported_offset, end_offset)
@@ -119,7 +122,7 @@ class Locator
       offset     = char_offset(reported_offset)
       length     = char_length(reported_offset, end_offset)
       start_line = line_for_offset(reported_offset)
-      { :line => start_line, :pos => pos, :offset => offset, :length => length}
+      { :line => start_line, :pos => pos, :offset => offset, :length => length }
     end
 
     # Returns the index of the smallest item for which the item > the given value
@@ -138,28 +141,29 @@ class Locator
       satisfied = false
       v = nil
 
-      while low < high do
-          mid = low + ((high - low) / 2)
-          v = (ary[mid] > value)
-          if v == true
-            satisfied = true
-            smaller = true
-          elsif !v
-            smaller = false
-          else
-            raise TypeError, "wrong argument, must be boolean or nil, got '#{v.class}'"
-          end
-
-          if smaller
-            high = mid
-          else
-            low = mid + 1;
-          end
+      while low < high
+        mid = low + ((high - low) / 2)
+        v = (ary[mid] > value)
+        if v == true
+          satisfied = true
+          smaller = true
+        elsif !v
+          smaller = false
+        else
+          raise TypeError, "wrong argument, must be boolean or nil, got '#{v.class}'"
+        end
+
+        if smaller
+          high = mid
+        else
+          low = mid + 1;
+        end
       end
 
       return nil if low == ary.length
-      return nil if !satisfied
-      return low
+      return nil unless satisfied
+
+      low
     end
 
     def hash
@@ -177,6 +181,7 @@ class Locator
         # use cache
         return @prev_line
       end
+
       line_nbr = ary_bsearch_i(line_index, offset)
       if line_nbr
         # cache
@@ -187,7 +192,7 @@ class Locator
       # If not found it is after last
       # clear cache
       @prev_offset = @prev_line = nil
-      return line_index.size
+      line_index.size
     end
   end
 
@@ -235,7 +240,7 @@ class Locator
       # The last entry is duplicated since there will be  the line "after last line" that would otherwise require
       # conditional logic.
       #
-      @accumulated_margin = margin_per_line.reduce([0]) {|memo, val| memo << memo[-1] + val; memo }
+      @accumulated_margin = margin_per_line.each_with_object([0]) { |val, memo| memo << memo[-1] + val; }
       @accumulated_margin << @accumulated_margin[-1]
     end
 
@@ -245,7 +250,7 @@ class Locator
 
     # Returns array with transposed (local) offset and (local) length. The transposed values
     # take the margin into account such that it is added to the content to the right
-    # 
+    #
     # Using X to denote margin and where end of line is explicitly shown as \n:
     # ```
     # XXXXabc\n
@@ -263,13 +268,13 @@ class Locator
 
       # compute local start and end line
       start_line = line_for_offset(offset)
-      end_line = line_for_offset(offset+length)
+      end_line = line_for_offset(offset + length)
 
       # complex case when there is a margin
       transposed_offset = offset == 0 ? @leading_offset : offset + @leading_offset + @accumulated_margin[start_line]
       transposed_length = length +
-        @accumulated_margin[end_line] - @accumulated_margin[start_line] +    # the margins between start and end (0 is line 1)
-        (offset_on_line(offset) == 0 ? margin_per_line[start_line - 1] : 0)  # include start's margin in position 0
+                          @accumulated_margin[end_line] - @accumulated_margin[start_line] +    # the margins between start and end (0 is line 1)
+                          (offset_on_line(offset) == 0 ? margin_per_line[start_line - 1] : 0)  # include start's margin in position 0
       [transposed_offset, transposed_length]
     end
 
@@ -282,13 +287,11 @@ class Locator
     def char_length(offset, end_offset)
       raise "Should not be called"
     end
-
   end
 
   class LocatorForChars < AbstractLocator
-
     def offset_on_line(offset)
-      line_offset = line_index[ line_for_offset(offset)-1 ]
+      line_offset = line_index[line_for_offset(offset) - 1]
       offset - line_offset
     end
 
@@ -305,7 +308,6 @@ class Locator
     def extract_text(offset, length)
       string.slice(offset, length)
     end
-
   end
 
   # This implementation is for Ruby19 and Ruby20. It uses byteslice to get strings from byte based offsets.
@@ -315,24 +317,26 @@ class Locator
   class Locator19 < AbstractLocator
     include Types::PuppetObject
 
+    # rubocop:disable Naming/MemoizedInstanceVariableName
     def self._pcore_type
       @type ||= Types::PObjectType.new('Puppet::AST::Locator', {
-        'attributes' => {
-          'string' => Types::PStringType::DEFAULT,
-          'file' => Types::PStringType::DEFAULT,
-          'line_index' => {
-            Types::KEY_TYPE => Types::POptionalType.new(Types::PArrayType.new(Types::PIntegerType::DEFAULT)),
-            Types::KEY_VALUE => nil
-          }
-        }
-      })
+                                         'attributes' => {
+                                           'string' => Types::PStringType::DEFAULT,
+                                           'file' => Types::PStringType::DEFAULT,
+                                           'line_index' => {
+                                             Types::KEY_TYPE => Types::POptionalType.new(Types::PArrayType.new(Types::PIntegerType::DEFAULT)),
+                                             Types::KEY_VALUE => nil
+                                           }
+                                         }
+                                       })
     end
+    # rubocop:enable Naming/MemoizedInstanceVariableName
 
     # Returns the offset on line (first offset on a line is 0).
     # Ruby 19 is multibyte but has no character position methods, must use byteslice
     def offset_on_line(offset)
-      line_offset = line_index[ line_for_offset(offset)-1 ]
-      @string.byteslice(line_offset, offset-line_offset).length
+      line_offset = line_index[line_for_offset(offset) - 1]
+      @string.byteslice(line_offset, offset - line_offset).length
     end
 
     # Returns the character offset for a given byte offset

data/lib/puppet/pops/parser/parser_support.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../../puppet/parser/functions'
 require_relative '../../../puppet/parser/files'
 require_relative '../../../puppet/resource/type_collection'
@@ -27,6 +29,7 @@ class Parser
   # Returns the token text of the given lexer token, or nil, if token is nil
   def token_text t
     return t if t.nil?
+
     if t.is_a?(Factory) && t.model_class <= Model::QualifiedName
       t['value']
     elsif t.is_a?(Model::QualifiedName)
@@ -74,14 +77,14 @@ class Parser
   def parse_file(file)
     unless Puppet::FileSystem.exist?(file)
       unless file =~ /\.pp$/
-        file = file + ".pp"
+        file += ".pp"
       end
     end
     @lexer.file = file
     _parse
   end
 
-  def initialize()
+  def initialize
     @lexer = Lexer2.new
     @namestack = []
     @definitions = []
@@ -89,7 +92,7 @@ class Parser
 
   # This is a callback from the generated parser (when an error occurs while parsing)
   #
-  def on_error(token,value,stack)
+  def on_error(token, value, stack)
     if token == 0 # denotes end of file
       value_at = 'end of input'
     else
@@ -169,7 +172,7 @@ class Parser
     @namestack << name
   end
 
-  def namepop()
+  def namepop
     @namestack.pop
   end
 
@@ -190,16 +193,15 @@ class Parser
     # where the "10, notice" forms an argument list. The parser builds an Array with the expressions and includes
     # the comma tokens to enable the error to be reported against the first comma.
     #
-    begin
-      Factory.transform_calls(expressions)
-    rescue Factory::ArgsToNonCallError => e
-      # e.args[1] is the first comma token in the list
-      # e.name_expr is the function name expression
-      if e.name_expr.is_a?(Factory) && e.name_expr.model_class <= Model::QualifiedName
-        error(e.args[1], _("attempt to pass argument list to the function '%{name}' which cannot be called without parentheses") % { name: e.name_expr['value'] })
-      else
-        error(e.args[1], _("illegal comma separated argument list"))
-      end
+
+    Factory.transform_calls(expressions)
+  rescue Factory::ArgsToNonCallError => e
+    # e.args[1] is the first comma token in the list
+    # e.name_expr is the function name expression
+    if e.name_expr.is_a?(Factory) && e.name_expr.model_class <= Model::QualifiedName
+      error(e.args[1], _("attempt to pass argument list to the function '%{name}' which cannot be called without parentheses") % { name: e.name_expr['value'] })
+    else
+      error(e.args[1], _("illegal comma separated argument list"))
     end
   end
 
@@ -217,17 +219,16 @@ class Parser
 
   # Creates an empty program with a single No-op at the input's EOF offset with 0 length.
   #
-  def create_empty_program()
+  def create_empty_program
     locator = @lexer.locator
     no_op = Factory.literal(nil)
     # Create a synthetic NOOP token at EOF offset with 0 size. The lexer does not produce an EOF token that is
     # visible to the grammar rules. Creating this token is mainly to reuse the positioning logic as it
     # expects a token decorated with location information.
-    _, token = @lexer.emit_completed([:NOOP,'',0], locator.string.bytesize)
+    _, token = @lexer.emit_completed([:NOOP, '', 0], locator.string.bytesize)
     loc(no_op, token)
     # Program with a Noop
-    program = Factory.PROGRAM(no_op, [], locator)
-    program
+    Factory.PROGRAM(no_op, [], locator)
   end
 
   # Performs the parsing and returns the resulting model.
@@ -235,12 +236,12 @@ class Parser
   #
   # @api private
   #
-  def _parse()
+  def _parse
     begin
       @yydebug = false
-      main = yyparse(@lexer,:scan)
+      main = yyparse(@lexer, :scan)
     end
-    return main
+    main
   ensure
     @lexer.clear
     @namestack = []

data/lib/puppet/pops/parser/pn_parser.rb

@@ -1,10 +1,11 @@
+# frozen_string_literal: true
+
 module Puppet::Pops
 module Parser
-
 class PNParser
-  LIT_TRUE = 'true'.freeze
-  LIT_FALSE = 'false'.freeze
-  LIT_NIL = 'nil'.freeze
+  LIT_TRUE = 'true'
+  LIT_FALSE = 'false'
+  LIT_NIL = 'nil'
 
   TOKEN_END = 0
   TOKEN_BOOL = 1
@@ -139,7 +140,7 @@ class PNParser
     while @token != end_token && @token != TOKEN_END
       elements << parse_next
     end
-    parse_error(_("missing '%{token}' to end list") % { token: end_token.chr(Encoding::UTF_8) } ) unless @token == end_token
+    parse_error(_("missing '%{token}' to end list") % { token: end_token.chr(Encoding::UTF_8) }) unless @token == end_token
     next_token
     elements
   end
@@ -195,7 +196,7 @@ class PNParser
   end
 
   def consume_identifier(s)
-    while @char_types[peek_cp] >= TYPE_IDENTIFIER do
+    while @char_types[peek_cp] >= TYPE_IDENTIFIER
       @pos += 1
     end
     id = @text[s...@pos]
@@ -217,7 +218,7 @@ class PNParser
 
   def consume_string
     s = @pos
-    b = ''
+    b = ''.dup
     loop do
       c = next_cp
       case c
@@ -286,7 +287,7 @@ class PNParser
       c = peek_cp
     end
 
-    while @char_types[c] == TYPE_DIGIT do
+    while @char_types[c] == TYPE_DIGIT
       @pos += 1
       c = peek_cp
       count += 1
@@ -295,7 +296,7 @@ class PNParser
   end
 
   def skip_white
-    while @char_types[peek_cp] == TYPE_WS do
+    while @char_types[peek_cp] == TYPE_WS
       @pos += 1
     end
   end

data/lib/puppet/pops/parser/slurp_support.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Puppet::Pops
 module Parser
 # This module is an integral part of the Lexer.
@@ -12,15 +13,15 @@ module Parser
 module SlurpSupport
   include LexerSupport
 
-  SLURP_SQ_PATTERN  = /(?:[^\\]|^)(?:[\\]{2})*[']/
-  SLURP_DQ_PATTERN  = /(?:[^\\]|^)(?:[\\]{2})*(["]|[$]\{?)/
-  SLURP_UQ_PATTERN  = /(?:[^\\]|^)(?:[\\]{2})*([$]\{?|\z)/
+  SLURP_SQ_PATTERN  = /(?:[^\\]|^)(?:\\{2})*'/
+  SLURP_DQ_PATTERN  = /(?:[^\\]|^)(?:\\{2})*("|[$]\{?)/
+  SLURP_UQ_PATTERN  = /(?:[^\\]|^)(?:\\{2})*([$]\{?|\z)/
   # unquoted, no escapes
-  SLURP_UQNE_PATTERN  = /(\$\{?|\z)/m
+  SLURP_UQNE_PATTERN = /(\$\{?|\z)/m
   SLURP_ALL_PATTERN = /.*(\z)/m
-  SQ_ESCAPES = %w{ \\ ' }
-  DQ_ESCAPES = %w{ \\  $ ' " r n t s u}+["\r\n", "\n"]
-  UQ_ESCAPES = %w{ \\  $ r n t s u}+["\r\n", "\n"]
+  SQ_ESCAPES = %w[\\ ']
+  DQ_ESCAPES = %w[\\  $ ' " r n t s u] + ["\r\n", "\n"]
+  UQ_ESCAPES = %w[\\  $ r n t s u] + ["\r\n", "\n"]
 
   def slurp_sqstring
     # skip the leading '
@@ -43,20 +44,20 @@ module SlurpSupport
     [str[0..(-1 - terminator.length)], terminator]
   end
 
-   # Copy from old lexer - can do much better
-   def slurp_uqstring
-     scn = @scanner
-     str = slurp(scn, @lexing_context[:uq_slurp_pattern], @lexing_context[:escapes], :ignore_invalid_escapes)
+  # Copy from old lexer - can do much better
+  def slurp_uqstring
+    scn = @scanner
+    str = slurp(scn, @lexing_context[:uq_slurp_pattern], @lexing_context[:escapes], :ignore_invalid_escapes)
 
-     # Terminator may be a single char '$', two characters '${', or empty string '' at the end of intput.
-     # Group match 1 holds this.
-     # The exceptional case is found by looking at the subgroup 1 of the most recent match made by the scanner (i.e. @scanner[1]).
-     # This is the last match made by the slurp method (having called scan_until on the scanner).
-     # If there is a terminating character is must be stripped and returned separately.
-     #
-     terminator = scn[1]
-     [str[0..(-1 - terminator.length)], terminator]
-   end
+    # Terminator may be a single char '$', two characters '${', or empty string '' at the end of intput.
+    # Group match 1 holds this.
+    # The exceptional case is found by looking at the subgroup 1 of the most recent match made by the scanner (i.e. @scanner[1]).
+    # This is the last match made by the slurp method (having called scan_until on the scanner).
+    # If there is a terminating character is must be stripped and returned separately.
+    #
+    terminator = scn[1]
+    [str[0..(-1 - terminator.length)], terminator]
+  end
 
   # Slurps a string from the given scanner until the given pattern and then replaces any escaped
   # characters given by escapes into their control-character equivalent or in case of line breaks, replaces the
@@ -75,32 +76,32 @@ module SlurpSupport
     # If later a \u is found it is warned not to be a unicode escape
     if escapes.include?('u')
       # gsub must be repeated to cater for adjacent escapes
-      while(str.gsub!(/((?:[^\\]|^)(?:[\\]{2})*)\\u(?:([\da-fA-F]{4})|\{([\da-fA-F]{1,6})\})/m) { $1 + [($2 || $3).hex].pack("U") })
+      while str.gsub!(/((?:[^\\]|^)(?:\\{2})*)\\u(?:([\da-fA-F]{4})|\{([\da-fA-F]{1,6})\})/m) { ::Regexp.last_match(1) + [(::Regexp.last_match(2) || ::Regexp.last_match(3)).hex].pack("U") }
         # empty block. Everything happens in the gsub block
       end
     end
 
     begin
-    str.gsub!(/\\([^\r\n]|(?:\r?\n))/m) {
-      ch = $1
-      if escapes.include? ch
-        case ch
-        when 'r'   ; "\r"
-        when 'n'   ; "\n"
-        when 't'   ; "\t"
-        when 's'   ; ' '
-        when 'u'
-          lex_warning(Issues::ILLEGAL_UNICODE_ESCAPE)
-          "\\u"
-        when "\n"  ; ''
-        when "\r\n"; ''
-        else      ch
+      str.gsub!(/\\([^\r\n]|(?:\r?\n))/m) {
+        ch = ::Regexp.last_match(1)
+        if escapes.include? ch
+          case ch
+          when 'r'; "\r"
+          when 'n'; "\n"
+          when 't'; "\t"
+          when 's'; ' '
+          when 'u'
+            lex_warning(Issues::ILLEGAL_UNICODE_ESCAPE)
+            "\\u"
+          when "\n"; ''
+          when "\r\n"; ''
+          else ch
+          end
+        else
+          lex_warning(Issues::UNRECOGNIZED_ESCAPE, :ch => ch) unless ignore_invalid_escapes
+          "\\#{ch}"
         end
-      else
-        lex_warning(Issues::UNRECOGNIZED_ESCAPE, :ch => ch) unless ignore_invalid_escapes
-        "\\#{ch}"
-      end
-    }
+      }
     rescue ArgumentError => e
       # A invalid byte sequence may be the result of faulty input as well, but that could not possibly
       # have reached this far... Unfortunately there is no more specific error and a match on message is

data/lib/puppet/pops/patterns.rb

@@ -1,6 +1,7 @@
+# frozen_string_literal: true
+
 # The Patterns module contains common regular expression patters for the Puppet DSL language
 module Puppet::Pops::Patterns
-
   # NUMERIC matches hex, octal, decimal, and floating point and captures several parts
   # 0 = entire matched number, leading and trailing whitespace and sign included
   # 1 = sign, +, - or nothing
@@ -12,49 +13,48 @@ module Puppet::Pops::Patterns
   # Thus, a hex number has group 3 value, an octal value has group 4 (if it starts with 0), and no group 3
   # and a floating point value has group 4 and group 5.
   #
-  NUMERIC = %r{\A[[:blank:]]*([-+]?)[[:blank:]]*((0[xX][0-9A-Fa-f]+)|(0?\d+)((?:\.\d+)?(?:[eE]-?\d+)?))[[:blank:]]*\z}
+  NUMERIC = /\A[[:blank:]]*([-+]?)[[:blank:]]*((0[xX][0-9A-Fa-f]+)|(0?\d+)((?:\.\d+)?(?:[eE]-?\d+)?))[[:blank:]]*\z/
 
   # Special expression that tests if there is whitespace between sign and number. The expression is used
   # to strip such whitespace when normal Float or Integer conversion fails.
-  WS_BETWEEN_SIGN_AND_NUMBER = %r{\A([+-])[[:blank:]]+(.*)\z}
+  WS_BETWEEN_SIGN_AND_NUMBER = /\A([+-])[[:blank:]]+(.*)\z/
 
   # ILLEGAL_P3_1_HOSTNAME matches if a hostname contains illegal characters.
   # This check does not prevent pathological names like 'a....b', '.....', "---". etc.
-  ILLEGAL_HOSTNAME_CHARS = %r{[^-\w.]}
+  ILLEGAL_HOSTNAME_CHARS = /[^-\w.]/
 
   # NAME matches a name the same way as the lexer.
-  NAME = %r{\A((::)?[a-z]\w*)(::[a-z]\w*)*\z}
+  NAME = /\A((::)?[a-z]\w*)(::[a-z]\w*)*\z/
 
   # CLASSREF_EXT matches a class reference the same way as the lexer - i.e. the external source form
   # where each part must start with a capital letter A-Z.
   #
-  CLASSREF_EXT = %r{\A((::){0,1}[A-Z][\w]*)+\z}
+  CLASSREF_EXT = /\A((::){0,1}[A-Z]\w*)+\z/
 
   # Same as CLASSREF_EXT but cannot start with '::'
   #
-  CLASSREF_EXT_DECL = %r{\A[A-Z][\w]*(?:::[A-Z][\w]*)*\z}
+  CLASSREF_EXT_DECL = /\A[A-Z]\w*(?:::[A-Z]\w*)*\z/
 
   # CLASSREF matches a class reference the way it is represented internally in the
   # model (i.e. in lower case).
   #
-  CLASSREF = %r{\A((::){0,1}[a-z][\w]*)+\z}
+  CLASSREF = /\A((::){0,1}[a-z]\w*)+\z/
 
   # Same as CLASSREF but cannot start with '::'
   #
-  CLASSREF_DECL = %r{\A[a-z][\w]*(?:::[a-z][\w]*)*\z}
+  CLASSREF_DECL = /\A[a-z]\w*(?:::[a-z]\w*)*\z/
 
   # DOLLAR_VAR matches a variable name including the initial $ character
-  DOLLAR_VAR     = %r{\$(::)?(\w+::)*\w+}
+  DOLLAR_VAR = /\$(::)?(\w+::)*\w+/
 
   # VAR_NAME matches the name part of a variable (The $ character is not included)
   # Note, that only the final segment may start with an underscore.
   # Note, regexp sensitive to backtracking
-  VAR_NAME = %r{\A(?:::)?(?:[a-z]\w*::)*[a-z_]\w*\z}
+  VAR_NAME = /\A(?:::)?(?:[a-z]\w*::)*[a-z_]\w*\z/
 
   # PARAM_NAME matches the name part of a parameter (The $ character is not included)
-  PARAM_NAME = %r{\A[a-z_]\w*\z}
+  PARAM_NAME = /\A[a-z_]\w*\z/
 
   # A Numeric var name must be the decimal number 0, or a decimal number not starting with 0
-  NUMERIC_VAR_NAME = %r{\A(?:0|(?:[1-9][0-9]*))\z}
-
+  NUMERIC_VAR_NAME = /\A(?:0|(?:[1-9][0-9]*))\z/
 end

data/lib/puppet/pops/pcore.rb

@@ -1,21 +1,23 @@
+# frozen_string_literal: true
+
 require 'uri'
 
 module Puppet::Pops
 module Pcore
   include Types::PuppetObject
 
-  TYPE_URI_RX = Types::TypeFactory.regexp(URI.regexp)
+  TYPE_URI_RX = Types::TypeFactory.regexp(URI::DEFAULT_PARSER.make_regexp)
   TYPE_URI = Types::TypeFactory.pattern(TYPE_URI_RX)
   TYPE_URI_ALIAS = Types::PTypeAliasType.new('Pcore::URI', nil, TYPE_URI)
   TYPE_SIMPLE_TYPE_NAME = Types::TypeFactory.pattern(/\A[A-Z]\w*\z/)
-  TYPE_QUALIFIED_REFERENCE = Types::TypeFactory.pattern(/\A[A-Z][\w]*(?:::[A-Z][\w]*)*\z/)
+  TYPE_QUALIFIED_REFERENCE = Types::TypeFactory.pattern(/\A[A-Z]\w*(?:::[A-Z]\w*)*\z/)
   TYPE_MEMBER_NAME = Types::PPatternType.new([Types::PRegexpType.new(Patterns::PARAM_NAME)])
 
-  KEY_PCORE_URI = 'pcore_uri'.freeze
-  KEY_PCORE_VERSION = 'pcore_version'.freeze
+  KEY_PCORE_URI = 'pcore_uri'
+  KEY_PCORE_VERSION = 'pcore_version'
 
   PCORE_URI = 'http://puppet.com/2016.1/pcore'
-  PCORE_VERSION = SemanticPuppet::Version.new(1,0,0)
+  PCORE_VERSION = SemanticPuppet::Version.new(1, 0, 0)
   PARSABLE_PCORE_VERSIONS = SemanticPuppet::VersionRange.parse('1.x')
 
   RUNTIME_NAME_AUTHORITY = 'http://puppet.com/2016.1/runtime'
@@ -82,7 +84,6 @@ module Pcore
         }
       }
     PUPPET
-
   end
 
   # Create and register a new `Object` type in the Puppet Type System and map it to an implementation class

data/lib/puppet/pops/pn.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Puppet::Pops
 module PN
   KEY_PATTERN = /^[A-Za-z_-][0-9A-Za-z_-]*$/
@@ -19,7 +21,7 @@ module PN
   end
 
   def to_s
-    s = ''
+    s = ''.dup
     format(nil, s)
     s
   end
@@ -68,6 +70,7 @@ module PN
 
   class Indent
     attr_reader :current
+
     def initialize(indent = '  ', current = '')
       @indent = indent
       @current = current
@@ -113,12 +116,13 @@ module PN
     end
 
     def to_data
-      { '^' => [@name] + @elements.map { |e| e.to_data } }
+      { '^' => [@name] + @elements.map(&:to_data) }
     end
   end
 
   class Entry
     attr_reader :key, :value
+
     def initialize(key, value)
       @key = key
       @value = value
@@ -162,7 +166,7 @@ module PN
     end
 
     def to_data
-      @elements.map { |e| e.to_data }
+      @elements.map(&:to_data)
     end
   end
 
@@ -209,7 +213,7 @@ module PN
     def format(indent, b)
       local_indent = indent ? indent.increase : nil
       b << '{'
-      @entries.each_with_index do |e,i|
+      @entries.each_with_index do |e, i|
         if indent
           b << "\n" << local_indent.current
         elsif i > 0
@@ -233,4 +237,3 @@ end
 
 require_relative 'model/pn_transformer'
 require_relative 'parser/pn_parser'
-

data/lib/puppet/pops/puppet_stack.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../puppet/thread_local'
 
 module Puppet
@@ -30,7 +32,7 @@ module Puppet
       @stack = Puppet::ThreadLocal.new { Array.new }
 
       def self.stack(file, line, obj, message, args, &block)
-        file = 'unknown' if (file.nil? || file == '')
+        file = 'unknown' if file.nil? || file == ''
         line = 0 if line.nil?
 
         result = nil