openvox 7.37.1 → 8.19.0

data/lib/puppet/settings/base_setting.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'set'
 require_relative '../../puppet/settings/errors'
 
@@ -34,14 +36,15 @@ class Puppet::Settings::BaseSetting
   # @param value [Symbol] One of {HOOK_TYPES}
   def call_hook=(value)
     if value.nil?
-      #TRANSLATORS ':%{name}', ':call_hook', and ':on_write_only' should not be translated
+      # TRANSLATORS ':%{name}', ':call_hook', and ':on_write_only' should not be translated
       Puppet.warning _("Setting :%{name} :call_hook is nil, defaulting to :on_write_only") % { name: name }
       value = :on_write_only
     end
     unless HOOK_TYPES.include?(value)
-      #TRANSLATORS 'call_hook' is a Puppet option name and should not be translated
+      # TRANSLATORS 'call_hook' is a Puppet option name and should not be translated
       raise ArgumentError, _("Invalid option %{value} for call_hook") % { value: value }
     end
+
     @call_hook = value
   end
 
@@ -86,33 +89,33 @@ class Puppet::Settings::BaseSetting
   def initialize(args = {})
     @settings = args.delete(:settings)
     unless @settings
-      raise ArgumentError.new("You must refer to a settings object")
+      raise ArgumentError, "You must refer to a settings object"
     end
 
     # explicitly set name prior to calling other param= methods to provide meaningful feedback during
     # other warnings
     @name = args[:name] if args.include? :name
 
-    #set the default value for call_hook
-    @call_hook = :on_write_only if args[:hook] and not args[:call_hook]
+    # set the default value for call_hook
+    @call_hook = :on_write_only if args[:hook] and !(args[:call_hook])
     @has_hook = false
 
-    if args[:call_hook] and not args[:hook]
-      #TRANSLATORS ':call_hook' and ':hook' are specific setting names and should not be translated
+    if args[:call_hook] and !(args[:hook])
+      # TRANSLATORS ':call_hook' and ':hook' are specific setting names and should not be translated
       raise ArgumentError, _("Cannot reference :call_hook for :%{name} if no :hook is defined") % { name: @name }
     end
 
     args.each do |param, value|
       method = param.to_s + "="
-      unless self.respond_to? method
+      unless respond_to? method
         raise ArgumentError, _("%{class_name} (setting '%{setting}') does not accept %{parameter}") %
-            { class_name: self.class, setting: args[:name], parameter: param }
+                             { class_name: self.class, setting: args[:name], parameter: param }
       end
 
-      self.send(method, value)
+      send(method, value)
     end
-    unless self.desc
-      raise ArgumentError, _("You must provide a description for the %{class_name} config option") % { class_name: self.name }
+    unless desc
+      raise ArgumentError, _("You must provide a description for the %{class_name} config option") % { class_name: name }
     end
   end
 
@@ -127,6 +130,7 @@ class Puppet::Settings::BaseSetting
   # short name for the element
   def short=(value)
     raise ArgumentError, _("Short names can only be one character.") if value.to_s.length != 1
+
     @short = value.to_s
   end
 
@@ -141,7 +145,8 @@ class Puppet::Settings::BaseSetting
       default_value = @default
     end
     return default_value unless check_application_defaults_first
-    return @settings.value(name, :application_defaults, true) || default_value
+
+    @settings.value(name, :application_defaults, true) || default_value
   end
 
   # Convert the object to a config statement.
@@ -156,7 +161,7 @@ class Puppet::Settings::BaseSetting
     # If the value has not been overridden, then print it out commented
     # and unconverted, so it's clear that that's the default and how it
     # works.
-    value = @settings.value(self.name)
+    value = @settings.value(name)
 
     if value != @default
       line = "#{@name} = #{value}"
@@ -175,7 +180,7 @@ class Puppet::Settings::BaseSetting
   # @return [String] Retrieves the value, or if it's not set, retrieves the default.
   # @api public
   def value(bypass_interpolation = false)
-    @settings.value(self.name, nil, bypass_interpolation)
+    @settings.value(name, nil, bypass_interpolation)
   end
 
   # Modify the value when it is first evaluated
@@ -194,9 +199,9 @@ class Puppet::Settings::BaseSetting
 
   def deprecated=(deprecation)
     unless [:completely, :allowed_on_commandline].include?(deprecation)
-      #TRANSLATORS 'deprecated' is a Puppet setting and ':completely' and ':allowed_on_commandline' are possible values and should not be translated
+      # TRANSLATORS 'deprecated' is a Puppet setting and ':completely' and ':allowed_on_commandline' are possible values and should not be translated
       raise ArgumentError, _("Unsupported deprecated value '%{deprecation}'.") % { deprecation: deprecation } +
-          ' ' + _("Supported values for deprecated are ':completely' or ':allowed_on_commandline'")
+                           ' ' + _("Supported values for deprecated are ':completely' or ':allowed_on_commandline'")
     end
     @deprecated = deprecation
   end
@@ -218,6 +223,6 @@ class Puppet::Settings::BaseSetting
   end
 
   def inspect
-    %Q{<#{self.class}:#{self.object_id} @name="#{@name}" @section="#{@section}" @default="#{@default}" @call_hook="#{@call_hook}">}
+    %Q(<#{self.class}:#{object_id} @name="#{@name}" @section="#{@section}" @default="#{@default}" @call_hook="#{@call_hook}">)
   end
 end

data/lib/puppet/settings/boolean_setting.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # A simple boolean.
 class Puppet::Settings::BooleanSetting < Puppet::Settings::BaseSetting
   # get the arguments in getopt format
@@ -11,7 +13,7 @@ class Puppet::Settings::BooleanSetting < Puppet::Settings::BaseSetting
 
   def optparse_args
     if short
-      ["--[no-]#{name}", "-#{short}", desc, :NONE ]
+      ["--[no-]#{name}", "-#{short}", desc, :NONE]
     else
       ["--[no-]#{name}", desc, :NONE]
     end
@@ -19,8 +21,8 @@ class Puppet::Settings::BooleanSetting < Puppet::Settings::BaseSetting
 
   def munge(value)
     case value
-    when true, "true"; return true
-    when false, "false"; return false
+    when true, "true"; true
+    when false, "false"; false
     else
       raise Puppet::Settings::ValidationError, _("Invalid value '%{value}' for boolean parameter: %{name}") % { value: value.inspect, name: @name }
     end

data/lib/puppet/settings/certificate_revocation_setting.rb

@@ -1,7 +1,8 @@
+# frozen_string_literal: true
+
 require_relative '../../puppet/settings/base_setting'
 
 class Puppet::Settings::CertificateRevocationSetting < Puppet::Settings::BaseSetting
-
   def type
     :certificate_revocation
   end

data/lib/puppet/settings/config_file.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../puppet/settings/ini_file'
 
 ##
@@ -6,7 +8,6 @@ require_relative '../../puppet/settings/ini_file'
 # Parses puppet configuration files
 #
 class Puppet::Settings::ConfigFile
-
   ##
   # @param value_converter [Proc] a function that will convert strings into ruby types
   def initialize(value_converter)
@@ -21,7 +22,7 @@ class Puppet::Settings::ConfigFile
   # @return A Struct with a +sections+ array representing each configuration section
   def parse_file(file, text, allowed_section_names = [])
     result = Conf.new
-    if !allowed_section_names.empty?
+    unless allowed_section_names.empty?
       allowed_section_names << 'main' unless allowed_section_names.include?('main')
     end
 
@@ -77,17 +78,17 @@ class Puppet::Settings::ConfigFile
   Meta = Struct.new(:owner, :group, :mode)
   NO_META = Meta.new(nil, nil, nil)
 
-private
+  private
 
   def unique_sections_in(ini, file, allowed_section_names)
     ini.section_lines.collect do |section|
       if !allowed_section_names.empty? && !allowed_section_names.include?(section.name)
         error_location_str = Puppet::Util::Errors.error_location(file, section.line_number)
         message = _("Illegal section '%{name}' in config file at %{error_location}.") %
-            { name: section.name, error_location: error_location_str }
-        #TRANSLATORS 'puppet.conf' is the name of the puppet configuration file and should not be translated.
+                  { name: section.name, error_location: error_location_str }
+        # TRANSLATORS 'puppet.conf' is the name of the puppet configuration file and should not be translated.
         message += ' ' + _("The only valid puppet.conf sections are: [%{allowed_sections_list}].") %
-            { allowed_sections_list: allowed_section_names.join(", ") }
+                         { allowed_sections_list: allowed_section_names.join(", ") }
         message += ' ' + _("Please use the directory environments feature to specify environments.")
         message += ' ' + _("(See https://puppet.com/docs/puppet/latest/environments_about.html)")
         raise(Puppet::Error, message)
@@ -122,10 +123,11 @@ private
   def extract_fileinfo(string)
     result = {}
     value = string.sub(/\{\s*([^}]+)\s*\}/) do
-      params = $1
+      params = ::Regexp.last_match(1)
       params.split(/\s*,\s*/).each do |str|
-        if str =~ /^\s*(\w+)\s*=\s*([\w]+)\s*$/
-          param, value = $1.intern, $2
+        if str =~ /^\s*(\w+)\s*=\s*(\w+)\s*$/
+          param = ::Regexp.last_match(1).intern
+          value = ::Regexp.last_match(2)
           result[param] = value
           unless [:owner, :mode, :group].include?(param)
             raise ArgumentError, _("Invalid file option '%{parameter}'") % { parameter: param }

data/lib/puppet/settings/directory_setting.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Puppet::Settings::DirectorySetting < Puppet::Settings::FileSetting
   def type
     :directory

data/lib/puppet/settings/duration_setting.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # A setting that represents a span of time, and evaluates to an integer
 # number of seconds after being parsed
 class Puppet::Settings::DurationSetting < Puppet::Settings::BaseSetting
@@ -20,11 +22,10 @@ class Puppet::Settings::DurationSetting < Puppet::Settings::BaseSetting
 
   # Convert the value to an integer, parsing numeric string with units if necessary.
   def munge(value)
-    case
-    when value.is_a?(Integer) || value.nil?
+    if value.is_a?(Integer) || value.nil?
       value
-    when (value.is_a?(String) and value =~ FORMAT)
-      $1.to_i * UNITMAP[$2 || 's']
+    elsif value.is_a?(String) and value =~ FORMAT
+      ::Regexp.last_match(1).to_i * UNITMAP[::Regexp.last_match(2) || 's']
     else
       raise Puppet::Settings::ValidationError, _("Invalid duration format '%{value}' for parameter: %{name}") % { value: value.inspect, name: @name }
     end

data/lib/puppet/settings/enum_setting.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Puppet::Settings::EnumSetting < Puppet::Settings::BaseSetting
   attr_accessor :values
 
@@ -10,7 +12,7 @@ class Puppet::Settings::EnumSetting < Puppet::Settings::BaseSetting
       value
     else
       raise Puppet::Settings::ValidationError,
-        _("Invalid value '%{value}' for parameter %{name}. Allowed values are '%{allowed_values}'") % { value: value, name: @name, allowed_values: values.join("', '") }
+            _("Invalid value '%{value}' for parameter %{name}. Allowed values are '%{allowed_values}'") % { value: value, name: @name, allowed_values: values.join("', '") }
     end
   end
 end

data/lib/puppet/settings/environment_conf.rb

@@ -1,7 +1,8 @@
+# frozen_string_literal: true
+
 # Configuration settings for a single directory Environment.
 # @api private
 class Puppet::Settings::EnvironmentConf
-
   ENVIRONMENT_CONF_ONLY_SETTINGS = [:modulepath, :manifest, :config_version].freeze
   VALID_SETTINGS = (ENVIRONMENT_CONF_ONLY_SETTINGS + [:environment_timeout, :environment_data_provider, :static_catalogs, :rich_data]).freeze
 
@@ -57,18 +58,18 @@ class Puppet::Settings::EnvironmentConf
     disable_per_environment_manifest = Puppet.settings.value(:disable_per_environment_manifest)
 
     fallback_manifest_directory =
-    if puppet_conf_manifest.absolute?
-      puppet_conf_manifest.to_s
-    else
-      File.join(@path_to_env, puppet_conf_manifest.to_s)
-    end
+      if puppet_conf_manifest.absolute?
+        puppet_conf_manifest.to_s
+      else
+        File.join(@path_to_env, puppet_conf_manifest.to_s)
+      end
 
     if disable_per_environment_manifest
       environment_conf_manifest = absolute(raw_setting(:manifest))
       if environment_conf_manifest && fallback_manifest_directory != environment_conf_manifest
-        #TRANSLATORS 'disable_per_environment_manifest' is a setting and 'environment.conf' is a file name and should not be translated
+        # TRANSLATORS 'disable_per_environment_manifest' is a setting and 'environment.conf' is a file name and should not be translated
         message = _("The 'disable_per_environment_manifest' setting is true, but the environment located at %{path_to_env} has a manifest setting in its environment.conf of '%{environment_conf}' which does not match the default_manifest setting '%{puppet_conf}'.") %
-            { path_to_env: @path_to_env, environment_conf: environment_conf_manifest, puppet_conf: puppet_conf_manifest }
+                  { path_to_env: @path_to_env, environment_conf: environment_conf_manifest, puppet_conf: puppet_conf_manifest }
         message += ' ' + _("If this environment is expecting to find modules in '%{environment_conf}', they will not be available!") % { environment_conf: environment_conf_manifest }
         Puppet.err(message)
       end
@@ -99,7 +100,7 @@ class Puppet::Settings::EnvironmentConf
   def modulepath
     default_modulepath = [File.join(@path_to_env, "modules")] + @global_module_path
     get_setting(:modulepath, default_modulepath) do |modulepath|
-      path = modulepath.kind_of?(String) ?
+      path = modulepath.is_a?(String) ?
         modulepath.split(File::PATH_SEPARATOR) :
         modulepath
       path.map { |p| expand_glob(absolute(p)) }.flatten.join(File::PATH_SEPARATOR)
@@ -142,23 +143,25 @@ class Puppet::Settings::EnvironmentConf
         _("Invalid sections in environment.conf at '%{path_to_conf_file}'. Environment conf may not have sections. The following sections are being ignored: '%{sections}'") % {
           path_to_conf_file: path_to_conf_file,
           sections: (section_keys - [:main]).join(',')
-        })
+        }
+      )
       valid = false
     end
 
     extraneous_settings = main.settings.map(&:name) - VALID_SETTINGS
-    if !extraneous_settings.empty?
+    unless extraneous_settings.empty?
       # warn once per config file path
       Puppet.warn_once(
         :invalid_settings, "EnvironmentConf-settings:#{path_to_conf_file}",
         _("Invalid settings in environment.conf at '%{path_to_conf_file}'. The following unknown setting(s) are being ignored: %{ignored_settings}") % {
           path_to_conf_file: path_to_conf_file,
           ignored_settings: extraneous_settings.join(', ')
-        })
+        }
+      )
       valid = false
     end
 
-    return valid
+    valid
   end
   private_class_method :validate
 
@@ -170,7 +173,8 @@ class Puppet::Settings::EnvironmentConf
 
   def expand_glob(path)
     return nil if path.nil?
-    if path =~ /[*?\[\{]/
+
+    if path =~ /[*?\[{]/
       Dir.glob(path)
     else
       path
@@ -179,6 +183,7 @@ class Puppet::Settings::EnvironmentConf
 
   def absolute(path)
     return nil if path.nil?
+
     if path =~ /^\$/
       # Path begins with $something interpolatable
       path
@@ -220,5 +225,4 @@ class Puppet::Settings::EnvironmentConf
       @environment.config_version
     end
   end
-
 end

data/lib/puppet/settings/errors.rb

@@ -1,10 +1,13 @@
+# frozen_string_literal: true
+
 # Exceptions for the settings module
 require_relative '../../puppet/error'
 
 class Puppet::Settings
-  class SettingsError < Puppet::Error ; end
-  class ValidationError < SettingsError ; end
-  class InterpolationError < SettingsError ; end
+  class SettingsError < Puppet::Error; end
+  class ValidationError < SettingsError; end
+  class InterpolationError < SettingsError; end
+
   class ParseError < SettingsError
     include Puppet::ExternalFileError
   end

data/lib/puppet/settings/file_or_directory_setting.rb

@@ -1,11 +1,8 @@
-class Puppet::Settings::FileOrDirectorySetting < Puppet::Settings::FileSetting
-
-  def initialize(args)
-    super
-  end
+# frozen_string_literal: true
 
+class Puppet::Settings::FileOrDirectorySetting < Puppet::Settings::FileSetting
   def type
-    if Puppet::FileSystem.directory?(self.value) || @path_ends_with_slash
+    if Puppet::FileSystem.directory?(value) || @path_ends_with_slash
       :directory
     else
       :file
@@ -15,7 +12,7 @@ class Puppet::Settings::FileOrDirectorySetting < Puppet::Settings::FileSetting
   # Overrides munge to be able to read the un-munged value (the FileSetting.munch removes trailing slash)
   #
   def munge(value)
-    if value.is_a?(String) && value =~ /[\\\/]$/
+    if value.is_a?(String) && value =~ %r{[\\/]$}
       @path_ends_with_slash = true
     end
     super

data/lib/puppet/settings/file_setting.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # A file.
 class Puppet::Settings::FileSetting < Puppet::Settings::StringSetting
   class SettingError < StandardError; end
@@ -47,7 +49,8 @@ class Puppet::Settings::FileSetting < Puppet::Settings::StringSetting
       end
     end
 
-  private
+    private
+
     def safe_to_use_settings_value?
       @settings[:mkusers] or @settings.send(@available_method)
     end
@@ -123,7 +126,7 @@ class Puppet::Settings::FileSetting < Puppet::Settings::StringSetting
     type = self.type
     return nil unless type
 
-    path = self.value
+    path = value
 
     return nil unless path.is_a?(String)
 
@@ -131,12 +134,12 @@ class Puppet::Settings::FileSetting < Puppet::Settings::StringSetting
     path = File.expand_path(path)
 
     return nil unless type == :directory || Puppet::FileSystem.exist?(path)
-    return nil if path =~ /^\/dev/ || path =~ /^[A-Z]:\/dev/i
+    return nil if path =~ %r{^/dev} || path =~ %r{^[A-Z]:/dev}i
 
     resource = Puppet::Resource.new(:file, path)
 
     if Puppet[:manage_internal_file_permissions]
-      if self.mode
+      if mode
         # This ends up mimicking the munge method of the mode
         # parameter to make sure that we're always passing the string
         # version of the octal number.  If we were setting the
@@ -153,8 +156,8 @@ class Puppet::Settings::FileSetting < Puppet::Settings::StringSetting
 
       # REMIND fails on Windows because chown/chgrp functionality not supported yet
       if Puppet.features.root? and !Puppet::Util::Platform.windows?
-        resource[:owner] = self.owner if self.owner
-        resource[:group] = self.group if self.group
+        resource[:owner] = owner if owner
+        resource[:group] = group if group
       end
     end
 
@@ -163,23 +166,11 @@ class Puppet::Settings::FileSetting < Puppet::Settings::StringSetting
     resource[:links] = :follow
     resource[:backup] = false
 
-    resource.tag(self.section, self.name, "settings")
+    resource.tag(section, name, "settings")
 
     resource
   end
 
-  # Make sure any provided variables look up to something.
-  def validate(value)
-    return true unless value.is_a? String
-    value.scan(/\$(\w+)/) { |name|
-      name = $1
-      unless @settings.include?(name)
-        raise ArgumentError,
-          _("Settings parameter '%{name}' is undefined") % { name: name }
-      end
-    }
-  end
-
   # @api private
   # @param option [String] Extra file operation mode information to use
   #   (defaults to read-only mode 'r')
@@ -224,14 +215,14 @@ class Puppet::Settings::FileSetting < Puppet::Settings::StringSetting
 
     Puppet::Util::SUIDManager.asuser(*chown) do
       # Update the umask to make non-executable files
-      Puppet::Util.withumask(File.umask ^ 0111) do
-        yielded_value = case self.mode
+      Puppet::Util.withumask(File.umask ^ 0o111) do
+        yielded_value = case mode
                         when String
-                          self.mode.to_i(8)
+                          mode.to_i(8)
                         when NilClass
-                          0640
+                          0o640
                         else
-                          self.mode
+                          mode
                         end
 
         yield yielded_value

data/lib/puppet/settings/http_extra_headers_setting.rb

@@ -1,5 +1,6 @@
-class Puppet::Settings::HttpExtraHeadersSetting < Puppet::Settings::BaseSetting
+# frozen_string_literal: true
 
+class Puppet::Settings::HttpExtraHeadersSetting < Puppet::Settings::BaseSetting
   def type
     :http_extra_headers
   end

data/lib/puppet/settings/ini_file.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # @api private
 class Puppet::Settings::IniFile
   DEFAULT_SECTION_NAME = "main"
@@ -14,9 +16,9 @@ class Puppet::Settings::IniFile
     config_fh.each_line do |line|
       case line.chomp
       when /^(\s*)\[([[:word:]]+)\](\s*)$/
-        config.append(SectionLine.new($1, $2, $3))
+        config.append(SectionLine.new(::Regexp.last_match(1), ::Regexp.last_match(2), ::Regexp.last_match(3)))
       when /^(\s*)([[:word:]]+)(\s*=\s*)(.*?)(\s*)$/
-        config.append(SettingLine.new($1, $2, $3, $4, $5))
+        config.append(SettingLine.new(::Regexp.last_match(1), ::Regexp.last_match(2), ::Regexp.last_match(3), ::Regexp.last_match(4), ::Regexp.last_match(5)))
       else
         config.append(Line.new(line))
       end
@@ -193,7 +195,7 @@ class Puppet::Settings::IniFile
     end
 
     def ==(other)
-      super(other) && self.line_number == other.line_number
+      super(other) && line_number == other.line_number
     end
   end
 

data/lib/puppet/settings/integer_setting.rb

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 class Puppet::Settings::IntegerSetting < Puppet::Settings::BaseSetting
   def munge(value)
-    return value if Integer === value
+    return value if value.is_a?(Integer)
 
     begin
       value = Integer(value)

data/lib/puppet/settings/path_setting.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Puppet::Settings::PathSetting < Puppet::Settings::StringSetting
   def munge(value)
     if value.is_a?(String)

data/lib/puppet/settings/port_setting.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 class Puppet::Settings::PortSetting < Puppet::Settings::IntegerSetting
   def munge(value)
-    value = super
+    value = super(value)
 
-    if value < 0 || value > 65535
+    if value < 0 || value > 65_535
       raise Puppet::Settings::ValidationError, _("Value '%{value}' is not a valid port number for parameter: %{name}") % { value: value.inspect, name: @name }
     end
 

data/lib/puppet/settings/priority_setting.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../puppet/settings/base_setting'
 
 # A setting that represents a scheduling priority, and evaluates to an
@@ -8,17 +10,17 @@ class Puppet::Settings::PrioritySetting < Puppet::Settings::BaseSetting
       require_relative '../../puppet/util/windows/process'
       require_relative '../../puppet/ffi/windows/constants'
       {
-        :high    => Puppet::FFI::Windows::Constants::HIGH_PRIORITY_CLASS,
-        :normal  => Puppet::FFI::Windows::Constants::NORMAL_PRIORITY_CLASS,
-        :low     => Puppet::FFI::Windows::Constants::BELOW_NORMAL_PRIORITY_CLASS,
-        :idle    => Puppet::FFI::Windows::Constants::IDLE_PRIORITY_CLASS
+        :high => Puppet::FFI::Windows::Constants::HIGH_PRIORITY_CLASS,
+        :normal => Puppet::FFI::Windows::Constants::NORMAL_PRIORITY_CLASS,
+        :low => Puppet::FFI::Windows::Constants::BELOW_NORMAL_PRIORITY_CLASS,
+        :idle => Puppet::FFI::Windows::Constants::IDLE_PRIORITY_CLASS
       }
     else
       {
-        :high    => -10,
-        :normal  => 0,
-        :low     => 10,
-        :idle    => 19
+        :high => -10,
+        :normal => 0,
+        :low => 10,
+        :idle => 19
       }
     end
 
@@ -29,12 +31,11 @@ class Puppet::Settings::PrioritySetting < Puppet::Settings::BaseSetting
   def munge(value)
     return unless value
 
-    case
-    when value.is_a?(Integer)
+    if value.is_a?(Integer)
       value
-    when (value.is_a?(String) and value =~ /\d+/)
+    elsif value.is_a?(String) and value =~ /\d+/
       value.to_i
-    when (value.is_a?(String) and PRIORITY_MAP[value.to_sym])
+    elsif value.is_a?(String) and PRIORITY_MAP[value.to_sym]
       PRIORITY_MAP[value.to_sym]
     else
       raise Puppet::Settings::ValidationError, _("Invalid priority format '%{value}' for parameter: %{name}") % { value: value.inspect, name: @name }

data/lib/puppet/settings/server_list_setting.rb

@@ -1,21 +1,22 @@
-class Puppet::Settings::ServerListSetting < Puppet::Settings::ArraySetting
+# frozen_string_literal: true
 
+class Puppet::Settings::ServerListSetting < Puppet::Settings::ArraySetting
   def type
     :server_list
   end
 
   def print(value)
     if value.is_a?(Array)
-      #turn into a string
-      value.map {|item| item.join(":") }.join(",")
+      # turn into a string
+      value.map { |item| item.join(":") }.join(",")
     else
       value
     end
   end
-  
+
   def munge(value)
-    servers = super 
-    servers.map! { |server| 
+    servers = super
+    servers.map! { |server|
       case server
       when String
         server.split(':')

data/lib/puppet/settings/string_setting.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Puppet::Settings::StringSetting < Puppet::Settings::BaseSetting
   def type
     :string