openvox 7.37.1 → 8.19.0

data/lib/puppet/file_bucket/file.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../puppet/file_bucket'
 require_relative '../../puppet/indirector'
 require_relative '../../puppet/util/checksums'
@@ -11,7 +13,7 @@ class Puppet::FileBucket::File
   extend Puppet::Indirector
   indirects :file_bucket_file, :terminus_class => :selector
 
-  attr :bucket_path
+  attr_reader :bucket_path
 
   def self.supported_formats
     [:binary]
@@ -24,12 +26,12 @@ class Puppet::FileBucket::File
     when Pathname
       @contents = FileContents.new(contents)
     else
-      raise ArgumentError.new(_("contents must be a String or Pathname, got a %{contents_class}") % { contents_class: contents.class })
+      raise ArgumentError, _("contents must be a String or Pathname, got a %{contents_class}") % { contents_class: contents.class }
     end
 
     @bucket_path = options.delete(:bucket_path)
     @checksum_type = Puppet[:digest_algorithm].to_sym
-    raise ArgumentError.new(_("Unknown option(s): %{opts}") % { opts: options.keys.join(', ') }) unless options.empty?
+    raise ArgumentError, _("Unknown option(s): %{opts}") % { opts: options.keys.join(', ') } unless options.empty?
   end
 
   # @return [Num] The size of the contents
@@ -71,7 +73,7 @@ class Puppet::FileBucket::File
   end
 
   def self.from_binary(contents)
-    self.new(contents)
+    new(contents)
   end
 
   class StringContents
@@ -100,7 +102,7 @@ class Puppet::FileBucket::File
     def to_binary
       # This is not so horrible as for FileContent, but still possible to mutate the content that the
       # checksum is based on... so semi horrible...
-      return @contents;
+      @contents;
     end
   end
 
@@ -123,7 +125,7 @@ class Puppet::FileBucket::File
     end
 
     def to_binary
-      Puppet::FileSystem::binread(@path)
+      Puppet::FileSystem.binread(@path)
     end
   end
 end

data/lib/puppet/file_bucket.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # stub
 module Puppet::FileBucket
   class BucketError < RuntimeError; end

data/lib/puppet/file_serving/base.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../puppet/file_serving'
 require_relative '../../puppet/util'
 
@@ -10,10 +12,10 @@ class Puppet::FileServing::Base
 
   # Does our file exist?
   def exist?
-      stat
-      return true
+    stat
+    true
   rescue
-      return false
+    false
   end
 
   # Return the full path to our file.  Fails if there's no path set.
@@ -43,40 +45,46 @@ class Puppet::FileServing::Base
 
   # Determine how we deal with links.
   attr_reader :links
+
   def links=(value)
     value = value.to_sym
     value = :manage if value == :ignore
-    #TRANSLATORS ':link', ':manage', ':follow' should not be translated
+    # TRANSLATORS ':link', ':manage', ':follow' should not be translated
     raise(ArgumentError, _(":links can only be set to :manage or :follow")) unless [:manage, :follow].include?(value)
+
     @links = value
   end
 
   # Set our base path.
   attr_reader :path
+
   def path=(path)
-    raise ArgumentError.new(_("Paths must be fully qualified")) unless Puppet::FileServing::Base.absolute?(path)
+    raise ArgumentError, _("Paths must be fully qualified") unless Puppet::FileServing::Base.absolute?(path)
+
     @path = path
   end
 
   # Set a relative path; this is used for recursion, and sets
   # the file's path relative to the initial recursion point.
   attr_reader :relative_path
+
   def relative_path=(path)
-    raise ArgumentError.new(_("Relative paths must not be fully qualified")) if Puppet::FileServing::Base.absolute?(path)
+    raise ArgumentError, _("Relative paths must not be fully qualified") if Puppet::FileServing::Base.absolute?(path)
+
     @relative_path = path
   end
 
   # Stat our file, using the appropriate link-sensitive method.
   def stat
-    @stat_method ||= self.links == :manage ? :lstat : :stat
+    @stat_method ||= links == :manage ? :lstat : :stat
     Puppet::FileSystem.send(@stat_method, full_path)
   end
 
   def to_data_hash
     {
-      'path'          => @path,
+      'path' => @path,
       'relative_path' => @relative_path,
-      'links'         => @links.to_s
+      'links' => @links.to_s
     }
   end
 

data/lib/puppet/file_serving/configuration/parser.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../../puppet/file_serving/configuration'
 require_relative '../../../puppet/util/watched_file'
 
@@ -23,12 +25,13 @@ class Puppet::FileServing::Configuration::Parser
         when /^\s*#/; next # skip comments
         when /^\s*$/; next # skip blank lines
         when /\[([-\w]+)\]/
-          mount = newmount($1)
+          mount = newmount(::Regexp.last_match(1))
         when /^\s*(\w+)\s+(.+?)(\s*#.*)?$/
-          var = $1
-          value = $2
+          var = ::Regexp.last_match(1)
+          value = ::Regexp.last_match(2)
           value.strip!
           raise(ArgumentError, _("Fileserver configuration file does not use '=' as a separator")) if value =~ /^=/
+
           case var
           when "path"
             path(mount, value)
@@ -40,13 +43,13 @@ class Puppet::FileServing::Configuration::Parser
             end
           else
             error_location_str = Puppet::Util::Errors.error_location(@file.filename, @count)
-            raise ArgumentError.new(_("Invalid argument '%{var}' at %{error_location}") %
-                                        { var: var, error_location: error_location_str })
+            raise ArgumentError, _("Invalid argument '%{var}' at %{error_location}") %
+                                 { var: var, error_location: error_location_str }
           end
         else
           error_location_str = Puppet::Util::Errors.error_location(@file.filename, @count)
-          raise ArgumentError.new(_("Invalid entry at %{error_location}: '%{file_text}'") %
-                                      { file_text: line.chomp, error_location: error_location_str })
+          raise ArgumentError, _("Invalid entry at %{error_location}: '%{file_text}'") %
+                               { file_text: line.chomp, error_location: error_location_str }
         end
       end
     end
@@ -70,8 +73,8 @@ class Puppet::FileServing::Configuration::Parser
   def newmount(name)
     if @mounts.include?(name)
       error_location_str = Puppet::Util::Errors.error_location(@file, @count)
-      raise ArgumentError.new(_("%{mount} is already mounted at %{name} at %{error_location}") %
-                                  { mount: @mounts[name], name: name, error_location: error_location_str })
+      raise ArgumentError, _("%{mount} is already mounted at %{name} at %{error_location}") %
+                           { mount: @mounts[name], name: name, error_location: error_location_str }
     end
     case name
     when "modules"
@@ -108,6 +111,6 @@ class Puppet::FileServing::Configuration::Parser
   # Make sure all of our mounts are valid.  We have to do this after the fact
   # because details are added over time as the file is parsed.
   def validate
-    @mounts.each { |name, mount| mount.validate }
+    @mounts.each { |_name, mount| mount.validate }
   end
 end

data/lib/puppet/file_serving/configuration.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../puppet'
 require_relative '../../puppet/file_serving'
 require_relative '../../puppet/file_serving/mount'
@@ -18,10 +20,11 @@ class Puppet::FileServing::Configuration
 
   Mount = Puppet::FileServing::Mount
 
-  private_class_method  :new
+  private_class_method :new
 
   attr_reader :mounts
-  #private :mounts
+
+  # private :mounts
 
   # Find the right mount.  Does some shenanigans to support old-style module
   # mounts.
@@ -53,11 +56,12 @@ class Puppet::FileServing::Configuration
 
     mount_name, path = request.key.split(File::Separator, 2)
 
-    raise(ArgumentError, _("Cannot find file: Invalid mount '%{mount_name}'") % { mount_name: mount_name }) unless mount_name =~ %r{^[-\w]+$}
+    raise(ArgumentError, _("Cannot find file: Invalid mount '%{mount_name}'") % { mount_name: mount_name }) unless mount_name =~ /^[-\w]+$/
     raise(ArgumentError, _("Cannot find file: Invalid relative path '%{path}'") % { path: path }) if path and path.split('/').include?('..')
 
     mount = find_mount(mount_name, request.environment)
     return nil unless mount
+
     if mount.name == "modules" and mount_name != "modules"
       # yay backward-compatibility
       path = "#{mount_name}/#{path}"
@@ -67,10 +71,10 @@ class Puppet::FileServing::Configuration
       path = nil
     elsif path
       # Remove any double slashes that might have occurred
-      path = path.gsub(/\/+/, "/")
+      path = path.gsub(%r{/+}, "/")
     end
 
-    return mount, path
+    [mount, path]
   end
 
   def umount(name)
@@ -96,7 +100,7 @@ class Puppet::FileServing::Configuration
 
     @parser ||= Puppet::FileServing::Configuration::Parser.new(config)
 
-    return if check and ! @parser.changed?
+    return if check and !@parser.changed?
 
     # Don't assign the mounts hash until we're sure the parsing succeeded.
     begin
@@ -105,7 +109,6 @@ class Puppet::FileServing::Configuration
     rescue => detail
       Puppet.log_exception(detail, _("Error parsing fileserver configuration: %{detail}; using old configuration") % { detail: detail })
     end
-
   ensure
     # Make sure we've got our plugins and modules.
     mk_default_mounts

data/lib/puppet/file_serving/content.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../puppet/indirector'
 require_relative '../../puppet/file_serving'
 require_relative '../../puppet/file_serving/base'

data/lib/puppet/file_serving/fileset.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'find'
 require_relative '../../puppet/file_serving'
 require_relative '../../puppet/file_serving/metadata'
@@ -27,11 +29,11 @@ class Puppet::FileServing::Fileset
   def initialize(path, options = {})
     if Puppet::Util::Platform.windows?
       # REMIND: UNC path
-      path = path.chomp(File::SEPARATOR) unless path =~ /^[A-Za-z]:\/$/
+      path = path.chomp(File::SEPARATOR) unless path =~ %r{^[A-Za-z]:/$}
     else
       path = path.chomp(File::SEPARATOR) unless path == File::SEPARATOR
     end
-    raise ArgumentError.new(_("Fileset paths must be fully qualified: %{path}") % { path: path }) unless Puppet::Util.absolute_path?(path)
+    raise ArgumentError, _("Fileset paths must be fully qualified: %{path}") % { path: path } unless Puppet::Util.absolute_path?(path)
 
     @path = path
 
@@ -48,9 +50,9 @@ class Puppet::FileServing::Fileset
       initialize_from_hash(options)
     end
 
-    raise ArgumentError.new(_("Fileset paths must exist")) unless valid?(path)
-    #TRANSLATORS "recurse" and "recurselimit" are parameter names and should not be translated
-    raise ArgumentError.new(_("Fileset recurse parameter must not be a number anymore, please use recurselimit")) if @recurse.is_a?(Integer)
+    raise ArgumentError, _("Fileset paths must exist") unless valid?(path)
+    # TRANSLATORS "recurse" and "recurselimit" are parameter names and should not be translated
+    raise ArgumentError, _("Fileset recurse parameter must not be a number anymore, please use recurselimit") if @recurse.is_a?(Integer)
   end
 
   # Return a list of all files in our fileset.  This is different from the
@@ -66,7 +68,7 @@ class Puppet::FileServing::Fileset
     munged_max_files = max_files == '-1' ? -1 : max_files
 
     if munged_max_files > 0 && files.size > munged_max_files
-      raise Puppet::Error.new _("The directory '%{path}' contains %{entries} entries, which exceeds the limit of %{munged_max_files} specified by the max_files parameter for this resource. The limit may be increased, but be aware that large number of file resources can result in excessive resource consumption and degraded performance. Consider using an alternate method to manage large directory trees") % { path: path, entries: files.size, munged_max_files: munged_max_files }
+      raise Puppet::Error, _("The directory '%{path}' contains %{entries} entries, which exceeds the limit of %{munged_max_files} specified by the max_files parameter for this resource. The limit may be increased, but be aware that large number of file resources can result in excessive resource consumption and degraded performance. Consider using an alternate method to manage large directory trees") % { path: path, entries: files.size, munged_max_files: munged_max_files }
     elsif munged_max_files == 0 && files.size > soft_max_files
       Puppet.warning _("The directory '%{path}' contains %{entries} entries, which exceeds the default soft limit %{soft_max_files} and may cause excessive resource consumption and degraded performance. To remove this warning set a value for `max_files` parameter or consider using an alternate method to manage large directory trees") % { path: path, entries: files.size, soft_max_files: soft_max_files }
     end
@@ -88,8 +90,9 @@ class Puppet::FileServing::Fileset
 
   def links=(links)
     links = links.to_sym
-    #TRANSLATORS ":links" is a parameter name and should not be translated
+    # TRANSLATORS ":links" is a parameter name and should not be translated
     raise(ArgumentError, _("Invalid :links value '%{links}'") % { links: links }) unless [:manage, :follow].include?(links)
+
     @links = links
     @stat_method = @links == :manage ? :lstat : :stat
   end
@@ -101,8 +104,8 @@ class Puppet::FileServing::Fileset
       method = option.to_s + "="
       begin
         send(method, value)
-      rescue NoMethodError
-        raise ArgumentError, _("Invalid option '%{option}'") % { option: option }, $!.backtrace
+      rescue NoMethodError => e
+        raise ArgumentError, _("Invalid option '%{option}'") % { option: option }, e.backtrace
       end
     end
   end
@@ -115,6 +118,7 @@ class Puppet::FileServing::Fileset
         value = request.options[param.to_s]
       end
       next if value.nil?
+
       value = true if value == "true"
       value = false if value == "false"
       value = Integer(value) if value.is_a?(String) and value =~ /^\d+$/
@@ -134,9 +138,9 @@ class Puppet::FileServing::Fileset
     def children
       return [] unless directory?
 
-      Dir.entries(path, encoding: Encoding::UTF_8).
-        reject { |child| ignore?(child) }.
-        collect { |child| down_level(child) }
+      Dir.entries(path, encoding: Encoding::UTF_8)
+         .reject { |child| ignore?(child) }
+         .collect { |child| down_level(child) }
     end
 
     def ignore?(child)
@@ -160,12 +164,12 @@ class Puppet::FileServing::Fileset
 
     result = []
 
-    while entry = current_dirs.shift #rubocop:disable Lint/AssignmentInCondition
-      if continue_recursion_at?(entry.depth + 1)
-        entry.children.each do |child|
-          result << child.path
-          current_dirs << child
-        end
+    while entry = current_dirs.shift # rubocop:disable Lint/AssignmentInCondition
+      next unless continue_recursion_at?(entry.depth + 1)
+
+      entry.children.each do |child|
+        result << child.path
+        current_dirs << child
       end
     end
 
@@ -181,6 +185,6 @@ class Puppet::FileServing::Fileset
 
   def continue_recursion_at?(depth)
     # recurse if told to, and infinite recursion or current depth not at the limit
-    self.recurse && (self.recurselimit == :infinite || depth <= self.recurselimit)
+    recurse && (recurselimit == :infinite || depth <= recurselimit)
   end
 end

data/lib/puppet/file_serving/http_metadata.rb

@@ -1,9 +1,10 @@
+# frozen_string_literal: true
+
 require_relative '../../puppet/file_serving/metadata'
 
 # Simplified metadata representation, suitable for the information
 # that is available from HTTP headers.
 class Puppet::FileServing::HttpMetadata < Puppet::FileServing::Metadata
-
   def initialize(http_response, path = '/dev/null')
     super(path)
 
@@ -19,7 +20,7 @@ class Puppet::FileServing::HttpMetadata < Puppet::FileServing::Metadata
     checksum = http_response['content-md5']
     if checksum
       # convert base64 digest to hex
-      checksum = checksum.unpack("m").first.unpack("H*").first
+      checksum = checksum.unpack1("m").unpack1("H*")
       @checksums[:md5] = "{md5}#{checksum}"
     end
 
@@ -41,8 +42,6 @@ class Puppet::FileServing::HttpMetadata < Puppet::FileServing::Metadata
     end
 
     @ftype = 'file'
-
-    self
   end
 
   # Override of the parent class method. Does not call super!

data/lib/puppet/file_serving/metadata.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../puppet'
 require_relative '../../puppet/indirector'
 require_relative '../../puppet/file_serving'
@@ -7,7 +9,6 @@ require 'uri'
 
 # A class that handles retrieving file metadata.
 class Puppet::FileServing::Metadata < Puppet::FileServing::Base
-
   include Puppet::Util::Checksums
 
   extend Puppet::Indirector
@@ -46,7 +47,7 @@ class Puppet::FileServing::Metadata < Puppet::FileServing::Base
 
     def initialize(stat, source_permissions)
       @stat = stat
-      @source_permissions_ignore = (!source_permissions || source_permissions == :ignore)
+      @source_permissions_ignore = !source_permissions || source_permissions == :ignore
     end
 
     def owner
@@ -58,7 +59,7 @@ class Puppet::FileServing::Metadata < Puppet::FileServing::Base
     end
 
     def mode
-      @source_permissions_ignore ? 0644 : @stat.mode
+      @source_permissions_ignore ? 0o644 : @stat.mode
     end
 
     def_delegators :@stat, :ftype
@@ -77,10 +78,9 @@ class Puppet::FileServing::Metadata < Puppet::FileServing::Base
 
     { :owner => 'S-1-5-32-544',
       :group => 'S-1-0-0',
-      :mode => 0644
-    }.each do |method, default_value|
+      :mode => 0o644 }.each do |method, default_value|
       define_method method do
-        return default_value
+        default_value
       end
     end
   end
@@ -107,26 +107,30 @@ class Puppet::FileServing::Metadata < Puppet::FileServing::Base
     @ftype = stat.ftype
 
     # We have to mask the mode, yay.
-    @mode = stat.mode & 007777
+    @mode = stat.mode & 0o07777
 
     case stat.ftype
     when "file"
-      @checksum = ("{#{@checksum_type}}") + send("#{@checksum_type}_file", real_path).to_s
+      @checksum = "{#{@checksum_type}}" + send("#{@checksum_type}_file", real_path).to_s
     when "directory" # Always just timestamp the directory.
       @checksum_type = "ctime"
-      @checksum = ("{#{@checksum_type}}") + send("#{@checksum_type}_file", path).to_s
+      @checksum = "{#{@checksum_type}}" + send("#{@checksum_type}_file", path).to_s
     when "link"
       @destination = Puppet::FileSystem.readlink(real_path)
-      @checksum = ("{#{@checksum_type}}") + send("#{@checksum_type}_file", real_path).to_s rescue nil
+      @checksum = begin
+        "{#{@checksum_type}}" + send("#{@checksum_type}_file", real_path).to_s
+      rescue
+        nil
+      end
     when "fifo", "socket"
       @checksum_type = "none"
-      @checksum = ("{#{@checksum_type}}") + send("#{@checksum_type}_file", real_path).to_s
+      @checksum = "{#{@checksum_type}}" + send("#{@checksum_type}_file", real_path).to_s
     else
       raise ArgumentError, _("Cannot manage files of type %{file_type}") % { file_type: stat.ftype }
     end
   end
 
-  def initialize(path,data={})
+  def initialize(path, data = {})
     @owner       = data.delete('owner')
     @group       = data.delete('group')
     @mode        = data.delete('mode')
@@ -150,22 +154,21 @@ class Puppet::FileServing::Metadata < Puppet::FileServing::Base
   def to_data_hash
     super.update(
       {
-        'owner'        => owner,
-        'group'        => group,
-        'mode'         => mode,
-        'checksum'     => {
-          'type'   => checksum_type,
-          'value'  => checksum
+        'owner' => owner,
+        'group' => group,
+        'mode' => mode,
+        'checksum' => {
+          'type' => checksum_type,
+          'value' => checksum
         },
-        'type'         => ftype,
-        'destination'  => destination,
-      }.merge(content_uri ? {'content_uri' => content_uri} : {})
-       .merge(source ? {'source' => source} : {})
+        'type' => ftype,
+        'destination' => destination,
+      }.merge(content_uri ? { 'content_uri' => content_uri } : {})
+       .merge(source ? { 'source' => source } : {})
     )
   end
 
   def self.from_data_hash(data)
     new(data.delete('path'), data)
   end
-
 end

data/lib/puppet/file_serving/mount/file.rb

@@ -1,28 +1,30 @@
+# frozen_string_literal: true
+
 require_relative '../../../puppet/file_serving/mount'
 
 class Puppet::FileServing::Mount::File < Puppet::FileServing::Mount
   def self.localmap
     @localmap ||= {
-      "h" => Puppet.runtime[:facter].value("hostname"),
+      "h" => Puppet.runtime[:facter].value('networking.hostname'),
       "H" => [
-               Puppet.runtime[:facter].value("hostname"),
-               Puppet.runtime[:facter].value("domain")
-             ].join("."),
-      "d" => Puppet.runtime[:facter].value("domain")
+        Puppet.runtime[:facter].value('networking.hostname'),
+        Puppet.runtime[:facter].value('networking.domain')
+      ].join("."),
+      "d" => Puppet.runtime[:facter].value('networking.domain')
     }
   end
 
   def complete_path(relative_path, node)
     full_path = path(node)
 
-    raise ArgumentError.new(_("Mounts without paths are not usable")) unless full_path
+    raise ArgumentError, _("Mounts without paths are not usable") unless full_path
 
     # If there's no relative path name, then we're serving the mount itself.
     return full_path unless relative_path
 
     file = ::File.join(full_path, relative_path)
 
-    if !(Puppet::FileSystem.exist?(file) or Puppet::FileSystem.symlink?(file))
+    unless Puppet::FileSystem.exist?(file) or Puppet::FileSystem.symlink?(file)
       Puppet.info(_("File does not exist or is not accessible: %{file}") % { file: file })
       return nil
     end
@@ -38,9 +40,9 @@ class Puppet::FileServing::Mount::File < Puppet::FileServing::Mount
   # Return the path as appropriate, expanding as necessary.
   def path(node = nil)
     if expandable?
-      return expand(@path, node)
+      expand(@path, node)
     else
-      return @path
+      @path
     end
   end
 
@@ -54,6 +56,7 @@ class Puppet::FileServing::Mount::File < Puppet::FileServing::Mount
     else
       raise ArgumentError, _("%{path} does not exist or is not a directory") % { path: path } unless FileTest.directory?(path)
       raise ArgumentError, _("%{path} is not readable") % { path: path } unless FileTest.readable?(path)
+
       @expandable = false
     end
     @path = path
@@ -62,13 +65,14 @@ class Puppet::FileServing::Mount::File < Puppet::FileServing::Mount
   def search(path, request)
     path = complete_path(path, request.node)
     return nil unless path
+
     [path]
   end
 
   # Verify our configuration is valid.  This should really check to
   # make sure at least someone will be allowed, but, eh.
   def validate
-    raise ArgumentError.new(_("Mounts without paths are not usable")) if @path.nil?
+    raise ArgumentError, _("Mounts without paths are not usable") if @path.nil?
   end
 
   private
@@ -96,7 +100,7 @@ class Puppet::FileServing::Mount::File < Puppet::FileServing::Mount
     end
 
     path.gsub(/%(.)/) do |v|
-      key = $1
+      key = ::Regexp.last_match(1)
       if key == "%"
         "%"
       else

data/lib/puppet/file_serving/mount/locales.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../../puppet/file_serving/mount'
 
 # Find files in the modules' locales directories.
@@ -6,18 +8,16 @@ require_relative '../../../puppet/file_serving/mount'
 class Puppet::FileServing::Mount::Locales < Puppet::FileServing::Mount
   # Return an instance of the appropriate class.
   def find(relative_path, request)
-    mod = request.environment.modules.find { |m|  m.locale(relative_path) }
+    mod = request.environment.modules.find { |m| m.locale(relative_path) }
     return nil unless mod
 
-    path = mod.locale(relative_path)
-
-    path
+    mod.locale(relative_path)
   end
 
   def search(relative_path, request)
     # We currently only support one kind of search on locales - return
     # them all.
-    paths = request.environment.modules.find_all { |mod| mod.locales? }.collect { |mod| mod.locale_directory }
+    paths = request.environment.modules.find_all(&:locales?).collect(&:locale_directory)
     if paths.empty?
       # If the modulepath is valid then we still need to return a valid root
       # directory for the search, but make sure nothing inside it is

data/lib/puppet/file_serving/mount/modules.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../../puppet/file_serving/mount'
 
 # This is the modules-specific mount: it knows how to search through
@@ -6,6 +8,7 @@ class Puppet::FileServing::Mount::Modules < Puppet::FileServing::Mount
   # Return an instance of the appropriate class.
   def find(path, request)
     raise _("No module specified") if path.to_s.empty?
+
     module_name, relative_path = path.split("/", 2)
     mod = request.environment.module(module_name)
     return nil unless mod