openvox 7.37.1 → 8.19.0

data/lib/puppet/test/test_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'tmpdir'
 require 'fileutils'
 
@@ -33,7 +35,7 @@ module Puppet::Test
     # Call this method once, as early as possible, such as before loading tests
     # that call Puppet.
     # @return nil
-    def self.initialize()
+    def self.initialize
       # This meta class instance variable is used as a guard to ensure that
       # before_each, and after_each are only called once. This problem occurs
       # when there are more than one puppet test infrastructure orchestrator in use.
@@ -51,9 +53,9 @@ module Puppet::Test
       Dir.mkdir("#{@environmentpath}/production")
       owner = Process.pid
       Puppet.push_context(Puppet.base_context({
-        :environmentpath => @environmentpath,
-        :basemodulepath => "",
-      }), "Initial for specs")
+                                                :environmentpath => @environmentpath,
+                                                :basemodulepath => "",
+                                              }), "Initial for specs")
       Puppet::Parser::Functions.reset
 
       ObjectSpace.define_finalizer(Puppet.lookup(:environments), proc {
@@ -67,21 +69,15 @@ module Puppet::Test
     # Call this method once, when beginning a test run--prior to running
     #  any individual tests.
     # @return nil
-    def self.before_all_tests()
+    def self.before_all_tests
       # The process environment is a shared, persistent resource.
-      # Can't use Puppet.features.microsoft_windows? as it may be mocked out in a test.  This can cause test recurring test failures
-      if (!!File::ALT_SEPARATOR)
-        mode = :windows
-      else
-        mode = :posix
-      end
-      $old_env = Puppet::Util.get_environment(mode)
+      $old_env = ENV.to_hash
     end
 
     # Call this method once, at the end of a test run, when no more tests
     #  will be run.
     # @return nil
-    def self.after_all_tests()
+    def self.after_all_tests
     end
 
     # The name of the rollback mark used in the Puppet.context. This is what
@@ -91,7 +87,7 @@ module Puppet::Test
 
     # Call this method once per test, prior to execution of each individual test.
     # @return nil
-    def self.before_each_test()
+    def self.before_each_test
       # When using both rspec-puppet and puppet-rspec-helper, there are two packages trying
       # to be helpful and orchestrate the callback sequence. We let only the first win, the
       # second callback results in a no-op.
@@ -99,6 +95,7 @@ module Puppet::Test
       # only once.
       #
       return unless @@reentry_count == 0
+
       @@reentry_count = 1
 
       Puppet.mark_context(ROLLBACK_MARK)
@@ -121,10 +118,10 @@ module Puppet::Test
       indirections.each do |indirector|
         $saved_indirection_state[indirector.name] = {
           :@terminus_class => indirector.instance_variable_get(:@terminus_class).value,
-          :@cache_class    => indirector.instance_variable_get(:@cache_class).value,
+          :@cache_class => indirector.instance_variable_get(:@cache_class).value,
           # dup the termini hash so termini created and registered during
           # the test aren't stored in our saved_indirection_state
-          :@termini        => indirector.instance_variable_get(:@termini).dup
+          :@termini => indirector.instance_variable_get(:@termini).dup
         }
       end
 
@@ -140,7 +137,8 @@ module Puppet::Test
           ssl_context: Puppet::SSL::SSLContext.new(cacerts: []).freeze,
           http_session: proc { Puppet.runtime[:http].create_session }
         },
-        "Context for specs")
+        "Context for specs"
+      )
 
       # trigger `require 'facter'`
       Puppet.runtime[:facter]
@@ -158,10 +156,11 @@ module Puppet::Test
 
     # Call this method once per test, after execution of each individual test.
     # @return nil
-    def self.after_each_test()
+    def self.after_each_test
       # Ensure that a matching tear down only happens once per completed setup
       # (see #before_each_test).
       return unless @@reentry_count == 1
+
       @@reentry_count = 0
 
       Puppet.settings.send(:clear_everything_for_tests)
@@ -173,7 +172,7 @@ module Puppet::Test
       Puppet.clear_deprecation_warnings
 
       # uncommenting and manipulating this can be useful when tracking down calls to deprecated code
-      #Puppet.log_deprecations_to_file("deprecations.txt", /^Puppet::Util.exec/)
+      # Puppet.log_deprecations_to_file("deprecations.txt", /^Puppet::Util.exec/)
 
       # Restore the indirector configuration.  See before hook.
       indirections = Puppet::Indirector::Indirection.send(:class_variable_get, :@@indirections)
@@ -188,51 +187,38 @@ module Puppet::Test
       end
       $saved_indirection_state = nil
 
-      # Can't use Puppet.features.microsoft_windows? as it may be mocked out in a test.  This can cause test recurring test failures
-      if (!!File::ALT_SEPARATOR)
-        mode = :windows
-      else
-        mode = :posix
-      end
-      # Restore the global process environment.  Can't just assign because this
-      # is a magic variable, sadly, and doesn't do that™.  It is sufficiently
-      # faster to use the compare-then-set model to avoid excessive work that it
-      # justifies the complexity.  --daniel 2012-03-15
-      unless Puppet::Util.get_environment(mode) == $old_env
-        Puppet::Util.clear_environment(mode)
-        $old_env.each {|k, v| Puppet::Util.set_env(k, v, mode) }
-      end
+      # Restore the global process environment.
+      ENV.replace($old_env)
 
       # Clear all environments
       Puppet.lookup(:environments).clear_all
 
       # Restore the load_path late, to avoid messing with stubs from the test.
       $LOAD_PATH.clear
-      $old_load_path.each {|x| $LOAD_PATH << x }
+      $old_load_path.each { |x| $LOAD_PATH << x }
 
       Puppet.rollback_context(ROLLBACK_MARK)
     end
 
-
     #########################################################################################
     # PRIVATE METHODS (not part of the public TestHelper API--do not call these from outside
     #  of this class!)
     #########################################################################################
 
-    def self.app_defaults_for_tests()
+    def self.app_defaults_for_tests
       {
-          :logdir     => "/dev/null",
-          :confdir    => "/dev/null",
-          :publicdir  => "/dev/null",
-          :codedir    => "/dev/null",
-          :vardir     => "/dev/null",
-          :rundir     => "/dev/null",
-          :hiera_config => "/dev/null",
+        :logdir => "/dev/null",
+        :confdir => "/dev/null",
+        :publicdir => "/dev/null",
+        :codedir => "/dev/null",
+        :vardir => "/dev/null",
+        :rundir => "/dev/null",
+        :hiera_config => "/dev/null",
       }
     end
     private_class_method :app_defaults_for_tests
 
-    def self.initialize_settings_before_each()
+    def self.initialize_settings_before_each
       Puppet.settings.preferred_run_mode = "user"
       # Initialize "app defaults" settings to a good set of test values
       Puppet.settings.initialize_app_defaults(app_defaults_for_tests)

data/lib/puppet/thread_local.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'concurrent'
 
 class Puppet::ThreadLocal < Concurrent::ThreadLocalVar

data/lib/puppet/transaction/additional_resource_generator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Adds additional resources to the catalog and relationship graph that are
 # generated by existing resources. There are two ways that a resource can
 # generate additional resources, either through the #generate method or the
@@ -18,6 +20,7 @@ class Puppet::Transaction::AdditionalResourceGenerator
 
   def generate_additional_resources(resource)
     return unless resource.respond_to?(:generate)
+
     begin
       generated = resource.generate
     rescue => detail
@@ -25,6 +28,7 @@ class Puppet::Transaction::AdditionalResourceGenerator
       resource.log_exception(detail, _("Failed to generate additional resources using 'generate': %{detail}") % { detail: detail })
     end
     return unless generated
+
     generated = [generated] unless generated.is_a?(Array)
     generated.collect! do |res|
       @catalog.resource(res.ref) || res
@@ -52,18 +56,19 @@ class Puppet::Transaction::AdditionalResourceGenerator
   def eval_generate(resource)
     return false unless resource.respond_to?(:eval_generate)
     raise Puppet::DevError, _("Depthfirst resources are not supported by eval_generate") if resource.depthfirst?
+
     begin
       generated = replace_duplicates_with_catalog_resources(resource.eval_generate)
       return false if generated.empty?
     rescue => detail
       @resources_failed_to_generate = true
-      #TRANSLATORS eval_generate is a method name and should be left untranslated
+      # TRANSLATORS eval_generate is a method name and should be left untranslated
       resource.log_exception(detail, _("Failed to generate additional resources using 'eval_generate': %{detail}") % { detail: detail })
       return false
     end
     add_resources(generated, resource)
 
-    made = Hash[generated.map(&:name).zip(generated)]
+    made = generated.map(&:name).zip(generated).to_h
     contain_generated_resources_in(resource, made)
     connect_resources_to_ancestors(resource, made)
 
@@ -129,7 +134,7 @@ class Puppet::Transaction::AdditionalResourceGenerator
     end
   end
 
-  def add_resource(res, parent_resource, priority=nil)
+  def add_resource(res, parent_resource, priority = nil)
     if @catalog.resource(res.ref).nil?
       res.merge_tags_from(parent_resource)
       if parent_resource.depthfirst?
@@ -152,7 +157,7 @@ class Puppet::Transaction::AdditionalResourceGenerator
   # add correct edge for depth- or breadth- first traversal of
   # generated resource. Skip generating the edge if there is already
   # some sort of edge between the two resources.
-  def add_generated_directed_dependency(parent, child, label=nil)
+  def add_generated_directed_dependency(parent, child, label = nil)
     if parent.depthfirst?
       source = child
       target = parent
@@ -186,7 +191,7 @@ class Puppet::Transaction::AdditionalResourceGenerator
       parent_contains || child_contains
     }
 
-    if not edge_exists
+    unless edge_exists
       # We *cannot* use target.to_resource here!
       #
       # For reasons that are beyond my (and, perhaps, human)
@@ -208,13 +213,13 @@ class Puppet::Transaction::AdditionalResourceGenerator
 
   # Copy an important relationships from the parent to the newly-generated
   # child resource.
-  def add_conditional_directed_dependency(parent, child, label=nil)
+  def add_conditional_directed_dependency(parent, child, label = nil)
     @relationship_graph.add_vertex(child)
     edge = parent.depthfirst? ? [child, parent] : [parent, child]
     if @relationship_graph.edge?(*edge.reverse)
       parent.debug "Skipping automatic relationship to #{child}"
     else
-      @relationship_graph.add_relationship(edge[0],edge[1],label)
+      @relationship_graph.add_relationship(edge[0], edge[1], label)
     end
   end
 end

data/lib/puppet/transaction/event.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../puppet/transaction'
 require_relative '../../puppet/util/tagging'
 require_relative '../../puppet/util/logging'
@@ -14,10 +16,10 @@ class Puppet::Transaction::Event
   attr_accessor :time
   attr_reader :default_log_level
 
-  EVENT_STATUSES = %w{noop success failure audit}
+  EVENT_STATUSES = %w[noop success failure audit]
 
   def self.from_data_hash(data)
-    obj = self.allocate
+    obj = allocate
     obj.initialize_from_hash(data)
     obj
   end
@@ -67,9 +69,9 @@ class Puppet::Transaction::Event
 
   def initialize_from_hash(data)
     data = Puppet::Pops::Serialization::FromDataConverter.convert(data, {
-      :allow_unresolved => true,
-      :loader => Puppet::Pops::Loaders.static_loader
-    })
+                                                                    :allow_unresolved => true,
+                                                                    :loader => Puppet::Pops::Loaders.static_loader
+                                                                  })
     @audited = data['audited']
     @property = data['property']
     @previous_value = data['previous_value']
@@ -122,6 +124,7 @@ class Puppet::Transaction::Event
 
   def status=(value)
     raise ArgumentError, _("Event status can only be %{statuses}") % { statuses: EVENT_STATUSES.join(', ') } unless EVENT_STATUSES.include?(value)
+
     @status = value
   end
 

data/lib/puppet/transaction/event_manager.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../puppet/transaction'
 
 # This class stores, routes, and responds to events generated while evaluating
@@ -5,7 +7,6 @@ require_relative '../../puppet/transaction'
 #
 # @api private
 class Puppet::Transaction::EventManager
-
   # @!attribute [r] transaction
   #   @return [Puppet::Transaction] The transaction associated with this event manager.
   attr_reader :transaction
@@ -49,15 +50,14 @@ class Puppet::Transaction::EventManager
   # @param events [Array<Puppet::Transaction::Event>] All events generated by this resource
   # @return [void]
   def queue_events(resource, events)
-    #@events += events
+    # @events += events
 
     # Do some basic normalization so we're not doing so many
     # graph queries for large sets of events.
-    events.inject({}) do |collection, event|
+    events.each_with_object({}) do |event, collection|
       collection[event.name] ||= []
       collection[event.name] << event
-      collection
-    end.collect do |name, list|
+    end.collect do |_name, list|
       # It doesn't matter which event we use - they all have the same source
       # and name here.
       event = list[0]
@@ -76,10 +76,10 @@ class Puppet::Transaction::EventManager
       end
       @events << event if received
 
-      queue_events_for_resource(resource, resource, :refresh, [event]) if resource.self_refresh? and ! resource.deleting?
+      queue_events_for_resource(resource, resource, :refresh, [event]) if resource.self_refresh? and !resource.deleting?
     end
 
-    dequeue_events_for_resource(resource, :refresh) if events.detect { |e| e.invalidate_refreshes }
+    dequeue_events_for_resource(resource, :refresh) if events.detect(&:invalidate_refreshes)
   end
 
   def dequeue_all_events_for_resource(target)
@@ -117,6 +117,7 @@ class Puppet::Transaction::EventManager
   def queued_events(resource)
     callbacks = @event_queues[resource]
     return unless callbacks
+
     callbacks.each do |callback, events|
       yield callback, events unless events.empty?
     end
@@ -141,27 +142,27 @@ class Puppet::Transaction::EventManager
   #   associated with this callback and resource.
   # @return [true, false] Whether the callback was successfully run.
   def process_callback(resource, callback, events)
-    if !process_callback?(resource, events)
+    unless process_callback?(resource, events)
       process_noop_events(resource, callback, events)
       return false
     end
 
     resource.send(callback)
 
-    if not resource.is_a?(Puppet::Type.type(:whit))
+    unless resource.is_a?(Puppet::Type.type(:whit))
       message = n_("Triggered '%{callback}' from %{count} event", "Triggered '%{callback}' from %{count} events", events.length) % { count: events.length, callback: callback }
       resource.notice message
       add_callback_status_event(resource, callback, message, "success")
     end
 
-    return true
+    true
   rescue => detail
     resource_error_message = _("Failed to call %{callback}: %{detail}") % { callback: callback, detail: detail }
     resource.err(resource_error_message)
     transaction.resource_status(resource).failed_to_restart = true
     transaction.resource_status(resource).fail_with_event(resource_error_message)
     resource.log_exception(detail)
-    return false
+    false
   end
 
   def add_callback_status_event(resource, callback, message, status)

data/lib/puppet/transaction/persistence.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'yaml'
 require_relative '../../puppet/util/yaml'
 
@@ -6,7 +8,6 @@ require_relative '../../puppet/util/yaml'
 # as calculating corrective_change).
 # @api private
 class Puppet::Transaction::Persistence
-
   def self.allowed_classes
     @allowed_classes ||= [
       Symbol,
@@ -20,7 +21,7 @@ class Puppet::Transaction::Persistence
       Puppet::Pops::Time::Timestamp,
       Puppet::Pops::Time::TimeData,
       Puppet::Pops::Time::Timespan,
-      Puppet::Pops::Types::PBinaryType::Binary,
+      Puppet::Pops::Types::PBinaryType::Binary
       # Puppet::Pops::Types::PSensitiveType::Sensitive values are excluded from
       # the persistence store, ignore it.
     ].freeze
@@ -28,7 +29,7 @@ class Puppet::Transaction::Persistence
 
   def initialize
     @old_data = {}
-    @new_data = {"resources" => {}}
+    @new_data = { "resources" => {} }
   end
 
   # Obtain the full raw data from the persistence store.
@@ -63,7 +64,7 @@ class Puppet::Transaction::Persistence
   def copy_skipped(resource_name)
     @old_data["resources"] ||= {}
     old_value = @old_data["resources"][resource_name]
-    if !old_value.nil?
+    unless old_value.nil?
       @new_data["resources"][resource_name] = old_value
     end
   end
@@ -74,6 +75,7 @@ class Puppet::Transaction::Persistence
     unless Puppet::FileSystem.exist?(filename)
       return
     end
+
     unless File.file?(filename)
       Puppet.warning(_("Transaction store file %{filename} is not a file, ignoring") % { filename: filename })
       return
@@ -81,20 +83,18 @@ class Puppet::Transaction::Persistence
 
     result = nil
     Puppet::Util.benchmark(:debug, _("Loaded transaction store file in %{seconds} seconds")) do
+      result = Puppet::Util::Yaml.safe_load_file(filename, self.class.allowed_classes)
+    rescue Puppet::Util::Yaml::YamlLoadError => detail
+      Puppet.log_exception(detail, _("Transaction store file %{filename} is corrupt (%{detail}); replacing") % { filename: filename, detail: detail })
+
       begin
-        result = Puppet::Util::Yaml.safe_load_file(filename, self.class.allowed_classes)
-      rescue Puppet::Util::Yaml::YamlLoadError => detail
-        Puppet.log_exception(detail, _("Transaction store file %{filename} is corrupt (%{detail}); replacing") % { filename: filename, detail: detail })
-
-        begin
-          File.rename(filename, filename + ".bad")
-        rescue => detail
-          Puppet.log_exception(detail, _("Unable to rename corrupt transaction store file: %{detail}") % { detail: detail })
-          raise Puppet::Error, _("Could not rename corrupt transaction store file %{filename}; remove manually") % { filename: filename }, detail.backtrace
-        end
-
-        result = {}
+        File.rename(filename, filename + ".bad")
+      rescue => detail
+        Puppet.log_exception(detail, _("Unable to rename corrupt transaction store file: %{detail}") % { detail: detail })
+        raise Puppet::Error, _("Could not rename corrupt transaction store file %{filename}; remove manually") % { filename: filename }, detail.backtrace
       end
+
+      result = {}
     end
 
     unless result.is_a?(Hash)

data/lib/puppet/transaction/report.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../../puppet'
 require_relative '../../puppet/indirector'
 
@@ -139,10 +141,10 @@ class Puppet::Transaction::Report
   #
   attr_accessor :transaction_completed
 
-  TOTAL = "total".freeze
+  TOTAL = "total"
 
   def self.from_data_hash(data)
-    obj = self.allocate
+    obj = allocate
     obj.initialize_from_hash(data)
     obj
   end
@@ -204,7 +206,7 @@ class Puppet::Transaction::Report
 
   # @api private
   def prune_internal_data
-    resource_statuses.delete_if {|name,res| res.resource_type == 'Whit'}
+    resource_statuses.delete_if { |_name, res| res.resource_type == 'Whit' }
   end
 
   # @api private
@@ -215,14 +217,14 @@ class Puppet::Transaction::Report
     resource_metrics = add_metric(:resources, calculate_resource_metrics)
     add_metric(:time, calculate_time_metrics)
     change_metric = calculate_change_metric
-    add_metric(:changes, {TOTAL => change_metric})
+    add_metric(:changes, { TOTAL => change_metric })
     add_metric(:events, calculate_event_metrics)
     @status = compute_status(resource_metrics, change_metric)
-    @noop_pending = @resource_statuses.any? { |name,res| has_noop_events?(res) }
+    @noop_pending = @resource_statuses.any? { |_name, res| has_noop_events?(res) }
   end
 
   # @api private
-  def initialize(configuration_version=nil, environment=nil, transaction_uuid=nil, job_id=nil, start_time=Time.now)
+  def initialize(configuration_version = nil, environment = nil, transaction_uuid = nil, job_id = nil, start_time = Time.now)
     @metrics = {}
     @logs = []
     @resource_statuses = {}
@@ -300,12 +302,16 @@ class Puppet::Transaction::Report
 
     @resource_statuses = {}
     data['resource_statuses'].map do |key, rs|
-      @resource_statuses[key] = if rs == Puppet::Resource::EMPTY_HASH
-        nil
-      else
-        # Older versions contain tags that causes Psych to create instances directly
-        rs.is_a?(Puppet::Resource::Status) ? rs : Puppet::Resource::Status.from_data_hash(rs)
-      end
+      @resource_statuses[key] =
+        if rs == Puppet::Resource::EMPTY_HASH
+          nil
+        elsif rs.is_a?(Puppet::Resource::Status)
+          # Older versions contain tags that causes Psych to create instances
+          # directly
+          rs
+        else
+          Puppet::Resource::Status.from_data_hash(rs)
+        end
     end
   end
 
@@ -322,7 +328,7 @@ class Puppet::Transaction::Report
                         else
                           @resource_statuses
                         end
-    Hash[resource_statuses.map { |key, rs| [key, rs.nil? ? nil : rs.to_data_hash] }]
+    resource_statuses.transform_values { |rs| rs.nil? ? nil : rs.to_data_hash }
   end
 
   def to_data_hash
@@ -338,8 +344,8 @@ class Puppet::Transaction::Report
       'noop' => @noop,
       'noop_pending' => @noop_pending,
       'environment' => @environment,
-      'logs' => @logs.map { |log| log.to_data_hash },
-      'metrics' => Hash[@metrics.map { |key, metric| [key, metric.to_data_hash] }],
+      'logs' => @logs.map(&:to_data_hash),
+      'metrics' => @metrics.transform_values(&:to_data_hash),
       'resource_statuses' => calculate_resource_statuses,
       'corrective_change' => @corrective_change,
     }
@@ -368,11 +374,11 @@ class Puppet::Transaction::Report
   def summary
     report = raw_summary
 
-    ret = ""
+    ret = ''.dup
     report.keys.sort_by(&:to_s).each do |key|
       ret += "#{Puppet::Util::Metric.labelize(key)}:\n"
 
-      report[key].keys.sort { |a,b|
+      report[key].keys.sort { |a, b|
         # sort by label
         if a == TOTAL
           1
@@ -384,6 +390,7 @@ class Puppet::Transaction::Report
       }.each do |label|
         value = report[key][label]
         next if value == 0
+
         value = "%0.2f" % value if value.is_a?(Float)
         ret += "   %15s %s\n" % [Puppet::Util::Metric.labelize(label) + ":", value]
       end
@@ -408,10 +415,10 @@ class Puppet::Transaction::Report
       }
     }
 
-    @metrics.each do |name, metric|
+    @metrics.each do |_name, metric|
       key = metric.name.to_s
       report[key] = {}
-      metric.values.each do |metric_name, label, value|
+      metric.values.each do |metric_name, _label, value|
         report[key][metric_name.to_s] = value
       end
       report[key][TOTAL] = 0 unless key == "time" or report[key].include?(TOTAL)
@@ -433,8 +440,8 @@ class Puppet::Transaction::Report
   def exit_status
     status = 0
     if @metrics["changes"] && @metrics["changes"][TOTAL] &&
-        @metrics["resources"] && @metrics["resources"]["failed"] &&
-        @metrics["resources"]["failed_to_restart"]
+       @metrics["resources"] && @metrics["resources"]["failed"] &&
+       @metrics["resources"]["failed_to_restart"]
       status |= 2 if @metrics["changes"][TOTAL] > 0
       status |= 4 if @metrics["resources"]["failed"] > 0
       status |= 4 if @metrics["resources"]["failed_to_restart"] > 0
@@ -448,19 +455,19 @@ class Puppet::Transaction::Report
 
   # Mark the report as corrective, if there are any resource_status marked corrective.
   def calculate_report_corrective_change
-    @corrective_change = resource_statuses.any? do |name, status|
+    @corrective_change = resource_statuses.any? do |_name, status|
       status.corrective_change
     end
   end
 
   def calculate_change_metric
-    resource_statuses.map { |name, status| status.change_count || 0 }.inject(0) { |a,b| a+b }
+    resource_statuses.map { |_name, status| status.change_count || 0 }.inject(0) { |a, b| a + b }
   end
 
   def calculate_event_metrics
     metrics = Hash.new(0)
-    %w{total failure success}.each { |m| metrics[m] = 0 }
-    resource_statuses.each do |name, status|
+    %w[total failure success].each { |m| metrics[m] = 0 }
+    resource_statuses.each do |_name, status|
       metrics[TOTAL] += status.events.length
       status.events.each do |event|
         metrics[event.status] += 1
@@ -480,7 +487,7 @@ class Puppet::Transaction::Report
       metrics[state.to_s] = 0
     end
 
-    resource_statuses.each do |name, status|
+    resource_statuses.each do |_name, status|
       Puppet::Resource::Status::STATES.each do |state|
         metrics[state.to_s] += 1 if status.send(state)
       end
@@ -491,7 +498,7 @@ class Puppet::Transaction::Report
 
   def calculate_time_metrics
     metrics = Hash.new(0)
-    resource_statuses.each do |name, status|
+    resource_statuses.each do |_name, status|
       metrics[status.resource_type.downcase] += status.evaluation_time if status.evaluation_time
     end