openvox 7.37.1 → 8.19.0

data/lib/puppet/functions/epp.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Evaluates an Embedded Puppet (EPP) template file and returns the rendered text
 # result as a String.
 #
@@ -35,7 +37,6 @@
 # @since 4.0.0
 #
 Puppet::Functions.create_function(:epp, Puppet::Functions::InternalFunction) do
-
   dispatch :epp do
     scope_param
     param 'String', :path

data/lib/puppet/functions/err.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Logs a message on the server at level `err`.
 Puppet::Functions.create_function(:err, Puppet::Functions::InternalFunction) do
   # @param values The values to log.

data/lib/puppet/functions/eyaml_lookup_key.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # The `eyaml_lookup_key` is a hiera 5 `lookup_key` data provider function.
 # See [the configuration guide documentation](https://puppet.com/docs/puppet/latest/hiera_config_yaml_5.html#configuring-a-hierarchy-level-hiera-eyaml) for
 # how to use this function.
@@ -26,9 +28,9 @@ Puppet::Functions.create_function(:eyaml_lookup_key) do
     # Can't do this with an argument_mismatch dispatcher since there is no way to declare a struct that at least
     # contains some keys but may contain other arbitrary keys.
     unless options.include?('path')
-      #TRANSLATORS 'eyaml_lookup_key':, 'path', 'paths' 'glob', 'globs', 'mapped_paths', and lookup_key should not be translated
+      # TRANSLATORS 'eyaml_lookup_key':, 'path', 'paths' 'glob', 'globs', 'mapped_paths', and lookup_key should not be translated
       raise ArgumentError,
-        _("'eyaml_lookup_key': one of 'path', 'paths' 'glob', 'globs' or 'mapped_paths' must be declared in hiera.yaml"\
+            _("'eyaml_lookup_key': one of 'path', 'paths' 'glob', 'globs' or 'mapped_paths' must be declared in hiera.yaml"\
               " when using this lookup_key function")
     end
 
@@ -45,20 +47,19 @@ Puppet::Functions.create_function(:eyaml_lookup_key) do
   def load_data_hash(options, context)
     path = options['path']
     context.cached_file_data(path) do |content|
-      begin
-        data = Puppet::Util::Yaml.safe_load(content, [Symbol], path)
-        if data.is_a?(Hash)
-          Puppet::Pops::Lookup::HieraConfig.symkeys_to_string(data)
-        else
-          msg = _("%{path}: file does not contain a valid yaml hash") % { path: path }
-          raise Puppet::DataBinding::LookupError, msg if Puppet[:strict] == :error && data != false
-          Puppet.warning(msg)
-          {}
-        end
-      rescue Puppet::Util::Yaml::YamlLoadError => ex
-        # YamlLoadErrors include the absolute path to the file, so no need to add that
-        raise Puppet::DataBinding::LookupError, _("Unable to parse %{message}") % { message: ex.message }
+      data = Puppet::Util::Yaml.safe_load(content, [Symbol], path)
+      if data.is_a?(Hash)
+        Puppet::Pops::Lookup::HieraConfig.symkeys_to_string(data)
+      else
+        msg = _("%{path}: file does not contain a valid yaml hash") % { path: path }
+        raise Puppet::DataBinding::LookupError, msg if Puppet[:strict] == :error && data != false
+
+        Puppet.warning(msg)
+        {}
       end
+    rescue Puppet::Util::Yaml::YamlLoadError => ex
+      # YamlLoadErrors include the absolute path to the file, so no need to add that
+      raise Puppet::DataBinding::LookupError, _("Unable to parse %{message}") % { message: ex.message }
     end
   end
 
@@ -90,7 +91,7 @@ Puppet::Functions.create_function(:eyaml_lookup_key) do
         data = tokens.map(&:to_plain_text).join.chomp
       rescue StandardError => ex
         raise Puppet::DataBinding::LookupError,
-          _("hiera-eyaml backend error decrypting %{data} when looking up %{key} in %{path}. Error was %{message}") % { data: data, key: key, path: options['path'], message: ex.message }
+              _("hiera-eyaml backend error decrypting %{data} when looking up %{key} in %{path}. Error was %{message}") % { data: data, key: key, path: options['path'], message: ex.message }
       end
     end
     context.interpolate(data)

data/lib/puppet/functions/filter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Applies a [lambda](https://puppet.com/docs/puppet/latest/lang_lambdas.html)
 # to every value in a data structure and returns an array or hash containing any elements
 # for which the lambda evaluates to a truthy value (not `false` or `undef`).
@@ -92,16 +94,16 @@ Puppet::Functions.create_function(:filter) do
   end
 
   def filter_Hash_1(hash)
-    result = hash.select {|x, y| yield([x, y]) }
+    result = hash.select { |x, y| yield([x, y]) }
     # Ruby 1.8.7 returns Array
-    result = Hash[result] unless result.is_a? Hash
+    result = result.to_h unless result.is_a? Hash
     result
   end
 
   def filter_Hash_2(hash)
-    result = hash.select {|x, y| yield(x, y) }
+    result = hash.select { |x, y| yield(x, y) }
     # Ruby 1.8.7 returns Array
-    result = Hash[result] unless result.is_a? Hash
+    result = result.to_h unless result.is_a? Hash
     result
   end
 
@@ -121,8 +123,7 @@ Puppet::Functions.create_function(:filter) do
     enum = Puppet::Pops::Types::Iterable.asserted_iterable(self, enumerable)
     if enum.hash_style?
       result = {}
-      enum.each {| k, v| result[k] = v if yield(k, v) }
-      result
+      enum.each { |k, v| result[k] = v if yield(k, v) }
     else
       result = []
       begin
@@ -131,7 +132,7 @@ Puppet::Functions.create_function(:filter) do
         end
       rescue StopIteration
       end
-      result
     end
+    result
   end
 end

data/lib/puppet/functions/find_file.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Finds an existing file from a module and returns its path.
 #
 # This function accepts an argument that is a String as a `<MODULE NAME>/<FILE>`
@@ -5,6 +7,10 @@
 # directory. (For example, the reference `mysql/mysqltuner.pl` will search for the
 # file `<MODULES DIRECTORY>/mysql/files/mysqltuner.pl`.)
 #
+# If this function is run via puppet agent, it checks for file existence on the
+# Puppet Primary server. If run via puppet apply, it checks on the local host.
+# In both cases, the check is performed before any resources are changed.
+#
 # This function can also accept:
 #
 # * An absolute String path, which checks for the existence of a file from anywhere on disk.

data/lib/puppet/functions/find_template.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Finds an existing template from a module and returns its path.
 #
 # This function accepts an argument that is a String as a `<MODULE NAME>/<TEMPLATE>`

data/lib/puppet/functions/flatten.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Returns a flat Array produced from its possibly deeply nested given arguments.
 #
 # One or more arguments of any data type can be given to this function.

data/lib/puppet/functions/floor.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Returns the largest `Integer` less or equal to the argument.
 # Takes a single numeric value as an argument.
 #
@@ -24,7 +26,7 @@ Puppet::Functions.create_function(:floor) do
 
   def on_string(x)
     Puppet.warn_once('deprecations', 'floor_function_numeric_coerce_string',
-      _("The floor() function's auto conversion of String to Float is deprecated - change to convert input before calling"))
+                     _("The floor() function's auto conversion of String to Float is deprecated - change to convert input before calling"))
 
     begin
       Float(x).floor
@@ -33,5 +35,4 @@ Puppet::Functions.create_function(:floor) do
       raise(ArgumentError, _('floor(): cannot convert given value to a floating point value.'))
     end
   end
-
 end

data/lib/puppet/functions/get.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Digs into a value with dot notation to get a value from within a structure.
 #
 # **To dig into a given value**, call the function with (at least) two arguments:
@@ -131,12 +133,12 @@ Puppet::Functions.create_function(:get, Puppet::Functions::InternalFunction) do
     # like '0.1' the wanted result is `[0,1]`, not `["0", 1]`. The workaround here is to
     # prefix the navigation with `"x."` thus giving split_key a first segment that is a string.
     # The fake segment is then dropped.
-    segments = split_key("x." + navigation) {|err| _("Syntax error in dotted-navigation string")}
+    segments = split_key("x." + navigation) { |_err| _("Syntax error in dotted-navigation string") }
     segments.shift
 
     begin
       result = call_function('dig', value, *segments)
-      return result.nil? ? default_value : result
+      result.nil? ? default_value : result
     rescue Puppet::ErrorWithData => e
       if block_given?
         yield(e.error_data)

data/lib/puppet/functions/getvar.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Digs into a variable with dot notation to get a value from a structure.
 #
 # **To get the value from a variable** (that may or may not exist), call the function with
@@ -45,7 +47,7 @@
 Puppet::Functions.create_function(:getvar, Puppet::Functions::InternalFunction) do
   dispatch :get_from_navigation do
     scope_param
-     param 'Pattern[/\A(?:::)?(?:[a-z]\w*::)*[a-z_]\w*(?:\.|\Z)/]', :get_string
+    param 'Pattern[/\A(?:::)?(?:[a-z]\w*::)*[a-z_]\w*(?:\.|\Z)/]', :get_string
     optional_param 'Any', :default_value
     optional_block_param 'Callable[1,1]', :block
   end
@@ -56,7 +58,7 @@ Puppet::Functions.create_function(:getvar, Puppet::Functions::InternalFunction)
     optional_block_param 'Callable', :block
   end
 
-  def invalid_variable_error(navigation, default_value=nil, &block)
+  def invalid_variable_error(navigation, default_value = nil, &block)
     _("The given string does not start with a valid variable name")
   end
 
@@ -67,10 +69,10 @@ Puppet::Functions.create_function(:getvar, Puppet::Functions::InternalFunction)
     matches = navigation.match(/^((::)?(\w+::)*\w+)(.*)\z/)
     navigation = matches[4]
     if navigation[0] == '.'
-      navigation = navigation[1..-1]
+      navigation = navigation[1..]
     else
       unless navigation.empty?
-        raise ArgumentError, _("First character after var name in get string must be a '.' - got %{char}") % {char: navigation[0]}
+        raise ArgumentError, _("First character after var name in get string must be a '.' - got %{char}") % { char: navigation[0] }
       end
     end
     get_from_var_name(scope, matches[1], navigation, default_value, &block)
@@ -80,7 +82,7 @@ Puppet::Functions.create_function(:getvar, Puppet::Functions::InternalFunction)
   #
   def get_from_var_name(scope, var_string, navigation, default_value = nil, &block)
     catch(:undefined_variable) do
-      return call_function_with_scope(scope,'get', scope.lookupvar(var_string), navigation, default_value, &block)
+      return call_function_with_scope(scope, 'get', scope.lookupvar(var_string), navigation, default_value, &block)
     end
     default_value
   end

data/lib/puppet/functions/group_by.rb

@@ -49,8 +49,8 @@ Puppet::Functions.create_function(:group_by) do
       yield(k, v)
     end
 
-    grouped.each_with_object({}) do |(k, v), hsh|
-      hsh[k] = v.map { |item| item[1] }
+    grouped.transform_values do |v|
+      v.map { |item| item[1] }
     end.freeze
   end
 

data/lib/puppet/functions/hiera.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'hiera/puppet_function'
 
 # Performs a standard priority lookup of the hierarchy and returns the most specific value

data/lib/puppet/functions/hiera_array.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'hiera/puppet_function'
 
 # Finds all matches of a key throughout the hierarchy and returns them as a single flattened

data/lib/puppet/functions/hiera_hash.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'hiera/puppet_function'
 
 # Finds all matches of a key throughout the hierarchy and returns them in a merged hash.

data/lib/puppet/functions/hiera_include.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'hiera/puppet_function'
 
 # Assigns classes to a node using an
@@ -99,6 +101,7 @@ Puppet::Functions.create_function(:hiera_include, Hiera::PuppetFunction) do
 
   def post_lookup(scope, key, value)
     raise Puppet::ParseError, _("Could not find data item %{key}") % { key: key } if value.nil?
+
     call_function_with_scope(scope, 'include', value) unless value.empty?
   end
 end

data/lib/puppet/functions/hocon_data.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # The `hocon_data` is a hiera 5 `data_hash` data provider function.
 # See [the configuration guide documentation](https://puppet.com/docs/puppet/latest/hiera_config_yaml_5.html#configuring-a-hierarchy-level-built-in-backends) for
 # how to use this function.
@@ -27,11 +29,9 @@ Puppet::Functions.create_function(:hocon_data) do
   def hocon_data(options, context)
     path = options['path']
     context.cached_file_data(path) do |content|
-      begin
-        Hocon.parse(content)
-      rescue Hocon::ConfigError => ex
-        raise Puppet::DataBinding::LookupError, _("Unable to parse (%{path}): %{message}") % { path: path, message: ex.message }
-      end
+      Hocon.parse(content)
+    rescue Hocon::ConfigError => ex
+      raise Puppet::DataBinding::LookupError, _("Unable to parse (%{path}): %{message}") % { path: path, message: ex.message }
     end
   end
 

data/lib/puppet/functions/import.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 # The import function raises an error when called to inform the user that import is no longer supported.
 #
 Puppet::Functions.create_function(:import) do
   def import(*args)
-    raise Puppet::Pops::SemanticError.new(Puppet::Pops::Issues::DISCONTINUED_IMPORT)
+    raise Puppet::Pops::SemanticError, Puppet::Pops::Issues::DISCONTINUED_IMPORT
   end
 end

data/lib/puppet/functions/include.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Declares one or more classes, causing the resources in them to be
 # evaluated and added to the catalog. Accepts a class name, an array of class
 # names, or a comma-separated list of class names.
@@ -40,11 +42,12 @@ Puppet::Functions.create_function(:include, Puppet::Functions::InternalFunction)
     if Puppet[:tasks]
       raise Puppet::ParseErrorWithIssue.from_issue_and_stack(
         Puppet::Pops::Issues::CATALOG_OPERATION_NOT_SUPPORTED_WHEN_SCRIPTING,
-        {:operation => 'include'})
+        { :operation => 'include' }
+      )
     end
 
     classes = scope.transform_and_assert_classnames(classes.flatten)
-    result = classes.map {|name| Puppet::Pops::Types::TypeFactory.host_class(name) }
+    result = classes.map { |name| Puppet::Pops::Types::TypeFactory.host_class(name) }
     scope.compiler.evaluate_classes(classes, scope, false)
 
     # Result is an Array[Class, 1, n] which allows chaining other operations

data/lib/puppet/functions/index.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Returns the index (or key in a hash) to a first-found value in an `Iterable` value.
 #
 # When called with a  [lambda](https://puppet.com/docs/puppet/latest/lang_lambdas.html)
@@ -38,8 +40,8 @@
 # Note that the lambda gets the value and not an array with `[key, value]` as in other
 # iterative functions.
 #
-# Using a lambda that accepts two values works the same way, it simply gets the index/key 
-# as the first parameter, and the value as the second.
+# Using a lambda that accepts two values works the same way. The lambda gets the index/key
+# as the first parameter and the value as the second parameter.
 #
 # @example Using the `index` function with an Array and a two-parameter lambda
 #
@@ -120,9 +122,8 @@ Puppet::Functions.create_function(:index) do
     param 'Any', :match
   end
 
-
   def index_Hash_1(hash)
-    hash.each_pair { |x, y| return x if yield(y)  }
+    hash.each_pair { |x, y| return x if yield(y) }
     nil
   end
 

data/lib/puppet/functions/info.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Logs a message on the server at level `info`.
 Puppet::Functions.create_function(:info, Puppet::Functions::InternalFunction) do
   # @param values The values to log.

data/lib/puppet/functions/inline_epp.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Evaluates an Embedded Puppet (EPP) template string and returns the rendered
 # text result as a String.
 #
@@ -46,7 +48,6 @@
 # @since 4.0.0
 #
 Puppet::Functions.create_function(:inline_epp, Puppet::Functions::InternalFunction) do
-
   dispatch :inline_epp do
     scope_param()
     param 'String', :template

data/lib/puppet/functions/join.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Joins the values of an Array into a string with elements separated by a delimiter.
 #
 # Supports up to two arguments
@@ -28,7 +30,7 @@
 # be made.
 #
 # @example Joining the result of a reverse_each converted to an array
-# 
+#
 # ```puppet
 # [1,2,3].reverse_each.convert_to(Array).join(', ')
 # # would result in: "3, 2, 1"
@@ -51,6 +53,6 @@ Puppet::Functions.create_function(:join) do
   end
 
   def join(arg, delimiter = '', puppet_formatting = false)
-      arg.join(delimiter)
+    arg.join(delimiter)
   end
 end

data/lib/puppet/functions/json_data.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # The `json_data` is a hiera 5 `data_hash` data provider function.
 # See [the configuration guide documentation](https://puppet.com/docs/puppet/latest/hiera_config_yaml_5.html#configuring-a-hierarchy-level-built-in-backends) for
 # how to use this function.
@@ -18,12 +20,10 @@ Puppet::Functions.create_function(:json_data) do
   def json_data(options, context)
     path = options['path']
     context.cached_file_data(path) do |content|
-      begin
-        Puppet::Util::Json.load(content)
-      rescue Puppet::Util::Json::ParseError => ex
-        # Filename not included in message, so we add it here.
-        raise Puppet::DataBinding::LookupError, "Unable to parse (%{path}): %{message}" % { path: path, message: ex.message }
-      end
+      Puppet::Util::Json.load(content)
+    rescue Puppet::Util::Json::ParseError => ex
+      # Filename not included in message, so we add it here.
+      raise Puppet::DataBinding::LookupError, "Unable to parse (%{path}): %{message}" % { path: path, message: ex.message }
     end
   end
 

data/lib/puppet/functions/keys.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Returns the keys of a hash as an Array
 #
 # @example Using `keys`

data/lib/puppet/functions/length.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Returns the length of an Array, Hash, String, or Binary value.
 #
 # The returned value is a positive integer indicating the number
@@ -40,5 +42,4 @@ Puppet::Functions.create_function(:length) do
   def binary_length(bin)
     bin.length
   end
-
 end

data/lib/puppet/functions/lest.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Calls a [lambda](https://puppet.com/docs/puppet/latest/lang_lambdas.html)
 # without arguments if the value given to `lest` is `undef`.
 # Returns the result of calling the lambda if the argument is `undef`, otherwise the

data/lib/puppet/functions/lookup.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Uses the Puppet lookup system to retrieve a value for a given key. By default,
 # this returns the first value found (and fails compilation if no values are
 # available), but you can configure it to merge multiple values into one, fail
@@ -95,7 +97,7 @@
 # or `{'strategy' => 'hash'}` --- Same as the string versions of these merge behaviors.
 # * `{'strategy' => 'deep', <DEEP OPTION> => <VALUE>, ...}` --- Same as `'deep'`,
 # but can adjust the merge with additional options. The available options are:
-#     * `'knockout_prefix'` (string or undef) --- A string prefix to indicate a
+#     * `'knockout_prefix'` (string) --- A string prefix to indicate a
 #     value should be _removed_ from the final result. If a value is exactly equal
 #     to the prefix, it will knockout the entire element. Defaults to `undef`, which
 #     disables this feature.
@@ -123,7 +125,6 @@
 #
 # @since 4.0.0
 Puppet::Functions.create_function(:lookup, Puppet::Functions::InternalFunction) do
-
   local_types do
     type 'NameType         = Variant[String, Array[String]]'
     type 'ValueType        = Type'
@@ -145,7 +146,6 @@ Puppet::Functions.create_function(:lookup, Puppet::Functions::InternalFunction)
       default_values_hash => Optional[Hash[String,Any]],\
       merge               => Optional[MergeType]\
     }]"
-
   end
 
   dispatch :lookup_1 do
@@ -186,7 +186,7 @@ Puppet::Functions.create_function(:lookup, Puppet::Functions::InternalFunction)
     optional_block_param 'BlockType',                     :block
   end
 
-  def lookup_1(scope, name, value_type=nil, merge=nil)
+  def lookup_1(scope, name, value_type = nil, merge = nil)
     do_lookup(scope, name, value_type, nil, false, {}, {}, merge)
   end
 
@@ -194,7 +194,7 @@ Puppet::Functions.create_function(:lookup, Puppet::Functions::InternalFunction)
     do_lookup(scope, name, value_type, default_value, true, {}, {}, merge)
   end
 
-  def lookup_3(scope, name, value_type=nil, merge=nil, &block)
+  def lookup_3(scope, name, value_type = nil, merge = nil, &block)
     do_lookup(scope, name, value_type, nil, false, {}, {}, merge, &block)
   end
 
@@ -208,17 +208,17 @@ Puppet::Functions.create_function(:lookup, Puppet::Functions::InternalFunction)
 
   def do_lookup(scope, name, value_type, default_value, has_default, override, default_values_hash, merge, &block)
     Puppet::Pops::Lookup.lookup(name, value_type, default_value, has_default, merge,
-      Puppet::Pops::Lookup::Invocation.new(scope, override, default_values_hash), &block)
+                                Puppet::Pops::Lookup::Invocation.new(scope, override, default_values_hash), &block)
   end
 
   def hash_args(options_hash)
     [
-        options_hash['value_type'],
-        options_hash['default_value'],
-        options_hash.include?('default_value'),
-        options_hash['override'] || {},
-        options_hash['default_values_hash'] || {},
-        options_hash['merge']
+      options_hash['value_type'],
+      options_hash['default_value'],
+      options_hash.include?('default_value'),
+      options_hash['override'] || {},
+      options_hash['default_values_hash'] || {},
+      options_hash['merge']
     ]
   end
 end

data/lib/puppet/functions/lstrip.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Strips leading spaces from a String
 #
 # This function is compatible with the stdlib function with the same name.
@@ -25,7 +27,6 @@
 # Would both result in `['hello', 'hi']`
 #
 Puppet::Functions.create_function(:lstrip) do
-
   dispatch :on_numeric do
     param 'Numeric', :arg
   end
@@ -48,7 +49,7 @@ Puppet::Functions.create_function(:lstrip) do
   end
 
   def on_iterable(a)
-    a.map {|x| do_lstrip(x) }
+    a.map { |x| do_lstrip(x) }
   end
 
   def do_lstrip(x)

data/lib/puppet/functions/map.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Applies a [lambda](https://puppet.com/docs/puppet/latest/lang_lambdas.html)
 # to every value in a data structure and returns an array containing the results.
 #
@@ -90,7 +92,7 @@ Puppet::Functions.create_function(:map) do
   def map_Hash_1(hash)
     result = []
     begin
-      hash.each {|x, y| result << yield([x, y]) }
+      hash.each { |x, y| result << yield([x, y]) }
     rescue StopIteration
     end
     result
@@ -99,7 +101,7 @@ Puppet::Functions.create_function(:map) do
   def map_Hash_2(hash)
     result = []
     begin
-      hash.each {|x, y| result << yield(x, y) }
+      hash.each { |x, y| result << yield(x, y) }
     rescue StopIteration
     end
     result

data/lib/puppet/functions/match.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Matches a regular expression against a string and returns an array containing the match
 # and any matched capturing groups.
 #
@@ -53,7 +55,7 @@ Puppet::Functions.create_function(:match) do
     # a puppet runtime (where this function is) without a reboot. If you model a function in a module after
     # this class, use a regular instance variable instead to enable reloading of the module without reboot
     #
-    @@match_visitor   ||= Puppet::Pops::Visitor.new(self, "match", 1, 1)
+    @@match_visitor ||= Puppet::Pops::Visitor.new(self, "match", 1, 1)
   end
 
   # Matches given string against given pattern and returns an Array with matches.
@@ -72,7 +74,7 @@ Puppet::Functions.create_function(:match) do
   # @return [Array<Array<String, nil>>] Array with matches (see {#match}), non matching entries produce a nil entry
   #
   def enumerable_match(array, pattern)
-    array.map {|s| match(s, pattern) }
+    array.map { |s| match(s, pattern) }
   end
 
   protected
@@ -97,12 +99,13 @@ Puppet::Functions.create_function(:match) do
   def match_PVariantType(var_t, s)
     # Find first matching type (or error out if one of the variants is not acceptable)
     result = nil
-    var_t.types.find {|t| result = match(s, t) }
+    var_t.types.find { |t| result = match(s, t) }
     result
   end
 
   def match_PRegexpType(regexp_t, s)
     raise ArgumentError, _("Given Regexp Type has no regular expression") unless regexp_t.pattern
+
     do_match(s, regexp_t.regexp)
   end
 
@@ -110,14 +113,14 @@ Puppet::Functions.create_function(:match) do
     # Since we want the actual match result (not just a boolean), an iteration over
     # Pattern's regular expressions is needed. (They are of PRegexpType)
     result = nil
-    pattern_t.patterns.find {|pattern| result = match(s, pattern) }
+    pattern_t.patterns.find { |pattern| result = match(s, pattern) }
     result
   end
 
   # Returns the first matching entry
   def match_Array(array, s)
     result = nil
-    array.flatten.find {|entry| result = match(s, entry) }
+    array.flatten.find { |entry| result = match(s, entry) }
     result
   end