fastlane 2.74.1 → 2.75.0.beta.20180109010003

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6a5ac60afa25f9506150a2183d757b025a89ef46
-  data.tar.gz: 531753b83e8e41548f21d718500c7cfb7fa35416
+  metadata.gz: 068043183fb1c67f72a848d2c925a7459802ba1d
+  data.tar.gz: 8e7d05dec8d9dc85f93fb78c5dc60180fd686770
 SHA512:
-  metadata.gz: cf27686d4198832d92745fc2aab01ff257dc4b15b1d6a41018a006450889674757d333f1c559a6845fcfacb433e55cf55e3652adbe920e20383a7bfefb1d0191
-  data.tar.gz: 6cc2f76c6ac122182ad4ab05a3c5488ef6c814dfbb0989417d4c64955084a52e2e4663f17b7f059f9ba40f9a29db748249f497657d249564f3ad2a8ce1657613
+  metadata.gz: 04131a7558ce3285bb43529bdf19a783729f1d58d81c49197e27da9359e87afc7202f55cadb3d969815c2fb16129370ffa2cfd96bf08a9df0c5382d3de2948a2
+  data.tar.gz: 2b4aa1e49fff2b5839f4c4eff2d4ba0aec1b2a91b8981443829a1911519ae7cb1154b15fb38c575bafccbb4dc29aca8d185be05d96634519d75fa591e2a3415d

data/bin/bin-proxy

@@ -7,8 +7,8 @@ tool_name = File.basename($0)
 
 full_params = ARGV.shelljoin
 
-puts "[WARNING] You are calling #{tool_name} directly. Usage of the tool name without the `fastlane` prefix is deprecated in fastlane 2.0".yellow
-puts "Please update your scripts to use `fastlane #{tool_name} #{full_params}` instead.".yellow
+puts("[WARNING] You are calling #{tool_name} directly. Usage of the tool name without the `fastlane` prefix is deprecated in fastlane 2.0".yellow)
+puts("Please update your scripts to use `fastlane #{tool_name} #{full_params}` instead.".yellow)
 
 exec_arr = ["fastlane", tool_name] + ARGV
 

data/bin/fastlane

@@ -1,10 +1,10 @@
 #!/usr/bin/env ruby
 
 if RUBY_VERSION < '2.0.0'
-  abort "fastlane requires Ruby 2.0.0 or higher"
+  abort("fastlane requires Ruby 2.0.0 or higher")
 end
 
-$LOAD_PATH.push File.expand_path("../../lib", __FILE__)
+$LOAD_PATH.push(File.expand_path("../../lib", __FILE__))
 
 require "fastlane/cli_tools_distributor"
 
@@ -12,9 +12,9 @@ if Fastlane::CLIToolsDistributor.running_version_command?
   # This will print out the fastlane binary path right above the
   # version number. Very often, users are not aware they have
   # e.g. bundled fastlane installed
-  puts "fastlane installation at path:"
-  puts File.expand_path(__FILE__)
-  puts "-----------------------------"
+  puts("fastlane installation at path:")
+  puts(File.expand_path(__FILE__))
+  puts("-----------------------------")
 end
 
 Fastlane::CLIToolsDistributor.take_off

data/cert/lib/cert/commands_generator.rb

@@ -51,7 +51,7 @@ module Cert
         end
       end
 
-      default_command :create
+      default_command(:create)
 
       run!
     end

data/cert/lib/cert/runner.rb

@@ -13,17 +13,17 @@ module Cert
       run
 
       installed = FastlaneCore::CertChecker.installed?(ENV["CER_FILE_PATH"])
-      UI.message "Verifying the certificate is properly installed locally..."
+      UI.message("Verifying the certificate is properly installed locally...")
       UI.user_error!("Could not find the newly generated certificate installed", show_github_issues: true) unless installed
-      UI.success "Successfully installed certificate #{ENV['CER_CERTIFICATE_ID']}"
+      UI.success("Successfully installed certificate #{ENV['CER_CERTIFICATE_ID']}")
       return ENV["CER_FILE_PATH"]
     end
 
     def login
-      UI.message "Starting login with user '#{Cert.config[:username]}'"
+      UI.message("Starting login with user '#{Cert.config[:username]}'")
       Spaceship.login(Cert.config[:username], nil)
       Spaceship.select_team
-      UI.message "Successfully logged in"
+      UI.message("Successfully logged in")
     end
 
     def run
@@ -57,7 +57,7 @@ module Cert
       to_revoke = expired_certs
 
       if to_revoke.empty?
-        UI.success "No expired certificates were found to revoke! 👍"
+        UI.success("No expired certificates were found to revoke! 👍")
         return
       end
 
@@ -65,16 +65,16 @@ module Cert
 
       to_revoke.each do |certificate|
         begin
-          UI.message "#{certificate.id} #{certificate.name} has expired, revoking..."
+          UI.message("#{certificate.id} #{certificate.name} has expired, revoking...")
           certificate.revoke!
           revoke_count += 1
         rescue => e
-          UI.error "An error occurred while revoking #{certificate.id} #{certificate.name}"
-          UI.error "#{e.message}\n#{e.backtrace.join("\n")}" if FastlaneCore::Globals.verbose?
+          UI.error("An error occurred while revoking #{certificate.id} #{certificate.name}")
+          UI.error("#{e.message}\n#{e.backtrace.join("\n")}") if FastlaneCore::Globals.verbose?
         end
       end
 
-      UI.success "#{revoke_count} expired certificate#{'s' if revoke_count != 1} #{revoke_count == 1 ? 'has' : 'have'} been revoked! 👍"
+      UI.success("#{revoke_count} expired certificate#{'s' if revoke_count != 1} #{revoke_count == 1 ? 'has' : 'have'} been revoked! 👍")
     end
 
     def expired_certs
@@ -97,7 +97,7 @@ module Cert
           ENV["CER_CERTIFICATE_ID"] = certificate.id
           ENV["CER_FILE_PATH"] = path
 
-          UI.success "Found the certificate #{certificate.id} (#{certificate.name}) which is installed on the local machine. Using this one."
+          UI.success("Found the certificate #{certificate.id} (#{certificate.name}) which is installed on the local machine. Using this one.")
 
           return path
         elsif File.exist?(private_key_path)
@@ -109,17 +109,17 @@ module Cert
           ENV["CER_CERTIFICATE_ID"] = certificate.id
           ENV["CER_FILE_PATH"] = path
 
-          UI.success "Found the cached certificate #{certificate.id} (#{certificate.name}). Using this one."
+          UI.success("Found the cached certificate #{certificate.id} (#{certificate.name}). Using this one.")
 
           return path
         else
-          UI.error "Certificate #{certificate.id} (#{certificate.name}) can't be found on your local computer"
+          UI.error("Certificate #{certificate.id} (#{certificate.name}) can't be found on your local computer")
         end
 
         File.delete(path) # as apparently this certificate is pretty useless without a private key
       end
 
-      UI.important "Couldn't find an existing certificate... creating a new one"
+      UI.important("Couldn't find an existing certificate... creating a new one")
       return nil
     end
 
@@ -182,7 +182,7 @@ module Cert
       ENV["CER_CERTIFICATE_ID"] = certificate.id
       ENV["CER_FILE_PATH"] = cert_path
 
-      UI.success "Successfully generated #{certificate.id} which was imported to the local machine."
+      UI.success("Successfully generated #{certificate.id} which was imported to the local machine.")
 
       return cert_path
     end

data/credentials_manager/lib/credentials_manager/account_manager.rb

@@ -57,16 +57,16 @@ module CredentialsManager
     # @param force: if false, the user is asked before it gets deleted
     # @return: Did the user decide to remove the old entry and enter a new password?
     def invalid_credentials(force: false)
-      puts "The login credentials for '#{user}' seem to be wrong".red
+      puts("The login credentials for '#{user}' seem to be wrong".red)
 
       if fetch_password_from_env
-        puts "The password was taken from the environment variable"
-        puts "Please make sure it is correct"
+        puts("The password was taken from the environment variable")
+        puts("Please make sure it is correct")
         return false
       end
 
       if force || agree("Do you want to re-enter your password? (y/n)", true)
-        puts "Removing Keychain entry for user '#{user}'...".yellow
+        puts("Removing Keychain entry for user '#{user}'...".yellow)
         remove_from_keychain
         ask_for_login
         return true
@@ -104,16 +104,16 @@ module CredentialsManager
     private
 
     def ask_for_login
-      puts "-------------------------------------------------------------------------------------".green
-      puts "Please provide your Apple Developer Program account credentials".green
-      puts "The login information you enter will be stored in your macOS Keychain".green
+      puts("-------------------------------------------------------------------------------------".green)
+      puts("Please provide your Apple Developer Program account credentials".green)
+      puts("The login information you enter will be stored in your macOS Keychain".green)
       if default_prefix?
         # We don't want to show this message, if we ask for the application specific password
         # which has a different prefix
-        puts "You can also pass the password using the `FASTLANE_PASSWORD` environment variable".green
-        puts "More information about it on GitHub: https://github.com/fastlane/fastlane/tree/master/credentials_manager".green
+        puts("You can also pass the password using the `FASTLANE_PASSWORD` environment variable".green)
+        puts("More information about it on GitHub: https://github.com/fastlane/fastlane/tree/master/credentials_manager".green)
       end
-      puts "-------------------------------------------------------------------------------------".green
+      puts("-------------------------------------------------------------------------------------".green)
 
       if @user.to_s.length == 0
         raise "Missing username, and running in non-interactive shell" if $stdout.isatty == false
@@ -138,7 +138,7 @@ module CredentialsManager
       if add_to_keychain
         return true
       else
-        puts "Could not store password in keychain".red
+        puts("Could not store password in keychain".red)
         return false
       end
     end

data/credentials_manager/lib/credentials_manager/appfile_config.rb

@@ -9,7 +9,7 @@ module CredentialsManager
       begin
         return self.new.data[key]
       rescue => ex
-        puts ex.to_s
+        puts(ex.to_s)
         return nil
       end
       nil
@@ -17,7 +17,7 @@ module CredentialsManager
 
     def self.default_path
       ["./fastlane/Appfile", "./.fastlane/Appfile", "./Appfile"].each do |current|
-        return current if File.exist? current
+        return current if File.exist?(current)
       end
       nil
     end
@@ -36,10 +36,10 @@ module CredentialsManager
 
           # From https://github.com/orta/danger/blob/master/lib/danger/Dangerfile.rb
           if content.tr!('“”‘’‛', %(""'''))
-            puts "Your #{File.basename(path)} has had smart quotes sanitised. " \
+            puts("Your #{File.basename(path)} has had smart quotes sanitised. " \
                  'To avoid issues in the future, you should not use ' \
                  'TextEdit for editing it. If you are not using TextEdit, ' \
-                 'you should turn off smart quotes in your editor of choice.'.red
+                 'you should turn off smart quotes in your editor of choice.'.red)
           end
 
           # rubocop:disable Security/Eval
@@ -60,12 +60,12 @@ module CredentialsManager
       # this is necessary, as on the course of a fastlane run, the values might change, e.g. when using
       # the `for_lane` keyword.
 
-      puts "Successfully loaded Appfile at path '#{path}'".yellow
+      puts("Successfully loaded Appfile at path '#{path}'".yellow)
 
       self.data.each do |key, value|
-        puts "- #{key.to_s.cyan}: '#{value.to_s.green}'"
+        puts("- #{key.to_s.cyan}: '#{value.to_s.green}'")
       end
-      puts "-------"
+      puts("-------")
 
       self.class.already_printed_debug_information[self.data] = true
     end
@@ -129,7 +129,7 @@ module CredentialsManager
     end
 
     def issuer(*args, &block)
-      puts "Appfile: DEPRECATED issuer: use json_key_file instead".red
+      puts("Appfile: DEPRECATED issuer: use json_key_file instead".red)
       setter(:issuer, *args, &block)
     end
 
@@ -138,7 +138,7 @@ module CredentialsManager
     end
 
     def keyfile(*args, &block)
-      puts "Appfile: DEPRECATED keyfile: use json_key_file instead".red
+      puts("Appfile: DEPRECATED keyfile: use json_key_file instead".red)
       setter(:keyfile, *args, &block)
     end
 
@@ -152,8 +152,8 @@ module CredentialsManager
     def for_lane(lane_name)
       if lane_name.to_s.split(" ").count > 1
         # That's the legacy syntax 'platform name'
-        puts "You use deprecated syntax '#{lane_name}' in your Appfile.".yellow
-        puts "Please follow the Appfile guide: https://docs.fastlane.tools/advanced/#appfile".yellow
+        puts("You use deprecated syntax '#{lane_name}' in your Appfile.".yellow)
+        puts("Please follow the Appfile guide: https://docs.fastlane.tools/advanced/#appfile".yellow)
         platform, lane_name = lane_name.split(" ")
 
         return unless platform == ENV["FASTLANE_PLATFORM_NAME"]

data/credentials_manager/lib/credentials_manager/cli.rb

@@ -17,8 +17,8 @@ module CredentialsManager
         c.syntax = 'fastlane fastlane-credentials add'
         c.description = 'Adds a fastlane credential to the keychain.'
 
-        c.option '--username username', String, 'Username to add.'
-        c.option '--password password', String, 'Password to add.'
+        c.option('--username username', String, 'Username to add.')
+        c.option('--password password', String, 'Password to add.')
 
         c.action do |args, options|
           username = options.username || ask('Username: ')
@@ -26,7 +26,7 @@ module CredentialsManager
 
           add(username, password)
 
-          puts "Credential #{username}:#{'*' * password.length} added to keychain."
+          puts("Credential #{username}:#{'*' * password.length} added to keychain.")
         end
       end
 
@@ -35,7 +35,7 @@ module CredentialsManager
         c.syntax = 'fastlane fastlane-credentials remove'
         c.description = 'Removes a fastlane credential from the keychain.'
 
-        c.option '--username username', String, 'Username to remove.'
+        c.option('--username username', String, 'Username to remove.')
 
         c.action do |args, options|
           username = options.username || ask('Username: ')

data/deliver/lib/deliver/app_screenshot.rb

@@ -19,6 +19,8 @@ module Deliver
       IOS_58 = "iOS-5.8-in"
       # iPad
       IOS_IPAD = "iOS-iPad"
+      # iPad 10.5
+      IOS_IPAD_10_5 = "iOS-iPad-10.5"
       # iPad Pro
       IOS_IPAD_PRO = "iOS-iPad-Pro"
       # iPhone 5 iMessage
@@ -31,6 +33,8 @@ module Deliver
       IOS_58_MESSAGES = "iOS-5.8-in-messages"
       # iPad iMessage
       IOS_IPAD_MESSAGES = "iOS-iPad-messages"
+      # iPad 10.5 iMessage
+      IOS_IPAD_10_5_MESSAGES = "iOS-10.5-messages"
       # iPad Pro iMessage
       IOS_IPAD_PRO_MESSAGES = "iOS-iPad-Pro-messages"
       # Apple Watch
@@ -72,6 +76,7 @@ module Deliver
         ScreenSize::IOS_55 => "iphone6Plus",
         ScreenSize::IOS_58 => "iphone58",
         ScreenSize::IOS_IPAD => "ipad",
+        ScreenSize::IOS_IPAD_10_5 => "ipad105",
         ScreenSize::IOS_IPAD_PRO => "ipadPro",
         ScreenSize::IOS_40_MESSAGES => "iphone4",
         ScreenSize::IOS_47_MESSAGES => "iphone6",
@@ -79,6 +84,7 @@ module Deliver
         ScreenSize::IOS_58_MESSAGES => "iphone58",
         ScreenSize::IOS_IPAD_MESSAGES => "ipad",
         ScreenSize::IOS_IPAD_PRO_MESSAGES => "ipadPro",
+        ScreenSize::IOS_IPAD_10_5_MESSAGES => "ipad105",
         ScreenSize::MAC => "desktop",
         ScreenSize::IOS_APPLE_WATCH => "watch",
         ScreenSize::APPLE_TV => "appleTV"
@@ -95,6 +101,7 @@ module Deliver
         ScreenSize::IOS_55 => "iPhone 6 Plus",
         ScreenSize::IOS_58 => "iPhone X",
         ScreenSize::IOS_IPAD => "iPad",
+        ScreenSize::IOS_IPAD_10_5 => "iPad 10.5",
         ScreenSize::IOS_IPAD_PRO => "iPad Pro",
         ScreenSize::IOS_40_MESSAGES => "iPhone 5 (iMessage)",
         ScreenSize::IOS_47_MESSAGES => "iPhone 6 (iMessage)",
@@ -102,6 +109,7 @@ module Deliver
         ScreenSize::IOS_58_MESSAGES => "iPhone X (iMessage)",
         ScreenSize::IOS_IPAD_MESSAGES => "iPad (iMessage)",
         ScreenSize::IOS_IPAD_PRO_MESSAGES => "iPad Pro (iMessage)",
+        ScreenSize::IOS_IPAD_10_5_MESSAGES => "iPad 10.5 (iMessage)",
         ScreenSize::MAC => "Mac",
         ScreenSize::IOS_APPLE_WATCH => "Watch",
         ScreenSize::APPLE_TV => "Apple TV"
@@ -123,7 +131,8 @@ module Deliver
         ScreenSize::IOS_55_MESSAGES,
         ScreenSize::IOS_58_MESSAGES,
         ScreenSize::IOS_IPAD_MESSAGES,
-        ScreenSize::IOS_IPAD_PRO_MESSAGES
+        ScreenSize::IOS_IPAD_PRO_MESSAGES,
+        ScreenSize::IOS_IPAD_10_5_MESSAGES
       ].include?(self.screen_size)
     end
 
@@ -154,6 +163,10 @@ module Deliver
           [1536, 2008],
           [1536, 2048]
         ],
+        ScreenSize::IOS_IPAD_10_5_MESSAGES => [
+          [1668, 2224],
+          [2224, 1668]
+        ],
         ScreenSize::IOS_IPAD_PRO_MESSAGES => [
           [2732, 2048],
           [2048, 2732]
@@ -193,6 +206,10 @@ module Deliver
           [1536, 2008],
           [1536, 2048]
         ],
+        ScreenSize::IOS_IPAD_10_5 => [
+          [1668, 2224],
+          [2224, 1668]
+        ],
         ScreenSize::IOS_IPAD_PRO => [
           [2732, 2048],
           [2048, 2732]
@@ -219,7 +236,7 @@ module Deliver
 
       # Walk up two directories and test if we need to handle a platform that doesn't support landscape
       path_component = Pathname.new(path).each_filename.to_a[-3]
-      if path_component.eql? "appleTV"
+      if path_component.eql?("appleTV")
         skip_landscape = true
       end
 

data/deliver/lib/deliver/commands_generator.rb

@@ -128,7 +128,7 @@ module Deliver
           options.load_configuration_file("Deliverfile")
           Deliver::Runner.new(options)
           html_path = Deliver::GenerateSummary.new.run(options)
-          UI.success "Successfully generated HTML report at '#{html_path}'"
+          UI.success("Successfully generated HTML report at '#{html_path}'")
           system("open '#{html_path}'") unless options[:force]
         end
       end
@@ -177,7 +177,7 @@ module Deliver
         end
       end
 
-      default_command :run
+      default_command(:run)
 
       run!
     end

data/deliver/lib/deliver/loader.rb

@@ -43,9 +43,9 @@ module Deliver
 
       if !ignore_validation && !rejected_folders.empty?
         rejected_folders = rejected_folders.map { |path| File.basename(path) }
-        UI.user_error! "Unsupported directory name(s) for screenshots/metadata in '#{root}': #{rejected_folders.join(', ')}" \
+        UI.user_error!("Unsupported directory name(s) for screenshots/metadata in '#{root}': #{rejected_folders.join(', ')}" \
                        "\nValid directory names are: #{allowed_directory_names_with_case}" \
-                       "\n\nEnable 'ignore_language_directory_validation' to prevent this validation from happening"
+                       "\n\nEnable 'ignore_language_directory_validation' to prevent this validation from happening")
       end
 
       selected_folders

data/deliver/lib/deliver/options.rb

@@ -74,7 +74,7 @@ module Deliver
                                      optional: true,
                                      default_value: "ios",
                                      verify_block: proc do |value|
-                                       UI.user_error!("The platform can only be ios, appletvos, or osx") unless %('ios', 'appletvos', 'osx').include? value
+                                       UI.user_error!("The platform can only be ios, appletvos, or osx") unless %('ios', 'appletvos', 'osx').include?(value)
                                      end),
         FastlaneCore::ConfigItem.new(key: :metadata_path,
                                      short_option: '-m',
@@ -152,7 +152,7 @@ module Deliver
                                      optional: true,
                                      verify_block: proc do |value|
                                        UI.user_error!("Could not find config file at path '#{File.expand_path(value)}'") unless File.exist?(value)
-                                       UI.user_error! "'#{value}' doesn't seem to be a JSON file" unless FastlaneCore::Helper.json_file?(File.expand_path(value))
+                                       UI.user_error!("'#{value}' doesn't seem to be a JSON file") unless FastlaneCore::Helper.json_file?(File.expand_path(value))
                                      end),
         FastlaneCore::ConfigItem.new(key: :submission_information,
                                      short_option: "-b",

data/deliver/lib/deliver/setup.rb

@@ -28,7 +28,7 @@ module Deliver
         download_screenshots(deliver_path, options)
 
         # Add a README to the screenshots folder
-        FileUtils.mkdir_p File.join(deliver_path, 'screenshots') # just in case the fetching didn't work
+        FileUtils.mkdir_p(File.join(deliver_path, 'screenshots')) # just in case the fetching didn't work
         File.write(File.join(deliver_path, 'screenshots', 'README.txt'), File.read("#{Deliver::ROOT}/lib/assets/ScreenshotsHelp"))
       end