fastlane 2.74.1 → 2.75.0.beta.20180109010003

data/fastlane/lib/fastlane/plugins/plugin_update_manager.rb

@@ -41,14 +41,14 @@ module Fastlane
         return
       end
 
-      puts Terminal::Table.new({
+      puts(Terminal::Table.new({
         rows: FastlaneCore::PrintTable.transform_output(rows),
         title: "Plugin updates available".yellow,
         headings: ["Plugin", "Your Version", "Latest Version"]
-      })
-      UI.message "To update all plugins, just run"
+      }))
+      UI.message("To update all plugins, just run")
       UI.command "bundle exec fastlane update_plugins"
-      puts ''
+      puts('')
       @server_results = nil
     end
 

data/fastlane/lib/fastlane/plugins/template/%gem_name%.gemspec.erb

@@ -23,12 +23,13 @@ Gem::Specification.new do |spec|
 
   # spec.add_dependency 'your-dependency', '~> 1.0.0'
 
-  spec.add_development_dependency 'pry'
-  spec.add_development_dependency 'bundler'
-  spec.add_development_dependency 'rspec'
-  spec.add_development_dependency 'rspec_junit_formatter'
-  spec.add_development_dependency 'rake'
-  spec.add_development_dependency 'rubocop', '<%= Fastlane::RUBOCOP_REQUIREMENT %>'
-  spec.add_development_dependency 'simplecov'
-  spec.add_development_dependency 'fastlane', '>= <%= Fastlane::VERSION %>'
+  spec.add_development_dependency('pry')
+  spec.add_development_dependency('bundler')
+  spec.add_development_dependency('rspec')
+  spec.add_development_dependency('rspec_junit_formatter')
+  spec.add_development_dependency('rake')
+  spec.add_development_dependency('rubocop', '<%= Fastlane::RUBOCOP_REQUIREMENT %>')
+  spec.add_development_dependency('rubocop-require_tools')
+  spec.add_development_dependency('simplecov')
+  spec.add_development_dependency('fastlane', '>= <%= Fastlane::VERSION %>')
 end

data/fastlane/lib/fastlane/plugins/template/.rubocop.yml

@@ -1,3 +1,6 @@
+require: 
+  - rubocop/require_tools
+
 Style/MultipleComparison:
   Enabled: false
 
@@ -83,6 +86,20 @@ Lint/UselessAssignment:
   Exclude:
     - '**/spec/**/*'
 
+# In specs requires are done automatically
+Require/MissingRequireStatement:
+  Exclude:
+    - '**/spec/**/*.rb'
+    - '**/spec_helper.rb'
+    - 'spaceship/lib/spaceship/babosa_fix.rb'
+    - '**/Fastfile'
+    - '**/*.gemspec'
+    - 'rakelib/**/*'
+    - '**/*.rake'
+    - '**/Rakefile'
+    - 'fastlane/**/*' # TODO: remove
+    - 'supply/**/*' # TODO: remove
+
 # We could potentially enable the 2 below:
 Layout/IndentHash:
   Enabled: false
@@ -262,5 +279,23 @@ Style/IfInsideElse:
 Style/CollectionMethods:
   Enabled: false
 
-Lint/UnneededDisable:
-  Enabled: false
+# ( ) for method calls
+Style/MethodCallWithArgsParentheses:
+  Enabled: true
+  IgnoredMethods:
+    - 'require'
+    - 'require_relative'
+    - 'gem'
+    - 'program'
+    - 'command'
+    - 'raise'
+    - 'attr_accessor'
+    - 'attr_reader'
+    - 'lane'
+    # rspec tests code below
+    - 'to'
+    - 'describe'
+    - 'it'
+    - 'context'
+    - 'before'
+    - 'after'

data/fastlane/lib/fastlane/plugins/template/Gemfile

@@ -1,4 +1,4 @@
-source 'https://rubygems.org'
+source('https://rubygems.org')
 
 gemspec
 

data/fastlane/lib/fastlane/plugins/template/Rakefile

@@ -6,4 +6,4 @@ RSpec::Core::RakeTask.new
 require 'rubocop/rake_task'
 RuboCop::RakeTask.new(:rubocop)
 
-task default: [:spec, :rubocop]
+task(default: [:spec, :rubocop])

data/fastlane/lib/fastlane/plugins/template/lib/fastlane/plugin/%plugin_name%/actions/%plugin_name%_action.rb.erb

@@ -1,3 +1,6 @@
+require 'fastlane/action'
+require_relative '../helper/<%= plugin_name %>_helper'
+
 module Fastlane
   module Actions
     class <%= plugin_name.fastlane_class %>Action < Action

data/fastlane/lib/fastlane/plugins/template/lib/fastlane/plugin/%plugin_name%/helper/%plugin_name%_helper.rb.erb

@@ -1,4 +1,8 @@
+require 'fastlane_core/ui/ui'
+
 module Fastlane
+  UI = FastlaneCore::UI unless Fastlane.const_defined?("UI")
+
   module Helper
     class <%= plugin_name.fastlane_class %>Helper
       # class methods that you define here become available in your action

data/fastlane/lib/fastlane/plugins/template/spec/spec_helper.rb.erb

@@ -1,4 +1,4 @@
-$LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
+$LOAD_PATH.unshift(File.expand_path('../../lib', __FILE__))
 
 require 'simplecov'
 

data/fastlane/lib/fastlane/runner.rb

@@ -35,7 +35,7 @@ module Fastlane
       Actions.lane_context[Actions::SharedValues::PLATFORM_NAME] = current_platform
       Actions.lane_context[Actions::SharedValues::LANE_NAME] = full_lane_name
 
-      UI.success "Driving the lane '#{full_lane_name}' 🚀"
+      UI.success("Driving the lane '#{full_lane_name}' 🚀")
 
       return_val = nil
 
@@ -186,14 +186,14 @@ module Fastlane
         original_full = full_lane_name
         original_lane = current_lane
 
-        UI.user_error!("Parameters for a lane must always be a hash") unless (parameters.first || {}).kind_of? Hash
+        UI.user_error!("Parameters for a lane must always be a hash") unless (parameters.first || {}).kind_of?(Hash)
 
         execute_flow_block(before_each_blocks, current_platform, new_lane, parameters)
 
         pretty = [new_lane]
         pretty = [current_platform, new_lane] if current_platform
         Actions.execute_action("Switch to #{pretty.join(' ')} lane") {} # log the action
-        UI.message "Cruising over to lane '#{pretty.join(' ')}' 🚖"
+        UI.message("Cruising over to lane '#{pretty.join(' ')}' 🚖")
 
         # Actually switch lane now
         self.current_lane = new_lane
@@ -205,7 +205,7 @@ module Fastlane
         # Call the platform specific after block and then the general one
         execute_flow_block(after_each_blocks, current_platform, new_lane, parameters)
 
-        UI.message "Cruising back to lane '#{original_full}' 🚘"
+        UI.message("Cruising back to lane '#{original_full}' 🚘")
         return result
       else
         raise LaneNotAvailableError.new, "Lane not found"
@@ -233,7 +233,7 @@ module Fastlane
             # Since we usually just need the passed hash, we'll just use the first object if there is only one
             if arguments.count == 0
               arguments = ConfigurationHelper.parse(class_ref, {}) # no parameters => empty hash
-            elsif arguments.count == 1 and arguments.first.kind_of? Hash
+            elsif arguments.count == 1 and arguments.first.kind_of?(Hash)
               arguments = ConfigurationHelper.parse(class_ref, arguments.first) # Correct configuration passed
             elsif !class_ref.available_options
               # This action does not use the new action format
@@ -243,10 +243,10 @@ module Fastlane
             end
 
             if Fastlane::Actions.is_deprecated?(class_ref)
-              puts "==========================================".deprecated
-              puts "This action (#{method_sym}) is deprecated".deprecated
-              puts class_ref.deprecated_notes.to_s.deprecated if class_ref.deprecated_notes
-              puts "==========================================\n".deprecated
+              puts("==========================================".deprecated)
+              puts("This action (#{method_sym}) is deprecated".deprecated)
+              puts(class_ref.deprecated_notes.to_s.deprecated) if class_ref.deprecated_notes
+              puts("==========================================\n".deprecated)
             end
 
             class_ref.runner = self # needed to call another action form an action

data/fastlane/lib/fastlane/setup/crashlytics_beta.rb

@@ -8,10 +8,10 @@ module Fastlane
     def run
       setup = Setup.new
 
-      @ui.message 'This command will generate a fastlane configuration for distributing your app with Beta by Crashlytics'
-      @ui.message 'so that you can get your testers new builds with a single command!'
+      @ui.message('This command will generate a fastlane configuration for distributing your app with Beta by Crashlytics')
+      @ui.message('so that you can get your testers new builds with a single command!')
 
-      @ui.message ''
+      @ui.message('')
 
       if setup.is_android?
         UI.user_error!('Sorry, Beta by Crashlytics configuration is currently only available for iOS projects!')
@@ -19,18 +19,18 @@ module Fastlane
         UI.user_error!('Please run Beta by Crashlytics configuration from your iOS project folder.')
       end
 
-      @ui.message "\nAttempting to detect your project settings in this directory...".cyan
+      @ui.message("\nAttempting to detect your project settings in this directory...".cyan)
       info_collector = CrashlyticsBetaInfoCollector.new(CrashlyticsProjectParser.new,
                                                         CrashlyticsBetaUserEmailFetcher.new,
                                                         @ui)
       info_collector.collect_info_into(@beta_info)
 
       if FastlaneCore::FastlaneFolder.setup?
-        @ui.message ""
+        @ui.message("")
         @ui.header('Copy and paste the following lane into your Fastfile to use Crashlytics Beta!')
-        @ui.message ""
-        puts lane_template.cyan
-        @ui.message ""
+        @ui.message("")
+        puts(lane_template.cyan)
+        @ui.message("")
       else
         fastfile = fastfile_template
         FileUtils.mkdir_p('fastlane')
@@ -40,7 +40,7 @@ module Fastlane
       @ui.header('Next Steps')
       @ui.success('Run the following command to build and upload to Beta by Crashlytics. 🎯')
       @ui.message("\n    fastlane beta")
-      @ui.message ""
+      @ui.message("")
     end
 
     def lane_template

data/fastlane/lib/fastlane/setup/crashlytics_beta_command_line_handler.rb

@@ -14,13 +14,13 @@ module Fastlane
     end
 
     def self.apply_options(command)
-      command.option '--crashlytics_path STRING', String, 'Path to Crashlytics.framework'
-      command.option '--api_key STRING', String, 'Crashlytics API key'
-      command.option '--build_secret STRING', String, 'Crashlytics build secret'
-      command.option '--emails ARRAY', Array, 'List of emails to invite'
-      command.option '--groups ARRAY', Array, 'List of group aliases to invite'
-      command.option '--scheme STRING', String, 'Xcode scheme'
-      command.option '--export_method STRING', String, 'Provisioning profile type (ad-hoc, enterprise, development)'
+      command.option('--crashlytics_path STRING', String, 'Path to Crashlytics.framework')
+      command.option('--api_key STRING', String, 'Crashlytics API key')
+      command.option('--build_secret STRING', String, 'Crashlytics build secret')
+      command.option('--emails ARRAY', Array, 'List of emails to invite')
+      command.option('--groups ARRAY', Array, 'List of group aliases to invite')
+      command.option('--scheme STRING', String, 'Xcode scheme')
+      command.option('--export_method STRING', String, 'Provisioning profile type (ad-hoc, enterprise, development)')
     end
   end
 end

data/fastlane/lib/fastlane/setup/crashlytics_beta_info_collector.rb

@@ -11,7 +11,7 @@ module Fastlane
     # @param info CrashlyticsBetaInfo to supplement with needed info that is collected
     def collect_info_into(info)
       if user_provided_invalid_values?(info) || !info.has_all_detectable_values?
-        @ui.message "\nTrying to discover Beta by Crashlytics info from your project...".cyan
+        @ui.message("\nTrying to discover Beta by Crashlytics info from your project...".cyan)
         parse_project_info_into(info)
         fetch_email_into(info)
       end
@@ -23,27 +23,27 @@ module Fastlane
       invalid = false
 
       if info.crashlytics_path && !info.crashlytics_path_valid?
-        @ui.message "The crashlytics_path you provided (#{info.crashlytics_path}) is not valid."
+        @ui.message("The crashlytics_path you provided (#{info.crashlytics_path}) is not valid.")
         invalid = true
       end
 
       if info.api_key && !info.api_key_valid?
-        @ui.message "The api_key you provided (#{info.api_key}) is not valid."
+        @ui.message("The api_key you provided (#{info.api_key}) is not valid.")
         invalid = true
       end
 
       if info.build_secret && !info.build_secret_valid?
-        @ui.message "The build_secret you provided (#{info.build_secret}) is not valid."
+        @ui.message("The build_secret you provided (#{info.build_secret}) is not valid.")
         invalid = true
       end
 
       if info.emails && !info.emails_valid?
-        @ui.message "The email you provided (#{info.emails.first}) is not valid."
+        @ui.message("The email you provided (#{info.emails.first}) is not valid.")
         invalid = true
       end
 
       if info.schemes && !info.schemes_valid?
-        @ui.message "The scheme you provided (#{info.schemes.first}) is not valid."
+        @ui.message("The scheme you provided (#{info.schemes.first}) is not valid.")
         invalid = true
       end
 
@@ -54,7 +54,7 @@ module Fastlane
       begin
         info_hash = @project_parser.parse
       rescue => ex
-        @ui.important ex.message
+        @ui.important(ex.message)
       end
 
       if info_hash
@@ -72,32 +72,32 @@ module Fastlane
 
     def prompt_for_missing_values(info)
       if !info.crashlytics_path || !info.crashlytics_path_valid?
-        @ui.important "A Crashlytics submit binary path couldn't be discovered from your project 🔍"
+        @ui.important("A Crashlytics submit binary path couldn't be discovered from your project 🔍")
         prompt_for_crashlytics_path(info)
       end
 
       if !info.api_key || !info.api_key_valid?
-        @ui.important "Your Fabric organization's API Key couldn't be discovered from your project 🔍"
+        @ui.important("Your Fabric organization's API Key couldn't be discovered from your project 🔍")
         show_fabric_org_help unless @shown_fabric_org_help
         prompt_for_api_key(info)
       end
 
       if !info.build_secret || !info.build_secret_valid?
-        @ui.important "Your Fabric organization's Build Secret couldn't be discovered from your project 🔍"
+        @ui.important("Your Fabric organization's Build Secret couldn't be discovered from your project 🔍")
         show_fabric_org_help unless @shown_fabric_org_help
         prompt_for_build_secret(info)
       end
 
       if (!info.emails || !info.emails_valid?) && !info.groups
-        @ui.important "Your email address couldn't be discovered from your project 🔍"
+        @ui.important("Your email address couldn't be discovered from your project 🔍")
         prompt_for_email(info)
       end
 
       if !info.schemes || info.schemes.empty?
-        @ui.important "Your scheme couldn't be discovered from your project 🔍"
+        @ui.important("Your scheme couldn't be discovered from your project 🔍")
         prompt_for_schemes(info)
       elsif info.schemes.size > 1
-        @ui.important "Multiple schemes were discovered from your project 🔍"
+        @ui.important("Multiple schemes were discovered from your project 🔍")
         prompt_for_schemes(info)
       end
 
@@ -115,7 +115,7 @@ module Fastlane
       loop do
         info.api_key = @ui.input("Please provide your Fabric organization's API Key:").strip
         break if info.api_key_valid?
-        @ui.message "The API Key you provided was invalid (must be 40 characters)."
+        @ui.message("The API Key you provided was invalid (must be 40 characters).")
       end
     end
 
@@ -123,7 +123,7 @@ module Fastlane
       loop do
         info.build_secret = @ui.input("Please provide your Fabric organization's Build Secret:").strip
         break if info.build_secret_valid?
-        @ui.message "The Build Secret you provided was invalid (must be 64 characters)."
+        @ui.message("The Build Secret you provided was invalid (must be 64 characters).")
       end
     end
 
@@ -131,7 +131,7 @@ module Fastlane
       loop do
         info.crashlytics_path = @ui.input("Please provide the path to Crashlytics.framework:").strip
         break if info.crashlytics_path_valid?
-        @ui.message "A submit binary could not be found at the framework path you provided."
+        @ui.message("A submit binary could not be found at the framework path you provided.")
       end
     end
 
@@ -139,7 +139,7 @@ module Fastlane
       loop do
         info.emails = [@ui.input("Please enter an email address to distribute the beta to:").strip]
         break if info.emails_valid?
-        @ui.message "You must provide an email address."
+        @ui.message("You must provide an email address.")
       end
     end
 
@@ -149,7 +149,7 @@ module Fastlane
         loop do
           info.schemes = [@ui.input("Please enter the name of the scheme you would like to use:").strip]
           break if info.schemes_valid?
-          @ui.message "You must provide a scheme name."
+          @ui.message("You must provide a scheme name.")
         end
       else
         info.schemes = [@ui.choose("\nWhich scheme would you like to use?", current_schemes)]
@@ -157,7 +157,7 @@ module Fastlane
     end
 
     def prompt_for_export_method(info)
-      @ui.important "The export method you entered was not valid."
+      @ui.important("The export method you entered was not valid.")
       info.export_method = @ui.choose("\nWhich export method would you like to use?", CrashlyticsBetaInfo::EXPORT_METHODS)
     end
   end

data/fastlane/lib/fastlane/setup/crashlytics_beta_ui.rb

@@ -1,11 +1,11 @@
 module Fastlane
   class CrashlyticsBetaUi
     def success(text)
-      puts text.green
+      puts(text.green)
     end
 
     def message(text)
-      puts text
+      puts(text)
     end
 
     def header(text)
@@ -13,7 +13,7 @@ module Fastlane
     end
 
     def important(text)
-      puts text.yellow
+      puts(text.yellow)
     end
 
     def input(text)

data/fastlane/lib/fastlane/setup/setup_android.rb

@@ -20,10 +20,10 @@ module Fastlane
       UI.success('To not re-enter your packagename and issuer every time you run one of the fastlane tools or fastlane, these will be stored in a so-called Appfile.')
 
       package_name = UI.input("Package Name (com.krausefx.app): ")
-      puts ""
-      puts "To automatically upload builds and metadata to Google Play, fastlane needs a service action json secret file".yellow
-      puts "Feel free to just click Enter to skip not provide certain things"
-      puts "Follow the Setup Guide on how to get the Json file: https://docs.fastlane.tools/actions/supply/".yellow
+      puts("")
+      puts("To automatically upload builds and metadata to Google Play, fastlane needs a service action json secret file".yellow)
+      puts("Feel free to just click Enter to skip not provide certain things")
+      puts("Follow the Setup Guide on how to get the Json file: https://docs.fastlane.tools/actions/supply/".yellow)
       json_key_file = UI.input("Path to the json secret file: ")
 
       template = File.read("#{Fastlane::ROOT}/lib/assets/AppfileTemplateAndroid")

data/fastlane/lib/fastlane/setup/setup_ios.rb

@@ -165,17 +165,17 @@ module Fastlane
       rows << ["App Identifier", self.app_identifier]
       rows << [(self.project.is_workspace ? "Workspace" : "Project"), self.project.path]
       require 'terminal-table'
-      puts ""
-      puts Terminal::Table.new(rows: FastlaneCore::PrintTable.transform_output(rows),
-                              title: "Detected Values")
-      puts ""
+      puts("")
+      puts(Terminal::Table.new(rows: FastlaneCore::PrintTable.transform_output(rows),
+                              title: "Detected Values"))
+      puts("")
 
       unless self.itc_ref || self.project.mac?
-        UI.important "This app identifier doesn't exist on iTunes Connect yet, it will be created for you"
+        UI.important("This app identifier doesn't exist on iTunes Connect yet, it will be created for you")
       end
 
       unless self.portal_ref || self.project.mac?
-        UI.important "This app identifier doesn't exist on the Apple Developer Portal yet, it will be created for you"
+        UI.important("This app identifier doesn't exist on the Apple Developer Portal yet, it will be created for you")
       end
     end
 
@@ -234,8 +234,8 @@ module Fastlane
 
     # Detect if the app was created on the Dev Portal / iTC
     def detect_if_app_is_available
-      UI.important "Verifying that app is available on the Apple Developer Portal and iTunes Connect..."
-      UI.message "Starting login with user '#{self.apple_id}'"
+      UI.important("Verifying that app is available on the Apple Developer Portal and iTunes Connect...")
+      UI.message("Starting login with user '#{self.apple_id}'")
       Spaceship.login(self.apple_id, nil)
       self.dev_portal_team = Spaceship.select_team
       self.portal_ref = Spaceship::App.find(self.app_identifier)
@@ -246,7 +246,7 @@ module Fastlane
     end
 
     def create_app_if_necessary
-      UI.important "Creating the app on iTunes Connect and the Apple Developer Portal"
+      UI.important("Creating the app on iTunes Connect and the Apple Developer Portal")
       require 'produce'
       config = {} # this has to be done like this
       FastlaneCore::Project.detect_projects(config)