fastlane 2.74.1 → 2.75.0.beta.20180109010003

data/fastlane/lib/fastlane/supported_platforms.rb

@@ -20,7 +20,7 @@ module Fastlane
 
     # this will log a warning if the passed platform is not supported
     def self.verify!(platform)
-      unless all.include? platform.to_s.to_sym
+      unless all.include?(platform.to_s.to_sym)
         UI.important("Platform '#{platform}' is not officially supported. Currently supported platforms are #{self.all}.")
       end
     end

data/fastlane/lib/fastlane/swift_fastlane_api_generator.rb

@@ -18,9 +18,11 @@ module Fastlane
     attr_accessor :actions_not_supported
     attr_accessor :action_options_to_ignore
     attr_accessor :target_output_path
+    attr_accessor :generated_paths # stores all file names of generated files (as they are generated)
 
     def initialize(target_output_path: "swift")
       @target_output_path = File.expand_path(target_output_path)
+      @generated_paths = []
       require 'fastlane'
       require 'fastlane/documentation/actions_list'
       Fastlane.load_actions
@@ -49,6 +51,7 @@ module Fastlane
     end
 
     def generate_swift
+      self.generated_paths = [] # reset generated paths in case we're called multiple times
       file_content = []
       file_content << "import Foundation"
 
@@ -83,9 +86,9 @@ module Fastlane
       File.write(fastlane_swift_api_path, file_content)
       UI.success(fastlane_swift_api_path)
 
-      files_generated = [fastlane_swift_api_path]
-      files_generated += generate_default_implementations(tool_details: tool_details)
-      return files_generated
+      self.generated_paths << fastlane_swift_api_path
+      self.generated_paths += generate_default_implementations(tool_details: tool_details)
+      return self.generated_paths
     end
 
     def write_lanefile(lanefile_implementation_opening: nil, class_name: nil, tool_name: nil)
@@ -202,6 +205,7 @@ func parseInt(fromString: String, function: String = #function) -> Int {
       file_content = protocol_content_array.join("\n")
       File.write(target_path, file_content)
       UI.success(target_path)
+      return target_path
     end
 
     def ignore_param?(function_name: nil, param_name: nil)
@@ -226,9 +230,9 @@ func parseInt(fromString: String, function: String = #function) -> Int {
       key_optionality_values = []
       key_type_overrides = []
 
-      if options.kind_of? Array
+      if options.kind_of?(Array)
         options.each do |current|
-          next unless current.kind_of? FastlaneCore::ConfigItem
+          next unless current.kind_of?(FastlaneCore::ConfigItem)
 
           if ignore_param?(function_name: action_name, param_name: current.key)
             next
@@ -252,7 +256,7 @@ func parseInt(fromString: String, function: String = #function) -> Int {
           key_type_overrides: key_type_overrides,
           return_type: action_return_type
         )
-        generate_tool_protocol(tool_swift_function: tool_swift_function)
+        self.generated_paths << generate_tool_protocol(tool_swift_function: tool_swift_function)
         return tool_swift_function
       else
         return SwiftFunction.new(

data/fastlane/lib/fastlane/swift_lane_manager.rb

@@ -42,7 +42,7 @@ module Fastlane
         # We also catch Exception, since the implemented action might send a SystemExit signal
         # (or similar). We still want to catch that, since we want properly finish running fastlane
         # Tested with `xcake`, which throws a `Xcake::Informative` object
-        UI.error e.to_s if e.kind_of?(StandardError) # we don't want to print things like 'system exit'
+        UI.error(e.to_s) if e.kind_of?(StandardError) # we don't want to print things like 'system exit'
       end
 
       skip_message = false

data/fastlane/lib/fastlane/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
-  VERSION = '2.74.1'.freeze
+  VERSION = '2.75.0.beta.20180109010003'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
   MINIMUM_XCODE_RELEASE = "7.0".freeze
   RUBOCOP_REQUIREMENT = '0.49.1'.freeze

data/fastlane_core/README.md

@@ -1,29 +1,3 @@
-<h3 align="center">
-  <a href="https://github.com/fastlane/fastlane/tree/master/fastlane">
-    <img src="../fastlane/assets/fastlane.png" width="150" />
-    <br />
-    fastlane
-  </a>
-</h3>
-<p align="center">
-  <a href="https://github.com/fastlane/fastlane/tree/master/deliver">deliver</a> &bull;
-  <a href="https://github.com/fastlane/fastlane/tree/master/snapshot">snapshot</a> &bull;
-  <a href="https://github.com/fastlane/fastlane/tree/master/frameit">frameit</a> &bull;
-  <a href="https://github.com/fastlane/fastlane/tree/master/pem">pem</a> &bull;
-  <a href="https://github.com/fastlane/fastlane/tree/master/sigh">sigh</a> &bull;
-  <a href="https://github.com/fastlane/fastlane/tree/master/produce">produce</a> &bull;
-  <a href="https://github.com/fastlane/fastlane/tree/master/cert">cert</a> &bull;
-  <a href="https://github.com/fastlane/fastlane/tree/master/spaceship">spaceship</a> &bull;
-  <a href="https://github.com/fastlane/fastlane/tree/master/pilot">pilot</a> &bull;
-  <a href="https://github.com/fastlane/boarding">boarding</a> &bull;
-  <a href="https://github.com/fastlane/fastlane/tree/master/gym">gym</a> &bull;
-  <a href="https://github.com/fastlane/fastlane/tree/master/scan">scan</a> &bull;
-  <a href="https://github.com/fastlane/fastlane/tree/master/match">match</a> &bull;
-  <a href="https://github.com/fastlane/fastlane/tree/master/precheck">precheck</a>
-</p>
-
--------
-
 FastlaneCore
 ============
 

data/fastlane_core/lib/fastlane_core/analytics/analytics_ingester_client.rb

@@ -28,14 +28,14 @@ module FastlaneCore
 
       require 'faraday'
       connection = Faraday.new(url) do |conn|
-        conn.adapter Faraday.default_adapter
+        conn.adapter(Faraday.default_adapter)
         if ENV['METRICS_DEBUG']
           conn.proxy = "https://127.0.0.1:8888"
           conn.ssl[:verify_mode] = OpenSSL::SSL::VERIFY_NONE
         end
       end
       connection.post do |req|
-        req.url '/public'
+        req.url('/public')
         req.headers['Content-Type'] = 'application/json'
         req.body = body
       end

data/fastlane_core/lib/fastlane_core/build_watcher.rb

@@ -28,7 +28,7 @@ module FastlaneCore
             return matched_build
           end
 
-          sleep poll_interval
+          sleep(poll_interval)
         end
       end
 

data/fastlane_core/lib/fastlane_core/cert_checker.rb

@@ -11,7 +11,7 @@ module FastlaneCore
       ids = installed_identies
       finger_print = sha1_fingerprint(path)
 
-      return ids.include? finger_print
+      return ids.include?(finger_print)
     end
 
     # Legacy Method, use `installed?` instead
@@ -35,7 +35,7 @@ module FastlaneCore
 
       ids = []
       available.split("\n").each do |current|
-        next if current.include? "REVOKED"
+        next if current.include?("REVOKED")
         begin
           (ids << current.match(/.*\) ([[:xdigit:]]*) \".*/)[1])
         rescue

data/fastlane_core/lib/fastlane_core/command_executor.rb

@@ -74,7 +74,7 @@ module FastlaneCore
           # > invalid byte sequence in US-ASCII (ArgumentError)
           output << ex.to_s
           o = output.join("\n")
-          puts o
+          puts(o)
           if error
             error.call(o, nil)
           else
@@ -86,8 +86,8 @@ module FastlaneCore
         status = $?.exitstatus
         if status != 0
           o = output.join("\n")
-          puts o # the user has the right to see the raw output
-          UI.error "Exit status: #{status}"
+          puts(o) # the user has the right to see the raw output
+          UI.error("Exit status: #{status}")
           if error
             error.call(o, status)
           else

data/fastlane_core/lib/fastlane_core/configuration/config_item.rb

@@ -99,8 +99,8 @@ module FastlaneCore
                    code_gen_sensitive: false,
                    code_gen_default_value: nil,
                    display_in_shell: true)
-      UI.user_error!("key must be a symbol") unless key.kind_of? Symbol
-      UI.user_error!("env_name must be a String") unless (env_name || '').kind_of? String
+      UI.user_error!("key must be a symbol") unless key.kind_of?(Symbol)
+      UI.user_error!("env_name must be a String") unless (env_name || '').kind_of?(String)
 
       if short_option
         UI.user_error!("short_option for key :#{key} must of type String") unless short_option.kind_of?(String)
@@ -113,7 +113,7 @@ module FastlaneCore
 
       if conflicting_options
         conflicting_options.each do |conflicting_option_key|
-          UI.user_error!("Conflicting option key must be a symbol") unless conflicting_option_key.kind_of? Symbol
+          UI.user_error!("Conflicting option key must be a symbol") unless conflicting_option_key.kind_of?(Symbol)
         end
       end
 
@@ -210,7 +210,7 @@ module FastlaneCore
           begin
             @verify_block.call(value)
           rescue => ex
-            UI.error "Error setting value '#{value}' for option '#{@key}'"
+            UI.error("Error setting value '#{value}' for option '#{@key}'")
             raise Interface::FastlaneError.new, ex.to_s
           end
         end

data/fastlane_core/lib/fastlane_core/configuration/configuration.rb

@@ -70,9 +70,9 @@ module FastlaneCore
     end
 
     def verify_input_types
-      UI.user_error!("available_options parameter must be an array of ConfigItems but is #{@available_options.class}") unless @available_options.kind_of? Array
+      UI.user_error!("available_options parameter must be an array of ConfigItems but is #{@available_options.class}") unless @available_options.kind_of?(Array)
       @available_options.each do |item|
-        UI.user_error!("available_options parameter must be an array of ConfigItems. Found #{item.class}.") unless item.kind_of? ConfigItem
+        UI.user_error!("available_options parameter must be an array of ConfigItems. Found #{item.class}.") unless item.kind_of?(ConfigItem)
       end
       UI.user_error!("values parameter must be a hash") unless @values.kind_of?(Hash)
     end
@@ -245,7 +245,7 @@ module FastlaneCore
         begin
           set(key, value)
         rescue => ex
-          puts ex
+          puts(ex)
           value = nil
         end
       end
@@ -261,7 +261,7 @@ module FastlaneCore
     # Overwrites or sets a new value for a given key
     # @param key [Symbol] Must be a symbol
     def set(key, value)
-      UI.user_error!("Key '#{key}' must be a symbol. Example :#{key}.") unless key.kind_of? Symbol
+      UI.user_error!("Key '#{key}' must be a symbol. Example :#{key}.") unless key.kind_of?(Symbol)
       option = option_for_key(key)
 
       unless option

data/fastlane_core/lib/fastlane_core/configuration/configuration_file.rb

@@ -69,10 +69,10 @@ module FastlaneCore
         [key, value] if value.to_s.length > 0
       end.compact
 
-      puts ""
-      puts Terminal::Table.new(rows: FastlaneCore::PrintTable.transform_output(rows),
-                              title: "Detected Values from '#{self.configfile_path}'")
-      puts ""
+      puts("")
+      puts(Terminal::Table.new(rows: FastlaneCore::PrintTable.transform_output(rows),
+                              title: "Detected Values from '#{self.configfile_path}'"))
+      puts("")
     end
 
     # This is used to display only the values that have changed in the summary table

data/fastlane_core/lib/fastlane_core/core_ext/cfpropertylist.rb

@@ -12,7 +12,7 @@ require "plist"
 # CFPropertyList also adds Enumerator#to_plist, but there is no such
 # method from Plist, so leave it.
 [Array, Hash].each do |c|
-  c.send :alias_method, :to_binary_plist, :to_plist
-  c.send :remove_method, :to_plist
-  c.module_eval "include Plist::Emit"
+  c.send(:alias_method, :to_binary_plist, :to_plist)
+  c.send(:remove_method, :to_plist)
+  c.module_eval("include Plist::Emit")
 end

data/fastlane_core/lib/fastlane_core/device_manager.rb

@@ -56,9 +56,7 @@ module FastlaneCore
 
             if matches.count && (os_type == requested_os_type || requested_os_type == "")
               # This is disabled here because the Device is defined later in the file, and that's a problem for the cop
-              # rubocop:disable Lint/MissingRequireStatement
               @devices << Device.new(name: name, os_type: os_type, os_version: (exact_versions[os_type][os_version] || os_version), udid: udid, state: state, is_simulator: true)
-              # rubocop:enable Lint/MissingRequireStatement
             end
           end
         end
@@ -257,7 +255,7 @@ module FastlaneCore
 
         simulator_path = File.join(Helper.xcode_path, 'Applications', 'Simulator.app')
 
-        UI.verbose "Launching #{simulator_path} for device: #{device.name} (#{device.udid})"
+        UI.verbose("Launching #{simulator_path} for device: #{device.name} (#{device.udid})")
 
         Helper.backticks("open -a #{simulator_path} --args -CurrentDeviceUDID #{device.udid}", print: FastlaneCore::Globals.verbose?)
       end
@@ -288,7 +286,7 @@ module FastlaneCore
 
         FileUtils.rm_f(logfile_dst)
         FileUtils.cp(logfile_src, logfile_dst)
-        UI.success "Copying file '#{logfile_src}' to '#{logfile_dst}'..."
+        UI.success("Copying file '#{logfile_src}' to '#{logfile_dst}'...")
       end
 
       def copy_logarchive(device, log_identity, logs_destination_dir)

data/fastlane_core/lib/fastlane_core/fastlane_folder.rb

@@ -65,7 +65,7 @@ module FastlaneCore
       return if File.directory?(path) # directory is already there
       UI.user_error!("Found a file called 'fastlane' at path '#{path}', please delete it") if File.exist?(path)
       FileUtils.mkdir_p(path)
-      UI.success "Created new folder '#{path}'."
+      UI.success("Created new folder '#{path}'.")
     end
   end
 end

data/fastlane_core/lib/fastlane_core/globals.rb

@@ -5,9 +5,9 @@ module FastlaneCore
     end
 
     class << self
-      attr_writer :captured_output
-      attr_writer :capture_output
-      attr_writer :verbose
+      attr_writer(:captured_output)
+      attr_writer(:capture_output)
+      attr_writer(:verbose)
     end
 
     def self.capture_output?

data/fastlane_core/lib/fastlane_core/helper.rb

@@ -12,7 +12,7 @@ module FastlaneCore
     # This method is deprecated, use the `UI` class
     # https://github.com/fastlane/fastlane/blob/master/fastlane/docs/UI.md
     def self.log
-      UI.deprecated "Helper.log is deprecated. Use `UI` class instead"
+      UI.deprecated("Helper.log is deprecated. Use `UI` class instead")
       UI.current.log
     end
 

data/fastlane_core/lib/fastlane_core/ipa_file_analyser.rb

@@ -47,7 +47,7 @@ module FastlaneCore
           # The XML file has to be properly unpacked first
           tmp_path = File.join(tmp, "Info.plist")
           File.open(tmp_path, 'wb') do |output|
-            output.write zipfile.read(file)
+            output.write(zipfile.read(file))
           end
           result = CFPropertyList.native_types(CFPropertyList::List.new(file: tmp_path).value)
 

data/fastlane_core/lib/fastlane_core/ipa_upload_package_builder.rb

@@ -13,8 +13,8 @@ module FastlaneCore
 
     def generate(app_id: nil, ipa_path: nil, package_path: nil, platform: nil)
       self.package_path = File.join(package_path, "#{app_id}.itmsp")
-      FileUtils.rm_rf self.package_path if File.directory?(self.package_path)
-      FileUtils.mkdir_p self.package_path
+      FileUtils.rm_rf(self.package_path) if File.directory?(self.package_path)
+      FileUtils.mkdir_p(self.package_path)
 
       ipa_path = copy_ipa(ipa_path)
       @data = {

data/fastlane_core/lib/fastlane_core/itunes_transporter.rb

@@ -110,8 +110,8 @@ module FastlaneCore
         UI.error("[Transporter Error Output]: #{$1}")
 
         # Check if it's a login error
-        if $1.include? "Your Apple ID or password was entered incorrectly" or
-           $1.include? "This Apple ID has been locked for security reasons"
+        if $1.include?("Your Apple ID or password was entered incorrectly") or
+           $1.include?("This Apple ID has been locked for security reasons")
 
           unless Helper.is_test?
             CredentialsManager::AccountManager.new(user: @user).invalid_credentials

data/fastlane_core/lib/fastlane_core/pkg_file_analyser.rb

@@ -22,7 +22,7 @@ module FastlaneCore
         Helper.backticks("xar -C #{dir.shellescape} -xf #{path.shellescape}")
 
         Dir.foreach(dir) do |file|
-          next unless file.include? 'Distribution'
+          next unless file.include?('Distribution')
 
           begin
             content = File.open(File.join(dir, file))

data/fastlane_core/lib/fastlane_core/pkg_upload_package_builder.rb

@@ -14,7 +14,7 @@ module FastlaneCore
     def generate(app_id: nil, pkg_path: nil, package_path: nil, platform: "osx")
       self.package_path = File.join(package_path, "#{app_id}.itmsp")
       FileUtils.rm_rf(self.package_path) if File.directory?(self.package_path)
-      FileUtils.mkdir_p self.package_path
+      FileUtils.mkdir_p(self.package_path)
 
       pkg_path = copy_pkg(pkg_path)
       @data = {

data/fastlane_core/lib/fastlane_core/print_table.rb

@@ -36,9 +36,9 @@ module FastlaneCore
 
         params[:title] = title.green if title
 
-        puts ""
-        puts Terminal::Table.new(params)
-        puts ""
+        puts("")
+        puts(Terminal::Table.new(params))
+        puts("")
 
         return params
       end
@@ -118,8 +118,8 @@ module FastlaneCore
           next if hide_keys.include?(prefixed_key)
           value = mask if mask_keys.include?(prefixed_key)
 
-          if value.respond_to? :key
-            rows.concat self.collect_rows(options: value, hide_keys: hide_keys, mask_keys: mask_keys, prefix: "#{prefix}#{key}.", mask: mask)
+          if value.respond_to?(:key)
+            rows.concat(self.collect_rows(options: value, hide_keys: hide_keys, mask_keys: mask_keys, prefix: "#{prefix}#{key}.", mask: mask))
           else
             rows << [prefixed_key, value]
           end

data/fastlane_core/lib/fastlane_core/project.rb

@@ -16,7 +16,7 @@ module FastlaneCore
         if config[:workspace].to_s.length == 0
           workspace = Dir["./*.xcworkspace"]
           if workspace.count > 1
-            puts "Select Workspace: "
+            puts("Select Workspace: ")
             config[:workspace] = choose(*workspace)
           elsif !workspace.first.nil?
             config[:workspace] = workspace.first
@@ -28,7 +28,7 @@ module FastlaneCore
         if config[:workspace].to_s.length == 0 and config[:project].to_s.length == 0
           project = Dir["./*.xcodeproj"]
           if project.count > 1
-            puts "Select Project: "
+            puts("Select Project: ")
             config[:project] = choose(*project)
           elsif !project.first.nil?
             config[:project] = project.first
@@ -43,11 +43,11 @@ module FastlaneCore
       def select_project(config)
         loop do
           path = UI.input("Couldn't automatically detect the project file, please provide a path: ")
-          if File.directory? path
-            if path.end_with? ".xcworkspace"
+          if File.directory?(path)
+            if path.end_with?(".xcworkspace")
               config[:workspace] = path
               break
-            elsif path.end_with? ".xcodeproj"
+            elsif path.end_with?(".xcodeproj")
               config[:project] = path
               break
             else
@@ -137,7 +137,7 @@ module FastlaneCore
           show_scheme_shared_information
           UI.user_error!("Multiple schemes found")
         else
-          puts "Select Scheme: "
+          puts("Select Scheme: ")
           options[:scheme] = choose(*schemes)
         end
       else
@@ -349,7 +349,7 @@ module FastlaneCore
     def build_xcodebuild_list_command
       # Unfortunately since we pass the workspace we also get all the
       # schemes generated by CocoaPods
-      options = xcodebuild_parameters.delete_if { |a| a.to_s.include? "scheme" }
+      options = xcodebuild_parameters.delete_if { |a| a.to_s.include?("scheme") }
       command = "xcodebuild -list #{options.join(' ')}"
       command += " 2> /dev/null" if xcodebuild_suppress_stderr
       command