fastlane 2.74.1 → 2.75.0.beta.20180109010003

data/fastlane/lib/fastlane/cli_tools_distributor.rb

@@ -116,31 +116,31 @@ module Fastlane
           # The user has a Gemfile, but forgot to use `bundle exec`
           # Let's tell the user how to use `bundle exec`
           # We show this warning no matter if the command is slow or not
-          UI.important "fastlane detected a Gemfile in the current directory"
-          UI.important "however it seems like you don't use `bundle exec`"
-          UI.important "to launch fastlane faster, please use"
-          UI.message ""
+          UI.important("fastlane detected a Gemfile in the current directory")
+          UI.important("however it seems like you don't use `bundle exec`")
+          UI.important("to launch fastlane faster, please use")
+          UI.message("")
           UI.command "bundle exec fastlane #{ARGV.join(' ')}"
-          UI.message ""
+          UI.message("")
         elsif is_slow
           # fastlane is slow and there is no Gemfile
           # Let's tell the user how to use `gem cleanup` and how to
           # start using a Gemfile
-          UI.important "Seems like launching fastlane takes a while - please run"
-          UI.message ""
+          UI.important("Seems like launching fastlane takes a while - please run")
+          UI.message("")
           UI.command "[sudo] gem cleanup"
-          UI.message ""
-          UI.important "to uninstall outdated gems and make fastlane launch faster"
-          UI.important "Alternatively it's recommended to start using a Gemfile to lock your dependencies"
-          UI.important "To get started with a Gemfile, run"
-          UI.message ""
+          UI.message("")
+          UI.important("to uninstall outdated gems and make fastlane launch faster")
+          UI.important("Alternatively it's recommended to start using a Gemfile to lock your dependencies")
+          UI.important("To get started with a Gemfile, run")
+          UI.message("")
           UI.command "bundle init"
           UI.command "echo 'gem \"fastlane\"' >> Gemfile"
           UI.command "bundle install"
-          UI.message ""
-          UI.important "After creating the Gemfile and Gemfile.lock, commit those files into version control"
+          UI.message("")
+          UI.important("After creating the Gemfile and Gemfile.lock, commit those files into version control")
         end
-        UI.important "Get started using a Gemfile for fastlane https://docs.fastlane.tools/getting-started/ios/setup/#use-a-gemfile"
+        UI.important("Get started using a Gemfile for fastlane https://docs.fastlane.tools/getting-started/ios/setup/#use-a-gemfile")
       end
 
       # Returns an array of symbols for the available lanes for the Fastfile

data/fastlane/lib/fastlane/command_line_handler.rb

@@ -7,7 +7,7 @@ module Fastlane
       lane_parameters = {} # the parameters we'll pass to the lane
       platform_lane_info = [] # the part that's responsible for the lane/platform definition
       args.each do |current|
-        if current.include? ":" # that's a key/value which we want to pass to the lane
+        if current.include?(":") # that's a key/value which we want to pass to the lane
           key, value = current.split(":", 2)
           UI.user_error!("Please pass values like this: key:value") unless key.length > 0
           value = convert_value(value)

data/fastlane/lib/fastlane/commands_generator.rb

@@ -57,19 +57,19 @@ module Fastlane
 
     def self.confirm_troubleshoot
       if Helper.is_ci?
-        UI.error "---"
-        UI.error "You are trying to use '--troubleshoot' on CI"
-        UI.error "this option is not usable in CI, as it is insecure"
-        UI.error "---"
+        UI.error("---")
+        UI.error("You are trying to use '--troubleshoot' on CI")
+        UI.error("this option is not usable in CI, as it is insecure")
+        UI.error("---")
         UI.user_error!("Do not use --troubleshoot in CI")
       end
       # maybe already set by 'start'
       return if $troubleshoot
-      UI.error "---"
-      UI.error "Are you sure you want to enable '--troubleshoot'?"
-      UI.error "All commmands will run in full unfiltered output mode."
-      UI.error "Sensitive data, like passwords, could be printed to the log."
-      UI.error "---"
+      UI.error("---")
+      UI.error("Are you sure you want to enable '--troubleshoot'?")
+      UI.error("All commmands will run in full unfiltered output mode.")
+      UI.error("Sensitive data, like passwords, could be printed to the log.")
+      UI.error("---")
       if UI.confirm("Do you really want to enable --troubleshoot")
         $troubleshoot = true
       end
@@ -100,7 +100,7 @@ module Fastlane
       command :trigger do |c|
         c.syntax = 'fastlane [lane]'
         c.description = 'Run a specific lane. Pass the lane name and optionally the platform first.'
-        c.option '--env STRING[,STRING2]', String, 'Add environment(s) to use with `dotenv`'
+        c.option('--env STRING[,STRING2]', String, 'Add environment(s) to use with `dotenv`')
 
         c.action do |args, options|
           if ensure_fastfile
@@ -113,7 +113,7 @@ module Fastlane
         c.syntax = 'fastlane init'
         c.description = 'Helps you with your initial fastlane setup'
 
-        c.option '-u STRING', '--user STRING', String, 'iOS projects only: Your Apple ID'
+        c.option('-u STRING', '--user STRING', String, 'iOS projects only: Your Apple ID')
 
         CrashlyticsBetaCommandLineHandler.apply_options(c)
 
@@ -131,7 +131,7 @@ module Fastlane
       command :init_swift do |c|
         c.syntax = 'fastlane init_swift'
         c.description = 'Helps you with your initial fastlane setup for Swift'
-        c.option '-u STRING', '--user STRING', String, 'iOS projects only: Your Apple ID'
+        c.option('-u STRING', '--user STRING', String, 'iOS projects only: Your Apple ID')
 
         c.action do |args, options|
           Fastlane::Setup.new.run(user: options.user, is_swift_fastfile: true)
@@ -142,7 +142,7 @@ module Fastlane
         c.syntax = 'fastlane new_action'
         c.description = 'Create a new custom action for fastlane.'
 
-        c.option '--name STRING', String, 'Name of your new action'
+        c.option('--name STRING', String, 'Name of your new action')
 
         c.action do |args, options|
           Fastlane::NewAction.run(new_action_name: options.name)
@@ -152,8 +152,8 @@ module Fastlane
       command :socket_server do |c|
         c.syntax = 'fastlane start_server'
         c.description = 'Starts local socket server and enables only a single local connection'
-        c.option '-s', '--stay_alive', 'Keeps socket server up even after error or disconnects, requires CTRL-C to kill.'
-        c.option '-c seconds', '--connection_timeout', 'Sets connection established timeout'
+        c.option('-s', '--stay_alive', 'Keeps socket server up even after error or disconnects, requires CTRL-C to kill.')
+        c.option('-c seconds', '--connection_timeout', 'Sets connection established timeout')
         c.action do |args, options|
           default_connection_timeout = 5
           stay_alive = options.stay_alive || false
@@ -173,14 +173,14 @@ module Fastlane
             stay_alive: stay_alive
           )
           result = server.start
-          UI.success "Result: #{result}" if result
+          UI.success("Result: #{result}") if result
         end
       end
 
       command :lanes do |c|
         c.syntax = 'fastlane lanes'
         c.description = 'Lists all available lanes and shows their description'
-        c.option "-j", "--json", "Output the lanes in JSON instead of text"
+        c.option("-j", "--json", "Output the lanes in JSON instead of text")
 
         c.action do |args, options|
           if options.json || ensure_fastfile
@@ -202,11 +202,11 @@ module Fastlane
         c.action do |args, options|
           if ensure_fastfile
             ff = Fastlane::FastFile.new(FastlaneCore::FastlaneFolder.fastfile_path)
-            UI.message "Available lanes:"
+            UI.message("Available lanes:")
             ff.runner.available_lanes.each do |lane|
-              UI.message "- #{lane}"
+              UI.message("- #{lane}")
             end
-            UI.important "Execute using `fastlane [lane_name]`"
+            UI.important("Execute using `fastlane [lane_name]`")
           end
         end
       end
@@ -214,12 +214,12 @@ module Fastlane
       command :docs do |c|
         c.syntax = 'fastlane docs'
         c.description = 'Generate a markdown based documentation based on the Fastfile'
-        c.option '-f', '--force', 'Overwrite the existing README.md in the ./fastlane folder'
+        c.option('-f', '--force', 'Overwrite the existing README.md in the ./fastlane folder')
 
         c.action do |args, options|
           if ensure_fastfile
             ff = Fastlane::FastFile.new(File.join(FastlaneCore::FastlaneFolder.path || '.', 'Fastfile'))
-            UI.message "You don't need to run `fastlane docs` manually any more, this will be done automatically for you when running a lane."
+            UI.message("You don't need to run `fastlane docs` manually any more, this will be done automatically for you when running a lane.")
             Fastlane::DocsGenerator.run(ff)
           end
         end
@@ -232,7 +232,7 @@ module Fastlane
         c.action do |args, options|
           require 'fastlane/one_off'
           result = Fastlane::OneOff.execute(args: args)
-          UI.success "Result: #{result}" if result
+          UI.success("Result: #{result}") if result
         end
       end
 
@@ -240,7 +240,7 @@ module Fastlane
         c.syntax = 'fastlane actions'
         c.description = 'Lists all available fastlane actions'
 
-        c.option '--platform STRING', String, 'Only show actions available on the given platform'
+        c.option('--platform STRING', String, 'Only show actions available on the given platform')
 
         c.action do |args, options|
           require 'fastlane/documentation/actions_list'
@@ -260,7 +260,7 @@ module Fastlane
       command :enable_auto_complete do |c|
         c.syntax = 'fastlane enable_auto_complete'
         c.description = 'Enable tab auto completion'
-        c.option '-c STRING[,STRING2]', '--custom STRING[,STRING2]', String, 'Add custom command(s) for which tab auto complete should be enabled too'
+        c.option('-c STRING[,STRING2]', '--custom STRING[,STRING2]', String, 'Add custom command(s) for which tab auto complete should be enabled too')
 
         c.action do |args, options|
           require 'fastlane/auto_complete'
@@ -342,7 +342,7 @@ module Fastlane
         end
       end
 
-      default_command :trigger
+      default_command(:trigger)
       run!
     end
 

data/fastlane/lib/fastlane/configuration_helper.rb

@@ -3,7 +3,7 @@ module Fastlane
     def self.parse(action, params)
       first_element = (action.available_options || []).first
 
-      if first_element and first_element.kind_of? FastlaneCore::ConfigItem
+      if first_element and first_element.kind_of?(FastlaneCore::ConfigItem)
         # default use case
         return FastlaneCore::Configuration.create(action.available_options, params)
       elsif first_element
@@ -16,7 +16,7 @@ module Fastlane
 
       end
     rescue => ex
-      if action.respond_to? :action_name
+      if action.respond_to?(:action_name)
         UI.error("You passed invalid parameters to '#{action.action_name}'.")
         UI.error("Check out the error below and available options by running `fastlane action #{action.action_name}`")
       end

data/fastlane/lib/fastlane/documentation/actions_list.rb

@@ -27,33 +27,33 @@ module Fastlane
           current << authors.first.green if authors.count == 1
           current << "Multiple".green if authors.count > 1
         else
-          UI.error action_subclass_error(name)
+          UI.error(action_subclass_error(name))
           current << "Please update action file".red
           current << ' '
         end
         rows << current
       end
 
-      puts Terminal::Table.new(
-        title: "Available fastlane actions".green,
-        headings: ['Action', 'Description', 'Author'],
-        rows: FastlaneCore::PrintTable.transform_output(rows)
-      )
-      puts "  Platform filter: #{platform}".magenta if platform
-      puts "  Total of #{rows.count} actions"
+      puts(Terminal::Table.new(
+             title: "Available fastlane actions".green,
+             headings: ['Action', 'Description', 'Author'],
+             rows: FastlaneCore::PrintTable.transform_output(rows)
+      ))
+      puts("  Platform filter: #{platform}".magenta) if platform
+      puts("  Total of #{rows.count} actions")
 
-      puts "\nGet more information for one specific action using `fastlane action [name]`\n".green
+      puts("\nGet more information for one specific action using `fastlane action [name]`\n".green)
     end
 
     def self.show_details(filter: nil)
-      puts "Loading documentation for #{filter}:".green
-      puts ""
+      puts("Loading documentation for #{filter}:".green)
+      puts("")
 
       action = find_action_named(filter)
 
       if action
         unless action < Action
-          UI.user_error! action_subclass_error(filter)
+          UI.user_error!(action_subclass_error(filter))
         end
 
         print_summary(action, filter)
@@ -62,17 +62,17 @@ module Fastlane
         print_return_value(action, filter)
 
         if Fastlane::Actions.is_deprecated?(action)
-          puts "==========================================".deprecated
-          puts "This action (#{filter}) is deprecated".deprecated
-          puts action.deprecated_notes.to_s.deprecated if action.deprecated_notes
-          puts "==========================================\n".deprecated
+          puts("==========================================".deprecated)
+          puts("This action (#{filter}) is deprecated".deprecated)
+          puts(action.deprecated_notes.to_s.deprecated) if action.deprecated_notes
+          puts("==========================================\n".deprecated)
         end
 
-        puts "More information can be found on https://docs.fastlane.tools/actions/#{filter}"
-        puts ""
+        puts("More information can be found on https://docs.fastlane.tools/actions/#{filter}")
+        puts("")
       else
-        puts "Couldn't find action for the given filter.".red
-        puts "==========================================\n".red
+        puts("Couldn't find action for the given filter.".red)
+        puts("==========================================\n".red)
 
         print_all # show all available actions instead
         print_suggestions(filter)
@@ -93,9 +93,9 @@ module Fastlane
           corrections << spell_checker.correct(filter).compact
         end
 
-        corrections << action_names.select { |name| name.include? filter }
+        corrections << action_names.select { |name| name.include?(filter) }
 
-        puts "Did you mean: #{corrections.flatten.uniq.join(', ')}?".green unless corrections.flatten.empty?
+        puts("Did you mean: #{corrections.flatten.uniq.join(', ')}?".green) unless corrections.flatten.empty?
       end
     end
 
@@ -119,44 +119,44 @@ module Fastlane
       authors = Array(action.author || action.authors)
       rows << ["Created by #{authors.join(', ').green}"] unless authors.empty?
 
-      puts Terminal::Table.new(title: name.green, rows: FastlaneCore::PrintTable.transform_output(rows))
-      puts ""
+      puts(Terminal::Table.new(title: name.green, rows: FastlaneCore::PrintTable.transform_output(rows)))
+      puts("")
     end
 
     def self.print_options(action, name)
       options = parse_options(action.available_options) if action.available_options
 
       if options
-        puts Terminal::Table.new(
-          title: "#{name} Options".green,
-          headings: ['Key', 'Description', 'Env Var', 'Default'],
-          rows: FastlaneCore::PrintTable.transform_output(options)
-        )
+        puts(Terminal::Table.new(
+               title: "#{name} Options".green,
+               headings: ['Key', 'Description', 'Env Var', 'Default'],
+               rows: FastlaneCore::PrintTable.transform_output(options)
+        ))
       else
-        puts "No available options".yellow
+        puts("No available options".yellow)
       end
-      puts ""
+      puts("")
     end
 
     def self.print_output_variables(action, name)
       output = action.output
       return if output.nil? || output.empty?
 
-      puts Terminal::Table.new(
-        title: "#{name} Output Variables".green,
-        headings: ['Key', 'Description'],
-        rows: FastlaneCore::PrintTable.transform_output(output.map { |key, desc| [key.yellow, desc] })
-      )
-      puts "Access the output values using `lane_context[SharedValues::VARIABLE_NAME]`"
-      puts ""
+      puts(Terminal::Table.new(
+             title: "#{name} Output Variables".green,
+             headings: ['Key', 'Description'],
+             rows: FastlaneCore::PrintTable.transform_output(output.map { |key, desc| [key.yellow, desc] })
+      ))
+      puts("Access the output values using `lane_context[SharedValues::VARIABLE_NAME]`")
+      puts("")
     end
 
     def self.print_return_value(action, name)
       return unless action.return_value
 
-      puts Terminal::Table.new(title: "#{name} Return Value".green,
-                                rows: FastlaneCore::PrintTable.transform_output([[action.return_value]]))
-      puts ""
+      puts(Terminal::Table.new(title: "#{name} Return Value".green,
+                                rows: FastlaneCore::PrintTable.transform_output([[action.return_value]])))
+      puts("")
     end
 
     # Iterates through all available actions and yields from there
@@ -170,7 +170,7 @@ module Fastlane
         next if platform && action.respond_to?(:is_supported?) && !action.is_supported?(platform.to_sym)
 
         name = symbol.to_s.gsub('Action', '').fastlane_underscore
-        yield action, name
+        yield(action, name)
       end
     end
 
@@ -185,15 +185,15 @@ module Fastlane
     # Helper:
     def self.parse_options(options, fill_all = true)
       rows = []
-      rows << [options] if options.kind_of? String
+      rows << [options] if options.kind_of?(String)
 
-      if options.kind_of? Array
+      if options.kind_of?(Array)
         options.each do |current|
-          if current.kind_of? FastlaneCore::ConfigItem
+          if current.kind_of?(FastlaneCore::ConfigItem)
             rows << [current.key.to_s.yellow, current.description, current.env_name, current.default_value]
-          elsif current.kind_of? Array
+          elsif current.kind_of?(Array)
             # Legacy actions that don't use the new config manager
-            UI.user_error!("Invalid number of elements in this row: #{current}. Must be 2 or 3") unless [2, 3].include? current.count
+            UI.user_error!("Invalid number of elements in this row: #{current}. Must be 2 or 3") unless [2, 3].include?(current.count)
             rows << current
             rows.last[0] = rows.last.first.yellow # color it yellow :)
             rows.last << nil while fill_all && rows.last.count < 4 # to have a nice border in the table

data/fastlane/lib/fastlane/documentation/docs_generator.rb

@@ -53,7 +53,7 @@ module Fastlane
 
       begin
         File.write(output_path, output.join("\n"))
-        UI.success "Successfully generated documentation at path '#{File.expand_path(output_path)}'" if FastlaneCore::Globals.verbose?
+        UI.success("Successfully generated documentation at path '#{File.expand_path(output_path)}'") if FastlaneCore::Globals.verbose?
       rescue => ex
         UI.error(ex)
         UI.error("Couldn't save fastlane documentation at path '#{File.expand_path(output_path)}', make sure you have write access to the containing directory.")

data/fastlane/lib/fastlane/environment_printer.rb

@@ -8,7 +8,7 @@ module Fastlane
         env_info.gsub!(sensitive_element, "#########")
       end
 
-      puts env_info
+      puts(env_info)
       UI.important("Take notice that this output may contain sensitive information, or simply information that you don't want to make public.")
       if FastlaneCore::Helper.mac? && UI.interactive? && UI.confirm("🙄  Wow, that's a lot of markdown text... should fastlane put it into your clipboard, so you can easily paste it on GitHub?")
         copy_to_clipboard(env_info)
@@ -76,7 +76,7 @@ module Fastlane
           table << "| #{plugin} | #{installed_version} | #{update_status} |\n"
         end
 
-        rendered_table = MarkdownTableFormatter.new table
+        rendered_table = MarkdownTableFormatter.new(table)
         env_output << rendered_table.to_md
       end
 
@@ -119,7 +119,7 @@ module Fastlane
         table << "| #{current_gem.name} | #{current_gem.version} | #{update_status} |\n"
       end
 
-      rendered_table = MarkdownTableFormatter.new table
+      rendered_table = MarkdownTableFormatter.new(table)
       env_output << rendered_table.to_md
 
       env_output << "\n\n"
@@ -138,7 +138,7 @@ module Fastlane
           table << "| #{current_gem.name} | #{current_gem.version} |\n"
         end
       end
-      rendered_table = MarkdownTableFormatter.new table
+      rendered_table = MarkdownTableFormatter.new(table)
 
       env_output << rendered_table.to_md
       env_output << "</details>\n\n"
@@ -169,7 +169,7 @@ module Fastlane
         table << "|-----|---------|----|\n"
         table << env_table
       end
-      rendered_table = MarkdownTableFormatter.new table
+      rendered_table = MarkdownTableFormatter.new(table)
       env_output << rendered_table.to_md
       env_output << "\n\n"
     end