fastlane 2.74.1 → 2.75.0.beta.20180109010003

data/deliver/lib/deliver/submit_for_review.rb

@@ -65,7 +65,7 @@ module Deliver
           UI.message("")
           UI.message("You can tweet: \"iTunes Connect #iosprocessingtime #{((Time.now - start) / 60).round} minutes\"")
         end
-        sleep 30
+        sleep(30)
       end
       nil
     end

data/fastlane/lib/fastlane/action.rb

@@ -30,10 +30,10 @@ module Fastlane
     class << self
       attr_accessor :runner
 
-      extend Forwardable
+      extend(Forwardable)
 
       # to allow a simple `sh` in the custom actions
-      def_delegator Actions, :sh_control_output, :sh
+      def_delegator(Actions, :sh_control_output, :sh)
     end
 
     def self.run(params)

data/fastlane/lib/fastlane/actions/actions_helper.rb

@@ -115,16 +115,16 @@ module Fastlane
           class_ref = Fastlane::Actions.const_get(class_name)
 
           if class_ref.respond_to?(:run)
-            UI.success "Successfully loaded custom action '#{file}'." if FastlaneCore::Globals.verbose?
+            UI.success("Successfully loaded custom action '#{file}'.") if FastlaneCore::Globals.verbose?
           else
-            UI.error "Could not find method 'run' in class #{class_name}."
-            UI.error 'For more information, check out the docs: https://docs.fastlane.tools/'
+            UI.error("Could not find method 'run' in class #{class_name}.")
+            UI.error('For more information, check out the docs: https://docs.fastlane.tools/')
             UI.user_error!("Action '#{file_name}' is damaged!", show_github_issues: true)
           end
         rescue NameError
           # Action not found
-          UI.error "Could not find '#{class_name}' class defined."
-          UI.error 'For more information, check out the docs: https://docs.fastlane.tools/'
+          UI.error("Could not find '#{class_name}' class defined.")
+          UI.error('For more information, check out the docs: https://docs.fastlane.tools/')
           UI.user_error!("Action '#{file_name}' is damaged!", show_github_issues: true)
         end
       end

data/fastlane/lib/fastlane/actions/add_extra_platforms.rb

@@ -2,9 +2,9 @@ module Fastlane
   module Actions
     class AddExtraPlatformsAction < Action
       def self.run(params)
-        UI.verbose "Before injecting extra platforms: #{Fastlane::SupportedPlatforms.all}"
+        UI.verbose("Before injecting extra platforms: #{Fastlane::SupportedPlatforms.all}")
         Fastlane::SupportedPlatforms.extra = params[:platforms]
-        UI.verbose "After injecting extra platforms (#{params[:platforms]})...: #{Fastlane::SupportedPlatforms.all}"
+        UI.verbose("After injecting extra platforms (#{params[:platforms]})...: #{Fastlane::SupportedPlatforms.all}")
       end
 
       def self.description

data/fastlane/lib/fastlane/actions/add_git_tag.rb

@@ -17,7 +17,7 @@ module Fastlane
         cmd << "'#{tag}'"
         cmd << options[:commit].to_s if options[:commit]
 
-        UI.message "Adding git tag '#{tag}' 🎯."
+        UI.message("Adding git tag '#{tag}' 🎯.")
         Actions.sh(cmd.join(' '))
       end
 

data/fastlane/lib/fastlane/actions/app_store_build_number.rb

@@ -112,7 +112,7 @@ module Fastlane
                                        is_string: true,
                                        default_value: "ios",
                                        verify_block: proc do |value|
-                                         UI.user_error!("The platform can only be ios, appletvos, or osx") unless %('ios', 'appletvos', 'osx').include? value
+                                         UI.user_error!("The platform can only be ios, appletvos, or osx") unless %('ios', 'appletvos', 'osx').include?(value)
                                        end),
           FastlaneCore::ConfigItem.new(key: :team_name,
                                        short_option: "-e",

data/fastlane/lib/fastlane/actions/appaloosa.rb

@@ -28,7 +28,7 @@ module Fastlane
         http.use_ssl = true
         presign_form_response = http.request(Net::HTTP::Get.new(uri.request_uri))
         json_res = JSON.parse(presign_form_response.body)
-        return if error_detected json_res['errors']
+        return if error_detected(json_res['errors'])
         s3_sign = json_res['s3_sign']
         path = json_res['path']
         uri = URI.parse(Base64.decode64(s3_sign))
@@ -123,9 +123,9 @@ module Fastlane
         uoa_response = http.request(req)
         json_res = JSON.parse(uoa_response.body)
         if json_res['errors']
-          UI.error "App: #{json_res['errors']}"
+          UI.error("App: #{json_res['errors']}")
         else
-          UI.success "Binary processing: Check your app': #{json_res['link']}"
+          UI.success("Binary processing: Check your app': #{json_res['link']}")
         end
       end
 
@@ -226,7 +226,7 @@ module Fastlane
       end
 
       def self.is_supported?(platform)
-        [:ios, :mac, :android].include? platform
+        [:ios, :mac, :android].include?(platform)
       end
 
       def self.invalid_response?(url_for_download_response)

data/fastlane/lib/fastlane/actions/appetize.rb

@@ -38,9 +38,9 @@ module Fastlane
         http.use_ssl = true
 
         if params[:platform] == 'ios'
-          UI.message "Uploading ipa to appetize... this might take a while"
+          UI.message("Uploading ipa to appetize... this might take a while")
         else
-          UI.message "Uploading apk to appetize... this might take a while"
+          UI.message("Uploading apk to appetize... this might take a while")
         end
 
         response = http.request(req)
@@ -81,7 +81,7 @@ module Fastlane
         Actions.lane_context[SharedValues::APPETIZE_MANAGE_URL] = manage_url
         return true
       rescue => ex
-        UI.error ex
+        UI.error(ex)
         UI.user_error!("Error uploading to Appetize.io: #{response.body}")
       end
       private_class_method :parse_response

data/fastlane/lib/fastlane/actions/appetize_viewing_url_generator.rb

@@ -27,8 +27,8 @@ module Fastlane
         url_params << "launchUrl=#{params[:launch_url]}" if params[:launch_url]
         url_params << "language=#{params[:language]}" if params[:language]
         url_params << "osVersion=#{params[:os_version]}" if params[:os_version]
-        url_params << "params=#{CGI.escape params[:params]}" if params[:params]
-        url_params << "proxy=#{CGI.escape params[:proxy]}" if params[:proxy]
+        url_params << "params=#{CGI.escape(params[:params])}" if params[:params]
+        url_params << "proxy=#{CGI.escape(params[:proxy])}" if params[:proxy]
 
         return link + "?" + url_params.join("&")
       end

data/fastlane/lib/fastlane/actions/appium.rb

@@ -32,7 +32,7 @@ module Fastlane
           UI.user_error!("Failed to run Appium spec. status code: #{status}")
         end
       ensure
-        Actions.sh "kill #{appium_pid}" if appium_pid
+        Actions.sh("kill #{appium_pid}") if appium_pid
       end
 
       def self.invoke_appium_server(params)
@@ -72,7 +72,7 @@ module Fastlane
           if count * 5 > INVOKE_TIMEOUT
             UI.user_error!("Invoke Appium server timed out")
           end
-          sleep 5
+          sleep(5)
         end
       end
 

data/fastlane/lib/fastlane/actions/appledoc.rb

@@ -74,7 +74,7 @@ module Fastlane
         input_cli_arg = Array(params_hash[:input]).map(&:shellescape).join(' ')
         command = "appledoc #{cli_args}".strip + " " + input_cli_arg
         UI.verbose(command)
-        Actions.sh command
+        Actions.sh(command)
       end
 
       def self.params_hash_to_cli_args(params)
@@ -109,8 +109,8 @@ module Fastlane
         output_dir = File.dirname(output_path)
 
         # If the output directory doesn't exist, create it
-        unless Dir.exist? output_dir
-          FileUtils.mkpath output_dir
+        unless Dir.exist?(output_dir)
+          FileUtils.mkpath(output_dir)
         end
       end
 

data/fastlane/lib/fastlane/actions/apteligent.rb

@@ -18,9 +18,9 @@ module Fastlane
 
       def self.fail_on_error(result)
         if result != "200"
-          UI.crash! "Server error, failed to upload the dSYM file."
+          UI.crash!("Server error, failed to upload the dSYM file.")
         else
-          UI.success 'dSYM successfully uploaded to Apteligent!'
+          UI.success('dSYM successfully uploaded to Apteligent!')
         end
       end
 

data/fastlane/lib/fastlane/actions/artifactory.rb

@@ -11,7 +11,7 @@ module Fastlane
 
         require 'artifactory'
         file_path = File.absolute_path(params[:file])
-        if File.exist? file_path
+        if File.exist?(file_path)
           client = connect_to_artifactory(params)
           artifact = Artifactory::Resource::Artifact.new
           artifact.client = client
@@ -39,7 +39,7 @@ module Fastlane
       def self.connect_to_artifactory(params)
         config_keys = [:endpoint, :username, :password, :ssl_pem_file, :ssl_verify, :proxy_username, :proxy_password, :proxy_address, :proxy_port]
         config = params.values.select do |key|
-          config_keys.include? key
+          config_keys.include?(key)
         end
         Artifactory::Client.new(config)
       end

data/fastlane/lib/fastlane/actions/backup_xcarchive.rb

@@ -110,7 +110,7 @@ module Fastlane
       end
 
       def self.is_supported?(platform)
-        [:ios, :mac].include? platform
+        [:ios, :mac].include?(platform)
       end
 
       def self.example_code

data/fastlane/lib/fastlane/actions/build_ios_app.rb

@@ -107,7 +107,7 @@ module Fastlane
       end
 
       def self.is_supported?(platform)
-        [:ios, :mac].include? platform
+        [:ios, :mac].include?(platform)
       end
 
       def self.example_code

data/fastlane/lib/fastlane/actions/capture_ios_screenshots.rb

@@ -33,7 +33,7 @@ module Fastlane
       end
 
       def self.is_supported?(platform)
-        [:ios, :mac].include? platform
+        [:ios, :mac].include?(platform)
       end
 
       def self.example_code

data/fastlane/lib/fastlane/actions/carthage.rb

@@ -10,9 +10,9 @@ module Fastlane
         cmd << command_name
 
         if command_name == "archive" && params[:frameworks].count > 0
-          cmd.concat params[:frameworks]
+          cmd.concat(params[:frameworks])
         elsif (command_name == "update" || command_name == "build") && params[:dependencies].count > 0
-          cmd.concat params[:dependencies]
+          cmd.concat(params[:dependencies])
         end
 
         cmd << "--output #{params[:output]}" if params[:output]
@@ -63,7 +63,7 @@ module Fastlane
                                        description: "Carthage command (one of: #{available_commands.join(', ')})",
                                        default_value: 'bootstrap',
                                        verify_block: proc do |value|
-                                         UI.user_error!("Please pass a valid command. Use one of the following: #{available_commands.join(', ')}") unless available_commands.include? value
+                                         UI.user_error!("Please pass a valid command. Use one of the following: #{available_commands.join(', ')}") unless available_commands.include?(value)
                                        end),
           FastlaneCore::ConfigItem.new(key: :dependencies,
                                        description: "Carthage dependencies to update or build",
@@ -190,7 +190,7 @@ module Fastlane
       end
 
       def self.is_supported?(platform)
-        [:ios, :mac].include? platform
+        [:ios, :mac].include?(platform)
       end
 
       def self.authors

data/fastlane/lib/fastlane/actions/changelog_from_git_commits.rb

@@ -37,9 +37,9 @@ module Fastlane
         changelog = changelog.gsub("\n\n", "\n") if changelog # as there are duplicate newlines
         Actions.lane_context[SharedValues::FL_CHANGELOG] = changelog
 
-        puts ""
-        puts changelog
-        puts ""
+        puts("")
+        puts(changelog)
+        puts("")
 
         changelog
       end
@@ -117,7 +117,7 @@ module Fastlane
                                        is_string: false,
                                        type: Boolean,
                                        verify_block: proc do |value|
-                                         UI.important "The :include_merges option is deprecated. Please use :merge_commit_filtering instead" unless value.nil?
+                                         UI.important("The :include_merges option is deprecated. Please use :merge_commit_filtering instead") unless value.nil?
                                        end),
           FastlaneCore::ConfigItem.new(key: :merge_commit_filtering,
                                        env_name: 'FL_CHANGELOG_FROM_GIT_COMMITS_MERGE_COMMIT_FILTERING',

data/fastlane/lib/fastlane/actions/clean_build_artifacts.rb

@@ -51,7 +51,7 @@ module Fastlane
       end
 
       def self.is_supported?(platform)
-        [:ios, :mac].include? platform
+        [:ios, :mac].include?(platform)
       end
 
       def self.example_code

data/fastlane/lib/fastlane/actions/clean_cocoapods_cache.rb

@@ -34,7 +34,7 @@ module Fastlane
       end
 
       def self.is_supported?(platform)
-        [:ios, :mac].include? platform
+        [:ios, :mac].include?(platform)
       end
 
       def self.example_code

data/fastlane/lib/fastlane/actions/cloc.rb

@@ -18,7 +18,7 @@ module Fastlane
           source_directory
         ].join(' ').strip
 
-        Actions.sh command
+        Actions.sh(command)
       end
 
       def self.description

data/fastlane/lib/fastlane/actions/cocoapods.rb

@@ -116,7 +116,7 @@ module Fastlane
       end
 
       def self.is_supported?(platform)
-        [:ios, :mac].include? platform
+        [:ios, :mac].include?(platform)
       end
 
       def self.authors

data/fastlane/lib/fastlane/actions/commit_github_file.rb

@@ -19,8 +19,8 @@ module Fastlane
         UI.important("Creating commit on #{repo_name} on branch \"#{branch}\" for file \"#{file_path}\"")
 
         api_file_path = file_path
-        api_file_path = "/#{api_file_path}" unless api_file_path.start_with? '/'
-        api_file_path = api_file_path[0..-2] if api_file_path.end_with? '/'
+        api_file_path = "/#{api_file_path}" unless api_file_path.start_with?('/')
+        api_file_path = api_file_path[0..-2] if api_file_path.end_with?('/')
 
         payload = {
           path: api_file_path,
@@ -89,7 +89,7 @@ module Fastlane
                                        env_name: "FL_COMMIT_GITHUB_FILE_REPOSITORY_NAME",
                                        description: "The path to your repo, e.g. 'fastlane/fastlane'",
                                        verify_block: proc do |value|
-                                         UI.user_error!("Please only pass the path, e.g. 'fastlane/fastlane'") if value.include? "github.com"
+                                         UI.user_error!("Please only pass the path, e.g. 'fastlane/fastlane'") if value.include?("github.com")
                                          UI.user_error!("Please only pass the path, e.g. 'fastlane/fastlane'") if value.split('/').count != 2
                                        end),
           FastlaneCore::ConfigItem.new(key: :server_url,
@@ -98,7 +98,7 @@ module Fastlane
                                        default_value: "https://api.github.com",
                                        optional: true,
                                        verify_block: proc do |value|
-                                         UI.user_error!("Please include the protocol in the server url, e.g. https://your.github.server/api/v3") unless value.include? "//"
+                                         UI.user_error!("Please include the protocol in the server url, e.g. https://your.github.server/api/v3") unless value.include?("//")
                                        end),
           FastlaneCore::ConfigItem.new(key: :api_token,
                                        env_name: "FL_COMMIT_GITHUB_FILE_API_TOKEN",

data/fastlane/lib/fastlane/actions/commit_version_bump.rb

@@ -88,7 +88,7 @@ module Fastlane
 
         if params[:settings]
           settings_plists_from_param(params[:settings]).each do |file|
-            settings_file_pathname = Pathname.new settings_bundle_file_path(project, file)
+            settings_file_pathname = Pathname.new(settings_bundle_file_path(project, file))
             expected_changed_files << settings_file_pathname.relative_path_from(repo_pathname).to_s
           end
         end
@@ -102,7 +102,7 @@ module Fastlane
         UI.user_error!("No file changes picked up. Make sure you run the `increment_build_number` action first.") if git_dirty_files.empty?
 
         # check if the files changed are the ones we expected to change (these should be only the files that have version info in them)
-        changed_files_as_expected = (Set.new(git_dirty_files.map(&:downcase)).subset? Set.new(expected_changed_files.map(&:downcase)))
+        changed_files_as_expected = Set.new(git_dirty_files.map(&:downcase)).subset?(Set.new(expected_changed_files.map(&:downcase)))
         unless changed_files_as_expected
           unless params[:force]
             error = [
@@ -155,7 +155,7 @@ module Fastlane
                                        description: "The path to your project file (Not the workspace). If you have only one, this is optional",
                                        optional: true,
                                        verify_block: proc do |value|
-                                         UI.user_error!("Please pass the path to the project, not the workspace") if value.end_with? ".xcworkspace"
+                                         UI.user_error!("Please pass the path to the project, not the workspace") if value.end_with?(".xcworkspace")
                                          UI.user_error!("Could not find Xcode project") unless File.exist?(value)
                                        end),
           FastlaneCore::ConfigItem.new(key: :force,
@@ -204,7 +204,7 @@ module Fastlane
       end
 
       def self.is_supported?(platform)
-        [:ios, :mac].include? platform
+        [:ios, :mac].include?(platform)
       end
 
       def self.example_code
@@ -238,10 +238,10 @@ module Fastlane
 
       class << self
         def settings_plists_from_param(param)
-          if param.kind_of? String
+          if param.kind_of?(String)
             # commit_version_bump settings: "About.plist"
             return [param]
-          elsif param.kind_of? Array
+          elsif param.kind_of?(Array)
             # commit_version_bump settings: ["Root.plist", "About.plist"]
             return param
           else
@@ -260,7 +260,7 @@ module Fastlane
         def modified_files_relative_to_repo_root(repo_root)
           return [] if Actions.lane_context[SharedValues::MODIFIED_FILES].nil?
 
-          root_pathname = Pathname.new repo_root
+          root_pathname = Pathname.new(repo_root)
           all_modified_files = Actions.lane_context[SharedValues::MODIFIED_FILES].map do |path|
             next path unless path =~ %r{^/}
             Pathname.new(path).relative_path_from(root_pathname).to_s

data/fastlane/lib/fastlane/actions/copy_artifacts.rb

@@ -23,7 +23,7 @@ module Fastlane
 
         if params[:fail_on_missing]
           missing = artifacts.reject { |a| File.exist?(a) }
-          UI.user_error! "Not all files were present in copy artifacts. Missing #{missing.join(', ')}" unless missing.empty?
+          UI.user_error!("Not all files were present in copy artifacts. Missing #{missing.join(', ')}") unless missing.empty?
         else
           # If we don't fail on non-existent files, don't try to copy non-existent files
           artifacts.select! { |artifact| File.exist?(artifact) }

data/fastlane/lib/fastlane/actions/crashlytics.rb

@@ -35,7 +35,7 @@ module Fastlane
                  .gsub(params[:build_secret], '[[BUILD_SECRET]]')
         end
 
-        UI.verbose sanitizer.call(command.join(' ')) if FastlaneCore::Globals.verbose?
+        UI.verbose(sanitizer.call(command.join(' '))) if FastlaneCore::Globals.verbose?
 
         error_callback = proc do |error|
           clean_error = sanitizer.call(error)
@@ -51,7 +51,7 @@ module Fastlane
 
         return command if Helper.test?
 
-        UI.verbose sanitizer.call(result) if FastlaneCore::Globals.verbose?
+        UI.verbose(sanitizer.call(result)) if FastlaneCore::Globals.verbose?
 
         UI.success('Build successfully uploaded to Crashlytics Beta 🌷')
         UI.success('Visit https://fabric.io/_/beta to add release notes and notify testers.')