fastlane 2.74.1 → 2.75.0.beta.20180109010003

data/gym/lib/gym/generators/build_command_generator.rb

@@ -106,7 +106,7 @@ module Gym
       def build_path
         unless Gym.cache[:build_path]
           Gym.cache[:build_path] = Gym.config[:build_path]
-          FileUtils.mkdir_p Gym.cache[:build_path]
+          FileUtils.mkdir_p(Gym.cache[:build_path])
         end
         Gym.cache[:build_path]
       end

data/gym/lib/gym/runner.rb

@@ -64,11 +64,11 @@ module Gym
         end
       end
 
-      puts Terminal::Table.new(
-        title: title.green,
-        headings: ["Option", "Value"],
-        rows: FastlaneCore::PrintTable.transform_output(rows.delete_if { |c| c.to_s.empty? })
-      )
+      puts(Terminal::Table.new(
+             title: title.green,
+             headings: ["Option", "Value"],
+             rows: FastlaneCore::PrintTable.transform_output(rows.delete_if { |c| c.to_s.empty? })
+      ))
     end
 
     private
@@ -99,7 +99,7 @@ module Gym
                                               end)
 
       mark_archive_as_built_by_gym(BuildCommandGenerator.archive_path)
-      UI.success "Successfully stored the archive. You can find it in the Xcode Organizer." unless Gym.config[:archive_path].nil?
+      UI.success("Successfully stored the archive. You can find it in the Xcode Organizer.") unless Gym.config[:archive_path].nil?
       UI.verbose("Stored the archive in: " + BuildCommandGenerator.archive_path)
     end
 
@@ -130,15 +130,15 @@ module Gym
       containing_directory = File.expand_path("..", PackageCommandGenerator.dsym_path)
 
       available_dsyms = Dir.glob("#{containing_directory}/*.dSYM")
-      UI.message "Compressing #{available_dsyms.count} dSYM(s)" unless Gym.config[:silent]
+      UI.message("Compressing #{available_dsyms.count} dSYM(s)") unless Gym.config[:silent]
 
       output_path = File.expand_path(File.join(Gym.config[:output_directory], Gym.config[:output_name] + ".app.dSYM.zip"))
       command = "cd '#{containing_directory}' && zip -r '#{output_path}' *.dSYM"
       Helper.backticks(command, print: !Gym.config[:silent])
 
-      puts "" # new line
+      puts("") # new line
 
-      UI.success "Successfully exported and compressed dSYM file"
+      UI.success("Successfully exported and compressed dSYM file")
     end
 
     # Moves over the binary and dsym file to the output directory
@@ -147,26 +147,26 @@ module Gym
       FileUtils.mv(PackageCommandGenerator.ipa_path, File.expand_path(Gym.config[:output_directory]), force: true)
       ipa_path = File.expand_path(File.join(Gym.config[:output_directory], File.basename(PackageCommandGenerator.ipa_path)))
 
-      UI.success "Successfully exported and signed the ipa file:"
-      UI.message ipa_path
+      UI.success("Successfully exported and signed the ipa file:")
+      UI.message(ipa_path)
       ipa_path
     end
 
     # copys framework from temp folder:
 
     def copy_files_from_path(path)
-      UI.success "Exporting Files:"
+      UI.success("Exporting Files:")
       Dir[path].each do |f|
         existing_file = File.join(File.expand_path(Gym.config[:output_directory]), File.basename(f))
         # If the target file already exists in output directory
         # we have to remove it first, otherwise cp_r fails even with remove_destination
         # e.g.: there are symlinks in the .framework
         if File.exist?(existing_file)
-          UI.important "Removing #{File.basename(f)} from output directory" if FastlaneCore::Globals.verbose?
+          UI.important("Removing #{File.basename(f)} from output directory") if FastlaneCore::Globals.verbose?
           FileUtils.rm_rf(existing_file)
         end
         FileUtils.cp_r(f, File.expand_path(Gym.config[:output_directory]), remove_destination: true)
-        UI.message "\t ▸ #{File.basename(f)}"
+        UI.message("\t ▸ #{File.basename(f)}")
       end
     end
 
@@ -177,8 +177,8 @@ module Gym
       UI.crash!("Couldn't find application in '#{BuildCommandGenerator.archive_path}'") unless File.exist?(app_path)
       FileUtils.cp_r(app_path, File.expand_path(Gym.config[:output_directory]), remove_destination: true)
       app_path = File.join(Gym.config[:output_directory], File.basename(app_path))
-      UI.success "Successfully exported the .app file:"
-      UI.message app_path
+      UI.success("Successfully exported the .app file:")
+      UI.message(app_path)
       app_path
     end
 
@@ -188,8 +188,8 @@ module Gym
         FileUtils.mv(PackageCommandGenerator.manifest_path, File.expand_path(Gym.config[:output_directory]), force: true)
         manifest_path = File.join(File.expand_path(Gym.config[:output_directory]), File.basename(PackageCommandGenerator.manifest_path))
 
-        UI.success "Successfully exported the manifest.plist file:"
-        UI.message manifest_path
+        UI.success("Successfully exported the manifest.plist file:")
+        UI.message(manifest_path)
         manifest_path
       end
     end
@@ -200,8 +200,8 @@ module Gym
         FileUtils.mv(PackageCommandGenerator.app_thinning_path, File.expand_path(Gym.config[:output_directory]), force: true)
         app_thinning_path = File.join(File.expand_path(Gym.config[:output_directory]), File.basename(PackageCommandGenerator.app_thinning_path))
 
-        UI.success "Successfully exported the app-thinning.plist file:"
-        UI.message app_thinning_path
+        UI.success("Successfully exported the app-thinning.plist file:")
+        UI.message(app_thinning_path)
         app_thinning_path
       end
     end
@@ -212,8 +212,8 @@ module Gym
         FileUtils.mv(PackageCommandGenerator.app_thinning_size_report_path, File.expand_path(Gym.config[:output_directory]), force: true)
         app_thinning_size_report_path = File.join(File.expand_path(Gym.config[:output_directory]), File.basename(PackageCommandGenerator.app_thinning_size_report_path))
 
-        UI.success "Successfully exported the App Thinning Size Report.txt file:"
-        UI.message app_thinning_size_report_path
+        UI.success("Successfully exported the App Thinning Size Report.txt file:")
+        UI.message(app_thinning_size_report_path)
         app_thinning_size_report_path
       end
     end
@@ -224,8 +224,8 @@ module Gym
         FileUtils.mv(PackageCommandGenerator.apps_path, File.expand_path(Gym.config[:output_directory]), force: true)
         apps_path = File.join(File.expand_path(Gym.config[:output_directory]), File.basename(PackageCommandGenerator.apps_path))
 
-        UI.success "Successfully exported Apps folder:"
-        UI.message apps_path
+        UI.success("Successfully exported Apps folder:")
+        UI.message(apps_path)
         apps_path
       end
     end

data/gym/lib/gym/xcodebuild_fixes/generic_archive_fix.rb

@@ -15,11 +15,11 @@ module Gym
       # This is a workaround for this bug
       # https://github.com/CocoaPods/CocoaPods/issues/4178
       def generic_archive_fix
-        UI.verbose "Looking For Orphaned WatchKit2 Applications"
+        UI.verbose("Looking For Orphaned WatchKit2 Applications")
 
         Dir.glob("#{BuildCommandGenerator.archive_path}/Products/Applications/*.app").each do |app_path|
           if is_watchkit_app?(app_path)
-            UI.verbose "Removing Orphaned WatchKit2 Application #{app_path}"
+            UI.verbose("Removing Orphaned WatchKit2 Application #{app_path}")
             FileUtils.rm_rf(app_path)
           end
         end

data/match/lib/assets/READMETemplate.md

@@ -1,4 +1,4 @@
-## [fastlane match](https://github.com/fastlane/fastlane/tree/master/match#readme)
+## [fastlane match](https://docs.fastlane.tools/actions/match)
 
 This repository contains all your certificates and provisioning profiles needed to build and sign your applications. They are encrypted using OpenSSL via a passphrase.
 
@@ -40,7 +40,7 @@ fastlane match development
 fastlane match enterprise
 ```
 
-For more information open [fastlane match git repo](https://github.com/fastlane/fastlane/tree/master/match#readme)
+For more information open [fastlane match git repo](https://docs.fastlane.tools/actions/match)
 
 ### Content
 
@@ -54,4 +54,4 @@ This directory contains all provisioning profiles
 
 ------------------------------------
 
-For more information open [fastlane match git repo](https://github.com/fastlane/fastlane/tree/master/match#readme)
+For more information open [fastlane match git repo](https://docs.fastlane.tools/actions/match)

data/match/lib/match/commands_generator.rb

@@ -96,7 +96,7 @@ module Match
           params.load_configuration_file("Matchfile")
 
           Match::ChangePassword.update(params: params)
-          UI.success "Successfully changed the password. Make sure to update the password on all your clients and servers"
+          UI.success("Successfully changed the password. Make sure to update the password on all your clients and servers")
         end
       end
 
@@ -113,7 +113,7 @@ module Match
                                                   params[:shallow_clone],
                                                   branch: params[:git_branch],
                                                   clone_branch_directly: params[:clone_branch_directly])
-          UI.success "Repo is at: '#{decrypted_repo}'"
+          UI.success("Repo is at: '#{decrypted_repo}'")
         end
       end
 
@@ -141,7 +141,7 @@ module Match
         end
       end
 
-      default_command :run
+      default_command(:run)
 
       run!
     end

data/match/lib/match/encrypt.rb

@@ -20,13 +20,13 @@ module Match
 
       unless password
         if !UI.interactive?
-          UI.error "Neither the MATCH_PASSWORD environment variable nor the local keychain contained a password."
-          UI.error "Bailing out instead of asking for a password, since this is non-interactive mode."
+          UI.error("Neither the MATCH_PASSWORD environment variable nor the local keychain contained a password.")
+          UI.error("Bailing out instead of asking for a password, since this is non-interactive mode.")
           UI.user_error!("Try setting the MATCH_PASSWORD environment variable, or temporarily enable interactive mode to store a password.")
         else
-          UI.important "Enter the passphrase that should be used to encrypt/decrypt your certificates"
-          UI.important "This passphrase is specific per repository and will be stored in your local keychain"
-          UI.important "Make sure to remember the password, as you'll need it when you run match on a different machine"
+          UI.important("Enter the passphrase that should be used to encrypt/decrypt your certificates")
+          UI.important("This passphrase is specific per repository and will be stored in your local keychain")
+          UI.important("Make sure to remember the password, as you'll need it when you run match on a different machine")
           password = ChangePassword.ask_password(confirm: true)
           store_password(git_url, password)
         end
@@ -49,9 +49,9 @@ module Match
         crypt(path: current,
           password: password(git_url),
            encrypt: true)
-        UI.success "🔒  Encrypted '#{File.basename(current)}'" if FastlaneCore::Globals.verbose?
+        UI.success("🔒  Encrypted '#{File.basename(current)}'") if FastlaneCore::Globals.verbose?
       end
-      UI.success "🔒  Successfully encrypted certificates repo"
+      UI.success("🔒  Successfully encrypted certificates repo")
     end
 
     def decrypt_repo(path: nil, git_url: nil, manual_password: nil)
@@ -61,15 +61,15 @@ module Match
             password: manual_password || password(git_url),
              encrypt: false)
         rescue
-          UI.error "Couldn't decrypt the repo, please make sure you enter the right password!"
+          UI.error("Couldn't decrypt the repo, please make sure you enter the right password!")
           UI.user_error!("Invalid password passed via 'MATCH_PASSWORD'") if ENV["MATCH_PASSWORD"]
           clear_password(git_url)
           decrypt_repo(path: path, git_url: git_url)
           return
         end
-        UI.success "🔓  Decrypted '#{File.basename(current)}'" if FastlaneCore::Globals.verbose?
+        UI.success("🔓  Decrypted '#{File.basename(current)}'") if FastlaneCore::Globals.verbose?
       end
-      UI.success "🔓  Successfully decrypted certificates repo"
+      UI.success("🔓  Successfully decrypted certificates repo")
     end
 
     private

data/match/lib/match/git_helper.rb

@@ -32,7 +32,7 @@ module Match
         command += " -b #{branch.shellescape} --single-branch"
       end
 
-      UI.message "Cloning remote git repo..."
+      UI.message("Cloning remote git repo...")
 
       if branch && !clone_branch_directly
         UI.message("If cloning the repo takes too long, you can use the `clone_branch_directly` option in match.")
@@ -60,7 +60,7 @@ module Match
       checkout_branch(branch) unless branch == "master"
 
       if !Helper.test? and GitHelper.match_version(@dir).nil? and manual_password.nil? and File.exist?(File.join(@dir, "README.md"))
-        UI.important "Migrating to new match..."
+        UI.important("Migrating to new match...")
         ChangePassword.update(params: { git_url: git_url,
                                     git_branch: branch,
                                  shallow_clone: shallow_clone },
@@ -128,7 +128,7 @@ module Match
         commands << "git commit -m #{message.shellescape}"
         commands << "GIT_TERMINAL_PROMPT=0 git push origin #{branch.shellescape}"
 
-        UI.message "Pushing changes to remote git repo..."
+        UI.message("Pushing changes to remote git repo...")
 
         commands.each do |command|
           FastlaneCore::CommandExecutor.execute(command: command,
@@ -165,7 +165,7 @@ module Match
         commands << "git reset --hard"
       end
 
-      UI.message "Checking out branch #{branch}..."
+      UI.message("Checking out branch #{branch}...")
 
       Dir.chdir(@dir) do
         commands.each do |command|
@@ -196,7 +196,7 @@ module Match
 
       return if commands.empty?
 
-      UI.message "Add git user config to local git repo..."
+      UI.message("Add git user config to local git repo...")
       Dir.chdir(@dir) do
         commands.each do |command|
           FastlaneCore::CommandExecutor.execute(command: command,

data/match/lib/match/nuke.rb

@@ -42,27 +42,27 @@ module Match
 
       if (self.certs + self.profiles + self.files).count > 0
         unless params[:skip_confirmation]
-          UI.error "---"
-          UI.error "Are you sure you want to completely delete and revoke all the"
-          UI.error "certificates and provisioning profiles listed above? (y/n)"
-          UI.error "Warning: By nuking distribution, both App Store and Ad Hoc profiles will be deleted" if type == "distribution"
-          UI.error "Warning: The :app_identifier value will be ignored - this will delete all profiles for all your apps!" if had_app_identifier
-          UI.error "---"
+          UI.error("---")
+          UI.error("Are you sure you want to completely delete and revoke all the")
+          UI.error("certificates and provisioning profiles listed above? (y/n)")
+          UI.error("Warning: By nuking distribution, both App Store and Ad Hoc profiles will be deleted") if type == "distribution"
+          UI.error("Warning: The :app_identifier value will be ignored - this will delete all profiles for all your apps!") if had_app_identifier
+          UI.error("---")
         end
         if params[:skip_confirmation] || UI.confirm("Do you really want to nuke everything listed above?")
           nuke_it_now!
-          UI.success "Successfully cleaned your account ♻️"
+          UI.success("Successfully cleaned your account ♻️")
         else
-          UI.success "Cancelled nuking #thanks 🏠 👨 ‍👩 ‍👧"
+          UI.success("Cancelled nuking #thanks 🏠 👨 ‍👩 ‍👧")
         end
       else
-        UI.success "No relevant certificates or provisioning profiles found, nothing to nuke here :)"
+        UI.success("No relevant certificates or provisioning profiles found, nothing to nuke here :)")
       end
     end
 
     # Collect all the certs/profiles
     def prepare_list
-      UI.message "Fetching certificates and profiles..."
+      UI.message("Fetching certificates and profiles...")
       cert_type = Match.cert_type_sym(type)
 
       prov_types = []
@@ -93,15 +93,15 @@ module Match
 
     # Print tables to ask the user
     def print_tables
-      puts ""
+      puts("")
       if self.certs.count > 0
         rows = self.certs.collect { |c| [c.name, c.id, c.class.to_s.split("::").last, c.expires.strftime("%Y-%m-%d")] }
-        puts Terminal::Table.new({
+        puts(Terminal::Table.new({
           title: "Certificates that are going to be revoked".green,
           headings: ["Name", "ID", "Type", "Expires"],
           rows: FastlaneCore::PrintTable.transform_output(rows)
-        })
-        puts ""
+        }))
+        puts("")
       end
 
       if self.profiles.count > 0
@@ -110,12 +110,12 @@ module Match
 
           [p.name, p.id, status, p.type, p.expires.strftime("%Y-%m-%d")]
         end
-        puts Terminal::Table.new({
+        puts(Terminal::Table.new({
           title: "Provisioning Profiles that are going to be revoked".green,
           headings: ["Name", "ID", "Status", "Type", "Expires"],
           rows: FastlaneCore::PrintTable.transform_output(rows)
-        })
-        puts ""
+        }))
+        puts("")
       end
 
       if self.files.count > 0
@@ -127,36 +127,36 @@ module Match
 
           [file_type, components[2]]
         end
-        puts Terminal::Table.new({
+        puts(Terminal::Table.new({
           title: "Files that are going to be deleted".green,
           headings: ["Type", "File Name"],
           rows: rows
-        })
-        puts ""
+        }))
+        puts("")
       end
     end
 
     def nuke_it_now!
-      UI.header "Deleting #{self.profiles.count} provisioning profiles..." unless self.profiles.count == 0
+      UI.header("Deleting #{self.profiles.count} provisioning profiles...") unless self.profiles.count == 0
       self.profiles.each do |profile|
-        UI.message "Deleting profile '#{profile.name}' (#{profile.id})..."
+        UI.message("Deleting profile '#{profile.name}' (#{profile.id})...")
         begin
           profile.delete!
         rescue => ex
           UI.message(ex.to_s)
         end
-        UI.success "Successfully deleted profile"
+        UI.success("Successfully deleted profile")
       end
 
-      UI.header "Revoking #{self.certs.count} certificates..." unless self.certs.count == 0
+      UI.header("Revoking #{self.certs.count} certificates...") unless self.certs.count == 0
       self.certs.each do |cert|
-        UI.message "Revoking certificate '#{cert.name}' (#{cert.id})..."
+        UI.message("Revoking certificate '#{cert.name}' (#{cert.id})...")
         begin
           cert.revoke!
         rescue => ex
           UI.message(ex.to_s)
         end
-        UI.success "Successfully deleted certificate"
+        UI.success("Successfully deleted certificate")
       end
 
       if self.files.count > 0
@@ -171,10 +171,10 @@ module Match
     private
 
     def delete_files!
-      UI.header "Deleting #{self.files.count} files from the git repo..."
+      UI.header("Deleting #{self.files.count} files from the git repo...")
 
       self.files.each do |file|
-        UI.message "Deleting file '#{File.basename(file)}'..."
+        UI.message("Deleting file '#{File.basename(file)}'...")
 
         # Check if the profile is installed on the local machine
         if file.end_with?("mobileprovision")
@@ -185,7 +185,7 @@ module Match
         end
 
         File.delete(file)
-        UI.success "Successfully deleted file"
+        UI.success("Successfully deleted file")
       end
     end
 

data/match/lib/match/runner.rb

@@ -77,7 +77,7 @@ module Match
         TablePrinter.print_summary(app_identifier: app_identifier, type: params[:type], platform: params[:platform])
       end
 
-      UI.success "All required keys, certificates and provisioning profiles are installed 🙌".green
+      UI.success("All required keys, certificates and provisioning profiles are installed 🙌".green)
     rescue Spaceship::Client::UnexpectedResponse, Spaceship::Client::InvalidUserCredentialsError, Spaceship::Client::NoUserCredentialsError => ex
       UI.error("An error occurred while verifying your certificates and profiles with the Apple Developer Portal.")
       UI.error("If you already have your certificates stored in git, you can run `fastlane match` in readonly mode")
@@ -95,7 +95,7 @@ module Match
       keys = Dir[File.join(params[:workspace], "certs", cert_type.to_s, "*.p12")]
 
       if certs.count == 0 or keys.count == 0
-        UI.important "Couldn't find a valid code signing identity in the git repo for #{cert_type}... creating one for you now"
+        UI.important("Couldn't find a valid code signing identity in the git repo for #{cert_type}... creating one for you now")
         UI.crash!("No code signing identity found and can not create a new one because you enabled `readonly`") if params[:readonly]
         cert_path = Generator.generate_certificate(params, cert_type)
         private_key_path = cert_path.gsub(".cer", ".p12")
@@ -104,10 +104,10 @@ module Match
         self.files_to_commmit << private_key_path
       else
         cert_path = certs.last
-        UI.message "Installing certificate..."
+        UI.message("Installing certificate...")
 
         if FastlaneCore::CertChecker.installed?(cert_path)
-          UI.verbose "Certificate '#{File.basename(cert_path)}' is already installed on this machine"
+          UI.verbose("Certificate '#{File.basename(cert_path)}' is already installed on this machine")
         else
           Utils.import(cert_path, params[:keychain_name], password: params[:keychain_password])
         end
@@ -145,20 +145,20 @@ module Match
         else
           # App Store provisioning profiles don't contain device identifiers and
           # thus shouldn't be renewed if the device count has changed.
-          UI.important "Warning: `force_for_new_devices` is set but is ignored for App Store provisioning profiles."
-          UI.important "You can safely stop specifying `force_for_new_devices` when running Match for type 'appstore'."
+          UI.important("Warning: `force_for_new_devices` is set but is ignored for App Store provisioning profiles.")
+          UI.important("You can safely stop specifying `force_for_new_devices` when running Match for type 'appstore'.")
         end
       end
 
       if profile.nil? or params[:force]
         if params[:readonly]
-          all_profiles = Dir.entries(base_dir).reject { |f| f.start_with? "." }
-          UI.error "No matching provisioning profiles found for '#{profile_name}'"
-          UI.error "A new one cannot be created because you enabled `readonly`"
-          UI.error "Provisioning profiles in your repo for type `#{prov_type}`:"
-          all_profiles.each { |p| UI.error "- '#{p}'" }
-          UI.error "If you are certain that a profile should exist, double-check the recent changes to your match repository"
-          UI.user_error! "No matching provisioning profiles found and can not create a new one because you enabled `readonly`. Check the output above for more information."
+          all_profiles = Dir.entries(base_dir).reject { |f| f.start_with?(".") }
+          UI.error("No matching provisioning profiles found for '#{profile_name}'")
+          UI.error("A new one cannot be created because you enabled `readonly`")
+          UI.error("Provisioning profiles in your repo for type `#{prov_type}`:")
+          all_profiles.each { |p| UI.error("- '#{p}'") }
+          UI.error("If you are certain that a profile should exist, double-check the recent changes to your match repository")
+          UI.user_error!("No matching provisioning profiles found and can not create a new one because you enabled `readonly`. Check the output above for more information.")
         end
         profile = Generator.generate_provisioning_profile(params: params,
                                                        prov_type: prov_type,