fastlane 2.74.1 → 2.75.0.beta.20180109010003

data/fastlane/lib/fastlane/actions/get_github_release.rb

@@ -108,7 +108,7 @@ module Fastlane
                                        env_name: "FL_GET_GITHUB_RELEASE_URL",
                                        description: "The path to your repo, e.g. 'KrauseFx/fastlane'",
                                        verify_block: proc do |value|
-                                         UI.user_error!("Please only pass the path, e.g. 'KrauseFx/fastlane'") if value.include? "github.com"
+                                         UI.user_error!("Please only pass the path, e.g. 'KrauseFx/fastlane'") if value.include?("github.com")
                                          UI.user_error!("Please only pass the path, e.g. 'KrauseFx/fastlane'") if value.split('/').count != 2
                                        end),
           FastlaneCore::ConfigItem.new(key: :server_url,
@@ -117,7 +117,7 @@ module Fastlane
                                        default_value: "https://api.github.com",
                                        optional: true,
                                        verify_block: proc do |value|
-                                         UI.user_error!("Please include the protocol in the server url, e.g. https://your.github.server") unless value.include? "//"
+                                         UI.user_error!("Please include the protocol in the server url, e.g. https://your.github.server") unless value.include?("//")
                                        end),
           FastlaneCore::ConfigItem.new(key: :version,
                                        env_name: "FL_GET_GITHUB_RELEASE_VERSION",

data/fastlane/lib/fastlane/actions/get_info_plist_value.rb

@@ -57,7 +57,7 @@ module Fastlane
       end
 
       def self.is_supported?(platform)
-        [:ios, :mac].include? platform
+        [:ios, :mac].include?(platform)
       end
 
       def self.example_code

data/fastlane/lib/fastlane/actions/get_version_number.rb

@@ -39,7 +39,7 @@ module Fastlane
             '"SampleProject.xcodeproj/../SampleProject_tests/Info.plist"=1.0'
           ]
         else
-          results = (Actions.sh command).split("\n")
+          results = Actions.sh(command).split("\n")
         end
 
         if target.empty? && scheme.empty?
@@ -48,7 +48,7 @@ module Fastlane
           # emulating the actual behavior or the -terse1 flag correctly
           project_string = ".xcodeproj"
           results.any? do |result|
-            if result.include? project_string
+            if result.include?(project_string)
               line = result
               break
             end
@@ -61,15 +61,15 @@ module Fastlane
           plist_target_string = "/#{target}-"
           results.any? do |result|
             if !target.empty?
-              if result.include? target_string
+              if result.include?(target_string)
                 line = result
                 break
-              elsif result.include? plist_target_string
+              elsif result.include?(plist_target_string)
                 line = result
                 break
               end
             else
-              if result.include? scheme_string
+              if result.include?(scheme_string)
                 line = result
                 break
               end
@@ -112,7 +112,7 @@ module Fastlane
                              description: "optional, you must specify the path to your main Xcode project if it is not in the project root directory",
                              optional: true,
                              verify_block: proc do |value|
-                               UI.user_error!("Please pass the path to the project, not the workspace") if value.end_with? ".xcworkspace"
+                               UI.user_error!("Please pass the path to the project, not the workspace") if value.end_with?(".xcworkspace")
                                UI.user_error!("Could not find Xcode project at path '#{File.expand_path(value)}'") if !File.exist?(value) and !Helper.is_test?
                              end),
           FastlaneCore::ConfigItem.new(key: :scheme,
@@ -141,7 +141,7 @@ module Fastlane
       end
 
       def self.is_supported?(platform)
-        [:ios, :mac].include? platform
+        [:ios, :mac].include?(platform)
       end
 
       def self.example_code

data/fastlane/lib/fastlane/actions/github_api.rb

@@ -82,7 +82,7 @@ module Fastlane
                                          default_value: "https://api.github.com",
                                          optional: true,
                                          verify_block: proc do |value|
-                                           UI.user_error!("Please include the protocol in the server url, e.g. https://your.github.server/api/v3") unless value.include? "//"
+                                           UI.user_error!("Please include the protocol in the server url, e.g. https://your.github.server/api/v3") unless value.include?("//")
                                          end),
             FastlaneCore::ConfigItem.new(key: :api_token,
                                          env_name: "FL_GITHUB_API_TOKEN",
@@ -122,7 +122,7 @@ module Fastlane
                                          description: "The complete full url - used instead of path. e.g. 'https://uploads.github.com/repos/fastlane...'",
                                          optional: true,
                                          verify_block: proc do |value|
-                                           UI.user_error!("Please include the protocol in the url, e.g. https://uploads.github.com") unless value.include? "//"
+                                           UI.user_error!("Please include the protocol in the url, e.g. https://uploads.github.com") unless value.include?("//")
                                          end),
             FastlaneCore::ConfigItem.new(key: :error_handlers,
                                          description: "Optional error handling hash based on status code, or pass '*' to handle all errors",

data/fastlane/lib/fastlane/actions/hg_commit_version_bump.rb

@@ -79,7 +79,7 @@ module Fastlane
         # check if the files changed are the ones we expected to change (these should be only the files that have version info in them)
         dirty_set = Set.new(hg_dirty_files.map(&:downcase))
         expected_set = Set.new(expected_changed_files.map(&:downcase))
-        changed_files_as_expected = dirty_set.subset? expected_set
+        changed_files_as_expected = dirty_set.subset?(expected_set)
         unless changed_files_as_expected
           unless params[:force]
             str = ["Found unexpected uncommitted changes in the working directory. Expected these files to have changed:",
@@ -120,7 +120,7 @@ module Fastlane
                                        description: "The path to your project file (Not the workspace). If you have only one, this is optional",
                                        optional: true,
                                        verify_block: proc do |value|
-                                         UI.user_error!("Please pass the path to the project, not the workspace") if value.end_with? ".xcworkspace"
+                                         UI.user_error!("Please pass the path to the project, not the workspace") if value.end_with?(".xcworkspace")
                                          UI.user_error!("Could not find Xcode project") unless File.exist?(value)
                                        end),
           FastlaneCore::ConfigItem.new(key: :force,

data/fastlane/lib/fastlane/actions/hockey.rb

@@ -15,11 +15,11 @@ module Fastlane
           url: base_url
         }
         Faraday.new(foptions) do |builder|
-          builder.request :multipart
-          builder.request :url_encoded
-          builder.response :json, content_type: /\bjson$/
-          builder.use FaradayMiddleware::FollowRedirects
-          builder.adapter :net_http
+          builder.request(:multipart)
+          builder.request(:url_encoded)
+          builder.response(:json, content_type: /\bjson$/)
+          builder.use(FaradayMiddleware::FollowRedirects)
+          builder.adapter(:net_http)
         end
       end
 

data/fastlane/lib/fastlane/actions/ifttt.rb

@@ -19,8 +19,8 @@ module Fastlane
 
         response = https.request(req)
 
-        UI.user_error! "Failed to make a request to IFTTT. #{response.message}." unless response.code == "200"
-        UI.success "Successfully made a request to IFTTT."
+        UI.user_error!("Failed to make a request to IFTTT. #{response.message}.") unless response.code == "200"
+        UI.success("Successfully made a request to IFTTT.")
       end
 
       #####################################################
@@ -42,13 +42,13 @@ module Fastlane
                                       sensitive: true,
                                       description: "API key",
                                       verify_block: proc do |value|
-                                        raise UI.error "No API key given, pass using `api_key: 'key'`" if value.to_s.empty?
+                                        raise UI.error("No API key given, pass using `api_key: 'key'`") if value.to_s.empty?
                                       end),
           FastlaneCore::ConfigItem.new(key: :event_name,
                                       env_name: "IFTTT_EVENT_NAME",
                                       description: "The name of the event that will be triggered",
                                       verify_block: proc do |value|
-                                        raise UI.error "No event name given, pass using `event_name: 'name'`" if value.to_s.empty?
+                                        raise UI.error("No event name given, pass using `event_name: 'name'`") if value.to_s.empty?
                                       end),
           FastlaneCore::ConfigItem.new(key: :value1,
                                        env_name: "IFTTT_VALUE1",

data/fastlane/lib/fastlane/actions/increment_build_number.rb

@@ -8,7 +8,7 @@ module Fastlane
       require 'shellwords'
 
       def self.is_supported?(platform)
-        [:ios, :mac].include? platform
+        [:ios, :mac].include?(platform)
       end
 
       def self.run(params)
@@ -46,7 +46,7 @@ module Fastlane
         if Helper.test?
           return Actions.lane_context[SharedValues::BUILD_NUMBER] = command
         else
-          Actions.sh command
+          Actions.sh(command)
 
           # Store the new number in the shared hash
           build_number = `#{command_prefix} agvtool what-version`.split("\n").last.strip
@@ -73,7 +73,7 @@ module Fastlane
                                        description: "optional, you must specify the path to your main Xcode project if it is not in the project root directory",
                                        optional: true,
                                        verify_block: proc do |value|
-                                         UI.user_error!("Please pass the path to the project, not the workspace") if value.end_with? ".xcworkspace"
+                                         UI.user_error!("Please pass the path to the project, not the workspace") if value.end_with?(".xcworkspace")
                                          UI.user_error!("Could not find Xcode project") if !File.exist?(value) and !Helper.is_test?
                                        end)
         ]

data/fastlane/lib/fastlane/actions/increment_version_number.rb

@@ -8,7 +8,7 @@ module Fastlane
       require 'shellwords'
 
       def self.is_supported?(platform)
-        [:ios, :mac].include? platform
+        [:ios, :mac].include?(platform)
       end
 
       def self.run(params)
@@ -64,7 +64,7 @@ module Fastlane
         if Helper.test?
           Actions.lane_context[SharedValues::VERSION_NUMBER] = command
         else
-          Actions.sh command
+          Actions.sh(command)
           Actions.lane_context[SharedValues::VERSION_NUMBER] = next_version_number
         end
 
@@ -93,7 +93,7 @@ module Fastlane
                                        description: "The type of this version bump. Available: patch, minor, major",
                                        default_value: "patch",
                                        verify_block: proc do |value|
-                                         UI.user_error!("Available values are 'patch', 'minor' and 'major'") unless ['patch', 'minor', 'major'].include? value
+                                         UI.user_error!("Available values are 'patch', 'minor' and 'major'") unless ['patch', 'minor', 'major'].include?(value)
                                        end),
           FastlaneCore::ConfigItem.new(key: :version_number,
                                        env_name: "FL_VERSION_NUMBER_VERSION_NUMBER",
@@ -103,7 +103,7 @@ module Fastlane
                                        env_name: "FL_VERSION_NUMBER_PROJECT",
                                        description: "optional, you must specify the path to your main Xcode project if it is not in the project root directory",
                                        verify_block: proc do |value|
-                                         UI.user_error!("Please pass the path to the project, not the workspace") if value.end_with? ".xcworkspace"
+                                         UI.user_error!("Please pass the path to the project, not the workspace") if value.end_with?(".xcworkspace")
                                          UI.user_error!("Could not find Xcode project") unless File.exist?(value)
                                        end,
                                        optional: true)

data/fastlane/lib/fastlane/actions/install_on_device.rb

@@ -58,8 +58,8 @@ module Fastlane
                                        default_value: Actions.lane_context[SharedValues::IPA_OUTPUT_PATH] || Dir["*.ipa"].first,
                                        verify_block: proc do |value|
                                          unless Helper.test?
-                                           UI.user_error!("Could not find ipa file at path '#{value}'") unless File.exist? value
-                                           UI.user_error!("'#{value}' doesn't seem to be an ipa file") unless value.end_with? ".ipa"
+                                           UI.user_error!("Could not find ipa file at path '#{value}'") unless File.exist?(value)
+                                           UI.user_error!("'#{value}' doesn't seem to be an ipa file") unless value.end_with?(".ipa")
                                          end
                                        end)
         ]

data/fastlane/lib/fastlane/actions/install_xcode_plugin.rb

@@ -25,10 +25,10 @@ module Fastlane
         end
 
         zip_path = File.join(Dir.tmpdir, 'plugin.zip')
-        sh "curl -Lso #{zip_path} #{params[:url]}"
+        sh("curl -Lso #{zip_path} #{params[:url]}")
         plugins_path = "#{ENV['HOME']}/Library/Application Support/Developer/Shared/Xcode/Plug-ins"
         FileUtils.mkdir_p(plugins_path)
-        Action.sh "unzip -qo '#{zip_path}' -d '#{plugins_path}'"
+        Action.sh("unzip -qo '#{zip_path}' -d '#{plugins_path}'")
 
         UI.success("Plugin #{File.basename(params[:url], '.zip')} installed successfully")
         UI.message("Please restart Xcode to use the newly installed plugin")

data/fastlane/lib/fastlane/actions/installr.rb

@@ -27,11 +27,11 @@ module Fastlane
 
         url = INSTALLR_API
         connection = Faraday.new(url) do |builder|
-          builder.request :multipart
-          builder.request :url_encoded
-          builder.response :json, content_type: /\bjson$/
-          builder.use FaradayMiddleware::FollowRedirects
-          builder.adapter :net_http
+          builder.request(:multipart)
+          builder.request(:url_encoded)
+          builder.response(:json, content_type: /\bjson$/)
+          builder.use(FaradayMiddleware::FollowRedirects)
+          builder.adapter(:net_http)
         end
 
         options = {}
@@ -55,7 +55,7 @@ module Fastlane
         end
 
         post_request.on_complete do |env|
-          yield env[:status], env[:body] if block_given?
+          yield(env[:status], env[:body]) if block_given?
         end
       end
 

data/fastlane/lib/fastlane/actions/ipa.rb

@@ -58,7 +58,7 @@ module Fastlane
         UI.verbose(command)
 
         begin
-          Actions.sh command
+          Actions.sh(command)
 
           # Finds absolute path of IPA and dSYM
           absolute_ipa_path = find_ipa_file(absolute_dest_directory)

data/fastlane/lib/fastlane/actions/latest_testflight_build_number.rb

@@ -62,7 +62,7 @@ module Fastlane
                                        is_string: true,
                                        default_value: "ios",
                                        verify_block: proc do |value|
-                                         UI.user_error!("The platform can only be ios, or appletvos") unless %('ios', 'appletvos').include? value
+                                         UI.user_error!("The platform can only be ios, or appletvos") unless %('ios', 'appletvos').include?(value)
                                        end),
           FastlaneCore::ConfigItem.new(key: :initial_build_number,
                                        env_name: "INITIAL_BUILD_NUMBER",

data/fastlane/lib/fastlane/actions/lcov.rb

@@ -2,7 +2,7 @@ module Fastlane
   module Actions
     class LcovAction < Action
       def self.is_supported?(platform)
-        [:ios, :mac].include? platform
+        [:ios, :mac].include?(platform)
       end
 
       def self.run(options)

data/fastlane/lib/fastlane/actions/mailgun.rb

@@ -102,10 +102,10 @@ module Fastlane
 
       def self.handle_params_transition(options)
         options[:postmaster] = options[:mailgun_sandbox_postmaster] if options[:mailgun_sandbox_postmaster]
-        puts "\nUsing :mailgun_sandbox_postmaster is deprecated, please change to :postmaster".yellow if options[:mailgun_sandbox_postmaster]
+        puts("\nUsing :mailgun_sandbox_postmaster is deprecated, please change to :postmaster".yellow) if options[:mailgun_sandbox_postmaster]
 
         options[:apikey] = options[:mailgun_apikey] if options[:mailgun_apikey]
-        puts "\nUsing :mailgun_apikey is deprecated, please change to :apikey".yellow if options[:mailgun_apikey]
+        puts("\nUsing :mailgun_apikey is deprecated, please change to :apikey".yellow) if options[:mailgun_apikey]
       end
 
       def self.mailgunit(options)
@@ -126,7 +126,7 @@ module Fastlane
           params.store(:attachment, attachments)
         end
 
-        RestClient.post "https://api:#{options[:apikey]}@api.mailgun.net/v3/#{sandbox_domain}/messages", params
+        RestClient.post("https://api:#{options[:apikey]}@api.mailgun.net/v3/#{sandbox_domain}/messages", params)
         mail_template(options)
       end
 

data/fastlane/lib/fastlane/actions/modify_services.rb

@@ -110,7 +110,7 @@ module Fastlane
                                          allowed_keys = Produce::DeveloperCenter::ALLOWED_SERVICES.keys
                                          UI.user_error!("enable_services has to be of type Hash") unless value.kind_of?(Hash)
                                          value.each do |key, v|
-                                           UI.user_error!("The key: '#{key}' is not supported in `enable_services' - following keys are available: [#{allowed_keys.join(',')}]") unless allowed_keys.include? key.to_sym
+                                           UI.user_error!("The key: '#{key}' is not supported in `enable_services' - following keys are available: [#{allowed_keys.join(',')}]") unless allowed_keys.include?(key.to_sym)
                                          end
                                        end),
           FastlaneCore::ConfigItem.new(key: :team_id,

data/fastlane/lib/fastlane/actions/notification.rb

@@ -6,7 +6,7 @@ module Fastlane
 
         options = params.values
         # :message is non-optional
-        message = options.delete :message
+        message = options.delete(:message)
         # remove nil keys, since `notify` below does not ignore them and instead translates them into empty strings in output, which looks ugly
         options = options.select { |_, v| v }
         option_map = {

data/fastlane/lib/fastlane/actions/number_of_commits.rb

@@ -2,7 +2,7 @@ module Fastlane
   module Actions
     class NumberOfCommitsAction < Action
       def self.is_git?
-        Actions.sh 'git rev-parse HEAD'
+        Actions.sh('git rev-parse HEAD')
         return true
       rescue
         return false

data/fastlane/lib/fastlane/actions/onesignal.rb

@@ -49,7 +49,7 @@ module Fastlane
       def self.check_response_code(response)
         case response.code.to_i
         when 200, 204
-          puts "Successfully created new OneSignal app".green
+          puts("Successfully created new OneSignal app".green)
         else
           UI.user_error!("Unexpected #{response.code} with response: #{response.body}")
         end

data/fastlane/lib/fastlane/actions/pod_push.rb

@@ -100,7 +100,7 @@ module Fastlane
       end
 
       def self.is_supported?(platform)
-        [:ios, :mac].include? platform
+        [:ios, :mac].include?(platform)
       end
 
       def self.example_code

data/fastlane/lib/fastlane/actions/podio_item.rb

@@ -129,11 +129,11 @@ module Fastlane
       end
 
       def self.authenticate(client_id, client_secret, app_id, app_token)
-        auth_response = RestClient.post AUTH_URL, grant_type: 'app',
+        auth_response = RestClient.post(AUTH_URL, grant_type: 'app',
                                                   app_id: app_id,
                                                   app_token: app_token,
                                                   client_id: client_id,
-                                                  client_secret: client_secret
+                                                  client_secret: client_secret)
         UI.user_error!("Failed to authenticate with Podio API") if auth_response.code != 200
 
         auth_response_dictionary = JSON.parse(auth_response.body)
@@ -154,7 +154,7 @@ module Fastlane
 
       def self.get_existing_item(auth_config, identifying_value, app_id)
         filter_request_body = { query: identifying_value, limit: 1, ref_type: 'item' }.to_json
-        filter_response = RestClient.post "#{BASE_URL}/search/app/#{app_id}/", filter_request_body, auth_config
+        filter_response = RestClient.post("#{BASE_URL}/search/app/#{app_id}/", filter_request_body, auth_config)
         UI.user_error!("Failed to search for already existing item #{identifying_value}") if filter_response.code != 200
 
         existing_items = JSON.parse(filter_response.body)
@@ -173,7 +173,7 @@ module Fastlane
 
       def self.create_item(auth_config, identifying_field, identifying_value, app_id)
         item_request_body = { fields: { identifying_field => identifying_value } }.to_json
-        item_response = RestClient.post "#{BASE_URL}/item/app/#{app_id}", item_request_body, auth_config
+        item_response = RestClient.post("#{BASE_URL}/item/app/#{app_id}", item_request_body, auth_config)
         UI.user_error!("Failed to create item \"#{identifying_value}\"") if item_response.code != 200
 
         item_response_dictionary = JSON.parse(item_response.body)
@@ -183,14 +183,14 @@ module Fastlane
       def self.update_item(auth_config, item_id, fields)
         if fields.length > 0
           item_request_body = { fields: fields }.to_json
-          item_response = RestClient.put "#{BASE_URL}/item/#{item_id}", item_request_body, auth_config
+          item_response = RestClient.put("#{BASE_URL}/item/#{item_id}", item_request_body, auth_config)
           UI.user_error!("Failed to update item values \"#{fields}\"") unless item_response.code != 200 || item_response.code != 204
         end
       end
 
       def self.get_embed_id(auth_config, url)
         embed_request_body = { url: url }.to_json
-        embed_response = RestClient.post "#{BASE_URL}/embed/", embed_request_body, auth_config
+        embed_response = RestClient.post("#{BASE_URL}/embed/", embed_request_body, auth_config)
         UI.user_error!("Failed to create embed for link #{link}") if embed_response.code != 200
 
         embed_response_dictionary = JSON.parse(embed_response.body)

data/fastlane/lib/fastlane/actions/puts.rb

@@ -2,7 +2,7 @@ module Fastlane
   module Actions
     class PutsAction < Action
       def self.run(params)
-        UI.message params.join(' ')
+        UI.message(params.join(' '))
       end
 
       #####################################################

data/fastlane/lib/fastlane/actions/read_podspec.rb

@@ -61,7 +61,7 @@ module Fastlane
       end
 
       def self.is_supported?(platform)
-        [:ios, :mac].include? platform
+        [:ios, :mac].include?(platform)
       end
 
       def self.example_code