fastlane 2.74.1 → 2.75.0.beta.20180109010003

data/fastlane/lib/fastlane/actions/recreate_schemes.rb

@@ -29,7 +29,7 @@ module Fastlane
       end
 
       def self.is_supported?(platform)
-        [:ios, :mac].include? platform
+        [:ios, :mac].include?(platform)
       end
 
       def self.example_code

data/fastlane/lib/fastlane/actions/reset_git_repo.rb

@@ -79,7 +79,7 @@ module Fastlane
                                        optional: true,
                                        is_string: false,
                                        verify_block: proc do |value|
-                                         UI.user_error!("Please pass an array only") unless value.kind_of? Array
+                                         UI.user_error!("Please pass an array only") unless value.kind_of?(Array)
                                        end),
           FastlaneCore::ConfigItem.new(key: :force,
                                        env_name: "FL_RESET_GIT_FORCE",

data/fastlane/lib/fastlane/actions/restore_file.rb

@@ -4,7 +4,7 @@ module Fastlane
       def self.run(params)
         path = params[:path]
         backup_path = "#{path}.back"
-        UI.user_error!("Could not find file '#{backup_path}'") unless File.exist? backup_path
+        UI.user_error!("Could not find file '#{backup_path}'") unless File.exist?(backup_path)
         FileUtils.cp(backup_path, path, { preserve: true })
         FileUtils.rm(backup_path)
         UI.message("Successfully restored backup 📤")

data/fastlane/lib/fastlane/actions/rocket.rb

@@ -2,7 +2,7 @@ module Fastlane
   module Actions
     class RocketAction < Action
       def self.run(params)
-        puts "
+        puts("
         ____
        /    \\
       |      |
@@ -36,7 +36,7 @@ module Fastlane
          ##
          ##
          ##
-         "
+         ")
         return "🚀"
       end
 

data/fastlane/lib/fastlane/actions/run_tests.rb

@@ -62,7 +62,7 @@ module Fastlane
       end
 
       def self.is_supported?(platform)
-        [:ios, :mac].include? platform
+        [:ios, :mac].include?(platform)
       end
 
       private_class_method

data/fastlane/lib/fastlane/actions/s3.rb

@@ -275,7 +275,7 @@ module Fastlane
         # writing to an object will create an object version
         # instead of replacing the existing object.
         # http://docs.aws.amazon.com/AWSRubySDK/latest/AWS/S3/ObjectVersion.html
-        if obj.kind_of? AWS::S3::ObjectVersion
+        if obj.kind_of?(AWS::S3::ObjectVersion)
           obj = obj.object
         end
 

data/fastlane/lib/fastlane/actions/scp.rb

@@ -10,12 +10,12 @@ module Fastlane
         ret = nil
         Net::SCP.start(params[:host], params[:username], { port: params[:port].to_i, password: params[:password] }) do |scp|
           if params[:upload]
-            scp.upload! params[:upload][:src], params[:upload][:dst], recursive: true
+            scp.upload!(params[:upload][:src], params[:upload][:dst], recursive: true)
             UI.message(['[SCP COMMAND]', "Successfully Uploaded", params[:upload][:src], params[:upload][:dst]].join(': '))
           end
           if params[:download]
 
-            t_ret = scp.download! params[:download][:src], params[:download][:dst], recursive: true
+            t_ret = scp.download!(params[:download][:src], params[:download][:dst], recursive: true)
             UI.message(['[SCP COMMAND]', "Successfully Downloaded", params[:download][:src], params[:download][:dst]].join(': '))
             unless params[:download][:dst]
               ret = t_ret

data/fastlane/lib/fastlane/actions/set_build_number_repository.rb

@@ -5,7 +5,7 @@ module Fastlane
 
     class SetBuildNumberRepositoryAction < Action
       def self.is_supported?(platform)
-        [:ios, :mac].include? platform
+        [:ios, :mac].include?(platform)
       end
 
       def self.run(params)

data/fastlane/lib/fastlane/actions/set_changelog.rb

@@ -30,7 +30,7 @@ module Fastlane
         unless changelog
           path = default_changelog_path
           UI.message("Looking for changelog in '#{path}'...")
-          if File.exist? path
+          if File.exist?(path)
             changelog = File.read(path)
           else
             UI.error("Couldn't find changelog.txt")
@@ -141,7 +141,7 @@ module Fastlane
       end
 
       def self.is_supported?(platform)
-        [:ios, :mac].include? platform
+        [:ios, :mac].include?(platform)
       end
 
       def self.example_code

data/fastlane/lib/fastlane/actions/set_github_release.rb

@@ -106,7 +106,7 @@ module Fastlane
         if File.directory?(absolute_path)
           Dir.mktmpdir do |dir|
             tmpzip = File.join(dir, File.basename(absolute_path) + '.zip')
-            sh "cd \"#{File.dirname(absolute_path)}\"; zip -r --symlinks \"#{tmpzip}\" \"#{File.basename(absolute_path)}\" 2>&1 >/dev/null"
+            sh("cd \"#{File.dirname(absolute_path)}\"; zip -r --symlinks \"#{tmpzip}\" \"#{File.basename(absolute_path)}\" 2>&1 >/dev/null")
             self.upload_file(tmpzip, upload_url_template, api_token)
           end
         else
@@ -159,7 +159,7 @@ module Fastlane
                                        env_name: "FL_SET_GITHUB_RELEASE_REPOSITORY_NAME",
                                        description: "The path to your repo, e.g. 'fastlane/fastlane'",
                                        verify_block: proc do |value|
-                                         UI.user_error!("Please only pass the path, e.g. 'fastlane/fastlane'") if value.include? "github.com"
+                                         UI.user_error!("Please only pass the path, e.g. 'fastlane/fastlane'") if value.include?("github.com")
                                          UI.user_error!("Please only pass the path, e.g. 'fastlane/fastlane'") if value.split('/').count != 2
                                        end),
           FastlaneCore::ConfigItem.new(key: :server_url,
@@ -168,7 +168,7 @@ module Fastlane
                                        default_value: "https://api.github.com",
                                        optional: true,
                                        verify_block: proc do |value|
-                                         UI.user_error!("Please include the protocol in the server url, e.g. https://your.github.server/api/v3") unless value.include? "//"
+                                         UI.user_error!("Please include the protocol in the server url, e.g. https://your.github.server/api/v3") unless value.include?("//")
                                        end),
           FastlaneCore::ConfigItem.new(key: :api_token,
                                        env_name: "FL_GITHUB_RELEASE_API_TOKEN",
@@ -217,7 +217,7 @@ module Fastlane
                                        optional: true,
                                        is_string: false,
                                        verify_block: proc do |value|
-                                         UI.user_error!("upload_assets must be an Array of paths to assets") unless value.kind_of? Array
+                                         UI.user_error!("upload_assets must be an Array of paths to assets") unless value.kind_of?(Array)
                                        end)
         ]
       end

data/fastlane/lib/fastlane/actions/set_info_plist_value.rb

@@ -14,7 +14,7 @@ module Fastlane
             if plist[params[:key]]
               plist[params[:key]][params[:subkey]] = params[:value]
             else
-              UI.message "Key doesn't exist, going to create new one ..."
+              UI.message("Key doesn't exist, going to create new one ...")
               plist[params[:key]] = { params[:subkey] => params[:value] }
             end
           else
@@ -74,7 +74,7 @@ module Fastlane
       end
 
       def self.is_supported?(platform)
-        [:ios, :mac].include? platform
+        [:ios, :mac].include?(platform)
       end
 
       def self.example_code

data/fastlane/lib/fastlane/actions/set_pod_key.rb

@@ -57,7 +57,7 @@ module Fastlane
       end
 
       def self.is_supported?(platform)
-        [:ios, :mac].include? platform
+        [:ios, :mac].include?(platform)
       end
 
       def self.example_code

data/fastlane/lib/fastlane/actions/setup_circle_ci.rb

@@ -3,7 +3,7 @@ module Fastlane
     class SetupCircleCiAction < Action
       def self.run(params)
         unless should_run?(params)
-          UI.message "Not running on CI, skipping `setup_circle_ci`"
+          UI.message("Not running on CI, skipping `setup_circle_ci`")
           return
         end
 
@@ -13,7 +13,7 @@ module Fastlane
 
       def self.setup_output_paths(params)
         unless ENV["FL_OUTPUT_DIR"]
-          UI.message "Skipping Log Path setup as FL_OUTPUT_DIR is unset"
+          UI.message("Skipping Log Path setup as FL_OUTPUT_DIR is unset")
           return
         end
 
@@ -26,7 +26,7 @@ module Fastlane
 
       def self.setup_keychain
         unless ENV["MATCH_KEYCHAIN_NAME"].nil?
-          UI.message "Skipping Keychain setup as a keychain was already specified"
+          UI.message("Skipping Keychain setup as a keychain was already specified")
           return
         end
 
@@ -34,7 +34,7 @@ module Fastlane
         ENV["MATCH_KEYCHAIN_NAME"] = keychain_name
         ENV["MATCH_KEYCHAIN_PASSWORD"] = ""
 
-        UI.message "Creating temporary keychain: \"#{keychain_name}\"."
+        UI.message("Creating temporary keychain: \"#{keychain_name}\".")
         Actions::CreateKeychainAction.run(
           name: keychain_name,
           default_keychain: true,

data/fastlane/lib/fastlane/actions/setup_jenkins.rb

@@ -20,7 +20,7 @@ module Fastlane
       def self.run(params)
         # Stop if not executed by CI
         if !Helper.is_ci? && !params[:force]
-          UI.important "Not executed by Continuous Integration system."
+          UI.important("Not executed by Continuous Integration system.")
           return
         end
 
@@ -33,7 +33,7 @@ module Fastlane
         # Keychain
         if params[:unlock_keychain] && params[:keychain_path]
           keychain_path = params[:keychain_path]
-          UI.message "Unlocking keychain: \"#{keychain_path}\"."
+          UI.message("Unlocking keychain: \"#{keychain_path}\".")
           Actions::UnlockKeychainAction.run(
             path: keychain_path,
             password: params[:keychain_password],
@@ -45,14 +45,14 @@ module Fastlane
         # Code signing identity
         if params[:set_code_signing_identity] && params[:code_signing_identity]
           code_signing_identity = params[:code_signing_identity]
-          UI.message "Set code signing identity: \"#{code_signing_identity}\"."
+          UI.message("Set code signing identity: \"#{code_signing_identity}\".")
           ENV['GYM_CODE_SIGNING_IDENTITY'] = code_signing_identity
         end
 
         # Set output directory
         if params[:output_directory]
           output_directory_path = File.expand_path(params[:output_directory])
-          UI.message "Set output directory path to: \"#{output_directory_path}\"."
+          UI.message("Set output directory path to: \"#{output_directory_path}\".")
           ENV['GYM_BUILD_PATH'] = output_directory_path
           ENV['GYM_OUTPUT_DIRECTORY'] = output_directory_path
           ENV['SCAN_OUTPUT_DIRECTORY'] = output_directory_path
@@ -62,7 +62,7 @@ module Fastlane
         # Set derived data
         if params[:derived_data_path]
           derived_data_path = File.expand_path(params[:derived_data_path])
-          UI.message "Set derived data path to: \"#{derived_data_path}\"."
+          UI.message("Set derived data path to: \"#{derived_data_path}\".")
           ENV['DERIVED_DATA_PATH'] = derived_data_path # Used by clear_derived_data.
           ENV['XCODE_DERIVED_DATA_PATH'] = derived_data_path
           ENV['GYM_DERIVED_DATA_PATH'] = derived_data_path
@@ -73,7 +73,7 @@ module Fastlane
 
         # Set result bundle
         if params[:result_bundle]
-          UI.message "Set result bundle."
+          UI.message("Set result bundle.")
           ENV['GYM_RESULT_BUNDLE'] = "YES"
           ENV['SCAN_RESULT_BUNDLE'] = "YES"
         end

data/fastlane/lib/fastlane/actions/setup_travis.rb

@@ -4,7 +4,7 @@ module Fastlane
       def self.run(params)
         # Stop if not executed by CI
         if !Helper.is_ci? && !params[:force]
-          UI.message "Currently not running on CI system, skipping travis setup"
+          UI.message("Currently not running on CI system, skipping travis setup")
           return
         end
 
@@ -14,7 +14,7 @@ module Fastlane
         ENV["MATCH_KEYCHAIN_NAME"] = keychain_name
         ENV["MATCH_KEYCHAIN_PASSWORD"] = password
 
-        UI.message "Creating temporary keychain: \"#{keychain_name}\"."
+        UI.message("Creating temporary keychain: \"#{keychain_name}\".")
         Actions::CreateKeychainAction.run(
           name: keychain_name,
           default_keychain: true,

data/fastlane/lib/fastlane/actions/slack.rb

@@ -39,9 +39,9 @@ module Fastlane
         return [notifier, slack_attachment] if Helper.is_test? # tests will verify the slack attachments and other properties
 
         begin
-          result = notifier.ping '',
+          result = notifier.ping('',
                                  icon_url: icon_url,
-                                 attachments: [slack_attachment]
+                                 attachments: [slack_attachment])
         rescue => exception
           UI.error("Exception: #{exception}")
         ensure
@@ -84,7 +84,7 @@ module Fastlane
                                        sensitive: true,
                                        description: "Create an Incoming WebHook for your Slack group",
                                        verify_block: proc do |value|
-                                         UI.user_error!("Invalid URL, must start with https://") unless value.start_with? "https://"
+                                         UI.user_error!("Invalid URL, must start with https://") unless value.start_with?("https://")
                                        end),
           FastlaneCore::ConfigItem.new(key: :username,
                                        env_name: "FL_SLACK_USERNAME",

data/fastlane/lib/fastlane/actions/slather.rb

@@ -48,7 +48,7 @@ module Fastlane
         validate_params!(params)
 
         command = build_command(params)
-        sh command
+        sh(command)
       end
 
       def self.has_config_file
@@ -280,7 +280,7 @@ Slather is available at https://github.com/SlatherOrg/slather
       end
 
       def self.is_supported?(platform)
-        [:ios, :mac].include? platform
+        [:ios, :mac].include?(platform)
       end
 
       def self.example_code

data/fastlane/lib/fastlane/actions/spm.rb

@@ -29,7 +29,7 @@ module Fastlane
                                        description: "The swift command (one of: #{available_commands.join(', ')})",
                                        default_value: "build",
                                        verify_block: proc do |value|
-                                         UI.user_error!("Please pass a valid command. Use one of the following: #{available_commands.join(', ')}") unless available_commands.include? value
+                                         UI.user_error!("Please pass a valid command. Use one of the following: #{available_commands.join(', ')}") unless available_commands.include?(value)
                                        end),
           FastlaneCore::ConfigItem.new(key: :build_path,
                                        env_name: "FL_SPM_BUILD_PATH",
@@ -45,7 +45,7 @@ module Fastlane
                                        description: "Build with configuration (debug|release) [default: debug]",
                                        optional: true,
                                        verify_block: proc do |value|
-                                         UI.user_error!("Please pass a valid configuration: (debug|release)") unless valid_configurations.include? value
+                                         UI.user_error!("Please pass a valid configuration: (debug|release)") unless valid_configurations.include?(value)
                                        end),
           FastlaneCore::ConfigItem.new(key: :verbose,
                                        short_option: "-v",

data/fastlane/lib/fastlane/actions/ssh.rb

@@ -14,7 +14,7 @@ module Fastlane
         ssh.open_channel do |channel|
           channel.exec(command) do |ch, success|
             unless success
-              abort "FAILED: couldn't execute command (ssh.channel.exec)"
+              abort("FAILED: couldn't execute command (ssh.channel.exec)")
             end
             channel.on_data do |ch1, data|
               stdout_data += data

data/fastlane/lib/fastlane/actions/team_id.rb

@@ -5,7 +5,7 @@ module Fastlane
 
     class TeamIdAction < Action
       def self.run(params)
-        params = nil unless params.kind_of? Array
+        params = nil unless params.kind_of?(Array)
         team = (params || []).first
         UI.user_error!("Please pass your Team ID (e.g. team_id 'Q2CBPK58CA')") unless team.to_s.length > 0
 

data/fastlane/lib/fastlane/actions/team_name.rb

@@ -5,7 +5,7 @@ module Fastlane
 
     class TeamNameAction < Action
       def self.run(params)
-        params = nil unless params.kind_of? Array
+        params = nil unless params.kind_of?(Array)
         team = (params || []).first
         UI.user_error!("Please pass your Team Name (e.g. team_name 'Felix Krause')") unless team.to_s.length > 0
 

data/fastlane/lib/fastlane/actions/testfairy.rb

@@ -10,12 +10,12 @@ module Fastlane
         require 'faraday_middleware'
 
         connection = Faraday.new(url: "https://upload.testfairy.com") do |builder|
-          builder.request :multipart
-          builder.request :url_encoded
-          builder.request :retry, max: 3, interval: 5
-          builder.response :json, content_type: /\bjson$/
-          builder.use FaradayMiddleware::FollowRedirects
-          builder.adapter :net_http
+          builder.request(:multipart)
+          builder.request(:url_encoded)
+          builder.request(:retry, max: 3, interval: 5)
+          builder.response(:json, content_type: /\bjson$/)
+          builder.use(FaradayMiddleware::FollowRedirects)
+          builder.adapter(:net_http)
         end
 
         options[:file] = Faraday::UploadIO.new(ipa, 'application/octet-stream') if ipa and File.exist?(ipa)
@@ -227,7 +227,7 @@ module Fastlane
       end
 
       def self.is_supported?(platform)
-        [:ios, :android].include? platform
+        [:ios, :android].include?(platform)
       end
     end
   end

data/fastlane/lib/fastlane/actions/tryouts.rb

@@ -28,11 +28,11 @@ module Fastlane
 
         url = TRYOUTS_API_BUILD_RELEASE_TEMPLATE % params[:app_id]
         connection = Faraday.new(url) do |builder|
-          builder.request :multipart
-          builder.request :url_encoded
-          builder.response :json, content_type: /\bjson$/
-          builder.use FaradayMiddleware::FollowRedirects
-          builder.adapter :net_http
+          builder.request(:multipart)
+          builder.request(:url_encoded)
+          builder.response(:json, content_type: /\bjson$/)
+          builder.use(FaradayMiddleware::FollowRedirects)
+          builder.adapter(:net_http)
         end
 
         options = {}
@@ -53,7 +53,7 @@ module Fastlane
         end
 
         post_request.on_complete do |env|
-          yield env[:status], env[:body] if block_given?
+          yield(env[:status], env[:body]) if block_given?
         end
       end
 

data/fastlane/lib/fastlane/actions/update_app_group_identifiers.rb

@@ -47,7 +47,7 @@ module Fastlane
                                        env_name: "FL_UPDATE_APP_GROUP_IDENTIFIER_ENTITLEMENTS_FILE_PATH", # The name of the environment variable
                                        description: "The path to the entitlement file which contains the app group identifiers", # a short description of this parameter
                                        verify_block: proc do |value|
-                                         UI.user_error!("Please pass a path to an entitlements file. ") unless value.include? ".entitlements"
+                                         UI.user_error!("Please pass a path to an entitlements file. ") unless value.include?(".entitlements")
                                          UI.user_error!("Could not find entitlements file") if !File.exist?(value) and !Helper.is_test?
                                        end),
           FastlaneCore::ConfigItem.new(key: :app_group_identifiers,
@@ -55,7 +55,7 @@ module Fastlane
                                        description: "An Array of unique identifiers for the app groups. Eg. ['group.com.test.testapp']",
                                        is_string: false,
                                        verify_block: proc do |value|
-                                         UI.user_error!("The parameter app_group_identifiers need to be an Array.") unless value.kind_of? Array
+                                         UI.user_error!("The parameter app_group_identifiers need to be an Array.") unless value.kind_of?(Array)
                                        end)
         ]
       end