fastlane 2.74.1 → 2.75.0.beta.20180109010003

data/spaceship/lib/spaceship/portal/certificate.rb

@@ -191,7 +191,7 @@ module Spaceship
         #  # Use the signing request to create a new distribution certificate
         #  Spaceship.certificate.production.create!(csr: csr)
         def create_certificate_signing_request
-          key = OpenSSL::PKey::RSA.new 2048
+          key = OpenSSL::PKey::RSA.new(2048)
           csr = OpenSSL::X509::Request.new
           csr.version = 0
           csr.subject = OpenSSL::X509::Name.new([
@@ -254,7 +254,7 @@ module Spaceship
             types += OLDER_IOS_CERTIFICATE_TYPES unless mac
           else
             types = [CERTIFICATE_TYPE_IDS.key(self)]
-            mac = MAC_CERTIFICATE_TYPE_IDS.values.include? self
+            mac = MAC_CERTIFICATE_TYPE_IDS.values.include?(self)
           end
 
           client.certificates(types, mac: mac).map do |cert|
@@ -285,7 +285,7 @@ module Spaceship
         # @return (Certificate): The newly created certificate
         def create!(csr: nil, bundle_id: nil)
           type = CERTIFICATE_TYPE_IDS.key(self)
-          mac = MAC_CERTIFICATE_TYPE_IDS.include? type
+          mac = MAC_CERTIFICATE_TYPE_IDS.include?(type)
 
           # look up the app_id by the bundle_id
           if bundle_id
@@ -324,12 +324,12 @@ module Spaceship
 
       # @return (Bool): Is this certificate a push profile for apps?
       def is_push?
-        self.kind_of? PushCertificate
+        self.kind_of?(PushCertificate)
       end
 
       # @return (Bool) Is this a Mac profile?
       def mac?
-        MAC_CERTIFICATE_TYPE_IDS.include? type_display_id
+        MAC_CERTIFICATE_TYPE_IDS.include?(type_display_id)
       end
     end
   end

data/spaceship/lib/spaceship/portal/device.rb

@@ -98,9 +98,9 @@ module Spaceship
 
         # @return (Array) Returns all devices matching the provided profile_type
         def all_for_profile_type(profile_type)
-          if profile_type.include? "tvOS"
+          if profile_type.include?("tvOS")
             Spaceship::Portal::Device.all_apple_tvs
-          elsif profile_type.include? "Mac"
+          elsif profile_type.include?("Mac")
             Spaceship::Portal::Device.all_macs
           else
             Spaceship::Portal::Device.all_ios_profile_devices

data/spaceship/lib/spaceship/portal/portal_client.rb

@@ -54,7 +54,7 @@ module Spaceship
       return @current_team_id if @current_team_id
 
       if teams.count > 1
-        puts "The current user is in #{teams.count} teams. Pass a team ID or call `select_team` to choose a team. Using the first one for now."
+        puts("The current user is in #{teams.count} teams. Pass a team ID or call `select_team` to choose a team. Using the first one for now.")
       end
 
       if teams.count == 0
@@ -378,7 +378,7 @@ module Spaceship
     #####################################################
     def team_members
       response = request(:post) do |req|
-        req.url "/services-account/#{PROTOCOL_VERSION}/account/getTeamMembers"
+        req.url("/services-account/#{PROTOCOL_VERSION}/account/getTeamMembers")
         req.body = {
           teamId: team_id
         }.to_json
@@ -389,7 +389,7 @@ module Spaceship
 
     def team_invited
       response = request(:post) do |req|
-        req.url "/services-account/#{PROTOCOL_VERSION}/account/getInvites"
+        req.url("/services-account/#{PROTOCOL_VERSION}/account/getInvites")
         req.body = {
           teamId: team_id
         }.to_json
@@ -401,7 +401,7 @@ module Spaceship
     def team_set_role(team_member_id, role)
       ensure_csrf(Spaceship::Portal::Persons)
       response = request(:post) do |req|
-        req.url "/services-account/#{PROTOCOL_VERSION}/account/setTeamMemberRoles"
+        req.url("/services-account/#{PROTOCOL_VERSION}/account/setTeamMemberRoles")
         req.body = {
           teamId: team_id,
           role: role,
@@ -415,7 +415,7 @@ module Spaceship
     def team_remove_member!(team_member_id)
       ensure_csrf(Spaceship::Portal::Persons)
       response = request(:post) do |req|
-        req.url "/services-account/#{PROTOCOL_VERSION}/account/removeTeamMembers"
+        req.url("/services-account/#{PROTOCOL_VERSION}/account/removeTeamMembers")
         req.body = {
           teamId: team_id,
           teamMemberIds: [team_member_id]
@@ -428,7 +428,7 @@ module Spaceship
     def team_invite(email, role)
       ensure_csrf(Spaceship::Portal::Persons)
       response = request(:post) do |req|
-        req.url "/services-account/#{PROTOCOL_VERSION}/account/sendInvites"
+        req.url("/services-account/#{PROTOCOL_VERSION}/account/sendInvites")
         req.body = {
           invites: [
             { recipientEmail: email, recipientRole: role }
@@ -591,7 +591,7 @@ module Spaceship
     # Use this method over `provisioning_profiles` if possible because no secondary API calls are necessary to populate the ProvisioningProfile data model.
     def provisioning_profiles_via_xcode_api(mac: false)
       req = request(:post) do |r|
-        r.url "https://developerservices2.apple.com/services/#{PROTOCOL_VERSION}/#{platform_slug(mac)}/listProvisioningProfiles.action"
+        r.url("https://developerservices2.apple.com/services/#{PROTOCOL_VERSION}/#{platform_slug(mac)}/listProvisioningProfiles.action")
         r.params = {
           teamId: team_id,
           includeInactiveProfiles: true,

data/spaceship/lib/spaceship/portal/provisioning_profile.rb

@@ -193,7 +193,6 @@ module Spaceship
         # Create a new object based on a hash.
         # This is used to create a new object based on the server response.
         def factory(attrs)
-          # rubocop:disable Lint/MissingRequireStatement
           # available values of `distributionMethod` at this point: ['adhoc', 'store', 'limited', 'direct']
           klass = case attrs['distributionMethod']
                   when 'limited'
@@ -207,7 +206,6 @@ module Spaceship
                   else
                     raise "Can't find class '#{attrs['distributionMethod']}'"
                   end
-          # rubocop:enable Lint/MissingRequireStatement
 
           # Parse the dates
           # rubocop:disable Style/RescueModifier
@@ -269,19 +267,19 @@ module Spaceship
           # Fill in sensible default values
           name ||= [bundle_id, self.pretty_type].join(' ')
 
-          if self == AppStore || self == InHouse || self == Direct # rubocop:disable Lint/MissingRequireStatement
+          if self == AppStore || self == InHouse || self == Direct
             # Distribution Profiles MUST NOT have devices
             devices = []
           end
 
-          certificate_parameter = certificate.collect(&:id) if certificate.kind_of? Array
+          certificate_parameter = certificate.collect(&:id) if certificate.kind_of?(Array)
           certificate_parameter ||= [certificate.id]
 
           # Fix https://github.com/KrauseFx/fastlane/issues/349
           certificate_parameter = certificate_parameter.first if certificate_parameter.count == 1
 
           if devices.nil? or devices.count == 0
-            if self == Development or self == AdHoc # rubocop:disable Lint/MissingRequireStatement
+            if self == Development or self == AdHoc
               # For Development and AdHoc we usually want all compatible devices by default
               if mac
                 devices = Spaceship::Portal::Device.all_macs
@@ -444,17 +442,17 @@ module Spaceship
         # This is the minimum protection needed for people using spaceship directly
         unless certificate_valid?
           if mac?
-            if self.kind_of? Development
+            if self.kind_of?(Development)
               self.certificates = [Spaceship::Portal::Certificate::MacDevelopment.all.first]
-            elsif self.kind_of? Direct
+            elsif self.kind_of?(Direct)
               self.certificates = [Spaceship::Portal::Certificate::DeveloperIDApplication.all.first]
             else
               self.certificates = [Spaceship::Portal::Certificate::MacAppDistribution.all.first]
             end
           else
-            if self.kind_of? Development
+            if self.kind_of?(Development)
               self.certificates = [Spaceship::Portal::Certificate::Development.all.first]
-            elsif self.kind_of? InHouse
+            elsif self.kind_of?(InHouse)
               self.certificates = [Spaceship::Portal::Certificate::InHouse.all.first]
             else
               self.certificates = [Spaceship::Portal::Certificate::Production.all.first]

data/spaceship/lib/spaceship/portal/ui/select_team.rb

@@ -31,7 +31,7 @@ module Spaceship
       #     {...}
       #   ]
 
-      # rubocop:disable Lint/MissingRequireStatement
+      # rubocop:disable Require/MissingRequireStatement
       def self.ci?
         if Object.const_defined?("FastlaneCore") && FastlaneCore.const_defined?("Helper")
           return FastlaneCore::Helper.ci?
@@ -45,15 +45,15 @@ module Spaceship
         end
         return true
       end
-      # rubocop:enable Lint/MissingRequireStatement
+      # rubocop:enable Require/MissingRequireStatement
 
       def select_team
         teams = client.teams
 
         if teams.count == 0
-          puts "No teams available on the Developer Portal"
-          puts "You must accept an invitation to a team for it to be available"
-          puts "To learn more about teams and how to use them visit https://developer.apple.com/library/ios/documentation/IDEs/Conceptual/AppDistributionGuide/ManagingYourTeam/ManagingYourTeam.html"
+          puts("No teams available on the Developer Portal")
+          puts("You must accept an invitation to a team for it to be available")
+          puts("To learn more about teams and how to use them visit https://developer.apple.com/library/ios/documentation/IDEs/Conceptual/AppDistributionGuide/ManagingYourTeam/ManagingYourTeam.html")
           raise "Your account is in no teams"
         end
 
@@ -67,7 +67,7 @@ module Spaceship
             return team['teamId'] if team['teamId'].strip == team_id
             return team['teamId'] if team['currentTeamMember']['teamMemberId'].to_s.strip == team_id
           end
-          puts "Couldn't find team with ID '#{team_id}'"
+          puts("Couldn't find team with ID '#{team_id}'")
         end
 
         if team_name.length > 0
@@ -75,17 +75,17 @@ module Spaceship
           teams.each_with_index do |team, i|
             return team['teamId'] if team['name'].strip == team_name
           end
-          puts "Couldn't find team with Name '#{team_name}'"
+          puts("Couldn't find team with Name '#{team_name}'")
         end
 
         return teams[0]['teamId'] if teams.count == 1 # user is just in one team
 
         unless self.class.interactive?
-          puts "Multiple teams found on the Developer Portal, Your Terminal is running in non-interactive mode! Cannot continue from here."
-          puts "Please check that you set FASTLANE_TEAM_ID or FASTLANE_TEAM_NAME to the right value."
-          puts "Available Teams:"
+          puts("Multiple teams found on the Developer Portal, Your Terminal is running in non-interactive mode! Cannot continue from here.")
+          puts("Please check that you set FASTLANE_TEAM_ID or FASTLANE_TEAM_NAME to the right value.")
+          puts("Available Teams:")
           teams.each_with_index do |team, i|
-            puts "#{i + 1}) #{team['teamId']} \"#{team['name']}\" (#{team['type']})"
+            puts("#{i + 1}) #{team['teamId']} \"#{team['name']}\" (#{team['type']})")
           end
           raise "Multiple Teams found; unable to choose, terminal not ineractive!"
         end
@@ -93,9 +93,9 @@ module Spaceship
         # User Selection
         loop do
           # Multiple teams, user has to select
-          puts "Multiple teams found on the Developer Portal, please enter the number of the team you want to use: "
+          puts("Multiple teams found on the Developer Portal, please enter the number of the team you want to use: ")
           teams.each_with_index do |team, i|
-            puts "#{i + 1}) #{team['teamId']} \"#{team['name']}\" (#{team['type']})"
+            puts("#{i + 1}) #{team['teamId']} \"#{team['name']}\" (#{team['type']})")
           end
 
           selected = ($stdin.gets || '').strip.to_i - 1

data/spaceship/lib/spaceship/spaceauth_runner.rb

@@ -14,16 +14,16 @@ module Spaceship
 
     def run
       begin
-        puts "Logging into to iTunes Connect (#{@username})..."
+        puts("Logging into to iTunes Connect (#{@username})...")
         Spaceship::Tunes.login(@username)
-        puts "Successfully logged in to iTunes Connect".green
-        puts ""
+        puts("Successfully logged in to iTunes Connect".green)
+        puts("")
       rescue
-        puts "Could not login to iTunes Connect".red
-        puts "Please check your credentials and try again.".yellow
-        puts "This could be an issue with iTunes Connect,".yellow
-        puts "Please try unsetting the FASTLANE_SESSION environment variable".yellow
-        puts "and re-run `fastlane spaceauth`".yellow
+        puts("Could not login to iTunes Connect".red)
+        puts("Please check your credentials and try again.".yellow)
+        puts("This could be an issue with iTunes Connect,".yellow)
+        puts("Please try unsetting the FASTLANE_SESSION environment variable".yellow)
+        puts("and re-run `fastlane spaceauth`".yellow)
         raise "Problem connecting to iTunes Connect"
       end
 
@@ -49,14 +49,14 @@ module Spaceship
 
       yaml = cookies.to_yaml.gsub("\n", "\\n")
 
-      puts "---"
-      puts ""
-      puts "Pass the following via the FASTLANE_SESSION environment variable:"
-      puts yaml.cyan.underline
-      puts ""
-      puts ""
-      puts "Example:"
-      puts "export FASTLANE_SESSION='#{yaml}'".cyan.underline
+      puts("---")
+      puts("")
+      puts("Pass the following via the FASTLANE_SESSION environment variable:")
+      puts(yaml.cyan.underline)
+      puts("")
+      puts("")
+      puts("Example:")
+      puts("export FASTLANE_SESSION='#{yaml}'".cyan.underline)
     end
   end
 end

data/spaceship/lib/spaceship/test_flight/client.rb

@@ -54,7 +54,7 @@ module Spaceship
         assert_required_params(__method__, binding)
 
         response = request(:put) do |req|
-          req.url "providers/#{team_id}/apps/#{app_id}/builds/#{build_id}"
+          req.url("providers/#{team_id}/apps/#{app_id}/builds/#{build_id}")
           req.body = build.to_json
           req.headers['Content-Type'] = 'application/json'
         end
@@ -65,7 +65,7 @@ module Spaceship
         assert_required_params(__method__, binding)
 
         response = request(:post) do |req|
-          req.url "providers/#{team_id}/apps/#{app_id}/builds/#{build_id}/review"
+          req.url("providers/#{team_id}/apps/#{app_id}/builds/#{build_id}/review")
           req.body = build.to_json
           req.headers['Content-Type'] = 'application/json'
         end
@@ -76,7 +76,7 @@ module Spaceship
         assert_required_params(__method__, binding)
 
         response = request(:post) do |req|
-          req.url "providers/#{team_id}/apps/#{app_id}/builds/#{build_id}/expire"
+          req.url("providers/#{team_id}/apps/#{app_id}/builds/#{build_id}/expire")
           req.body = build.to_json
           req.headers['Content-Type'] = 'application/json'
         end
@@ -106,7 +106,7 @@ module Spaceship
         }
 
         response = request(:post) do |req|
-          req.url "providers/#{team_id}/apps/#{app_id}/groups"
+          req.url("providers/#{team_id}/apps/#{app_id}/groups")
           req.body = body.to_json
           req.headers['Content-Type'] = 'application/json'
         end
@@ -121,7 +121,7 @@ module Spaceship
           'buildId' => build_id
         }
         response = request(:put) do |req|
-          req.url "providers/#{team_id}/apps/#{app_id}/groups/#{group_id}/builds/#{build_id}"
+          req.url("providers/#{team_id}/apps/#{app_id}/groups/#{group_id}/builds/#{build_id}")
           req.body = body.to_json
           req.headers['Content-Type'] = 'application/json'
         end
@@ -212,7 +212,7 @@ module Spaceship
         assert_required_params(__method__, binding)
         url = "providers/#{team_id}/apps/#{app_id}/testers"
         response = request(:post) do |req|
-          req.url url
+          req.url(url)
           req.body = {
             "email" => email,
             "firstName" => first_name,
@@ -230,7 +230,7 @@ module Spaceship
         # This is easy enough, we already have all this data. We don't need any response from the previous request
         url = "providers/#{team_id}/apps/#{app_id}/groups/#{group_id}/testers"
         response = request(:post) do |req|
-          req.url url
+          req.url(url)
           req.body = [{
             "email" => email,
             "firstName" => first_name,
@@ -246,7 +246,7 @@ module Spaceship
 
         url = "providers/#{team_id}/apps/#{app_id}/groups/#{group_id}/testers/#{tester_id}"
         response = request(:delete) do |req|
-          req.url url
+          req.url(url)
           req.headers['Content-Type'] = 'application/json'
         end
         handle_response(response)
@@ -267,7 +267,7 @@ module Spaceship
         assert_required_params(__method__, binding)
 
         response = request(:put) do |req|
-          req.url "providers/#{team_id}/apps/#{app_id}/testInfo"
+          req.url("providers/#{team_id}/apps/#{app_id}/testInfo")
           req.body = app_test_info.to_json
           req.headers['Content-Type'] = 'application/json'
         end

data/spaceship/lib/spaceship/tunes/app_details.rb

@@ -139,7 +139,7 @@ module Spaceship
       end
 
       def prefix_apps(value)
-        return value unless value.include? "Stickers"
+        return value unless value.include?("Stickers")
         value.include?("Apps") ? value : "Apps.#{value}"
       end
     end

data/spaceship/lib/spaceship/tunes/app_version.rb

@@ -304,7 +304,7 @@ module Spaceship
       # Important: Due to a bug you have to fetch the `edit_version` again, as it doesn't get refreshed immediately
       def create_languages(languages)
         languages = [languages] if languages.kind_of?(String)
-        raise "Please pass an array" unless languages.kind_of? Array
+        raise "Please pass an array" unless languages.kind_of?(Array)
 
         copy_from = self.languages.find { |a| a['language'] == 'en-US' } || self.languages.first
 
@@ -442,7 +442,7 @@ module Spaceship
           @large_app_icon.reset!
           return
         end
-        upload_image = UploadFile.from_path icon_path
+        upload_image = UploadFile.from_path(icon_path)
         image_data = client.upload_large_icon(self, upload_image)
 
         raw_data["largeAppIcon"]["value"] = generate_image_metadata(image_data, upload_image.file_name)
@@ -455,7 +455,7 @@ module Spaceship
           @watch_app_icon.reset!
           return
         end
-        upload_image = UploadFile.from_path icon_path
+        upload_image = UploadFile.from_path(icon_path)
         image_data = client.upload_watch_icon(self, upload_image)
 
         raw_data["watchAppIcon"]["value"] = generate_image_metadata(image_data, upload_image.file_name)
@@ -469,7 +469,7 @@ module Spaceship
           @transit_app_file = nil
           return
         end
-        upload_file = UploadFile.from_path geojson_path
+        upload_file = UploadFile.from_path(geojson_path)
         geojson_data = client.upload_geojson(self, upload_file)
 
         @transit_app_file = Tunes::TransitAppFile.factory({}) if @transit_app_file.nil?
@@ -493,7 +493,7 @@ module Spaceship
 
         existing_sort_orders = device_lang_screenshots.map { |s| s["value"]["sortOrder"] }
         if screenshot_path # adding / replacing
-          upload_file = UploadFile.from_path screenshot_path
+          upload_file = UploadFile.from_path(screenshot_path)
           screenshot_data = client.upload_screenshot(self, upload_file, device, is_messages)
 
           # Since October 2016 we also need to pass the size, height, width and checksum
@@ -569,10 +569,10 @@ module Spaceship
             video_preview_resolution = video_preview_resolution_for(device, trailer_path)
             video_preview_path = Utilities.grab_video_preview(trailer_path, timestamp, video_preview_resolution)
           end
-          video_preview_file = UploadFile.from_path video_preview_path
+          video_preview_file = UploadFile.from_path(video_preview_path)
           video_preview_data = client.upload_trailer_preview(self, video_preview_file, device)
 
-          upload_file = UploadFile.from_path trailer_path
+          upload_file = UploadFile.from_path(trailer_path)
           trailer_data = client.upload_trailer(self, upload_file)
 
           ts = "00:00:#{timestamp}"

data/spaceship/lib/spaceship/tunes/app_version_common.rb

@@ -15,7 +15,7 @@ module Spaceship
           search_platform = search_platform.to_sym if search_platform
 
           platform = versions.detect do |p|
-            ['ios', 'osx', 'appletvos'].include? p['platformString']
+            ['ios', 'osx', 'appletvos'].include?(p['platformString'])
           end
 
           raise "Could not find platform 'ios', 'osx' or 'appletvos'" unless platform