fastlane 2.74.1 → 2.75.0.beta.20180109010003

data/fastlane/lib/fastlane/fast_file.rb

@@ -20,10 +20,10 @@ module Fastlane
 
       # From https://github.com/orta/danger/blob/master/lib/danger/Dangerfile.rb
       if content.tr!('“”‘’‛', %(""'''))
-        UI.error "Your #{File.basename(path)} has had smart quotes sanitised. " \
+        UI.error("Your #{File.basename(path)} has had smart quotes sanitised. " \
                 'To avoid issues in the future, you should not use ' \
                 'TextEdit for editing it. If you are not using TextEdit, ' \
-                'you should turn off smart quotes in your editor of choice.'
+                'you should turn off smart quotes in your editor of choice.')
       end
 
       content.scan(/^\s*require (.*)/).each do |current|
@@ -249,14 +249,14 @@ module Fastlane
 
           branch_option = "--branch #{branch}" if branch != 'HEAD'
 
-          UI.message "Cloning remote git repo..."
+          UI.message("Cloning remote git repo...")
           Actions.sh("GIT_TERMINAL_PROMPT=0 git clone '#{url}' '#{clone_folder}' --depth 1 -n #{branch_option}")
 
           unless version.nil?
             req = Gem::Requirement.new(version)
             all_tags = fetch_remote_tags(folder: clone_folder)
             checkout_param = all_tags.select { |t| req =~ FastlaneCore::TagVersion.new(t) }.last
-            UI.user_error! "No tag found matching #{version.inspect}" if checkout_param.nil?
+            UI.user_error!("No tag found matching #{version.inspect}") if checkout_param.nil?
           end
 
           Actions.sh("cd '#{clone_folder}' && git checkout #{checkout_param} '#{path}'")
@@ -285,7 +285,7 @@ module Fastlane
     #####################################################
 
     def fetch_remote_tags(folder: nil)
-      UI.message "Fetching remote git tags..."
+      UI.message("Fetching remote git tags...")
       Actions.sh("cd '#{folder}' && GIT_TERMINAL_PROMPT=0 git fetch --all --tags -q")
 
       # Fetch all possible tags

data/fastlane/lib/fastlane/fastlane_require.rb

@@ -24,7 +24,7 @@ module Fastlane
         require "rubygems/command_manager"
         installer = Gem::CommandManager.instance[:install]
 
-        UI.important "Installing Ruby gem '#{gem_name}'..."
+        UI.important("Installing Ruby gem '#{gem_name}'...")
 
         spec_name = self.find_gem_name(gem_name)
         UI.important("Found gem \"#{spec_name}\" instead of the required name \"#{gem_name}\"") if spec_name != gem_name
@@ -65,7 +65,7 @@ module Fastlane
 
       def format_gem_require_name(gem_name)
         # from "fastlane-plugin-xcversion" to "fastlane/plugin/xcversion"
-        gem_name = gem_name.tr("-", "/") if gem_name.start_with? "fastlane-plugin-"
+        gem_name = gem_name.tr("-", "/") if gem_name.start_with?("fastlane-plugin-")
 
         return gem_name
       end

data/fastlane/lib/fastlane/helper/crashlytics_helper.rb

@@ -84,15 +84,15 @@ module Fastlane
             http_conn = Net::HTTP.new(uri.host, uri.port)
             http_conn.use_ssl = true
             result = http_conn.request_get(uri.path)
-            UI.error! "#{result.message} (#{result.code})" unless result.kind_of? Net::HTTPSuccess
+            UI.error!("#{result.message} (#{result.code})") unless result.kind_of?(Net::HTTPSuccess)
             File.write(zip_path, result.body)
 
             # Now unzip the file
-            Action.sh "unzip '#{zip_path}' -d '#{containing}'"
+            Action.sh("unzip '#{zip_path}' -d '#{containing}'")
 
             UI.user_error!("Couldn't find 'crashlytics-devtools.jar'") unless File.exist?(jar_path)
 
-            UI.success "Successfully downloaded Crashlytics Support Library to '#{jar_path}'"
+            UI.success("Successfully downloaded Crashlytics Support Library to '#{jar_path}'")
           rescue => ex
             UI.user_error!("Error fetching remote file: #{ex}")
           end

data/fastlane/lib/fastlane/helper/podspec_helper.rb

@@ -65,7 +65,7 @@ module Fastlane
         new_version = version || @version_value
         updated_podspec_content = @podspec_content.gsub(@version_regex, "#{@version_match[:begin]}#{new_version}#{@version_match[:end]}")
 
-        File.open(@path, "w") { |file| file.puts updated_podspec_content } unless Helper.test?
+        File.open(@path, "w") { |file| file.puts(updated_podspec_content) } unless Helper.test?
 
         updated_podspec_content
       end

data/fastlane/lib/fastlane/helper/sh_helper.rb

@@ -88,7 +88,7 @@ module Fastlane
         # Avoid yielding nil in tests. $? will be meaningless, but calls to
         # it will not crash. There is no Process::Status.new. The alternative
         # is to move this inside the sh_enabled? check and not yield in tests.
-        return yield exit_status || $?, result, shell_command
+        return yield(exit_status || $?, result, shell_command)
       end
       result
     rescue => ex
@@ -121,7 +121,7 @@ module Fastlane
       # Support [ "/usr/local/bin/foo", "foo" ], "-x", ...
       if args.first.kind_of?(Array)
         command += args.shift.first.shellescape + " " + args.shelljoin
-        command.chomp! " "
+        command.chomp!(" ")
       elsif args.count == 1 && args.first.kind_of?(String)
         command += args.first
       else

data/fastlane/lib/fastlane/helper/xcversion_helper.rb

@@ -8,7 +8,7 @@ module Fastlane
         installer = XcodeInstall::Installer.new
         installed = installer.installed_versions.reverse
         installed.detect do |xcode|
-          req.satisfied_by? Gem::Version.new(xcode.version)
+          req.satisfied_by?(Gem::Version.new(xcode.version))
         end
       end
 

data/fastlane/lib/fastlane/lane.rb

@@ -15,9 +15,9 @@ module Fastlane
     attr_accessor :is_private
 
     def initialize(platform: nil, name: nil, description: nil, block: nil, is_private: false)
-      UI.user_error!("description must be an array") unless description.kind_of? Array
-      UI.user_error!("lane name must not contain any spaces") if name.to_s.include? " "
-      UI.user_error!("lane name must start with :") unless name.kind_of? Symbol
+      UI.user_error!("description must be an array") unless description.kind_of?(Array)
+      UI.user_error!("lane name must not contain any spaces") if name.to_s.include?(" ")
+      UI.user_error!("lane name must start with :") unless name.kind_of?(Symbol)
 
       self.class.verify_lane_name(name)
 
@@ -42,13 +42,13 @@ module Fastlane
       # Makes sure the lane name is valid
       def verify_lane_name(name)
         if self.black_list.include?(name.to_s)
-          UI.error "Lane name '#{name}' is invalid! Invalid names are #{self.black_list.join(', ')}."
+          UI.error("Lane name '#{name}' is invalid! Invalid names are #{self.black_list.join(', ')}.")
           UI.user_error!("Lane name '#{name}' is invalid")
         end
 
         if self.gray_list.include?(name.to_sym)
-          UI.error "Lane name '#{name}' should not be used because it is the name of a fastlane tool"
-          UI.error "It is recommended to not use '#{name}' as the name of your lane"
+          UI.error("Lane name '#{name}' should not be used because it is the name of a fastlane tool")
+          UI.error("It is recommended to not use '#{name}' as the name of your lane")
           # We still allow it, because we're nice
           # Otherwise we might break existing setups
           return

data/fastlane/lib/fastlane/lane_list.rb

@@ -4,9 +4,9 @@ module Fastlane
     SWIFT_FUNCTION_REGEX = /\s*func\s*(\w*)\s*\(\s*\)\s*/
     SWIFT_DESC_REGEX = /\s*desc\s*\(\s*"(.*)"\s*\)\s*/
     def self.output(path)
-      puts generate(path)
+      puts(generate(path))
 
-      puts "Execute using `fastlane [lane_name]`".yellow
+      puts("Execute using `fastlane [lane_name]`".yellow)
     end
 
     def self.generate_swift_lanes(path)
@@ -103,7 +103,7 @@ module Fastlane
     end
 
     def self.output_json(path)
-      puts JSON.pretty_generate(self.generate_json(path))
+      puts(JSON.pretty_generate(self.generate_json(path)))
     end
 
     # Returns a hash

data/fastlane/lib/fastlane/lane_manager.rb

@@ -60,7 +60,7 @@ module Fastlane
         # Tested with `xcake`, which throws a `Xcake::Informative` object
 
         print_lane_context
-        UI.error ex.to_s if ex.kind_of?(StandardError) # we don't want to print things like 'system exit'
+        UI.error(ex.to_s) if ex.kind_of?(StandardError) # we don't want to print things like 'system exit'
         e = ex
       end
 
@@ -89,7 +89,7 @@ module Fastlane
       end
 
       if available.empty?
-        UI.user_error! "It looks like you don't have any lanes to run just yet. Check out how to get started here: https://github.com/fastlane/fastlane 🚀"
+        UI.user_error!("It looks like you don't have any lanes to run just yet. Check out how to get started here: https://github.com/fastlane/fastlane 🚀")
       end
 
       rows = []
@@ -105,16 +105,16 @@ module Fastlane
         rows: FastlaneCore::PrintTable.transform_output(rows)
       )
 
-      UI.message "Welcome to fastlane! Here's what your app is setup to do:"
+      UI.message("Welcome to fastlane! Here's what your app is setup to do:")
 
-      puts table
+      puts(table)
 
-      i = UI.input "Which number would you like run?"
+      i = UI.input("Which number would you like run?")
 
       i = i.to_i - 1
       if i >= 0 && available[i]
         selection = available[i].last.pretty_name
-        UI.important "Running lane `#{selection}`. Next time you can do this by directly typing `fastlane #{selection}` 🚀."
+        UI.important("Running lane `#{selection}`. Next time you can do this by directly typing `fastlane #{selection}` 🚀.")
         platform = selection.split(' ')[0]
         lane_name = selection.split(' ')[1]
 
@@ -125,7 +125,7 @@ module Fastlane
 
         return platform, lane_name # yeah
       else
-        UI.user_error! "Run `fastlane` the next time you need to build, test or release your app 🚀"
+        UI.user_error!("Run `fastlane` the next time you need to build, test or release your app 🚀")
       end
     end
   end

data/fastlane/lib/fastlane/lane_manager_base.rb

@@ -20,12 +20,12 @@ module Fastlane
       Fastlane::PluginUpdateManager.show_update_status
 
       if error
-        UI.error 'fastlane finished with errors' unless skip_message
+        UI.error('fastlane finished with errors') unless skip_message
         raise error
       elsif duration > 5
-        UI.success "fastlane.tools just saved you #{duration} minutes! 🎉" unless skip_message
+        UI.success("fastlane.tools just saved you #{duration} minutes! 🎉") unless skip_message
       else
-        UI.success 'fastlane.tools finished successfully 🎉' unless skip_message
+        UI.success('fastlane.tools finished successfully 🎉') unless skip_message
       end
     end
 
@@ -46,13 +46,13 @@ module Fastlane
         rows << [index, name, current[:time].to_i]
       end
 
-      puts ""
-      puts Terminal::Table.new(
-        title: "fastlane summary".green,
-        headings: ["Step", "Action", "Time (in s)"],
-        rows: FastlaneCore::PrintTable.transform_output(rows)
-      )
-      puts ""
+      puts("")
+      puts(Terminal::Table.new(
+             title: "fastlane summary".green,
+             headings: ["Step", "Action", "Time (in s)"],
+             rows: FastlaneCore::PrintTable.transform_output(rows)
+      ))
+      puts("")
     end
 
     # @param env_cl_param [String] an optional list of dotenv environment names separated by commas, without space
@@ -95,7 +95,7 @@ module Fastlane
       # Loads .env file for the environment(s) passed in through options
       envs.each do |env|
         env_file = File.join(base_path, ".env.#{env}")
-        UI.success "Loading from '#{env_file}'"
+        UI.success("Loading from '#{env_file}'")
         Dotenv.overload(env_file)
       end
     end
@@ -104,8 +104,8 @@ module Fastlane
       return if Actions.lane_context.empty?
 
       if FastlaneCore::Globals.verbose?
-        UI.important 'Lane Context:'.yellow
-        UI.message Actions.lane_context
+        UI.important('Lane Context:'.yellow)
+        UI.message(Actions.lane_context)
         return
       end
 
@@ -115,10 +115,10 @@ module Fastlane
       end
 
       require 'terminal-table'
-      puts Terminal::Table.new({
+      puts(Terminal::Table.new({
         title: "Lane Context".yellow,
         rows: FastlaneCore::PrintTable.transform_output(rows)
-      })
+      }))
     end
   end
 end

data/fastlane/lib/fastlane/markdown_table_formatter.rb

@@ -13,7 +13,7 @@ module Fastlane
       rows.each do |row|
         row_array = row.split("|")
         row_array.each(&:strip!)
-        @table.push row_array
+        @table.push(row_array)
       end
       @table.delete_at(1) if @header # strip header separator
       @table
@@ -43,7 +43,7 @@ module Fastlane
     def header_separator_row
       output = []
       [*0...table.first.length].each do |column|
-        output.push separator(column_width(column))
+        output.push(separator(column_width(column)))
       end
       output
     end

data/fastlane/lib/fastlane/new_action.rb

@@ -7,11 +7,11 @@ module Fastlane
     end
 
     def self.fetch_name
-      puts "Must be lower case, and use a '_' between words. Do not use '.'".green
-      puts "examples: 'testflight', 'upload_to_s3'".green
+      puts("Must be lower case, and use a '_' between words. Do not use '.'".green)
+      puts("examples: 'testflight', 'upload_to_s3'".green)
       name = UI.input("Name of your action: ")
       until name_valid?(name)
-        puts "Name is invalid. Please ensure the name is all lowercase, free of spaces and without special characters! Try again."
+        puts("Name is invalid. Please ensure the name is all lowercase, free of spaces and without special characters! Try again.")
         name = UI.input("Name of your action: ")
       end
       name
@@ -28,14 +28,14 @@ module Fastlane
 
       path = File.join(actions_path, "#{name}.rb")
       File.write(path, template)
-      UI.success "Created new action file '#{path}'. Edit it to implement your custom action."
+      UI.success("Created new action file '#{path}'. Edit it to implement your custom action.")
     end
 
     def self.check_action_name_from_args(new_action_name)
       if name_valid?(new_action_name)
         new_action_name
       else
-        puts "Name is invalid. Please ensure the name is all lowercase, free of spaces and without special characters! Try again."
+        puts("Name is invalid. Please ensure the name is all lowercase, free of spaces and without special characters! Try again.")
       end
     end
 

data/fastlane/lib/fastlane/one_off.rb

@@ -6,7 +6,7 @@ module Fastlane
       action_name = nil
 
       args.each do |current|
-        if current.include? ":" # that's a key/value which we want to pass to the lane
+        if current.include?(":") # that's a key/value which we want to pass to the lane
           key, value = current.split(":", 2)
           UI.user_error!("Please pass values like this: key:value") unless key.length > 0
           value = CommandLineHandler.convert_value(value)

data/fastlane/lib/fastlane/plugins/plugin_generator.rb

@@ -28,11 +28,11 @@ module Fastlane
         handle_template_path(template_path, plugin_info)
       end
 
-      @ui.success "\nYour plugin was successfully generated at #{plugin_info.gem_name}/ 🚀"
-      @ui.success "\nTo get started with using this plugin, run"
-      @ui.message "\n    fastlane add_plugin #{plugin_info.plugin_name}\n"
-      @ui.success "\nfrom a fastlane-enabled app project directory and provide the following as the path:"
-      @ui.message "\n    #{File.expand_path(plugin_info.gem_name)}\n\n"
+      @ui.success("\nYour plugin was successfully generated at #{plugin_info.gem_name}/ 🚀")
+      @ui.success("\nTo get started with using this plugin, run")
+      @ui.message("\n    fastlane add_plugin #{plugin_info.plugin_name}\n")
+      @ui.success("\nfrom a fastlane-enabled app project directory and provide the following as the path:")
+      @ui.message("\n    #{File.expand_path(plugin_info.gem_name)}\n\n")
     end
 
     def handle_template_path(template_path, plugin_info)

data/fastlane/lib/fastlane/plugins/plugin_generator_ui.rb

@@ -1,11 +1,11 @@
 module Fastlane
   class PluginGeneratorUI
     def success(text)
-      puts text.green
+      puts(text.green)
     end
 
     def message(text)
-      puts text
+      puts(text)
     end
 
     def input(text)

data/fastlane/lib/fastlane/plugins/plugin_manager.rb

@@ -169,7 +169,7 @@ module Fastlane
     # This is necessary since the user might be prompted for their password
     def install_dependencies!
       # Using puts instead of `UI` to have the same style as the `echo`
-      puts "Installing plugin dependencies..."
+      puts("Installing plugin dependencies...")
       ensure_plugins_attached!
       with_clean_bundler_env do
         cmd = "bundle install"
@@ -183,7 +183,7 @@ module Fastlane
     # Warning: This will exec out
     # This is necessary since the user might be prompted for their password
     def update_dependencies!
-      puts "Updating plugin dependencies..."
+      puts("Updating plugin dependencies...")
       ensure_plugins_attached!
       plugins = available_plugins
       if plugins.empty?
@@ -233,8 +233,8 @@ module Fastlane
 
       unless UI.confirm("Should fastlane modify the Gemfile at path '#{path_to_gemfile}' for you?")
         UI.important("Please add the following code to '#{path_to_gemfile}':")
-        puts ""
-        puts self.class.code_to_attach.magenta # we use `puts` instead of `UI` to make it easier to copy and paste
+        puts("")
+        puts(self.class.code_to_attach.magenta) # we use `puts` instead of `UI` to make it easier to copy and paste
         UI.user_error!("Please update '#{path_to_gemfile} and run fastlane again")
       end
 
@@ -323,12 +323,12 @@ module Fastlane
       end
 
       require 'terminal-table'
-      puts Terminal::Table.new({
+      puts(Terminal::Table.new({
         rows: FastlaneCore::PrintTable.transform_output(rows),
         title: "Used plugins".green,
         headings: ["Plugin", "Version", "Action"]
-      })
-      puts ""
+      }))
+      puts("")
     end
 
     #####################################################

data/fastlane/lib/fastlane/plugins/plugin_search.rb

@@ -4,9 +4,9 @@ module Fastlane
 
     def self.print_plugins(search_query: nil)
       if search_query
-        UI.message "Looking for fastlane plugins containing '#{search_query}'..."
+        UI.message("Looking for fastlane plugins containing '#{search_query}'...")
       else
-        UI.message "Listing all available fastlane plugins"
+        UI.message("Listing all available fastlane plugins")
       end
 
       plugins = Fastlane::PluginFetcher.fetch_gems(search_query: search_query)
@@ -29,9 +29,9 @@ module Fastlane
         headings: ["Name", "Description", "Downloads"]
       }
 
-      puts ""
-      puts Terminal::Table.new(params)
-      puts ""
+      puts("")
+      puts(Terminal::Table.new(params))
+      puts("")
 
       if plugins.count == 1
         print_plugin_details(plugins.last)