fastlane 2.74.1 → 2.75.0.beta.20180109010003

data/fastlane/lib/fastlane/actions/update_fastlane.rb

@@ -10,7 +10,7 @@ module Fastlane
       def self.run(options)
         return if options[:no_update] # this is used to update itself
 
-        tools_to_update = options[:tools].split ',' unless options[:tools].nil?
+        tools_to_update = options[:tools].split(',') unless options[:tools].nil?
         tools_to_update ||= all_installed_tools
 
         if tools_to_update.count == 0
@@ -36,8 +36,8 @@ module Fastlane
         end
 
         unless updater.respond_to?(:highest_installed_gems)
-          UI.important "The update_fastlane action requires rubygems version 2.1.0 or greater."
-          UI.important "Please update your version of ruby gems before proceeding."
+          UI.important("The update_fastlane action requires rubygems version 2.1.0 or greater.")
+          UI.important("Please update your version of ruby gems before proceeding.")
           UI.command "gem install rubygems-update"
           UI.command "update_rubygems"
           UI.command "gem update --system"
@@ -89,7 +89,7 @@ module Fastlane
         UI.message("fastlane.tools successfully updated! I will now restart myself... 😴")
 
         # Set no_update to true so we don't try to update again
-        exec "FL_NO_UPDATE=true #{$PROGRAM_NAME} #{ARGV.join ' '}"
+        exec("FL_NO_UPDATE=true #{$PROGRAM_NAME} #{ARGV.join(' ')}")
       end
 
       def self.show_information_about_nightly_builds
@@ -104,7 +104,7 @@ module Fastlane
       end
 
       def self.all_installed_tools
-        Gem::Specification.select { |s| ALL_TOOLS.include? s.name }.map(&:name).uniq
+        Gem::Specification.select { |s| ALL_TOOLS.include?(s.name) }.map(&:name).uniq
       end
 
       def self.description

data/fastlane/lib/fastlane/actions/update_icloud_container_identifiers.rb

@@ -9,21 +9,21 @@ module Fastlane
 
       def self.run(params)
         entitlements_file = params[:entitlements_file]
-        UI.message "Entitlements File: #{entitlements_file}"
+        UI.message("Entitlements File: #{entitlements_file}")
 
         # parse entitlements
         result = Plist.parse_xml(entitlements_file)
-        UI.error "Entitlements file at '#{entitlements_file}' cannot be parsed." unless result
+        UI.error("Entitlements file at '#{entitlements_file}' cannot be parsed.") unless result
 
         # get iCloud container field
         icloud_container_key = 'com.apple.developer.icloud-container-identifiers'
         icloud_container_value = result[icloud_container_key]
-        UI.error "No existing iCloud container field specified. Please specify an iCloud container in the entitlements file." unless icloud_container_value
+        UI.error("No existing iCloud container field specified. Please specify an iCloud container in the entitlements file.") unless icloud_container_value
 
         # get uniquity container field
         ubiquity_container_key = 'com.apple.developer.ubiquity-container-identifiers'
         ubiquity_container_value = result[ubiquity_container_key]
-        UI.error "No existing ubiquity container field specified. Please specify an ubiquity container in the entitlements file." unless ubiquity_container_value
+        UI.error("No existing ubiquity container field specified. Please specify an ubiquity container in the entitlements file.") unless ubiquity_container_value
 
         # set iCloud container identifiers
         result[icloud_container_key] = params[:icloud_container_identifiers]
@@ -32,11 +32,11 @@ module Fastlane
         # save entitlements file
         result.save_plist(entitlements_file)
 
-        UI.message "Old iCloud Container Identifiers: #{icloud_container_value}"
-        UI.message "Old Ubiquity Container Identifiers: #{ubiquity_container_value}"
+        UI.message("Old iCloud Container Identifiers: #{icloud_container_value}")
+        UI.message("Old Ubiquity Container Identifiers: #{ubiquity_container_value}")
 
-        UI.success "New iCloud Container Identifiers set: #{result[icloud_container_key]}"
-        UI.success "New Ubiquity Container Identifiers set: #{result[ubiquity_container_key]}"
+        UI.success("New iCloud Container Identifiers set: #{result[icloud_container_key]}")
+        UI.success("New Ubiquity Container Identifiers set: #{result[ubiquity_container_key]}")
 
         Actions.lane_context[SharedValues::UPDATE_ICLOUD_CONTAINER_IDENTIFIERS] = result[icloud_container_key]
       end
@@ -55,7 +55,7 @@ module Fastlane
                                        env_name: "FL_UPDATE_ICLOUD_CONTAINER_IDENTIFIERS_ENTITLEMENTS_FILE_PATH",
                                        description: "The path to the entitlement file which contains the iCloud container identifiers",
                                        verify_block: proc do |value|
-                                         UI.user_error!("Please pass a path to an entitlements file. ") unless value.include? ".entitlements"
+                                         UI.user_error!("Please pass a path to an entitlements file. ") unless value.include?(".entitlements")
                                          UI.user_error!("Could not find entitlements file") if !File.exist?(value) and !Helper.is_test?
                                        end),
           FastlaneCore::ConfigItem.new(key: :icloud_container_identifiers,
@@ -63,7 +63,7 @@ module Fastlane
                                        description: "An Array of unique identifiers for the iCloud containers. Eg. ['iCloud.com.test.testapp']",
                                        is_string: false,
                                        verify_block: proc do |value|
-                                         UI.user_error!("The parameter icloud_container_identifiers needs to be an Array.") unless value.kind_of? Array
+                                         UI.user_error!("The parameter icloud_container_identifiers needs to be an Array.") unless value.kind_of?(Array)
                                        end)
         ]
       end

data/fastlane/lib/fastlane/actions/update_info_plist.rb

@@ -76,7 +76,7 @@ module Fastlane
                                        description: "Path to your Xcode project",
                                        optional: true,
                                        verify_block: proc do |value|
-                                         UI.user_error!("Please pass the path to the project, not the workspace") if value.end_with? ".xcworkspace"
+                                         UI.user_error!("Please pass the path to the project, not the workspace") if value.end_with?(".xcworkspace")
                                          UI.user_error!("Could not find Xcode project") unless File.exist?(value)
                                        end),
           FastlaneCore::ConfigItem.new(key: :plist_path,

data/fastlane/lib/fastlane/actions/update_project_provisioning.rb

@@ -138,7 +138,7 @@ module Fastlane
       end
 
       def self.is_supported?(platform)
-        [:ios, :mac].include? platform
+        [:ios, :mac].include?(platform)
       end
 
       def self.example_code

data/fastlane/lib/fastlane/actions/update_url_schemes.rb

@@ -64,7 +64,7 @@ module Fastlane
       end
 
       def self.is_supported?(platform)
-        [:ios, :mac].include? platform
+        [:ios, :mac].include?(platform)
       end
 
       def self.example_code

data/fastlane/lib/fastlane/actions/upload_symbols_to_crashlytics.rb

@@ -48,13 +48,13 @@ module Fastlane
               Actions.sh("unzip -qo #{current_path.shellescape}")
               work_q = Queue.new
               Dir["*.dSYM"].each do |sub|
-                work_q.push sub
+                work_q.push(sub)
               end
               execute_uploads(params, max_worker_threads, work_q)
             end
           end
         else
-          UI.error "Don't know how to handle '#{current_path}'"
+          UI.error("Don't know how to handle '#{current_path}'")
         end
       end
 
@@ -68,7 +68,7 @@ module Fastlane
                 upload_dsym(params, current_path)
               end
             rescue => ex
-              UI.error ex.to_s
+              UI.error(ex.to_s)
             end
           end
         end
@@ -87,7 +87,7 @@ module Fastlane
           UI.verbose("upload_dsym using command: #{command_to_execute}")
           Actions.sh(command_to_execute, log: false)
         rescue => ex
-          UI.error ex.to_s # it fails, however we don't want to fail everything just for this
+          UI.error(ex.to_s) # it fails, however we don't want to fail everything just for this
         end
       end
 

data/fastlane/lib/fastlane/actions/upload_symbols_to_sentry.rb

@@ -40,7 +40,7 @@ module Fastlane
           resource = RestClient::Resource.new(url, headers: { Authorization: "Bearer #{auth_token}" })
         end
 
-        UI.message "Will upload dSYM(s) to #{url}"
+        UI.message("Will upload dSYM(s) to #{url}")
 
         # Upload dsym(s)
         dsym_paths += [dsym_path]
@@ -53,13 +53,13 @@ module Fastlane
       end
 
       def self.upload_dsym(resource, dsym)
-        UI.message "Uploading... #{dsym}"
+        UI.message("Uploading... #{dsym}")
         resource.post(file: File.new(dsym, 'rb')) unless Helper.test?
-        UI.success 'dSYM successfully uploaded to Sentry!'
+        UI.success('dSYM successfully uploaded to Sentry!')
 
         dsym
       rescue
-        UI.user_error! 'Error while trying to upload dSYM to Sentry'
+        UI.user_error!('Error while trying to upload dSYM to Sentry')
       end
 
       #####################################################

data/fastlane/lib/fastlane/actions/verify_build.rb

@@ -46,10 +46,10 @@ module Fastlane
             type = part.split('=')[1].split(':')[0]
             values['provisioning_type'] = type.downcase =~ /distribution/i ? "distribution" : "development"
           end
-          if part.start_with? "TeamIdentifier"
+          if part.start_with?("TeamIdentifier")
             values['team_identifier'] = part.split('=')[1]
           end
-          if part.start_with? "Identifier"
+          if part.start_with?("Identifier")
             values['bundle_identifier'] = part.split('=')[1]
           end
         end
@@ -96,9 +96,9 @@ module Fastlane
           end
         end
 
-        puts ""
-        puts table
-        puts ""
+        puts("")
+        puts(table)
+        puts("")
       end
 
       def self.evaulate(params, values)
@@ -121,7 +121,7 @@ module Fastlane
           UI.user_error!("Mismatched bundle_identifier. Required: '#{params[:bundle_identifier]}'; Found: '#{values['bundle_identifier']}'") unless params[:bundle_identifier] == values['bundle_identifier']
         end
 
-        UI.success "Build is verified, have a 🍪."
+        UI.success("Build is verified, have a 🍪.")
       end
 
       #####################################################

data/fastlane/lib/fastlane/actions/verify_pod_keys.rb

@@ -15,7 +15,7 @@ module Fastlane
 
       def self.plugin_options
         require 'cocoapods-core'
-        podfile = Pod::Podfile.from_file "Podfile"
+        podfile = Pod::Podfile.from_file("Podfile")
         podfile.plugins["cocoapods-keys"]
       end
 

data/fastlane/lib/fastlane/actions/version_bump_podspec.rb

@@ -8,7 +8,7 @@ module Fastlane
       def self.run(params)
         podspec_path = params[:path]
 
-        UI.user_error!("Could not find podspec file at path #{podspec_path}") unless File.exist? podspec_path
+        UI.user_error!("Could not find podspec file at path #{podspec_path}") unless File.exist?(podspec_path)
 
         version_podspec_file = Helper::PodspecHelper.new(podspec_path)
 
@@ -57,7 +57,7 @@ module Fastlane
                                        description: "The type of this version bump. Available: patch, minor, major",
                                        default_value: "patch",
                                        verify_block: proc do |value|
-                                         UI.user_error!("Available values are 'patch', 'minor' and 'major'") unless ['patch', 'minor', 'major'].include? value
+                                         UI.user_error!("Available values are 'patch', 'minor' and 'major'") unless ['patch', 'minor', 'major'].include?(value)
                                        end),
           FastlaneCore::ConfigItem.new(key: :version_number,
                                        env_name: "FL_VERSION_BUMP_PODSPEC_VERSION_NUMBER",
@@ -81,7 +81,7 @@ module Fastlane
       end
 
       def self.is_supported?(platform)
-        [:ios, :mac].include? platform
+        [:ios, :mac].include?(platform)
       end
 
       def self.example_code

data/fastlane/lib/fastlane/actions/version_get_podspec.rb

@@ -4,7 +4,7 @@ module Fastlane
       def self.run(params)
         podspec_path = params[:path]
 
-        UI.user_error!("Could not find podspec file at path '#{podspec_path}'") unless File.exist? podspec_path
+        UI.user_error!("Could not find podspec file at path '#{podspec_path}'") unless File.exist?(podspec_path)
 
         version_podspec_file = Helper::PodspecHelper.new(podspec_path)
 
@@ -44,7 +44,7 @@ module Fastlane
       end
 
       def self.is_supported?(platform)
-        [:ios, :mac].include? platform
+        [:ios, :mac].include?(platform)
       end
 
       def self.example_code

data/fastlane/lib/fastlane/actions/xcode_select.rb

@@ -19,7 +19,7 @@ module Fastlane
     #
     class XcodeSelectAction < Action
       def self.run(params)
-        params = nil unless params.kind_of? Array
+        params = nil unless params.kind_of?(Array)
         xcode_path = (params || []).first
 
         # Verify that a param was passed in
@@ -46,7 +46,7 @@ module Fastlane
       end
 
       def self.is_supported?(platform)
-        [:ios, :mac].include? platform
+        [:ios, :mac].include?(platform)
       end
 
       def self.example_code

data/fastlane/lib/fastlane/actions/xcode_server_get_assets.rb

@@ -80,7 +80,7 @@ module Fastlane
             UI.important("Archive #{archive_path} already exists, not unzipping again...")
           else
             # unzip the archive
-            sh "unzip -q \"#{zipped_archive_path}\" -d \"#{archive_dir_path}\""
+            sh("unzip -q \"#{zipped_archive_path}\" -d \"#{archive_dir_path}\"")
           end
 
           # reload asset entries to also contain the xcarchive file
@@ -149,7 +149,7 @@ module Fastlane
             out_folder = File.join(dir, "out_#{rand(1_000_000)}")
             FileUtils.mkdir_p(out_folder)
 
-            action.sh "cd \"#{out_folder}\"; cat \"#{temp_file}\" | gzip -d | tar -x"
+            action.sh("cd \"#{out_folder}\"; cat \"#{temp_file}\" | gzip -d | tar -x")
 
             # then pull the real name from headers
             asset_filename = response.headers['Content-Disposition'].split(';')[1].split('=')[1].delete('"')
@@ -292,7 +292,7 @@ module Fastlane
       end
 
       def self.is_supported?(platform)
-        [:ios, :mac].include? platform
+        [:ios, :mac].include?(platform)
       end
 
       def self.example_code

data/fastlane/lib/fastlane/actions/xcov.rb

@@ -43,7 +43,7 @@ module Fastlane
       end
 
       def self.is_supported?(platform)
-        [:ios, :mac].include? platform
+        [:ios, :mac].include?(platform)
       end
 
       def self.example_code

data/fastlane/lib/fastlane/actions/xctool.rb

@@ -7,7 +7,7 @@ module Fastlane
           UI.user_error!("xctool not installed, please install using `brew install xctool`") if `which xctool`.length == 0
         end
 
-        params = [] if params.kind_of? FastlaneCore::Configuration
+        params = [] if params.kind_of?(FastlaneCore::Configuration)
 
         Actions.sh('xctool ' + params.join(' '))
       end

data/fastlane/lib/fastlane/actions/xcversion.rb

@@ -37,7 +37,7 @@ module Fastlane
       end
 
       def self.is_supported?(platform)
-        [:ios, :mac].include? platform
+        [:ios, :mac].include?(platform)
       end
 
       def self.example_code

data/fastlane/lib/fastlane/actions/zip.rb

@@ -2,7 +2,7 @@ module Fastlane
   module Actions
     class ZipAction < Action
       def self.run(params)
-        UI.message "Compressing #{params[:path]}..."
+        UI.message("Compressing #{params[:path]}...")
 
         params[:output_path] ||= params[:path]
 
@@ -19,10 +19,10 @@ module Fastlane
         Dir.chdir(File.expand_path("..", params[:path])) do # required to properly zip
           zip_options = params[:verbose] ? "r" : "rq"
 
-          Actions.sh "zip -#{zip_options} #{absolute_output_path.shellescape} #{File.basename(params[:path]).shellescape}"
+          Actions.sh("zip -#{zip_options} #{absolute_output_path.shellescape} #{File.basename(params[:path]).shellescape}")
         end
 
-        UI.success "Successfully generated zip file at path '#{File.expand_path(absolute_output_path)}'"
+        UI.success("Successfully generated zip file at path '#{File.expand_path(absolute_output_path)}'")
         return File.expand_path(absolute_output_path)
       end
 

data/fastlane/lib/fastlane/auto_complete.rb

@@ -9,38 +9,38 @@ module Fastlane
     def self.execute(args, options)
       shell = ENV['SHELL']
 
-      if shell.end_with? "fish"
+      if shell.end_with?("fish")
         fish_completions_dir = "~/.config/fish/completions"
 
         if UI.interactive?
-          confirm = UI.confirm "This will copy a fish script into #{fish_completions_dir} that provides the command tab completion. If the directory does not exist it will be created. Sound good?"
+          confirm = UI.confirm("This will copy a fish script into #{fish_completions_dir} that provides the command tab completion. If the directory does not exist it will be created. Sound good?")
           return unless confirm
         end
 
-        fish_completions_dir = File.expand_path fish_completions_dir
-        FileUtils.mkdir_p fish_completions_dir
+        fish_completions_dir = File.expand_path(fish_completions_dir)
+        FileUtils.mkdir_p(fish_completions_dir)
 
         completion_script_path = File.join(Fastlane::ROOT, 'lib', 'assets', 'completions', 'completion.fish')
         final_completion_script_path = File.join(fish_completions_dir, 'fastlane.fish')
 
-        FileUtils.cp completion_script_path, final_completion_script_path
+        FileUtils.cp(completion_script_path, final_completion_script_path)
 
-        UI.success "Copied! You can now use tab completion for lanes"
+        UI.success("Copied! You can now use tab completion for lanes")
       else
         fastlane_conf_dir = "~/.fastlane"
 
         if UI.interactive?
-          confirm = UI.confirm "This will copy a shell script into #{fastlane_conf_dir} that provides the command tab completion. Sound good?"
+          confirm = UI.confirm("This will copy a shell script into #{fastlane_conf_dir} that provides the command tab completion. Sound good?")
           return unless confirm
         end
 
         # create the ~/.fastlane directory
-        fastlane_conf_dir = File.expand_path fastlane_conf_dir
-        FileUtils.mkdir_p fastlane_conf_dir
+        fastlane_conf_dir = File.expand_path(fastlane_conf_dir)
+        FileUtils.mkdir_p(fastlane_conf_dir)
 
         # then copy all of the completions files into it from the gem
         completion_script_path = File.join(Fastlane::ROOT, 'lib', 'assets', 'completions')
-        FileUtils.cp_r completion_script_path, fastlane_conf_dir
+        FileUtils.cp_r(completion_script_path, fastlane_conf_dir)
 
         custom_commands = options.custom.to_s.split(',')
 
@@ -48,21 +48,21 @@ module Fastlane
           open("#{fastlane_conf_dir}/completions/completion.#{shell_name}", 'a') do |file|
             default_line_prefix = Helper.bundler? ? "bundle exec " : ""
 
-            file.puts self.get_auto_complete_line(shell_name, "#{default_line_prefix}fastlane")
+            file.puts(self.get_auto_complete_line(shell_name, "#{default_line_prefix}fastlane"))
 
             custom_commands.each do |command|
               auto_complete_line = self.get_auto_complete_line(shell_name, command)
 
               next if auto_complete_line.nil?
 
-              file.puts auto_complete_line
+              file.puts(auto_complete_line)
             end
           end
         end
 
-        UI.success "Copied! To use auto complete for fastlane, add the following line to your favorite rc file (e.g. ~/.bashrc)"
-        UI.important "  . ~/.fastlane/completions/completion.sh"
-        UI.success "Don't forget to source that file in your current shell! 🐚"
+        UI.success("Copied! To use auto complete for fastlane, add the following line to your favorite rc file (e.g. ~/.bashrc)")
+        UI.important("  . ~/.fastlane/completions/completion.sh")
+        UI.success("Don't forget to source that file in your current shell! 🐚")
       end
     end