fastlane 2.74.1 → 2.75.0.beta.20180109010003

data/fastlane_core/lib/fastlane_core/swag.rb

@@ -32,8 +32,8 @@ module FastlaneCore
       @break = true
       @thr.join
       # Process.kill("KILL", @sound_pid) if @sound_thr
-      STDOUT.print "\e[H\e[2J"
-      STDOUT.print "\e[?25l"
+      STDOUT.print("\e[H\e[2J")
+      STDOUT.print("\e[?25l")
     end
 
     def self.should_be_shown?
@@ -66,19 +66,19 @@ module FastlaneCore
       interrupted = false
       begin
         loop do
-          STDOUT.print "\e[H\e[2J"
-          STDOUT.print "\e[?25l"
-          FRAMES.each.with_index 1 do |frame, nxt|
-            STDOUT.print Zlib::Inflate.inflate frame
-            sleep 0.1
+          STDOUT.print("\e[H\e[2J")
+          STDOUT.print("\e[?25l")
+          FRAMES.each.with_index(1) do |frame, nxt|
+            STDOUT.print(Zlib::Inflate.inflate(frame))
+            sleep(0.1)
             break if interrupted
-            STDOUT.print "\e[H\e[2J" if FRAMES[nxt]
+            STDOUT.print("\e[H\e[2J") if FRAMES[nxt]
           end
           break if do_break
         end
         STDOUT.puts
       ensure
-        print "\e[?25h"
+        print("\e[?25h")
       end
     end
   end

data/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb

@@ -36,8 +36,8 @@ module Commander
     attr_accessor :collector
 
     def run!
-      require_program :version, :description
-      trap('INT') { abort program(:int_message) } if program(:int_message)
+      require_program(:version, :description)
+      trap('INT') { abort(program(:int_message)) } if program(:int_message)
       trap('INT') { program(:int_block).call } if program(:int_block)
       global_option('-h', '--help', 'Display help documentation') do
         args = @args - %w(-h --help)
@@ -45,11 +45,11 @@ module Commander
         return
       end
       global_option('-v', '--version', 'Display version information') do
-        say version
+        say(version)
         return
       end
       parse_global_options
-      remove_global_options options, @args
+      remove_global_options(options, @args)
 
       xcode_outdated = false
       begin
@@ -83,7 +83,7 @@ module Commander
           raise e
         else
           FastlaneCore::CrashReporter.report_crash(exception: e)
-          abort "#{e}. Use --help for more information"
+          abort("#{e}. Use --help for more information")
         end
       rescue Interrupt => e
         # We catch it so that the stack trace is hidden by default when using ctrl + c
@@ -91,7 +91,7 @@ module Commander
           raise e
         else
           action_completed(@program[:name], status: FastlaneCore::ActionCompletionStatus::INTERRUPTED, exception: e)
-          puts "\nCancelled... use --verbose to show the stack trace"
+          puts("\nCancelled... use --verbose to show the stack trace")
         end
       rescue \
         OptionParser::InvalidOption,
@@ -109,13 +109,13 @@ module Commander
             # This would be confusing, as the user probably wanted to use `pilot list`
             # or some other command. Because `-u` isn't available for the `pilot --help`
             # command it would show this very confusing error message otherwise
-            abort "Please ensure to use one of the available commands (#{self.commands.keys.join(', ')})".red
+            abort("Please ensure to use one of the available commands (#{self.commands.keys.join(', ')})".red)
           else
             # This would print something like
             #
             #   invalid option: -u
             #
-            abort e.to_s
+            abort(e.to_s)
           end
         end
       rescue FastlaneCore::Interface::FastlaneCommonException => e # these are exceptions that we dont count as crashes
@@ -144,16 +144,16 @@ module Commander
 
     def rescue_file_error(e)
       # We're also printing the new-lines, as otherwise the message is not very visible in-between the error and the stack trace
-      puts ""
+      puts("")
       FastlaneCore::UI.important("Error accessing file, this might be due to fastlane's directory handling")
       FastlaneCore::UI.important("Check out https://docs.fastlane.tools/advanced/#directory-behavior for more details")
-      puts ""
+      puts("")
       FastlaneCore::CrashReporter.report_crash(exception: e)
       raise e
     end
 
     def rescue_connection_failed_error(e)
-      if e.message.include? 'Connection reset by peer - SSL_connect'
+      if e.message.include?('Connection reset by peer - SSL_connect')
         handle_tls_error!(e)
       else
         FastlaneCore::CrashReporter.report_crash(exception: e)
@@ -196,45 +196,45 @@ module Commander
 
     def suggest_ruby_reinstall(e)
       ui = FastlaneCore::UI
-      ui.error "-----------------------------------------------------------------------"
-      ui.error e.to_s
-      ui.error ""
-      ui.error "SSL errors can be caused by various components on your local machine."
+      ui.error("-----------------------------------------------------------------------")
+      ui.error(e.to_s)
+      ui.error("")
+      ui.error("SSL errors can be caused by various components on your local machine.")
       if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.1')
-        ui.error "Apple has recently changed their servers to require TLS 1.2, which may"
-        ui.error "not be available to your system installed Ruby (#{RUBY_VERSION})"
+        ui.error("Apple has recently changed their servers to require TLS 1.2, which may")
+        ui.error("not be available to your system installed Ruby (#{RUBY_VERSION})")
       end
-      ui.error ""
-      ui.error "The best solution is to use the self-contained fastlane version."
-      ui.error "Which ships with a bundled OpenSSL,ruby and all gems - so you don't depend on system libraries"
-      ui.error " - Use Homebrew"
-      ui.error "    - update brew with `brew update`"
-      ui.error "    - install fastlane using:"
-      ui.error "      - `brew cask install fastlane`"
-      ui.error " - Use One-Click-Installer:"
-      ui.error "    - download fastlane at https://download.fastlane.tools"
-      ui.error "    - extract the archive and double click the `install`"
-      ui.error "-----------------------------------------------------------"
-      ui.error "for more details on ways to install fastlane please refer the documentation:"
-      ui.error "-----------------------------------------------------------"
-      ui.error "        🚀       https://docs.fastlane.tools          🚀   "
-      ui.error "-----------------------------------------------------------"
-      ui.error ""
-      ui.error "You can also install a new version of Ruby"
-      ui.error ""
-      ui.error "- Make sure OpenSSL is installed with Homebrew: `brew update && brew upgrade openssl`"
-      ui.error "- If you use system Ruby:"
-      ui.error "  - Run `brew update && brew install ruby`"
-      ui.error "- If you use rbenv with ruby-build:"
-      ui.error "  - Run `brew update && brew upgrade ruby-build && rbenv install 2.3.1`"
-      ui.error "  - Run `rbenv global 2.3.1` to make it the new global default Ruby version"
-      ui.error "- If you use rvm:"
-      ui.error "  - First run `rvm osx-ssl-certs update all`"
-      ui.error "  - Then run `rvm reinstall ruby-2.3.1 --with-openssl-dir=/usr/local`"
-      ui.error ""
-      ui.error "If that doesn't fix your issue, please google for the following error message:"
-      ui.error "  '#{e}'"
-      ui.error "-----------------------------------------------------------------------"
+      ui.error("")
+      ui.error("The best solution is to use the self-contained fastlane version.")
+      ui.error("Which ships with a bundled OpenSSL,ruby and all gems - so you don't depend on system libraries")
+      ui.error(" - Use Homebrew")
+      ui.error("    - update brew with `brew update`")
+      ui.error("    - install fastlane using:")
+      ui.error("      - `brew cask install fastlane`")
+      ui.error(" - Use One-Click-Installer:")
+      ui.error("    - download fastlane at https://download.fastlane.tools")
+      ui.error("    - extract the archive and double click the `install`")
+      ui.error("-----------------------------------------------------------")
+      ui.error("for more details on ways to install fastlane please refer the documentation:")
+      ui.error("-----------------------------------------------------------")
+      ui.error("        🚀       https://docs.fastlane.tools          🚀   ")
+      ui.error("-----------------------------------------------------------")
+      ui.error("")
+      ui.error("You can also install a new version of Ruby")
+      ui.error("")
+      ui.error("- Make sure OpenSSL is installed with Homebrew: `brew update && brew upgrade openssl`")
+      ui.error("- If you use system Ruby:")
+      ui.error("  - Run `brew update && brew install ruby`")
+      ui.error("- If you use rbenv with ruby-build:")
+      ui.error("  - Run `brew update && brew upgrade ruby-build && rbenv install 2.3.1`")
+      ui.error("  - Run `rbenv global 2.3.1` to make it the new global default Ruby version")
+      ui.error("- If you use rvm:")
+      ui.error("  - First run `rvm osx-ssl-certs update all`")
+      ui.error("  - Then run `rvm reinstall ruby-2.3.1 --with-openssl-dir=/usr/local`")
+      ui.error("")
+      ui.error("If that doesn't fix your issue, please google for the following error message:")
+      ui.error("  '#{e}'")
+      ui.error("-----------------------------------------------------------------------")
     end
 
     def handle_unknown_error!(e)
@@ -269,7 +269,7 @@ module Commander
       else
         # without stack trace
         action_completed(@program[:name], status: FastlaneCore::ActionCompletionStatus::USER_ERROR, exception: e)
-        abort "\n[!] #{message}".red
+        abort("\n[!] #{message}".red)
       end
     end
 

data/fastlane_core/lib/fastlane_core/ui/github_issue_inspector_reporter.rb

@@ -9,10 +9,10 @@ module Fastlane
 
     # Called just as the investigation has begun.
     def inspector_started_query(query, inspector)
-      puts ""
-      puts "Looking for related GitHub issues on #{inspector.repo_owner}/#{inspector.repo_name}..."
-      puts "Search query: #{query}" if FastlaneCore::Globals.verbose?
-      puts ""
+      puts("")
+      puts("Looking for related GitHub issues on #{inspector.repo_owner}/#{inspector.repo_name}...")
+      puts("Search query: #{query}") if FastlaneCore::Globals.verbose?
+      puts("")
     end
 
     # Called once the inspector has recieved a report with more than one issue.
@@ -21,8 +21,8 @@ module Fastlane
 
       if report.issues.count > NUMBER_OF_ISSUES_INLINE
         report.url.sub!('\'', '%27')
-        puts "and #{report.total_results - NUMBER_OF_ISSUES_INLINE} more at: #{report.url}"
-        puts ""
+        puts("and #{report.total_results - NUMBER_OF_ISSUES_INLINE} more at: #{report.url}")
+        puts("")
       end
 
       print_open_link_hint
@@ -30,16 +30,16 @@ module Fastlane
 
     # Called once the report has been recieved, but when there are no issues found.
     def inspector_recieved_empty_report(report, inspector)
-      puts "Found no similar issues. To create a new issue, please visit:"
-      puts "https://github.com/#{inspector.repo_owner}/#{inspector.repo_name}/issues/new"
-      puts "Run `fastlane env` to append the fastlane environment to your issue"
+      puts("Found no similar issues. To create a new issue, please visit:")
+      puts("https://github.com/#{inspector.repo_owner}/#{inspector.repo_name}/issues/new")
+      puts("Run `fastlane env` to append the fastlane environment to your issue")
     end
 
     # Called when there have been networking issues in creating the report.
     def inspector_could_not_create_report(error, query, inspector)
-      puts "Could not access the GitHub API, you may have better luck via the website."
-      puts "https://github.com/#{inspector.repo_owner}/#{inspector.repo_name}/search?q=#{query}&type=Issues&utf8=✓"
-      puts "Error: #{error.name}"
+      puts("Could not access the GitHub API, you may have better luck via the website.")
+      puts("https://github.com/#{inspector.repo_owner}/#{inspector.repo_name}/search?q=#{query}&type=Issues&utf8=✓")
+      puts("Error: #{error.name}")
     end
 
     private
@@ -48,15 +48,15 @@ module Fastlane
       resolved = issue.state == 'closed'
       status = (resolved ? issue.state.green : issue.state.red)
 
-      puts "➡️  #{issue.title.yellow}"
-      puts "    #{issue.html_url} [#{status}] #{issue.comments} 💬"
-      puts "    #{Time.parse(issue.updated_at).to_pretty}"
-      puts ""
+      puts("➡️  #{issue.title.yellow}")
+      puts("    #{issue.html_url} [#{status}] #{issue.comments} 💬")
+      puts("    #{Time.parse(issue.updated_at).to_pretty}")
+      puts("")
     end
 
     def print_open_link_hint(newline = false)
-      puts "" if newline
-      puts "🔗  You can ⌘ + double-click on links to open them directly in your browser." if FastlaneCore::Helper.mac?
+      puts("") if newline
+      puts("🔗  You can ⌘ + double-click on links to open them directly in your browser.") if FastlaneCore::Helper.mac?
     end
   end
 end

data/fastlane_core/lib/fastlane_core/ui/implementations/shell.rb

@@ -16,7 +16,7 @@ module FastlaneCore
       $stdout.sync = true
 
       if Helper.is_test? && !ENV.key?('DEBUG')
-        $stdout.puts "Logging disabled while running tests. Force them by setting the DEBUG environment variable"
+        $stdout.puts("Logging disabled while running tests. Force them by setting the DEBUG environment variable")
         @log ||= Logger.new(nil) # don't show any logs when running tests
       else
         @log ||= Logger.new($stdout)

data/fastlane_core/lib/fastlane_core/update_checker/changelog.rb

@@ -8,19 +8,19 @@ module FastlaneCore
 
         self.releases(gem_name).each_with_index do |release, index|
           next unless Gem::Version.new(release['tag_name']) > Gem::Version.new(current_version)
-          puts ""
-          puts release['name'].green
-          puts release['body']
+          puts("")
+          puts(release['name'].green)
+          puts(release['body'])
           did_show_changelog = true
 
           next unless index == 2
-          puts ""
-          puts "To see all new releases, open https://github.com/fastlane/#{gem_name}/releases".green
+          puts("")
+          puts("To see all new releases, open https://github.com/fastlane/#{gem_name}/releases".green)
           break
         end
 
-        puts ""
-        puts "Please update using `#{update_gem_command}`".green if did_show_changelog
+        puts("")
+        puts("Please update using `#{update_gem_command}`".green) if did_show_changelog
       rescue
         # Something went wrong, we don't care so much about this
       end

data/fastlane_core/lib/fastlane_core/update_checker/update_checker.rb

@@ -64,24 +64,24 @@ module FastlaneCore
     # appropriate message to the user
     def self.show_update_message(gem_name, current_version)
       available = server_results[gem_name]
-      puts ""
-      puts '#######################################################################'.green
+      puts("")
+      puts('#######################################################################'.green)
       if available
-        puts "# #{gem_name} #{available} is available. You are on #{current_version}.".green
+        puts("# #{gem_name} #{available} is available. You are on #{current_version}.".green)
       else
-        puts "# An update for #{gem_name} is available. You are on #{current_version}.".green
+        puts("# An update for #{gem_name} is available. You are on #{current_version}.".green)
       end
-      puts "# You should use the latest version.".green
-      puts "# Please update using `#{self.update_command(gem_name: gem_name)}`.".green
+      puts("# You should use the latest version.".green)
+      puts("# Please update using `#{self.update_command(gem_name: gem_name)}`.".green)
 
-      puts "# To see what's new, open https://github.com/fastlane/#{gem_name}/releases.".green if FastlaneCore::Env.truthy?("FASTLANE_HIDE_CHANGELOG")
+      puts("# To see what's new, open https://github.com/fastlane/#{gem_name}/releases.".green) if FastlaneCore::Env.truthy?("FASTLANE_HIDE_CHANGELOG")
 
       if !Helper.bundler? && !Helper.contained_fastlane? && Random.rand(5) == 1
         # We want to show this message from time to time, if the user doesn't use bundler, nor bundled fastlane
-        puts '#######################################################################'.green
-        puts "# Run `sudo gem cleanup` from time to time to speed up fastlane".green
+        puts('#######################################################################'.green)
+        puts("# Run `sudo gem cleanup` from time to time to speed up fastlane".green)
       end
-      puts '#######################################################################'.green
+      puts('#######################################################################'.green)
       Changelog.show_changes(gem_name, current_version, update_gem_command: UpdateChecker.update_command(gem_name: gem_name)) unless FastlaneCore::Env.truthy?("FASTLANE_HIDE_CHANGELOG")
 
       ensure_rubygems_source
@@ -107,7 +107,7 @@ module FastlaneCore
     def self.ensure_rubygems_source
       return if Helper.contained_fastlane?
       return if `gem sources`.include?("https://rubygems.org")
-      puts ""
+      puts("")
       UI.error("RubyGems is not listed as your Gem source")
       UI.error("You can run `gem sources` to see all your sources")
       UI.error("Please run the following command to fix this:")

data/frameit/lib/frameit/commands_generator.rb

@@ -30,7 +30,7 @@ module Frameit
 
       global_option('--verbose') { FastlaneCore::Globals.verbose = true }
 
-      default_command :run
+      default_command(:run)
 
       command :run do |c|
         c.syntax = 'fastlane frameit black'
@@ -98,7 +98,7 @@ module Frameit
         end
       end
 
-      alias_command :white, :silver
+      alias_command(:white, :silver)
 
       run!
     end

data/frameit/lib/frameit/config_parser.rb

@@ -16,8 +16,8 @@ module Frameit
       begin
         @data = JSON.parse(data)
       rescue => ex
-        UI.error ex.message
-        UI.user_error! "Invalid JSON file at path '#{@path}'. Make sure it's a valid JSON file"
+        UI.error(ex.message)
+        UI.user_error!("Invalid JSON file at path '#{@path}'. Make sure it's a valid JSON file")
       end
 
       self
@@ -26,7 +26,7 @@ module Frameit
     # Fetches the finished configuration for a given path. This will try to look for a specific value
     # and fallback to a default value if nothing was found
     def fetch_value(path)
-      specific = @data['data'].find { |a| path.include? a['filter'] }
+      specific = @data['data'].find { |a| path.include?(a['filter']) }
 
       default = @data['default']
 
@@ -41,19 +41,19 @@ module Frameit
     # Use absolute paths instead of relative
     def change_paths_to_absolutes!(values)
       values.each do |key, value|
-        if value.kind_of? Hash
+        if value.kind_of?(Hash)
           change_paths_to_absolutes!(value) # recursive call
-        elsif value.kind_of? Array
+        elsif value.kind_of?(Array)
           value.each do |current|
-            change_paths_to_absolutes!(current) if current.kind_of? Hash # recursive call
+            change_paths_to_absolutes!(current) if current.kind_of?(Hash) # recursive call
           end
         else
-          if ['font', 'background'].include? key
+          if ['font', 'background'].include?(key)
             # Change the paths to relative ones
             # `replace`: to change the content of the string, so it's actually stored
             if @path # where is the config file. We don't have a config file in tests
               containing_folder = File.expand_path('..', @path)
-              value.replace File.join(containing_folder, value)
+              value.replace(File.join(containing_folder, value))
             end
           end
         end
@@ -75,10 +75,10 @@ module Frameit
             value.each do |current|
               UI.user_error!("You must specify a font path") if current.fetch('font', '').length == 0
               UI.user_error!("Could not find font at path '#{File.expand_path(current.fetch('font'))}'") unless File.exist?(current.fetch('font'))
-              UI.user_error!("`supported` must be an array") unless current.fetch('supported', []).kind_of? Array
+              UI.user_error!("`supported` must be an array") unless current.fetch('supported', []).kind_of?(Array)
             end
           when 'background'
-            UI.user_error!("Could not find background image at path '#{File.expand_path(value)}'") unless File.exist? value
+            UI.user_error!("Could not find background image at path '#{File.expand_path(value)}'") unless File.exist?(value)
           when 'color'
             UI.user_error!("Invalid color '#{value}'. Must be valid Hex #123123") unless value.include?("#")
           when 'padding'
@@ -86,7 +86,7 @@ module Frameit
               UI.user_error!("padding must be type integer or pair of integers of format 'AxB' or a percentage of screen size")
             end
           when 'show_complete_frame', 'title_below_image'
-            UI.user_error! "'#{key}' must be a Boolean" unless [true, false].include?(value)
+            UI.user_error!("'#{key}' must be a Boolean") unless [true, false].include?(value)
           when 'font_scale_factor'
             UI.user_error!("font_scale_factor must be numeric") unless value.kind_of?(Numeric)
           end

data/frameit/lib/frameit/dependency_checker.rb

@@ -9,13 +9,13 @@ module Frameit
     end
 
     def self.check_image_magick
-      unless `which convert`.include? "convert"
-        UI.error '#############################################################'
-        UI.error "# You have to install the ImageMagick to use FrameIt"
-        UI.error "# Install it using 'brew update && brew install imagemagick'"
-        UI.error "# If you don't have homebrew: http://brew.sh"
-        UI.error '#############################################################'
-        UI.user_error! "Install ImageMagick and start frameit again!"
+      unless `which convert`.include?("convert")
+        UI.error('#############################################################')
+        UI.error("# You have to install the ImageMagick to use FrameIt")
+        UI.error("# Install it using 'brew update && brew install imagemagick'")
+        UI.error("# If you don't have homebrew: http://brew.sh")
+        UI.error('#############################################################')
+        UI.user_error!("Install ImageMagick and start frameit again!")
       end
     end
   end