fastlane 2.74.1 → 2.75.0.beta.20180109010003

data/match/lib/match/setup.rb

@@ -9,18 +9,18 @@ module Match
         template = File.read("#{Match::ROOT}/lib/assets/MatchfileTemplate")
       end
 
-      UI.important "Please create a new, private git repository"
-      UI.important "to store the certificates and profiles there"
+      UI.important("Please create a new, private git repository")
+      UI.important("to store the certificates and profiles there")
       url = UI.input("URL of the Git Repo: ")
 
       template.gsub!("[[GIT_URL]]", url)
       File.write(path, template)
-      UI.success "Successfully created '#{path}'. You can open the file using a code editor."
+      UI.success("Successfully created '#{path}'. You can open the file using a code editor.")
 
-      UI.important "You can now run `fastlane match development`, `fastlane match adhoc`, `fastlane match enterprise` and `fastlane match appstore`"
-      UI.message "On the first run for each environment it will create the provisioning profiles and"
-      UI.message "certificates for you. From then on, it will automatically import the existing profiles."
-      UI.message "For more information visit https://docs.fastlane.tools/actions/match/"
+      UI.important("You can now run `fastlane match development`, `fastlane match adhoc`, `fastlane match enterprise` and `fastlane match appstore`")
+      UI.message("On the first run for each environment it will create the provisioning profiles and")
+      UI.message("certificates for you. From then on, it will automatically import the existing profiles.")
+      UI.message("For more information visit https://docs.fastlane.tools/actions/match/")
     end
   end
 end

data/match/lib/match/table_printer.rb

@@ -13,9 +13,9 @@ module Match
         title: "Installed Certificate".green
       }
 
-      puts ""
-      puts Terminal::Table.new(params)
-      puts ""
+      puts("")
+      puts(Terminal::Table.new(params))
+      puts("")
     rescue => ex
       UI.error(ex)
     end
@@ -43,9 +43,9 @@ module Match
       params[:title] = "Installed Provisioning Profile".green
       params[:headings] = ['Parameter', 'Environment Variable', 'Value']
 
-      puts ""
-      puts Terminal::Table.new(params)
-      puts ""
+      puts("")
+      puts(Terminal::Table.new(params))
+      puts("")
     end
   end
 end

data/match/lib/match/utils.rb

@@ -10,7 +10,7 @@ module Match
 
     # Fill in an environment variable, ready to be used in _xcodebuild_
     def self.fill_environment(key, value)
-      UI.important "Setting environment variable '#{key}' to '#{value}'" if FastlaneCore::Globals.verbose?
+      UI.important("Setting environment variable '#{key}' to '#{value}'") if FastlaneCore::Globals.verbose?
       ENV[key] = value
     end
 
@@ -51,7 +51,7 @@ module Match
            'notAfter' => 'End Datetime'
        }
 
-      return out_array.map { |x| x.split(/=+/) if x.include? "=" }
+      return out_array.map { |x| x.split(/=+/) if x.include?("=") }
                       .compact
                       .map { |k, v| [openssl_keys_to_readable_keys.fetch(k, k), v] }
     rescue => ex

data/pem/lib/pem/commands_generator.rb

@@ -38,7 +38,7 @@ module PEM
         end
       end
 
-      default_command :renew
+      default_command(:renew)
 
       run!
     end

data/pem/lib/pem/manager.rb

@@ -18,13 +18,13 @@ module PEM
 
         if existing_certificate
           remaining_days = (existing_certificate.expires - Time.now) / 60 / 60 / 24
-          UI.message "Existing push notification profile for '#{existing_certificate.owner_name}' is valid for #{remaining_days.round} more days."
+          UI.message("Existing push notification profile for '#{existing_certificate.owner_name}' is valid for #{remaining_days.round} more days.")
           if remaining_days > PEM.config[:active_days_limit]
             if PEM.config[:force]
-              UI.success "You already have an existing push certificate, but a new one will be created since the --force option has been set."
+              UI.success("You already have an existing push certificate, but a new one will be created since the --force option has been set.")
             else
-              UI.success "You already have a push certificate, which is active for more than #{PEM.config[:active_days_limit]} more days. No need to create a new one"
-              UI.success "If you still want to create a new one, use the --force option when running PEM."
+              UI.success("You already have a push certificate, which is active for more than #{PEM.config[:active_days_limit]} more days. No need to create a new one")
+              UI.success("If you still want to create a new one, use the --force option when running PEM.")
               return false
             end
           end
@@ -34,23 +34,23 @@ module PEM
       end
 
       def login
-        UI.message "Starting login with user '#{PEM.config[:username]}'"
+        UI.message("Starting login with user '#{PEM.config[:username]}'")
         Spaceship.login(PEM.config[:username], nil)
         Spaceship.client.select_team
-        UI.message "Successfully logged in"
+        UI.message("Successfully logged in")
       end
 
       def create_certificate
-        UI.important "Creating a new push certificate for app '#{PEM.config[:app_identifier]}'."
+        UI.important("Creating a new push certificate for app '#{PEM.config[:app_identifier]}'.")
 
         csr, pkey = Spaceship.certificate.create_certificate_signing_request
 
         begin
           cert = certificate.create!(csr: csr, bundle_id: PEM.config[:app_identifier])
         rescue => ex
-          if ex.to_s.include? "You already have a current"
+          if ex.to_s.include?("You already have a current")
             # That's the most common failure probably
-            UI.message ex.to_s
+            UI.message(ex.to_s)
             UI.user_error!("You already have 2 active push profiles for this application/environment. You'll need to revoke an old certificate to make room for a new one")
           else
             raise ex

data/pem/lib/pem/module.rb

@@ -7,7 +7,7 @@ module PEM
   end
 
   TMP_FOLDER = "/tmp/PEM/"
-  FileUtils.mkdir_p TMP_FOLDER
+  FileUtils.mkdir_p(TMP_FOLDER)
 
   ENV['FASTLANE_TEAM_ID'] ||= ENV["PEM_TEAM_ID"]
   ENV['DELIVER_USER'] ||= ENV["PEM_USERNAME"]

data/pilot/lib/pilot/build_manager.rb

@@ -69,7 +69,7 @@ module Pilot
         app_test_info.test_info.description = options[:beta_app_description] if options[:beta_app_description]
         begin
           app_test_info.save_for_app!(app_id: build.app_id)
-          UI.success "Successfully set the beta_app_feedback_email and/or beta_app_description"
+          UI.success("Successfully set the beta_app_feedback_email and/or beta_app_description")
         rescue => ex
           UI.user_error!("Could not set beta_app_feedback_email and/or beta_app_description: #{ex}")
         end
@@ -78,7 +78,7 @@ module Pilot
       if should_update_build_information?(options)
         begin
           build.update_build_information!(whats_new: options[:changelog])
-          UI.success "Successfully set the changelog for build"
+          UI.success("Successfully set the changelog for build")
         rescue => ex
           UI.user_error!("Could not set changelog: #{ex}")
         end
@@ -102,11 +102,11 @@ module Pilot
       builds.sort! { |a, b| a.upload_date <=> b.upload_date }
       rows = builds.collect { |build| describe_build(build) }
 
-      puts Terminal::Table.new(
-        title: "#{app.name} Builds".green,
-        headings: ["Version #", "Build #", "Installs"],
-        rows: FastlaneCore::PrintTable.transform_output(rows)
-      )
+      puts(Terminal::Table.new(
+             title: "#{app.name} Builds".green,
+             headings: ["Version #", "Build #", "Installs"],
+             rows: FastlaneCore::PrintTable.transform_output(rows)
+      ))
     end
 
     def self.truncate_changelog(changelog)
@@ -115,7 +115,7 @@ module Pilot
         original_length = changelog.length
         bottom_message = "..."
         changelog = "#{changelog[0...max_changelog_length - bottom_message.length]}#{bottom_message}"
-        UI.important "Changelog has been truncated since it exceeds Apple's #{max_changelog_length} character limit. It currently contains #{original_length} characters."
+        UI.important("Changelog has been truncated since it exceeds Apple's #{max_changelog_length} character limit. It currently contains #{original_length} characters.")
       end
       return changelog
     end

data/pilot/lib/pilot/commands_generator.rb

@@ -161,7 +161,7 @@ module Pilot
         end
       end
 
-      default_command :help
+      default_command(:help)
 
       run!
     end

data/pilot/lib/pilot/manager.rb

@@ -69,7 +69,7 @@ module Pilot
       result ||= FastlaneCore::IpaFileAnalyser.fetch_app_platform(config[:ipa]) if config[:ipa]
       if required
         result ||= UI.input("Please enter the app's platform (appletvos, ios, osx): ")
-        UI.user_error!("App Platform must be ios, appletvos, or osx") unless ['ios', 'appletvos', 'osx'].include? result
+        UI.user_error!("App Platform must be ios, appletvos, or osx") unless ['ios', 'appletvos', 'osx'].include?(result)
         UI.verbose("App Platform (#{result})")
       end
       return result

data/pilot/lib/pilot/options.rb

@@ -29,7 +29,7 @@ module Pilot
                                      optional: true,
                                      default_value: 'ios',
                                      verify_block: proc do |value|
-                                       UI.user_error!("The platform can only be ios, appletvos, or osx") unless ['ios', 'appletvos', 'osx'].include? value
+                                       UI.user_error!("The platform can only be ios, appletvos, or osx") unless ['ios', 'appletvos', 'osx'].include?(value)
                                      end),
         FastlaneCore::ConfigItem.new(key: :ipa,
                                      short_option: "-i",
@@ -40,8 +40,8 @@ module Pilot
                                      default_value: Dir["*.ipa"].sort_by { |x| File.mtime(x) }.last,
                                      verify_block: proc do |value|
                                        value = File.expand_path(value)
-                                       UI.user_error!("Could not find ipa file at path '#{value}'") unless File.exist? value
-                                       UI.user_error!("'#{value}' doesn't seem to be an ipa file") unless value.end_with? ".ipa"
+                                       UI.user_error!("Could not find ipa file at path '#{value}'") unless File.exist?(value)
+                                       UI.user_error!("'#{value}' doesn't seem to be an ipa file") unless value.end_with?(".ipa")
                                      end),
         FastlaneCore::ConfigItem.new(key: :changelog,
                                      short_option: "-w",
@@ -105,7 +105,7 @@ module Pilot
                                      description: "The tester's email",
                                      optional: true,
                                      verify_block: proc do |value|
-                                       UI.user_error!("Please pass a valid email address") unless value.include? "@"
+                                       UI.user_error!("Please pass a valid email address") unless value.include?("@")
                                      end),
         FastlaneCore::ConfigItem.new(key: :testers_file_path,
                                      short_option: "-c",

data/pilot/lib/pilot/tester_manager.rb

@@ -182,12 +182,12 @@ module Pilot
 
     # Requires a block that accepts a tester and returns an array of tester column values
     def list(all_testers, title, headings)
-      rows = all_testers.map { |tester| yield tester }
-      puts Terminal::Table.new(
-        title: title.green,
-        headings: headings,
-        rows: FastlaneCore::PrintTable.transform_output(rows)
-      )
+      rows = all_testers.map { |tester| yield(tester) }
+      puts(Terminal::Table.new(
+             title: title.green,
+             headings: headings,
+             rows: FastlaneCore::PrintTable.transform_output(rows)
+      ))
     end
 
     # Print out all the details of a specific tester
@@ -209,10 +209,10 @@ module Pilot
         rows << ["Latest Install Date", tester.pretty_install_date]
       end
 
-      puts Terminal::Table.new(
-        title: tester.email.green,
-        rows: FastlaneCore::PrintTable.transform_output(rows)
-      )
+      puts(Terminal::Table.new(
+             title: tester.email.green,
+             rows: FastlaneCore::PrintTable.transform_output(rows)
+      ))
     end
   end
 end

data/precheck/lib/precheck/commands_generator.rb

@@ -48,12 +48,12 @@ module Precheck
         c.action do |args, options|
           containing = FastlaneCore::Helper.fastlane_enabled_folder_path
           path = File.join(containing, Precheck.precheckfile_name)
-          UI.user_error! "Precheckfile already exists" if File.exist?(path)
+          UI.user_error!("Precheckfile already exists") if File.exist?(path)
 
           is_swift_fastfile = args.include?("swift")
           if is_swift_fastfile
             path = File.join(containing, Precheck.precheckfile_name + ".swift")
-            UI.user_error! "Precheckfile.swift already exists" if File.exist?(path)
+            UI.user_error!("Precheckfile.swift already exists") if File.exist?(path)
           end
 
           if is_swift_fastfile
@@ -62,11 +62,11 @@ module Precheck
             template = File.read("#{Precheck::ROOT}/lib/assets/PrecheckfileTemplate")
           end
           File.write(path, template)
-          UI.success "Successfully created '#{path}'. Open the file using a code editor."
+          UI.success("Successfully created '#{path}'. Open the file using a code editor.")
         end
       end
 
-      default_command :check_metadata
+      default_command(:check_metadata)
 
       run!
     end

data/precheck/lib/precheck/rule.rb

@@ -159,13 +159,13 @@ module Precheck
   # URLRule rule_block
   class TextRule < Rule
     def handle_item?(item)
-      (item.kind_of? TextItemToCheck) ? true : false
+      item.kind_of?(TextItemToCheck) ? true : false
     end
   end
 
   class URLRule < Rule
     def handle_item?(item)
-      (item.kind_of? URLItemToCheck) ? true : false
+      item.kind_of?(URLItemToCheck) ? true : false
     end
   end
 end

data/precheck/lib/precheck/rule_processor.rb

@@ -62,7 +62,7 @@ module Precheck
 
         if rule_level == RULE_LEVELS[:skip]
           skipped_rules << rule
-          UI.message "Skipped: #{rule.class.friendly_name}-> #{rule.description}".yellow
+          UI.message("Skipped: #{rule.class.friendly_name}-> #{rule.description}".yellow)
           next
         end
 
@@ -98,12 +98,12 @@ module Precheck
         if rule_failed_at_least_once
           message = "😵  Failed: #{rule.class.friendly_name}-> #{rule.description}"
           if rule_level == RULE_LEVELS[:error]
-            UI.error message
+            UI.error(message)
           else
-            UI.important message
+            UI.important(message)
           end
         else
-          UI.message "✅  Passed: #{rule.class.friendly_name}"
+          UI.message("✅  Passed: #{rule.class.friendly_name}")
         end
       end
 
@@ -182,14 +182,14 @@ module Precheck
 
       should_include_iap = Precheck.config[:include_in_app_purchases]
       if should_include_iap
-        UI.message "Reading in-app purchases. If you have a lot, this might take a while"
-        UI.message "You can disable IAP checking by setting the `include_in_app_purchases` flag to `false`"
+        UI.message("Reading in-app purchases. If you have a lot, this might take a while")
+        UI.message("You can disable IAP checking by setting the `include_in_app_purchases` flag to `false`")
         in_app_purchases = app.in_app_purchases.all
         in_app_purchases ||= []
         in_app_purchases.each do |purchase|
           items += collect_iap_language_items(purchase_edit_versions: purchase.edit.versions)
         end
-        UI.message "Done reading in-app purchases"
+        UI.message("Done reading in-app purchases")
       end
 
       return items

data/precheck/lib/precheck/rules/abstract_text_match_rule.rb

@@ -59,7 +59,7 @@ module Precheck
         if matches.length > 0 && word_search_type == WORD_SEARCH_TYPES[:fail_on_inclusion]
           # we are supposed to fail if any of the words are found
           friendly_matches = matches.join(', ')
-          UI.verbose "😭  #{self.class.name.split('::').last ||= self.class.name} found words \"#{friendly_matches}\""
+          UI.verbose("😭  #{self.class.name.split('::').last ||= self.class.name} found words \"#{friendly_matches}\"")
 
           return RuleReturn.new(validation_state: VALIDATION_STATES[:failed], failure_data: "found: #{friendly_matches}")
         elsif matches.length < lowercased_words_to_look_for.length && word_search_type == WORD_SEARCH_TYPES[:fail_on_exclusion]
@@ -68,7 +68,7 @@ module Precheck
           search_data_set.subtract(matches)
 
           missing_words = search_data_set.to_a.join(', ')
-          UI.verbose "😭  #{self.class.name.split('::').last ||= self.class.name} didn't find words \"#{missing_words}\""
+          UI.verbose("😭  #{self.class.name.split('::').last ||= self.class.name} didn't find words \"#{missing_words}\"")
 
           return RuleReturn.new(validation_state: VALIDATION_STATES[:failed], failure_data: "missing: #{missing_words}")
         else

data/precheck/lib/precheck/rules/curse_words_rule.rb

@@ -41,9 +41,9 @@ module Precheck
 
         if found_words.length > 0
           friendly_found_words = found_words.join(', ')
-          UI.verbose "#{self.class.name.split('::').last ||= self.class.name} found potential curse words 😬"
-          UI.verbose "Keep in mind, these words might be ok given the context they are used in"
-          UI.verbose "Matched: \"#{friendly_found_words}\""
+          UI.verbose("#{self.class.name.split('::').last ||= self.class.name} found potential curse words 😬")
+          UI.verbose("Keep in mind, these words might be ok given the context they are used in")
+          UI.verbose("Matched: \"#{friendly_found_words}\"")
           return RuleReturn.new(validation_state: VALIDATION_STATES[:failed], failure_data: "found: #{friendly_found_words}")
         else
           return RuleReturn.new(validation_state: VALIDATION_STATES[:passed])

data/precheck/lib/precheck/rules/unreachable_urls_rule.rb

@@ -30,12 +30,12 @@ module Precheck
           uri = Addressable::URI.parse(url)
           uri.fragment = nil
           request = Faraday.new(URI.encode(uri.to_s)) do |connection|
-            connection.use FaradayMiddleware::FollowRedirects
-            connection.adapter :net_http
+            connection.use(FaradayMiddleware::FollowRedirects)
+            connection.adapter(:net_http)
           end
           return RuleReturn.new(validation_state: Precheck::VALIDATION_STATES[:failed], failure_data: url) unless request.head.status == 200
         rescue
-          UI.verbose "URL #{url} not reachable 😵"
+          UI.verbose("URL #{url} not reachable 😵")
           # I can only return :fail here, but I also want to return #{url}
           return RuleReturn.new(validation_state: VALIDATION_STATES[:failed], failure_data: "unreachable: #{url}")
         end

data/precheck/lib/precheck/runner.rb

@@ -19,14 +19,14 @@ module Precheck
                                              title: "Summary for precheck #{Fastlane::VERSION}")
 
       unless Spaceship::Tunes.client
-        UI.message "Starting login with user '#{Precheck.config[:username]}'"
+        UI.message("Starting login with user '#{Precheck.config[:username]}'")
         Spaceship::Tunes.login(Precheck.config[:username])
         Spaceship::Tunes.select_team
 
-        UI.message "Successfully logged in"
+        UI.message("Successfully logged in")
       end
 
-      UI.message "Checking app for precheck rule violations"
+      UI.message("Checking app for precheck rule violations")
 
       ensure_app_exists!
 
@@ -38,7 +38,7 @@ module Precheck
 
       if processor_result.has_errors_or_warnings?
         summary_table = build_potential_problems_table(processor_result: processor_result)
-        puts summary_table
+        puts(summary_table)
       end
 
       if processor_result.should_trigger_user_error?
@@ -47,11 +47,11 @@ module Precheck
       end
 
       if processor_result.has_errors_or_warnings?
-        UI.important "precheck 👮‍♀️ 👮  found one or more potential metadata problems, but this won't prevent fastlane from completing 👍".yellow
+        UI.important("precheck 👮‍♀️ 👮  found one or more potential metadata problems, but this won't prevent fastlane from completing 👍".yellow)
       end
 
       if !processor_result.has_errors_or_warnings? && !processor_result.items_not_checked?
-        UI.message "precheck 👮‍♀️ 👮  finished without detecting any potential problems 🛫".green
+        UI.message("precheck 👮‍♀️ 👮  finished without detecting any potential problems 🛫".green)
       end
 
       return true
@@ -59,7 +59,7 @@ module Precheck
 
     def print_items_not_checked(processor_result: nil)
       names = processor_result.items_not_checked.map(&:friendly_name)
-      UI.message "😶  Metadata fields not checked by any rule: #{names.join(', ')}".yellow if names.length > 0
+      UI.message("😶  Metadata fields not checked by any rule: #{names.join(', ')}".yellow) if names.length > 0
     end
 
     def build_potential_problems_table(processor_result: nil)