decidim-core 0.31.2 → 0.32.1

data/lib/decidim/participatory_space/has_members.rb

@@ -0,0 +1,61 @@
+# frozen_string_literal: true
+
+require "active_support/concern"
+
+module Decidim
+  module ParticipatorySpace
+    # A concern with the features needed when you want a model to be able to create
+    # members
+    module HasMembers
+      extend ActiveSupport::Concern
+      include Decidim::UserRoleChecker
+
+      included do
+        has_many :members,
+                 class_name: "Decidim::ParticipatorySpace::Member",
+                 as: :participatory_space,
+                 dependent: :destroy
+        has_many :users,
+                 through: :members,
+                 class_name: "Decidim::User",
+                 foreign_key: "member_to_id"
+
+        def self.visible_for(user)
+          if user
+            return all if user.admin?
+
+            where(
+              id: public_spaces +
+                  private_spaces
+                  .joins(:members)
+                  .where(decidim_members: { decidim_user_id: user.id })
+            )
+          else
+            public_spaces
+          end
+        end
+
+        def members_public_page?
+          has_members && members.published.any?
+        end
+
+        def can_participate?(user)
+          return false unless published?
+          return true if open?
+          return true if user_has_any_role?(user, self)
+          return false unless user
+
+          members.exists?(decidim_user_id: user.id)
+        end
+
+        def self.public_spaces
+          where(access_mode: [:open, :transparent]).published
+        end
+
+        def self.private_spaces
+          where(access_mode: [:restricted, :transparent]).published
+        end
+      end
+    end
+  end
+end

data/lib/decidim/participatory_space_manifest.rb

@@ -43,10 +43,6 @@ module Decidim
     # probably have the form of `Decidim::<MySpace>::Permissions`.
     attribute :permissions_class_name, String, default: "Decidim::DefaultPermissions"
 
-    # The cell to use as dropdown in the breadcrumb element associated to the space.
-    # If this value is omitted or blank, no breadcrumb is displayed
-    attribute :breadcrumb_cell, String
-
     # The cell path to use to render the card of a resource.
     attribute :card, String
 

data/lib/decidim/participatory_space_resourceable.rb

@@ -102,7 +102,16 @@ module Decidim
       # - is published
       # - is not private
       def visible?
-        published? && !try(:private_space?)
+        published? && access_mode_visible?
+      end
+
+      # Checks if the ParticipatorySpace has an access_mode attribute
+      # If it does not have it, then returns true
+      # If it has it, then checks if this access_mode should be visible (open or transparent)
+      def access_mode_visible?
+        return true unless respond_to?(:access_mode)
+
+        try(:open?) || try(:transparent?)
       end
 
       # Defines a way to get the user roles for the current participatory space.

data/lib/decidim/participatory_space_user.rb

@@ -11,7 +11,7 @@ module Decidim
     included do
       validate :user_and_space_same_organization
 
-      belongs_to :user, foreign_key: "decidim_user_id", class_name: "Decidim::User", optional: true
+      belongs_to :user, foreign_key: "decidim_user_id", class_name: "Decidim::User"
 
       ransacker :name do
         Arel.sql(%{("decidim_users"."name")::text})

data/lib/decidim/routes/locale_redirects.rb

@@ -0,0 +1,47 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Routes
+    module LocaleRedirects
+      def locale_scope_options
+        {
+          defaults: { locale: Decidim.default_locale },
+          constraints: { locale: Regexp.union(I18n.available_locales.map(&:to_s)) }
+        }
+      end
+
+      def locale_redirector(path, preserve_query_string: true)
+        lambda do |params, request|
+          locale_redirect(params, request, path, preserve_query_string:)
+        end
+      end
+
+      def locale_redirect(params, request, path, preserve_query_string: true)
+        locale = Decidim::LocaleRouterDetector.new(request, params).locale
+        destination = append_locale(path, locale)
+        destination = append_query_string(destination, request) if preserve_query_string
+
+        destination
+      end
+
+      private
+
+      def append_locale(path, locale)
+        return path if path == "/404"
+        return path if path.start_with?("/#{locale}/") || path == "/#{locale}"
+
+        path = "/#{path}" unless path.start_with?("/")
+
+        "/#{locale}#{path}"
+      end
+
+      def append_query_string(path, request)
+        query_string = request.query_string.to_s
+        query_params = query_string.gsub(/(?:\A|&)locale=[^&]*(?=&|\z)/, "")
+        query_params = query_params.gsub(/\A&|&\z/, "").gsub(/&&+/, "&")
+
+        query_params.empty? ? path : "#{path}?#{query_params}"
+      end
+    end
+  end
+end

data/lib/decidim/routes.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Routes
+    autoload :LocaleRedirects, "decidim/routes/locale_redirects"
+  end
+end

data/lib/decidim/search_resource_fields_mapper.rb

@@ -11,7 +11,7 @@ module Decidim
     # - Array each element should be a text field symbol, all values will be concatenated.
     # - Symbol when mapping is direct.
     #
-    # @param declared_fields: A Hash with the mappings between a SearchableResource attributes and
+    # @param declared_fields [Hash] - A Hash with the mappings between a SearchableResource attributes and
     #    any given model. Mapped fields are:
     # - scope_id: The field where the scope is set in the model, if any.
     # - participatory_space: The field where the ParticipatorySpace is set in the model.
@@ -24,14 +24,13 @@ module Decidim
     # A: :title,
     # D: [:description, :address],
     # datetime: :start_time}
-    #
     def initialize(declared_fields)
       @declared_fields = declared_fields.with_indifferent_access
       @conditions = { create: true, update: true }
     end
 
-    # @param action: currently supports :create, :update
-    # @param condition: a boolean or a Proc that will receive the Searchable and will return a boolean.
+    # @param action [Symbol] currently supports :create, :update
+    # @param condition [TrueClass, FalseClass] a boolean or a Proc that will receive the Searchable and will return a boolean.
     def set_index_condition(action, condition)
       @conditions[action] = condition
     end

data/lib/decidim/searchable.rb

@@ -101,7 +101,7 @@ module Decidim
 
       # Public: after_update callback to update index information of the model.
       #
-      def try_update_index_for_search_resource
+      def try_update_index_for_search_resource(current_depth = 0)
         return unless self.class.searchable_resource?(self)
 
         org = self.class.search_resource_fields_mapper.retrieve_organization(self)
@@ -117,6 +117,11 @@ module Decidim
             searchables_in_org.find_each do |sr|
               next if sr.blank?
 
+              unless sr.locale.in?(org.available_locales)
+                sr.destroy
+                next
+              end
+
               sr.update(contents_to_searchable_resource_attributes(fields, sr.locale))
             end
           end
@@ -124,13 +129,13 @@ module Decidim
           searchables_in_org.destroy_all
         end
 
-        find_and_update_descendants
+        find_and_update_descendants(current_depth)
       end
 
       private
 
-      def find_and_update_descendants
-        Decidim::FindAndUpdateDescendantsJob.perform_later(self)
+      def find_and_update_descendants(current_depth = 0)
+        Decidim::FindAndUpdateDescendantsJob.perform_later(self, current_depth)
       end
 
       def contents_to_searchable_resource_attributes(fields, locale)

data/lib/decidim/seeds.rb

@@ -7,6 +7,19 @@ require "decidim/faker/localized"
 module Decidim
   # Base class to be inherited from the different modules' seeds classes
   class Seeds
+    SEEDS_CONFIG = {
+      comments_count: { slow: 6, fast: 2 },
+      comments_nested_probability: { slow: 0.5, fast: 0.2 },
+      comments_vote_skip_probability: { slow: 0.5, fast: 0.7 },
+      comments_votes_count: { slow: 12, fast: 3 },
+      surveys_responses_count: { slow: 200, fast: 20 },
+      surveys_response_options_count: { slow: 3, fast: 2 },
+      surveys_matrix_rows_count: { slow: 3, fast: 2 },
+      initiatives_votes_count: { slow: 50, fast: 10 },
+      accountability_statuses_count: { slow: 5, fast: 3 },
+      accountability_taxonomies_count: { slow: 2, fast: 1 }
+    }.freeze
+
     protected
 
     def slow_seeds?
@@ -17,6 +30,10 @@ module Decidim
       slow_seeds? ? rand(3..5) : 1
     end
 
+    def config_value(key)
+      slow_seeds? ? SEEDS_CONFIG[key][:slow] : SEEDS_CONFIG[key][:fast]
+    end
+
     def organization
       @organization ||= Decidim::Organization.first
     end

data/lib/decidim/shakapacker/runner.rb

@@ -7,15 +7,15 @@ module Decidim
         base.alias_method :original_initialize, :initialize
         base.send :private, :original_initialize
 
-        base.define_method :initialize do |argv|
-          decidim_initialize(argv)
-          original_initialize(argv)
+        base.define_method :initialize do |argv, build_config = nil, bundler_override = nil|
+          decidim_initialize(argv, build_config, bundler_override)
+          original_initialize(argv, build_config, bundler_override)
         end
       end
 
       private
 
-      def decidim_initialize(_argv)
+      def decidim_initialize(_argv, _build_config = nil, _bundler_override = nil)
         # Write runtime configuration for Tailwind
         # This method is called here because in Decidim CSS compilation is done via Webpack.
         # If CSS is decoupled from JS in the future, this call should be removed.

data/lib/decidim/shakapacker/shakapacker.yml

@@ -21,8 +21,12 @@ default: &default
   # Reload manifest.json on all requests so we reload latest compiled packs
   cache_manifest: false
 
-  # Select loader to use, available options are 'babel' (default), 'swc' or 'esbuild'
-  webpack_loader: 'esbuild'
+  # Select JavaScript transpiler to use
+  # Available options: 'swc' (default, 20x faster), 'babel', 'esbuild', or 'none'
+  # Use 'none' when providing a completely custom webpack configuration
+  # Note: When using rspack, swc is used automatically regardless of this setting
+  javascript_transpiler: 'esbuild'
+  assets_bundler: "webpack"
 
   # Set to true to enable check for matching versions of shakapacker gem and NPM package - will raise an error if there is a mismatch or wildcard versioning is used
   ensure_consistent_versioning: true
@@ -35,15 +39,36 @@ default: &default
   # https://webpack.js.org/guides/build-performance/#avoid-production-specific-tooling
   useContentHash: false
 
+  # Utilizing webpack-subresource-integrity plugin, will generate integrity hashes for all entries in manifest.json
+  # https://github.com/waysact/webpack-subresource-integrity/tree/main/webpack-subresource-integrity
+  integrity:
+    enabled: false
+    # Which cryptographic function(s) to use, for generating the integrity hash(es). Default sha-384. Other possible values sha256, sha512
+    hash_functions: [ "sha384" ]
+    # Default "anonymous". Other possible value "use-credentials"
+    # https://developer.mozilla.org/en-US/docs/Web/Security/Subresource_Integrity#cross-origin_resource_sharing_and_subresource_integrity
+    cross_origin: "anonymous"
+
+  # HTTP 103 Early Hints support for faster asset loading
+  # Sends Link headers to browsers so they can preload assets while Rails is rendering
+  # See docs/early_hints_new_api.md for setup instructions and requirements
+  # https://api.rubyonrails.org/classes/ActionDispatch/Request.html#method-i-send_early_hints
+  early_hints:
+    enabled: false
+    # css: "preload" # 'preload' | 'prefetch' | 'none' - default: 'preload'
+    # js: "preload" # 'preload' | 'prefetch' | 'none' - default: 'preload'
+    # debug: false # Output early hints info as HTML comments for troubleshooting
+
 development:
   <<: *default
   compile: true
   compiler_strategy: mtime
   # Compile test packs to decidim decidim-packs folder
 
+  useContentHash: false
+
   # Reference: https://webpack.js.org/configuration/dev-server/
   dev_server:
-    https: false
     host: localhost
     # Notice that we use a different port (to prevent blocking the default one) as
     # there will be at least two webpack servers running

data/lib/decidim/taxonomizable.rb

@@ -51,7 +51,7 @@ module Decidim
           Arel::Nodes::Intersect.new(memo, query)
         end
 
-        @klass.from(Arel::Nodes::As.new(subquery, Arel.sql(@klass.arel_table.name)))
+        from(Arel::Nodes::As.new(subquery, Arel.sql(arel_table.name)))
       }
 
       private

data/lib/decidim/translatable_attributes.rb

@@ -96,8 +96,7 @@ module Decidim
         given_organization ||= try(:organization)
         organization_locale = given_organization.try(:default_locale)
 
-        attribute[I18n.locale.to_s].presence ||
-          machine_translation_value(attribute, given_organization, override_machine_translation_settings) ||
+        translated_value(attribute, given_organization, override_machine_translation_settings) ||
           attribute[organization_locale].presence ||
           attribute[attribute.keys.first].presence ||
           ""
@@ -112,7 +111,7 @@ module Decidim
         return unless organization
         return unless organization.enable_machine_translations?
 
-        attribute.dig("machine_translations", I18n.locale.to_s).presence if must_render_translation?(organization, override_machine_translation_settings)
+        attribute.dig("machine_translations", I18n.locale.to_s)&.gsub("<p></p>", "").presence if must_render_translation?(organization, override_machine_translation_settings)
       end
 
       def must_render_translation?(organization, override_machine_translation_settings = nil)
@@ -131,5 +130,12 @@ module Decidim
     def attachment?(value)
       value.is_a?(String) && value.include?(ActiveStorage.routes_prefix)
     end
+
+    private
+
+    def translated_value(attribute, given_organization, override_machine_translation_settings = nil)
+      attribute[I18n.locale.to_s]&.gsub("<p></p>", "").presence ||
+        machine_translation_value(attribute, given_organization, override_machine_translation_settings)
+    end
   end
 end

data/lib/decidim/view_model.rb

@@ -35,6 +35,10 @@ module Decidim
       end
     end
 
+    def current_locale
+      I18n.locale
+    end
+
     # Rails cells is delegating those methods to some internal view layer which messes up with shakapacker asset loading strategy
     # generating 2 or more queues for the javascript to be loading, resulting in the fact that no js / style pack appended or
     # prepended is added to main view rendering queue.
@@ -79,7 +83,7 @@ module Decidim
     end
 
     def perform_caching?
-      cache_hash.present?
+      super && cache_hash.present?
     end
 
     def cache_hash

data/lib/devise/models/decidim_newsletterable.rb

@@ -13,7 +13,7 @@ module Devise
       def newsletter_opt_in_notify
         unless newsletter_opt_in_valid?
           set_newsletter_token!
-          Decidim::NewslettersOptInJob.perform_later(self, newsletter_token)
+          Decidim::NewslettersOptInMailer.notify(self, newsletter_token).deliver_later
         end
       end
 

data/lib/tasks/decidim_mailers_tasks.rake

@@ -4,20 +4,42 @@ namespace :decidim do
   namespace :mailers do
     desc "Sends the notification digest email with the daily report"
     task notifications_digest_daily: :environment do
-      notifications_digest(:daily)
+      time = Time.now.utc
+      target_users = Decidim::User.where(notifications_sending_frequency: :daily)
+
+      target_users.find_in_batches do |batch|
+        notification_users =
+          Decidim::Notification
+          .daily(time)
+          .where(decidim_user_id: batch.pluck(:id))
+          .select(:decidim_user_id)
+          .distinct
+          .pluck(:decidim_user_id)
+
+        notification_users.each do |user_id|
+          Decidim::EmailNotificationsDigestGeneratorJob.perform_later(user_id, :daily, time:)
+        end
+      end
     end
 
     desc "Sends the notification digest email with the weekly report"
     task notifications_digest_weekly: :environment do
-      notifications_digest(:weekly)
-    end
-  end
+      time = Time.now.utc
+      target_users = Decidim::User.where(notifications_sending_frequency: :weekly)
+
+      target_users.find_in_batches do |batch|
+        notification_users =
+          Decidim::Notification
+          .weekly(time)
+          .where(decidim_user_id: batch.pluck(:id))
+          .select(:decidim_user_id)
+          .distinct
+          .pluck(:decidim_user_id)
 
-  def notifications_digest(frequency)
-    target_users = Decidim::User.where(notifications_sending_frequency: frequency)
-    time = Time.now.utc
-    target_users.find_each do |user|
-      Decidim::EmailNotificationsDigestGeneratorJob.perform_later(user.id, frequency, time:)
+        notification_users.each do |user_id|
+          Decidim::EmailNotificationsDigestGeneratorJob.perform_later(user_id, :weekly, time:)
+        end
+      end
     end
   end
 end

data/lib/tasks/decidim_procfile.rake

@@ -30,7 +30,7 @@ if ! gem list foreman -i --silent; then
   gem install foreman
 fi
 
-exec foreman start -f Procfile.dev "$@")
+exec foreman start -f Procfile.dev "$@"), force: true
 
       actions :chmod, "bin/dev", 0o755
     end

data/lib/tasks/decidim_tasks.rake

@@ -34,7 +34,6 @@ namespace :decidim do
       decidim_pages
       decidim_participatory_processes
       decidim_proposals
-      decidim_sortitions
       decidim_surveys
       decidim_system
       decidim_templates

data/lib/tasks/decidim_taxonomies.rake

@@ -106,7 +106,7 @@ namespace :decidim do
     end
 
     def planner(organization)
-      models = ENV.fetch("IMPORTS", "ParticipatoryProcessType AssemblyType Scope Area Category").split.map do |model_name|
+      models = ENV.fetch("IMPORTS", "Scope Area Category").split.map do |model_name|
         "Decidim::Maintenance::ImportModels::#{model_name}".constantize
       end
       Decidim::Maintenance::TaxonomyPlan.new(organization, models)

data/lib/tasks/upgrade/decidim_active_storage_migration_tasks.rake

@@ -57,7 +57,6 @@ namespace :decidim do
           "Decidim::Category" => %w(description),
           "Decidim::Blogs::Post" => %w(body),
           "Decidim::Pages::Page" => %w(body),
-          "Decidim::Sortitions::Sortition" => %w(additional_info witnesses cancel_reason),
           "Decidim::Debates::Debate" => %w(description instructions information_updates conclusions),
           "Decidim::Budgets::Budget" => %w(description),
           "Decidim::Budgets::Project" => %w(description),

data/lib/tasks/upgrade/decidim_encryption.rake

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+
+namespace :decidim do
+  namespace :upgrade do
+    desc "Upgrade the encryption environment"
+    task encryption: :environment do
+      # Authorization is using the RecordEncryptor which automatically decrypts or encrypts before using.
+      # A simple save will retrigger the encryption using SHA256
+      Decidim::Authorization.find_each(&:save)
+    end
+  end
+end

data/lib/tasks/upgrade/decidim_migrate_wysiwyg_content.rake

@@ -39,7 +39,6 @@ namespace :decidim do
       Decidim::Upgrade::WysiwygMigrator.register_model("Decidim::Meetings::Meeting", [:description, :registration_terms, :registration_email_custom_content, :closing_report])
       Decidim::Upgrade::WysiwygMigrator.register_model("Decidim::Pages::Page", [:body])
       Decidim::Upgrade::WysiwygMigrator.register_model("Decidim::Proposals::Proposal", [:body, :answer, :cost_report, :execution_period])
-      Decidim::Upgrade::WysiwygMigrator.register_model("Decidim::Sortitions::Sortition", [:witnesses, :additional_info, :cancel_reason])
     end
 
     desc "Updates the content entered through the WYSIWYG editors"

data/lib/tasks/upgrade/decidim_remove_deleted_users_left_data_tasks.rake

@@ -8,7 +8,7 @@ namespace :decidim do
       Decidim::User.where.not(deleted_at: nil).find_each do |deleted_user|
         Decidim::Follow.where(followable: deleted_user).find_each(&:destroy)
         Decidim::Follow.where(user: deleted_user).find_each(&:destroy)
-        Decidim::ParticipatorySpacePrivateUser.where(user: deleted_user).find_each(&:destroy)
+        Decidim::ParticipatorySpace::Member.where(user: deleted_user).find_each(&:destroy)
         Decidim::Gamification::BadgeScore.where(user: deleted_user).find_each(&:destroy)
         Decidim::UserModeration.where(user: deleted_user).find_each(&:destroy)
         Decidim::Like.where(author: deleted_user).find_each(&:destroy)

data/lib/tasks/upgrade/{fix_deleted_private_follows.rake → fix_deleted_members_follows.rake}

@@ -2,14 +2,14 @@
 
 namespace :decidim do
   namespace :upgrade do
-    desc "Delete follows of private users deleted from a private space"
-    task fix_deleted_private_follows: :environment do
+    desc "Delete follows of members deleted from a restricted space"
+    task fix_deleted_members_follows: :environment do
       Decidim::Organization.all.each do |organization|
-        spaces = organization.participatory_spaces.collect { |space| space if space.respond_to?(:private_space?) && space.private_space? }.compact_blank
+        spaces = organization.participatory_spaces.collect { |space| space if space.respond_to?(:restricted?) && space.restricted? }.compact_blank
 
         next if spaces.blank?
 
-        spaces = spaces.map { |space| space.respond_to?(:is_transparent?) ? (space unless space.is_transparent?) : space }.compact_blank
+        spaces = spaces.map { |space| space.respond_to?(:transparent?) ? (space unless space.transparent?) : space }.compact_blank
 
         next if spaces.blank?
 
@@ -17,7 +17,7 @@ namespace :decidim do
           next unless user.following_follows.count.positive?
 
           spaces.each do |space|
-            Decidim::Admin::DestroyPrivateUsersFollowsJob.perform_later(user, space)
+            Decidim::Admin::ParticipatorySpace::DestroyMembersFollowsJob.perform_later(user, space)
           end
         end
       end

data/lib/tasks/upgrade/migrations.rake

@@ -24,7 +24,6 @@ namespace :decidim do
         "pages" => "Pages",
         "participatory_processes" => "ParticipatoryProcesses",
         "proposals" => "Proposals",
-        "sortitions" => "Sortitions",
         "surveys" => "Surveys",
         "system" => "System",
         "templates" => "Templates",

data/lib/tasks/upgrade/user_groups_migration.rake

@@ -80,7 +80,6 @@ namespace :decidim do
       task transfer_user_groups_authorships: :environment do
         coauthorable_models = %w(
           Decidim::Proposals::Proposal
-          Decidim::Proposals::CollaborativeDraft
         )
         authorable_models = %w(
           Decidim::Like