decidim-core 0.31.2 → 0.32.1

data/lib/decidim/core/test/shared_examples/participatory_space_members_shared_examples.rb

@@ -0,0 +1,121 @@
+# frozen_string_literal: true
+
+shared_examples "participatory space members" do
+  let(:blocks_manifests) { [] }
+  let(:organization) { create(:organization) }
+  let(:user) { create(:user, organization: participatory_space.organization) }
+  let(:unpublished_user) { create(:user, organization: participatory_space.organization) }
+
+  before do
+    switch_to_host(organization.host)
+  end
+
+  context "when there are no members and directly accessing from URL" do
+    it_behaves_like "a 404 page" do
+      let(:target_path) { members_path }
+    end
+  end
+
+  context "when there are no members and accessing from the space homepage" do
+    context "and the main data content block is disabled" do
+      it "the menu nav is not shown" do
+        visit participatory_space_homepage_path
+
+        expect(page).to have_no_css(".participatory-space__nav-container")
+      end
+    end
+
+    context "and the main data content block is enabled" do
+      let(:blocks_manifests) { ["main_data"] }
+
+      it "the menu link is not shown" do
+        visit participatory_space_homepage_path
+
+        expect(page).to have_no_content("Members")
+      end
+    end
+  end
+
+  context "when the participatory space does not exist" do
+    it_behaves_like "a 404 page" do
+      let(:target_path) { unexisting_participatory_space_members_path }
+    end
+  end
+
+  context "when there are some members and all are unpublished" do
+    before do
+      create(:member, user:, participatory_space:, published: false)
+    end
+
+    context "and directly accessing from URL" do
+      it_behaves_like "a 404 page" do
+        let(:target_path) { members_path }
+      end
+    end
+
+    context "and accessing from the homepage" do
+      context "and the main data content block is disabled" do
+        it "the menu nav is not shown" do
+          visit participatory_space_homepage_path
+
+          expect(page).to have_no_css(".participatory-space__nav-container")
+        end
+      end
+
+      context "and the main data content block is enabled" do
+        let(:blocks_manifests) { ["main_data"] }
+
+        it "the menu link is not shown" do
+          visit participatory_space_homepage_path
+
+          expect(page).to have_no_content("Members")
+        end
+      end
+    end
+  end
+
+  context "when there are some published members" do
+    let!(:member) { create(:member, user:, participatory_space:, published: true) }
+    let!(:unpublished_member) { create(:member, user: unpublished_user, participatory_space:, published: false) }
+
+    before do
+      visit members_path
+    end
+
+    context "and accessing from the space homepage" do
+      context "and the main data content block is disabled" do
+        it "the menu nav is not shown" do
+          visit participatory_space_homepage_path
+
+          expect(page).to have_no_css(".participatory-space__nav-container")
+        end
+      end
+
+      context "and the main data content block is enabled" do
+        let(:blocks_manifests) { ["main_data"] }
+
+        it "the menu link is shown" do
+          visit participatory_space_homepage_path
+
+          within ".participatory-space__nav-container" do
+            expect(page).to have_content("Members")
+            click_on "Members"
+          end
+
+          expect(page).to have_current_path members_path
+        end
+      end
+
+      it "lists all the members" do
+        within ".layout-main__section" do
+          expect(page).to have_css(".profile__user", count: 1)
+          expect(page).to have_no_content(Decidim::ParticipatorySpace::MemberPresenter.new(unpublished_member).name)
+        end
+
+        click_on(member.name)
+
+        expect(page).to have_content("Profile")
+      end
+    end
+  end
+end

data/lib/decidim/core/test/shared_examples/resource_liked_event_examples.rb

@@ -30,7 +30,7 @@ shared_examples_for "resource liked event" do
 
   describe "email_subject" do
     it "is generated correctly" do
-      expect(subject.email_subject).to eq("#{author_presenter.nickname} has performed a new like")
+      expect(subject.email_subject).to eq("#{author_presenter.name} has performed a new like")
     end
   end
 
@@ -38,7 +38,7 @@ shared_examples_for "resource liked event" do
     let(:resource_title) { decidim_sanitize_translated(resource.title) }
     it "is generated correctly" do
       expect(subject.email_intro)
-        .to eq("#{author.name} #{author_presenter.nickname}, who you are following, " \
+        .to eq("#{author.name}, who you are following, " \
                "has just liked \"#{resource_title}\" and we think it may be interesting to you. Check it out and contribute:")
     end
   end
@@ -51,7 +51,7 @@ shared_examples_for "resource liked event" do
         .to include("The <a href=\"#{resource_path}\">#{resource_title}</a> #{resource_type} has been liked by ")
 
       expect(subject.notification_title)
-        .to include("<a href=\"/profiles/#{author.nickname}\">#{author.name} #{author_presenter.nickname}</a>.")
+        .to include("<a href=\"/en/profiles/#{author.nickname}\">#{author.name}</a>.")
     end
   end
 

data/lib/decidim/core/test/shared_examples/resource_locator_presenter_examples.rb

@@ -34,13 +34,13 @@ shared_examples "generates routes without query strings on slug" do
     describe "#show" do
       subject { described_class.new(participatory_space).show }
 
-      it { is_expected.to eq("/admin/#{admin_route_fragment}") }
+      it { is_expected.to eq("/#{admin_route_fragment}") }
     end
 
     describe "#edit" do
       subject { described_class.new(participatory_space).edit }
 
-      it { is_expected.to eq("/admin/#{admin_route_fragment}/edit") }
+      it { is_expected.to eq("/#{admin_route_fragment}/edit") }
     end
   end
 
@@ -80,19 +80,19 @@ shared_examples "generates routes without query strings on slug" do
     describe "#admin_index" do
       subject { described_class.new([resource, nested_resource]).admin_index }
 
-      it { is_expected.to eq("/admin/#{admin_route_fragment}/components/1/manage/dummy_resources/1/nested_dummy_resources") }
+      it { is_expected.to eq("/#{admin_route_fragment}/components/1/manage/dummy_resources/1/nested_dummy_resources") }
     end
 
     describe "#show" do
       subject { described_class.new([resource, nested_resource]).show }
 
-      it { is_expected.to eq("/admin/#{admin_route_fragment}/components/1/manage/dummy_resources/1/nested_dummy_resources/1") }
+      it { is_expected.to eq("/#{admin_route_fragment}/components/1/manage/dummy_resources/1/nested_dummy_resources/1") }
     end
 
     describe "#edit" do
       subject { described_class.new([resource, nested_resource]).edit }
 
-      it { is_expected.to eq("/admin/#{admin_route_fragment}/components/1/manage/dummy_resources/1/nested_dummy_resources/1/edit") }
+      it { is_expected.to eq("/#{admin_route_fragment}/components/1/manage/dummy_resources/1/nested_dummy_resources/1/edit") }
     end
   end
 
@@ -122,13 +122,13 @@ shared_examples "generates routes without query strings on slug" do
     describe "#show" do
       subject { described_class.new(participatory_space).show }
 
-      it { is_expected.to eq("/admin/#{admin_route_fragment}") }
+      it { is_expected.to eq("/#{admin_route_fragment}") }
     end
 
     describe "#edit" do
       subject { described_class.new(participatory_space).edit }
 
-      it { is_expected.to eq("/admin/#{admin_route_fragment}/edit") }
+      it { is_expected.to eq("/#{admin_route_fragment}/edit") }
     end
   end
 end

data/lib/decidim/core/test/shared_examples/searchable_participatory_space_examples.rb

@@ -57,10 +57,10 @@ shared_examples "global search of participatory spaces" do
       end
     end
 
-    context "when participatory_spaces ARE private" do
+    context "when participatory_spaces ARE restricted" do
       it "does NOT indexes a SearchableResource after ParticipatorySpace update" do
-        if participatory_space.respond_to?(:private_space?)
-          participatory_space.update(published_at: Time.current, private_space: true)
+        if participatory_space.respond_to?(:access_mode?)
+          participatory_space.update(published_at: Time.current, access_mode: :restricted)
           organization.available_locales.each do |locale|
             searchables = Decidim::SearchableResource.where(resource_type: participatory_space.class.name, resource_id: participatory_space.id, locale:)
             expect(searchables).to be_empty

data/lib/decidim/core/test/shared_examples/searchable_results_examples.rb

@@ -83,9 +83,9 @@ shared_examples "searchable results" do
         it_behaves_like "no searches found"
       end
 
-      context "when participatory space is private" do
+      context "when participatory space is restricted" do
         before do
-          perform_enqueued_jobs { participatory_space.update!(private_space: true) }
+          perform_enqueued_jobs { participatory_space.update!(access_mode: :restricted) }
         end
 
         it_behaves_like "no searches found"

data/lib/decidim/core/test/shared_examples/simple_event.rb

@@ -4,6 +4,7 @@ require "spec_helper"
 
 shared_context "when a simple event" do
   include Decidim::SanitizeHelper
+
   subject { event_instance }
 
   let(:event_instance) do

data/lib/decidim/core/test/shared_examples/translated_event_examples.rb

@@ -75,7 +75,7 @@ shared_examples_for "a translated event" do
         end
 
         it "does not offer an alternate translation" do
-          expect(subject.safe_resource_translated_text).to eq(en_version)
+          expect(subject.safe_resource_translated_text).to eq(untranslated_content)
         end
       end
     end
@@ -123,7 +123,7 @@ shared_examples_for "a translated event" do
         end
 
         it "does not offer an alternate translation" do
-          expect(subject.safe_resource_translated_text).to eq(en_version)
+          expect(subject.safe_resource_translated_text).to eq(untranslated_content)
         end
       end
     end

data/lib/decidim/core/test/shared_examples/versions_controller_examples.rb

@@ -31,7 +31,7 @@ end
 shared_examples "versions controller" do
   let(:base_params) do
     if resource.is_a?(Decidim::Participable)
-      { :"#{resource.model_name.singular_route_key}_slug" => resource.slug }
+      { :"#{resource.model_name.singular_route_key}_slug" => resource.slug, :locale => I18n.locale }
     else
       { :"#{resource.model_name.singular_route_key}_id" => resource.id }
     end

data/lib/decidim/core/test.rb

@@ -53,7 +53,7 @@ require "decidim/core/test/shared_examples/amendable/amendment_promoted_event_ex
 require "decidim/core/test/shared_examples/uncommentable_component_examples"
 require "decidim/core/test/shared_examples/searchable_resources_shared_context"
 require "decidim/core/test/shared_examples/searchable_participatory_space_examples"
-require "decidim/core/test/shared_examples/has_private_users"
+require "decidim/core/test/shared_examples/has_members"
 require "decidim/core/test/shared_examples/with_likeable_permissions_examples"
 require "decidim/core/test/shared_examples/system_like_resource_examples"
 require "decidim/core/test/shared_examples/rich_text_editor_examples"
@@ -79,3 +79,4 @@ require "decidim/core/test/shared_examples/statistics_cell_examples"
 require "decidim/core/test/shared_examples/resource_locator_presenter_examples"
 require "decidim/core/test/shared_examples/etiquette_validator_examples"
 require "decidim/core/test/shared_examples/oauth_application_examples"
+require "decidim/core/test/shared_examples/participant_details_examples"

data/lib/decidim/core/version.rb

@@ -4,7 +4,7 @@ module Decidim
   # This holds the decidim-core version.
   module Core
     def self.version
-      "0.31.2"
+      "0.32.1"
     end
   end
 end