decidim-core 0.31.2 → 0.32.1

data/app/packs/src/decidim/editor/test/helpers.js

@@ -76,16 +76,14 @@ Object.assign(Range.prototype, {
 
 export const sleep = async (time) => new Promise((resolve) => setTimeout(resolve, time));
 
-export const updateContent = async (editable, content) => {
-  // ProseMirror listens has a mutation observer which listens to the changes on
-  // the contenteditable element. This forces us to manually change the
-  // `innerHTML` of the element to cause a change event to be triggered for the
-  // editor.
-  editable.innerHTML = content;
-
-  // We need to wait for the mutation observer to complete its logic. It has a
-  // timeout of 20 milliseconds by default which is the minimum amount we need
-  // to wait.
+export const updateContent = async (editable, content, editor) => {
+  if (editor) {
+    // Allows the proper use of TipTap's setContent method
+    editor.commands.setContent(content);
+  } else {
+    // Fallback for cases where editor is not available
+    editable.innerHTML = content;
+  }
   await sleep(50);
 };
 

data/app/packs/src/decidim/editor/test/toolbar/full.test.js

@@ -53,6 +53,12 @@ describe("full toolbar", () => {
     });
 
     describe("videoEmbed", () => {
+
+      const normalizeHTML = (html) => {
+        return html.replace(/\s*data-mention-suggestion-char="[^"]*"/g, "").
+          replace(/<p><br class="ProseMirror-trailingBreak"><\/p>/g, "");
+      };
+
       it("creates a new video embed with the provided details at the end of the selection", async () => {
         await setContent("Hello, world!");
         prosemirror.focus();
@@ -69,7 +75,7 @@ describe("full toolbar", () => {
         // handled
         await sleep(0);
 
-        expect(prosemirror.innerHTML).toMatchHtml(
+        expect(normalizeHTML(prosemirror.innerHTML)).toMatchHtml(
           `
             <p>Hello, world!</p>
             <div class="editor-content-videoEmbed ProseMirror-selectednode" data-video-embed="https://www.youtube.com/watch?v=f6JMgJAQ2tc" draggable="true">
@@ -112,7 +118,7 @@ describe("full toolbar", () => {
         // handled
         await sleep(0);
 
-        expect(prosemirror.innerHTML).toMatchHtml(
+        expect(normalizeHTML(prosemirror.innerHTML)).toMatchHtml(
           `
             <p>Hello, world!</p>
             <div class="editor-content-videoEmbed ProseMirror-selectednode" data-video-embed="https://www.youtube.com/watch?v=zhMMW0TENNA" draggable="true">
@@ -148,6 +154,11 @@ describe("full toolbar", () => {
         window.Decidim.currentDialogs[dialog] = dialogEl.dialog;
       }
 
+      const normalizeHTML = (html) => {
+        return html.replace(/\s*data-mention-suggestion-char="[^"]*"/g, "").
+          replace(/<p><br class="ProseMirror-trailingBreak"><\/p>/g, "");
+      };
+
       beforeEach(() => {
         const csrf = document.createElement("meta");
         csrf.setAttribute("name", "csrf-token")
@@ -174,7 +185,7 @@ describe("full toolbar", () => {
 
         await sleep(0);
 
-        expect(prosemirror.innerHTML).toMatchHtml(
+        expect(normalizeHTML(prosemirror.innerHTML)).toMatchHtml(
           `
             <p>Hello, world!</p>
             <div data-image-resizer="" class="ProseMirror-selectednode" draggable="true">
@@ -218,7 +229,7 @@ describe("full toolbar", () => {
 
         await sleep(0);
 
-        expect(prosemirror.innerHTML).toMatchHtml(
+        expect(normalizeHTML(prosemirror.innerHTML)).toMatchHtml(
           `
             <p>Hello, world!</p>
             <div data-image-resizer="" class="ProseMirror-selectednode" draggable="true">

data/app/packs/src/decidim/editor/test/toolbar/shared/behaves_like_basic_block.js

@@ -5,13 +5,17 @@ import contextHelpers from "src/decidim/editor/test/toolbar/shared/context";
 export default (ctx) => {
   const { getControl, setContent } = contextHelpers(ctx);
 
+  const normalizeHTML = (html) => {
+    return html.replace(/<p><br class="ProseMirror-trailingBreak"><\/p>$/g, "").trim();
+  };
+
   describe("codeBlock", () => {
     it("creates a new code block", async () => {
       await setContent("Hello, world!");
       selectContent(ctx.prosemirror);
       getControl("codeBlock").click();
 
-      expect(ctx.prosemirror.innerHTML).toEqual("<pre><code>Hello, world!</code></pre>");
+      expect(normalizeHTML(ctx.prosemirror.innerHTML)).toEqual("<pre><code>Hello, world!</code></pre>");
     });
 
     it("makes existing code block content as normal text", async () => {
@@ -20,7 +24,7 @@ export default (ctx) => {
       selectContent(ctx.prosemirror, "pre code");
       getControl("codeBlock").click();
 
-      expect(ctx.prosemirror.innerHTML).toEqual("<p>Hello, world!</p>");
+      expect(normalizeHTML(ctx.prosemirror.innerHTML)).toEqual("<p>Hello, world!</p>");
     });
   });
 
@@ -30,7 +34,7 @@ export default (ctx) => {
       selectContent(ctx.prosemirror);
       getControl("blockquote").click();
 
-      expect(ctx.prosemirror.innerHTML).toEqual("<blockquote><p>Hello, world!</p></blockquote>");
+      expect(normalizeHTML(ctx.prosemirror.innerHTML)).toEqual("<blockquote><p>Hello, world!</p></blockquote>");
     });
 
     it("makes existing blockquote content as normal text", async () => {
@@ -39,7 +43,7 @@ export default (ctx) => {
       selectContent(ctx.prosemirror, "blockquote p");
       getControl("blockquote").click();
 
-      expect(ctx.prosemirror.innerHTML).toEqual("<p>Hello, world!</p>");
+      expect(normalizeHTML(ctx.prosemirror.innerHTML)).toEqual("<p>Hello, world!</p>");
     });
   });
 };

data/app/packs/src/decidim/editor/test/toolbar/shared/behaves_like_basic_formatting.js

@@ -3,6 +3,10 @@ import contextHelpers from "src/decidim/editor/test/toolbar/shared/context";
 export default (ctx) => {
   const { getControl, setContent } = contextHelpers(ctx);
 
+  const normalizeHTML = (html) => {
+    return html.replace(/<p><br class="ProseMirror-trailingBreak"><\/p>$/g, "").trim();
+  };
+
   describe("hardBreak", () => {
     it("creates a new line break at the cursor position", async () => {
       await setContent("Hello, world!");
@@ -11,7 +15,7 @@ export default (ctx) => {
 
       // Note that the "tailingBreak" is only ProseMirror's internal element
       // to place the cursor at the correct location.
-      expect(ctx.prosemirror.innerHTML).toEqual('<p>Hello, world!<br><br class="ProseMirror-trailingBreak"></p>');
+      expect(normalizeHTML(ctx.prosemirror.innerHTML)).toEqual('<p>Hello, world!<br><br class="ProseMirror-trailingBreak"></p>');
     });
   });
 };

data/app/packs/src/decidim/editor/test/toolbar/shared/behaves_like_basic_indent.js

@@ -5,6 +5,10 @@ import contextHelpers from "src/decidim/editor/test/toolbar/shared/context";
 export default (ctx) => {
   const { getControl, setContent } = contextHelpers(ctx);
 
+  const normalizeHTML = (html) => {
+    return html.replace(/<p><br class="ProseMirror-trailingBreak"><\/p>$/g, "").trim();
+  };
+
   describe("indent:indent", () => {
     it("indents the existing content", async () => {
       await setContent("Hello, world!");
@@ -13,7 +17,7 @@ export default (ctx) => {
       ctrl.click();
       ctrl.click();
 
-      expect(ctx.prosemirror.innerHTML).toEqual('<p class="editor-indent-2">Hello, world!</p>');
+      expect(normalizeHTML(ctx.prosemirror.innerHTML)).toEqual('<p class="editor-indent-2">Hello, world!</p>');
     });
 
     it("indents a list item correctly", async () => {
@@ -21,7 +25,7 @@ export default (ctx) => {
       selectContent(ctx.prosemirror, "ul li:nth-child(2) p");
       getControl("indent:indent").click();
 
-      expect(ctx.prosemirror.innerHTML).toEqual(
+      expect(normalizeHTML(ctx.prosemirror.innerHTML)).toEqual(
         "<ul><li><p>First item</p><ul><li><p>Second item</p></li></ul></li></ul>"
       );
     });
@@ -35,7 +39,7 @@ export default (ctx) => {
       ctrl.click();
       ctrl.click();
 
-      expect(ctx.prosemirror.innerHTML).toEqual("<p>Hello, world!</p>");
+      expect(normalizeHTML(ctx.prosemirror.innerHTML)).toEqual("<p>Hello, world!</p>");
     });
 
     it("outdents a list item correctly", async () => {
@@ -43,7 +47,7 @@ export default (ctx) => {
       selectContent(ctx.prosemirror, "ul li ul li p");
       getControl("indent:outdent").click();
 
-      expect(ctx.prosemirror.innerHTML).toEqual(
+      expect(normalizeHTML(ctx.prosemirror.innerHTML)).toEqual(
         "<ul><li><p>First item</p></li><li><p>Second item</p></li></ul>"
       );
     });
@@ -53,7 +57,7 @@ export default (ctx) => {
       selectContent(ctx.prosemirror, "ul li:nth-child(2) p");
       getControl("indent:outdent").click();
 
-      expect(ctx.prosemirror.innerHTML).toEqual(
+      expect(normalizeHTML(ctx.prosemirror.innerHTML)).toEqual(
         "<ul><li><p>First item</p></li><li><p>Second item</p></li></ul>"
       );
     });

data/app/packs/src/decidim/editor/test/toolbar/shared/behaves_like_basic_link.js

@@ -5,6 +5,10 @@ import contextHelpers from "src/decidim/editor/test/toolbar/shared/context";
 export default (ctx) => {
   const { getControl, setContent } = contextHelpers(ctx);
 
+  const normalizeHTML = (html) => {
+    return html.replace(/<p><br class="ProseMirror-trailingBreak"><\/p>$/g, "").trim();
+  };
+
   describe("link", () => {
     it("creates a link for the selected text", async () => {
       await setContent("Hello, world!");
@@ -25,7 +29,7 @@ export default (ctx) => {
       // handled
       await sleep(0);
 
-      expect(ctx.prosemirror.innerHTML).toEqual(
+      expect(normalizeHTML(ctx.prosemirror.innerHTML)).toEqual(
         '<p>Hello, <a href="https://decidim.org" target="_blank">world</a>!</p>'
       );
     });

data/app/packs/src/decidim/editor/test/toolbar/shared/behaves_like_basic_list.js

@@ -5,13 +5,17 @@ import contextHelpers from "src/decidim/editor/test/toolbar/shared/context";
 export default (ctx) => {
   const { getControl, setContent } = contextHelpers(ctx);
 
+  const normalizeHTML = (html) => {
+    return html.replace(/<p><br class="ProseMirror-trailingBreak"><\/p>$/g, "").trim();
+  };
+
   describe("orderedList", () => {
     it("creates a new ordered list", async () => {
       await setContent("Hello, world!");
       ctx.prosemirror.focus();
       getControl("orderedList").click();
 
-      expect(ctx.prosemirror.innerHTML).toEqual("<ol><li><p>Hello, world!</p></li></ol>");
+      expect(normalizeHTML(ctx.prosemirror.innerHTML)).toEqual("<ol><li><p>Hello, world!</p></li></ol>");
     });
 
     it("makes existing ordered list as normal text", async () => {
@@ -21,7 +25,7 @@ export default (ctx) => {
       selectContent(ctx.prosemirror, "ol li p");
       getControl("orderedList").click();
 
-      expect(ctx.prosemirror.innerHTML).toEqual("<p>Hello, world!</p>");
+      expect(normalizeHTML(ctx.prosemirror.innerHTML)).toEqual("<p>Hello, world!</p>");
     });
   });
 
@@ -31,7 +35,7 @@ export default (ctx) => {
       ctx.prosemirror.focus();
       getControl("bulletList").click();
 
-      expect(ctx.prosemirror.innerHTML).toEqual("<ul><li><p>Hello, world!</p></li></ul>");
+      expect(normalizeHTML(ctx.prosemirror.innerHTML)).toEqual("<ul><li><p>Hello, world!</p></li></ul>");
     });
 
     it("makes existing bullet list as normal text", async () => {
@@ -41,7 +45,7 @@ export default (ctx) => {
       selectContent(ctx.prosemirror, "ul li p");
       getControl("bulletList").click();
 
-      expect(ctx.prosemirror.innerHTML).toEqual("<p>Hello, world!</p>");
+      expect(normalizeHTML(ctx.prosemirror.innerHTML)).toEqual("<p>Hello, world!</p>");
     });
   });
 };

data/app/packs/src/decidim/editor/test/toolbar/shared/behaves_like_basic_styling.js

@@ -5,13 +5,17 @@ import contextHelpers from "src/decidim/editor/test/toolbar/shared/context";
 export default (ctx) => {
   const { getControl, setContent } = contextHelpers(ctx);
 
+  const normalizeHTML = (html) => {
+    return html.replace(/<p><br class="ProseMirror-trailingBreak"><\/p>$/g, "").trim();
+  };
+
   describe("bold", () => {
     it("makes text bold", async () => {
       await setContent("Hello, world!");
       selectContent(ctx.prosemirror);
       getControl("bold").click();
 
-      expect(ctx.prosemirror.innerHTML).toEqual("<p><strong>Hello, world!</strong></p>");
+      expect(normalizeHTML(ctx.prosemirror.innerHTML)).toEqual("<p><strong>Hello, world!</strong></p>");
     });
 
     it("makes already bolded text normal", async () => {
@@ -20,7 +24,7 @@ export default (ctx) => {
       selectContent(ctx.prosemirror, "p strong");
       getControl("bold").click();
 
-      expect(ctx.prosemirror.innerHTML).toEqual("<p>Hello, world!</p>");
+      expect(normalizeHTML(ctx.prosemirror.innerHTML)).toEqual("<p>Hello, world!</p>");
     });
   });
 
@@ -30,7 +34,7 @@ export default (ctx) => {
       selectContent(ctx.prosemirror);
       getControl("italic").click();
 
-      expect(ctx.prosemirror.innerHTML).toEqual("<p><em>Hello, world!</em></p>");
+      expect(normalizeHTML(ctx.prosemirror.innerHTML)).toEqual("<p><em>Hello, world!</em></p>");
     });
 
     it("makes already italic text normal", async () => {
@@ -39,7 +43,7 @@ export default (ctx) => {
       selectContent(ctx.prosemirror, "p em");
       getControl("italic").click();
 
-      expect(ctx.prosemirror.innerHTML).toEqual("<p>Hello, world!</p>");
+      expect(normalizeHTML(ctx.prosemirror.innerHTML)).toEqual("<p>Hello, world!</p>");
     });
   });
 
@@ -49,7 +53,7 @@ export default (ctx) => {
       selectContent(ctx.prosemirror);
       getControl("underline").click();
 
-      expect(ctx.prosemirror.innerHTML).toEqual("<p><u>Hello, world!</u></p>");
+      expect(normalizeHTML(ctx.prosemirror.innerHTML)).toEqual("<p><u>Hello, world!</u></p>");
     });
 
     it("makes already underlined text normal", async () => {
@@ -58,7 +62,7 @@ export default (ctx) => {
       selectContent(ctx.prosemirror, "p u");
       getControl("underline").click();
 
-      expect(ctx.prosemirror.innerHTML).toEqual("<p>Hello, world!</p>");
+      expect(normalizeHTML(ctx.prosemirror.innerHTML)).toEqual("<p>Hello, world!</p>");
     });
   });
 
@@ -71,7 +75,7 @@ export default (ctx) => {
 
       getControl("common:eraseStyles").click();
 
-      expect(ctx.prosemirror.innerHTML).toEqual("<p>Hello, world!</p>")
+      expect(normalizeHTML(ctx.prosemirror.innerHTML)).toEqual("<p>Hello, world!</p>")
     });
 
     it("makes ordered list content as normal text", async () => {
@@ -80,7 +84,7 @@ export default (ctx) => {
 
       getControl("common:eraseStyles").click();
 
-      expect(ctx.prosemirror.innerHTML).toEqual("<p>Hello, world!</p>")
+      expect(normalizeHTML(ctx.prosemirror.innerHTML)).toEqual("<p>Hello, world!</p>")
     });
 
     it("makes bullet list content as normal text", async () => {
@@ -89,7 +93,7 @@ export default (ctx) => {
 
       getControl("common:eraseStyles").click();
 
-      expect(ctx.prosemirror.innerHTML).toEqual("<p>Hello, world!</p>")
+      expect(normalizeHTML(ctx.prosemirror.innerHTML)).toEqual("<p>Hello, world!</p>")
     });
   });
 };

data/app/packs/src/decidim/editor/test/toolbar/shared/behaves_like_content_styling.js

@@ -5,6 +5,10 @@ import contextHelpers from "src/decidim/editor/test/toolbar/shared/context";
 export default (ctx) => {
   const { getControl, setContent } = contextHelpers(ctx);
 
+  const normalizeHTML = (html) => {
+    return html.replace(/<p><br class="ProseMirror-trailingBreak"><\/p>$/g, "").trim();
+  };
+
   describe("heading", () => {
     const levels = ["2", "3", "4", "5", "6"];
     let selectValue = (value) => {
@@ -21,7 +25,7 @@ export default (ctx) => {
         selectValue(level);
 
         const tag = `h${level}`;
-        expect(ctx.prosemirror.innerHTML).toEqual(`<${tag}>Hello, world!</${tag}>`);
+        expect(normalizeHTML(ctx.prosemirror.innerHTML)).toEqual(`<${tag}>Hello, world!</${tag}>`);
       });
     });
 
@@ -33,7 +37,7 @@ export default (ctx) => {
 
         selectValue("normal");
 
-        expect(ctx.prosemirror.innerHTML).toEqual("<p>Hello, world!</p>");
+        expect(normalizeHTML(ctx.prosemirror.innerHTML)).toEqual("<p>Hello, world!</p>");
       });
     });
   });

data/app/packs/src/decidim/geocoding/reverse_geocoding.js

@@ -13,13 +13,24 @@ export const initializeReverseGeocoding = function() {
 
   const setLocating = (button, enable) => {
     if (enable) {
+      button.dataset.originalContent = button.innerHTML;
+      button.textContent = "";
+      const spinner = document.createElement("span");
+      spinner.className = "geocoding__spinner";
+      button.appendChild(spinner);
+      button.append(` ${button.dataset.locatingText || "Locating..."}`);
       button.setAttribute("disabled", true);
+      button.classList.add("geocoding__button--locating");
     } else {
+      if (button.dataset.originalContent) {
+        button.innerHTML = button.dataset.originalContent;
+      }
       button.removeAttribute("disabled");
+      button.classList.remove("geocoding__button--locating");
     }
   };
 
-  document.querySelectorAll(".user-device-location button").forEach((button) => {
+  document.querySelectorAll(".geocoding__button").forEach((button) => {
     button.addEventListener("click", (event) => {
       const target = event.target;
       if (target.disabled) {
@@ -36,19 +47,18 @@ export const initializeReverseGeocoding = function() {
         navigator.geolocation.getCurrentPosition((position) => {
           const coordinates = [position.coords.latitude, position.coords.longitude];
 
-          // reverse geolocation
           $.post(url, { latitude: coordinates[0], longitude: coordinates[1] }, (data) => {
             input.value = data.address;
             $(input).trigger("geocoder-suggest-coordinates.decidim", [coordinates]);
+            setLocating(target, false);
           }).fail((xhr, status, error) => {
             info(input, `${errorNoLocation} ${error}`);
+            setLocating(target, false);
           });
 
-          setLocating(target, false);
-
         }, (evt) => {
           info(input, `${errorNoLocation} ${evt.message}`);
-          target.removeAttribute("disabled");
+          setLocating(target, false);
         }, {
           enableHighAccuracy: true
         });

data/app/packs/src/decidim/geocoding/reverse_geocoding.test.js

@@ -0,0 +1,197 @@
+/* global global, jest */
+
+import { initializeReverseGeocoding } from "src/decidim/geocoding/reverse_geocoding";
+
+describe("reverseGeocoding", () => {
+  let container = null;
+  let button = null;
+  let input = null;
+  let label = null;
+  let mockGeolocation = null;
+  let mockPost = null;
+  let originalGeolocation = null;
+
+  beforeEach(() => {
+    document.body.innerHTML = "";
+
+    container = document.createElement("div");
+    container.innerHTML = `
+      <label>
+        <input id="test_address" type="text" />
+        <div class="geocoding__locate">
+          <button
+            class="geocoding__button"
+            type="button"
+            data-input="test_address"
+            data-error-no-location="Could not detect location."
+            data-error-unsupported="Device not supported."
+            data-locating-text="Locating..."
+            data-url="/locate">
+            Use my location
+          </button>
+        </div>
+      </label>
+    `;
+    document.body.appendChild(container);
+
+    button = container.querySelector(".geocoding__button");
+    input = container.querySelector("#test_address");
+    label = container.querySelector("label");
+
+    originalGeolocation = navigator.geolocation;
+    mockGeolocation = {
+      getCurrentPosition: jest.fn()
+    };
+    Reflect.defineProperty(global.navigator, "geolocation", {
+      value: mockGeolocation,
+      configurable: true
+    });
+
+    mockPost = jest.fn();
+    global.jQuery = jest.fn(() => ({ trigger: jest.fn() }));
+    global.jQuery.post = mockPost;
+    // eslint-disable-next-line id-length
+    global.$ = global.jQuery;
+
+    initializeReverseGeocoding();
+  });
+
+  afterEach(() => {
+    Reflect.defineProperty(global.navigator, "geolocation", {
+      value: originalGeolocation,
+      configurable: true
+    });
+    jest.restoreAllMocks();
+  });
+
+  describe("when clicking the button", () => {
+    it("shows the spinner and disables the button", () => {
+      mockGeolocation.getCurrentPosition.mockImplementation(() => {});
+
+      button.click();
+
+      expect(button.disabled).toBe(true);
+      expect(button.classList.contains("geocoding__button--locating")).toBe(true);
+      expect(button.querySelector(".geocoding__spinner")).not.toBeNull();
+      expect(button.textContent).toContain("Locating...");
+    });
+
+    it("uses custom locating text from data attribute", () => {
+      button.dataset.locatingText = "Finding you...";
+      mockGeolocation.getCurrentPosition.mockImplementation(() => {});
+
+      button.click();
+
+      expect(button.textContent).toContain("Finding you...");
+    });
+
+    it("stores original content for restoration", () => {
+      mockGeolocation.getCurrentPosition.mockImplementation(() => {});
+
+      button.click();
+
+      expect(button.dataset.originalContent).toContain("Use my location");
+    });
+  });
+
+  describe("when geolocation succeeds", () => {
+    it("restores the button after successful reverse geocoding", () => {
+      const mockPosition = {
+        coords: { latitude: 40.7128, longitude: -74.006 }
+      };
+      mockGeolocation.getCurrentPosition.mockImplementation((success) => {
+        success(mockPosition);
+      });
+
+      const mockDeferred = { fail: jest.fn() };
+      mockPost.mockImplementation((url, data, callback) => {
+        callback({ address: "New York, NY, USA" });
+        return mockDeferred;
+      });
+
+      button.click();
+
+      expect(button.disabled).toBe(false);
+      expect(button.classList.contains("geocoding__button--locating")).toBe(false);
+      expect(button.querySelector(".geocoding__spinner")).toBeNull();
+      expect(button.textContent).toContain("Use my location");
+      expect(input.value).toBe("New York, NY, USA");
+    });
+
+    it("restores the button when reverse geocoding fails", () => {
+      const mockPosition = {
+        coords: { latitude: 40.7128, longitude: -74.006 }
+      };
+      mockGeolocation.getCurrentPosition.mockImplementation((success) => {
+        success(mockPosition);
+      });
+
+      const mockDeferred = { fail: jest.fn((callback) => {
+        callback({}, "error", "Not Found");
+      }) };
+      mockPost.mockReturnValue(mockDeferred);
+
+      button.click();
+
+      expect(button.disabled).toBe(false);
+      expect(button.classList.contains("geocoding__button--locating")).toBe(false);
+      expect(button.textContent).toContain("Use my location");
+    });
+  });
+
+  describe("when geolocation fails", () => {
+    it("restores the button when user denies permission", () => {
+      const mockError = { message: "User denied geolocation" };
+      mockGeolocation.getCurrentPosition.mockImplementation((success, error) => {
+        error(mockError);
+      });
+
+      button.click();
+
+      expect(button.disabled).toBe(false);
+      expect(button.classList.contains("geocoding__button--locating")).toBe(false);
+      expect(button.textContent).toContain("Use my location");
+    });
+
+    it("shows an error message", () => {
+      const mockError = { message: "User denied geolocation" };
+      mockGeolocation.getCurrentPosition.mockImplementation((success, error) => {
+        error(mockError);
+      });
+
+      button.click();
+
+      const errorElement = label.querySelector(".form-error");
+      expect(errorElement).not.toBeNull();
+      expect(errorElement.textContent).toContain("Could not detect location.");
+    });
+  });
+
+  describe("when geolocation is not supported", () => {
+    it("shows an unsupported error and does not show spinner", () => {
+      Reflect.defineProperty(global.navigator, "geolocation", {
+        value: null,
+        configurable: true
+      });
+
+      button.click();
+
+      expect(button.disabled).toBe(false);
+      expect(button.classList.contains("geocoding__button--locating")).toBe(false);
+      const errorElement = label.querySelector(".form-error");
+      expect(errorElement).not.toBeNull();
+      expect(errorElement.textContent).toContain("Device not supported.");
+    });
+  });
+
+  describe("when button is already disabled", () => {
+    it("does not trigger geolocation again", () => {
+      button.disabled = true;
+      mockGeolocation.getCurrentPosition.mockImplementation(() => {});
+
+      button.click();
+
+      expect(mockGeolocation.getCurrentPosition).not.toHaveBeenCalled();
+    });
+  });
+});

data/app/packs/src/decidim/index.js

@@ -34,9 +34,7 @@ import "src/decidim/security/selfxss_warning"
 import "src/decidim/session_timeouter"
 import "src/decidim/results_listing"
 import "src/decidim/data_consent"
-import "src/decidim/sw"
 import "src/decidim/attachments"
-import "src/decidim/dropdown_menu"
 import "src/decidim/callout"
 
 // local deps that require initialization
@@ -62,6 +60,7 @@ window.Decidim = window.Decidim || {
   announceForScreenReader
 };
 
+window.createDialog = createDialog;
 window.morphdom = morphdom
 
 // eslint-disable-next-line max-params
@@ -156,6 +155,8 @@ document.addEventListener("turbo:load", () => {
     deprecationMessage(container, '.callout[role="alert"]', '.flash[role="alert"]'));
   document.querySelectorAll(".js-back-to-list").forEach((container) =>
     deprecationMessage(container, ".js-back-to-list", "NEEDS TO BE REMOVED"));
+  document.querySelectorAll("[data-toggler]").forEach((container) =>
+    deprecationMessage(container, "[data-toggler]", "Use the Stimulus toggle controller with hidden targets"));
 })
 
 // REDESIGN_PENDING: deprecated
@@ -236,8 +237,7 @@ const initializer = (element = document) => {
   document.dispatchEvent(new CustomEvent("decidim:loaded", { detail: { element } }));
 }
 
-// If no jQuery is used the Tribute feature used in comments to autocomplete
-// mentions stops working
+// Keep this under jQuery ready to support components initialized on legacy templates
 $(() => initializer());
 
 // Run initializer action over the new DOM elements