decidim-core 0.31.2 → 0.32.1

data/lib/decidim/core/test/shared_examples/access_mode_restricted_participatory_spaces.rb

@@ -0,0 +1,175 @@
+# frozen_string_literal: true
+
+shared_examples "access mode restricted participatory spaces" do |with_attachments: true|
+  let!(:organization) { create(:organization) }
+  let!(:admin) { create(:user, :admin, :confirmed, organization:) }
+  let!(:user) { create(:user, :confirmed, organization:) }
+
+  context "and no user is logged in" do
+    before do
+      switch_to_host(organization.host)
+      visit participatory_space_index_path
+    end
+
+    it "does not list the restricted participatory space" do
+      within css_class_selector do
+        within "h2" do
+          expect(page).to have_content("1")
+        end
+
+        expect(page).to have_content(translated(participatory_space.title, locale: :en))
+        expect(page).to have_css(".card__grid", count: 1)
+
+        expect(page).to have_no_content(translated(restricted_participatory_space.title, locale: :en))
+      end
+    end
+  end
+
+  context "when user is logged in and is not a participatory space member" do
+    context "when the user is not admin" do
+      before do
+        switch_to_host(organization.host)
+        login_as user, scope: :user
+        visit participatory_space_index_path
+      end
+
+      it "does not list the restricted participatory space" do
+        within css_class_selector do
+          within "h2" do
+            expect(page).to have_content("1")
+          end
+
+          expect(page).to have_content(translated(participatory_space.title, locale: :en))
+          expect(page).to have_css(".card__grid", count: 1)
+
+          expect(page).to have_no_content(translated(restricted_participatory_space.title, locale: :en))
+        end
+      end
+    end
+
+    context "when the user is admin" do
+      before do
+        switch_to_host(organization.host)
+        login_as admin, scope: :user
+        visit participatory_space_index_path
+      end
+
+      it "lists restricted participatory spaces" do
+        within css_class_selector do
+          within "h2" do
+            expect(page).to have_content("2")
+          end
+
+          expect(page).to have_content(translated(participatory_space.title, locale: :en))
+          expect(page).to have_content(translated(restricted_participatory_space.title, locale: :en))
+          expect(page).to have_css(".card__grid", count: 2)
+        end
+      end
+
+      it "links to the individual participatory space page" do
+        first(".card__grid-text", text: translated(restricted_participatory_space.title, locale: :en)).click
+
+        expect(page).to have_current_path restricted_participatory_space_path
+        expect(page).to have_content "This is a restricted space"
+      end
+
+      # Evaluators and Moderators do not have permissions to see the admin attachments page
+      if with_attachments
+        it "shows the privacy warning in attachments admin" do
+          visit restricted_participatory_space_attachment_path
+          within "#attachments" do
+            expect(page).to have_content(I18n.t("decidim.admin.attachments_privacy_warning.message"))
+          end
+        end
+      end
+    end
+  end
+
+  context "when user is logged in and is an participatory space member" do
+    before do
+      switch_to_host(organization.host)
+      login_as other_user, scope: :user
+      visit participatory_space_index_path
+    end
+
+    it "lists restricted participatory spaces" do
+      within css_class_selector do
+        within "h2" do
+          expect(page).to have_content("2")
+        end
+
+        expect(page).to have_content(translated(participatory_space.title, locale: :en))
+        expect(page).to have_content(translated(restricted_participatory_space.title, locale: :en))
+        expect(page).to have_css(".card__grid", count: 2)
+      end
+    end
+
+    it "links to the individual participatory space page" do
+      first(".card__grid-text", text: translated(restricted_participatory_space.title, locale: :en)).click
+
+      expect(page).to have_current_path restricted_participatory_space_path
+      expect(page).to have_content "This is a restricted space"
+    end
+  end
+end
+
+shared_examples "access mode restricted participatory spaces comments" do
+  let!(:participatory_space) { restricted_participatory_space }
+  let!(:member) { create(:member, user: member_user, participatory_space:) }
+  let!(:component) { create(:dummy_component, participatory_space:) }
+  let!(:commentable) { create(:dummy_resource, component:) }
+  let!(:comment) { create(:comment, commentable:, author: user) }
+
+  let!(:organization) { create(:organization) }
+  let!(:user) { create(:user, :confirmed, organization:) }
+  let!(:other_user) { create(:user, :confirmed, organization:) }
+  let!(:member_user) { create(:user, :confirmed, organization:) }
+
+  let(:resource_path) { resource_locator(commentable).path }
+
+  before do
+    switch_to_host(organization.host)
+  end
+
+  context "when the user is not logged in" do
+    it "cannot access the page" do
+      visit resource_path
+      expect(page).to have_content("You are not authorized to perform this action")
+    end
+  end
+
+  context "when the user is logged in and is a member" do
+    before do
+      login_as member_user, scope: :user
+      visit resource_path
+    end
+
+    it "can see the comments" do
+      expect(page).to have_css("#comments")
+      expect(page).to have_content(comment.body["en"])
+    end
+
+    it "can see the comment form" do
+      expect(page).to have_css("form#new_comment_for_DummyResource_#{commentable.id}")
+    end
+
+    it "can see the vote buttons" do
+      if commentable.comments_have_votes?
+        expect(page).to have_css(".comment__votes button", minimum: 2)
+      else
+        expect(page).to have_no_css(".comment__votes button")
+      end
+    end
+  end
+
+  context "when the user is logged in and is not a member" do
+    before do
+      login_as other_user, scope: :user
+      visit resource_path
+    end
+
+    it "cannot access the page" do
+      expect(page).to have_content("You are not authorized to perform this action")
+    end
+  end
+end

data/lib/decidim/core/test/shared_examples/access_mode_transparent_participatory_spaces.rb

@@ -0,0 +1,244 @@
+# frozen_string_literal: true
+
+shared_examples "access mode transparent participatory spaces" do |with_attachments: true|
+  let!(:admin) { create(:user, :admin, :confirmed, organization:) }
+  let!(:user) { create(:user, :confirmed, organization:) }
+  let!(:other_user) { create(:user, :confirmed, organization:) }
+  let!(:other_user2) { create(:user, :confirmed, organization:) }
+
+  context "and no user is logged in" do
+    before do
+      switch_to_host(organization.host)
+      visit participatory_space_index_path
+    end
+
+    it "lists all the spaces" do
+      within css_class_selector do
+        within "h2" do
+          expect(page).to have_content("2")
+        end
+
+        expect(page).to have_content(translated(participatory_space.title, locale: :en))
+        expect(page).to have_css(".card__grid", count: 2)
+
+        expect(page).to have_content(translated(transparent_participatory_space.title, locale: :en))
+      end
+    end
+
+    it "links to the individual space page" do
+      first(".card__grid-text", text: translated(transparent_participatory_space.title, locale: :en)).click
+
+      expect(page).to have_current_path transparent_participatory_space_path
+      expect(page).to have_content "This is a transparent space"
+    end
+  end
+
+  context "when user is logged in" do
+    context "when is not a space member" do
+      before do
+        switch_to_host(organization.host)
+        login_as user, scope: :user
+        visit participatory_space_index_path
+      end
+
+      it "lists all the spaces" do
+        within css_class_selector do
+          within "h2" do
+            expect(page).to have_content("2")
+          end
+
+          expect(page).to have_content(translated(participatory_space.title, locale: :en))
+          expect(page).to have_css(".card__grid", count: 2)
+
+          expect(page).to have_content(translated(transparent_participatory_space.title, locale: :en))
+        end
+      end
+    end
+
+    # Evaluators and Moderators do not have permissions to see the admin attachments page
+    if with_attachments
+      context "when the user is admin" do
+        before do
+          switch_to_host(organization.host)
+          login_as admin, scope: :user
+          visit participatory_space_index_path
+        end
+
+        it "does not show the privacy warning in attachments admin" do
+          visit transparent_participatory_space_attachment_path
+          within "#attachments" do
+            expect(page).to have_no_content("Any participant could share this document to others")
+          end
+        end
+      end
+    end
+  end
+end
+
+shared_examples "access mode transparent participatory spaces comments" do
+  let!(:participatory_space) { transparent_participatory_space }
+  let!(:component) { create(:dummy_component, participatory_space:) }
+  let!(:commentable) { create(:dummy_resource, component:) }
+  let!(:comment) { create(:comment, commentable:, author: user) }
+
+  let!(:user) { create(:user, :confirmed, organization:) }
+  let!(:other_user) { create(:user, :confirmed, organization:) }
+  let!(:member_user) { create(:user, :confirmed, organization:) }
+  let!(:member) { create(:member, user: member_user, participatory_space:) }
+
+  let(:resource_path) { resource_locator(commentable).path }
+
+  before do
+    switch_to_host(organization.host)
+  end
+
+  context "when the user is not logged in" do
+    before do
+      visit resource_path
+    end
+
+    it "can see the comments" do
+      expect(page).to have_css("#comments")
+      expect(page).to have_content(comment.body["en"])
+    end
+
+    it "cannot see the comment form" do
+      expect(page).to have_no_css("form#new_comment_for_DummyResource_#{commentable.id}")
+    end
+
+    it "cannot see the vote buttons" do
+      expect(page).to have_no_css(".js-comment__votes--up")
+      expect(page).to have_no_css(".js-comment__votes--down")
+    end
+  end
+
+  context "when the user is logged in and is a member" do
+    before do
+      login_as member_user, scope: :user
+      visit resource_path
+    end
+
+    it "can see the comments" do
+      expect(page).to have_css("#comments")
+      expect(page).to have_content(comment.body["en"])
+    end
+
+    it "can see the comment form" do
+      expect(page).to have_css("form#new_comment_for_DummyResource_#{commentable.id}")
+    end
+
+    it "can add a new comment" do
+      within "form#new_comment_for_DummyResource_#{commentable.id}" do
+        fill_in "add-comment-DummyResource-#{commentable.id}", with: "This is a test comment from a member"
+        click_on "Publish comment"
+      end
+
+      expect(page).to have_content("This is a test comment from a member")
+    end
+
+    it "can see the vote buttons" do
+      if commentable.comments_have_votes?
+        expect(page).to have_css(".comment__votes button", minimum: 2)
+      else
+        expect(page).to have_no_css(".comment__votes button")
+      end
+    end
+
+    it "can vote on a comment" do
+      skip "Commentable comments has no votes" unless commentable.comments_have_votes?
+
+      within "#comment_#{comment.id}" do
+        click_on(".comment__votes button", match: :first)
+      end
+
+      expect(page).to have_css(".comment__votes button.is-vote-selected")
+    end
+  end
+
+  context "when the user is logged in and is not a member" do
+    before do
+      login_as other_user, scope: :user
+      visit resource_path
+    end
+
+    it "can see the comments" do
+      expect(page).to have_css("#comments")
+      expect(page).to have_content(comment.body["en"])
+    end
+
+    it "cannot see the comment form" do
+      expect(page).to have_no_css("form#new_comment_for_DummyResource_#{commentable.id}")
+      expect(page).to have_content("You are not able to comment at this moment")
+    end
+
+    it "cannot see the vote buttons" do
+      expect(page).to have_no_css(".js-comment__votes--up")
+      expect(page).to have_no_css(".js-comment__votes--down")
+    end
+  end
+
+  context "when the user is logged in and is a member" do
+    before do
+      login_as member_user, scope: :user
+      visit resource_path
+    end
+
+    it "can see the comments" do
+      expect(page).to have_css("#comments")
+      expect(page).to have_content(comment.body["en"])
+    end
+
+    it "can see the comment form" do
+      expect(page).to have_css("form#new_comment_for_DummyResource_#{commentable.id}")
+    end
+
+    it "can add a new comment" do
+      within "form#new_comment_for_DummyResource_#{commentable.id}" do
+        fill_in "add-comment-DummyResource-#{commentable.id}", with: "This is a test comment from a member"
+        click_on "Publish comment"
+      end
+
+      expect(page).to have_content("This is a test comment from a member")
+    end
+
+    it "can see the vote buttons" do
+      if commentable.comments_have_votes?
+        expect(page).to have_css(".comment__votes button", minimum: 2)
+      else
+        expect(page).to have_no_css(".comment__votes button")
+      end
+    end
+
+    it "can vote on a comment" do
+      skip "Commentable comments has no votes" unless commentable.comments_have_votes?
+
+      within "#comment_#{comment.id}" do
+        click_on(".comment__votes button", match: :first)
+      end
+
+      expect(page).to have_css(".comment__votes button.is-vote-selected")
+    end
+  end
+
+  context "when the user is logged in and is not a member" do
+    before do
+      login_as other_user, scope: :user
+      visit resource_path
+    end
+
+    it "can see the comments" do
+      expect(page).to have_css("#comments")
+      expect(page).to have_content(comment.body["en"])
+    end
+
+    it "cannot see the comment form" do
+      expect(page).to have_no_css("form#new_comment_for_DummyResource_#{commentable.id}")
+      expect(page).to have_content("You are not able to comment at this moment")
+    end
+
+    it "cannot see the vote buttons" do
+      expect(page).to have_no_css(".js-comment__votes--up")
+      expect(page).to have_no_css(".js-comment__votes--down")
+    end
+  end
+end

data/lib/decidim/core/test/shared_examples/admin_resource_gallery_examples.rb

@@ -87,7 +87,7 @@ end
 
 shared_examples "admin creates resource gallery" do
   context "when uploading images" do
-    let(:uploaded_photos) do
+    let(:uploaded_attachments) do
       [
         {
           title: "Picture of the city",
@@ -99,10 +99,10 @@ shared_examples "admin creates resource gallery" do
         }
       ]
     end
-    let(:photos) { [] }
+    let(:current_attachments) { [] }
 
     it "creates a gallery for the resource" do
-      expect { command.call }.to change(Decidim::Attachment, :count).by(uploaded_photos.count)
+      expect { command.call }.to change(Decidim::Attachment, :count).by(uploaded_attachments.count)
 
       resource = resource_class.last
       expect(resource.photos.count).to eq(2)
@@ -111,7 +111,7 @@ shared_examples "admin creates resource gallery" do
     end
 
     context "when gallery is left blank" do
-      let(:uploaded_photos) { [] }
+      let(:uploaded_attachments) { [] }
 
       it "broadcasts ok" do
         expect { command.call }.to broadcast(:ok)
@@ -122,7 +122,7 @@ end
 
 shared_examples "admin manages resource gallery" do
   context "when managing images" do
-    let(:uploaded_photos) do
+    let(:uploaded_attachments) do
       [
         {
           title: "Picture of the city",
@@ -134,10 +134,10 @@ shared_examples "admin manages resource gallery" do
         }
       ]
     end
-    let(:photos) { [] }
+    let(:current_attachments) { [] }
 
     it "creates a gallery for the resource" do
-      expect { command.call }.to change(Decidim::Attachment, :count).by(uploaded_photos.count)
+      expect { command.call }.to change(Decidim::Attachment, :count).by(uploaded_attachments.count)
       resource = resource_class.last
       expect(resource.photos.count).to eq(2)
       last_attachment = Decidim::Attachment.last
@@ -145,7 +145,7 @@ shared_examples "admin manages resource gallery" do
     end
 
     context "when gallery is left blank" do
-      let(:uploaded_photos) { [] }
+      let(:uploaded_attachments) { [] }
 
       it "broadcasts ok" do
         expect { command.call }.to broadcast(:ok)
@@ -155,8 +155,8 @@ shared_examples "admin manages resource gallery" do
     context "when images are removed" do
       let!(:image1) { create(:attachment, :with_image, attached_to: resource) }
       let!(:image2) { create(:attachment, :with_image, attached_to: resource) }
-      let(:uploaded_photos) { [] }
-      let(:current_photos) { [image1] }
+      let(:uploaded_attachments) { [] }
+      let(:current_attachments) { [image1.id] }
 
       it "to decrease the number of photos in the gallery" do
         expect(resource.attachments.count).to eq(2)

data/lib/decidim/core/test/shared_examples/amendable/amendment_event_examples.rb

@@ -8,7 +8,7 @@ shared_examples "amendment event" do
   it_behaves_like "a simple event email"
   it_behaves_like "a simple event notification"
 
-  let(:emendation_author_nickname) { "@#{emendation.creator_author.nickname}" }
+  let(:emendation_author_name) { emendation.creator_author.name }
   let(:emendation_path) { Decidim::ResourceLocatorPresenter.new(emendation).path }
   let(:emendation_author_path) { Decidim::UserPresenter.new(emendation.creator_author).profile_path }
   let(:amendable_path) { Decidim::ResourceLocatorPresenter.new(amendable).path }
@@ -16,5 +16,5 @@ shared_examples "amendment event" do
   let(:email_intro) { "An amendment has been #{amendment_type} for #{amendable_title}. You can see it from this page:" }
   let(:email_outro) { "You have received this notification because you are following #{amendable_title}. You can stop receiving notifications following the previous link." }
 
-  let(:notification_title) { "The <a href=\"#{emendation_path}\">amendment</a> created by <a href=\"#{emendation_author_path}\">#{emendation_author_nickname}</a> has been #{amendment_type} for <a href=\"#{amendable_path}\">#{amendable_title}</a>." } # rubocop:disable Layout/LineLength
+  let(:notification_title) { "The <a href=\"#{emendation_path}\">amendment</a> created by <a href=\"#{emendation_author_path}\">#{emendation_author_name}</a> has been #{amendment_type} for <a href=\"#{amendable_path}\">#{amendable_title}</a>." } # rubocop:disable Layout/LineLength
 end

data/lib/decidim/core/test/shared_examples/amendable/amendment_promoted_event_examples.rb

@@ -10,15 +10,15 @@ shared_examples "amendment promoted event" do
   it_behaves_like "a simple event email"
   it_behaves_like "a simple event notification"
 
-  let(:emendation_author_nickname) { "@#{emendation.creator_author.nickname}" }
+  let(:emendation_author_name) { emendation.creator_author.name }
   let(:emendation_path) { Decidim::ResourceLocatorPresenter.new(emendation).path }
   let(:emendation_author_path) { Decidim::UserPresenter.new(emendation.creator_author).profile_path }
   let(:amendable_path) { Decidim::ResourceLocatorPresenter.new(amendable).path }
 
-  let(:email_subject) { "An amendment from #{emendation_author_nickname} has been published as a new proposal" }
+  let(:email_subject) { "An amendment from #{emendation_author_name} has been published as a new proposal" }
   let(:email_intro) { "A rejected amendment for #{amendable_title} has been published as a new #{amendable_type}. You can see it from this page:" }
   let(:email_outro) { "You have received this notification because you are following #{amendable_title}. You can stop receiving notifications following the previous link." }
   # rubocop:disable Layout/LineLength
-  let(:notification_title) { "A <a href=\"#{emendation_path}\">rejected amendment</a> for <a href=\"#{amendable_path}\">#{amendable_title}</a> has been published as a new #{amendable_type} by <a href=\"#{emendation_author_path}\">#{emendation_author_nickname}</a>." }
+  let(:notification_title) { "A <a href=\"#{emendation_path}\">rejected amendment</a> for <a href=\"#{amendable_path}\">#{amendable_title}</a> has been published as a new #{amendable_type} by <a href=\"#{emendation_author_path}\">#{emendation_author_name}</a>." }
   # rubocop:enable Layout/LineLength
 end