decidim-core 0.31.2 → 0.32.1

data/lib/decidim/core/test/shared_examples/comments_examples.rb

@@ -67,7 +67,8 @@ shared_examples "comments" do
       select "Best rated", from: "order"
     end
 
-    expect(page).to have_css(".comments > div:nth-child(2)", text: "Most Rated Comment")
+    expect(page).to have_no_css(".loading-comments", visible: :visible)
+    expect(page).to have_css(".comment-threads .comment-thread", text: "Most Rated Comment")
   end
 
   context "when there are comments and replies" do
@@ -79,8 +80,8 @@ shared_examples "comments" do
       expect(page).to have_no_content("Comments are disabled at this time")
       expect(page).to have_css(".comment", minimum: 1)
 
-      within("#accordion-#{single_comment.id}") do
-        expect(page).to have_content "1 answer"
+      within("#comment_#{single_comment.id}") do
+        expect(page).to have_content "1 reply"
       end
     end
 
@@ -132,6 +133,7 @@ shared_examples "comments" do
         visit resource_path
 
         within "#comment_#{deleted_comment.id}" do
+          click_on "1 reply"
           expect(page).to have_css("#comment-#{deleted_comment.id}-replies")
           expect(page).to have_content(reply.author.name)
           expect(page).to have_content(reply.body.values.first)
@@ -140,6 +142,30 @@ shared_examples "comments" do
     end
   end
 
+  context "when there are more comments than the default per page" do
+    let(:per_page) { Decidim::Comments::SortedComments::DEFAULT_COMMENTS_LIMIT }
+    let!(:extra_comments) { create_list(:comment, per_page - comments.size + 1, commentable:) }
+    let(:all_comments) { comments + extra_comments }
+
+    it "shows a load more button and loads the next page" do
+      visit resource_path
+
+      visible_comments = all_comments.sort_by(&:created_at).first(per_page)
+      hidden_comment = (all_comments.sort_by(&:created_at) - visible_comments).first
+
+      visible_comments.each do |comment|
+        expect(page).to have_css("#comment_#{comment.id}")
+      end
+      expect(page).to have_no_css("#comment_#{hidden_comment.id}")
+      expect(page).to have_button("Load more comments")
+
+      click_on "Load more comments"
+
+      expect(page).to have_css("#comment_#{hidden_comment.id}")
+      expect(page).to have_no_button("Load more comments")
+    end
+  end
+
   context "when not authenticated" do
     it "does not show form to add comments to user" do
       visit resource_path
@@ -147,6 +173,16 @@ shared_examples "comments" do
       expect(page).to have_css(".comment-thread")
     end
 
+    it "opens the login modal when clicking the comment button" do
+      visit resource_path
+
+      expect(page).to have_no_css("#loginModal-content", visible: :visible)
+
+      find(".add-comment-mobile").click
+
+      expect(page).to have_css("#loginModal-content", visible: :visible)
+    end
+
     context "when user visit a mobile browser" do
       before do
         driven_by(:iphone)
@@ -176,6 +212,22 @@ shared_examples "comments" do
       expect(page).to have_css(".add-comment form")
     end
 
+    it "does not show login modal when clicking the comment button" do
+      visit resource_path
+
+      find("a.add-comment-mobile").click
+
+      expect(page).to have_no_css("#loginModal-content", visible: :visible)
+    end
+
+    it "guides the user to the comment form when clicking the comment button" do
+      visit resource_path
+
+      find("a.add-comment-mobile").click
+
+      expect(page).to have_css("#add-comment-anchor")
+    end
+
     context "when user visit a computer browser" do
       before do
         switch_to_host(organization.host)
@@ -260,6 +312,8 @@ shared_examples "comments" do
 
     describe "when using emojis" do
       before do
+        skip("This spec does not work in focus mode, since there is no language selector.") if has_selector?(".main-bar--focus-mode-back-button")
+
         within_language_menu do
           click_on "Castellano"
         end
@@ -310,6 +364,12 @@ shared_examples "comments" do
         let(:locale) { "Català" }
         let(:phrase) { I18n.with_locale(:ca) { I18n.t("emojis.categories.people") } }
 
+        around do |example|
+          I18n.with_locale(:ca) do
+            example.run
+          end
+        end
+
         it_behaves_like "allowing to select emojis"
       end
     end
@@ -641,96 +701,48 @@ shared_examples "comments" do
       end
     end
 
-    context "when the user is writing a new comment while someone else comments" do
-      let(:new_comment_body) { "Hey, I just jumped in the conversation!" }
-      let(:new_comment) { build(:comment, commentable:, body: new_comment_body) }
-      let(:content) { "This is a new comment" }
+    context "when user can show and hide replies on a thread" do
+      let(:thread) { comments.first }
+      let(:new_reply_body) { "Hey, I just jumped inside the thread!" }
+      let!(:new_reply) { create(:comment, commentable: thread, root_commentable: commentable, body: new_reply_body) }
 
-      before do
-        within "form#new_comment_for_#{commentable.commentable_type.demodulize}_#{commentable.id}" do
-          field = find("#add-comment-#{commentable.commentable_type.demodulize}-#{commentable.id}")
-          field.set " "
-          field.native.send_keys content
+      it "displays a way to display content" do
+        visit resource_path
+        within "#comment_#{thread.id}" do
+          expect(page).to have_content("1 reply")
+          click_on "1 reply"
+          expect(page).to have_content(new_reply_body)
+          click_on "Reply", match: :first
+          expect(page).to have_content("Publish reply")
+          find("textarea[name='comment[body]']").set("Test reply comments.")
+          click_on "Publish reply"
+          expect(page).to have_content("Test reply comments.")
         end
-        new_comment.save!
       end
 
-      it "does not clear the current user's comment" do
-        expect(page).to have_content(new_comment.body.values.first, wait: 20)
-        expect(page.find("#add-comment-#{commentable.commentable_type.demodulize}-#{commentable.id}").value).to include(content)
+      it "displays a way to hide content" do
+        visit resource_path
+        within "#comment_#{thread.id}" do
+          expect(page).to have_content("1 reply")
+          click_on "1 reply"
+          expect(page).to have_content(new_reply_body)
+          click_on "1 reply"
+          expect(page).to have_no_content(new_reply_body)
+        end
       end
 
-      context "when user can hide replies on a thread" do
-        let(:thread) { comments.first }
-        let(:new_reply_body) { "Hey, I just jumped inside the thread!" }
-        let!(:new_reply) { create(:comment, commentable: thread, root_commentable: commentable, body: new_reply_body) }
+      context "when there are more replies" do
+        let!(:new_replies) { create_list(:comment, 2, commentable: thread, root_commentable: commentable, body: new_reply_body) }
 
-        it "displays a way to to display content" do
-          visit current_path
-          within "#comment_#{thread.id}" do
-            expect(page).to have_content("1 answer")
-            click_on "1 answer"
-            expect(page).to have_content(new_reply_body)
-            click_on "Reply", match: :first
-            expect(page).to have_content("Publish reply")
-            find("textarea[name='comment[body]']").set("Test reply comments.")
-            click_on "Publish reply"
-            expect(page).to have_content("Show 2 replies")
-            click_on "Show 2 replies"
-            expect(page).to have_content("Test reply comments.")
-          end
-        end
-
-        it "displays a way hide content" do
-          visit current_path
+        it "displays the load replies button" do
+          visit resource_path
           within "#comment_#{thread.id}" do
-            expect(page).to have_content("1 answer")
-            click_on "1 answer"
-            expect(page).to have_content("1 answer")
-            click_on "1 answer"
+            expect(page).to have_content("3 replies")
             expect(page).to have_no_content(new_reply_body)
+            click_on "3 replies"
+            expect(page).to have_content(new_reply_body)
           end
         end
-
-        context "when are more replies" do
-          let!(:new_replies) { create_list(:comment, 2, commentable: thread, root_commentable: commentable, body: new_reply_body) }
-
-          it "displays the show button" do
-            visit current_path
-            within "#comment_#{thread.id}" do
-              expect(page).to have_content("3 answers")
-              expect(page).to have_no_content(new_reply_body)
-              click_on "3 answers"
-              expect(page).to have_content(new_reply_body)
-            end
-          end
-        end
-      end
-
-      context "when inside a thread reply form" do
-        let(:thread) { comments.first }
-        let(:new_reply_body) { "Hey, I just jumped inside the thread!" }
-        let(:new_reply) { build(:comment, commentable: thread, root_commentable: commentable, body: new_reply_body) }
-        let(:reply_content) { "This is a new reply" }
-
-        before do
-          within "div#comment_#{thread.id}" do
-            find("span", text: "Reply").click
-          end
-
-          within "form#new_comment_for_#{thread.commentable_type.demodulize}_#{thread.id}" do
-            field = find("#add-comment-#{thread.commentable_type.demodulize}-#{thread.id}")
-            field.set " "
-            field.native.send_keys reply_content
-          end
-          new_reply.save!
-        end
-
-        it "does not clear the current user's comment" do
-          expect(page).to have_content(new_reply.body.values.first, wait: 20)
-          expect(page.find("#add-comment-#{commentable.commentable_type.demodulize}-#{commentable.id}").value).to include(content)
-          expect(page.find("#add-comment-#{thread.commentable_type.demodulize}-#{thread.id}").value).to include(reply_content)
-        end
       end
     end
 
@@ -895,8 +907,8 @@ shared_examples "comments" do
         visit current_path
 
         within "#comments #comment_#{parent.id}" do
-          expect(page).to have_css("#comment-#{parent.id}-replies")
-          expect(page.find("#comment-#{parent.id}-replies").text).to be_blank
+          expect(page).to have_no_css(".show-replies-button")
+          expect(page).to have_no_css("#comment-#{parent.id}-replies")
         end
       end
 
@@ -960,6 +972,10 @@ shared_examples "comments" do
             skip "Commentable comments has no votes" unless commentable.comments_have_votes?
 
             visit current_path
+
+            within "#comment_#{comments[0].id}" do
+              click_on "1 reply"
+            end
             expect(page).to have_css("#comment_#{comments[0].id} > [data-comment-footer] > .comment__footer-grid .comment__votes .js-comment__votes--up", text: /0/, visible: :all)
             page.find("#comment_#{comments[0].id} > [data-comment-footer] > .comment__footer-grid .comment__votes .js-comment__votes--up").click
             expect(page).to have_css("#comment_#{comments[0].id} > [data-comment-footer] > .comment__footer-grid .comment__votes .js-comment__votes--up", text: /1/, visible: :all)
@@ -1000,16 +1016,16 @@ shared_examples "comments" do
         let(:content) { "A valid user mention: @#{mentioned_user.nickname}" }
 
         context "when text finish with a mention" do
-          it "shows the tribute container" do
-            expect(page).to have_css(".tribute-container", text: mentioned_user.name, wait: 10)
+          it "shows the suggestions menu" do
+            expect(page).to have_css(".editor-suggestions-item", text: "@#{mentioned_user.nickname} (#{mentioned_user.name})", wait: 10)
           end
         end
 
         context "when text contains a mention" do
           let(:content) { "A valid user mention: @#{mentioned_user.nickname}." }
 
-          it "shows the tribute container" do
-            expect(page).to have_no_css(".tribute-container", text: mentioned_user.name)
+          it "hides the suggestions menu" do
+            expect(page).to have_no_css(".editor-suggestions-item", text: "@#{mentioned_user.nickname} (#{mentioned_user.name})")
           end
         end
       end
@@ -1018,8 +1034,8 @@ shared_examples "comments" do
         let!(:mentioned_user) { create(:user, organization:) }
         let(:content) { "A unconfirmed user mention: @#{mentioned_user.nickname}" }
 
-        it "do not show the tribute container" do
-          expect(page).to have_no_css(".tribute-container", text: mentioned_user.name)
+        it "does not show the suggestions menu" do
+          expect(page).to have_no_css(".editor-suggestions-item", text: "@#{mentioned_user.nickname} (#{mentioned_user.name})")
         end
       end
     end
@@ -1043,7 +1059,7 @@ shared_examples "comments" do
 
         it "replaces the mention with a link to the user's profile" do
           expect(page).to have_comment_from(user, "A valid user mention: @#{mentioned_user.nickname}", wait: 20)
-          expect(page).to have_link "@#{mentioned_user.nickname}", href: "http://#{mentioned_user.organization.host}:#{Capybara.server_port}/profiles/#{mentioned_user.nickname}"
+          expect(page).to have_link "@#{mentioned_user.nickname}", href: "http://#{mentioned_user.organization.host}:#{Capybara.server_port}/en/profiles/#{mentioned_user.nickname}"
         end
       end
 
@@ -1195,6 +1211,7 @@ shared_examples "comments with two columns" do
   let!(:user) { create(:user, :confirmed, organization:) }
 
   before do
+    switch_to_host(organization.host)
     login_as user, scope: :user
   end
 
@@ -1209,7 +1226,7 @@ shared_examples "comments with two columns" do
       expect(page).to have_css(".comment", count: comments.length)
 
       within(".comments-two-columns") do
-        check_comments_order(".comments-section__in-favor", comments_in_favor)
+        check_comments_order(".comments-section__in-favor", comments_in_favor.reverse)
         check_comments_order(".comments-section__against", comments_against)
       end
     end
@@ -1230,6 +1247,7 @@ shared_examples "comments with two columns" do
 
     context "when commentable is closed" do
       let!(:commentable) { closed_commentable }
+      let!(:comments) { [] }
       let!(:highest_voted_comment_in_favor) { create(:comment, :in_favor, commentable:, created_at: 2.days.ago, up_votes_count: 15) }
       let!(:high_voted_comment_in_favor) { create(:comment, :in_favor, commentable:, created_at: 4.days.ago, up_votes_count: 10) }
       let!(:older_comment_in_favor) { create(:comment, :in_favor, commentable:, created_at: 3.days.ago, up_votes_count: 5) }
@@ -1238,27 +1256,26 @@ shared_examples "comments with two columns" do
       let!(:high_voted_comment_against) { create(:comment, :against, commentable:, created_at: 5.days.ago, up_votes_count: 8) }
       let!(:older_comment_against) { create(:comment, :against, commentable:, created_at: 3.days.ago, up_votes_count: 4) }
 
-      it "shows comments with top comments at the beginning and interleaved order after" do
+      it "shows comments sorted by the selected filter in mobile view" do
         resize_window_to_mobile
         visit resource_path
+        sleep 1
 
         within(".comment-threads") do
-          interleaved_comments = [
-            highest_voted_comment_in_favor,
+          expected_order = [
             highest_voted_comment_against,
-            high_voted_comment_in_favor,
-            high_voted_comment_against,
+            highest_voted_comment_in_favor,
+            older_comment_against,
             older_comment_in_favor,
-            older_comment_against
+            high_voted_comment_in_favor,
+            high_voted_comment_against
           ]
 
           all_comments = all(".comment-thread")
 
-          interleaved_comments.each_with_index do |comment, index|
+          expected_order.each_with_index do |comment, index|
             expect(all_comments[index]).to have_content(comment.body["en"])
           end
-
-          expect(page).to have_css(".most-upvoted-label", text: "Most upvoted", count: 2)
         end
 
         resize_window_to_desktop
@@ -1285,31 +1302,36 @@ shared_examples "comments with two columns" do
   end
 
   context "when commentable is not closed" do
+    let!(:comments) { [] }
     let!(:oldest_in_favor_comment) { create(:comment, :in_favor, commentable:, created_at: 3.days.ago) }
     let!(:older_in_favor_comment) { create(:comment, :in_favor, commentable:, created_at: 2.days.ago) }
     let!(:oldest_against_comment) { create(:comment, :against, commentable:, created_at: 4.days.ago) }
     let!(:newer_against_comment) { create(:comment, :against, commentable:, created_at: 1.day.ago) }
 
-    it "shows the comments in two columns sorted by creation date in ascending order" do
+    it "shows the comments in two columns sorted by creation date in descending order" do
+      resize_window_to_desktop
       visit resource_path
 
       within(".comments-two-columns") do
-        check_comments_order(".comments-section__in-favor", [oldest_in_favor_comment, older_in_favor_comment])
-        check_comments_order(".comments-section__against", [oldest_against_comment, newer_against_comment])
+        check_comments_order(".comments-section__in-favor", [older_in_favor_comment, oldest_in_favor_comment])
+        check_comments_order(".comments-section__against", [newer_against_comment, oldest_against_comment])
       end
     end
 
-    it "allows the user to add a new comment at the end of the respective column" do
+    it "allows the user to add a new comment at the top of the respective column" do
+      resize_window_to_desktop
       visit resource_path
 
       add_new_comment("In favor", "This is a new comment in favor")
 
       within(".comments-section__in-favor") do
         expect(page).to have_content("This is a new comment in favor")
+        expect(first(".comment-thread")).to have_content("This is a new comment in favor")
       end
     end
 
     it "disables the publish button until 'in favor' or 'against' is selected" do
+      resize_window_to_desktop
       visit resource_path
 
       expect(page).to have_button("Publish comment", disabled: true)
@@ -1327,14 +1349,21 @@ shared_examples "comments with two columns" do
     it "shows comments sorted by creation date when viewed on a small screen" do
       resize_window_to_mobile
       visit resource_path
+      sleep 1
 
       within(".comment-threads") do
-        comments = all(".comment-thread")
+        expect(page).to have_css(".comment-thread", minimum: 4)
 
-        expect(comments[0]).to have_content(oldest_in_favor_comment.body["en"])
-        expect(comments[1]).to have_content(oldest_against_comment.body["en"])
-        expect(comments[2]).to have_content(older_in_favor_comment.body["en"])
-        expect(comments[3]).to have_content(newer_against_comment.body["en"])
+        expected_order = [
+          newer_against_comment,
+          older_in_favor_comment,
+          oldest_in_favor_comment,
+          oldest_against_comment
+        ]
+
+        expected_order.each_with_index do |comment, index|
+          expect(all(".comment-thread")[index]).to have_content(comment.body["en"])
+        end
       end
 
       resize_window_to_desktop
@@ -1356,25 +1385,26 @@ shared_examples "comments with two columns" do
     let!(:latest_comment_against) { create(:comment, :against, commentable:, created_at: 1.day.ago, up_votes_count: 1) }
 
     before do
+      resize_window_to_desktop
       visit resource_path
     end
 
-    it "shows the top voted comments at the top of each column, followed by comments in ascending chronological order" do
+    it "shows the top voted comments at the top of each column, followed by comments in descending chronological order" do
       within(".comments-two-columns") do
         check_comments_order(".comments-section__in-favor", [
                                highest_voted_comment_in_favor,
-                               high_voted_comment_in_favor,
-                               older_comment_in_favor,
+                               latest_comment_in_favor,
                                recent_comment_in_favor,
-                               latest_comment_in_favor
+                               older_comment_in_favor,
+                               high_voted_comment_in_favor
                              ])
 
         check_comments_order(".comments-section__against", [
                                highest_voted_comment_against,
-                               high_voted_comment_against,
-                               older_comment_against,
+                               latest_comment_against,
                                recent_comment_against,
-                               latest_comment_against
+                               older_comment_against,
+                               high_voted_comment_against
                              ])
       end
     end

data/lib/decidim/core/test/shared_examples/fingerprint_examples.rb

@@ -5,6 +5,7 @@ shared_examples "fingerprint" do
 
   it "shows a fingerprint" do
     visit(resource_locator(fingerprintable).path)
+    click_on("see other versions")
     click_on("Check fingerprint")
 
     within ".fingerprint-modal" do
@@ -19,6 +20,7 @@ shared_examples "consistent fingerprint" do
 
   it "shows the fingerprint source with correct spacing" do
     visit(resource_locator(fingerprintable).path)
+    click_on("see other versions")
     click_on("Check fingerprint")
 
     within ".fingerprint-modal" do

data/lib/decidim/core/test/shared_examples/has_members.rb

@@ -0,0 +1,63 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+shared_examples_for "has members" do
+  let(:factory_name) { described_class.name.demodulize.underscore.to_sym }
+
+  let!(:open_space) do
+    create(factory_name, access_mode: "open", published_at: Time.current)
+  end
+
+  let!(:restricted_space) do
+    create(factory_name, access_mode: "restricted", published_at: Time.current)
+  end
+
+  def create_space_member(space, user = create(:user, organization: space.organization))
+    Decidim::ParticipatorySpace::Member.create(participatory_space: space, user:)
+  end
+
+  describe ".public_spaces" do
+    let(:scope) { described_class.send(:public_spaces) }
+
+    it { expect(scope).to eq([open_space]) }
+  end
+
+  describe ".visible_for" do
+    let(:scope) { described_class.send(:visible_for, user) }
+
+    before { create_space_member(restricted_space) }
+
+    context "without user" do
+      let(:user) { nil }
+
+      it { expect(scope).to contain_exactly(open_space) }
+    end
+
+    context "with non-member" do
+      let(:user) { create(:user) }
+
+      it { expect(scope).to contain_exactly(open_space) }
+    end
+
+    context "with member" do
+      let(:user) { restricted_space.users.first }
+
+      it { expect(scope).to contain_exactly(open_space, restricted_space) }
+    end
+
+    context "when the space is both public and has members" do
+      # Visible spaces for non-member.
+      let(:user) { create(:user) }
+
+      before do
+        # Public space has multiple members.
+        create_space_member(open_space)
+        create_space_member(open_space)
+      end
+
+      # Expect no duplicate results.
+      it { expect(scope).to contain_exactly(open_space) }
+    end
+  end
+end

data/lib/decidim/core/test/shared_examples/has_space_in_mcell_examples.rb

@@ -8,7 +8,8 @@ shared_examples_for "has space in m-cell" do
     let(:show_space) { true }
 
     it "renders the space where the model belongs to" do
-      expect(cell_html).to have_content(decidim_escape_translated(model.component.participatory_space.title))
+      expect(cell_html).to have_content(translated_attribute(model.component.participatory_space.title))
+      expect(cell_html.to_s).to include(decidim_escape_translated(model.component.participatory_space.title).gsub(""", "\""))
     end
   end
 end

data/lib/decidim/core/test/shared_examples/manage_share_tokens_examples.rb

@@ -181,7 +181,7 @@ shared_examples "manage resource share tokens" do
         accept_confirm { click_on "Delete" }
       end
 
-      expect(page).to have_admin_callout("Access link successfully destroyed")
+      expect(page).to have_callout("Access link successfully destroyed")
       expect(page).to have_css("tbody tr", count: 2)
     end
   end

data/lib/decidim/core/test/shared_examples/map_examples.rb

@@ -205,7 +205,7 @@ shared_examples "a record with front-end geocoding address field" do |geocoded_m
     # the dummy test geocoding API defined at
     # `decidim-dev/lib/decidim/dev/test/map_server.rb`. Search for
     # `serve_autocomplete`.
-    expect(page).to have_content("successfully")
+    expect(page).to have_callout(geocoded_success_message)
     final = if geocoded_record
               geocoded_model.find(geocoded_record.id)
             else

data/lib/decidim/core/test/shared_examples/participant_details_examples.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+shared_examples "loggable participant details" do
+  it "returns the participant private details" do
+    expect(response["participantDetails"]).to include("email" => participant.email)
+    expect(response["participantDetails"]).to include("nickname" => participant.nickname)
+    expect(response["participantDetails"]).to include("name" => participant.name)
+  end
+
+  it "logs the action in action log" do
+    expect { response }.to change(Decidim::ActionLog, :count).by(1)
+    action_log = Decidim::ActionLog.last
+    expect(action_log.user).to eq(current_user)
+    expect(action_log.resource).to eq(participant)
+  end
+end

data/lib/decidim/core/test/shared_examples/participatory_space_members_page_examples.rb

@@ -1,9 +1,9 @@
 # frozen_string_literal: true
 
 shared_examples "participatory space members page examples" do
-  let(:user1) { create(:user, organization: privatable_to.organization) }
-  let(:user2) { create(:user, organization: privatable_to.organization) }
-  let(:user3) { create(:user, organization: privatable_to.organization) }
+  let(:user1) { create(:user, organization: participatory_space.organization) }
+  let(:user2) { create(:user, organization: participatory_space.organization) }
+  let(:user3) { create(:user, organization: participatory_space.organization) }
 
   before do
     request.env["decidim.current_organization"] = organization
@@ -12,19 +12,19 @@ shared_examples "participatory space members page examples" do
   describe "GET index" do
     context "when participatory space has no members" do
       it "redirects to 404" do
-        expect { get :index, params: { slug_param => slug } }
+        expect { get :index, params: { slug_param => slug, :locale => I18n.locale } }
           .to raise_error(ActionController::RoutingError)
       end
     end
 
     context "when participatory space has members" do
-      let!(:member1) { create(:participatory_space_private_user, privatable_to:, user: user1, published: true) }
-      let!(:member2) { create(:participatory_space_private_user, privatable_to:, user: user2, published: true) }
-      let!(:non_published) { create(:participatory_space_private_user, privatable_to:, user: user3, published: false) }
+      let!(:member1) { create(:member, participatory_space:, user: user1, published: true) }
+      let!(:member2) { create(:member, participatory_space:, user: user2, published: true) }
+      let!(:non_published) { create(:member, participatory_space:, user: user3, published: false) }
 
       context "when user has permissions" do
         it "displays list of members" do
-          get :index, params: { slug_param => slug }
+          get :index, params: { slug_param => slug, :locale => I18n.locale }
 
           expect(controller.helpers.collection).to contain_exactly(member1, member2)
         end
@@ -36,9 +36,9 @@ shared_examples "participatory space members page examples" do
         end
 
         it "redirects to participatory space path" do
-          get :index, params: { slug_param => slug }
+          get :index, params: { slug_param => slug, :locale => I18n.locale }
 
-          expect(response).to redirect_to(privatable_to)
+          expect(response).to redirect_to(destination_path)
         end
       end
     end