lighthouse 11.7.1 → 12.0.0

package/CONTRIBUTING.md

@@ -79,8 +79,8 @@ A PR adding or changing a gatherer almost always needs to include the following:
 1. **Golden artifacts**: `sample_v2.json` is generated from a set of artifacts that come from running LH against `dbw_tester.html`. Those artifacts likely need to be updated after gatherer changes with `yarn update:sample-artifacts`, but limit to just the artifact being altered if possible. For example:
 
    ```sh
-   # update just the ScriptElements artifact
-   yarn update:sample-artifacts ScriptElements
+   # update just the Scripts artifact
+   yarn update:sample-artifacts Scripts
    ```
 
    This command works for updating `yarn update:sample-artifacts DevtoolsLog` or `Trace` as well, but the resulting `sample_v2.json` churn may be extensive and you might be better off editing manually.

package/cli/bin.js

@@ -79,13 +79,6 @@ async function begin() {
     config = (await import(`../core/config/${cliFlags.preset}-config.js`)).default;
   }
 
-  if (cliFlags.budgetPath) {
-    cliFlags.budgetPath = path.resolve(process.cwd(), cliFlags.budgetPath);
-    /** @type {Array<LH.Budget>} */
-    const parsedBudget = JSON.parse(fs.readFileSync(cliFlags.budgetPath, 'utf8'));
-    cliFlags.budgets = parsedBudget;
-  }
-
   // set logging preferences
   cliFlags.logLevel = 'info';
   if (cliFlags.verbose) {

package/cli/cli-flags.d.ts

@@ -24,7 +24,7 @@ export function getYargsParser(manualArgv?: string | undefined): yargs.Argv<yarg
         default: boolean;
         describe: string;
     };
-}>, "port" | "screenEmulation" | "emulatedUserAgent" | "hostname" | "preset" | "save-assets" | "list-all-audits" | "list-locales" | "list-trace-categories" | "debug-navigation" | "additional-trace-categories" | "config-path" | "chrome-flags" | "form-factor" | "max-wait-for-load" | "enable-error-reporting" | "gather-mode" | "audit-mode" | "only-audits" | "only-categories" | "skip-audits" | "budget-path" | "disable-full-page-screenshot" | "ignore-status-code"> & yargs.InferredOptionTypes<{
+}>, "port" | "screenEmulation" | "emulatedUserAgent" | "hostname" | "preset" | "save-assets" | "list-all-audits" | "list-locales" | "list-trace-categories" | "debug-navigation" | "additional-trace-categories" | "config-path" | "chrome-flags" | "form-factor" | "max-wait-for-load" | "enable-error-reporting" | "gather-mode" | "audit-mode" | "only-audits" | "only-categories" | "skip-audits" | "disable-full-page-screenshot" | "ignore-status-code"> & yargs.InferredOptionTypes<{
     'save-assets': {
         type: "boolean";
         default: boolean;
@@ -125,10 +125,6 @@ export function getYargsParser(manualArgv?: string | undefined): yargs.Argv<yarg
         coerce: typeof splitCommaSeparatedValues;
         describe: string;
     };
-    'budget-path': {
-        type: "string";
-        describe: string;
-    };
     'disable-full-page-screenshot': {
         type: "boolean";
         describe: string;

package/cli/cli-flags.js

@@ -53,8 +53,8 @@ function getYargsParser(manualArgv) {
         'lighthouse <url> --extra-headers=./path/to/file.json',
         'Path to JSON file of HTTP Header key/value pairs to send in requests')
     .example(
-        'lighthouse <url> --only-categories=performance,pwa',
-        'Only run the specified categories. Available categories: accessibility, best-practices, performance, pwa, seo')
+        'lighthouse <url> --only-categories=performance,seo',
+        'Only run the specified categories. Available categories: accessibility, best-practices, performance, seo')
 
     // We only have the single string positional argument, the url.
     .option('_', {
@@ -188,7 +188,7 @@ function getYargsParser(manualArgv) {
         array: true,
         type: 'string',
         coerce: splitCommaSeparatedValues,
-        describe: 'Only run the specified categories. Available categories: accessibility, best-practices, performance, pwa, seo',
+        describe: 'Only run the specified categories. Available categories: accessibility, best-practices, performance, seo',
       },
       'skip-audits': {
         array: true,
@@ -196,10 +196,6 @@ function getYargsParser(manualArgv) {
         coerce: splitCommaSeparatedValues,
         describe: 'Run everything except these audits',
       },
-      'budget-path': {
-        type: 'string',
-        describe: 'The path to the budget.json file for LightWallet.',
-      },
       'disable-full-page-screenshot': {
         type: 'boolean',
         describe: 'Disables collection of the full page screenshot, which can be quite large',
@@ -213,7 +209,7 @@ function getYargsParser(manualArgv) {
       'save-assets', 'list-all-audits', 'list-locales', 'list-trace-categories', 'additional-trace-categories',
       'config-path', 'preset', 'chrome-flags', 'port', 'hostname', 'form-factor', 'screenEmulation', 'emulatedUserAgent',
       'max-wait-for-load', 'enable-error-reporting', 'gather-mode', 'audit-mode',
-      'only-audits', 'only-categories', 'skip-audits', 'budget-path', 'disable-full-page-screenshot', 'ignore-status-code',
+      'only-audits', 'only-categories', 'skip-audits', 'disable-full-page-screenshot', 'ignore-status-code',
     ], 'Configuration:')
 
     // Output

package/cli/test/smokehouse/__snapshots__/report-assert-test.js.snap

@@ -3,7 +3,7 @@
 exports[`getAssertionReport works (multiple failing) 1`] = `
 "X difference at cumulative-layout-shift audit.details.items.length
               expected: []
-                 found: [{\\"cumulativeLayoutShiftMainFrame\\":0.13570762803819444,\\"newEngineResult\\":{\\"cumulativeLayoutShift\\":0.13570762803819444,\\"cumulativeLayoutShiftMainFrame\\":0.13570762803819444},\\"newEngineResultDiffered\\":false}]
+                 found: [{\\"cumulativeLayoutShiftMainFrame\\":0.09957584751767748,\\"newEngineResult\\":{\\"cumulativeLayoutShift\\":0.09957584751767748,\\"cumulativeLayoutShiftMainFrame\\":0.09957584751767748},\\"newEngineResultDiffered\\":false}]
 
 
   X difference at cumulative-layout-shift audit.details.blah
@@ -15,11 +15,11 @@ exports[`getAssertionReport works (multiple failing) 1`] = `
         \\"id\\": \\"cumulative-layout-shift\\",
         \\"title\\": \\"Cumulative Layout Shift\\",
         \\"description\\": \\"Cumulative Layout Shift measures the movement of visible elements within the viewport. [Learn more about the Cumulative Layout Shift metric](https://web.dev/articles/cls).\\",
-        \\"score\\": 0.8,
+        \\"score\\": 0.9,
         \\"scoreDisplayMode\\": \\"numeric\\",
-        \\"numericValue\\": 0.13570762803819444,
+        \\"numericValue\\": 0.09957584751767748,
         \\"numericUnit\\": \\"unitless\\",
-        \\"displayValue\\": \\"0.136\\",
+        \\"displayValue\\": \\"0.1\\",
         \\"scoringOptions\\": {
           \\"p10\\": 0.1,
           \\"median\\": 0.25
@@ -28,10 +28,10 @@ exports[`getAssertionReport works (multiple failing) 1`] = `
           \\"type\\": \\"debugdata\\",
           \\"items\\": [
             {
-              \\"cumulativeLayoutShiftMainFrame\\": 0.13570762803819444,
+              \\"cumulativeLayoutShiftMainFrame\\": 0.09957584751767748,
               \\"newEngineResult\\": {
-                \\"cumulativeLayoutShift\\": 0.13570762803819444,
-                \\"cumulativeLayoutShiftMainFrame\\": 0.13570762803819444
+                \\"cumulativeLayoutShift\\": 0.09957584751767748,
+                \\"cumulativeLayoutShiftMainFrame\\": 0.09957584751767748
               },
               \\"newEngineResultDiffered\\": false
             }
@@ -43,18 +43,18 @@ exports[`getAssertionReport works (multiple failing) 1`] = `
 exports[`getAssertionReport works (trivial failing) 1`] = `
 "X difference at cumulative-layout-shift audit.details.items.length
               expected: []
-                 found: [{\\"cumulativeLayoutShiftMainFrame\\":0.13570762803819444,\\"newEngineResult\\":{\\"cumulativeLayoutShift\\":0.13570762803819444,\\"cumulativeLayoutShiftMainFrame\\":0.13570762803819444},\\"newEngineResultDiffered\\":false}]
+                 found: [{\\"cumulativeLayoutShiftMainFrame\\":0.09957584751767748,\\"newEngineResult\\":{\\"cumulativeLayoutShift\\":0.09957584751767748,\\"cumulativeLayoutShiftMainFrame\\":0.09957584751767748},\\"newEngineResultDiffered\\":false}]
 
           found result:
       {
         \\"id\\": \\"cumulative-layout-shift\\",
         \\"title\\": \\"Cumulative Layout Shift\\",
         \\"description\\": \\"Cumulative Layout Shift measures the movement of visible elements within the viewport. [Learn more about the Cumulative Layout Shift metric](https://web.dev/articles/cls).\\",
-        \\"score\\": 0.8,
+        \\"score\\": 0.9,
         \\"scoreDisplayMode\\": \\"numeric\\",
-        \\"numericValue\\": 0.13570762803819444,
+        \\"numericValue\\": 0.09957584751767748,
         \\"numericUnit\\": \\"unitless\\",
-        \\"displayValue\\": \\"0.136\\",
+        \\"displayValue\\": \\"0.1\\",
         \\"scoringOptions\\": {
           \\"p10\\": 0.1,
           \\"median\\": 0.25
@@ -63,10 +63,10 @@ exports[`getAssertionReport works (trivial failing) 1`] = `
           \\"type\\": \\"debugdata\\",
           \\"items\\": [
             {
-              \\"cumulativeLayoutShiftMainFrame\\": 0.13570762803819444,
+              \\"cumulativeLayoutShiftMainFrame\\": 0.09957584751767748,
               \\"newEngineResult\\": {
-                \\"cumulativeLayoutShift\\": 0.13570762803819444,
-                \\"cumulativeLayoutShiftMainFrame\\": 0.13570762803819444
+                \\"cumulativeLayoutShift\\": 0.09957584751767748,
+                \\"cumulativeLayoutShiftMainFrame\\": 0.09957584751767748
               },
               \\"newEngineResultDiffered\\": false
             }

package/cli/test/smokehouse/config/exclusions.js

@@ -20,11 +20,14 @@ const exclusions = {
     'redirects-client-paint-server', 'redirects-multiple-server',
     'redirects-single-server', 'redirects-single-client',
     'redirects-history-push-state', 'redirects-scripts',
+    'redirects-http',
     // Disabled because these tests use settings that cannot be fully configured in
     // DevTools (e.g. throttling method "provided").
     'metrics-tricky-tti', 'metrics-tricky-tti-late-fcp', 'screenshot',
     // Disabled because of differences that need further investigation
     'byte-efficiency', 'byte-gzip', 'perf-preload',
+    // Disabled because a renderer crash also breaks devtools frontend
+    'crash',
   ],
 };
 

package/cli/test/smokehouse/core-tests.js

@@ -7,12 +7,14 @@
 import a11y from './test-definitions/a11y.js';
 import byteEfficiency from './test-definitions/byte-efficiency.js';
 import byteGzip from './test-definitions/byte-gzip.js';
+import crash from './test-definitions/crash.js';
 import cspAllowAll from './test-definitions/csp-allow-all.js';
 import cspBlockAll from './test-definitions/csp-block-all.js';
 import dbw from './test-definitions/dobetterweb.js';
 import errorsExpiredSsl from './test-definitions/errors-expired-ssl.js';
 import errorsIframeExpiredSsl from './test-definitions/errors-iframe-expired-ssl.js';
 import errorsInfiniteLoop from './test-definitions/errors-infinite-loop.js';
+import fontSize from './test-definitions/font-size.js';
 import formsAutoComplete from './test-definitions/forms-autocomplete.js';
 import fpsMax from './test-definitions/fps-max.js';
 import fpsMaxPassive from './test-definitions/fps-max-passive.js';
@@ -31,12 +33,8 @@ import metricsDelayedFcp from './test-definitions/metrics-delayed-fcp.js';
 import metricsDelayedLcp from './test-definitions/metrics-delayed-lcp.js';
 import metricsTrickyTti from './test-definitions/metrics-tricky-tti.js';
 import metricsTrickyTtiLateFcp from './test-definitions/metrics-tricky-tti-late-fcp.js';
-import offlineOnlineOnly from './test-definitions/offline-online-only.js';
-import offlineReady from './test-definitions/offline-ready.js';
-import offlineSwBroken from './test-definitions/offline-sw-broken.js';
 import oopifRequests from './test-definitions/oopif-requests.js';
 import oopifScripts from './test-definitions/oopif-scripts.js';
-import perfBudgets from './test-definitions/perf-budgets.js';
 import perfDebug from './test-definitions/perf-debug.js';
 import perfDiagnosticsAnimations from './test-definitions/perf-diagnostics-animations.js';
 import perfDiagnosticsThirdParty from './test-definitions/perf-diagnostics-third-party.js';
@@ -45,13 +43,9 @@ import perfFonts from './test-definitions/perf-fonts.js';
 import perfFrameMetrics from './test-definitions/perf-frame-metrics.js';
 import perfPreload from './test-definitions/perf-preload.js';
 import perfTraceElements from './test-definitions/perf-trace-elements.js';
-import pwaAirhorner from './test-definitions/pwa-airhorner.js';
-import pwaCaltrain from './test-definitions/pwa-caltrain.js';
-import pwaChromestatus from './test-definitions/pwa-chromestatus.js';
-import pwaRocks from './test-definitions/pwa-rocks.js';
-import pwaSvgomg from './test-definitions/pwa-svgomg.js';
 import redirectsClientPaintServer from './test-definitions/redirects-client-paint-server.js';
 import redirectsHistoryPushState from './test-definitions/redirects-history-push-state.js';
+import redirectsHttp from './test-definitions/redirects-http.js';
 import redirectsMultipleServer from './test-definitions/redirects-multiple-server.js';
 import redirectsScripts from './test-definitions/redirects-scripts.js';
 import redirectsSelf from './test-definitions/redirects-self.js';
@@ -61,7 +55,6 @@ import screenshot from './test-definitions/screenshot.js';
 import seoFailing from './test-definitions/seo-failing.js';
 import seoPassing from './test-definitions/seo-passing.js';
 import seoStatus403 from './test-definitions/seo-status-403.js';
-import seoTapTargets from './test-definitions/seo-tap-targets.js';
 import serviceWorkerReloaded from './test-definitions/service-worker-reloaded.js';
 import shiftAttribution from './test-definitions/shift-attribution.js';
 import sourceMaps from './test-definitions/source-maps.js';
@@ -72,12 +65,14 @@ const smokeTests = [
   a11y,
   byteEfficiency,
   byteGzip,
+  crash,
   cspAllowAll,
   cspBlockAll,
   dbw,
   errorsExpiredSsl,
   errorsIframeExpiredSsl,
   errorsInfiniteLoop,
+  fontSize,
   formsAutoComplete,
   fpsMax,
   fpsMaxPassive,
@@ -96,12 +91,8 @@ const smokeTests = [
   metricsDelayedLcp,
   metricsTrickyTti,
   metricsTrickyTtiLateFcp,
-  offlineOnlineOnly,
-  offlineReady,
-  offlineSwBroken,
   oopifRequests,
   oopifScripts,
-  perfBudgets,
   perfDebug,
   perfDiagnosticsAnimations,
   perfDiagnosticsThirdParty,
@@ -110,13 +101,9 @@ const smokeTests = [
   perfFrameMetrics,
   perfPreload,
   perfTraceElements,
-  pwaAirhorner,
-  pwaCaltrain,
-  pwaChromestatus,
-  pwaRocks,
-  pwaSvgomg,
   redirectsClientPaintServer,
   redirectsHistoryPushState,
+  redirectsHttp,
   redirectsMultipleServer,
   redirectsScripts,
   redirectsSelf,
@@ -126,7 +113,6 @@ const smokeTests = [
   seoFailing,
   seoPassing,
   seoStatus403,
-  seoTapTargets,
   serviceWorkerReloaded,
   shiftAttribution,
   sourceMaps,

package/cli/test/smokehouse/frontends/smokehouse-bin.js

@@ -59,7 +59,7 @@ function getDefinitionsToRun(allTestDefns, requestedIds, excludedTests) {
   } else {
     smokes = allTestDefns.filter(test => {
       // Include all tests that *include* requested id.
-      // e.g. a requested 'pwa' will match 'pwa-airhorner', 'pwa-caltrain', etc
+      // e.g. a requested 'perf' will match 'perf-preload', 'perf-trace-elements', etc
       return requestedIds.some(requestedId => test.id.includes(requestedId));
     });
     console.log(`Running ONLY smoketests for: ${smokes.map(t => t.id).join(' ')}\n`);
@@ -125,7 +125,7 @@ async function begin() {
   const rawArgv = y
     .help('help')
     .usage('node $0 [<options>] <test-ids>')
-    .example('node $0 -j=1 pwa seo', 'run pwa and seo tests serially')
+    .example('node $0 -j=1 perf seo', 'run perf and seo tests serially')
     .option('_', {
       array: true,
       type: 'string',

package/core/audits/accessibility/aria-conditional-attr.d.ts

@@ -0,0 +1,10 @@
+export default AriaConditionalAttr;
+declare class AriaConditionalAttr extends AxeAudit {
+}
+export namespace UIStrings {
+    const title: string;
+    const failureTitle: string;
+    const description: string;
+}
+import AxeAudit from './axe-audit.js';
+//# sourceMappingURL=aria-conditional-attr.d.ts.map

package/core/audits/accessibility/aria-conditional-attr.js

@@ -0,0 +1,43 @@
+/**
+ * @license
+ * Copyright 2024 Google LLC
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+/**
+ * @fileoverview Ensures that ARIA attributes are used as specified for element roles.
+ * See base class in axe-audit.js for audit() implementation.
+ */
+
+import AxeAudit from './axe-audit.js';
+import * as i18n from '../../lib/i18n/i18n.js';
+
+const UIStrings = {
+  /** Title of an accessibility audit that checks if ARIA attributes are used as specified for element roles. This title is descriptive of the successful state and is shown to users when no user action is required. */
+  title: 'ARIA attributes are used as specified for the element\'s role',
+  /** Title of an accessibility audit that checks if ARIA attributes are used as specified for element roles. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */
+  failureTitle: 'ARIA attributes are not used as specified for the element\'s role',
+  /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */
+  description: 'Some ARIA attributes are only allowed on an element under certain conditions. ' +
+      '[Learn more about conditional ARIA attributes](https://dequeuniversity.com/rules/axe/4.9/aria-conditional-attr).',
+};
+
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
+
+class AriaConditionalAttr extends AxeAudit {
+  /**
+   * @return {LH.Audit.Meta}
+   */
+  static get meta() {
+    return {
+      id: 'aria-conditional-attr',
+      title: str_(UIStrings.title),
+      failureTitle: str_(UIStrings.failureTitle),
+      description: str_(UIStrings.description),
+      requiredArtifacts: ['Accessibility'],
+    };
+  }
+}
+
+export default AriaConditionalAttr;
+export {UIStrings};

package/core/audits/accessibility/{duplicate-id-active.d.ts → aria-deprecated-role.d.ts}

@@ -1,5 +1,5 @@
-export default DuplicateIdActive;
-declare class DuplicateIdActive extends AxeAudit {
+export default AriaDeprecatedRole;
+declare class AriaDeprecatedRole extends AxeAudit {
 }
 export namespace UIStrings {
     const title: string;
@@ -7,4 +7,4 @@ export namespace UIStrings {
     const description: string;
 }
 import AxeAudit from './axe-audit.js';
-//# sourceMappingURL=duplicate-id-active.d.ts.map
+//# sourceMappingURL=aria-deprecated-role.d.ts.map

package/core/audits/accessibility/aria-deprecated-role.js

@@ -0,0 +1,43 @@
+/**
+ * @license
+ * Copyright 2024 Google LLC
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+/**
+ * @fileoverview Ensures that deprecated ARIA roles are not used.
+ * See base class in axe-audit.js for audit() implementation.
+ */
+
+import AxeAudit from './axe-audit.js';
+import * as i18n from '../../lib/i18n/i18n.js';
+
+const UIStrings = {
+  /** Title of an accessibility audit that checks if deprecated ARIA roles are used. This title is descriptive of the successful state and is shown to users when no user action is required. */
+  title: 'Deprecated ARIA roles were not used',
+  /** Title of an accessibility audit that checks if deprecated ARIA roles are used. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */
+  failureTitle: 'Deprecated ARIA roles were used',
+  /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */
+  description: 'Deprecated ARIA roles may not be processed correctly by assistive technology. ' +
+      '[Learn more about deprecated ARIA roles](https://dequeuniversity.com/rules/axe/4.9/aria-deprecated-role).',
+};
+
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
+
+class AriaDeprecatedRole extends AxeAudit {
+  /**
+   * @return {LH.Audit.Meta}
+   */
+  static get meta() {
+    return {
+      id: 'aria-deprecated-role',
+      title: str_(UIStrings.title),
+      failureTitle: str_(UIStrings.failureTitle),
+      description: str_(UIStrings.description),
+      requiredArtifacts: ['Accessibility'],
+    };
+  }
+}
+
+export default AriaDeprecatedRole;
+export {UIStrings};

package/core/audits/accessibility/aria-prohibited-attr.d.ts

@@ -0,0 +1,10 @@
+export default AriaProhibitedAttr;
+declare class AriaProhibitedAttr extends AxeAudit {
+}
+export namespace UIStrings {
+    const title: string;
+    const failureTitle: string;
+    const description: string;
+}
+import AxeAudit from './axe-audit.js';
+//# sourceMappingURL=aria-prohibited-attr.d.ts.map

package/core/audits/accessibility/aria-prohibited-attr.js

@@ -0,0 +1,44 @@
+/**
+ * @license
+ * Copyright 2024 Google LLC
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+/**
+ * @fileoverview Ensures that deprecated ARIA roles are not used.
+ * See base class in axe-audit.js for audit() implementation.
+ */
+
+import AxeAudit from './axe-audit.js';
+import * as i18n from '../../lib/i18n/i18n.js';
+
+const UIStrings = {
+  /** Title of an accessibility audit that checks if elements use prohibited ARIA attributes. This title is descriptive of the successful state and is shown to users when no user action is required. */
+  title: 'Elements use only permitted ARIA attributes',
+  /** Title of an accessibility audit that checks if elements use prohibited ARIA attributes. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */
+  failureTitle: 'Elements use prohibited ARIA attributes',
+  /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */
+  description: 'Using ARIA attributes in roles where they are prohibited can mean that important ' +
+      'information is not communicated to users of assistive technologies. ' +
+      '[Learn more about prohibited ARIA roles](https://dequeuniversity.com/rules/axe/4.9/aria-prohibited-attr).',
+};
+
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
+
+class AriaProhibitedAttr extends AxeAudit {
+  /**
+   * @return {LH.Audit.Meta}
+   */
+  static get meta() {
+    return {
+      id: 'aria-prohibited-attr',
+      title: str_(UIStrings.title),
+      failureTitle: str_(UIStrings.failureTitle),
+      description: str_(UIStrings.description),
+      requiredArtifacts: ['Accessibility'],
+    };
+  }
+}
+
+export default AriaProhibitedAttr;
+export {UIStrings};

package/core/audits/accessibility/target-size.js

@@ -35,7 +35,6 @@ class TargetSize extends AxeAudit {
       title: str_(UIStrings.title),
       failureTitle: str_(UIStrings.failureTitle),
       description: str_(UIStrings.description),
-      scoreDisplayMode: AxeAudit.SCORING_MODES.INFORMATIVE,
       requiredArtifacts: ['Accessibility'],
     };
   }

package/core/audits/byte-efficiency/byte-efficiency-audit.d.ts

@@ -56,22 +56,6 @@ export class ByteEfficiencyAudit extends Audit {
         simulationBeforeChanges: LH.Gatherer.Simulation.Result;
         simulationAfterChanges: LH.Gatherer.Simulation.Result;
     };
-    /**
-     * Computes the estimated effect of all the byte savings on the maximum of the following:
-     *
-     * - end time of the last long task in the provided graph
-     * - (if includeLoad is true or not provided) end time of the last node in the graph
-     *
-     * @param {Array<LH.Audit.ByteEfficiencyItem>} results The array of byte savings results per resource
-     * @param {Node} graph
-     * @param {Simulator} simulator
-     * @param {{includeLoad?: boolean, providedWastedBytesByUrl?: Map<string, number>}=} options
-     * @return {number}
-     */
-    static computeWasteWithTTIGraph(results: Array<LH.Audit.ByteEfficiencyItem>, graph: Node, simulator: Simulator, options?: {
-        includeLoad?: boolean;
-        providedWastedBytesByUrl?: Map<string, number>;
-    } | undefined): number;
     /**
      * @param {ByteEfficiencyProduct} result
      * @param {Simulator} simulator

package/core/audits/byte-efficiency/byte-efficiency-audit.js

@@ -5,11 +5,9 @@
  */
 
 import {Audit} from '../audit.js';
-import {LanternInteractive} from '../../computed/metrics/lantern-interactive.js';
 import * as i18n from '../../lib/i18n/i18n.js';
 import {NetworkRecords} from '../../computed/network-records.js';
 import {LoadSimulator} from '../../computed/load-simulator.js';
-import {PageDependencyGraph} from '../../computed/page-dependency-graph.js';
 import {LanternLargestContentfulPaint} from '../../computed/metrics/lantern-largest-contentful-paint.js';
 import {LanternFirstContentfulPaint} from '../../computed/metrics/lantern-first-contentful-paint.js';
 import {LCPImageRecord} from '../../computed/lcp-image-record.js';
@@ -151,37 +149,6 @@ class ByteEfficiencyAudit extends Audit {
     };
   }
 
-  /**
-   * Computes the estimated effect of all the byte savings on the maximum of the following:
-   *
-   * - end time of the last long task in the provided graph
-   * - (if includeLoad is true or not provided) end time of the last node in the graph
-   *
-   * @param {Array<LH.Audit.ByteEfficiencyItem>} results The array of byte savings results per resource
-   * @param {Node} graph
-   * @param {Simulator} simulator
-   * @param {{includeLoad?: boolean, providedWastedBytesByUrl?: Map<string, number>}=} options
-   * @return {number}
-   */
-  static computeWasteWithTTIGraph(results, graph, simulator, options) {
-    options = Object.assign({includeLoad: true}, options);
-    const {savings: savingsOnOverallLoad, simulationBeforeChanges, simulationAfterChanges} =
-      this.computeWasteWithGraph(results, graph, simulator, {
-        ...options,
-        label: 'overallLoad',
-      });
-
-    const savingsOnTTI =
-      LanternInteractive.getLastLongTaskEndTime(simulationBeforeChanges.nodeTimings) -
-      LanternInteractive.getLastLongTaskEndTime(simulationAfterChanges.nodeTimings);
-
-    let savings = savingsOnTTI;
-    if (options.includeLoad) savings = Math.max(savings, savingsOnOverallLoad);
-
-    // Round waste to nearest 10ms
-    return Math.round(Math.max(savings, 0) / 10) * 10;
-  }
-
   /**
    * @param {ByteEfficiencyProduct} result
    * @param {Simulator} simulator
@@ -204,7 +171,6 @@ class ByteEfficiencyAudit extends Audit {
     // This is useful information in the LHR and should be preserved.
     let wastedMs;
     if (metricComputationInput.gatherContext.gatherMode === 'navigation') {
-      const graph = await PageDependencyGraph.request(metricComputationInput, context);
       const {
         optimisticGraph: optimisticFCPGraph,
       } = await LanternFirstContentfulPaint.request(metricComputationInput, context);
@@ -212,10 +178,6 @@ class ByteEfficiencyAudit extends Audit {
         optimisticGraph: optimisticLCPGraph,
       } = await LanternLargestContentfulPaint.request(metricComputationInput, context);
 
-      wastedMs = this.computeWasteWithTTIGraph(results, graph, simulator, {
-        providedWastedBytesByUrl: result.wastedBytesByUrl,
-      });
-
       const {savings: fcpSavings} = this.computeWasteWithGraph(
         results,
         optimisticFCPGraph,
@@ -243,6 +205,7 @@ class ByteEfficiencyAudit extends Audit {
 
       metricSavings.FCP = fcpSavings;
       metricSavings.LCP = Math.max(lcpGraphSavings, lcpRecordSavings);
+      wastedMs = metricSavings.LCP;
     } else {
       wastedMs = simulator.computeWastedMsFromWastedBytes(wastedBytes);
     }

package/core/audits/byte-efficiency/offscreen-images.d.ts

@@ -47,17 +47,6 @@ declare class OffscreenImages extends ByteEfficiencyAudit {
      * @param {number} interactiveTimestamp
      */
     static filterObservedResults(images: WasteResult[], interactiveTimestamp: number): WasteResult[];
-    /**
-     * The default byte efficiency audit will report max(TTI, load), since lazy-loading offscreen
-     * images won't reduce the overall time and the wasted bytes are really only "wasted" for TTI,
-     * override the function to just look at TTI savings.
-     *
-     * @param {Array<LH.Audit.ByteEfficiencyItem>} results
-     * @param {LH.Gatherer.Simulation.GraphNode} graph
-     * @param {LH.Gatherer.Simulation.Simulator} simulator
-     * @return {number}
-     */
-    static computeWasteWithTTIGraph(results: Array<LH.Audit.ByteEfficiencyItem>, graph: LH.Gatherer.Simulation.GraphNode, simulator: LH.Gatherer.Simulation.Simulator): number;
     /**
      * @param {LH.Artifacts} artifacts
      * @param {Array<LH.Artifacts.NetworkRequest>} networkRecords

package/core/audits/byte-efficiency/offscreen-images.js

@@ -156,21 +156,6 @@ class OffscreenImages extends ByteEfficiencyAudit {
     });
   }
 
-  /**
-   * The default byte efficiency audit will report max(TTI, load), since lazy-loading offscreen
-   * images won't reduce the overall time and the wasted bytes are really only "wasted" for TTI,
-   * override the function to just look at TTI savings.
-   *
-   * @param {Array<LH.Audit.ByteEfficiencyItem>} results
-   * @param {LH.Gatherer.Simulation.GraphNode} graph
-   * @param {LH.Gatherer.Simulation.Simulator} simulator
-   * @return {number}
-   */
-  static computeWasteWithTTIGraph(results, graph, simulator) {
-    return super.computeWasteWithTTIGraph(results, graph, simulator,
-      {includeLoad: false});
-  }
-
   /**
    * @param {LH.Artifacts} artifacts
    * @param {Array<LH.Artifacts.NetworkRequest>} networkRecords