@windyroad/itil 0.61.1 → 0.61.2

package/hooks/test/itil-mid-loop-ask-detect.bats

@@ -1,220 +0,0 @@
-#!/usr/bin/env bats
-
-# P132 Phase 2b: itil-mid-loop-ask-detect.sh Stop hook detects
-# orchestrator main-turn AskUserQuestion calls fired mid-loop inside
-# /wr-itil:work-problems — the regression class P132 captures
-# (2026-05-17 reopen: orchestrator asked iter-target selection between
-# iters 3 and 4; halted the loop for hours of AFK time).
-#
-# Detection signal:
-#   1. Last assistant turn contains an AskUserQuestion tool_use
-#   2. Earlier transcript contains a Skill tool_use to wr-itil:work-problems
-#   3. No `ALL_DONE` / `## Work Problems Summary` marker has been emitted
-#      since the skill activation (mid-loop, not post-loop wrap)
-#
-# When all three match the hook emits a structured `stopReason`
-# advisory citing P130 + the Mid-loop ask discipline subsection of
-# work-problems SKILL.md. Advisory only — never blocks. Mirrors the
-# itil-assistant-output-review.sh Stop hook precedent (P085 prose-ask
-# detection) but on a different signal class.
-#
-# Per ADR-005 / ADR-052 — bats live under packages/<plugin>/hooks/test/
-# and assert behaviour on emitted JSON, not source-content. Per
-# feedback_behavioural_tests.md (P081) — no source-grep on hook text.
-
-setup() {
-  REPO_ROOT="$(cd "$(dirname "$BATS_TEST_FILENAME")/../../../.." && pwd)"
-  HOOK="$REPO_ROOT/packages/itil/hooks/itil-mid-loop-ask-detect.sh"
-  TMPDIR_="$(mktemp -d)"
-  TRANSCRIPT="$TMPDIR_/transcript.jsonl"
-}
-
-teardown() {
-  rm -rf "$TMPDIR_"
-}
-
-# Helper: emit the JSONL transcript line for an assistant turn
-# containing a Skill tool_use to wr-itil:work-problems.
-emit_orchestrator_activation() {
-  cat <<'JSON'
-{"type":"assistant","message":{"role":"assistant","content":[{"type":"tool_use","name":"Skill","input":{"skill":"wr-itil:work-problems"}}]}}
-JSON
-}
-
-# Helper: emit a benign assistant text turn (no tool_use).
-emit_text_turn() {
-  local text="$1"
-  printf '{"type":"assistant","message":{"role":"assistant","content":[{"type":"text","text":%s}]}}\n' \
-    "$(printf '%s' "$text" | jq -Rs .)"
-}
-
-# Helper: emit an assistant turn containing an AskUserQuestion tool_use.
-emit_ask_turn() {
-  local header="${1:-Next problem}"
-  cat <<JSON
-{"type":"assistant","message":{"role":"assistant","content":[{"type":"tool_use","name":"AskUserQuestion","input":{"questions":[{"question":"Pick next iter","header":"${header}","options":[{"label":"A","description":"x"},{"label":"B","description":"y"}]}]}}]}}
-JSON
-}
-
-run_hook() {
-  echo "{\"session_id\":\"mid-loop-test\",\"transcript_path\":$(printf '%s' "$TRANSCRIPT" | jq -Rs .)}" | bash "$HOOK"
-}
-
-# --- Positive detection ---
-
-@test "detect: orchestrator activation + final AskUserQuestion + no terminal marker emits stopReason" {
-  {
-    printf '{"type":"user","message":{"role":"user","content":"/wr-itil:work-problems"}}\n'
-    emit_orchestrator_activation
-    emit_text_turn "Iter 1 complete. Dispatching iter 2."
-    emit_text_turn "Iter 2 complete. Dispatching iter 3."
-    emit_ask_turn "Pick next iter"
-  } > "$TRANSCRIPT"
-  run run_hook
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"stopReason"* ]]
-}
-
-@test "detect: stopReason cites P130 + framework-prescribed halt points" {
-  {
-    printf '{"type":"user","message":{"role":"user","content":"/wr-itil:work-problems"}}\n'
-    emit_orchestrator_activation
-    emit_text_turn "Iter 1 done."
-    emit_ask_turn "Next problem"
-  } > "$TRANSCRIPT"
-  run run_hook
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"P130"* ]]
-  [[ "$output" == *"halt point"* ]]
-  [[ "$output" == *"outstanding_questions"* ]]
-}
-
-@test "detect: stopReason cites ADR-044 framework-resolution boundary" {
-  {
-    printf '{"type":"user","message":{"role":"user","content":"/wr-itil:work-problems"}}\n'
-    emit_orchestrator_activation
-    emit_text_turn "Iter 1 done."
-    emit_ask_turn "Pick"
-  } > "$TRANSCRIPT"
-  run run_hook
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"ADR-044"* ]]
-}
-
-# --- Negative paths: silent exit ---
-
-@test "allow: transcript with no orchestrator activation exits silently" {
-  # User asked a question outside /wr-itil:work-problems context;
-  # AskUserQuestion in this case is unrelated to mid-loop discipline.
-  {
-    printf '{"type":"user","message":{"role":"user","content":"help me design a feature"}}\n'
-    emit_text_turn "Two paths come to mind."
-    emit_ask_turn "Design choice"
-  } > "$TRANSCRIPT"
-  run run_hook
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"stopReason"* ]]
-}
-
-@test "allow: orchestrator activated then ALL_DONE emitted (post-loop wrap)" {
-  # The orchestrator has emitted its terminal summary; subsequent
-  # AskUserQuestion is post-loop interactive follow-up, not mid-loop.
-  {
-    printf '{"type":"user","message":{"role":"user","content":"/wr-itil:work-problems"}}\n'
-    emit_orchestrator_activation
-    emit_text_turn "Iter 1 complete."
-    emit_text_turn "## Work Problems Summary
-All iters complete.
-ALL_DONE"
-    emit_ask_turn "Follow-up question"
-  } > "$TRANSCRIPT"
-  run run_hook
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"stopReason"* ]]
-}
-
-@test "allow: orchestrator activated then Work Problems Summary header emitted (post-loop)" {
-  {
-    printf '{"type":"user","message":{"role":"user","content":"/wr-itil:work-problems"}}\n'
-    emit_orchestrator_activation
-    emit_text_turn "## Work Problems Summary
-
-Completed: 3 iters."
-    emit_ask_turn "Next steps?"
-  } > "$TRANSCRIPT"
-  run run_hook
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"stopReason"* ]]
-}
-
-@test "allow: last assistant turn does not contain AskUserQuestion" {
-  {
-    printf '{"type":"user","message":{"role":"user","content":"/wr-itil:work-problems"}}\n'
-    emit_orchestrator_activation
-    emit_text_turn "Iter 2 dispatched."
-  } > "$TRANSCRIPT"
-  run run_hook
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"stopReason"* ]]
-}
-
-@test "allow: missing transcript_path exits silently" {
-  run bash -c 'echo "{\"session_id\":\"sid\"}" | bash "$1"' -- "$HOOK"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"stopReason"* ]]
-}
-
-@test "allow: non-existent transcript file exits silently" {
-  run bash -c "echo '{\"session_id\":\"sid\",\"transcript_path\":\"/tmp/does-not-exist-$RANDOM\"}' | bash '$HOOK'"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"stopReason"* ]]
-}
-
-@test "allow: empty transcript exits silently" {
-  : > "$TRANSCRIPT"
-  run run_hook
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"stopReason"* ]]
-}
-
-@test "allow: malformed JSONL lines do not crash the hook" {
-  {
-    echo "not-json"
-    emit_orchestrator_activation
-    emit_text_turn "Iter 2"
-  } > "$TRANSCRIPT"
-  run run_hook
-  [ "$status" -eq 0 ]
-  # Either silent OR stopReason — but never a crash. We assert no
-  # non-zero exit; the silent-vs-stopReason split is incidental here.
-}
-
-# --- Advisory budget per ADR-045 ---
-
-@test "advisory output stays under ADR-045 800-byte honour-system band" {
-  {
-    printf '{"type":"user","message":{"role":"user","content":"/wr-itil:work-problems"}}\n'
-    emit_orchestrator_activation
-    emit_text_turn "Iter 1 done."
-    emit_ask_turn "Pick"
-  } > "$TRANSCRIPT"
-  run run_hook
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"stopReason"* ]]
-  [ "${#output}" -lt 1000 ]
-}
-
-# --- Distinguishing-marker: tool_name for AskUserQuestion --
-
-@test "detect: matches even when AskUserQuestion is intermixed with text blocks" {
-  {
-    printf '{"type":"user","message":{"role":"user","content":"/wr-itil:work-problems"}}\n'
-    emit_orchestrator_activation
-    cat <<'JSON'
-{"type":"assistant","message":{"role":"assistant","content":[{"type":"text","text":"Two iter targets are tied on WSJF:"},{"type":"tool_use","name":"AskUserQuestion","input":{"questions":[{"question":"Pick next iter","header":"Next iter","options":[{"label":"P132","description":"x"},{"label":"P130","description":"y"}]}]}}]}}
-JSON
-  } > "$TRANSCRIPT"
-  run run_hook
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"stopReason"* ]]
-}

package/hooks/test/itil-no-implement-draft-gate.bats

@@ -1,210 +0,0 @@
-#!/usr/bin/env bats
-# Behavioural tests for itil-no-implement-draft-gate.sh (ADR-096 / P404).
-# PreToolUse:Bash — reads a JSON envelope on stdin, emits permissionDecision:deny
-# (exit 0, deny in the JSON) when a commit references a DRAFT story.
-# @adr ADR-096  @adr ADR-052  @problem P404
-
-setup() {
-  HOOK="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)/itil-no-implement-draft-gate.sh"
-  MARK="$(cd "$(dirname "$BATS_TEST_FILENAME")/../../scripts" && pwd)/mark-story-oversight-confirmed.sh"
-  TMP="$(mktemp -d)"; cd "$TMP"; git init -q .
-  mkdir -p docs/stories/draft docs/stories/accepted docs/stories/in-progress
-}
-
-# Seed a minimally well-formed story. Since ADR-101 the gate is ratification-
-# aware, so a bare `touch` no longer produces a story it will pass.
-seed_story() { printf -- '---\nstatus: accepted\n---\n\n# %s\n' "$1" > "$2"; }
-# Ratify via the real write path, never a hand-written marker — the hash has one
-# definition and a hand-rolled fixture would drift from it.
-ratify() { bash "$MARK" "$@" >/dev/null 2>&1; }
-teardown() { cd /; rm -rf "$TMP"; }
-
-# write env.json carrying the given command string
-env_cmd() { python3 -c 'import json,sys; open("env.json","w").write(json.dumps({"tool_name":"Bash","tool_input":{"command":sys.argv[1]}}))' "$1"; }
-
-@test "blocks a commit referencing a DRAFT story" {
-  touch docs/stories/draft/STORY-042-foo.md
-  env_cmd 'git commit -m "fix: thing
-
-Refs: STORY-042"'
-  run bash -c "bash '$HOOK' < env.json"
-  [ "$status" -eq 0 ]
-  echo "$output" | grep -q '"permissionDecision": "deny"'
-  echo "$output" | grep -q 'STORY-042'
-}
-
-# This case previously seeded an EMPTY, unratified accepted story and asserted
-# allow — the P465 hole encoded as a test rather than behaviour anyone chose.
-# ADR-096 always claimed no unratified story could be implemented; nothing
-# enforced it. Split into both directions, flipped in the slice that ships the
-# behaviour (the ADR-089 precedent).
-
-@test "allows a commit referencing an ACCEPTED and RATIFIED story" {
-  seed_story STORY-042 docs/stories/accepted/STORY-042-foo.md
-  ratify docs/stories/accepted/STORY-042-foo.md
-  env_cmd 'git commit -m "fix: thing
-
-Refs: STORY-042"'
-  run bash -c "bash '$HOOK' < env.json"
-  [ "$status" -eq 0 ]
-  ! echo "$output" | grep -q 'deny'
-}
-
-@test "blocks a commit referencing an ACCEPTED but UNRATIFIED story (P465)" {
-  seed_story STORY-042 docs/stories/accepted/STORY-042-foo.md
-  env_cmd 'git commit -m "fix: thing
-
-Refs: STORY-042"'
-  run bash -c "bash '$HOOK' < env.json"
-  [ "$status" -eq 0 ]
-  echo "$output" | grep -q '"permissionDecision": "deny"'
-  echo "$output" | grep -q 'not ratified'
-}
-
-@test "blocks a commit referencing an IN-PROGRESS story whose content has drifted since ratification" {
-  seed_story STORY-042 docs/stories/in-progress/STORY-042-foo.md
-  ratify docs/stories/in-progress/STORY-042-foo.md
-  printf -- '\nA substance edit made after ratification.\n' >> docs/stories/in-progress/STORY-042-foo.md
-  env_cmd 'git commit -m "fix: thing
-
-Refs: STORY-042"'
-  run bash -c "bash '$HOOK' < env.json"
-  [ "$status" -eq 0 ]
-  echo "$output" | grep -q '"permissionDecision": "deny"'
-}
-
-@test "ticking an acceptance criterion is progress, not drift — commit still allowed" {
-  cat > docs/stories/in-progress/STORY-042-foo.md <<'EOF'
----
-status: in-progress
----
-
-# STORY-042
-
-## Acceptance criteria (accepted-gate, INVEST Testable)
-
-- [ ] The step happens.
-EOF
-  ratify docs/stories/in-progress/STORY-042-foo.md
-  sed -i.bak 's/- \[ \] The step happens./- [x] The step happens./' docs/stories/in-progress/STORY-042-foo.md
-  rm -f docs/stories/in-progress/*.bak
-  env_cmd 'git commit -m "fix: thing
-
-Refs: STORY-042"'
-  run bash -c "bash '$HOOK' < env.json"
-  [ "$status" -eq 0 ]
-  ! echo "$output" | grep -q 'deny'
-}
-
-@test "ADR-101: a pure-decomposition story whose basis no longer matches its criteria is blocked" {
-  cat > docs/stories/accepted/STORY-042-foo.md <<'EOF'
----
-status: accepted
-afk-accept: pure-decomposition
----
-
-# STORY-042
-
-## Acceptance criteria (accepted-gate, INVEST Testable)
-
-- [ ] One.
-- [ ] Two.
-
-## Decomposition basis
-
-- One decomposes ADR-900.
-EOF
-  bash "$MARK" --pure-decomposition docs/stories/accepted/STORY-042-foo.md >/dev/null 2>&1
-  env_cmd 'git commit -m "fix: thing
-
-Refs: STORY-042"'
-  run bash -c "bash '$HOOK' < env.json"
-  [ "$status" -eq 0 ]
-  echo "$output" | grep -q '"permissionDecision": "deny"'
-  echo "$output" | grep -q 'Decomposition basis'
-}
-
-@test "ADR-101: a well-formed pure-decomposition story is allowed" {
-  cat > docs/stories/accepted/STORY-042-foo.md <<'EOF'
----
-status: accepted
-afk-accept: pure-decomposition
----
-
-# STORY-042
-
-## Acceptance criteria (accepted-gate, INVEST Testable)
-
-- [ ] One.
-- [ ] Two.
-
-## Decomposition basis
-
-- One decomposes ADR-900.
-- Two decomposes ADR-900.
-EOF
-  bash "$MARK" --pure-decomposition docs/stories/accepted/STORY-042-foo.md >/dev/null 2>&1
-  env_cmd 'git commit -m "fix: thing
-
-Refs: STORY-042"'
-  run bash -c "bash '$HOOK' < env.json"
-  [ "$status" -eq 0 ]
-  ! echo "$output" | grep -q 'deny'
-}
-
-@test "a DONE story is past implementation and is not ratification-gated" {
-  mkdir -p docs/stories/done
-  touch docs/stories/done/STORY-042-foo.md
-  env_cmd 'git commit -m "fix: thing
-
-Refs: STORY-042"'
-  run bash -c "bash '$HOOK' < env.json"
-  [ "$status" -eq 0 ]
-  ! echo "$output" | grep -q 'deny'
-}
-
-@test "exempts a capture commit even for a draft story" {
-  touch docs/stories/draft/STORY-042-foo.md
-  env_cmd 'git commit -m "feat(itil): capture STORY-042 foo
-
-Refs: STORY-042"'
-  run bash -c "bash '$HOOK' < env.json"
-  [ "$status" -eq 0 ]
-  ! echo "$output" | grep -q 'deny'
-}
-
-@test "bootstrap-exempt commit bypasses" {
-  touch docs/stories/draft/STORY-042-foo.md
-  env_cmd 'git commit -m "migrate
-
-Refs: STORY-042
-bootstrap-exempt: STORY-MAP-001"'
-  run bash -c "bash '$HOOK' < env.json"
-  [ "$status" -eq 0 ]
-  ! echo "$output" | grep -q 'deny'
-}
-
-@test "non-commit command is a no-op" {
-  touch docs/stories/draft/STORY-042-foo.md
-  env_cmd 'echo Refs: STORY-042'
-  run bash -c "bash '$HOOK' < env.json"
-  [ "$status" -eq 0 ]
-  ! echo "$output" | grep -q 'deny'
-}
-
-@test "commit with no story trailer is a no-op" {
-  env_cmd 'git commit -m "fix: no story ref"'
-  run bash -c "bash '$HOOK' < env.json"
-  [ "$status" -eq 0 ]
-  ! echo "$output" | grep -q 'deny'
-}
-
-@test "BYPASS env allows the commit" {
-  touch docs/stories/draft/STORY-042-foo.md
-  env_cmd 'git commit -m "fix
-
-Refs: STORY-042"'
-  BYPASS_NO_IMPLEMENT_DRAFT=1 run bash -c "BYPASS_NO_IMPLEMENT_DRAFT=1 bash '$HOOK' < env.json"
-  [ "$status" -eq 0 ]
-  ! echo "$output" | grep -q 'deny'
-}