@windyroad/itil 0.61.1 → 0.61.2

package/skills/manage-incident/test/manage-incident.bats

@@ -1,171 +0,0 @@
-#!/usr/bin/env bats
-# Functional tests for the manage-incident skill (Option A-lite per ADR-011).
-#
-# Scope: execute the bash fragments the SKILL.md instructs Claude to run
-# (ID assignment, file-path construction, directory creation) and assert on
-# the mocked Skill-tool handoff contract between manage-incident and
-# manage-problem. Source-grep assertions on SKILL.md prose are NOT used
-# (P011 ban). A single structural check asserts SKILL.md exists and has
-# frontmatter — file-existence checks are a Permitted Exception per ADR-005.
-
-setup() {
-  SKILL_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)"
-  SKILL_FILE="${SKILL_DIR}/SKILL.md"
-
-  TEST_ROOT="$(mktemp -d "${TMPDIR:-/tmp}/manage-incident-bats-XXXXXX")"
-  INCIDENTS_DIR="${TEST_ROOT}/docs/incidents"
-  PROBLEMS_DIR="${TEST_ROOT}/docs/problems"
-}
-
-teardown() {
-  rm -rf "$TEST_ROOT"
-}
-
-# --- Fragment: next-ID computation (I###) ---
-# SKILL.md instructs: scan docs/incidents/ for existing I<NNN> files, take the
-# highest numeric ID, increment by 1, zero-pad to 3 digits.
-next_incident_id() {
-  local dir="$1"
-  local last
-  last=$(ls "$dir"/I*.md 2>/dev/null | sed 's/.*\///' | grep -oE '^I[0-9]+' | sed 's/^I//' | sort -n | tail -1)
-  if [[ -z "$last" ]]; then
-    printf 'I001'
-  else
-    printf 'I%03d' $((10#$last + 1))
-  fi
-}
-
-# --- Fragment: file path construction ---
-incident_path() {
-  local dir="$1" id="$2" slug="$3" status="$4"
-  printf '%s/%s-%s.%s.md' "$dir" "$id" "$slug" "$status"
-}
-
-# --- Mock: Skill-tool invocation contract ---
-# The SKILL.md instructs Claude to invoke wr-itil:manage-problem via the
-# Skill tool on restoration. The contract (skill name + argument shape) is
-# asserted by a mock that writes the payload to a file the test reads back.
-invoke_skill_mock() {
-  local tool="$1" skill="$2" args="$3"
-  printf '%s\n%s\n%s\n' "$tool" "$skill" "$args" > "${TEST_ROOT}/skill-invocation.log"
-}
-
-# ---- Tests ----
-
-@test "SKILL.md exists and has frontmatter" {
-  [ -f "$SKILL_FILE" ]
-  run head -1 "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  [ "$output" = "---" ]
-}
-
-@test "next_incident_id returns I001 when docs/incidents is empty" {
-  mkdir -p "$INCIDENTS_DIR"
-  run next_incident_id "$INCIDENTS_DIR"
-  [ "$status" -eq 0 ]
-  [ "$output" = "I001" ]
-}
-
-@test "next_incident_id returns I001 when docs/incidents does not exist" {
-  run next_incident_id "$INCIDENTS_DIR"
-  [ "$status" -eq 0 ]
-  [ "$output" = "I001" ]
-}
-
-@test "next_incident_id increments past the highest existing ID" {
-  mkdir -p "$INCIDENTS_DIR"
-  : > "$INCIDENTS_DIR/I001-foo.closed.md"
-  : > "$INCIDENTS_DIR/I002-bar.restored.md"
-  : > "$INCIDENTS_DIR/I005-baz.investigating.md"
-  run next_incident_id "$INCIDENTS_DIR"
-  [ "$status" -eq 0 ]
-  [ "$output" = "I006" ]
-}
-
-@test "next_incident_id zero-pads three digits" {
-  mkdir -p "$INCIDENTS_DIR"
-  : > "$INCIDENTS_DIR/I098-foo.closed.md"
-  run next_incident_id "$INCIDENTS_DIR"
-  [ "$status" -eq 0 ]
-  [ "$output" = "I099" ]
-}
-
-@test "next_incident_id ignores non-incident files" {
-  mkdir -p "$INCIDENTS_DIR"
-  : > "$INCIDENTS_DIR/README.md"
-  : > "$INCIDENTS_DIR/notes.md"
-  run next_incident_id "$INCIDENTS_DIR"
-  [ "$status" -eq 0 ]
-  [ "$output" = "I001" ]
-}
-
-@test "incident_path builds investigating file path" {
-  run incident_path "$INCIDENTS_DIR" "I001" "login-500s" "investigating"
-  [ "$status" -eq 0 ]
-  [ "$output" = "${INCIDENTS_DIR}/I001-login-500s.investigating.md" ]
-}
-
-@test "incident_path supports all lifecycle suffixes" {
-  for suffix in investigating mitigating restored closed; do
-    run incident_path "$INCIDENTS_DIR" "I042" "x" "$suffix"
-    [ "$status" -eq 0 ]
-    [ "$output" = "${INCIDENTS_DIR}/I042-x.${suffix}.md" ]
-  done
-}
-
-@test "docs/incidents is auto-created on first declaration" {
-  [ ! -d "$INCIDENTS_DIR" ]
-  mkdir -p "$INCIDENTS_DIR"
-  [ -d "$INCIDENTS_DIR" ]
-  id=$(next_incident_id "$INCIDENTS_DIR")
-  path=$(incident_path "$INCIDENTS_DIR" "$id" "test" "investigating")
-  : > "$path"
-  [ -f "$path" ]
-}
-
-@test "restore handoff invokes Skill tool with wr-itil:manage-problem and payload" {
-  invoke_skill_mock "Skill" "wr-itil:manage-problem" "incident I001 login-500s — rollback v1.4.3 restored service at 14:30 UTC"
-  [ -f "${TEST_ROOT}/skill-invocation.log" ]
-  run cat "${TEST_ROOT}/skill-invocation.log"
-  [ "$status" -eq 0 ]
-  [ "${lines[0]}" = "Skill" ]
-  [ "${lines[1]}" = "wr-itil:manage-problem" ]
-  [[ "${lines[2]}" == *"I001"* ]]
-  [[ "${lines[2]}" == *"rollback"* ]]
-}
-
-@test "restore handoff payload carries incident ID and mitigation" {
-  invoke_skill_mock "Skill" "wr-itil:manage-problem" "incident I042 — mitigation: feature flag off — verified via Datadog"
-  run cat "${TEST_ROOT}/skill-invocation.log"
-  [[ "${lines[2]}" == *"I042"* ]]
-  [[ "${lines[2]}" == *"feature flag off"* ]]
-  [[ "${lines[2]}" == *"Datadog"* ]]
-}
-
-@test "handoff contract rejects invocation with wrong skill name" {
-  invoke_skill_mock "Skill" "wr-itil:manage-change" "incident I001"
-  run grep -c '^wr-itil:manage-problem$' "${TEST_ROOT}/skill-invocation.log"
-  [ "$output" = "0" ]
-}
-
-@test "close is blocked when linked problem file is .open.md" {
-  mkdir -p "$PROBLEMS_DIR"
-  : > "$PROBLEMS_DIR/P050-root.open.md"
-  # close-gate: close only if linked P### is known-error or closed
-  linked=$(ls "$PROBLEMS_DIR"/P050-*.md 2>/dev/null | head -1)
-  [[ "$linked" != *".known-error.md" && "$linked" != *".closed.md" ]]
-}
-
-@test "close is allowed when linked problem file is .known-error.md" {
-  mkdir -p "$PROBLEMS_DIR"
-  : > "$PROBLEMS_DIR/P050-root.known-error.md"
-  linked=$(ls "$PROBLEMS_DIR"/P050-*.md 2>/dev/null | head -1)
-  [[ "$linked" == *".known-error.md" || "$linked" == *".closed.md" ]]
-}
-
-@test "close is allowed when linked problem file is .closed.md" {
-  mkdir -p "$PROBLEMS_DIR"
-  : > "$PROBLEMS_DIR/P050-root.closed.md"
-  linked=$(ls "$PROBLEMS_DIR"/P050-*.md 2>/dev/null | head -1)
-  [[ "$linked" == *".known-error.md" || "$linked" == *".closed.md" ]]
-}

package/skills/manage-problem/test/manage-problem-adr-044-step4-derive-first.bats

@@ -1,151 +0,0 @@
-#!/usr/bin/env bats
-# ADR-044 alignment contract assertions for manage-problem SKILL.md
-# Step 4 (P132 Phase 2a-ii derive-first refactor, 2026-05-15).
-#
-# tdd-review: structural-permitted (justification: SKILL.md prose contract
-# assertions; behavioural skill-runtime harness pending P012 + P081 Phase 2;
-# expected to migrate to behavioural form once the harness exists. Added
-# during P132 Phase 2a-ii per the inline plan's bridge-marker rule —
-# isomorphic precedent at manage-incident-adr-044-contract.bats Surface 2.)
-#
-# This file is the dedicated structural-grep-permitted home for the ADR-044
-# alignment contract during the bridge window. After P081 Phase 2 retrofits
-# the project's structural-grep tests to behavioural form, this file's
-# assertions migrate too.
-#
-# @problem P132 (agents over-ask in interactive sessions — Phase 2a-ii
-#   manage-problem create flow derive-first refactor)
-# @problem P185 (capture-problem Step 1.5 worked-example precedent)
-# @problem P136 (ADR-044 alignment audit master)
-# @adr ADR-044 (Decision-Delegation Contract)
-# @adr ADR-013 amended Rule 1 (structured user interaction)
-# @adr ADR-026 (cost-source grounding — stderr advisory shape)
-# @adr ADR-052 (behavioural-by-default with structural bridge window)
-# @jtbd JTBD-001 (enforce governance without slowing down — primary)
-# @jtbd JTBD-006 (work backlog AFK — queued for return, not guessed at)
-# @jtbd JTBD-101 (extend the suite with consistent patterns)
-
-setup() {
-  SKILL_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)"
-  SKILL_FILE="${SKILL_DIR}/SKILL.md"
-  [ -f "$SKILL_FILE" ]
-}
-
-# ----------------------------------------------------------------------
-# Step 4 derive-first refactor (P132 Phase 2a-ii) — cat-4 silent-framework
-# on Title + Priority-when-evidence-present; cat-1 direction-setting only
-# on Description; cat-5 taste fallback only on Priority-when-ambiguous.
-# ----------------------------------------------------------------------
-
-@test "SKILL.md Step 4 cross-references ADR-044 category-4 (silent-framework) for derivable fields (P132 derive-first)" {
-  # P132 Phase 2a-ii: Title + Priority-when-evidence-present resolve via
-  # silent-framework per ADR-044 category 4. Only Description retains
-  # AskUserQuestion as genuine cat-1 direction-setting (no prose -> nothing
-  # to capture).
-  run awk '/^### 4\. /,/^### 4b\. /' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"silent-framework"* ]] || [[ "$output" == *"category 4"* ]] || [[ "$output" == *"category-4"* ]]
-}
-
-@test "SKILL.md Step 4 cross-references ADR-044 category-1 (direction-setting) for Description fallback" {
-  # Description is the genuine cat-1 surface — without prose there is
-  # literally nothing to capture. The refactor preserves the AskUserQuestion
-  # on Description.
-  run awk '/^### 4\. /,/^### 4b\. /' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"direction-setting"* ]] || [[ "$output" == *"category 1"* ]] || [[ "$output" == *"category-1"* ]]
-}
-
-@test "SKILL.md Step 4 derives Title from prose silently (P132 inverse-P078)" {
-  # The 2026-05-06 I001 declaration regression cited in P132 line 14 was the
-  # same agent failure mode on the manage-incident surface: agent asked
-  # "Title" with 3 candidate options when kebab-casing the description
-  # would have produced the slug directly. manage-problem Step 4 must ship
-  # the same derive-first pattern.
-  run awk '/^### 4\. /,/^### 4b\. /' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"Title"* ]]
-  [[ "$output" == *"derive"* ]] || [[ "$output" == *"derived"* ]]
-  [[ "$output" == *"kebab"* ]] || [[ "$output" == *"prose"* ]]
-}
-
-@test "SKILL.md Step 4 derives Priority from RISK-POLICY matrix + evidence (P132 inverse-P078)" {
-  # The I001 regression cited in P132 line 15 was the analogous failure on
-  # Severity. manage-problem's Priority (Impact x Likelihood) derives from
-  # the same RISK-POLICY matrix lookup against description signals.
-  # Ambiguous-evidence falls back to AskUserQuestion as cat-5 (taste).
-  run awk '/^### 4\. /,/^### 4b\. /' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"Priority"* ]]
-  [[ "$output" == *"RISK-POLICY"* ]]
-}
-
-@test "SKILL.md Step 4 retains Description as AskUserQuestion fallback (negative-of-negative guard)" {
-  # Regression-resistance: the refactor MUST preserve the genuine cat-1
-  # direction-setting surface on Description. Without user-supplied prose
-  # the SKILL has nothing to derive from — Description IS the input. Same
-  # reasoning as manage-incident Step 4 Scope retention.
-  run awk '/^### 4\. /,/^### 4b\. /' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"Description"* ]]
-  [[ "$output" == *"AskUserQuestion"* ]]
-}
-
-@test "SKILL.md Step 4 cites P132 (inverse-P078 audit traceability)" {
-  # P132 + ADR-044 must appear in Step 4 or Related section so the audit
-  # trail for the Phase 2a-ii refactor is recoverable from the SKILL.md
-  # surface.
-  run grep -nE "P132" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md Step 4 documents stderr advisory shape for derived fields (ADR-026 grounding)" {
-  # ADR-026 cost-source grounding: each silent derivation emits a stderr
-  # advisory citing the source. Pattern parity with capture-problem Step
-  # 1.5 + manage-incident Step 4 (I2-isomorphic across the three
-  # declaration-skill surfaces per architect verdict 2026-05-15).
-  run awk '/^### 4\. /,/^### 4b\. /' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"stderr"* ]] || [[ "$output" == *"advisory"* ]]
-}
-
-@test "SKILL.md Step 4 cross-references capture-problem Step 1.5 + manage-incident Step 4 (cross-skill consistency)" {
-  # The architect verdict 2026-05-15 P132 Phase 2a-ii flagged cross-skill
-  # consistency: three declaration-skill surfaces now ship the same
-  # dispatch shape. The Step 4 prose must explicitly cite both prior
-  # surfaces (P185 capture-problem + manage-incident b7cc645) as
-  # worked-example precedents so the I2-isomorphic stderr advisory format
-  # is locked-in by reference before a fourth surface (Phase 2a-iii
-  # create-adr) drifts.
-  run awk '/^### 4\. /,/^### 4b\. /' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"P185"* ]] || [[ "$output" == *"capture-problem"* ]]
-  [[ "$output" == *"manage-incident"* ]] || [[ "$output" == *"b7cc645"* ]]
-}
-
-# ----------------------------------------------------------------------
-# Negative-of-negative guards — Step 4b multi-concern + Step 2
-# duplicate-check MUST remain cat-1 direction-setting AskUserQuestion
-# surfaces (architect verdict 2026-05-15: not touched by Phase 2a-ii).
-# ----------------------------------------------------------------------
-
-@test "SKILL.md Step 4b multi-concern AskUserQuestion is preserved (cat-1 direction-setting, not touched by Phase 2a-ii)" {
-  # Architect verdict 2026-05-15: Step 4b is a separate cat-1
-  # direction-setting surface — only the user knows whether the concerns
-  # can be independently fixed. The Phase 2a-ii refactor MUST NOT touch
-  # Step 4b's AskUserQuestion gate.
-  run awk '/^### 4b\. /,/^### 5\. /' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"AskUserQuestion"* ]]
-  [[ "$output" == *"concern"* ]] || [[ "$output" == *"split"* ]]
-}
-
-@test "SKILL.md Step 2 duplicate-check AskUserQuestion is preserved (cat-1 direction-setting, not touched by Phase 2a-ii)" {
-  # Architect verdict 2026-05-15: Step 2 is a separate cat-1
-  # direction-setting surface — only the user knows whether an existing
-  # ticket is the same root cause. The Phase 2a-ii refactor MUST NOT
-  # touch Step 2's AskUserQuestion gate.
-  run awk '/^### 2\. /,/^### 3\. /' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"AskUserQuestion"* ]]
-}

package/skills/manage-problem/test/manage-problem-auto-migrate-step.bats

@@ -1,53 +0,0 @@
-#!/usr/bin/env bats
-
-# P170 / RFC-002 / ADR-031 Open-Execution Q1 resolution: manage-problem
-# SKILL.md wires the shared migration routine at Step 0a (before
-# Step 0 README reconciliation preflight). Doc-lint structural test —
-# the wiring is a SKILL.md preamble integration point; behavioural
-# assertions for the routine itself live at
-# packages/shared/test/sync-migrate-problems-layout.bats (T7) and the
-# end-to-end behavioural fixture
-# packages/itil/skills/manage-problem/test/manage-problem-auto-migrate.bats (T10).
-
-setup() {
-  REPO_ROOT="$(cd "$(dirname "$BATS_TEST_FILENAME")/../../../../.." && pwd)"
-  SKILL_MD="$REPO_ROOT/packages/itil/skills/manage-problem/SKILL.md"
-}
-
-@test "manage-problem: SKILL.md declares Step 0a auto-migrate (T8 wiring point)" {
-  run grep -E '^### 0a\.|^## Step 0a|Step 0a:' "$SKILL_MD"
-  [ "$status" -eq 0 ]
-}
-
-@test "manage-problem: SKILL.md Step 0a cites P170 / RFC-002 / ADR-031" {
-  run grep -F 'P170' "$SKILL_MD"
-  [ "$status" -eq 0 ]
-  run grep -F 'ADR-031' "$SKILL_MD"
-  [ "$status" -eq 0 ]
-}
-
-@test "manage-problem: SKILL.md Step 0a sources packages/itil/lib/migrate-problems-layout.sh" {
-  run grep -F 'packages/itil/lib/migrate-problems-layout.sh' "$SKILL_MD"
-  [ "$status" -eq 0 ]
-}
-
-@test "manage-problem: SKILL.md Step 0a calls migrate_problems_to_per_state_layout entrypoint" {
-  run grep -F 'migrate_problems_to_per_state_layout' "$SKILL_MD"
-  [ "$status" -eq 0 ]
-}
-
-@test "manage-problem: SKILL.md Step 0a fires before Step 0 README reconciliation" {
-  # Assert the literal line order in the file: Step 0a appears before
-  # the existing Step 0 README reconciliation heading.
-  local step_0a_line step_0_line
-  step_0a_line=$(grep -nE '^### 0a\.|^## Step 0a|Step 0a:' "$SKILL_MD" | head -1 | cut -d: -f1)
-  step_0_line=$(grep -nE '^### 0\. README' "$SKILL_MD" | head -1 | cut -d: -f1)
-  [ -n "$step_0a_line" ]
-  [ -n "$step_0_line" ]
-  [ "$step_0a_line" -lt "$step_0_line" ]
-}
-
-@test "manage-problem: SKILL.md Step 0a cites ADR-013 Rule 6 (AFK auto-fire authorisation)" {
-  run grep -F 'ADR-013' "$SKILL_MD"
-  [ "$status" -eq 0 ]
-}

package/skills/manage-problem/test/manage-problem-concern-boundary.bats

@@ -1,64 +0,0 @@
-#!/usr/bin/env bats
-# Doc-lint guard: manage-problem SKILL.md must include a concern-boundary
-# analysis step for new problem creation.
-#
-# Structural assertion — Permitted Exception to the source-grep ban (ADR-005 / P011).
-# These tests assert that the skill specification document conforms to the
-# concern-boundary splitting contract introduced by P016.
-#
-# Cross-reference:
-#   P016: docs/problems/016-manage-problem-should-split-multi-concern-tickets.open.md
-#   ADR-013: docs/decisions/013-structured-user-interaction-for-governance-decisions.proposed.md
-#   @jtbd JTBD-001 (enforce governance without slowing down)
-#   @jtbd JTBD-101 (extend the suite with clear patterns)
-
-setup() {
-  SKILL_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)"
-  SKILL_FILE="${SKILL_DIR}/SKILL.md"
-}
-
-@test "SKILL.md includes a concern-boundary analysis step for new problem creation" {
-  # P016: Before writing a problem file (step 5), the skill must check whether
-  # the description contains multiple distinct root causes or concerns, and offer
-  # to split if it does. This guards against conflated tickets that make WSJF
-  # scoring meaningless.
-  run grep -in "concern.boundary\|concern-boundary\|concern boundary\|boundary.*concern\|split.*concern\|multi.concern\|single.*concern" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md concern-boundary step uses AskUserQuestion, not prose (ADR-013)" {
-  # ADR-013 Rule 1: all branch points must use AskUserQuestion, not prose options.
-  # The concern-boundary split decision (split vs keep as one) is a branch point
-  # and must be handled with a structured AskUserQuestion call, not a
-  # '(a) split (b) keep' prose paragraph.
-  # This test verifies the split prompt references AskUserQuestion (not just that
-  # AskUserQuestion appears anywhere — the no-prose-options.bats test covers that).
-  run grep -n "concern.boundary\|concern-boundary\|concern boundary\|split.*concern\|multi.concern" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  # The split decision must direct the skill to use AskUserQuestion
-  run grep -in "split.*AskUserQuestion\|AskUserQuestion.*split\|split.*question\|question.*split\|split.*ask\|concern.*AskUserQuestion\|AskUserQuestion.*concern" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md concern-boundary step is scoped to new problem creation (not updates)" {
-  # P016 fix must only fire during new problem creation (between steps 4 and 5),
-  # not during updates or transitions. Scope constraint prevents spurious split
-  # prompts on existing tickets being updated or transitioned.
-  # This checks that the concern-boundary step is placed in the 'new problems'
-  # section (steps 2-5), not in the update or transition sections.
-  run grep -n "For new problems\|new problem" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  # The concern-boundary check must appear in the new-problems workflow context
-  run grep -A5 -i "concern.boundary\|concern-boundary\|concern boundary\|multi.concern\|split.*concern" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md concern-boundary step specifies non-interactive fallback with auto-split" {
-  # ADR-013 Rule 6: non-interactive fail-safe — when AskUserQuestion is unavailable,
-  # the skill must auto-split rather than hanging or silently dropping the split.
-  # This specifically requires "auto-split" or "automatically split" language in
-  # the concern-boundary step, not just general "AskUserQuestion unavailable" text
-  # which already exists for the commit step (step 11).
-  run grep -in "auto.split\|automatically split" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}

package/skills/manage-problem/test/manage-problem-effort-buckets.bats

@@ -1,56 +0,0 @@
-#!/usr/bin/env bats
-# Doc-lint guard: manage-problem SKILL.md must define the XL effort bucket
-# and require effort re-rating at lifecycle transitions.
-#
-# Structural assertion — Permitted Exception to the source-grep ban (ADR-005 / P011).
-# These tests assert that the skill specification document conforms to the
-# effort-bucket and re-rating contract introduced by P047.
-#
-# Cross-reference:
-#   P047: docs/problems/047-wsjf-effort-bucket-accuracy-gaps.open.md
-#   @jtbd JTBD-006 (Progress the Backlog While I'm Away — finer ranking signal)
-#   @jtbd JTBD-101 (Extend the Suite with Clear Patterns — consistent WSJF semantics)
-#   @jtbd JTBD-001 (Enforce Governance Without Slowing Down — explicit re-rate audit trail)
-
-setup() {
-  SKILL_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)"
-  SKILL_FILE="${SKILL_DIR}/SKILL.md"
-}
-
-@test "SKILL.md effort table includes an XL bucket with divisor 8" {
-  # P047 concern (2): the L bucket is open-ended (>4 hours, no upper bound),
-  # so multi-day / multi-week work ranks identically to a 4-hour L task.
-  # The XL bucket disambiguates the top end of the effort spectrum.
-  run grep -En "^\|\s*XL\s*\|\s*8\s*\|" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md step 7 pre-flight checks effort bucket re-rating" {
-  # P047 concern (1): effort is set at problem creation and never re-rated.
-  # Step 7 (Open → Known Error transition) must prompt the reviewer to
-  # re-evaluate the effort bucket against the now-documented fix strategy.
-  # Match tight phrasings that can only appear in the new pre-flight item,
-  # not incidental co-occurrences on a summary line.
-  run grep -inE "effort bucket (reviewed|re-?rated|re-?assessed|re-?estimated)|re-?(rate|estimate|assess)( the)? effort bucket" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md step 9b requires explicit effort re-estimation with reason" {
-  # P047 candidate fix (2): step 9b's effort re-rate is implicit today
-  # ("Estimate Effort"). The explicit form ("Re-estimate Effort; if the
-  # bucket changed since last review, update the file and note the reason")
-  # makes the check unmissable and leaves an audit trail.
-  run grep -in "re-estimate effort\|re.estimate effort" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  # The note-the-reason phrase must appear near the re-estimate instruction
-  run grep -inE "note.*reason|reason.*noted|note the reason" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md XL bucket description names its scope as multi-day / cross-package" {
-  # P047 scoping: XL must be unambiguously wider than L. The description
-  # should reference multi-day or cross-package to distinguish it from L's
-  # "> 4 hours, multiple files, significant change".
-  run grep -inE "XL.*(multi.?day|multi-?week|cross-?package|multi-?package)" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}

package/skills/manage-problem/test/manage-problem-external-root-cause-detection.bats

@@ -1,119 +0,0 @@
-#!/usr/bin/env bats
-
-# P063: manage-problem SKILL.md documents the external-root-cause
-# detection block that triggers /wr-itil:report-upstream (ADR-024)
-# when root cause is external.
-#
-# Doc-lint structural test (Permitted Exception per ADR-005) — asserts
-# SKILL.md wording for detection tokens, AskUserQuestion three-option
-# prompt, AFK fallback, and the stable `- **Upstream report pending** --`
-# marker (canonical ASCII form per P210; the legacy em-dash variant is
-# still matched by the SKILL's already-noted check for backward
-# compatibility, but is not the canonical-write target). Mirrors
-# work-problems-release-cadence.bats and report-upstream-contract.bats
-# patterns.
-
-setup() {
-  REPO_ROOT="$(cd "$(dirname "$BATS_TEST_FILENAME")/../../../../.." && pwd)"
-  MP_SKILL="$REPO_ROOT/packages/itil/skills/manage-problem/SKILL.md"
-  WP_SKILL="$REPO_ROOT/packages/itil/skills/work-problems/SKILL.md"
-}
-
-@test "manage-problem: SKILL.md contains the External-root-cause detection block (P063)" {
-  run grep -F 'External-root-cause detection (P063)' "$MP_SKILL"
-  [ "$status" -eq 0 ]
-}
-
-@test "manage-problem: SKILL.md documents strict detection tokens (upstream, third-party, external, vendor)" {
-  run grep -F '`upstream`, `third-party`, `external`, `vendor`' "$MP_SKILL"
-  [ "$status" -eq 0 ]
-}
-
-@test "manage-problem: SKILL.md documents the scoped-npm detection pattern" {
-  run grep -F '@[\w-]+/[\w-]+' "$MP_SKILL"
-  [ "$status" -eq 0 ]
-}
-
-@test "manage-problem: SKILL.md documents the three AskUserQuestion options (invoke / defer / false positive)" {
-  run grep -F 'Invoke /wr-itil:report-upstream now' "$MP_SKILL"
-  [ "$status" -eq 0 ]
-  run grep -F 'Defer and note in ticket' "$MP_SKILL"
-  [ "$status" -eq 0 ]
-  run grep -F 'Not actually upstream' "$MP_SKILL"
-  [ "$status" -eq 0 ]
-}
-
-@test "manage-problem: SKILL.md defines the stable Upstream report pending marker with fixed wording (canonical ASCII per P210)" {
-  run grep -F -- '- **Upstream report pending** -- external dependency identified; invoke /wr-itil:report-upstream when ready' "$MP_SKILL"
-  [ "$status" -eq 0 ]
-}
-
-@test "manage-problem: SKILL.md still references the legacy em-dash marker variant for backward compatibility (P210)" {
-  # P210: canonical write form is ASCII `--`, but the already-noted
-  # check MUST still match the legacy em-dash variant so tickets
-  # written in prior sessions are detected correctly. Asserts the
-  # legacy form remains documented in the SKILL prose.
-  run grep -F -- '- **Upstream report pending** —' "$MP_SKILL"
-  [ "$status" -eq 0 ]
-}
-
-@test "manage-problem: SKILL.md documents the AFK non-interactive fallback (P270 — auto-invoke report-upstream via external-comms gate)" {
-  run grep -iE 'non-interactive.*afk|afk.*fallback|Non-interactive \(AFK\) branch' "$MP_SKILL"
-  [ "$status" -eq 0 ]
-  # P270 (ADR-024 2026-06-04 amendment): the AFK branch now auto-invokes
-  # report-upstream and routes the drafted prose through the
-  # wr-risk-scorer:external-comms gate, superseding the pre-2026-06-04
-  # "append marker, do NOT auto-invoke" default.
-  run grep -iE 'auto-invoke .*report-upstream' "$MP_SKILL"
-  [ "$status" -eq 0 ]
-  run grep -F 'external-comms' "$MP_SKILL"
-  [ "$status" -eq 0 ]
-}
-
-@test "manage-problem: SKILL.md documents the already-noted check to avoid duplicate prompts" {
-  run grep -F 'Already-noted check' "$MP_SKILL"
-  [ "$status" -eq 0 ]
-}
-
-@test "manage-problem: SKILL.md documents both insertion points (Open → Known Error AND upstream-blocked park)" {
-  run grep -F 'Open → Known Error transition' "$MP_SKILL"
-  [ "$status" -eq 0 ]
-  run grep -F 'Parking path with `upstream-blocked` reason' "$MP_SKILL"
-  [ "$status" -eq 0 ]
-}
-
-@test "manage-problem: Parked lifecycle entry cross-references the external-root-cause detection block" {
-  run grep -F 'If the park reason is `upstream-blocked`' "$MP_SKILL"
-  [ "$status" -eq 0 ]
-}
-
-@test "manage-problem: SKILL.md references ADR-024 and ADR-013 Rule 6 in the detection block" {
-  run grep -F 'ADR-024 Confirmation criterion 3a' "$MP_SKILL"
-  [ "$status" -eq 0 ]
-  run grep -F 'ADR-013 Rule 6' "$MP_SKILL"
-  [ "$status" -eq 0 ]
-}
-
-@test "work-problems: upstream-blocked skip row runs the AFK fallback before skipping (P270 — auto-invoke report-upstream)" {
-  # P270 (ADR-024 2026-06-04 amendment): the skip row auto-invokes
-  # report-upstream before skipping (superseding the old marker-only append).
-  run grep -iE 'Auto-invoke .*report-upstream' "$WP_SKILL"
-  [ "$status" -eq 0 ]
-  run grep -F 'Before skipping, run the manage-problem external-root-cause detection AFK fallback' "$WP_SKILL"
-  [ "$status" -eq 0 ]
-}
-
-@test "work-problems: upstream-blocked taxonomy entry documents the AFK fallback" {
-  run grep -F 'Before skipping, run the manage-problem external-root-cause detection AFK fallback' "$WP_SKILL"
-  [ "$status" -eq 0 ]
-}
-
-@test "work-problems: Non-Interactive Decision Making table has the external-root-cause row (P063)" {
-  run grep -F 'External root cause detected at Open → Known Error' "$WP_SKILL"
-  [ "$status" -eq 0 ]
-}
-
-@test "work-problems: uses the same stable marker wording as manage-problem (canonical ASCII per P210)" {
-  run grep -F -- '- **Upstream report pending** -- external dependency identified; invoke /wr-itil:report-upstream when ready' "$WP_SKILL"
-  [ "$status" -eq 0 ]
-}

package/skills/manage-problem/test/manage-problem-first-run-intake-prompt.bats

@@ -1,43 +0,0 @@
-#!/usr/bin/env bats
-
-# P065 / ADR-036 Confirmation line 198: manage-problem SKILL.md must
-# wire the first-run intake-scaffold prompt — citing ADR-036 + the AFK
-# fail-safe + the marker contract.
-#
-# Doc-lint structural test (Permitted Exception per ADR-005). The wiring
-# itself is a SKILL.md preamble pointer (architect direction 2026-04-26),
-# so behavioural assertions live at the contract layer of scaffold-intake;
-# this bats fixes the wiring point so future maintainers cannot silently
-# remove the cross-reference.
-
-setup() {
-  REPO_ROOT="$(cd "$(dirname "$BATS_TEST_FILENAME")/../../../../.." && pwd)"
-  SKILL_MD="$REPO_ROOT/packages/itil/skills/manage-problem/SKILL.md"
-}
-
-@test "manage-problem: SKILL.md cites ADR-036 (first-run-prompt contract)" {
-  run grep -F 'ADR-036' "$SKILL_MD"
-  [ "$status" -eq 0 ]
-}
-
-@test "manage-problem: SKILL.md cross-references the scaffold-intake skill" {
-  run grep -F 'wr-itil:scaffold-intake' "$SKILL_MD"
-  [ "$status" -eq 0 ]
-}
-
-@test "manage-problem: SKILL.md documents the first-run intake-scaffold detection clause" {
-  # Detection clause must reference at least one intake-file path AND the
-  # decline marker so future maintainers see how the trigger fires.
-  run grep -iE 'intake' "$SKILL_MD"
-  [ "$status" -eq 0 ]
-  run grep -F '.claude/.intake-scaffold-declined' "$SKILL_MD"
-  [ "$status" -eq 0 ]
-}
-
-@test "manage-problem: SKILL.md documents the AFK fail-safe (no AskUserQuestion in AFK; iteration-report note)" {
-  # Per ADR-013 Rule 6, the AFK orchestrator branch must not fire
-  # AskUserQuestion. The SKILL.md preamble pointer must call out this
-  # fail-safe so adopters reading the skill understand the divergence.
-  run grep -iE 'afk|rule 6' "$SKILL_MD"
-  [ "$status" -eq 0 ]
-}