@windyroad/itil 0.61.1 → 0.61.2

package/hooks/test/command-detect.bats

@@ -1,181 +0,0 @@
-#!/usr/bin/env bats
-
-# P268: lib/command-detect.sh — `command_invokes_git_commit` helper.
-#
-# Behavioural contract:
-#   `command_invokes_git_commit "$cmd"` returns 0 iff `$cmd`, when
-#   executed by bash, would actually invoke `git commit` as its
-#   leading-effective command (after stripping common prefix shapes:
-#   leading whitespace, env-var assignments, `cd <path> &&` prefix).
-#   Returns 1 for any other command, including commands whose
-#   argument vectors or heredoc bodies merely mention the literal
-#   string "git commit".
-#
-# Replaces the substring-match `case "$COMMAND" in *"git commit"*) ;;`
-# pattern that 5 sibling PreToolUse:Bash hooks previously shared. The
-# substring match misfired on `grep -n 'git commit' file.md`,
-# `cat >> file <<EOF ... git commit ... EOF`, `echo "git commit ..."`,
-# `sed -i 's/git commit/.../' file`, `git log --grep 'git commit'`,
-# and similar non-commit Bash invocations whose arguments contained
-# the literal phrase (P268 ticket Description).
-#
-# Per P081 (behavioural tests): tests assert helper return code against
-# realistic command strings — NOT grep-against-source-content.
-
-setup() {
-  SCRIPT_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)"
-  HELPER="$SCRIPT_DIR/lib/command-detect.sh"
-  # shellcheck source=../lib/command-detect.sh
-  source "$HELPER"
-}
-
-# --- Positive cases (helper returns 0 — command IS a git commit) ---
-
-@test "positive: bare git commit -m" {
-  run command_invokes_git_commit "git commit -m 'feat'"
-  [ "$status" -eq 0 ]
-}
-
-@test "positive: git commit --amend" {
-  run command_invokes_git_commit "git commit --amend"
-  [ "$status" -eq 0 ]
-}
-
-@test "positive: git commit with no args" {
-  run command_invokes_git_commit "git commit"
-  [ "$status" -eq 0 ]
-}
-
-@test "positive: leading whitespace before git commit" {
-  run command_invokes_git_commit "  git commit -m 'feat'"
-  [ "$status" -eq 0 ]
-}
-
-@test "positive: env-var prefix BYPASS_X=1 git commit" {
-  run command_invokes_git_commit "BYPASS_README_REFRESH_GATE=1 git commit -m 'feat'"
-  [ "$status" -eq 0 ]
-}
-
-@test "positive: multiple env-var prefixes git commit" {
-  run command_invokes_git_commit "FOO=1 BAR=baz git commit -m 'feat'"
-  [ "$status" -eq 0 ]
-}
-
-@test "positive: env-var with double-quoted value git commit" {
-  run command_invokes_git_commit "GIT_AUTHOR_NAME=\"Test User\" git commit -m 'feat'"
-  [ "$status" -eq 0 ]
-}
-
-@test "positive: env-var with single-quoted value git commit" {
-  run command_invokes_git_commit "GIT_AUTHOR_NAME='Test User' git commit -m 'feat'"
-  [ "$status" -eq 0 ]
-}
-
-@test "positive: cd <path> && git commit" {
-  run command_invokes_git_commit "cd /tmp && git commit -m 'feat'"
-  [ "$status" -eq 0 ]
-}
-
-@test "positive: cd <quoted path> && git commit" {
-  run command_invokes_git_commit "cd \"/tmp/with spaces\" && git commit -m 'feat'"
-  [ "$status" -eq 0 ]
-}
-
-@test "positive: env-var then cd then git commit (combined prefixes)" {
-  run command_invokes_git_commit "BYPASS=1 cd /tmp && git commit -m 'feat'"
-  [ "$status" -eq 0 ]
-}
-
-@test "positive: cd then env-var then git commit (reversed prefix order)" {
-  run command_invokes_git_commit "cd /tmp && BYPASS=1 git commit -m 'feat'"
-  [ "$status" -eq 0 ]
-}
-
-@test "positive: tab-indented git commit" {
-  run command_invokes_git_commit $'\tgit commit -m feat'
-  [ "$status" -eq 0 ]
-}
-
-# --- Negative cases (helper returns 1 — command is NOT a git commit) ---
-
-@test "negative: grep with 'git commit' as pattern argument" {
-  run command_invokes_git_commit "grep -n 'git commit' file.md"
-  [ "$status" -eq 1 ]
-}
-
-@test "negative: grep -rn 'git commit' (the recurring orchestrator surface)" {
-  run command_invokes_git_commit "grep -rn 'git commit' packages/"
-  [ "$status" -eq 1 ]
-}
-
-@test "negative: cat heredoc whose body contains the phrase git commit" {
-  run command_invokes_git_commit $'cat >> docs/problems/README-history.md <<EOF\nWe added a git commit gate.\nEOF'
-  [ "$status" -eq 1 ]
-}
-
-@test "negative: echo string containing git commit" {
-  run command_invokes_git_commit "echo 'the git commit gate fires here'"
-  [ "$status" -eq 1 ]
-}
-
-@test "negative: sed substitution mentioning git commit" {
-  run command_invokes_git_commit "sed -i 's/git commit/git push/' file.md"
-  [ "$status" -eq 1 ]
-}
-
-@test "negative: git log --grep 'git commit'" {
-  run command_invokes_git_commit "git log --grep 'git commit'"
-  [ "$status" -eq 1 ]
-}
-
-@test "negative: git status (other git subcommand)" {
-  run command_invokes_git_commit "git status"
-  [ "$status" -eq 1 ]
-}
-
-@test "negative: git push (other git subcommand)" {
-  run command_invokes_git_commit "git push origin main"
-  [ "$status" -eq 1 ]
-}
-
-@test "negative: git commit-tree (plumbing — boundary check)" {
-  run command_invokes_git_commit "git commit-tree HEAD^{tree}"
-  [ "$status" -eq 1 ]
-}
-
-@test "negative: empty command" {
-  run command_invokes_git_commit ""
-  [ "$status" -eq 1 ]
-}
-
-@test "negative: whitespace-only command" {
-  run command_invokes_git_commit "   "
-  [ "$status" -eq 1 ]
-}
-
-@test "negative: cat with single-quoted body containing git commit phrase" {
-  run command_invokes_git_commit "printf '%s\n' 'the git commit gate is here' > /tmp/out"
-  [ "$status" -eq 1 ]
-}
-
-@test "negative: a different command chained before git commit (e.g. git add foo && git commit) — leading is git add, helper passes" {
-  # Per Fix shape B narrow scope: helper only checks the leading-
-  # effective command after prefix-strip. Mid-chain `git commit`
-  # after a non-prefix-shape leading command (here `git add`) is a
-  # documented false negative — standalone re-commit would re-trigger
-  # detection. Acceptable per P268 ticket Description.
-  run command_invokes_git_commit "git add foo && git commit -m 'feat'"
-  [ "$status" -eq 1 ]
-}
-
-# --- Silence contract (ADR-045 Pattern 1) ---
-
-@test "helper emits zero bytes on stdout (pure exit-code contract)" {
-  run command_invokes_git_commit "git commit -m 'feat'"
-  [ "${#output}" -eq 0 ]
-}
-
-@test "helper emits zero bytes on stdout for negative case too" {
-  run command_invokes_git_commit "grep -n 'git commit' file.md"
-  [ "${#output}" -eq 0 ]
-}

package/hooks/test/itil-assistant-output-gate.bats

@@ -1,114 +0,0 @@
-#!/usr/bin/env bats
-
-# P085: itil-assistant-output-gate.sh UserPromptSubmit hook must detect
-# when the user's incoming prompt pins a direction / confirms a prior
-# ask / issues an act-verb, and inject a once-per-session MANDATORY
-# reminder instructing the assistant to act without asking — or use
-# AskUserQuestion for genuine ambiguity — and NEVER prose-ask.
-#
-# Per ADR-038: full block emits once per session; subsequent prompts
-# emit a terse reminder (<250 bytes) that keeps the MANDATORY signal,
-# the gate name, and the AskUserQuestion affordance.
-#
-# Per feedback_behavioural_tests.md (P081): these are behavioural
-# assertions — they simulate the hook's payload on stdin and assert
-# on what the hook emits, not on the source text of the hook file.
-
-setup() {
-  REPO_ROOT="$(cd "$(dirname "$BATS_TEST_FILENAME")/../../../.." && pwd)"
-  HOOK="$REPO_ROOT/packages/itil/hooks/itil-assistant-output-gate.sh"
-  SID="itil-gate-test-$$-$RANDOM"
-}
-
-teardown() {
-  rm -f "/tmp/itil-assistant-gate-announced-${SID}"
-  rm -f "/tmp/itil-assistant-gate-announced-${SID}-alt"
-}
-
-run_hook() {
-  local sid="$1"
-  local prompt="$2"
-  echo "{\"session_id\":\"$sid\",\"prompt\":$(printf '%s' "$prompt" | jq -Rs .)}" | bash "$HOOK"
-}
-
-@test "gate: emits full MANDATORY block on first direction-pin prompt" {
-  run run_hook "$SID" "yes, update P084 and verify the subagent tools thing"
-  [ "$status" -eq 0 ]
-  [ "${#output}" -gt 400 ]
-  [[ "$output" == *"MANDATORY"* ]]
-  [[ "$output" == *"AskUserQuestion"* ]]
-  [[ "$output" == *"obvious"* ]] || [[ "$output" == *"act"* ]]
-}
-
-@test "gate: writes the announcement marker on first emission" {
-  run run_hook "$SID" "go ahead and do it"
-  [ "$status" -eq 0 ]
-  [ -f "/tmp/itil-assistant-gate-announced-${SID}" ]
-}
-
-@test "gate: second direction-pin prompt in same session emits terse reminder only" {
-  run_hook "$SID" "yes, please proceed" >/dev/null
-  # Second prompt also pins direction (required for the gate to fire).
-  run run_hook "$SID" "yes, go ahead"
-  [ "$status" -eq 0 ]
-  [ "${#output}" -lt 250 ]
-  [[ "$output" == *"AskUserQuestion"* ]]
-  # Full block is NOT re-emitted
-  [[ "$output" != *"Canonical prose-ask phrasings"* ]]
-}
-
-@test "gate: terse reminder preserves MANDATORY / REQUIRED signal word" {
-  run_hook "$SID" "yes" >/dev/null
-  run run_hook "$SID" "act on this"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"MANDATORY"* ]] || [[ "$output" == *"REQUIRED"* ]] || [[ "$output" == *"NON-OPTIONAL"* ]]
-}
-
-@test "gate: different session_id re-emits the full block" {
-  run_hook "$SID" "yes" >/dev/null
-  local SID2="${SID}-alt"
-  run run_hook "$SID2" "yes"
-  [ "$status" -eq 0 ]
-  [ "${#output}" -gt 400 ]
-  rm -f "/tmp/itil-assistant-gate-announced-${SID2}"
-}
-
-@test "gate: empty session_id emits the full block and writes no marker" {
-  run run_hook "" "yes, go"
-  [ "$status" -eq 0 ]
-  [ "${#output}" -gt 400 ]
-  [ ! -f "/tmp/itil-assistant-gate-announced-" ]
-}
-
-@test "gate: non-direction-pinning prompt does not emit a block" {
-  # A conversational prompt with no direction/act-verb/yes signal
-  # should not burn the session-marker budget.
-  run run_hook "$SID" "what does ADR-013 say about ambiguous decisions?"
-  [ "$status" -eq 0 ]
-  # May emit a short neutral note OR nothing, but must not emit the
-  # full MANDATORY block on a non-direction prompt.
-  [[ "$output" != *"MANDATORY: act"* ]] || [ "${#output}" -lt 250 ]
-  # Must not have written the announcement marker either.
-  [ ! -f "/tmp/itil-assistant-gate-announced-${SID}" ]
-}
-
-@test "gate: direction-pin via 'act now' verb triggers the block" {
-  run run_hook "$SID" "act now and close the ticket"
-  [ "$status" -eq 0 ]
-  [ "${#output}" -gt 400 ]
-  [[ "$output" == *"MANDATORY"* ]]
-}
-
-@test "gate: direction-pin via 'just do it' triggers the block" {
-  run run_hook "$SID" "just do it"
-  [ "$status" -eq 0 ]
-  [ "${#output}" -gt 400 ]
-  [[ "$output" == *"MANDATORY"* ]]
-}
-
-@test "gate: terse reminder references AskUserQuestion" {
-  run_hook "$SID" "yes" >/dev/null
-  run run_hook "$SID" "proceed"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"AskUserQuestion"* ]]
-}

package/hooks/test/itil-assistant-output-review.bats

@@ -1,224 +0,0 @@
-#!/usr/bin/env bats
-
-# P085: itil-assistant-output-review.sh Stop hook reads the last
-# assistant turn from the transcript at `transcript_path` on stdin and
-# scans for canonical prose-ask phrasings ("Want me to", "Should I",
-# "Option A or Option B", etc.). When a prose-ask is detected, the
-# hook emits a stopReason JSON object with a nudge instructing the
-# assistant to re-emit via AskUserQuestion (or to act, if the decision
-# was obvious). Clean turns pass silently (no stopReason field).
-#
-# The Stop hook cannot rewrite the emitted turn — only nudge the next
-# turn — so its job is post-hoc detection + durable signal, per the
-# architect verdict for P085.
-
-setup() {
-  REPO_ROOT="$(cd "$(dirname "$BATS_TEST_FILENAME")/../../../.." && pwd)"
-  HOOK="$REPO_ROOT/packages/itil/hooks/itil-assistant-output-review.sh"
-  TMPDIR_="$(mktemp -d)"
-  TRANSCRIPT="$TMPDIR_/transcript.jsonl"
-}
-
-teardown() {
-  rm -rf "$TMPDIR_"
-}
-
-# Writes a JSONL transcript with a user message followed by an
-# assistant message. Claude Code transcript format: each line is a
-# JSON object with `type: user|assistant` and `message.content` being
-# either a string or an array of content blocks (text/tool_use).
-write_transcript() {
-  local user_text="$1"
-  local assistant_text="$2"
-  {
-    printf '{"type":"user","message":{"role":"user","content":%s}}\n' "$(printf '%s' "$user_text" | jq -Rs .)"
-    printf '{"type":"assistant","message":{"role":"assistant","content":[{"type":"text","text":%s}]}}\n' "$(printf '%s' "$assistant_text" | jq -Rs .)"
-  } > "$TRANSCRIPT"
-}
-
-run_hook() {
-  echo "{\"session_id\":\"stop-test\",\"transcript_path\":$(printf '%s' "$TRANSCRIPT" | jq -Rs .)}" | bash "$HOOK"
-}
-
-@test "review: 'Want me to' in assistant text triggers stopReason nudge" {
-  write_transcript "update the ticket" "Done. Want me to also commit now or wait?"
-  run run_hook
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"stopReason"* ]]
-  [[ "$output" == *"AskUserQuestion"* ]]
-}
-
-@test "review: 'Should I' in assistant text triggers stopReason nudge" {
-  write_transcript "look at this" "I see the issue. Should I fix it now or wait for review?"
-  run run_hook
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"stopReason"* ]]
-}
-
-@test "review: 'Would you like me to' triggers stopReason nudge" {
-  write_transcript "ok" "Ticket updated. Would you like me to open a PR next?"
-  run run_hook
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"stopReason"* ]]
-}
-
-@test "review: 'Option A or Option B' triggers stopReason nudge" {
-  write_transcript "plan this" "Two paths: Option A: do it inline. Or Option B: split into two commits. Which do you prefer?"
-  run run_hook
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"stopReason"* ]]
-}
-
-@test "review: '(a) / (b) / (c)?' triggers stopReason nudge" {
-  write_transcript "go" "Three choices: (a) ship now, (b) wait for review, or (c) add tests first?"
-  run run_hook
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"stopReason"* ]]
-}
-
-@test "review: clean informative turn does not trigger stopReason" {
-  write_transcript "what changed" "The last commit added three files: detectors.sh, gate.sh, and review.sh. No new decisions were introduced."
-  run run_hook
-  [ "$status" -eq 0 ]
-  # Clean output: either empty or a JSON object WITHOUT stopReason.
-  [[ "$output" != *"stopReason"* ]]
-}
-
-@test "review: assistant turn containing AskUserQuestion tool_use does NOT flag" {
-  # If the assistant used the AskUserQuestion tool, that's the compliant
-  # path — we must not nudge them for using prose inside the tool's
-  # rendered question text (the tool surface is structured).
-  {
-    printf '{"type":"user","message":{"role":"user","content":"plan this"}}\n'
-    cat <<'JSON'
-{"type":"assistant","message":{"role":"assistant","content":[{"type":"text","text":"Here is the choice:"},{"type":"tool_use","name":"AskUserQuestion","input":{"question":"Which option?","options":[{"label":"A"},{"label":"B"}]}}]}}
-JSON
-  } > "$TRANSCRIPT"
-  run run_hook
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"stopReason"* ]]
-}
-
-@test "review: missing transcript_path exits cleanly without error" {
-  run bash -c 'echo "{\"session_id\":\"sid\"}" | bash "$1"' -- "$HOOK"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"stopReason"* ]]
-}
-
-@test "review: non-existent transcript file exits cleanly without error" {
-  run bash -c "echo '{\"session_id\":\"sid\",\"transcript_path\":\"/tmp/does-not-exist-$RANDOM\"}' | bash '$HOOK'"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"stopReason"* ]]
-}
-
-@test "review: ask-when-obvious pattern triggers stopReason" {
-  # Prior user message pins direction ("yes, update the ticket"), next
-  # assistant turn ends with a question mark on an obvious-next-step.
-  # This is Facet A of P085 — asking when the answer is obvious.
-  write_transcript "yes, update the ticket with the findings" "Updated. Want me to commit and close the ticket now, or leave it open for review?"
-  run run_hook
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"stopReason"* ]]
-}
-
-@test "review: 'Shall we' triggers stopReason nudge" {
-  write_transcript "look at options" "That's one route. Shall we go with it?"
-  run run_hook
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"stopReason"* ]]
-}
-
-@test "review: 'Do you want to' triggers stopReason nudge" {
-  write_transcript "plan" "I can split into two PRs. Do you want to go that route?"
-  run run_hook
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"stopReason"* ]]
-}
-
-# 2026-04-28 regression evidence (P085 reopen, Citation 1).
-# Orchestrator main turn emitted a halt-summary ending with "Awaiting your
-# direction on whether to add it + resume on P123, or end the session."
-# The Stop hook should have caught this binary-choice prose-ask but the
-# pattern list did not match. Detector extension closes the gap.
-@test "review: 'Awaiting your direction on whether ... or ...' (Citation 1 shape) triggers stopReason" {
-  write_transcript "ok" "Loop is still halted. Remaining open item: missing changeset for b9da37e. Awaiting your direction on whether to add it + resume on P123, or end the session."
-  run run_hook
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"stopReason"* ]]
-}
-
-@test "review: 'Awaiting your input' triggers stopReason nudge" {
-  write_transcript "ok" "Plan staged. Awaiting your input on the next step."
-  run run_hook
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"stopReason"* ]]
-}
-
-@test "review: 'Pending your decision' triggers stopReason nudge" {
-  write_transcript "review" "Refactor scoped to three files. Pending your decision before I continue."
-  run run_hook
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"stopReason"* ]]
-}
-
-@test "review: 'Once you confirm' triggers stopReason nudge" {
-  write_transcript "look" "Rename ready. Once you confirm, I will proceed with the rename."
-  run run_hook
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"stopReason"* ]]
-}
-
-@test "review: 'Awaiting your response' triggers stopReason nudge" {
-  write_transcript "go" "Two paths identified. Awaiting your response so I know which to take."
-  run run_hook
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"stopReason"* ]]
-}
-
-# P403: mechanical-step-framed-as-user-optional. When a skill contract
-# mandates a mechanical step, the agent must not re-surface it as a user
-# decision (or a budget-caution skip) in end-of-turn prose. The detector
-# fires only when a step-skip signal, a step/mechanical-pass reference,
-# AND an offloaded-justification closer all co-occur (the AND-discriminator).
-
-@test "review: P403 evidence 1 — 'Step 7 auto-release skipped — your call' triggers stopReason" {
-  write_transcript "review the backlog" "Done. Step 7 auto-release skipped — your call whether to drain via /wr-risk-scorer:assess-release."
-  run run_hook
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"stopReason"* ]]
-  [[ "$output" == *"mechanical"* ]]
-}
-
-@test "review: P403 evidence 2 — 'Skipped the full re-rank (Step 2) ... to stay within context budget' triggers stopReason" {
-  write_transcript "review problems" "Skipped the full 40-ticket re-rank (Step 2), inbound-discovery pipeline (Step 4.5), and relevance-close pass (Step 4.6) to stay within context budget."
-  run run_hook
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"stopReason"* ]]
-}
-
-@test "review: AND-discriminator — optional closer WITHOUT a step-skip does not trigger stopReason" {
-  # "up to you" is a legitimately user-owned decision with no skipped
-  # mechanical step in context — must NOT fire (the inverse-P078 guard).
-  write_transcript "which theme" "Both palettes meet contrast AA. It is up to you which one reads better for your brand."
-  run run_hook
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"stopReason"* ]]
-}
-
-@test "review: AND-discriminator — skipped step with a real reason (no offload) does not trigger stopReason" {
-  # A skipped step reported with a substantive reason (not offloaded to the
-  # user, not budget-caution) is a legitimate report, not the P403 defect.
-  write_transcript "run it" "Step 2 skipped because its precondition is already satisfied by Step 1. Proceeding to Step 3."
-  run run_hook
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"stopReason"* ]]
-}
-
-@test "review: P403 nudge stays within the ADR-045 hook injection budget" {
-  write_transcript "review the backlog" "Done. Step 7 auto-release skipped — your call whether to drain."
-  run run_hook
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"stopReason"* ]]
-  # ADR-045 advisory band: keep the injected nudge well under 1000 bytes.
-  [ "${#output}" -lt 1000 ]
-}

package/hooks/test/itil-bash-polling-antipattern-detect.bats

@@ -1,154 +0,0 @@
-#!/usr/bin/env bats
-
-# P232: itil-bash-polling-antipattern-detect.sh PreToolUse:Bash hook
-# must deny bash polling loops that self-reference via `pgrep -f`
-# (parent class) or `pkill -0` (sibling), advising `wait $bg_pid` or
-# Bash-tool `BashOutput` polling instead.
-#
-# Detection shape: a loop construct (`until` / `while`) combined with a
-# polling mechanism (`pgrep -f` / `pkill -0`). One-shot `pgrep -f` (no
-# surrounding loop) is allowed — the polling shape is the antipattern,
-# not pgrep itself.
-#
-# Per ADR-005 / ADR-052 — bats live under packages/<plugin>/hooks/test/
-# and assert behaviour on emitted JSON, not source-content. Per
-# feedback_behavioural_tests.md (P081) — no source-grep on hook text.
-
-setup() {
-  SCRIPT_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)"
-  HOOK="$SCRIPT_DIR/itil-bash-polling-antipattern-detect.sh"
-}
-
-# Helper: simulate the PreToolUse:Bash payload on stdin.
-# Uses python to build the JSON so we don't escape-hell with bash.
-run_bash_hook() {
-  local cmd="$1"
-  python3 -c "
-import json, sys
-print(json.dumps({'tool_name': 'Bash', 'tool_input': {'command': sys.argv[1]}}))
-" "$cmd" | bash "$HOOK"
-}
-
-# --- Antipattern detection: positive cases (deny) ---
-
-@test "deny: until ! pgrep -f loop" {
-  run run_bash_hook "until ! pgrep -f 'bats --recursive' > /dev/null 2>&1; do sleep 5; done"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"\"permissionDecision\": \"deny\""* ]]
-  [[ "$output" == *"P232"* ]]
-}
-
-@test "deny: while pgrep -f loop (positive form, no negation)" {
-  run run_bash_hook "while pgrep -f 'long-running-job'; do sleep 2; done"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"\"permissionDecision\": \"deny\""* ]]
-  [[ "$output" == *"P232"* ]]
-}
-
-@test "deny: until ! pkill -0 signal-0 poll" {
-  run run_bash_hook "until ! pkill -0 -f 'worker'; do sleep 3; done"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"\"permissionDecision\": \"deny\""* ]]
-}
-
-@test "deny: while pkill -0 signal-0 poll" {
-  run run_bash_hook "while pkill -0 12345; do sleep 1; done"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"\"permissionDecision\": \"deny\""* ]]
-}
-
-@test "deny: pgrep poll embedded in heredoc body" {
-  # Heredoc body lands in the same tool_input.command string.
-  run run_bash_hook "bash <<'EOF'
-until ! pgrep -f 'bats'; do sleep 5; done
-EOF"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"\"permissionDecision\": \"deny\""* ]]
-}
-
-@test "deny: P232 deadlock witness — multi-line shape with trailing tail" {
-  run run_bash_hook "until ! pgrep -f 'bats --recursive' > /dev/null 2>&1; do sleep 5; done; echo done; tail -30 /tmp/bats-out.log"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"\"permissionDecision\": \"deny\""* ]]
-}
-
-# --- Allow paths: legitimate non-polling uses ---
-
-@test "allow: one-shot pgrep -f without surrounding loop" {
-  run run_bash_hook "pgrep -f 'nginx' && echo running"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"\"permissionDecision\": \"deny\""* ]]
-}
-
-@test "allow: one-shot pkill (no -0, real signal — not a poll)" {
-  run run_bash_hook "pkill -TERM -f 'stale-worker'"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"\"permissionDecision\": \"deny\""* ]]
-}
-
-@test "allow: wait \$bg_pid (the canonical recovery shape)" {
-  run run_bash_hook "bats --recursive packages/itil/hooks/test/ & wait \$!"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"\"permissionDecision\": \"deny\""* ]]
-}
-
-@test "allow: while loop without pgrep/pkill (unrelated)" {
-  run run_bash_hook "while read line; do echo \$line; done < input.txt"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"\"permissionDecision\": \"deny\""* ]]
-}
-
-@test "allow: until loop without pgrep/pkill (unrelated)" {
-  run run_bash_hook "until [ -f /tmp/sentinel ]; do sleep 1; done"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"\"permissionDecision\": \"deny\""* ]]
-}
-
-@test "allow: commit message text mentioning pgrep does not deny" {
-  # The literal pair is in the commit message body, not a poll shape.
-  # The hook should not over-match on commit prose.
-  run run_bash_hook "git commit -m 'document pgrep antipattern in P232'"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"\"permissionDecision\": \"deny\""* ]]
-}
-
-# --- Tool-name filters ---
-
-@test "allow: non-Bash tool exits 0 without deny" {
-  run bash -c "echo '{\"tool_name\":\"Edit\",\"tool_input\":{\"file_path\":\"foo.md\"}}' | bash $HOOK"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"\"permissionDecision\": \"deny\""* ]]
-}
-
-# --- Parse / fail-open ---
-
-@test "allow: empty JSON fails open" {
-  run bash -c "echo '{}' | bash $HOOK"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"\"permissionDecision\": \"deny\""* ]]
-}
-
-@test "allow: empty command field fails open" {
-  run bash -c "echo '{\"tool_name\":\"Bash\",\"tool_input\":{\"command\":\"\"}}' | bash $HOOK"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"\"permissionDecision\": \"deny\""* ]]
-}
-
-# --- Deny message contract (ADR-038 progressive disclosure / ADR-045 budget) ---
-
-@test "deny message cites P232 + names BOTH recovery alternatives" {
-  run run_bash_hook "until ! pgrep -f 'bats'; do sleep 5; done"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"P232"* ]]
-  [[ "$output" == *"wait"* ]]
-  [[ "$output" == *"BashOutput"* ]]
-}
-
-@test "deny message stays under ADR-045 deny-path budget (<700 bytes)" {
-  # Voice-tone target ~245 bytes (sibling p057-staging-trap-detect.sh
-  # precedent). ADR-045 deny-path band hard cap at 700 bytes keeps the
-  # message terse — fail loudly if it bloats.
-  run run_bash_hook "until ! pgrep -f 'bats'; do sleep 5; done"
-  [ "$status" -eq 0 ]
-  [ "${#output}" -lt 700 ]
-}