@windyroad/itil 0.61.1 → 0.61.2

package/scripts/test/check-locale-discipline.bats

@@ -1,291 +0,0 @@
-#!/usr/bin/env bats
-
-# @problem P328 — BSD `grep` / `sed` / `awk` on macOS silently mis-process
-# UTF-8 multi-byte characters (em-dash, smart quotes) without
-# `LC_ALL=en_US.UTF-8` set. Lint detects unprotected invocations so the
-# class of silent-wrong-result bugs can't reach the codebase undetected.
-#
-# Contract: `check-locale-discipline.sh [<repo-root>]` walks scripts under
-# `packages/*/scripts/`, `packages/*/hooks/` (incl. nested `lib/`), and
-# `packages/*/lib/`, then emits one WARN line per unprotected grep/sed/awk
-# invocation. Default Phase 1 advisory exits 0; `WR_LOCALE_DISCIPLINE_WARN_ONLY=0`
-# promotes to Phase 2 load-bearing (exit 1 on any violation).
-#
-# Behavioural fixture (ADR-052 default): every test exercises the script
-# against a synthesised packages/ fixture tree containing known-state
-# scripts. No grep of SKILL.md / agent prose / source content.
-#
-# @adr ADR-040 (advisory-then-load-bearing reusable pattern)
-# @adr ADR-049 (plugin-bundled scripts; PATH shim)
-# @adr ADR-052 (behavioural-tests-default — temp script with known violations)
-# @adr ADR-080 (highest-version-wins shim wrapper)
-# @adr ADR-005 (Plugin testing strategy — bats coverage)
-# @jtbd JTBD-001 (Enforce Governance Without Slowing Down)
-# @jtbd JTBD-101 (Extend the Suite with New Plugins)
-
-setup() {
-  SCRIPTS_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)"
-  SCRIPT="$SCRIPTS_DIR/check-locale-discipline.sh"
-  FIXTURE_ROOT="$(mktemp -d)"
-  mkdir -p "$FIXTURE_ROOT/packages/demo/scripts"
-  mkdir -p "$FIXTURE_ROOT/packages/demo/hooks"
-  mkdir -p "$FIXTURE_ROOT/packages/demo/hooks/lib"
-  mkdir -p "$FIXTURE_ROOT/packages/demo/lib"
-}
-
-teardown() {
-  rm -rf "$FIXTURE_ROOT"
-}
-
-# ── Existence + executable ──────────────────────────────────────────────────
-
-@test "check-locale-discipline: script exists" {
-  [ -f "$SCRIPT" ]
-}
-
-@test "check-locale-discipline: script is executable" {
-  [ -x "$SCRIPT" ]
-}
-
-# ── Negative cases (violations expected) ────────────────────────────────────
-
-@test "check-locale-discipline: grep without LC_ALL emits WARN and counts violation" {
-  cat > "$FIXTURE_ROOT/packages/demo/scripts/raw-grep.sh" <<'EOF'
-#!/usr/bin/env bash
-grep -c '^### ' README.md
-EOF
-  run "$SCRIPT" "$FIXTURE_ROOT"
-  [ "$status" -eq 0 ]  # Phase 1 advisory
-  echo "$output" | grep -E "WARN.*raw-grep.sh:2.*grep without preceding LC_ALL"
-  echo "$output" | grep -E "1 violation"
-}
-
-@test "check-locale-discipline: sed without LC_ALL emits WARN" {
-  cat > "$FIXTURE_ROOT/packages/demo/scripts/raw-sed.sh" <<'EOF'
-#!/usr/bin/env bash
-sed -n '/^### /p' README.md
-EOF
-  run "$SCRIPT" "$FIXTURE_ROOT"
-  [ "$status" -eq 0 ]
-  echo "$output" | grep -E "WARN.*raw-sed.sh:2.*sed without preceding LC_ALL"
-}
-
-@test "check-locale-discipline: awk without LC_ALL emits WARN" {
-  cat > "$FIXTURE_ROOT/packages/demo/scripts/raw-awk.sh" <<'EOF'
-#!/usr/bin/env bash
-awk '/^### /' README.md
-EOF
-  run "$SCRIPT" "$FIXTURE_ROOT"
-  [ "$status" -eq 0 ]
-  echo "$output" | grep -E "WARN.*raw-awk.sh:2.*awk without preceding LC_ALL"
-}
-
-# ── Positive cases (file-wide protection — silent pass) ─────────────────────
-
-@test "check-locale-discipline: file-wide export LC_ALL above grep — silent pass" {
-  cat > "$FIXTURE_ROOT/packages/demo/scripts/protected.sh" <<'EOF'
-#!/usr/bin/env bash
-export LC_ALL=en_US.UTF-8
-grep -c '^### ' README.md
-sed -n '/^### /p' README.md
-awk '/^### /' README.md
-EOF
-  run "$SCRIPT" "$FIXTURE_ROOT"
-  [ "$status" -eq 0 ]
-  ! echo "$output" | grep -qE "protected.sh.*WARN"
-  echo "$output" | grep -E "clean"
-}
-
-@test "check-locale-discipline: inline LC_ALL= prefix on same line — silent pass" {
-  cat > "$FIXTURE_ROOT/packages/demo/scripts/inline.sh" <<'EOF'
-#!/usr/bin/env bash
-LC_ALL=en_US.UTF-8 grep -c '^### ' README.md
-LC_ALL=en_US.UTF-8 sed -n '/^### /p' README.md
-LC_ALL=en_US.UTF-8 awk '/^### /' README.md
-EOF
-  run "$SCRIPT" "$FIXTURE_ROOT"
-  [ "$status" -eq 0 ]
-  ! echo "$output" | grep -qE "inline.sh.*WARN"
-}
-
-# ── Edge cases ──────────────────────────────────────────────────────────────
-
-@test "check-locale-discipline: multiple grep/sed/awk on one line — line is flagged" {
-  cat > "$FIXTURE_ROOT/packages/demo/scripts/multi.sh" <<'EOF'
-#!/usr/bin/env bash
-grep -c '^### ' README.md | sed 's/ //g' | awk '{print $1}'
-EOF
-  run "$SCRIPT" "$FIXTURE_ROOT"
-  [ "$status" -eq 0 ]
-  # At least one tool is reported; we don't over-specify the count.
-  echo "$output" | grep -E "WARN.*multi.sh:2.*(grep|sed|awk) without preceding LC_ALL"
-}
-
-@test "check-locale-discipline: git grep is skipped" {
-  cat > "$FIXTURE_ROOT/packages/demo/scripts/git-grep.sh" <<'EOF'
-#!/usr/bin/env bash
-git grep -nE 'pattern' -- '*.md'
-EOF
-  run "$SCRIPT" "$FIXTURE_ROOT"
-  [ "$status" -eq 0 ]
-  ! echo "$output" | grep -qE "git-grep.sh.*WARN"
-}
-
-@test "check-locale-discipline: heredoc body containing grep is not flagged" {
-  cat > "$FIXTURE_ROOT/packages/demo/scripts/heredoc.sh" <<'EOF'
-#!/usr/bin/env bash
-cat <<'INNER'
-The way to do this is to run: grep '^### ' README.md
-And then: sed -n '/^### /p'
-INNER
-echo "done"
-EOF
-  run "$SCRIPT" "$FIXTURE_ROOT"
-  [ "$status" -eq 0 ]
-  # Heredoc body lines must NOT produce WARNs.
-  ! echo "$output" | grep -qE "heredoc.sh:[34].*WARN"
-}
-
-@test "check-locale-discipline: comment-only line is not flagged" {
-  cat > "$FIXTURE_ROOT/packages/demo/scripts/commented.sh" <<'EOF'
-#!/usr/bin/env bash
-# Future work: replace this awk with a sed | grep pipeline.
-echo "no grep here"
-EOF
-  run "$SCRIPT" "$FIXTURE_ROOT"
-  [ "$status" -eq 0 ]
-  ! echo "$output" | grep -qE "commented.sh.*WARN"
-}
-
-@test "check-locale-discipline: identifiers containing grep/sed/awk substrings are not flagged" {
-  cat > "$FIXTURE_ROOT/packages/demo/scripts/identifiers.sh" <<'EOF'
-#!/usr/bin/env bash
-grep_helper="something"
-result_from_sed=42
-my_awkward_var="x"
-echo "$grep_helper $result_from_sed $my_awkward_var"
-EOF
-  run "$SCRIPT" "$FIXTURE_ROOT"
-  [ "$status" -eq 0 ]
-  ! echo "$output" | grep -qE "identifiers.sh.*WARN"
-}
-
-# ── Scope: hooks/ + lib/ + nested hooks/lib/ ────────────────────────────────
-
-@test "check-locale-discipline: scans packages/*/hooks/ scripts" {
-  cat > "$FIXTURE_ROOT/packages/demo/hooks/raw-grep-hook.sh" <<'EOF'
-#!/usr/bin/env bash
-grep -c '^### ' README.md
-EOF
-  run "$SCRIPT" "$FIXTURE_ROOT"
-  [ "$status" -eq 0 ]
-  echo "$output" | grep -E "WARN.*hooks/raw-grep-hook.sh:2"
-}
-
-@test "check-locale-discipline: scans packages/*/hooks/lib/ scripts" {
-  cat > "$FIXTURE_ROOT/packages/demo/hooks/lib/nested.sh" <<'EOF'
-#!/usr/bin/env bash
-awk '/^### /' README.md
-EOF
-  run "$SCRIPT" "$FIXTURE_ROOT"
-  [ "$status" -eq 0 ]
-  echo "$output" | grep -E "WARN.*hooks/lib/nested.sh:2"
-}
-
-@test "check-locale-discipline: scans packages/*/lib/ scripts" {
-  cat > "$FIXTURE_ROOT/packages/demo/lib/raw-sed-lib.sh" <<'EOF'
-#!/usr/bin/env bash
-sed -n '/^### /p' README.md
-EOF
-  run "$SCRIPT" "$FIXTURE_ROOT"
-  [ "$status" -eq 0 ]
-  echo "$output" | grep -E "WARN.*lib/raw-sed-lib.sh:2"
-}
-
-# ── Phase 1 advisory vs Phase 2 load-bearing ────────────────────────────────
-
-@test "check-locale-discipline: Phase 1 default exits 0 even with violations" {
-  cat > "$FIXTURE_ROOT/packages/demo/scripts/violation.sh" <<'EOF'
-#!/usr/bin/env bash
-grep -c '^### ' README.md
-EOF
-  run "$SCRIPT" "$FIXTURE_ROOT"
-  [ "$status" -eq 0 ]
-}
-
-@test "check-locale-discipline: Phase 2 load-bearing exits 1 on violations" {
-  cat > "$FIXTURE_ROOT/packages/demo/scripts/violation.sh" <<'EOF'
-#!/usr/bin/env bash
-grep -c '^### ' README.md
-EOF
-  WR_LOCALE_DISCIPLINE_WARN_ONLY=0 run "$SCRIPT" "$FIXTURE_ROOT"
-  [ "$status" -eq 1 ]
-}
-
-@test "check-locale-discipline: Phase 2 load-bearing exits 0 on clean tree" {
-  cat > "$FIXTURE_ROOT/packages/demo/scripts/clean.sh" <<'EOF'
-#!/usr/bin/env bash
-export LC_ALL=en_US.UTF-8
-grep -c '^### ' README.md
-EOF
-  WR_LOCALE_DISCIPLINE_WARN_ONLY=0 run "$SCRIPT" "$FIXTURE_ROOT"
-  [ "$status" -eq 0 ]
-}
-
-# ── Argument and error handling ─────────────────────────────────────────────
-
-@test "check-locale-discipline: missing repo-root directory exits 2" {
-  run "$SCRIPT" "$FIXTURE_ROOT/does-not-exist"
-  [ "$status" -eq 2 ]
-  echo "$output" | grep -iE "not a directory"
-}
-
-@test "check-locale-discipline: repo-root without packages/ subdir exits 2" {
-  mkdir -p "$FIXTURE_ROOT/empty"
-  run "$SCRIPT" "$FIXTURE_ROOT/empty"
-  [ "$status" -eq 2 ]
-  echo "$output" | grep -iE "no packages/"
-}
-
-@test "check-locale-discipline: defaults to current working directory when no arg" {
-  cat > "$FIXTURE_ROOT/packages/demo/scripts/violation.sh" <<'EOF'
-#!/usr/bin/env bash
-grep -c '^### ' README.md
-EOF
-  cd "$FIXTURE_ROOT"
-  run "$SCRIPT"
-  [ "$status" -eq 0 ]
-  echo "$output" | grep -E "WARN.*scripts/violation.sh:2"
-}
-
-# ── Output shape ────────────────────────────────────────────────────────────
-
-@test "check-locale-discipline: clean tree emits summary on stdout" {
-  cat > "$FIXTURE_ROOT/packages/demo/scripts/clean.sh" <<'EOF'
-#!/usr/bin/env bash
-export LC_ALL=en_US.UTF-8
-grep -c '^### ' README.md
-EOF
-  run "$SCRIPT" "$FIXTURE_ROOT"
-  [ "$status" -eq 0 ]
-  echo "$output" | grep -E "^check-locale-discipline: clean"
-}
-
-@test "check-locale-discipline: violation summary cites P328" {
-  cat > "$FIXTURE_ROOT/packages/demo/scripts/violation.sh" <<'EOF'
-#!/usr/bin/env bash
-grep -c '^### ' README.md
-EOF
-  run "$SCRIPT" "$FIXTURE_ROOT"
-  [ "$status" -eq 0 ]
-  echo "$output" | grep -E "P328"
-}
-
-# ── Self-application: lint script itself is locale-discipline-compliant ─────
-
-@test "check-locale-discipline: own script declares export LC_ALL at top" {
-  # The lint walks UTF-8 prose; it must lead by example. This guards
-  # against a future edit that strips the export and reintroduces P328
-  # in the lint itself.
-  head -80 "$SCRIPT" | grep -qE "^export LC_ALL=en_US.UTF-8$"
-}

package/scripts/test/check-problems-readme-budget.bats

@@ -1,192 +0,0 @@
-#!/usr/bin/env bats
-
-# @problem P134 — docs/problems/README.md line 3 narrative-blob accumulator
-# bloat. Sibling to P099 (briefing tier 3) on a different surface. The
-# "Last reviewed" line accumulates session-summary fragments unbounded;
-# at ~62 KB it breaks the Read tool entirely (25K-token limit on the
-# whole file regardless of offset/limit). P134 promotes the same
-# advisory-triplet pattern P099 documented (advisory script + behavioural
-# bats + ADR-040-tier-budget enforcement clause) to this surface.
-#
-# Contract: `check-problems-readme-budget.sh [<readme-path>]` is a
-# diagnose-only advisory script. It reads `docs/problems/README.md`
-# (or the supplied path), measures the byte size of line 3, and reports
-# overflow when line 3 is at or above the configured threshold (default
-# 5120 bytes per ADR-040 Tier 3 envelope; overridable via the
-# `PROBLEMS_README_LINE3_MAX_BYTES` env var).
-#
-# Exit codes:
-#   0 = always (advisory only — overflow is signal, not failure)
-#   2 = parse error (README path missing or unreadable)
-#
-# Output format on overflow (one line, terse machine-readable per
-# ADR-038 progressive-disclosure budget):
-#   OVER <readme-path> line=3 bytes=<N> threshold=<N>
-#
-# Output is empty (no lines) when line 3 is under the threshold.
-#
-# The script is read-only — it does NOT mutate the README. Truncation
-# is owned by the per-operation refresh contracts in `manage-problem`
-# Step 5 P094 + Step 7 P062 (and the sibling skills `transition-problem`,
-# `transition-problems`, `review-problems`, `reconcile-readme`).
-#
-# @jtbd JTBD-001 (Enforce Governance Without Slowing Down — restores
-#   Read-tool affordance to the highest-traffic problems-management surface)
-# @jtbd JTBD-006 (Progress the Backlog While I'm Away — every AFK iter's
-#   manage-problem call previously paid an awk/grep workaround tax)
-# @jtbd JTBD-101 (Extend the Suite with Clear Patterns — re-applies P099's
-#   advisory-script + bats + ADR-tier-budget triplet to a new surface,
-#   exactly the reusable shape ADR-040 line 92 documents)
-#
-# Cross-reference:
-#   P134: docs/problems/134-docs-problems-readme-md-line-3-narrative-blob-accumulator-bloat-sibling-p099.*.md
-#   P099: docs/problems/099-briefing-md-grows-unbounded-via-run-retro-appends-violating-progressive-disclosure.*.md
-#   ADR-040 — Session-start briefing surface (Tier 3 budget; line 92's
-#     reusable-pattern note explicitly names "problems index" as a
-#     candidate surface for this triplet)
-#   ADR-038 — Progressive disclosure (per-row terse budget)
-#   ADR-013 Rule 6 — non-interactive fail-safe (advisory-only / exit 0)
-#   ADR-005 — Plugin testing strategy (script-level bats governance)
-
-setup() {
-  SCRIPTS_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)"
-  SCRIPT="$SCRIPTS_DIR/check-problems-readme-budget.sh"
-  FIXTURE_DIR="$(mktemp -d)"
-}
-
-teardown() {
-  rm -rf "$FIXTURE_DIR"
-}
-
-# Helper: write a problems README fixture with the given line-3 byte size.
-# Lines 1, 2 are short header; line 3 is the synthetic "Last reviewed"
-# blob padded to target_bytes; lines 4+ contain a short stub so the
-# multi-line shape mirrors the production README.
-write_problems_readme() {
-  local path="$1"
-  local target_bytes="$2"
-  : > "$path"
-  printf '# Problem Backlog\n\n' >> "$path"
-  if [ "$target_bytes" -gt 0 ]; then
-    # Build a single line of exactly target_bytes bytes (no trailing
-    # newline before the byte budget completes). The newline at the
-    # end is part of the file structure but not counted in line 3's
-    # byte size — `awk 'NR==3' | wc -c` would include it; the script
-    # under test must strip it to match the threshold semantics.
-    local prefix='> Last reviewed: '
-    local prefix_size=${#prefix}
-    local body_target=$(( target_bytes - prefix_size ))
-    if [ "$body_target" -gt 0 ]; then
-      printf '%s' "$prefix" >> "$path"
-      # Append body_target dots — a single contiguous line.
-      printf '%.0s.' $(seq 1 "$body_target") >> "$path"
-    else
-      # target smaller than prefix — emit only the requested bytes
-      printf '%.0s.' $(seq 1 "$target_bytes") >> "$path"
-    fi
-    printf '\n' >> "$path"
-  else
-    printf '\n' >> "$path"
-  fi
-  printf '\n## WSJF Rankings\n\n(stub)\n' >> "$path"
-}
-
-# ── Existence + executable ──────────────────────────────────────────────────
-
-@test "check-problems-readme-budget: script exists" {
-  [ -f "$SCRIPT" ]
-}
-
-@test "check-problems-readme-budget: script is executable" {
-  [ -x "$SCRIPT" ]
-}
-
-# ── Default-threshold behaviour (5120 bytes per ADR-040 Tier 3 envelope) ────
-
-@test "check-problems-readme-budget: line 3 well under threshold produces no output and exits 0" {
-  write_problems_readme "$FIXTURE_DIR/README.md" 1024
-  run "$SCRIPT" "$FIXTURE_DIR/README.md"
-  [ "$status" -eq 0 ]
-  [ -z "$output" ]
-}
-
-@test "check-problems-readme-budget: line 3 at exactly the default threshold emits OVER (>= boundary)" {
-  write_problems_readme "$FIXTURE_DIR/README.md" 5120
-  run "$SCRIPT" "$FIXTURE_DIR/README.md"
-  [ "$status" -eq 0 ]
-  echo "$output" | grep -E "^OVER .*README.md line=3 bytes=5120 threshold=5120$"
-}
-
-@test "check-problems-readme-budget: line 3 well over threshold emits OVER with bytes + threshold" {
-  write_problems_readme "$FIXTURE_DIR/README.md" 12000
-  run "$SCRIPT" "$FIXTURE_DIR/README.md"
-  [ "$status" -eq 0 ]
-  echo "$output" | grep -E "^OVER .*README.md line=3 bytes=12000 threshold=5120$"
-}
-
-@test "check-problems-readme-budget: short line 3 (single fragment ~600 bytes) produces no output" {
-  write_problems_readme "$FIXTURE_DIR/README.md" 600
-  run "$SCRIPT" "$FIXTURE_DIR/README.md"
-  [ "$status" -eq 0 ]
-  [ -z "$output" ]
-}
-
-# ── Configurable threshold via env var ──────────────────────────────────────
-
-@test "check-problems-readme-budget: PROBLEMS_README_LINE3_MAX_BYTES env var overrides default" {
-  write_problems_readme "$FIXTURE_DIR/README.md" 3000
-  # Default 5120: under threshold, no output. With env var set to 2000:
-  # over threshold, expect OVER line.
-  PROBLEMS_README_LINE3_MAX_BYTES=2000 run "$SCRIPT" "$FIXTURE_DIR/README.md"
-  [ "$status" -eq 0 ]
-  echo "$output" | grep -E "^OVER .*README.md line=3 bytes=3000 threshold=2000$"
-}
-
-@test "check-problems-readme-budget: env var threshold of 0 emits OVER for non-empty line 3 (sanity)" {
-  write_problems_readme "$FIXTURE_DIR/README.md" 100
-  PROBLEMS_README_LINE3_MAX_BYTES=0 run "$SCRIPT" "$FIXTURE_DIR/README.md"
-  [ "$status" -eq 0 ]
-  echo "$output" | grep -E "^OVER .*README.md line=3 bytes=100 threshold=0$"
-}
-
-# ── Argument and error handling ─────────────────────────────────────────────
-
-@test "check-problems-readme-budget: defaults to docs/problems/README.md when no arg provided" {
-  cd "$FIXTURE_DIR"
-  mkdir -p docs/problems
-  write_problems_readme docs/problems/README.md 8000
-  run "$SCRIPT"
-  [ "$status" -eq 0 ]
-  echo "$output" | grep -E "^OVER docs/problems/README.md line=3 bytes=8000 threshold=5120$"
-}
-
-@test "check-problems-readme-budget: missing README path exits 2 with parse error on stderr" {
-  run "$SCRIPT" "$FIXTURE_DIR/does-not-exist/README.md"
-  [ "$status" -eq 2 ]
-  echo "$output" | grep -iE "not found|missing|does not exist"
-}
-
-@test "check-problems-readme-budget: file with no line 3 (only 2 lines) exits 0 with no output" {
-  printf '# Problem Backlog\n\n' > "$FIXTURE_DIR/README.md"
-  run "$SCRIPT" "$FIXTURE_DIR/README.md"
-  [ "$status" -eq 0 ]
-  [ -z "$output" ]
-}
-
-@test "check-problems-readme-budget: file with empty line 3 exits 0 with no output" {
-  printf '# Problem Backlog\n\n\n## WSJF Rankings\n\n(stub)\n' > "$FIXTURE_DIR/README.md"
-  run "$SCRIPT" "$FIXTURE_DIR/README.md"
-  [ "$status" -eq 0 ]
-  [ -z "$output" ]
-}
-
-# ── Read-only contract ──────────────────────────────────────────────────────
-
-@test "check-problems-readme-budget: script does not mutate the README under audit" {
-  write_problems_readme "$FIXTURE_DIR/README.md" 12000
-  pre_hash=$(shasum -a 256 "$FIXTURE_DIR/README.md" | awk '{print $1}')
-  run "$SCRIPT" "$FIXTURE_DIR/README.md"
-  [ "$status" -eq 0 ]
-  post_hash=$(shasum -a 256 "$FIXTURE_DIR/README.md" | awk '{print $1}')
-  [ "$pre_hash" = "$post_hash" ]
-}

package/scripts/test/check-rfc-has-stories.bats

@@ -1,69 +0,0 @@
-#!/usr/bin/env bats
-# Behavioural test for check-rfc-has-stories.sh (ADR-089 — every RFC has >=1 story).
-# The predicate exits non-zero when an RFC's `stories:` frontmatter is empty or
-# missing (the empty-stories fallback ADR-089 removes); exit 0 when >=1 story is
-# listed. This is the load-bearing detection half of the proposed->accepted gate.
-#
-# @adr ADR-089 (every RFC has at least one story)
-# @problem P404 (implement ADR-089 + ADR-090)
-
-setup() {
-  REPO_ROOT="$(cd "$(dirname "$BATS_TEST_FILENAME")/../../../.." && pwd)"
-  SCRIPT="${REPO_ROOT}/packages/itil/scripts/check-rfc-has-stories.sh"
-  TMPD="$(mktemp -d)"
-}
-teardown() { rm -rf "$TMPD"; }
-
-@test "check-rfc-has-stories: empty stories: [] is REJECTED (exit non-zero + directive)" {
-  cat > "$TMPD/RFC-901-empty.proposed.md" <<'EOF'
----
-status: proposed
-problems: [P170]
-stories: []
----
-# RFC-901: empty
-EOF
-  run bash "$SCRIPT" "$TMPD/RFC-901-empty.proposed.md"
-  [ "$status" -ne 0 ]
-  [[ "$output" == *"stories"* ]]
-}
-
-@test "check-rfc-has-stories: missing stories: field is REJECTED" {
-  cat > "$TMPD/RFC-902-none.proposed.md" <<'EOF'
----
-status: proposed
-problems: [P170]
----
-# RFC-902: no stories field
-EOF
-  run bash "$SCRIPT" "$TMPD/RFC-902-none.proposed.md"
-  [ "$status" -ne 0 ]
-  [[ "$output" == *"stories"* ]]
-}
-
-@test "check-rfc-has-stories: inline >=1 story is ACCEPTED (exit 0)" {
-  cat > "$TMPD/RFC-903-ok.proposed.md" <<'EOF'
----
-status: proposed
-problems: [P170]
-stories: [STORY-020, STORY-021]
----
-# RFC-903: has stories
-EOF
-  run bash "$SCRIPT" "$TMPD/RFC-903-ok.proposed.md"
-  [ "$status" -eq 0 ]
-}
-
-@test "check-rfc-has-stories: block-list >=1 story is ACCEPTED (exit 0)" {
-  cat > "$TMPD/RFC-904-block.proposed.md" <<'EOF'
----
-status: proposed
-problems: [P170]
-stories:
-  - STORY-020
----
-# RFC-904: block-list stories
-EOF
-  run bash "$SCRIPT" "$TMPD/RFC-904-block.proposed.md"
-  [ "$status" -eq 0 ]
-}

package/scripts/test/check-rfc-rejected-alternatives.bats

@@ -1,108 +0,0 @@
-#!/usr/bin/env bats
-
-# @problem P310 — RFCs carry independent decisions invisible to the ADR-066
-#   human-oversight net. ADR-070 closes the blind spot; this lint enforces it.
-# @adr ADR-070 (RFCs hold no independent decisions — the invariant under test)
-# @adr ADR-052 (behavioural-tests-default — this is an artefact-state behavioural
-#   assertion: it RUNS the checker against fixture RFC corpora + the real corpus
-#   and asserts the verdict (exit code + output). It does NOT structurally grep
-#   the checker's own source, the SKILL.md, or any agent prose — that would be
-#   the P081 structural-test-disguised-as-behavioural anti-pattern.)
-# @adr ADR-071 (every fix via RFC — composes; the lint guards the RFC corpus)
-#
-# Contract under test (ADR-070 § Confirmation): no RFC body in docs/rfcs/
-# contains a "Considered Options / Alternatives Rejected" HEADING block
-# without a matching `adrs:` frontmatter reference. The detector targets a
-# markdown heading, never a prose mention of the phrase.
-
-setup() {
-  REPO_ROOT="$(cd "$(dirname "$BATS_TEST_FILENAME")/../../../.." && pwd)"
-  SCRIPT="$REPO_ROOT/packages/itil/scripts/check-rfc-rejected-alternatives.sh"
-  FIXTURE_DIR="$(mktemp -d)"
-}
-
-teardown() {
-  rm -rf "$FIXTURE_DIR"
-}
-
-# ── Fixture helper: write an RFC file with given adrs-line + body ────────────
-write_rfc() {
-  local name="$1" adrs_line="$2" body="$3"
-  cat > "$FIXTURE_DIR/$name" <<EOF
----
-status: accepted
-rfc-id: ${name%.md}
-problems: [P999]
-$adrs_line
-stories: []
----
-
-# ${name%.md}: fixture
-
-## Summary
-
-A fixture RFC.
-
-$body
-EOF
-}
-
-@test "violation: rejected-alternatives heading block WITH empty adrs: -> exit 1 + VIOLATION" {
-  write_rfc "RFC-901-bad.md" "adrs: []" $'## Considered Options / Alternatives Rejected\n\n- F1 alternative rejected: foo.'
-  run bash "$SCRIPT" "$FIXTURE_DIR"
-  [ "$status" -eq 1 ]
-  [[ "$output" == *"VIOLATION"* ]]
-  [[ "$output" == *"RFC-901-bad.md"* ]]
-}
-
-@test "allowed: rejected-alternatives heading block WITH a matching adrs: reference -> exit 0 (clean)" {
-  write_rfc "RFC-902-homed.md" "adrs: [ADR-072, ADR-073]" $'## Considered Options / Alternatives Rejected\n\n- The contested choice is recorded in ADR-072; this block references it.'
-  run bash "$SCRIPT" "$FIXTURE_DIR"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"clean"* ]]
-}
-
-@test "clean: no rejected-alternatives block, empty adrs: -> exit 0" {
-  write_rfc "RFC-903-scope.md" "adrs: []" $'## Scope\n\nPure scope + decomposition + traces. No decisions here.'
-  run bash "$SCRIPT" "$FIXTURE_DIR"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"clean"* ]]
-}
-
-@test "prose mention (not a heading) of the phrase does NOT trigger -> exit 0" {
-  # Guards the RFC-005 retrofit-banner false positive: a blockquote/prose line
-  # mentioning the struck section must not be flagged.
-  write_rfc "RFC-904-retrofit.md" "adrs: []" $'> Retrofitted: this RFC originally carried a "Considered Options / Alternatives Rejected" section, now struck per ADR-070.'
-  run bash "$SCRIPT" "$FIXTURE_DIR"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"clean"* ]]
-}
-
-@test "variant heading 'Alternatives Rejected' WITH empty adrs: -> exit 1" {
-  write_rfc "RFC-905-variant.md" "adrs: []" $'### Alternatives Rejected\n\n- rejected: bar.'
-  run bash "$SCRIPT" "$FIXTURE_DIR"
-  [ "$status" -eq 1 ]
-  [[ "$output" == *"RFC-905-variant.md"* ]]
-}
-
-@test "mixed corpus: one violation among clean RFCs -> exit 1, names only the offender" {
-  write_rfc "RFC-906-ok.md" "adrs: [ADR-001]" $'## Considered Options\n\n- references ADR-001.'
-  write_rfc "RFC-907-bad.md" "adrs: []" $'## Considered Options\n\n- no adr.'
-  write_rfc "RFC-908-scope.md" "adrs: []" $'## Scope\n\nclean.'
-  run bash "$SCRIPT" "$FIXTURE_DIR"
-  [ "$status" -eq 1 ]
-  [[ "$output" == *"RFC-907-bad.md"* ]]
-  [[ "$output" != *"RFC-906-ok.md"* ]]
-  [[ "$output" != *"RFC-908-scope.md"* ]]
-}
-
-@test "non-existent directory -> exit 2 (usage error)" {
-  run bash "$SCRIPT" "$FIXTURE_DIR/does-not-exist"
-  [ "$status" -eq 2 ]
-}
-
-@test "dogfood: the real docs/rfcs/ corpus is clean -> exit 0" {
-  run bash "$SCRIPT" "$REPO_ROOT/docs/rfcs"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"clean"* ]]
-}