@windyroad/itil 0.61.1 → 0.61.2

package/hooks/test/manage-problem-enforce-create.bats

@@ -1,424 +0,0 @@
-#!/usr/bin/env bats
-
-# P119: manage-problem-enforce-create.sh PreToolUse hook must block new-file
-# Write to docs/problems/<NNN>-*.<status>.md until /wr-itil:manage-problem
-# Step 2 (duplicate-check) has run for the current session.
-#
-# Marker: /tmp/manage-problem-grep-${SESSION_ID} (set by Step 2 grep
-# completion). Per-session scope so a single skill invocation can write
-# multiple tickets (Step 4b multi-concern split) without re-grep blocking.
-#
-# Per feedback_behavioural_tests.md (P081): behavioural assertions —
-# simulate the hook's payload on stdin and assert on emitted JSON
-# permissionDecision and exit status. No source-grep on hook content.
-#
-# ADR-031 forward-compat: matcher uses docs/problems/ prefix +
-# numeric-prefix basename test, agnostic to current suffix-based
-# layout vs future per-state subdirectory layout.
-
-setup() {
-  SCRIPT_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)"
-  HOOK="$SCRIPT_DIR/manage-problem-enforce-create.sh"
-  ORIG_DIR="$PWD"
-  TEST_DIR=$(mktemp -d)
-  cd "$TEST_DIR"
-  mkdir -p docs/problems docs/rfcs
-  SID="mp-create-test-$$-$RANDOM"
-}
-
-teardown() {
-  cd "$ORIG_DIR"
-  rm -rf "$TEST_DIR"
-  rm -f "/tmp/manage-problem-grep-${SID}"
-  rm -f "/tmp/wr-itil-rfc-capture-grep-${SID}"
-}
-
-set_rfc_marker() {
-  : > "/tmp/wr-itil-rfc-capture-grep-${SID}"
-}
-
-# Helper: run the hook with mock JSON for a Write tool call to file_path
-run_write_hook() {
-  local file_path="$1"
-  local sid="$2"
-  local json
-  json=$(printf '{"tool_name":"Write","tool_input":{"file_path":"%s"},"session_id":"%s"}' "$file_path" "$sid")
-  echo "$json" | bash "$HOOK"
-}
-
-# Helper: run the hook with mock JSON for an Edit tool call to file_path
-run_edit_hook() {
-  local file_path="$1"
-  local sid="$2"
-  local json
-  json=$(printf '{"tool_name":"Edit","tool_input":{"file_path":"%s"},"session_id":"%s"}' "$file_path" "$sid")
-  echo "$json" | bash "$HOOK"
-}
-
-set_marker() {
-  : > "/tmp/manage-problem-grep-${SID}"
-}
-
-# --- Core deny path: new-file Write without marker ---
-
-@test "deny: Write to new docs/problems/999-foo.open.md without marker" {
-  run run_write_hook "$PWD/docs/problems/999-foo.open.md" "$SID"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"\"permissionDecision\": \"deny\""* ]]
-  [[ "$output" == *"BLOCKED"* ]]
-  [[ "$output" == *"manage-problem"* ]]
-}
-
-@test "deny message names the skill the agent must invoke" {
-  run run_write_hook "$PWD/docs/problems/999-foo.open.md" "$SID"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"/wr-itil:manage-problem"* ]]
-}
-
-# --- Allow paths ---
-
-@test "allow: Write to new docs/problems/999-foo.open.md WITH marker" {
-  set_marker
-  run run_write_hook "$PWD/docs/problems/999-foo.open.md" "$SID"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"BLOCKED"* ]]
-  [[ "$output" != *"\"permissionDecision\": \"deny\""* ]]
-}
-
-@test "allow: marker permits multiple consecutive Writes (multi-concern split, Step 4b)" {
-  set_marker
-  run run_write_hook "$PWD/docs/problems/998-foo.open.md" "$SID"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"BLOCKED"* ]]
-  run run_write_hook "$PWD/docs/problems/999-bar.open.md" "$SID"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"BLOCKED"* ]]
-}
-
-@test "allow: Write to docs/problems/README.md regardless of marker" {
-  # README is regenerated by Steps 5/6/7 — chicken-and-egg per ticket Out of Scope
-  run run_write_hook "$PWD/docs/problems/README.md" "$SID"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"BLOCKED"* ]]
-}
-
-@test "allow: Edit (not Write) to existing ticket regardless of marker" {
-  echo "stub" > docs/problems/042-existing.open.md
-  run run_edit_hook "$PWD/docs/problems/042-existing.open.md" "$SID"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"BLOCKED"* ]]
-}
-
-@test "allow: Write to existing ticket file (overwrite) regardless of marker" {
-  # Existing file = not a new ticket creation — Edit-flow / status transitions
-  # are governed by /wr-itil:transition-problem, not this hook.
-  echo "stub" > docs/problems/042-existing.open.md
-  run run_write_hook "$PWD/docs/problems/042-existing.open.md" "$SID"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"BLOCKED"* ]]
-}
-
-@test "allow: Write to non-docs/problems path regardless of marker" {
-  run run_write_hook "$PWD/src/component.tsx" "$SID"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"BLOCKED"* ]]
-}
-
-@test "allow: Write to docs/problems/ non-numeric basename (e.g. NOTES.md)" {
-  # Only docs/problems/<NNN>-*.md ticket-shaped paths are gated. Other
-  # docs in this directory (e.g. NOTES.md, archive/index.md) are not
-  # tickets and don't need the duplicate-check.
-  run run_write_hook "$PWD/docs/problems/NOTES.md" "$SID"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"BLOCKED"* ]]
-}
-
-# --- Status-suffix coverage (ADR-022 lifecycle) ---
-
-@test "deny: new .known-error.md without marker" {
-  run run_write_hook "$PWD/docs/problems/999-foo.known-error.md" "$SID"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"BLOCKED"* ]]
-}
-
-@test "deny: new .verifying.md without marker" {
-  run run_write_hook "$PWD/docs/problems/999-foo.verifying.md" "$SID"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"BLOCKED"* ]]
-}
-
-@test "deny: new .parked.md without marker" {
-  run run_write_hook "$PWD/docs/problems/999-foo.parked.md" "$SID"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"BLOCKED"* ]]
-}
-
-# --- Tool-name and edge cases ---
-
-@test "allow: empty session_id (fail-open for parse failure parity with sibling hooks)" {
-  # Mirror jtbd-enforce-edit.sh: empty session_id => exit 0 without deny.
-  run bash -c "echo '{\"tool_name\":\"Write\",\"tool_input\":{\"file_path\":\"$PWD/docs/problems/999-foo.open.md\"}}' | bash $HOOK"
-  [ "$status" -eq 0 ]
-  # No deny — empty session is the parse-error / fallback shape
-  [[ "$output" != *"\"permissionDecision\": \"deny\""* ]] || skip "fail-closed parse error is also acceptable; assert in parse-failure test"
-}
-
-@test "allow: empty file_path exits 0 without action" {
-  run bash -c "echo '{\"tool_name\":\"Write\",\"tool_input\":{},\"session_id\":\"$SID\"}' | bash $HOOK"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"BLOCKED"* ]]
-}
-
-# --- ADR-031 forward-compat: per-state subdirectory shape ---
-
-@test "deny: hypothetical ADR-031 layout docs/problems/open/999-foo.md without marker" {
-  # If/when ADR-031 lands and tickets move to docs/problems/<state>/<NNN>-...md,
-  # the hook must still gate them. Matcher should be path-prefix +
-  # numeric-prefix basename, not suffix-based.
-  mkdir -p docs/problems/open
-  run run_write_hook "$PWD/docs/problems/open/999-foo.md" "$SID"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"BLOCKED"* ]]
-}
-
-# --- Marker hygiene ---
-
-@test "marker file presence is the gate signal — touching marker after first deny unblocks subsequent Write" {
-  run run_write_hook "$PWD/docs/problems/999-foo.open.md" "$SID"
-  [[ "$output" == *"BLOCKED"* ]]
-  set_marker
-  run run_write_hook "$PWD/docs/problems/999-foo.open.md" "$SID"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"BLOCKED"* ]]
-}
-
-# --- P142 / ADR-050: deny-message simplicity post-supersession ---
-#
-# ADR-048 documented a two-tier recovery procedure for SID-mismatch denials
-# (when the helper picked a stale subprocess SID while the runtime hook saw
-# the orchestrator SID). The hook appended a "Helper succeeded but SID
-# mismatch detected — see manage-problem SKILL.md Step 2 substep 7."
-# pointer when SOME marker existed for SOME SID (the helper-bug signal).
-#
-# P142 / ADR-050 superseded ADR-048 by capturing the runtime stdin SID
-# in a per-machine marker via a new PreToolUse hook
-# (`itil-runtime-sid-marker.sh`). The helper reads the marker as
-# authoritative; SID-mismatch is structurally impossible in routine flow.
-# The conditional RECOVERY_HINT was removed; the deny message stays
-# terse and skill-pointing regardless of marker presence.
-#
-# These tests pin that the deny message is INVARIANT of the
-# /tmp/manage-problem-grep-* marker state (no recovery-hint branching).
-
-setup_other_sid_marker() {
-  OTHER_SID="other-sid-$$-$RANDOM"
-  : > "/tmp/manage-problem-grep-${OTHER_SID}"
-}
-
-teardown_other_sid_marker() {
-  if [ -n "${OTHER_SID:-}" ]; then
-    rm -f "/tmp/manage-problem-grep-${OTHER_SID}"
-  fi
-}
-
-@test "deny without ANY /tmp/manage-problem-grep-* marker → deny is terse, no recovery prose" {
-  rm -f /tmp/manage-problem-grep-*
-  run run_write_hook "$PWD/docs/problems/999-foo.open.md" "$SID"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"BLOCKED"* ]]
-  [[ "$output" != *"SID mismatch"* ]]
-  [[ "$output" != *"Step 2 substep 7"* ]]
-}
-
-@test "deny with /tmp/manage-problem-grep-* marker for OTHER SID → deny is terse (post-ADR-050; no recovery hint)" {
-  # Pre-ADR-050 contract: an other-SID marker triggered the helper-bug
-  # recovery pointer. Post-ADR-050: the runtime-SID marker prevents
-  # SID-mismatch in routine flow, so the recovery pointer is removed.
-  # The deny message is identical regardless of marker presence — the
-  # only signal that matters is "this session has not run Step 2".
-  rm -f /tmp/manage-problem-grep-*
-  setup_other_sid_marker
-  run run_write_hook "$PWD/docs/problems/999-foo.open.md" "$SID"
-  status=$?
-  teardown_other_sid_marker
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"BLOCKED"* ]]
-  [[ "$output" != *"SID mismatch"* ]]
-  [[ "$output" != *"Step 2 substep 7"* ]]
-}
-
-# --- P170 / ADR-060: RFC tier extension ---
-#
-# The hook gate covers both docs/problems/ and docs/rfcs/. Each tier has its
-# own marker (problems: /tmp/manage-problem-grep-${SID};
-# rfcs: /tmp/wr-itil-rfc-capture-grep-${SID}) and its own deny message
-# pointing to the right skill (manage-problem vs capture-rfc).
-
-@test "rfcs deny: Write to new docs/rfcs/RFC-001-foo.proposed.md without RFC marker" {
-  run run_write_hook "$PWD/docs/rfcs/RFC-001-foo.proposed.md" "$SID"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"\"permissionDecision\": \"deny\""* ]]
-  [[ "$output" == *"BLOCKED"* ]]
-}
-
-@test "rfcs deny message names capture-rfc skill (not manage-problem)" {
-  run run_write_hook "$PWD/docs/rfcs/RFC-001-foo.proposed.md" "$SID"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"/wr-itil:capture-rfc"* ]]
-  [[ "$output" != *"/wr-itil:manage-problem"* ]]
-}
-
-@test "rfcs deny message names the I1 trace-to-problem invariant + ADR-060" {
-  run run_write_hook "$PWD/docs/rfcs/RFC-001-foo.proposed.md" "$SID"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"problem-trace"* ]]
-  [[ "$output" == *"ADR-060"* ]]
-}
-
-@test "rfcs allow: Write to new docs/rfcs/RFC-001-foo.proposed.md WITH RFC marker" {
-  set_rfc_marker
-  run run_write_hook "$PWD/docs/rfcs/RFC-001-foo.proposed.md" "$SID"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"BLOCKED"* ]]
-  [[ "$output" != *"\"permissionDecision\": \"deny\""* ]]
-}
-
-@test "rfcs allow: Write to docs/rfcs/README.md regardless of marker (chicken-and-egg)" {
-  run run_write_hook "$PWD/docs/rfcs/README.md" "$SID"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"BLOCKED"* ]]
-}
-
-@test "rfcs allow: Write to docs/rfcs/ non-RFC basename (e.g. NOTES.md) regardless of marker" {
-  run run_write_hook "$PWD/docs/rfcs/NOTES.md" "$SID"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"BLOCKED"* ]]
-}
-
-@test "rfcs deny: Write across all RFC lifecycle suffixes without marker (proposed/accepted/in-progress/verifying/closed)" {
-  for suffix in proposed accepted in-progress verifying closed; do
-    run run_write_hook "$PWD/docs/rfcs/RFC-001-foo.${suffix}.md" "$SID"
-    [ "$status" -eq 0 ]
-    [[ "$output" == *"BLOCKED"* ]] || { echo "expected deny for suffix=$suffix"; return 1; }
-  done
-}
-
-@test "rfcs marker independence: problem marker does NOT unlock RFC writes" {
-  # The two markers are siblings, not interchangeable. Setting the
-  # problem-tier marker should NOT bypass the RFC-tier gate.
-  set_marker
-  run run_write_hook "$PWD/docs/rfcs/RFC-001-foo.proposed.md" "$SID"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"BLOCKED"* ]]
-  [[ "$output" == *"capture-rfc"* ]]
-}
-
-@test "problems marker independence: RFC marker does NOT unlock problem writes" {
-  # Inverse direction — preserves audit-trail per-surface granularity.
-  set_rfc_marker
-  run run_write_hook "$PWD/docs/problems/999-foo.open.md" "$SID"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"BLOCKED"* ]]
-  [[ "$output" == *"manage-problem"* ]]
-}
-
-@test "rfcs allow: existing RFC file (overwrite) regardless of marker" {
-  echo "stub" > docs/rfcs/RFC-001-foo.proposed.md
-  run run_write_hook "$PWD/docs/rfcs/RFC-001-foo.proposed.md" "$SID"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"BLOCKED"* ]]
-}
-
-@test "rfcs allow: Edit (not Write) regardless of marker" {
-  echo "stub" > docs/rfcs/RFC-001-foo.proposed.md
-  run run_edit_hook "$PWD/docs/rfcs/RFC-001-foo.proposed.md" "$SID"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"BLOCKED"* ]]
-}
-
-@test "rfcs deny: bare numeric basename (no RFC- prefix) does NOT match the rfcs gate" {
-  # Defensive: a docs/rfcs/123-foo.proposed.md (no RFC- prefix) is not
-  # an RFC by naming convention; it should NOT trigger the gate.
-  # (If the user accidentally creates such a file, it's project
-  # housekeeping, not a ticket.)
-  run run_write_hook "$PWD/docs/rfcs/123-no-prefix.proposed.md" "$SID"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"BLOCKED"* ]]
-}
-
-# --- P260: concurrent orchestrator+subprocess create-gate marker race ---
-#
-# /wr-itil:work-problems Step 5 BACKGROUNDS the iter subprocess
-# (`claude -p ... &`) and runs an idle-timeout poll loop in the
-# orchestrator's main turn, so the orchestrator fires PreToolUse hooks
-# CONCURRENTLY with the running subprocess. Both sessions write the same
-# per-machine runtime-sid marker (same project ⇒ same proj_hash),
-# last-writer-wins. When the orchestrator captures a ticket while the
-# subprocess holds the runtime-sid, the single-SID Step-2 marker-write
-# (`sid=$(get_current_session_id) && mark_step2_complete "$sid"`) lands the
-# marker under the SUBPROCESS SID, but the orchestrator's Write fires the
-# PreToolUse:Write hook whose stdin session_id is the ORCHESTRATOR SID ⇒
-# marker mismatch ⇒ deny. This was P260 (the 2026-05-18 P254/P255 foreground
-# captures). ADR-050 Option C (architect-resolved + human-confirmed
-# 2026-05-26) is the fix: the candidate-set marker-write
-# (`get_candidate_session_ids | mark_step2_complete_candidates`) writes the
-# marker under EVERY recent candidate SID, so whichever SID the hook reads,
-# a matching marker exists.
-#
-# These tests are end-to-end: they run the real agent-side marker-write
-# helpers under the concurrent fixture, then fire the real hook with the
-# orchestrator's stdin SID and assert the observable permit/deny outcome.
-
-# Build the concurrent fixture in a sandbox marker dir: orchestrator
-# announced first (older mtime), subprocess announced later (newer mtime),
-# and the subprocess clobbered the runtime-sid marker last.
-p260_setup_concurrent_fixture() {
-  P260_SANDBOX=$(mktemp -d)
-  P260_ORCH_SID="p260-orch-$$-$RANDOM"
-  P260_SUB_SID="p260-sub-$$-$RANDOM"
-  : > "$P260_SANDBOX/architect-announced-${P260_ORCH_SID}"
-  sleep 1
-  : > "$P260_SANDBOX/jtbd-announced-${P260_SUB_SID}"
-  printf '%s' "$P260_SUB_SID" > "$P260_SANDBOX/itil-runtime-sid.current"
-}
-
-p260_teardown_concurrent_fixture() {
-  rm -f "/tmp/manage-problem-grep-${P260_ORCH_SID}" \
-        "/tmp/manage-problem-grep-${P260_SUB_SID}"
-  rm -rf "$P260_SANDBOX"
-}
-
-@test "P260: candidate-set marker-write PERMITS the orchestrator Write despite runtime-sid clobbered to the subprocess SID" {
-  p260_setup_concurrent_fixture
-  # Agent-side Step 2 marker write under the FULL candidate set (Option C).
-  SESSION_MARKER_DIR="$P260_SANDBOX" bash -c "
-    source '$SCRIPT_DIR/lib/session-id.sh'
-    source '$SCRIPT_DIR/lib/create-gate.sh'
-    get_candidate_session_ids | mark_step2_complete_candidates
-  "
-  # The orchestrator's Write carries the orchestrator SID on its stdin.
-  run run_write_hook "$PWD/docs/problems/997-concurrent-capture.open.md" "$P260_ORCH_SID"
-  p260_teardown_concurrent_fixture
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"BLOCKED"* ]]
-  [[ "$output" != *"\"permissionDecision\": \"deny\""* ]]
-}
-
-@test "P260 negative control: single-SID marker-write (pre-Option-C behaviour) DENIES the orchestrator Write under the same race" {
-  # Pins WHY Option C is needed: the old single-SID write lands the marker
-  # under the subprocess SID (the clobbered runtime value), so the
-  # orchestrator's Write — stdin = orchestrator SID — is denied. This is
-  # the reproduced P260 failure; the candidate-set write above is what
-  # fixes it.
-  p260_setup_concurrent_fixture
-  SESSION_MARKER_DIR="$P260_SANDBOX" bash -c "
-    source '$SCRIPT_DIR/lib/session-id.sh'
-    source '$SCRIPT_DIR/lib/create-gate.sh'
-    sid=\$(get_current_session_id) && mark_step2_complete \"\$sid\"
-  "
-  run run_write_hook "$PWD/docs/problems/996-concurrent-capture.open.md" "$P260_ORCH_SID"
-  p260_teardown_concurrent_fixture
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"\"permissionDecision\": \"deny\""* ]]
-  [[ "$output" == *"BLOCKED"* ]]
-}

package/hooks/test/p057-staging-trap-detect.bats

@@ -1,231 +0,0 @@
-#!/usr/bin/env bats
-
-# P125: p057-staging-trap-detect.sh PreToolUse:Bash hook must detect the
-# rename-then-edit-without-re-stage pattern that drops post-rename edits
-# into the next commit (P057 staging trap).
-#
-# Detection logic (per ticket Fix Strategy):
-#   On `git commit` invocations, run `git diff --staged --name-status`
-#   and `git diff --name-only`. If a file appears in --staged with an
-#   `R<num>` (rename) status AND in working-tree `git diff --name-only`
-#   as modified, the trap shape is present — emit a deny with recovery
-#   command `git add <new-path>` and the P057 cite.
-#
-# Per ADR-005 (plugin testing strategy) — hook bats live under
-# packages/<plugin>/hooks/test/ and assert behaviour on emitted JSON,
-# not source-content. ADR-037 partitions skill tests separately.
-#
-# Per feedback_behavioural_tests.md (P081) — no source-grep on hook
-# text. Simulate the PreToolUse:Bash payload on stdin and assert on
-# the emitted permissionDecision.
-
-setup() {
-  SCRIPT_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)"
-  HOOK="$SCRIPT_DIR/p057-staging-trap-detect.sh"
-  ORIG_DIR="$PWD"
-  TEST_DIR=$(mktemp -d)
-  cd "$TEST_DIR"
-  git init --quiet -b main
-  git config user.email "test@example.com"
-  git config user.name "Test"
-  echo "original" > foo.md
-  git add foo.md
-  git -c commit.gpgsign=false commit --quiet -m "initial"
-}
-
-teardown() {
-  cd "$ORIG_DIR"
-  rm -rf "$TEST_DIR"
-}
-
-# Helper: simulate the PreToolUse:Bash payload on stdin.
-run_bash_hook() {
-  local cmd="$1"
-  local json
-  json=$(printf '{"tool_name":"Bash","tool_input":{"command":"%s"}}' "$cmd")
-  echo "$json" | bash "$HOOK"
-}
-
-# --- Trap detection: the canonical P057 shape ---
-
-@test "deny: rename + post-rename edit without re-stage triggers deny on git commit" {
-  git mv foo.md bar.md
-  echo "modified content" > bar.md
-  run run_bash_hook "git commit -m 'test'"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"\"permissionDecision\": \"deny\""* ]]
-  [[ "$output" == *"P057"* ]]
-  [[ "$output" == *"bar.md"* ]]
-  [[ "$output" == *"git add bar.md"* ]]
-}
-
-# --- Allow paths: each non-trap shape must NOT deny ---
-
-@test "allow: rename + post-rename edit + re-stage allows the commit" {
-  git mv foo.md bar.md
-  echo "modified content" > bar.md
-  git add bar.md
-  run run_bash_hook "git commit -m 'test'"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"\"permissionDecision\": \"deny\""* ]]
-}
-
-@test "allow: pure rename without subsequent edit allows the commit" {
-  git mv foo.md bar.md
-  run run_bash_hook "git commit -m 'test'"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"\"permissionDecision\": \"deny\""* ]]
-}
-
-@test "allow: modify-only batch (no rename) allows the commit" {
-  echo "modified" > foo.md
-  git add foo.md
-  run run_bash_hook "git commit -m 'test'"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"\"permissionDecision\": \"deny\""* ]]
-}
-
-@test "allow: empty batch (nothing staged, nothing modified) allows the commit" {
-  run run_bash_hook "git commit -m 'test'"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"\"permissionDecision\": \"deny\""* ]]
-}
-
-# --- Tool-name and command-shape filters ---
-
-@test "allow: non-Bash tool exits 0 without deny" {
-  run bash -c "echo '{\"tool_name\":\"Edit\",\"tool_input\":{\"file_path\":\"foo.md\"}}' | bash $HOOK"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"\"permissionDecision\": \"deny\""* ]]
-}
-
-@test "allow: Bash command that is NOT git commit (e.g., git status) bypasses detection" {
-  # Trap shape IS present in the working tree, but the command isn't
-  # `git commit` — the hook only fires on commit invocations.
-  git mv foo.md bar.md
-  echo "modified" > bar.md
-  run run_bash_hook "git status"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"\"permissionDecision\": \"deny\""* ]]
-}
-
-# --- Parse / fail-open (mirror create-gate.sh's exit-0 on parse failure) ---
-
-@test "allow: empty JSON exits 0 without deny (fail-open on parse-incomplete)" {
-  run bash -c "echo '{}' | bash $HOOK"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"\"permissionDecision\": \"deny\""* ]]
-}
-
-# --- Deny message contract (ADR-038 progressive disclosure budget) ---
-
-@test "deny message names the file, recovery command, and P057 cite" {
-  git mv foo.md bar.md
-  echo "modified" > bar.md
-  run run_bash_hook "git commit -m 'test'"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"P057"* ]]
-  [[ "$output" == *"git add bar.md"* ]]
-  [[ "$output" == *"bar.md"* ]]
-}
-
-@test "deny message stays under ADR-038 progressive-disclosure budget (<400 bytes)" {
-  # Voice-tone draft target is ~245 bytes; allow generous headroom for
-  # JSON envelope. Hard cap at 400 keeps the message terse per
-  # ADR-038 — fail loudly if the message bloats over time.
-  git mv foo.md bar.md
-  echo "modified" > bar.md
-  run run_bash_hook "git commit -m 'test'"
-  [ "$status" -eq 0 ]
-  [ "${#output}" -lt 400 ]
-}
-
-# --- P273 / P268: leading-executable command detection regression cases ---
-#
-# The hook must fire on ACTUAL `git commit` invocations, NOT on Bash that
-# merely MENTIONS the phrase "git commit" in argument vectors or heredoc
-# bodies. Mirrors the P268 regression fixtures landed in
-# command-detect.bats and the P272 sibling fixtures in
-# itil-changeset-discipline.bats.
-
-@test "allow: grep with literal 'git commit' pattern in trap state does NOT deny" {
-  # Trap shape IS present in the working tree, but the Bash is a grep
-  # invocation whose pattern argument MENTIONS "git commit" — the hook
-  # must not fire (leading executable is `grep`, not `git`).
-  git mv foo.md bar.md
-  echo "modified" > bar.md
-  run run_bash_hook "grep -r 'git commit' ."
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"\"permissionDecision\": \"deny\""* ]]
-}
-
-@test "allow: sed pattern containing 'git commit' in trap state does NOT deny" {
-  git mv foo.md bar.md
-  echo "modified" > bar.md
-  run run_bash_hook "sed -n 's/git commit/X/p' bar.md"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"\"permissionDecision\": \"deny\""* ]]
-}
-
-@test "allow: echo with literal 'git commit' string in trap state does NOT deny" {
-  git mv foo.md bar.md
-  echo "modified" > bar.md
-  run run_bash_hook "echo 'run git commit -m foo'"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"\"permissionDecision\": \"deny\""* ]]
-}
-
-@test "allow: cat heredoc body containing 'git commit' in trap state does NOT deny" {
-  git mv foo.md bar.md
-  echo "modified" > bar.md
-  run run_bash_hook "cat <<EOF
-prose mentioning git commit invocations
-EOF"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"\"permissionDecision\": \"deny\""* ]]
-}
-
-@test "allow: git log --grep with 'git commit' search term does NOT deny" {
-  git mv foo.md bar.md
-  echo "modified" > bar.md
-  run run_bash_hook "git log --grep='git commit'"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"\"permissionDecision\": \"deny\""* ]]
-}
-
-@test "allow: git commit-tree plumbing in trap state does NOT deny (boundary)" {
-  # `git commit-tree` is a different git subcommand — the helper must
-  # not match it on the `commit-*` boundary.
-  git mv foo.md bar.md
-  echo "modified" > bar.md
-  run run_bash_hook "git commit-tree HEAD^{tree} -m 'msg'"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"\"permissionDecision\": \"deny\""* ]]
-}
-
-# --- P273 / P268: positive leading-executable cases still deny ---
-
-@test "deny: env-var-prefixed git commit in trap state still triggers deny" {
-  git mv foo.md bar.md
-  echo "modified" > bar.md
-  run run_bash_hook "GIT_AUTHOR_NAME=foo git commit -m 'test'"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"\"permissionDecision\": \"deny\""* ]]
-  [[ "$output" == *"P057"* ]]
-}
-
-@test "deny: cd-prefixed git commit in trap state still triggers deny" {
-  git mv foo.md bar.md
-  echo "modified" > bar.md
-  run run_bash_hook "cd . && git commit -m 'test'"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"\"permissionDecision\": \"deny\""* ]]
-}
-
-@test "deny: leading-whitespace git commit in trap state still triggers deny" {
-  git mv foo.md bar.md
-  echo "modified" > bar.md
-  run run_bash_hook "   git commit -m 'test'"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"\"permissionDecision\": \"deny\""* ]]
-}