@windyroad/itil 0.61.1 → 0.61.2

package/scripts/migrate-problems-add-type.sh

@@ -1,116 +0,0 @@
-#!/usr/bin/env bash
-# packages/itil/scripts/migrate-problems-add-type.sh
-#
-# One-shot bulk migration: ensure every `<problems-dir>/<NNN>-*.<status>.md`
-# carries a `**Type**: technical` body field per ADR-060 Phase 1 item 8b.
-#
-# Default `**Type**: technical` per ADR-060 line 92 (existing tickets
-# bulk-migrate to default; per-ticket judgement comes later via
-# capture-problem AskUserQuestion in item 8c — out of scope here).
-#
-# Usage:
-#   migrate-problems-add-type.sh [--apply] [<problems-dir>]
-#
-# Default <problems-dir> is ./docs/problems.
-#
-# Modes:
-#   diagnose (default): read-only. Lists each ticket needing migration on
-#     stdout (one per line, basename only). Exit 0 = clean, 1 = drift.
-#   --apply: writes `**Type**: technical` after the LAST present body
-#     field marker in {Status, Reported, Priority, Effort, WSJF}.
-#     Idempotent — re-running with Type already present is a no-op.
-#
-# Exit codes:
-#   0 = clean (diagnose: no migration needed; apply: completed)
-#   1 = drift (diagnose only; tickets needing migration listed)
-#   2 = parse error
-#
-# Tickets with NO recognisable header field markers are skipped with a
-# `SKIP <basename>` warning on stderr — these are typically malformed
-# scaffold leftovers and should not be auto-migrated.
-#
-# @problem P170 (Slice 4 B7.T2 / item 8b)
-# @adr ADR-060 (type-tag schema; default `technical`; spec line 91 amended
-#   2026-05-06: header field block in body, NOT YAML frontmatter)
-# @adr ADR-014 (one bounded sub-task per script)
-
-set -uo pipefail
-
-APPLY=0
-PROBLEMS_DIR=""
-
-for arg in "$@"; do
-  case "$arg" in
-    --apply) APPLY=1 ;;
-    -*) echo "PARSE_ERROR: unknown flag: $arg" >&2; exit 2 ;;
-    *)
-      if [ -z "$PROBLEMS_DIR" ]; then
-        PROBLEMS_DIR="$arg"
-      else
-        echo "PARSE_ERROR: multiple positional args: $arg" >&2
-        exit 2
-      fi
-      ;;
-  esac
-done
-
-PROBLEMS_DIR="${PROBLEMS_DIR:-docs/problems}"
-
-if [ ! -d "$PROBLEMS_DIR" ]; then
-  echo "PARSE_ERROR: problems-dir not found: $PROBLEMS_DIR" >&2
-  exit 2
-fi
-
-drift=0
-shopt -s nullglob
-for f in "$PROBLEMS_DIR"/[0-9][0-9][0-9]-*.open.md \
-         "$PROBLEMS_DIR"/[0-9][0-9][0-9]-*.known-error.md \
-         "$PROBLEMS_DIR"/[0-9][0-9][0-9]-*.verifying.md \
-         "$PROBLEMS_DIR"/[0-9][0-9][0-9]-*.parked.md \
-         "$PROBLEMS_DIR"/[0-9][0-9][0-9]-*.closed.md; do
-  base="$(basename "$f")"
-
-  # Idempotency check: any line matching `**Type**: <value>` in the
-  # first 30 lines counts as already-migrated.
-  if head -n 30 "$f" | grep -q '^\*\*Type\*\*:'; then
-    continue
-  fi
-
-  # Find the LAST body-field marker line (Status / Reported / Priority /
-  # Effort / WSJF) in the first 30 lines. Insertion anchor.
-  anchor=$(head -n 30 "$f" \
-    | grep -n -E '^\*\*(Status|Reported|Priority|Effort|WSJF)\*\*:' \
-    | tail -1 | cut -d: -f1)
-
-  if [ -z "$anchor" ]; then
-    echo "SKIP $base (no recognisable header field markers)" >&2
-    continue
-  fi
-
-  drift=1
-
-  if [ "$APPLY" -eq 0 ]; then
-    echo "$base"
-    continue
-  fi
-
-  # Apply: insert `**Type**: technical` after line $anchor.
-  # Use a temp file for atomic replace.
-  tmp=$(mktemp)
-  awk -v anchor="$anchor" '
-    NR == anchor { print; print "**Type**: technical"; next }
-    { print }
-  ' "$f" > "$tmp"
-  mv "$tmp" "$f"
-done
-shopt -u nullglob
-
-if [ "$APPLY" -eq 1 ]; then
-  exit 0
-fi
-
-if [ "$drift" -eq 1 ]; then
-  exit 1
-fi
-
-exit 0

package/scripts/test/catchup-scan.bats

@@ -1,274 +0,0 @@
-#!/usr/bin/env bats
-
-# Behavioural test for packages/itil/scripts/catchup-scan.sh — the P080
-# Phase 2 `--catchup` worklist scanner. Exercises the script against a
-# synthetic `.verifying.md` / `.closed.md` fixture corpus and asserts on
-# its emitted worklist (stdout) + summary (stderr) — NOT on SKILL.md prose.
-# This is a genuinely behavioural test per ADR-052: it runs the target and
-# asserts on its outputs, covering acceptance criterion 6 (fixture +
-# idempotency assertion).
-#
-# Coverage:
-# - CATCHUP emitted for a post-fix ticket with `## Reported Upstream` and
-#   no lifecycle log entry for the target state.
-# - SKIP/already-logged (idempotency) for a ticket whose
-#   `## Upstream Lifecycle Updates` log already records the target state.
-# - Silent skip for tickets without a `## Reported Upstream` section.
-# - SKIP/out-of-band for out-of-band / mailbox disclosure paths.
-# - Open / Known-Error / Parked tickets are out of the catchup corpus.
-# - Dual-tolerant flat-layout AND per-state subdir layout (RFC-002).
-# - --ticket restricts the scan; bad args / missing dir error cleanly.
-#
-# @problem P080 (Phase 2 --catchup)
-# @adr ADR-052 (behavioural-tests default)
-
-setup() {
-  REPO_ROOT="$(cd "$(dirname "$BATS_TEST_FILENAME")/../../../.." && pwd)"
-  SCRIPT="$REPO_ROOT/packages/itil/scripts/catchup-scan.sh"
-  FIX="$BATS_TEST_TMPDIR/problems"
-  mkdir -p "$FIX"
-}
-
-# Write a ticket with a `## Reported Upstream` section. Args:
-#   $1 = filename (relative to $FIX)
-#   $2 = upstream URL (or "" for none)
-#   $3 = disclosure path text
-make_reported_ticket() {
-  local path="$FIX/$1" url="$2" disclosure="$3"
-  mkdir -p "$(dirname "$path")"
-  {
-    echo "# Problem: fixture"
-    echo ""
-    echo "**Status**: fixture"
-    echo ""
-    echo "## Reported Upstream"
-    echo ""
-    [ -n "$url" ] && echo "- **URL**: $url"
-    echo "- **Reported**: 2026-01-01"
-    echo "- **Disclosure path**: $disclosure"
-  } > "$path"
-}
-
-# Append an `## Upstream Lifecycle Updates` log entry recording a target.
-append_lifecycle_log() {
-  local path="$FIX/$1" transition="$2"
-  {
-    echo ""
-    echo "## Upstream Lifecycle Updates"
-    echo ""
-    echo "- **2026-02-02** — $transition"
-    echo "  - **Disclosure path**: posted-comment"
-  } >> "$path"
-}
-
-# Write a ticket carrying an inbound `**Origin**: inbound-reported (<ref>)`
-# field (ADR-076) — the INBOUND surface. Args:
-#   $1 = filename (relative to $FIX)
-#   $2 = origin-paren content (e.g. "#63", "bbstats#195", "relayed from other projects")
-make_inbound_ticket() {
-  local path="$FIX/$1" ref="$2"
-  mkdir -p "$(dirname "$path")"
-  {
-    echo "# Problem: inbound fixture"
-    echo ""
-    echo "**Status**: fixture"
-    echo "**Origin**: inbound-reported ($ref)"
-    echo ""
-    echo "## Description"
-    echo ""
-    echo "fixture body"
-  } > "$path"
-}
-
-@test "catchup-scan: emits CATCHUP for a closed ticket with Reported Upstream and no lifecycle log" {
-  make_reported_ticket "113-foo.closed.md" "https://github.com/o/r/issues/5" "public issue"
-  run bash "$SCRIPT" --problems-dir "$FIX"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"CATCHUP P113 https://github.com/o/r/issues/5 state=closed transition=Verifying->Closed"* ]]
-}
-
-@test "catchup-scan: emits CATCHUP for a verifying ticket with the KE->Verifying transition" {
-  make_reported_ticket "090-bar.verifying.md" "https://github.com/o/r/issues/9" "public issue"
-  run bash "$SCRIPT" --problems-dir "$FIX"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"CATCHUP P090 https://github.com/o/r/issues/9 state=verifying transition=KE->Verifying"* ]]
-}
-
-@test "catchup-scan: idempotency — SKIP/already-logged when log records the target state (closed)" {
-  make_reported_ticket "113-foo.closed.md" "https://github.com/o/r/issues/5" "public issue"
-  append_lifecycle_log "113-foo.closed.md" "Verification Pending → Closed"
-  run bash "$SCRIPT" --problems-dir "$FIX"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"SKIP    P113 https://github.com/o/r/issues/5 reason=already-logged"* ]]
-  [[ "$output" != *"CATCHUP P113"* ]]
-}
-
-@test "catchup-scan: idempotency — SKIP/already-logged when log records the target state (verifying)" {
-  make_reported_ticket "090-bar.verifying.md" "https://github.com/o/r/issues/9" "public issue"
-  append_lifecycle_log "090-bar.verifying.md" "Known Error → Verification Pending"
-  run bash "$SCRIPT" --problems-dir "$FIX"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"SKIP    P090 https://github.com/o/r/issues/9 reason=already-logged"* ]]
-  [[ "$output" != *"CATCHUP P090"* ]]
-}
-
-@test "catchup-scan: idempotency is re-run-safe — a logged closed ticket alongside a fresh one" {
-  make_reported_ticket "113-done.closed.md" "https://github.com/o/r/issues/5" "public issue"
-  append_lifecycle_log "113-done.closed.md" "Verification Pending → Closed"
-  make_reported_ticket "114-fresh.closed.md" "https://github.com/o/r/issues/6" "public issue"
-  run bash "$SCRIPT" --problems-dir "$FIX"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"SKIP    P113 https://github.com/o/r/issues/5 reason=already-logged"* ]]
-  [[ "$output" == *"CATCHUP P114 https://github.com/o/r/issues/6"* ]]
-}
-
-@test "catchup-scan: silently skips tickets with no Reported Upstream section" {
-  mkdir -p "$FIX"
-  printf '# Problem\n\n**Status**: Closed\n\nNo upstream link here.\n' > "$FIX/200-nolink.closed.md"
-  run bash "$SCRIPT" --problems-dir "$FIX"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"P200"* ]]
-}
-
-@test "catchup-scan: SKIP/out-of-band for a mailbox / out-of-band disclosure path" {
-  make_reported_ticket "150-sec.closed.md" "" "drafted-and-saved (mailbox / out-of-band)"
-  run bash "$SCRIPT" --problems-dir "$FIX"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"SKIP    P150"* ]]
-  [[ "$output" == *"reason=out-of-band"* ]]
-}
-
-@test "catchup-scan: Open / Known-Error / Parked tickets are out of the catchup corpus" {
-  make_reported_ticket "300-open.open.md" "https://github.com/o/r/issues/3" "public issue"
-  make_reported_ticket "301-ke.known-error.md" "https://github.com/o/r/issues/4" "public issue"
-  make_reported_ticket "302-park.parked.md" "https://github.com/o/r/issues/7" "public issue"
-  run bash "$SCRIPT" --problems-dir "$FIX"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"P300"* ]]
-  [[ "$output" != *"P301"* ]]
-  [[ "$output" != *"P302"* ]]
-}
-
-@test "catchup-scan: dual-tolerant — per-state subdir layout (RFC-002) is scanned" {
-  make_reported_ticket "closed/113-sub.md" "https://github.com/o/r/issues/8" "public issue"
-  run bash "$SCRIPT" --problems-dir "$FIX"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"CATCHUP P113 https://github.com/o/r/issues/8 state=closed transition=Verifying->Closed"* ]]
-}
-
-@test "catchup-scan: --ticket restricts the scan to one ticket" {
-  make_reported_ticket "113-foo.closed.md" "https://github.com/o/r/issues/5" "public issue"
-  make_reported_ticket "114-bar.closed.md" "https://github.com/o/r/issues/6" "public issue"
-  run bash "$SCRIPT" --problems-dir "$FIX" --ticket P114
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"CATCHUP P114"* ]]
-  [[ "$output" != *"P113"* ]]
-}
-
-@test "catchup-scan: SUMMARY line reports counts on stderr" {
-  make_reported_ticket "113-foo.closed.md" "https://github.com/o/r/issues/5" "public issue"
-  make_reported_ticket "114-bar.closed.md" "https://github.com/o/r/issues/6" "public issue"
-  append_lifecycle_log "114-bar.closed.md" "Verification Pending → Closed"
-  run bash -c "bash '$SCRIPT' --problems-dir '$FIX' 2>&1 1>/dev/null"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"SUMMARY scanned=2 catchup=1 skip-logged=1 skip-out-of-band=0"* ]]
-}
-
-@test "catchup-scan: missing problems-dir exits 1 with error" {
-  run bash "$SCRIPT" --problems-dir "$BATS_TEST_TMPDIR/does-not-exist"
-  [ "$status" -eq 1 ]
-  [[ "$output" == *"ERROR"* ]]
-}
-
-@test "catchup-scan: unknown argument exits 1" {
-  run bash "$SCRIPT" --bogus
-  [ "$status" -eq 1 ]
-  [[ "$output" == *"ERROR"* ]]
-}
-
-@test "catchup-scan: --help prints usage and exits 0" {
-  run bash "$SCRIPT" --help
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"Usage:"* ]]
-  [[ "$output" == *"--catchup"* ]] || [[ "$output" == *"catchup-scan"* ]]
-}
-
-# ── Inbound direction (P376) ────────────────────────────────────────────────
-# The scanner must ALSO enumerate inbound-reported tickets (`**Origin**:
-# inbound-reported (#NN)`, ADR-076) so the maintainer no longer hand-greps
-# them after each catchup run. Direction-tagged so the worklist stays
-# unambiguous; idempotency re-checks the `(inbound)`-tagged lifecycle log.
-
-@test "catchup-scan: emits inbound CATCHUP for a verifying ticket with Origin inbound-reported (KE->Verifying)" {
-  make_inbound_ticket "220-inbound.verifying.md" "#63"
-  run bash "$SCRIPT" --problems-dir "$FIX"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"CATCHUP P220 inbound-#63 state=verifying transition=KE->Verifying direction=inbound"* ]]
-}
-
-@test "catchup-scan: emits inbound CATCHUP for a closed ticket with Origin inbound-reported (Verifying->Closed)" {
-  make_inbound_ticket "211-inbound.closed.md" "#97"
-  run bash "$SCRIPT" --problems-dir "$FIX"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"CATCHUP P211 inbound-#97 state=closed transition=Verifying->Closed direction=inbound"* ]]
-}
-
-@test "catchup-scan: inbound idempotency — SKIP/already-logged when an (inbound)-tagged log records the target" {
-  make_inbound_ticket "220-inbound.verifying.md" "#63"
-  append_lifecycle_log "220-inbound.verifying.md" "Known Error → Verification Pending (inbound)"
-  run bash "$SCRIPT" --problems-dir "$FIX"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"SKIP    P220 inbound-#63 reason=already-logged"* ]]
-  [[ "$output" != *"CATCHUP P220"* ]]
-}
-
-@test "catchup-scan: inbound idempotency does NOT match an outbound-tagged log for the same target" {
-  # A Closed log entry without (inbound) is the outbound leg's marker; the
-  # inbound leg must still emit CATCHUP (its own verdict was never posted).
-  make_inbound_ticket "228-inbound.closed.md" "#42"
-  append_lifecycle_log "228-inbound.closed.md" "Verification Pending → Closed"
-  run bash "$SCRIPT" --problems-dir "$FIX"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"CATCHUP P228 inbound-#42 state=closed transition=Verifying->Closed direction=inbound"* ]]
-}
-
-@test "catchup-scan: non-actionable Origin (no #NN) emits no inbound line" {
-  make_inbound_ticket "300-relayed.verifying.md" "relayed from other projects"
-  run bash "$SCRIPT" --problems-dir "$FIX"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"P300"* ]]
-}
-
-@test "catchup-scan: cross-repo inbound ref is preserved in the worklist line" {
-  make_inbound_ticket "250-xrepo.closed.md" "bbstats#195"
-  run bash "$SCRIPT" --problems-dir "$FIX"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"CATCHUP P250 inbound-bbstats#195 state=closed transition=Verifying->Closed direction=inbound"* ]]
-}
-
-@test "catchup-scan: a ticket with BOTH surfaces emits an outbound AND an inbound line" {
-  make_reported_ticket "330-both.closed.md" "https://github.com/o/r/issues/5" "public issue"
-  printf '**Origin**: inbound-reported (#71)\n' >> "$FIX/330-both.closed.md"
-  run bash "$SCRIPT" --problems-dir "$FIX"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"CATCHUP P330 https://github.com/o/r/issues/5 state=closed transition=Verifying->Closed"* ]]
-  [[ "$output" == *"CATCHUP P330 inbound-#71 state=closed transition=Verifying->Closed direction=inbound"* ]]
-}
-
-@test "catchup-scan: inbound worklist line stays within the ADR-038 150-byte budget" {
-  make_inbound_ticket "999-long.closed.md" "averylongupstreamreponame/withdeepsubpath#123456"
-  run bash "$SCRIPT" --problems-dir "$FIX"
-  [ "$status" -eq 0 ]
-  line="$(printf '%s\n' "$output" | grep '^CATCHUP P999')"
-  [ -n "$line" ]
-  [ "${#line}" -le 150 ]
-}
-
-@test "catchup-scan: inbound-only Open/Known-Error tickets are out of the catchup corpus" {
-  make_inbound_ticket "400-open.open.md" "#12"
-  make_inbound_ticket "401-ke.known-error.md" "#13"
-  run bash "$SCRIPT" --problems-dir "$FIX"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"P400"* ]]
-  [[ "$output" != *"P401"* ]]
-}