@windyroad/itil 0.61.1 → 0.61.2

package/skills/manage-problem/test/manage-problem-git-mv-restage-reminder.bats

@@ -1,48 +0,0 @@
-#!/usr/bin/env bats
-# Doc-lint guard: manage-problem SKILL.md must document the re-stage-after-Edit
-# requirement for every `git mv` block that is followed by a content edit.
-#
-# Structural assertion — Permitted Exception to the source-grep ban (ADR-005 / P011).
-# The tests assert that the skill specification document warns authors that
-# `git mv` alone stages only the rename, and subsequent Edit-tool modifications
-# must be re-staged explicitly (`git add <new>`) before commit — otherwise the
-# commit captures a rename-only change and the content edit leaks into the
-# next commit, corrupting the audit trail (P054 / P046 incident, 2026-04-19).
-#
-# Cross-reference:
-#   P057: docs/problems/057-git-mv-plus-edit-staging-ordering-trap.*.md
-#   ADR-014: docs/decisions/014-governance-skills-commit-their-own-work.proposed.md
-#   ADR-022: docs/decisions/022-problem-lifecycle-verification-pending-status.proposed.md
-#   @jtbd JTBD-002 (ship with confidence — audit trail)
-#   @jtbd JTBD-006 (progress the backlog while I'm away — audit trail)
-
-setup() {
-  TEST_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")" && pwd)"
-  REPO_ROOT="$(cd "${TEST_DIR}/../../../../.." && pwd)"
-  SKILL_FILE="${REPO_ROOT}/packages/itil/skills/manage-problem/SKILL.md"
-}
-
-@test "manage-problem SKILL.md exists (P057 precondition)" {
-  [ -f "$SKILL_FILE" ]
-}
-
-@test "manage-problem SKILL.md warns that git mv stages only the rename (P057)" {
-  # The document must explicitly state that `git mv` stages the rename into
-  # the index but does NOT pick up subsequent Edit-tool content changes.
-  run grep -inE "git mv.*(only the rename|rename only|not .*content|stages only)" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "manage-problem SKILL.md instructs re-staging the renamed file after Edit (P057)" {
-  # Authors must be told to run `git add <new>` (or equivalent) after editing
-  # the renamed file, before commit.
-  run grep -inE "re-stage|re‑stage|\`git add\`.*after|after.*\`git add\`|git add <new>|git add .*\.verifying\.md|git add .*\.known-error\.md" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "manage-problem SKILL.md cites P057 on the re-stage requirement (P057)" {
-  # Traceability: the new guidance must cite P057 so reviewers can chase
-  # the fix back to the incident that motivated it.
-  run grep -n "P057" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}

package/skills/manage-problem/test/manage-problem-id-collision-guard.bats

@@ -1,39 +0,0 @@
-#!/usr/bin/env bats
-# Doc-lint guard: manage-problem SKILL.md step 3 (Assign the next ID) must
-# include the next-ID collision guard against origin per ADR-019
-# confirmation criterion 2.
-#
-# Structural assertion — Permitted Exception to the source-grep ban (ADR-005 / P011).
-# These tests assert that the skill specification document instructs the
-# orchestrator to compare next-ID against origin/<base> before assigning,
-# so parallel sessions don't produce colliding ticket numbers.
-#
-# Cross-reference:
-#   P043 (next-ID collision guard in ticket-creator skills)
-#   P040 (work-problems does not fetch origin before starting — sibling)
-#   ADR-019 (AFK orchestrator preflight, including next-ID guard)
-#   @jtbd JTBD-006 (Progress the Backlog While I'm Away)
-
-setup() {
-  SKILL_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)"
-  SKILL_FILE="${SKILL_DIR}/SKILL.md"
-}
-
-@test "SKILL.md cites ADR-019 (next-ID collision guard)" {
-  run grep -n "ADR-019" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md step 3 references git ls-tree origin for next-ID lookup" {
-  # ADR-019 mechanism: the orchestrator MUST re-check next-ID assignment
-  # against `git ls-tree origin/<base>` before creating any new ticket.
-  run grep -n "git ls-tree origin" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md mentions taking the max of local and origin IDs" {
-  # The guard logic is: take the max of local-max-ID and origin-max-ID,
-  # then increment. Skill must mention this combination.
-  run grep -niE "max of (the )?(two|local and origin)|max\(.*origin" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}

package/skills/manage-problem/test/manage-problem-list-forwarder.bats

@@ -1,66 +0,0 @@
-#!/usr/bin/env bats
-# Contract assertions for manage-problem's `list` subcommand forwarder (P071 split slice 1).
-#
-# Per ADR-010 amended (Skill Granularity section) + P071 phased plan:
-# `/wr-itil:manage-problem list` delegates to the new `/wr-itil:list-problems`
-# skill via a thin-router forwarder. Original skill carries
-# `deprecated-arguments: true` frontmatter; forwarder emits a
-# canonical one-line systemMessage deprecation notice.
-#
-# Structural assertion — Permitted Exception to the source-grep ban
-# (ADR-005 / P011 / ADR-037 contract-assertion pattern).
-#
-# @problem P071
-# @jtbd JTBD-001 (enforce governance without slowing down)
-# @jtbd JTBD-101 (extend the suite with clear patterns)
-#
-# Cross-reference:
-#   P071: docs/problems/071-argument-based-skill-subcommands-are-not-discoverable.open.md
-#   ADR-010 amended — split naming + forwarder contract + deprecated-arguments flag
-#   ADR-013 Rule 1 — structured user interaction (forwarder emits systemMessage, not AskUserQuestion)
-#   ADR-037 — contract-assertion bats pattern
-
-setup() {
-  SKILL_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)"
-  SKILL_FILE="${SKILL_DIR}/SKILL.md"
-}
-
-@test "manage-problem SKILL.md frontmatter has deprecated-arguments: true (ADR-010 amended)" {
-  # ADR-010 amendment pins the frontmatter flag name as `deprecated-arguments`.
-  # The host skill of any forwarder route must carry this flag so ADR-037
-  # cross-plugin contract assertions can find the opt-in during the
-  # deprecation window.
-  run grep -nE "^deprecated-arguments:[[:space:]]*true[[:space:]]*$" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "manage-problem Step 1 forwards 'list' argument to /wr-itil:list-problems (P071)" {
-  # The forwarder names the target skill explicitly so the router is legible
-  # at the contract level. ADR-010's canonical shape: "invokes the new
-  # named skill via the Skill tool, not via re-prompting the user".
-  run grep -inE "/wr-itil:list-problems" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "manage-problem Step 1 emits the canonical deprecation notice (ADR-010 amended)" {
-  # ADR-010's canonical deprecation-notice template:
-  # "/wr-<plugin>:<old> <arg> is deprecated; use /wr-<plugin>:<new>
-  #  directly. This forwarder will be removed in <plugin>'s next major
-  #  version."
-  # The notice MUST be emitted as a systemMessage (not AskUserQuestion)
-  # because deprecation is informational, not decisional (ADR-013 Rule 1
-  # structured-interaction scope).
-  run grep -inE "is deprecated.*use /wr-itil:list-problems|deprecated.*list-problems|removed in .* next major version" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "manage-problem Step 1 forwarder does not re-implement the list logic (P071 regression guard)" {
-  # The forwarder must not duplicate the list logic — it must delegate.
-  # Per ADR-010: "thin-router forwarder re-invokes the new named skill
-  # via the Skill tool". If the forwarder grows its own scan logic, the
-  # deprecation window will harden into a permanent fork. Guard against
-  # this by asserting the forwarder block mentions "delegate" or
-  # "Skill tool" language near the list-problems reference.
-  run grep -inE "delegate.*list-problems|Skill tool.*list-problems|list-problems.*Skill tool" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}

package/skills/manage-problem/test/manage-problem-next-id-origin-lookup.bats

@@ -1,50 +0,0 @@
-#!/usr/bin/env bats
-# Doc-lint guard: manage-problem SKILL.md Step 3 origin-max lookup must use
-# `git ls-tree --name-only` to avoid false-matching blob SHA digits (P056).
-#
-# Structural assertion — Permitted Exception to the source-grep ban
-# (ADR-005 / P011). Default `git ls-tree` output shape is
-# `<mode> <type> <sha>\t<path>`. A `grep -oE '[0-9]{3}'` over that line
-# can match digits inside the 40-char blob SHA and return a wrong
-# `origin_max` (observed 997 on 2026-04-20 when opening P055). `--name-only`
-# drops mode/type/SHA columns leaving only the path, restoring the
-# invariant ADR-019 and P043 presume.
-#
-# Cross-reference:
-#   P056: docs/problems/056-ticket-creator-next-id-lookup-blob-sha-false-match.*.md
-#   P043 (closed): next-ID collision guard in ticket-creator skills
-#   ADR-019: docs/decisions/019-afk-orchestrator-preflight.*.md
-#   @jtbd JTBD-002 (ship with confidence — audit trail)
-#   @jtbd JTBD-006 (progress the backlog while I'm away — collision-free IDs)
-
-setup() {
-  TEST_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")" && pwd)"
-  REPO_ROOT="$(cd "${TEST_DIR}/../../../../.." && pwd)"
-  SKILL_FILE="${REPO_ROOT}/packages/itil/skills/manage-problem/SKILL.md"
-}
-
-@test "manage-problem SKILL.md exists (P056 precondition)" {
-  [ -f "$SKILL_FILE" ]
-}
-
-@test "manage-problem SKILL.md origin-max lookup uses git ls-tree --name-only (P056)" {
-  # The fix: `git ls-tree --name-only` drops mode/type/SHA columns so the
-  # digit-extraction regex cannot match SHA hex runs.
-  run grep -nE "git ls-tree --name-only .* docs/problems" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "manage-problem SKILL.md does not keep the buggy bare git ls-tree pattern (P056)" {
-  # Regression guard: `git ls-tree <ref> docs/problems/` without `--name-only`
-  # piped directly into a digit regex is the bug. Any remaining pipeline of
-  # this shape in a bash code block is a regression.
-  run grep -nE "git ls-tree [^-].* docs/problems/ .*\| *grep -oE '\[0-9\]\{3\}'" "$SKILL_FILE"
-  [ "$status" -ne 0 ]
-}
-
-@test "manage-problem SKILL.md cites P056 on the origin-max fix (P056)" {
-  # Traceability: the fix must cite P056 so reviewers can chase the
-  # correction back to the incident that motivated it.
-  run grep -n "P056" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}

package/skills/manage-problem/test/manage-problem-no-prose-options.bats

@@ -1,74 +0,0 @@
-#!/usr/bin/env bats
-# Doc-lint guard: manage-problem SKILL.md must not contain prose option prompts.
-#
-# Structural assertion — Permitted Exception to the source-grep ban (ADR-005 / P011).
-# These tests do not assert hook behaviour; they assert that the skill specification
-# document conforms to the structured-interaction contract.
-#
-# Cross-reference:
-#   ADR-013 Confirmation criterion (docs/decisions/013-structured-user-interaction-for-governance-decisions.proposed.md)
-#   P021 investigation task: "add a BATS or doc-lint test that fails if the skill contains prose option patterns"
-#   @jtbd JTBD-001 (enforce governance without slowing down)
-#   @jtbd JTBD-101 (extend the suite with clear patterns)
-
-setup() {
-  SKILL_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)"
-  SKILL_FILE="${SKILL_DIR}/SKILL.md"
-}
-
-@test "SKILL.md exists and has frontmatter" {
-  [ -f "$SKILL_FILE" ]
-  run head -1 "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  [ "$output" = "---" ]
-}
-
-@test "SKILL.md does not contain 'Your call:' prose option prompt" {
-  # ADR-013 Rule 1: all decision branch points must use AskUserQuestion, not prose.
-  # 'Your call:' is the canonical unstructured prompt observed in P021 (risk-scorer image #3).
-  run grep -n "Your call:" "$SKILL_FILE"
-  [ "$status" -ne 0 ]   # grep exits 1 when no match — that IS the pass condition
-}
-
-@test "SKILL.md does not contain freestanding 'Options: (a)' prose list" {
-  # ADR-013 Rule 1: prose option lists must not appear as skill instructions.
-  # Pattern: 'Options: (a)' as an instruction to Claude to present unstructured choices.
-  # Note: 'Would you like to: (a)' in AskUserQuestion examples is a different pattern
-  # and is NOT matched by this assertion.
-  run grep -n "Options: (a)" "$SKILL_FILE"
-  [ "$status" -ne 0 ]
-}
-
-@test "SKILL.md does not contain 'which way?' prose branch prompt" {
-  # ADR-013 Confirmation criterion lists 'which way?' as a prohibited prose prompt.
-  run grep -n "which way?" "$SKILL_FILE"
-  [ "$status" -ne 0 ]
-}
-
-@test "SKILL.md mandates AskUserQuestion for work-next selection (WSJF tie-break)" {
-  # ADR-013 Rule 1: the step 9c work-selection branch must use AskUserQuestion,
-  # not a prose '(a)/(b)/(c)' list. This is a regression guard — if step 9c is
-  # edited and the AskUserQuestion mandate is removed, this test catches it.
-  # P021 investigation task: manage-problem WSJF tie → assert AskUserQuestion.
-  run grep -n "AskUserQuestion" "$SKILL_FILE"
-  [ "$status" -eq 0 ]   # file MUST reference AskUserQuestion
-}
-
-@test "SKILL.md mandates AskUserQuestion for scope-change decisions during work" {
-  # ADR-013 Rule 1: the 'Scope expansion during work' branch must use AskUserQuestion.
-  # 'Scope change' is the header text used in the AskUserQuestion call for scope decisions
-  # (per P021 amendment). Regression guard.
-  run grep -n "Scope change" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md step 9d requires fix summary extracted from Fix Released in AskUserQuestion (P030)" {
-  # P030: verification prompts must include a one-line fix summary extracted from the
-  # '## Fix Released' section so the user can answer without a clarifying round-trip.
-  # This checks that step 9d explicitly instructs including fix content in the question,
-  # not just detecting Fix Released to decide which problems need verification.
-  # The fix must add wording like "extract" or "include" + "Fix Released" + "summary"
-  # (or "question") within step 9d. A generic "Fix Released" mention is insufficient.
-  run grep -n "fix summary\|Fix Released.*question\|Fix Released.*summary\|extract.*Fix Released\|include.*Fix Released\|summary.*Fix Released" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}

package/skills/manage-problem/test/manage-problem-output-formatting.bats

@@ -1,30 +0,0 @@
-#!/usr/bin/env bats
-# Doc-lint guard: manage-problem SKILL.md must include the output formatting rule
-# requiring human-readable titles alongside bare IDs (P032).
-#
-# Structural assertion — Permitted Exception to the source-grep ban (ADR-005 / P011).
-# These tests assert that the skill specification document contains the output
-# formatting instruction so agents include titles with IDs in prose output.
-#
-# Cross-reference:
-#   P032 (agent output uses opaque IDs without titles)
-#   @jtbd JTBD-001 (enforce governance without slowing down)
-
-setup() {
-  SKILL_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)"
-  SKILL_FILE="${SKILL_DIR}/SKILL.md"
-}
-
-@test "SKILL.md contains output formatting section" {
-  run grep -n "## Output Formatting" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md output formatting rule requires titles with IDs (P032)" {
-  # P032: agents must include human-readable titles when referencing IDs in prose.
-  # The rule must mention including the title alongside IDs.
-  run grep -n "title" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  run grep -n "Output Formatting" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}

package/skills/manage-problem/test/manage-problem-parked-and-cache.bats

@@ -1,73 +0,0 @@
-#!/usr/bin/env bats
-# Doc-lint guard: manage-problem SKILL.md must define the Parked lifecycle
-# status and the README.md fast-path cache for the `work` operation.
-#
-# Structural assertions — Permitted Exception to the source-grep ban (ADR-005 / P011).
-# These tests assert that the skill specification document conforms to the
-# P027 fix: first-class Parked status + README.md-based WSJF cache.
-#
-# Cross-reference:
-#   P027: docs/problems/027-manage-problem-work-flow-is-expensive.open.md
-#   @jtbd JTBD-001 (enforce governance without slowing down — under 60s)
-#   @jtbd JTBD-005 (invoke governance assessments on demand)
-
-setup() {
-  SKILL_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)"
-  SKILL_FILE="${SKILL_DIR}/SKILL.md"
-}
-
-# ──────────────────────────────────────────────────────────────────────────────
-# Parked lifecycle status
-# ──────────────────────────────────────────────────────────────────────────────
-
-@test "SKILL.md lifecycle table includes Parked status" {
-  # P027: Parked must be a first-class status so parked problems are
-  # auto-excluded from work selection without manual user flags each session.
-  run grep -q "Parked" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md defines .parked.md file suffix" {
-  # Parked problems need a distinct file suffix so the review step can
-  # identify and exclude them by filename pattern alone.
-  run grep -q "\.parked\.md" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md excludes parked problems from WSJF ranking" {
-  # Parked problems must not appear in the WSJF table — they are listed
-  # separately so users can see them but they don't pollute the ranking.
-  run grep -q "parked.*exclud\|exclud.*parked\|Parked.*exclud\|exclud.*Parked\|skip.*[Pp]arked\|[Pp]arked.*skip" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-# ──────────────────────────────────────────────────────────────────────────────
-# README.md cache (fast-path for `problem work`)
-# ──────────────────────────────────────────────────────────────────────────────
-
-@test "SKILL.md references README.md as the cache file" {
-  # P027: docs/problems/README.md is the WSJF cache written by review
-  # and read by work to skip the full re-scan when nothing changed.
-  run grep -q "README\.md" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md describes writing README.md after review" {
-  # The review step (9e) must write/overwrite README.md with the ranked table.
-  # Without this write, the cache never gets populated.
-  run grep -q "README\.md" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md describes checking README.md freshness using git history, not mtime" {
-  # P031: The mtime-based `find -newer` check is broken in git worktrees
-  # because all files receive the same mtime at checkout time.
-  # The cache-freshness check must use git log to compare commits, not
-  # filesystem timestamps.
-  # Positive: SKILL.md uses git log for cache freshness.
-  run grep -q "git log.*README\.md" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  # Negative: SKILL.md must NOT use find -newer for cache freshness.
-  run grep -q "\-newer" "$SKILL_FILE"
-  [ "$status" -ne 0 ]
-}

package/skills/manage-problem/test/manage-problem-readme-refresh-on-transition.bats

@@ -1,62 +0,0 @@
-#!/usr/bin/env bats
-
-# P062: manage-problem SKILL.md documents that every Step 7 status
-# transition refreshes docs/problems/README.md and stages it in the
-# same commit — including folded-fix commits that ride with `fix(...)`.
-#
-# Doc-lint structural test (Permitted Exception per ADR-005). Asserts
-# SKILL.md wording for the refresh block, the four transition scopes,
-# the folded-fix-commit case, the fast-path interaction, and the
-# Step 11 commit convention's stage-list requirement.
-
-setup() {
-  REPO_ROOT="$(cd "$(dirname "$BATS_TEST_FILENAME")/../../../../.." && pwd)"
-  SKILL_MD="$REPO_ROOT/packages/itil/skills/manage-problem/SKILL.md"
-}
-
-@test "manage-problem: SKILL.md contains the README.md refresh block (P062)" {
-  run grep -F 'README.md refresh on every transition (P062)' "$SKILL_MD"
-  [ "$status" -eq 0 ]
-}
-
-@test "manage-problem: the refresh block lists all four transition scopes" {
-  run grep -F 'Open → Known Error, Known Error → Verification Pending, Verification Pending → Closed, Parked' "$SKILL_MD"
-  [ "$status" -eq 0 ]
-}
-
-@test "manage-problem: the refresh block covers folded-fix commits explicitly" {
-  run grep -F '**Folded-fix commits**' "$SKILL_MD"
-  [ "$status" -eq 0 ]
-}
-
-@test "manage-problem: the refresh block says refresh is a render not a re-rank" {
-  run grep -F 'The refresh is a render, not a re-rank' "$SKILL_MD"
-  [ "$status" -eq 0 ]
-}
-
-@test "manage-problem: the refresh block stages README.md in the same commit" {
-  run grep -F 'git add docs/problems/README.md' "$SKILL_MD"
-  [ "$status" -eq 0 ]
-}
-
-@test "manage-problem: Step 11 commit convention requires README.md in the stage list on transitions (P062)" {
-  run grep -F 'stage list MUST include `docs/problems/README.md`' "$SKILL_MD"
-  [ "$status" -eq 0 ]
-}
-
-@test "manage-problem: Step 11 references Step 7's refresh block from the stage-list requirement" {
-  run grep -F "Step 7's \"README.md refresh on every transition\" block (P062)" "$SKILL_MD"
-  [ "$status" -eq 0 ]
-}
-
-@test "manage-problem: refresh block describes the fast-path interaction" {
-  run grep -F 'Fast-path interaction' "$SKILL_MD"
-  [ "$status" -eq 0 ]
-  run grep -F 'cache stays fresh by construction' "$SKILL_MD"
-  [ "$status" -eq 0 ]
-}
-
-@test "manage-problem: refresh block describes Last reviewed line update" {
-  run grep -F 'Update the "Last reviewed" line' "$SKILL_MD"
-  [ "$status" -eq 0 ]
-}