@windyroad/itil 0.61.1 → 0.61.2

package/skills/review-problems/test/jtbd-301-verdict-shape-contract.bats

@@ -1,225 +0,0 @@
-#!/usr/bin/env bats
-# Contract assertions for /wr-itil:review-problems Step 4.5d + Step 4.5e
-# verdict-shape ack-comment templates (P229 / JTBD-301).
-#
-# Structural assertions — Permitted Exception to the source-grep ban
-# per ADR-005 / P011 / ADR-037 / ADR-052 § Surface 2. SKILL.md prose
-# governs LLM-driven runtime behaviour; behavioural-replay testing
-# requires a synthetic agent harness (P012 master ticket; P176 follow-up
-# for the SKILL.md surface; P324 review-problems agent-prose harness gap).
-# Until that harness lands, contract bats assert the load-bearing
-# template elements are present so future edits don't silently strip
-# the JTBD-301 verdict vocabulary and re-introduce framework-vocab leakage.
-#
-# @problem P229
-# @problem P012 (master harness ticket — justification for structural exception)
-# @problem P176 (SKILL.md surface follow-up)
-# @problem P324 (review-problems agent-prose harness gap)
-# @jtbd JTBD-301 (verdict-shape acknowledgement contract — non-negotiable)
-# @adr ADR-024 (report-upstream contract — symmetry mirror)
-# @adr ADR-036 (downstream-scaffold contract — adopter inheritance)
-# @adr ADR-052 (behavioural-tests default + Permitted Exception)
-# @adr ADR-062 (inbound-discovery + assessment pipeline)
-
-setup() {
-  SKILL_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)"
-  SKILL_FILE="${SKILL_DIR}/SKILL.md"
-}
-
-# ──────────────────────────────────────────────────────────────────────────────
-# Verdict-shape contract subsection exists at the head of Step 4.5e
-# ──────────────────────────────────────────────────────────────────────────────
-
-@test "4.5e-comment-shape subsection exists (briefs JTBD-301 contract upstream of branch templates)" {
-  run grep -nE '^#### 4\.5e-comment-shape' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "verdict-shape subsection names all four JTBD-301 verdict words verbatim" {
-  # JTBD-301 Desired Outcome row 6 names exactly four verdicts.
-  # The subsection MUST name all four so a reader sees the vocabulary
-  # before reading the per-branch templates that implement it.
-  run grep -nE 'fix released' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  run grep -nE 'won.t-fix|won\\.t fix' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  run grep -nE 'duplicate' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  run grep -nE 'parked' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "verdict-shape subsection explicitly forbids framework-vocab leakage in ack-comment bodies" {
-  # Load-bearing rule: maintainer-internal jargon (Step IDs, branch
-  # names, classification tokens) MUST NOT appear in reporter-facing
-  # comment bodies. Audit-log at 4.5f keeps the tokens.
-  run grep -inE 'framework.vocab|maintainer.internal|reporter.facing' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "verdict-shape subsection cites the report-upstream symmetry (ADR-024 / ADR-036)" {
-  # JTBD-301 line 23 + ADR-024 / ADR-036 establish the inbound/outbound
-  # symmetry: outbound `/wr-itil:report-upstream` posts structured
-  # human-language; inbound ack mirrors that shape.
-  run grep -nE 'symmetry|mirror' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "verdict-shape subsection documents the C2 gate-substitution caveat (architect condition C2)" {
-  # The external-comms gate (ADR-028) fires on the SUBSTITUTED body,
-  # not the template — template authors must ensure no maintainer
-  # jargon leaks via P<NNN> title substitution or <reason> expansion.
-  run grep -inE 'substituted body|gate.fires.on.the.*substituted|template.author' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-# ──────────────────────────────────────────────────────────────────────────────
-# Step 4.5d — matched-local-ticket cross-reference uses verdict-shape
-# (duplicate verdict)
-# ──────────────────────────────────────────────────────────────────────────────
-
-@test "Step 4.5d cross-reference comment uses 'duplicate' verdict language" {
-  # Replaces the bureaucratic "Tracked locally as docs/problems/..." boilerplate
-  # with verdict-shape "we're tracking this as a duplicate of P<NNN>".
-  run grep -inE 'duplicate of P.NNN.|tracking.*duplicate' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "Step 4.5d cross-reference comment template is documented inline (not just referenced)" {
-  # SKILL prose must carry the actual template body so a single-pass
-  # reader sees the shape, not just a cross-reference to JTBD-301.
-  run grep -nE '4\.5d.*[Cc]omment template|matched-local-ticket.*template' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-# ──────────────────────────────────────────────────────────────────────────────
-# Step 4.5e Step 4 — above-threshold-pushback verdict template (won't-fix)
-# ──────────────────────────────────────────────────────────────────────────────
-
-@test "Step 4.5e Step 4 pushback template uses 'we don't plan to fix this' verdict language" {
-  run grep -inE "we don.t plan to fix|don.t plan to fix this" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-# ──────────────────────────────────────────────────────────────────────────────
-# Step 4.5e Step 5 — clear-malicious verdict template (policy-violation close)
-# Architect condition C4: name this as fifth implicit verdict, not conflated
-# with won't-fix
-# ──────────────────────────────────────────────────────────────────────────────
-
-@test "Step 4.5e Step 5 clear-malicious template uses 'we're closing this report' verdict language" {
-  run grep -inE "we.re closing this|closing this report" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "verdict-shape subsection names clear-malicious as fifth implicit verdict (architect C4)" {
-  # The four documented JTBD-301 verdicts are fix-released / parked /
-  # duplicate / won't-fix. clear-malicious is a stronger close
-  # (policy-violation) — name it precisely in the subsection prose
-  # rather than conflating with won't-fix.
-  run grep -inE 'policy.violation close|fifth.*verdict|implicit.*verdict' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "clear-malicious classification gloss is plain-language (JTBD non-blocking advisory)" {
-  # JTBD advisory: <classification> in the clear-malicious template
-  # MUST be a plain-language gloss, NOT the raw wr-risk-scorer verdict
-  # token. SKILL prose must specify this so the reporter sees
-  # human language, not "out-of-scope-for-documented-personas".
-  run grep -inE 'plain.language gloss|plain-language.*classification' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-# ──────────────────────────────────────────────────────────────────────────────
-# Step 4.5e Step 6 — safe-and-valid verdict template (accepted-into-backlog)
-# Architect condition C3: name as "accepted into backlog", not fix-released
-# ──────────────────────────────────────────────────────────────────────────────
-
-@test "Step 4.5e Step 6 safe-and-valid template uses 'we're tracking this as a real bug' verdict language" {
-  run grep -inE "tracking this as a real|tracking.*real bug" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "Step 4.5e Step 6 template does NOT include framework vocab 'safe-and-valid branch' in comment body" {
-  # The 31-comment leak: "classified via /wr-itil:review-problems Step
-  # 4.5e safe-and-valid branch with safe-low-fix-risk" appeared in
-  # comment bodies. The new template prose must show the reporter-facing
-  # body and not include the framework-vocab phrasing inside a comment-body block.
-  # Note: the steps section header itself names "Safe-and-valid branch" —
-  # that's the maintainer prose and fine. This test checks the COMMENT-BODY
-  # template (which lives in a fenced code block under Step 6) does not include
-  # the leak phrase "safe-low-fix-risk".
-  run grep -nE 'safe-low-fix-risk' "$SKILL_FILE"
-  # Token may appear in maintainer prose / classifier docs — but MUST NOT
-  # appear inside a fenced comment-body template block. We assert the token
-  # appears AT MOST in step-3 dual-axis-risk-classifier prose and the audit-log
-  # surface; not in a quoted comment template body. We use a structural proxy:
-  # the new 4.5e-comment-shape subsection MUST explicitly call out that the
-  # token belongs in maintainer-side audit-log only, not in the user-facing comment.
-  run grep -inE "safe-low-fix-risk.*audit.log only|safe.low.fix.risk.*maintainer.side" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "verdict-shape subsection names Step 6 verdict as 'accepted into backlog' (architect C3)" {
-  # JTBD-301 'fix released' is the post-release verdict — the Step 6
-  # ack fires at accept-into-backlog time. Name the verdict precisely
-  # in the subsection prose.
-  run grep -inE 'accepted into backlog|accept.into.backlog' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "Step 4.5e Step 6 template references release-notes / status surface for future updates" {
-  # JTBD-301 desired outcome: reporter knows where to watch for updates.
-  # The template must point to a stable surface (release notes / status
-  # page / linked issue) so the reporter has actionable expectation.
-  run grep -inE 'release notes|release-notes|watch this issue' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-# ──────────────────────────────────────────────────────────────────────────────
-# Architect condition A1 — gate-denial sub-branches preserved across all four
-# verdict-shape templates (no silent-skip regression)
-# ──────────────────────────────────────────────────────────────────────────────
-
-@test "All four ack-comment branches preserve gate-denial sub-branches (architect A1)" {
-  # Step 4 (pushback), Step 5 (clear-malicious), Step 6 (safe-and-valid)
-  # already have gate-denial sub-branches in the current SKILL. The
-  # P229 fix preserves them; this assertion catches a regression where
-  # a template rewrite accidentally drops the sub-branch.
-  run grep -nE 'gate-denied-pushback' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  run grep -nE 'gate-denied-clear-malicious' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  run grep -nE 'gate-denied-safe-and-valid' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-# ──────────────────────────────────────────────────────────────────────────────
-# Architect condition A2 — audit-log preserves classification tokens verbatim
-# ──────────────────────────────────────────────────────────────────────────────
-
-@test "Audit-log surface at 4.5f preserves classification tokens (architect A2)" {
-  # The user-side template change strips framework vocab from comment
-  # bodies; the audit-log surface (4.5f) MUST continue receiving the
-  # raw classification tokens for replay determinism per ADR-062.
-  run grep -nE '4\.5f.*[Aa]udit-log' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  run grep -nE 'safe-and-valid-local-ticket-created|above-threshold-pushback|clear-malicious-closed' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-# ──────────────────────────────────────────────────────────────────────────────
-# JTBD-301 vocabulary visibility — four-verdict words appear in branch templates
-# ──────────────────────────────────────────────────────────────────────────────
-
-@test "P229 root-cause ticket cross-referenced from verdict-shape subsection" {
-  # Audit-trail grounding per ADR-026: the SKILL prose change cites
-  # the originating ticket so the rationale stays discoverable.
-  run grep -nE 'P229' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "verdict-shape subsection cites JTBD-301 by ID" {
-  run grep -nE 'JTBD-301' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}

package/skills/review-problems/test/review-problems-contract.bats

@@ -1,235 +0,0 @@
-#!/usr/bin/env bats
-# Contract assertions for /wr-itil:review-problems (P071 split slice 2).
-#
-# This skill hosts the "re-assess every open / known-error problem,
-# auto-transition, fire the verification prompt, and rewrite the README
-# cache" user intent previously hidden behind /wr-itil:manage-problem
-# review. Unlike list-problems (slice 1, pure read-only) this skill
-# owns the README cache write and the auto-transition path, so it
-# requires the full governance tool surface (Write, Edit, Bash,
-# AskUserQuestion, Skill for the commit-gate fallback).
-#
-# Structural assertion — Permitted Exception to the source-grep ban
-# (ADR-005 / P011 / ADR-037 contract-assertion pattern).
-#
-# @problem P071
-# @jtbd JTBD-001 (enforce governance without slowing down — discoverable surface)
-# @jtbd JTBD-101 (extend the suite with clear patterns — one skill per distinct user intent)
-#
-# Cross-reference:
-#   P071: docs/problems/071-argument-based-skill-subcommands-are-not-discoverable.open.md
-#   ADR-010 amended (Skill Granularity section) — split naming + forwarder contract
-#   ADR-022 — Verification Pending status conventions (review-problems owns the queue prompt)
-#   ADR-014 — governance skills commit their own work
-#   ADR-015 — commit-gate delegation pattern
-#   ADR-037 — contract-assertion bats pattern
-
-setup() {
-  SKILL_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)"
-  SKILL_FILE="${SKILL_DIR}/SKILL.md"
-}
-
-@test "SKILL.md exists and has frontmatter" {
-  [ -f "$SKILL_FILE" ]
-  run head -1 "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  [ "$output" = "---" ]
-}
-
-@test "SKILL.md frontmatter name is wr-itil:review-problems (P071 + ADR-010 amended)" {
-  # Split naming convention per ADR-010 amendment: <verb>-<object> pair.
-  # The new skill's name must match the phased-landing plan pinned in P071.
-  run grep -n "^name: wr-itil:review-problems$" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md frontmatter description names the review intent (P071)" {
-  # Description must name "re-assess" or "review" + "problem" so
-  # Claude Code autocomplete surfaces the user intent rather than a
-  # generic name.
-  run grep -inE "^description:.*(re-assess|review).*problem|^description:.*problem.*(re-assess|review)" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md frontmatter allowed-tools includes Write + Edit (owns README refresh)" {
-  # Review owns the README cache write and auto-transition Edits.
-  # Unlike list-problems (pure read-only), this skill MUST carry Write
-  # and Edit so the commit gate contract from ADR-014 holds.
-  run grep -nE "^allowed-tools:.*Write" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  run grep -nE "^allowed-tools:.*Edit" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md frontmatter allowed-tools includes Skill (commit-gate fallback)" {
-  # Step 6 commit-gate fallback invokes /wr-risk-scorer:assess-release
-  # when the pipeline subagent is unavailable. That fallback requires
-  # the Skill tool per ADR-015.
-  run grep -nE "^allowed-tools:.*Skill" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md frontmatter allowed-tools includes AskUserQuestion (Verification prompt)" {
-  # Step 4 fires AskUserQuestion for every .verifying.md ticket per
-  # ADR-022. The AFK branch degrades gracefully (ADR-013 Rule 6) but
-  # the primary path requires the tool.
-  run grep -nE "^allowed-tools:.*AskUserQuestion" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md documents the re-scoring scan scope (P071)" {
-  # The skill reads .open.md and .known-error.md files and writes back
-  # Priority + Effort + WSJF. .verifying.md and .parked.md are NOT
-  # re-scored (multiplier 0) but are shown in dedicated sections.
-  # The SKILL.md must name all four glob patterns so the contract is legible.
-  run grep -inE "\.open\.md" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  run grep -inE "\.known-error\.md" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  run grep -inE "\.verifying\.md" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  run grep -inE "\.parked\.md" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md owns the README.md refresh write (P062 + ownership boundary)" {
-  # Review is the canonical writer of docs/problems/README.md. The
-  # sibling list-problems skill explicitly defers here. If this
-  # contract drifts (e.g. list-problems starts writing the README or
-  # review stops writing it), the fast-path cache goes stale.
-  run grep -inE "docs/problems/README\.md" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  run grep -inE "(rewrite|write[ /]+overwrite|refresh|rewrites).*README\.md|README\.md.*(rewrite|refresh|overwrite|write)" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md fires the Verification Queue prompt per ADR-022 (Step 4)" {
-  # Step 4 is the structured path that transitions Verification Pending
-  # → Closed. Without it, verifyings accumulate forever. The prompt
-  # MUST include a fix summary per ADR-022 (not just ID + title +
-  # version).
-  run grep -inE "Verification (Queue|Pending)|verifying\.md" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  run grep -inE "Fix Released|fix summary" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md declares the auto-transition path (Open → Known Error)" {
-  # Step 2.10 auto-transitions Open tickets with documented root cause
-  # + workaround to Known Error. This is a defining behaviour of the
-  # review skill; drift here means the backlog lingers in Open forever.
-  run grep -inE "Auto-transition|auto.transition|Open.+Known Error|known-error" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md satisfies the commit gate per ADR-014 + ADR-015" {
-  # Review is a governance skill per ADR-014: it commits its own work
-  # after satisfying the commit gate. Per ADR-015 the gate has two
-  # paths (primary subagent delegation + fallback assess-release
-  # skill). Both MUST be documented so P035 stays closed.
-  run grep -inE "wr-risk-scorer:pipeline|wr-risk-scorer:assess-release" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  run grep -inE "ADR-014|ADR-015" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md cites the P057 staging trap on auto-transitions" {
-  # Any git mv + Edit combo in this skill (Step 2.10 auto-transition,
-  # Step 4 verification close) MUST re-stage explicitly. P057
-  # codifies this; drift here means content edits leak into later
-  # commits.
-  run grep -inE "staging trap|P057|re-stage" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md reuses the RISK-POLICY.md risk framework (no hardcoded scale)" {
-  # Step 1 reads RISK-POLICY.md for the current Impact/Likelihood
-  # scales and label bands. Hardcoding a scale causes drift when the
-  # policy is amended (ISO 31000 alignment axis).
-  run grep -inE "RISK-POLICY\.md" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md cites P071 and ADR-010 amended (P071 + ADR-025)" {
-  # ADR-025 inheritance per ADR-037: contract-assertion bats should
-  # reflect traceability cites on the skill spec document.
-  run grep -inE "P071|ADR-010" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md does not carry a deprecated-arguments frontmatter flag (clean-split skill)" {
-  # Architect advisory: review-problems is a clean-split skill with no
-  # argument-subcommands itself. ADR-010 amendment's
-  # `deprecated-arguments: true` flag is only valid on host skills with
-  # forwarder routes — review-problems is the forwarder TARGET, not the
-  # host.
-  run grep -E "^deprecated-arguments:" "$SKILL_FILE"
-  [ "$status" -ne 0 ]
-}
-
-@test "SKILL.md does not use word-argument subcommand branching (P071 regression guard)" {
-  # The whole point of P071: Claude Code autocomplete does not surface
-  # arguments. A clean-split skill must not reintroduce word-arg
-  # subcommand routing. The SKILL.md must not contain `If arguments
-  # start with "list"` / `If arguments contain "work"` / etc. patterns.
-  run grep -inE "If arguments start with|If arguments contain" "$SKILL_FILE"
-  [ "$status" -ne 0 ]
-}
-
-@test "SKILL.md has a dependency-graph-traversal pass for transitive effort (P076)" {
-  # P076: review-problems is the executor for the WSJF transitive-effort
-  # rule. Step 2 assigns marginal effort; a second pass must walk
-  # `## Dependencies` edges and propagate effort per the canonical rule
-  # in /wr-itil:manage-problem's WSJF Prioritisation section. Without
-  # this pass, the marginal-only ranking mis-ranks dependent tickets
-  # above their blockers (the exact failure P076 documents).
-  run grep -inE "transitive[[:space:]]?effort|graph traversal|propagate.*effort|dependency[[:space:]-]?graph" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md transitive-effort pass cites P076 and the canonical rule location (traceability)" {
-  # Audit trail: the Step 2.5 block must cite P076 (motivation) and
-  # point to /wr-itil:manage-problem's WSJF section as the canonical
-  # definition — duplication would fork the contract.
-  run grep -n "P076" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  run grep -inE "manage-problem.*WSJF|WSJF.*manage-problem|canonical" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md transitive re-rate message format matches the canonical shape (P076)" {
-  # Architect correction 4: the re-rate message must be greppable and
-  # consistent across skills. Shape: `P<NNN>: Effort <OLD> → <NEW>
-  # (transitive via <UPSTREAM>)`. review-problems emits this in step 3's
-  # summary output so downstream audit tools can grep the review log.
-  run grep -inE "Effort.*→.*transitive via|transitive via.*P[0-9]" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-# --- P136 ADR-044 alignment: Step 4 close-on-evidence bucket routing ---
-# tdd-review: structural-permitted — P081 bridge per the P136 Fix Strategy.
-# Pins the Step 4 lazy-ask removal (close the evidence-backed subset
-# mechanically; ask only the unobserved subset) so a future reword cannot
-# silently revert to a per-ticket AskUserQuestion (the exact P136 regression
-# class). Behavioural retrofit owned by P081 Phase 2.
-
-@test "SKILL.md Step 4 closes the yes-observed subset on evidence without AskUserQuestion (P136 / ADR-044 + run-retro Step 4a)" {
-  run grep -inE "close-on-evidence" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  run grep -inE "Do NOT fire one .AskUserQuestion. per ticket" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  run grep -inE "ADR-044" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md Step 4 keeps the three-way split — ask no-not-observed, flip-back regressions (P136)" {
-  # Bucket 2 (no — not observed) still asks; Bucket 3 (no — observed
-  # regression) still flips back and is never batch-closed. Do not collapse
-  # the three-way routing to a two-way one (JTBD-201 audit-trail invariant).
-  run grep -inE "no — not observed" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  run grep -inE "no — observed regression" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  run grep -inE "flip-back" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}